[INFO] fetching crate xl 0.1.7... [INFO] linting xl-0.1.7 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate xl 0.1.7 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate xl 0.1.7 [INFO] finished tweaking crates.io crate xl 0.1.7 [INFO] tweaked toml for crates.io crate xl 0.1.7 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate xl 0.1.7 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate xl 0.1.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded quick-xml v0.22.0 [INFO] [stderr] Downloaded bzip2 v0.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1697aade39b8937f55f84d3d3ee83351876f000c7d62f2a87219a63c74e62d81 [INFO] running `Command { std: "docker" "start" "-a" "1697aade39b8937f55f84d3d3ee83351876f000c7d62f2a87219a63c74e62d81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1697aade39b8937f55f84d3d3ee83351876f000c7d62f2a87219a63c74e62d81", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1697aade39b8937f55f84d3d3ee83351876f000c7d62f2a87219a63c74e62d81", kill_on_drop: false }` [INFO] [stdout] 1697aade39b8937f55f84d3d3ee83351876f000c7d62f2a87219a63c74e62d81 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6c005599e3a07d375aa64450d345384ecd12a7ffb1f0c69068933824c0ebc0dc [INFO] running `Command { std: "docker" "start" "-a" "6c005599e3a07d375aa64450d345384ecd12a7ffb1f0c69068933824c0ebc0dc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking quick-xml v0.22.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking flate2 v1.0.20 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking bzip2 v0.4.3 [INFO] [stderr] Compiling thiserror-impl v1.0.26 [INFO] [stderr] Checking thiserror v1.0.26 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking xl v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `encoding` is never read [INFO] [stdout] --> src/wb.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct Workbook { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | encoding: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Workbook` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `relationship_id` and `sheet_id` are never read [INFO] [stdout] --> src/ws.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 85 | pub struct Worksheet { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | relationship_id: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 91 | sheet_id: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Worksheet` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless `fn main` in doctest [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | //! fn main () { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main [INFO] [stdout] = note: `#[warn(clippy::needless_doctest_main)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wb.rs:102:59 [INFO] [stdout] | [INFO] [stdout] 102 | fn go(&self) -> SheetNameOrNum { SheetNameOrNum::Name(*self) } [INFO] [stdout] | ^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wb.rs:310:45 [INFO] [stdout] | [INFO] [stdout] 310 | let zip_file = match fs::File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/wb.rs:344:16 [INFO] [stdout] | [INFO] [stdout] 344 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `file.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/wb.rs:344:16 [INFO] [stdout] | [INFO] [stdout] 344 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `(*file.name())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wb.rs:344:16 [INFO] [stdout] | [INFO] [stdout] 344 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `file.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/wb.rs:389:29 [INFO] [stdout] | [INFO] [stdout] 389 | / ... if att == "preserve" { [INFO] [stdout] 390 | | ... preserve_space = true; [INFO] [stdout] 391 | | ... } else { [INFO] [stdout] 392 | | ... preserve_space = false; [INFO] [stdout] 393 | | ... } [INFO] [stdout] | |_______________________^ help: you can reduce it to: `preserve_space = att == "preserve";` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `encoding` is never read [INFO] [stdout] --> src/wb.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct Workbook { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | encoding: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Workbook` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `relationship_id` and `sheet_id` are never read [INFO] [stdout] --> src/ws.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 85 | pub struct Worksheet { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | relationship_id: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 91 | sheet_id: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Worksheet` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless `fn main` in doctest [INFO] [stdout] --> src/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | //! fn main () { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_doctest_main [INFO] [stdout] = note: `#[warn(clippy::needless_doctest_main)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wb.rs:102:59 [INFO] [stdout] | [INFO] [stdout] 102 | fn go(&self) -> SheetNameOrNum { SheetNameOrNum::Name(*self) } [INFO] [stdout] | ^^^^^ help: try: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wb.rs:310:45 [INFO] [stdout] | [INFO] [stdout] 310 | let zip_file = match fs::File::open(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/wb.rs:344:16 [INFO] [stdout] | [INFO] [stdout] 344 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: if you would like to reborrow, try removing `&*`: `file.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/wb.rs:344:16 [INFO] [stdout] | [INFO] [stdout] 344 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `(*file.name())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/wb.rs:344:16 [INFO] [stdout] | [INFO] [stdout] 344 | if (&*file.name()).ends_with('/') { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `file.name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ws.rs:347:61 [INFO] [stdout] | [INFO] [stdout] 347 | c.raw_value = e.unescape_and_decode(&reader).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `reader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ws.rs:383:57 [INFO] [stdout] | [INFO] [stdout] 383 | let txt = e.unescape_and_decode(&reader).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `reader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression assigns a bool literal [INFO] [stdout] --> src/wb.rs:389:29 [INFO] [stdout] | [INFO] [stdout] 389 | / ... if att == "preserve" { [INFO] [stdout] 390 | | ... preserve_space = true; [INFO] [stdout] 391 | | ... } else { [INFO] [stdout] 392 | | ... preserve_space = false; [INFO] [stdout] 393 | | ... } [INFO] [stdout] | |_______________________^ help: you can reduce it to: `preserve_space = att == "preserve";` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool_assign [INFO] [stdout] = note: `#[warn(clippy::needless_bool_assign)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/utils.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | if !('A'..='Z').contains(&c) { return None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - if !('A'..='Z').contains(&c) { return None } [INFO] [stdout] 27 + if !c.is_ascii_uppercase() { return None } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wb.rs:569:21 [INFO] [stdout] | [INFO] [stdout] 569 | assert!(!sheets.get("Unknown").is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sheets.get("Unknown").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(args: &[String]) -> Result { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(args: &[String]) -> Result> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wb.rs:576:21 [INFO] [stdout] | [INFO] [stdout] 576 | assert!(!sheets.get(0).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sheets.get(0).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/wb.rs:591:24 [INFO] [stdout] | [INFO] [stdout] 591 | let row1 = ws.rows(&mut wb).nth(0).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `ws.rows(&mut wb).next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/wb.rs:99:36 [INFO] [stdout] | [INFO] [stdout] 99 | pub trait SheetAccessTrait { fn go(&self) -> SheetNameOrNum; } [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 99 | pub trait SheetAccessTrait { fn go(&self) -> SheetNameOrNum<'_>; } [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/wb.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | fn go(&self) -> SheetNameOrNum { SheetNameOrNum::Name(*self) } [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 102 | fn go(&self) -> SheetNameOrNum<'_> { SheetNameOrNum::Name(*self) } [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/wb.rs:106:11 [INFO] [stdout] | [INFO] [stdout] 106 | fn go(&self) -> SheetNameOrNum { SheetNameOrNum::Pos(*self) } [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 106 | fn go(&self) -> SheetNameOrNum<'_> { SheetNameOrNum::Pos(*self) } [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ws.rs:347:61 [INFO] [stdout] | [INFO] [stdout] 347 | c.raw_value = e.unescape_and_decode(&reader).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `reader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ws.rs:383:57 [INFO] [stdout] | [INFO] [stdout] 383 | let txt = e.unescape_and_decode(&reader).unwrap(); [INFO] [stdout] | ^^^^^^^ help: change this to: `reader` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual check for common ascii range [INFO] [stdout] --> src/utils.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | if !('A'..='Z').contains(&c) { return None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_ascii_check [INFO] [stdout] = note: `#[warn(clippy::manual_is_ascii_check)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 - if !('A'..='Z').contains(&c) { return None } [INFO] [stdout] 27 + if !c.is_ascii_uppercase() { return None } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(args: &[String]) -> Result { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 77 | pub fn new(args: &[String]) -> Result> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/wb.rs:99:36 [INFO] [stdout] | [INFO] [stdout] 99 | pub trait SheetAccessTrait { fn go(&self) -> SheetNameOrNum; } [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 99 | pub trait SheetAccessTrait { fn go(&self) -> SheetNameOrNum<'_>; } [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/wb.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | fn go(&self) -> SheetNameOrNum { SheetNameOrNum::Name(*self) } [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 102 | fn go(&self) -> SheetNameOrNum<'_> { SheetNameOrNum::Name(*self) } [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/wb.rs:106:11 [INFO] [stdout] | [INFO] [stdout] 106 | fn go(&self) -> SheetNameOrNum { SheetNameOrNum::Pos(*self) } [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 106 | fn go(&self) -> SheetNameOrNum<'_> { SheetNameOrNum::Pos(*self) } [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.88s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: quick-xml v0.22.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "6c005599e3a07d375aa64450d345384ecd12a7ffb1f0c69068933824c0ebc0dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c005599e3a07d375aa64450d345384ecd12a7ffb1f0c69068933824c0ebc0dc", kill_on_drop: false }` [INFO] [stdout] 6c005599e3a07d375aa64450d345384ecd12a7ffb1f0c69068933824c0ebc0dc