[INFO] fetching crate xdrfile 0.3.0... [INFO] linting xdrfile-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate xdrfile 0.3.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate xdrfile 0.3.0 [INFO] finished tweaking crates.io crate xdrfile 0.3.0 [INFO] tweaked toml for crates.io crate xdrfile 0.3.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate xdrfile 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 103 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.3.6 (available: v0.8.2) [INFO] [stderr] Adding lazy-init v0.3.0 (available: v0.5.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lazy-init v0.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e802af9c33e2e0593caaa64e57540fa68cdeda2bd2658a7e2ccad0d39c42b6c6 [INFO] running `Command { std: "docker" "start" "-a" "e802af9c33e2e0593caaa64e57540fa68cdeda2bd2658a7e2ccad0d39c42b6c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e802af9c33e2e0593caaa64e57540fa68cdeda2bd2658a7e2ccad0d39c42b6c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e802af9c33e2e0593caaa64e57540fa68cdeda2bd2658a7e2ccad0d39c42b6c6", kill_on_drop: false }` [INFO] [stdout] e802af9c33e2e0593caaa64e57540fa68cdeda2bd2658a7e2ccad0d39c42b6c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b83ef5ea11c69a966114ac95ad5814a306bdce10ab93a143e4cadabf83c699e [INFO] running `Command { std: "docker" "start" "-a" "0b83ef5ea11c69a966114ac95ad5814a306bdce10ab93a143e4cadabf83c699e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking getrandom v0.4.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Checking lazy-init v0.3.0 [INFO] [stderr] Checking tempfile v3.27.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Compiling xdrfile v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/errors.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | self.code().map_or(false, |e| e.is_eof()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 54 - self.code().map_or(false, |e| e.is_eof()) [INFO] [stdout] 54 + self.code().is_some_and(|e| e.is_eof()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/frame.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 44 | self.coords = self [INFO] [stdout] | _______________________^ [INFO] [stdout] 45 | | .coords [INFO] [stdout] 46 | | .iter() [INFO] [stdout] 47 | | .map(|elem| elem.clone()) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 44 ~ self.coords = self [INFO] [stdout] 45 + .coords [INFO] [stdout] 46 + .iter().copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[f32; 3]` which implements the `Copy` trait [INFO] [stdout] --> src/frame.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 47 | .map(|elem| elem.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*elem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/iterator.rs:60:53 [INFO] [stdout] | [INFO] [stdout] 60 | self.item = Rc::new(Frame::with_len(num_atoms as usize)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `num_atoms` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:207:34 [INFO] [stdout] | [INFO] [stdout] 207 | Some(err) => Err(io::Error::new(io::ErrorKind::Other, err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 207 - Some(err) => Err(io::Error::new(io::ErrorKind::Other, err)), [INFO] [stdout] 207 + Some(err) => Err(io::Error::other(err)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `xdrfile_xtc::read_xtc_natoms` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:337:69 [INFO] [stdout] | [INFO] [stdout] 337 | let code = xdrfile_xtc::read_xtc_natoms(path_p, &mut num_atoms); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 337 - let code = xdrfile_xtc::read_xtc_natoms(path_p, &mut num_atoms); [INFO] [stdout] 337 + let code = xdrfile_xtc::read_xtc_natoms(path_p, &num_atoms); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `xdrfile_trr::read_trr_natoms` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:467:69 [INFO] [stdout] | [INFO] [stdout] 467 | let code = xdrfile_trr::read_trr_natoms(path_p, &mut num_atoms); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 467 - let code = xdrfile_trr::read_trr_natoms(path_p, &mut num_atoms); [INFO] [stdout] 467 + let code = xdrfile_trr::read_trr_natoms(path_p, &num_atoms); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `read_trr_natoms` doesn't need a mutable reference [INFO] [stdout] --> src/c_abi/xdrfile_trr.rs:55:44 [INFO] [stdout] | [INFO] [stdout] 55 | read_trr_natoms(path.as_ptr(), &mut natoms); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 55 - read_trr_natoms(path.as_ptr(), &mut natoms); [INFO] [stdout] 55 + read_trr_natoms(path.as_ptr(), &natoms); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `read_trr_nframes` doesn't need a mutable reference [INFO] [stdout] --> src/c_abi/xdrfile_trr.rs:67:56 [INFO] [stdout] | [INFO] [stdout] 67 | let code = read_trr_nframes(path.as_ptr(), &mut nframes); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 67 - let code = read_trr_nframes(path.as_ptr(), &mut nframes); [INFO] [stdout] 67 + let code = read_trr_nframes(path.as_ptr(), &nframes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `read_xtc_natoms` doesn't need a mutable reference [INFO] [stdout] --> src/c_abi/xdrfile_xtc.rs:51:55 [INFO] [stdout] | [INFO] [stdout] 51 | read_xtc_natoms(path.as_ptr() as *mut i8, &mut natoms); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 51 - read_xtc_natoms(path.as_ptr() as *mut i8, &mut natoms); [INFO] [stdout] 51 + read_xtc_natoms(path.as_ptr() as *mut i8, &natoms); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `read_xtc_nframes` doesn't need a mutable reference [INFO] [stdout] --> src/c_abi/xdrfile_xtc.rs:63:56 [INFO] [stdout] | [INFO] [stdout] 63 | let code = read_xtc_nframes(path.as_ptr(), &mut nframes); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 63 - let code = read_xtc_nframes(path.as_ptr(), &mut nframes); [INFO] [stdout] 63 + let code = read_xtc_nframes(path.as_ptr(), &nframes); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/errors.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | self.code().map_or(false, |e| e.is_eof()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 54 - self.code().map_or(false, |e| e.is_eof()) [INFO] [stdout] 54 + self.code().is_some_and(|e| e.is_eof()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/frame.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 44 | self.coords = self [INFO] [stdout] | _______________________^ [INFO] [stdout] 45 | | .coords [INFO] [stdout] 46 | | .iter() [INFO] [stdout] 47 | | .map(|elem| elem.clone()) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `copied` method [INFO] [stdout] | [INFO] [stdout] 44 ~ self.coords = self [INFO] [stdout] 45 + .coords [INFO] [stdout] 46 + .iter().copied() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[f32; 3]` which implements the `Copy` trait [INFO] [stdout] --> src/frame.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 47 | .map(|elem| elem.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*elem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/iterator.rs:60:53 [INFO] [stdout] | [INFO] [stdout] 60 | self.item = Rc::new(Frame::with_len(num_atoms as usize)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `num_atoms` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/lib.rs:207:34 [INFO] [stdout] | [INFO] [stdout] 207 | Some(err) => Err(io::Error::new(io::ErrorKind::Other, err)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 207 - Some(err) => Err(io::Error::new(io::ErrorKind::Other, err)), [INFO] [stdout] 207 + Some(err) => Err(io::Error::other(err)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `xdrfile_xtc::read_xtc_natoms` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:337:69 [INFO] [stdout] | [INFO] [stdout] 337 | let code = xdrfile_xtc::read_xtc_natoms(path_p, &mut num_atoms); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 337 - let code = xdrfile_xtc::read_xtc_natoms(path_p, &mut num_atoms); [INFO] [stdout] 337 + let code = xdrfile_xtc::read_xtc_natoms(path_p, &num_atoms); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `xdrfile_trr::read_trr_natoms` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:467:69 [INFO] [stdout] | [INFO] [stdout] 467 | let code = xdrfile_trr::read_trr_natoms(path_p, &mut num_atoms); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 467 - let code = xdrfile_trr::read_trr_natoms(path_p, &mut num_atoms); [INFO] [stdout] 467 + let code = xdrfile_trr::read_trr_natoms(path_p, &num_atoms); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:515:47 [INFO] [stdout] | [INFO] [stdout] 515 | let mut f = XTCTrajectory::open_write(&tmp_path)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `tmp_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:517:9 [INFO] [stdout] | [INFO] [stdout] 517 | / match write_status { [INFO] [stdout] 518 | | Err(_) => panic!("Failed"), [INFO] [stdout] 519 | | Ok(()) => {} [INFO] [stdout] 520 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(_) = write_status { panic!("Failed") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | / match read_status { [INFO] [stdout] 530 | | Err(e) => assert!(false, "{:?}", e), [INFO] [stdout] 531 | | Ok(()) => {} [INFO] [stdout] 532 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(e) = read_status { assert!(false, "{:?}", e) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/lib.rs:530:23 [INFO] [stdout] | [INFO] [stdout] 530 | Err(e) => assert!(false, "{:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:556:9 [INFO] [stdout] | [INFO] [stdout] 556 | / match write_status { [INFO] [stdout] 557 | | Err(_) => panic!("Failed"), [INFO] [stdout] 558 | | Ok(()) => {} [INFO] [stdout] 559 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(_) = write_status { panic!("Failed") }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:568:9 [INFO] [stdout] | [INFO] [stdout] 568 | / match read_status { [INFO] [stdout] 569 | | Err(e) => assert!(false, "{:?}", e), [INFO] [stdout] 570 | | Ok(()) => {} [INFO] [stdout] 571 | | } [INFO] [stdout] | |_________^ help: try: `if let Err(e) = read_status { assert!(false, "{:?}", e) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/lib.rs:569:23 [INFO] [stdout] | [INFO] [stdout] 569 | Err(e) => assert!(false, "{:?}", e), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:775:47 [INFO] [stdout] | [INFO] [stdout] 775 | let mut f = XTCTrajectory::open_write(&tmp_path)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `tmp_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:809:17 [INFO] [stdout] | [INFO] [stdout] 809 | assert!(!check_code(code, ErrorTask::Read).is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `check_code(code, ErrorTask::Read).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/lib.rs:811:18 [INFO] [stdout] | [INFO] [stdout] 811 | for i in vec![1, 10, 100, 1000] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[1, 10, 100, 1000]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/iterator.rs:102:38 [INFO] [stdout] | [INFO] [stdout] 102 | assert!(frames[0].step == 1, frames[0].step); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 102 | assert!(frames[0].step == 1, "{}", frames[0].step); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/iterator.rs:113:38 [INFO] [stdout] | [INFO] [stdout] 113 | assert!(frames[0].step == 1, frames[0].step); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 113 | assert!(frames[0].step == 1, "{}", frames[0].step); [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.41s [INFO] running `Command { std: "docker" "inspect" "0b83ef5ea11c69a966114ac95ad5814a306bdce10ab93a143e4cadabf83c699e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b83ef5ea11c69a966114ac95ad5814a306bdce10ab93a143e4cadabf83c699e", kill_on_drop: false }` [INFO] [stdout] 0b83ef5ea11c69a966114ac95ad5814a306bdce10ab93a143e4cadabf83c699e