[INFO] fetching crate world_dispatcher 2.1.0... [INFO] linting world_dispatcher-2.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate world_dispatcher 2.1.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate world_dispatcher 2.1.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate world_dispatcher 2.1.0 [INFO] tweaked toml for crates.io crate world_dispatcher 2.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate world_dispatcher 2.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate world_dispatcher 2.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thread_profiler v0.3.0 [INFO] [stderr] Downloaded atomic_refcell_try v0.2.0 [INFO] [stderr] Downloaded libc v0.2.121 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3ca30e3e431293769e9f1fa3daca9063414a8884f1d7440b6076fc57c45f13c [INFO] running `Command { std: "docker" "start" "-a" "e3ca30e3e431293769e9f1fa3daca9063414a8884f1d7440b6076fc57c45f13c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3ca30e3e431293769e9f1fa3daca9063414a8884f1d7440b6076fc57c45f13c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3ca30e3e431293769e9f1fa3daca9063414a8884f1d7440b6076fc57c45f13c", kill_on_drop: false }` [INFO] [stdout] e3ca30e3e431293769e9f1fa3daca9063414a8884f1d7440b6076fc57c45f13c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6a1d1e72bc2373849e3dd1188861fcf122cf0feeacbcb7a6588d8ecb55502594 [INFO] running `Command { std: "docker" "start" "-a" "6a1d1e72bc2373849e3dd1188861fcf122cf0feeacbcb7a6588d8ecb55502594", kill_on_drop: false }` [INFO] [stderr] Compiling serde_json v1.0.141 [INFO] [stderr] Checking ryu v1.0.9 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Checking downcast-rs v2.0.1 [INFO] [stderr] Checking atomic_refcell_try v0.2.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking world_dispatcher v2.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stdout] warning: method `add` can be confused for the standard trait method `std::ops::Add::add` [INFO] [stdout] --> src/dispatcher.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / pub fn add>(mut self, into_system: F) -> Self { [INFO] [stdout] 25 | | self.systems.push(into_system.system()); [INFO] [stdout] 26 | | self [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::ops::Add` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/resource.rs:17:6 [INFO] [stdout] | [INFO] [stdout] 17 | impl<'a, T> RefLifetime for &'a T {} [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 17 - impl<'a, T> RefLifetime for &'a T {} [INFO] [stdout] 17 + impl RefLifetime for &T {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/resource.rs:18:6 [INFO] [stdout] | [INFO] [stdout] 18 | impl<'a, T> RefLifetime for &'a mut T {} [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 18 - impl<'a, T> RefLifetime for &'a mut T {} [INFO] [stdout] 18 + impl RefLifetime for &mut T {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/system.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) lock: Box>) -> bool + Send>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking clap v4.5.41 [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/world.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if !self.res.contains_key(&TypeId::of::()) { [INFO] [stdout] 22 | | self.res.insert( [INFO] [stdout] 23 | | TypeId::of::(), [INFO] [stdout] 24 | | AtomicRefCell::new(Box::new(T::default())), [INFO] [stdout] 25 | | ); [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ help: try: `self.res.entry(TypeId::of::()).or_insert_with(|| AtomicRefCell::new(Box::new(T::default())));` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/world.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | .expect(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 37 | | "Trying to world::get a resource that is not initialized. Type: {}", [INFO] [stdout] 38 | | std::any::type_name::() [INFO] [stdout] 39 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ .unwrap_or_else(|| panic!("Trying to world::get a resource that is not initialized. Type: {}", [INFO] [stdout] 37 + std::any::type_name::())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/world.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / self.res [INFO] [stdout] 47 | | .get(&TypeId::of::()) [INFO] [stdout] 48 | | .ok_or(()) [INFO] [stdout] 49 | | .and_then(|i| i.try_borrow().map_err(|_| ())) [INFO] [stdout] 50 | | .and_then(|i| Ok(AtomicRef::map(i, |j| j.downcast_ref::().unwrap()))) [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ self.res [INFO] [stdout] 47 + .get(&TypeId::of::()) [INFO] [stdout] 48 + .ok_or(()) [INFO] [stdout] 49 + .and_then(|i| i.try_borrow().map_err(|_| ())).map(|i| AtomicRef::map(i, |j| j.downcast_ref::().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/world.rs:62:14 [INFO] [stdout] | [INFO] [stdout] 62 | .expect(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 63 | | "Trying to world::get_mut a resource that is not initialized. Type: {}", [INFO] [stdout] 64 | | std::any::type_name::() [INFO] [stdout] 65 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ .unwrap_or_else(|| panic!("Trying to world::get_mut a resource that is not initialized. Type: {}", [INFO] [stdout] 63 + std::any::type_name::())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/world.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / self.res [INFO] [stdout] 73 | | .get(&TypeId::of::()) [INFO] [stdout] 74 | | .ok_or(()) [INFO] [stdout] 75 | | .and_then(|i| i.try_borrow_mut().map_err(|_| ())) [INFO] [stdout] 76 | | .and_then(|i| Ok(AtomicRefMut::map(i, |j| j.downcast_mut::().unwrap()))) [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 ~ self.res [INFO] [stdout] 73 + .get(&TypeId::of::()) [INFO] [stdout] 74 + .ok_or(()) [INFO] [stdout] 75 + .and_then(|i| i.try_borrow_mut().map_err(|_| ())).map(|i| AtomicRefMut::map(i, |j| j.downcast_mut::().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:32:42 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn get(&self) -> AtomicRef { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 32 | pub fn get(&self) -> AtomicRef<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:45:53 [INFO] [stdout] | [INFO] [stdout] 45 | pub(crate) fn try_get(&self) -> Result, ()> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 45 | pub(crate) fn try_get(&self) -> Result, ()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:58:46 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_mut(&self) -> AtomicRefMut { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_mut(&self) -> AtomicRefMut<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:71:57 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) fn try_get_mut(&self) -> Result, ()> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) fn try_get_mut(&self) -> Result, ()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:81:67 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn get_mut_or_default(&mut self) -> AtomicRefMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 81 | pub fn get_mut_or_default(&mut self) -> AtomicRefMut<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:93:26 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn get_by_typeid(&self, typeid: &TypeId) -> AtomicRefMut> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 93 | pub fn get_by_typeid(&self, typeid: &TypeId) -> AtomicRefMut<'_, Box> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.6.0 [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> benches/system.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | / fn big( [INFO] [stdout] 9 | | _a: &A, [INFO] [stdout] 10 | | _b: &A, [INFO] [stdout] 11 | | _c: &A, [INFO] [stdout] ... | [INFO] [stdout] 20 | | _l: &A, [INFO] [stdout] 21 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> benches/system.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | black_box(sys.run(&world)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 47 ~ let _: () = sys.run(&world); [INFO] [stdout] 48 ~ black_box(()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> benches/system.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | black_box(sys.run(&world)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 59 ~ let _: () = sys.run(&world); [INFO] [stdout] 60 ~ black_box(()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> benches/dispatcher.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | black_box(dispatch.run_seq(&world)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 52 ~ dispatch.run_seq(&world); [INFO] [stdout] 53 ~ black_box(()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `add` can be confused for the standard trait method `std::ops::Add::add` [INFO] [stdout] --> src/dispatcher.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | / pub fn add>(mut self, into_system: F) -> Self { [INFO] [stdout] 25 | | self.systems.push(into_system.system()); [INFO] [stdout] 26 | | self [INFO] [stdout] 27 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::ops::Add` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/resource.rs:17:6 [INFO] [stdout] | [INFO] [stdout] 17 | impl<'a, T> RefLifetime for &'a T {} [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 17 - impl<'a, T> RefLifetime for &'a T {} [INFO] [stdout] 17 + impl RefLifetime for &T {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/resource.rs:18:6 [INFO] [stdout] | [INFO] [stdout] 18 | impl<'a, T> RefLifetime for &'a mut T {} [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 18 - impl<'a, T> RefLifetime for &'a mut T {} [INFO] [stdout] 18 + impl RefLifetime for &mut T {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/system.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) lock: Box>) -> bool + Send>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/system.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | / fn tmp2( [INFO] [stdout] 138 | | _var1: &u32, [INFO] [stdout] 139 | | _var2: &u64, [INFO] [stdout] 140 | | _var3: &mut i32, [INFO] [stdout] ... | [INFO] [stdout] 149 | | _var12: &mut i64, [INFO] [stdout] 150 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/world.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if !self.res.contains_key(&TypeId::of::()) { [INFO] [stdout] 22 | | self.res.insert( [INFO] [stdout] 23 | | TypeId::of::(), [INFO] [stdout] 24 | | AtomicRefCell::new(Box::new(T::default())), [INFO] [stdout] 25 | | ); [INFO] [stdout] 26 | | } [INFO] [stdout] | |_________^ help: try: `self.res.entry(TypeId::of::()).or_insert_with(|| AtomicRefCell::new(Box::new(T::default())));` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/world.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | .expect(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 37 | | "Trying to world::get a resource that is not initialized. Type: {}", [INFO] [stdout] 38 | | std::any::type_name::() [INFO] [stdout] 39 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 36 ~ .unwrap_or_else(|| panic!("Trying to world::get a resource that is not initialized. Type: {}", [INFO] [stdout] 37 + std::any::type_name::())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/world.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / self.res [INFO] [stdout] 47 | | .get(&TypeId::of::()) [INFO] [stdout] 48 | | .ok_or(()) [INFO] [stdout] 49 | | .and_then(|i| i.try_borrow().map_err(|_| ())) [INFO] [stdout] 50 | | .and_then(|i| Ok(AtomicRef::map(i, |j| j.downcast_ref::().unwrap()))) [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 46 ~ self.res [INFO] [stdout] 47 + .get(&TypeId::of::()) [INFO] [stdout] 48 + .ok_or(()) [INFO] [stdout] 49 + .and_then(|i| i.try_borrow().map_err(|_| ())).map(|i| AtomicRef::map(i, |j| j.downcast_ref::().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/world.rs:62:14 [INFO] [stdout] | [INFO] [stdout] 62 | .expect(&format!( [INFO] [stdout] | ______________^ [INFO] [stdout] 63 | | "Trying to world::get_mut a resource that is not initialized. Type: {}", [INFO] [stdout] 64 | | std::any::type_name::() [INFO] [stdout] 65 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 62 ~ .unwrap_or_else(|| panic!("Trying to world::get_mut a resource that is not initialized. Type: {}", [INFO] [stdout] 63 + std::any::type_name::())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/world.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | / self.res [INFO] [stdout] 73 | | .get(&TypeId::of::()) [INFO] [stdout] 74 | | .ok_or(()) [INFO] [stdout] 75 | | .and_then(|i| i.try_borrow_mut().map_err(|_| ())) [INFO] [stdout] 76 | | .and_then(|i| Ok(AtomicRefMut::map(i, |j| j.downcast_mut::().unwrap()))) [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 ~ self.res [INFO] [stdout] 73 + .get(&TypeId::of::()) [INFO] [stdout] 74 + .ok_or(()) [INFO] [stdout] 75 + .and_then(|i| i.try_borrow_mut().map_err(|_| ())).map(|i| AtomicRefMut::map(i, |j| j.downcast_mut::().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/world.rs:115:16 [INFO] [stdout] | [INFO] [stdout] 115 | if !failing_borrow.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `failing_borrow.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/world.rs:122:16 [INFO] [stdout] | [INFO] [stdout] 122 | if !failing_borrow.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `failing_borrow.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:32:42 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn get(&self) -> AtomicRef { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 32 | pub fn get(&self) -> AtomicRef<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:45:53 [INFO] [stdout] | [INFO] [stdout] 45 | pub(crate) fn try_get(&self) -> Result, ()> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 45 | pub(crate) fn try_get(&self) -> Result, ()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:58:46 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_mut(&self) -> AtomicRefMut { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 58 | pub fn get_mut(&self) -> AtomicRefMut<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:71:57 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) fn try_get_mut(&self) -> Result, ()> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) fn try_get_mut(&self) -> Result, ()> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:81:67 [INFO] [stdout] | [INFO] [stdout] 81 | pub fn get_mut_or_default(&mut self) -> AtomicRefMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 81 | pub fn get_mut_or_default(&mut self) -> AtomicRefMut<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/world.rs:93:26 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn get_by_typeid(&self, typeid: &TypeId) -> AtomicRefMut> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 93 | pub fn get_by_typeid(&self, typeid: &TypeId) -> AtomicRefMut<'_, Box> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.00s [INFO] running `Command { std: "docker" "inspect" "6a1d1e72bc2373849e3dd1188861fcf122cf0feeacbcb7a6588d8ecb55502594", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6a1d1e72bc2373849e3dd1188861fcf122cf0feeacbcb7a6588d8ecb55502594", kill_on_drop: false }` [INFO] [stdout] 6a1d1e72bc2373849e3dd1188861fcf122cf0feeacbcb7a6588d8ecb55502594