[INFO] fetching crate wmclient 0.2.0... [INFO] linting wmclient-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate wmclient 0.2.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate wmclient 0.2.0 [INFO] finished tweaking crates.io crate wmclient 0.2.0 [INFO] tweaked toml for crates.io crate wmclient 0.2.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate wmclient 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate wmclient 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror v1.0.64 [INFO] [stderr] Downloaded proc-macro2 v1.0.87 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.95 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.95 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.95 [INFO] [stderr] Downloaded thiserror-impl v1.0.64 [INFO] [stderr] Downloaded security-framework-sys v2.12.0 [INFO] [stderr] Downloaded rustls-pki-types v1.9.0 [INFO] [stderr] Downloaded js-sys v0.3.72 [INFO] [stderr] Downloaded unicode-bidi v0.3.17 [INFO] [stderr] Downloaded serde_json v1.0.128 [INFO] [stderr] Downloaded wasm-bindgen v0.2.95 [INFO] [stderr] Downloaded cc v1.1.30 [INFO] [stderr] Downloaded hyper v0.14.30 [INFO] [stderr] Downloaded syn v2.0.79 [INFO] [stderr] Downloaded openssl v0.10.66 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.95 [INFO] [stderr] Downloaded rustls v0.23.14 [INFO] [stderr] Downloaded libc v0.2.159 [INFO] [stderr] Downloaded tokio v1.40.0 [INFO] [stderr] Downloaded reqwest v0.12.8 [INFO] [stderr] Downloaded hyper-util v0.1.9 [INFO] [stderr] Downloaded openssl-src v300.3.2+3.3.2 [INFO] [stderr] Downloaded openssl-sys v0.9.103 [INFO] [stderr] Downloaded bytes v1.7.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 665449f594d5b9160b754102bc7a0145c22c6474c6f87240cc4e8114430521bb [INFO] running `Command { std: "docker" "start" "-a" "665449f594d5b9160b754102bc7a0145c22c6474c6f87240cc4e8114430521bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "665449f594d5b9160b754102bc7a0145c22c6474c6f87240cc4e8114430521bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "665449f594d5b9160b754102bc7a0145c22c6474c6f87240cc4e8114430521bb", kill_on_drop: false }` [INFO] [stdout] 665449f594d5b9160b754102bc7a0145c22c6474c6f87240cc4e8114430521bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 379f86d104859ed6574b613f9c275fdcfea5c25462f263d67e768f72e1203910 [INFO] running `Command { std: "docker" "start" "-a" "379f86d104859ed6574b613f9c275fdcfea5c25462f263d67e768f72e1203910", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.87 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling cc v1.1.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking hashbrown v0.15.0 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking unicode-bidi v0.3.17 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking rustls-pki-types v1.9.0 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking indexmap v2.6.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.79 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ahash v0.7.8 [INFO] [stderr] Compiling openssl-src v300.3.2+3.3.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking lru v0.7.8 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.9 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.8 [INFO] [stderr] Checking wmclient v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap` on `http_client` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:126:33 [INFO] [stdout] | [INFO] [stdout] 125 | if http_client.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = http_client` [INFO] [stdout] 126 | self._http_client = http_client.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return self.static_caps.contains(&cap_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return self.static_caps.contains(&cap_name.to_string()); [INFO] [stdout] 132 + self.static_caps.contains(&cap_name.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | return self.virtual_caps.contains(&vcap_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return self.virtual_caps.contains(&vcap_name.to_string()); [INFO] [stdout] 137 + self.virtual_caps.contains(&vcap_name.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `info_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:162:24 [INFO] [stdout] | [INFO] [stdout] 161 | if info_res.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = info_res` [INFO] [stdout] 162 | let info = info_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `serde_err` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:168:43 [INFO] [stdout] | [INFO] [stdout] 167 | if serde_err.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = serde_err` [INFO] [stdout] 168 | return Err(WmError { msg: serde_err.unwrap().to_string() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return result; [INFO] [stdout] 164 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:168:17 [INFO] [stdout] | [INFO] [stdout] 168 | return Err(WmError { msg: serde_err.unwrap().to_string() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return Err(WmError { msg: serde_err.unwrap().to_string() }); [INFO] [stdout] 168 + Err(WmError { msg: serde_err.unwrap().to_string() }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 170 | return Err(WmError { msg: "Unable to parse JSON response".to_string() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 170 - return Err(WmError { msg: "Unable to parse JSON response".to_string() }); [INFO] [stdout] 170 + Err(WmError { msg: "Unable to parse JSON response".to_string() }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:184:30 [INFO] [stdout] | [INFO] [stdout] 183 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 184 | let device_opt = self._cache.as_ref().unwrap().get(USERAGENT_CACHE_TYPE.to_string(), cache_key.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device_opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:186:25 [INFO] [stdout] | [INFO] [stdout] 185 | if device_opt.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = device_opt` [INFO] [stdout] 186 | let d = device_opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:197:26 [INFO] [stdout] | [INFO] [stdout] 196 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 197 | let device = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:202:17 [INFO] [stdout] | [INFO] [stdout] 201 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 202 | self._cache.as_ref().unwrap().put(USERAGENT_CACHE_TYPE.to_string(), cache_key, device.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | return Ok(device); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return Ok(device); [INFO] [stdout] 204 + Ok(device) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:206:13 [INFO] [stdout] | [INFO] [stdout] 206 | return Err(result.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 - return Err(result.err().unwrap()); [INFO] [stdout] 206 + Err(result.err().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:216:30 [INFO] [stdout] | [INFO] [stdout] 215 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 216 | let device_opt = self._cache.as_ref().unwrap().get(DEVICE_ID_CACHE_TYPE.to_string(), device_id.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device_opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:218:34 [INFO] [stdout] | [INFO] [stdout] 217 | if device_opt.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = device_opt` [INFO] [stdout] 218 | let device_ref = device_opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:234:26 [INFO] [stdout] | [INFO] [stdout] 233 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 234 | let device = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 239 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 240 | self._cache.as_ref().unwrap().put(DEVICE_ID_CACHE_TYPE.to_string(), device_id, device.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:242:13 [INFO] [stdout] | [INFO] [stdout] 242 | return Ok(device); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return Ok(device); [INFO] [stdout] 242 + Ok(device) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:244:13 [INFO] [stdout] | [INFO] [stdout] 244 | return Err(result.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 - return Err(result.err().unwrap()); [INFO] [stdout] 244 + Err(result.err().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `h_value` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:266:53 [INFO] [stdout] | [INFO] [stdout] 265 | if h_value.is_some() && !h_value.unwrap().is_empty() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 266 | headers.insert(ih_name.to_string(), h_value.unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:276:30 [INFO] [stdout] | [INFO] [stdout] 275 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 276 | let device_opt = self._cache.as_ref().unwrap().get(USERAGENT_CACHE_TYPE.to_string(), cache_key.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device_opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 278 | if device_opt.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = device_opt` [INFO] [stdout] 279 | let d = device_opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:290:26 [INFO] [stdout] | [INFO] [stdout] 289 | if device_res.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = device_res` [INFO] [stdout] 290 | let device = device_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:294:17 [INFO] [stdout] | [INFO] [stdout] 293 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 294 | self._cache.as_ref().unwrap().put(USERAGENT_CACHE_TYPE.to_string(), cache_key, device.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:296:13 [INFO] [stdout] | [INFO] [stdout] 296 | return Ok(device); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - return Ok(device); [INFO] [stdout] 296 + Ok(device) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | return Err(device_res.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return Err(device_res.err().unwrap()); [INFO] [stdout] 298 + Err(device_res.err().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 305 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 306 | self._cache.as_ref().unwrap().clear(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mk_md_lock_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:313:35 [INFO] [stdout] | [INFO] [stdout] 312 | if mk_md_lock_res.is_ok() { [INFO] [stdout] | ------------------------- help: try: `if let Ok() = mk_md_lock_res` [INFO] [stdout] 313 | let mut make_models = mk_md_lock_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dev_makes_lock_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:319:36 [INFO] [stdout] | [INFO] [stdout] 318 | if dev_makes_lock_guard.is_ok() { [INFO] [stdout] | ------------------------------- help: try: `if let Ok() = dev_makes_lock_guard` [INFO] [stdout] 319 | let mut device_makes = dev_makes_lock_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dev_makes_map_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:323:17 [INFO] [stdout] | [INFO] [stdout] 322 | if dev_makes_map_guard.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = dev_makes_map_guard` [INFO] [stdout] 323 | dev_makes_map_guard.unwrap().clear(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dev_os_lock_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:329:35 [INFO] [stdout] | [INFO] [stdout] 328 | if dev_os_lock_res.is_ok() { [INFO] [stdout] | -------------------------- help: try: `if let Ok() = dev_os_lock_res` [INFO] [stdout] 329 | let mut device_oses = dev_os_lock_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_ver_map_lock_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:335:34 [INFO] [stdout] | [INFO] [stdout] 334 | if os_ver_map_lock_res.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = os_ver_map_lock_res` [INFO] [stdout] 335 | let mut os_ver_map = os_ver_map_lock_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `http_client` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:126:33 [INFO] [stdout] | [INFO] [stdout] 125 | if http_client.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = http_client` [INFO] [stdout] 126 | self._http_client = http_client.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return self.static_caps.contains(&cap_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return self.static_caps.contains(&cap_name.to_string()); [INFO] [stdout] 132 + self.static_caps.contains(&cap_name.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | return self.virtual_caps.contains(&vcap_name.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return self.virtual_caps.contains(&vcap_name.to_string()); [INFO] [stdout] 137 + self.virtual_caps.contains(&vcap_name.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | return format!("{}://{}:{}{}", self._scheme.as_str(), self._host.as_str(), self._port.as_str(), path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 349 - return format!("{}://{}:{}{}", self._scheme.as_str(), self._host.as_str(), self._port.as_str(), path); [INFO] [stdout] 349 + format!("{}://{}:{}{}", self._scheme.as_str(), self._host.as_str(), self._port.as_str(), path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `info_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:162:24 [INFO] [stdout] | [INFO] [stdout] 161 | if info_res.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = info_res` [INFO] [stdout] 162 | let info = info_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `serde_err` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:168:43 [INFO] [stdout] | [INFO] [stdout] 167 | if serde_err.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = serde_err` [INFO] [stdout] 168 | return Err(WmError { msg: serde_err.unwrap().to_string() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:164:13 [INFO] [stdout] | [INFO] [stdout] 164 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return result; [INFO] [stdout] 164 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:168:17 [INFO] [stdout] | [INFO] [stdout] 168 | return Err(WmError { msg: serde_err.unwrap().to_string() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return Err(WmError { msg: serde_err.unwrap().to_string() }); [INFO] [stdout] 168 + Err(WmError { msg: serde_err.unwrap().to_string() }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 170 | return Err(WmError { msg: "Unable to parse JSON response".to_string() }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 170 - return Err(WmError { msg: "Unable to parse JSON response".to_string() }); [INFO] [stdout] 170 + Err(WmError { msg: "Unable to parse JSON response".to_string() }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `h_val` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:359:33 [INFO] [stdout] | [INFO] [stdout] 358 | if h_val.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = h_val` [INFO] [stdout] 359 | key = key + h_val.unwrap().as_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:366:9 [INFO] [stdout] | [INFO] [stdout] 366 | return Some(str_digest.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return Some(str_digest.to_string()); [INFO] [stdout] 366 + Some(str_digest.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:184:30 [INFO] [stdout] | [INFO] [stdout] 183 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 184 | let device_opt = self._cache.as_ref().unwrap().get(USERAGENT_CACHE_TYPE.to_string(), cache_key.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device_opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:186:25 [INFO] [stdout] | [INFO] [stdout] 185 | if device_opt.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = device_opt` [INFO] [stdout] 186 | let d = device_opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/./wmclient.rs:359:21 [INFO] [stdout] | [INFO] [stdout] 359 | key = key + h_val.unwrap().as_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key += h_val.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:197:26 [INFO] [stdout] | [INFO] [stdout] 196 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 197 | let device = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:202:17 [INFO] [stdout] | [INFO] [stdout] 201 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 202 | self._cache.as_ref().unwrap().put(USERAGENT_CACHE_TYPE.to_string(), cache_key, device.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:204:13 [INFO] [stdout] | [INFO] [stdout] 204 | return Ok(device); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return Ok(device); [INFO] [stdout] 204 + Ok(device) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | return ua; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 - return ua; [INFO] [stdout] 372 + ua [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:206:13 [INFO] [stdout] | [INFO] [stdout] 206 | return Err(result.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 - return Err(result.err().unwrap()); [INFO] [stdout] 206 + Err(result.err().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:385:16 [INFO] [stdout] | [INFO] [stdout] 384 | return if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 385 | Ok(result.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / return if result.is_ok() { [INFO] [stdout] 385 | | Ok(result.unwrap()) [INFO] [stdout] 386 | | } else { [INFO] [stdout] 387 | | let err = result.err().unwrap(); [INFO] [stdout] 388 | | let msg = format!("Unable to perform get for path {}. Error {}", url, err.to_string()); [INFO] [stdout] 389 | | Err(WmError { msg }) [INFO] [stdout] 390 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 384 ~ if result.is_ok() { [INFO] [stdout] 385 + Ok(result.unwrap()) [INFO] [stdout] 386 + } else { [INFO] [stdout] 387 + let err = result.err().unwrap(); [INFO] [stdout] 388 + let msg = format!("Unable to perform get for path {}. Error {}", url, err.to_string()); [INFO] [stdout] 389 + Err(WmError { msg }) [INFO] [stdout] 390 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:216:30 [INFO] [stdout] | [INFO] [stdout] 215 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 216 | let device_opt = self._cache.as_ref().unwrap().get(DEVICE_ID_CACHE_TYPE.to_string(), device_id.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:388:86 [INFO] [stdout] | [INFO] [stdout] 388 | let msg = format!("Unable to perform get for path {}. Error {}", url, err.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/./wmclient.rs:409:12 [INFO] [stdout] | [INFO] [stdout] 409 | if cap_names.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cap_names.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device_opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:218:34 [INFO] [stdout] | [INFO] [stdout] 217 | if device_opt.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = device_opt` [INFO] [stdout] 218 | let device_ref = device_opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:234:26 [INFO] [stdout] | [INFO] [stdout] 233 | if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 234 | let device = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 239 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 240 | self._cache.as_ref().unwrap().put(DEVICE_ID_CACHE_TYPE.to_string(), device_id, device.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:242:13 [INFO] [stdout] | [INFO] [stdout] 242 | return Ok(device); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return Ok(device); [INFO] [stdout] 242 + Ok(device) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:244:13 [INFO] [stdout] | [INFO] [stdout] 244 | return Err(result.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 244 - return Err(result.err().unwrap()); [INFO] [stdout] 244 + Err(result.err().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `h_value` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:266:53 [INFO] [stdout] | [INFO] [stdout] 265 | if h_value.is_some() && !h_value.unwrap().is_empty() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 266 | headers.insert(ih_name.to_string(), h_value.unwrap().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/./wmclient.rs:431:12 [INFO] [stdout] | [INFO] [stdout] 431 | if virtual_cap_names.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!virtual_cap_names.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:276:30 [INFO] [stdout] | [INFO] [stdout] 275 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 276 | let device_opt = self._cache.as_ref().unwrap().get(USERAGENT_CACHE_TYPE.to_string(), cache_key.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device_opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:279:25 [INFO] [stdout] | [INFO] [stdout] 278 | if device_opt.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = device_opt` [INFO] [stdout] 279 | let d = device_opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `device_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:290:26 [INFO] [stdout] | [INFO] [stdout] 289 | if device_res.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = device_res` [INFO] [stdout] 290 | let device = device_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:294:17 [INFO] [stdout] | [INFO] [stdout] 293 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 294 | self._cache.as_ref().unwrap().put(USERAGENT_CACHE_TYPE.to_string(), cache_key, device.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:296:13 [INFO] [stdout] | [INFO] [stdout] 296 | return Ok(device); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 - return Ok(device); [INFO] [stdout] 296 + Ok(device) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | return Err(device_res.err().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return Err(device_res.err().unwrap()); [INFO] [stdout] 298 + Err(device_res.err().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/./wmclient.rs:477:12 [INFO] [stdout] | [INFO] [stdout] 477 | if ltime.len() > 0 && self._ltime != ltime { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ltime.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:487:20 [INFO] [stdout] | [INFO] [stdout] 486 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 487 | return self._cache.as_ref().unwrap().get_actual_sizes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:489:9 [INFO] [stdout] | [INFO] [stdout] 489 | return (0, 0); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 489 - return (0, 0); [INFO] [stdout] 489 + (0, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 305 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 306 | self._cache.as_ref().unwrap().clear(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_data` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:496:26 [INFO] [stdout] | [INFO] [stdout] 495 | if os_data.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = os_data` [INFO] [stdout] 496 | let wm_err = os_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `mk_md_lock_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:313:35 [INFO] [stdout] | [INFO] [stdout] 312 | if mk_md_lock_res.is_ok() { [INFO] [stdout] | ------------------------- help: try: `if let Ok() = mk_md_lock_res` [INFO] [stdout] 313 | let mut make_models = mk_md_lock_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:502:23 [INFO] [stdout] | [INFO] [stdout] 501 | if os_guard.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = os_guard` [INFO] [stdout] 502 | let vec = os_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dev_makes_lock_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:319:36 [INFO] [stdout] | [INFO] [stdout] 318 | if dev_makes_lock_guard.is_ok() { [INFO] [stdout] | ------------------------------- help: try: `if let Ok() = dev_makes_lock_guard` [INFO] [stdout] 319 | let mut device_makes = dev_makes_lock_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dev_makes_map_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:323:17 [INFO] [stdout] | [INFO] [stdout] 322 | if dev_makes_map_guard.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = dev_makes_map_guard` [INFO] [stdout] 323 | dev_makes_map_guard.unwrap().clear(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:504:13 [INFO] [stdout] | [INFO] [stdout] 504 | return Ok(ret_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 504 - return Ok(ret_val); [INFO] [stdout] 504 + Ok(ret_val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dev_os_lock_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:329:35 [INFO] [stdout] | [INFO] [stdout] 328 | if dev_os_lock_res.is_ok() { [INFO] [stdout] | -------------------------- help: try: `if let Ok() = dev_os_lock_res` [INFO] [stdout] 329 | let mut device_oses = dev_os_lock_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:507:13 [INFO] [stdout] | [INFO] [stdout] 507 | return Err(WmError { msg: format!("Cannot retrieve device OS list: {}", guard_err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 507 - return Err(WmError { msg: format!("Cannot retrieve device OS list: {}", guard_err.to_string()) }); [INFO] [stdout] 507 + Err(WmError { msg: format!("Cannot retrieve device OS list: {}", guard_err.to_string()) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_ver_map_lock_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:335:34 [INFO] [stdout] | [INFO] [stdout] 334 | if os_ver_map_lock_res.is_ok() { [INFO] [stdout] | ------------------------------ help: try: `if let Ok() = os_ver_map_lock_res` [INFO] [stdout] 335 | let mut os_ver_map = os_ver_map_lock_res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:507:94 [INFO] [stdout] | [INFO] [stdout] 507 | return Err(WmError { msg: format!("Cannot retrieve device OS list: {}", guard_err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_data` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:517:26 [INFO] [stdout] | [INFO] [stdout] 516 | if os_data.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = os_data` [INFO] [stdout] 517 | let wm_err = os_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_ver_map_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:523:30 [INFO] [stdout] | [INFO] [stdout] 522 | if os_ver_map_guard.is_ok() { [INFO] [stdout] | --------------------------- help: try: `if let Ok() = os_ver_map_guard` [INFO] [stdout] 523 | let os_ver_map = os_ver_map_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | return format!("{}://{}:{}{}", self._scheme.as_str(), self._host.as_str(), self._port.as_str(), path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 349 - return format!("{}://{}:{}{}", self._scheme.as_str(), self._host.as_str(), self._port.as_str(), path); [INFO] [stdout] 349 + format!("{}://{}:{}{}", self._scheme.as_str(), self._host.as_str(), self._port.as_str(), path) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `h_val` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:359:33 [INFO] [stdout] | [INFO] [stdout] 358 | if h_val.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = h_val` [INFO] [stdout] 359 | key = key + h_val.unwrap().as_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:366:9 [INFO] [stdout] | [INFO] [stdout] 366 | return Some(str_digest.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return Some(str_digest.to_string()); [INFO] [stdout] 366 + Some(str_digest.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:538:96 [INFO] [stdout] | [INFO] [stdout] 538 | Err(WmError { msg: format!("Cannot retrieve device OS versions list: {}", guard_err.to_string()) }) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/./wmclient.rs:359:21 [INFO] [stdout] | [INFO] [stdout] 359 | key = key + h_val.unwrap().as_str(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `key += h_val.unwrap().as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `makes_data` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:546:26 [INFO] [stdout] | [INFO] [stdout] 545 | if makes_data.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = makes_data` [INFO] [stdout] 546 | let wm_err = makes_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:372:9 [INFO] [stdout] | [INFO] [stdout] 372 | return ua; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 372 - return ua; [INFO] [stdout] 372 + ua [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:552:23 [INFO] [stdout] | [INFO] [stdout] 551 | if guard.is_ok() { [INFO] [stdout] | ---------------- help: try: `if let Ok() = guard` [INFO] [stdout] 552 | let vec = guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:554:13 [INFO] [stdout] | [INFO] [stdout] 554 | return Ok(ret_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 554 - return Ok(ret_val); [INFO] [stdout] 554 + Ok(ret_val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:385:16 [INFO] [stdout] | [INFO] [stdout] 384 | return if result.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = result` [INFO] [stdout] 385 | Ok(result.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:557:13 [INFO] [stdout] | [INFO] [stdout] 557 | return Err(WmError { msg: format!("Cannot retrieve device makes list: {}", guard_err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 557 - return Err(WmError { msg: format!("Cannot retrieve device makes list: {}", guard_err.to_string()) }); [INFO] [stdout] 557 + Err(WmError { msg: format!("Cannot retrieve device makes list: {}", guard_err.to_string()) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / return if result.is_ok() { [INFO] [stdout] 385 | | Ok(result.unwrap()) [INFO] [stdout] 386 | | } else { [INFO] [stdout] 387 | | let err = result.err().unwrap(); [INFO] [stdout] 388 | | let msg = format!("Unable to perform get for path {}. Error {}", url, err.to_string()); [INFO] [stdout] 389 | | Err(WmError { msg }) [INFO] [stdout] 390 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 384 ~ if result.is_ok() { [INFO] [stdout] 385 + Ok(result.unwrap()) [INFO] [stdout] 386 + } else { [INFO] [stdout] 387 + let err = result.err().unwrap(); [INFO] [stdout] 388 + let msg = format!("Unable to perform get for path {}. Error {}", url, err.to_string()); [INFO] [stdout] 389 + Err(WmError { msg }) [INFO] [stdout] 390 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:557:97 [INFO] [stdout] | [INFO] [stdout] 557 | return Err(WmError { msg: format!("Cannot retrieve device makes list: {}", guard_err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:388:86 [INFO] [stdout] | [INFO] [stdout] 388 | let msg = format!("Unable to perform get for path {}. Error {}", url, err.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `makes_data` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:566:26 [INFO] [stdout] | [INFO] [stdout] 565 | if makes_data.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = makes_data` [INFO] [stdout] 566 | let wm_err = makes_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:572:36 [INFO] [stdout] | [INFO] [stdout] 571 | if guard.is_ok() { [INFO] [stdout] | ---------------- help: try: `if let Ok() = guard` [INFO] [stdout] 572 | let device_makes_map = guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `vec_opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:576:33 [INFO] [stdout] | [INFO] [stdout] 574 | if vec_opt.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = vec_opt` [INFO] [stdout] 575 | let mut ret_vec: Vec = Vec::new(); [INFO] [stdout] 576 | let md_mk_vec = vec_opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:584:17 [INFO] [stdout] | [INFO] [stdout] 584 | return Ok(ret_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 584 - return Ok(ret_vec); [INFO] [stdout] 584 + Ok(ret_vec) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:586:17 [INFO] [stdout] | [INFO] [stdout] 586 | ... return Err(WmError { msg: format!("Error getting data from WM server: brand {} does not exist or has no devices", brand_name) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 586 - return Err(WmError { msg: format!("Error getting data from WM server: brand {} does not exist or has no devices", brand_name) }); [INFO] [stdout] 586 + Err(WmError { msg: format!("Error getting data from WM server: brand {} does not exist or has no devices", brand_name) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/./wmclient.rs:409:12 [INFO] [stdout] | [INFO] [stdout] 409 | if cap_names.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cap_names.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:590:13 [INFO] [stdout] | [INFO] [stdout] 590 | return Err(WmError { msg: format!("Error getting data from WM server: {}", guard_err.unwrap().to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 590 - return Err(WmError { msg: format!("Error getting data from WM server: {}", guard_err.unwrap().to_string()) }); [INFO] [stdout] 590 + Err(WmError { msg: format!("Error getting data from WM server: {}", guard_err.unwrap().to_string()) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/./wmclient.rs:431:12 [INFO] [stdout] | [INFO] [stdout] 431 | if virtual_cap_names.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!virtual_cap_names.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:590:106 [INFO] [stdout] | [INFO] [stdout] 590 | return Err(WmError { msg: format!("Error getting data from WM server: {}", guard_err.unwrap().to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:597:26 [INFO] [stdout] | [INFO] [stdout] 596 | if os_guard.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = os_guard` [INFO] [stdout] 597 | let os_vec = os_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res_string` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:614:39 [INFO] [stdout] | [INFO] [stdout] 613 | if res_string.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = res_string` [INFO] [stdout] 614 | let os_vers_str = res_string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:617:44 [INFO] [stdout] | [INFO] [stdout] 616 | if _res.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = _res` [INFO] [stdout] 617 | os_version_pairs = _res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/./wmclient.rs:477:12 [INFO] [stdout] | [INFO] [stdout] 477 | if ltime.len() > 0 && self._ltime != ltime { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!ltime.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:661:9 [INFO] [stdout] | [INFO] [stdout] 661 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 661 - return None; [INFO] [stdout] 661 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self._cache` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:487:20 [INFO] [stdout] | [INFO] [stdout] 486 | if self._cache.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self._cache` [INFO] [stdout] 487 | return self._cache.as_ref().unwrap().get_actual_sizes(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:489:9 [INFO] [stdout] | [INFO] [stdout] 489 | return (0, 0); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 489 - return (0, 0); [INFO] [stdout] 489 + (0, 0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_data` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:496:26 [INFO] [stdout] | [INFO] [stdout] 495 | if os_data.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = os_data` [INFO] [stdout] 496 | let wm_err = os_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:502:23 [INFO] [stdout] | [INFO] [stdout] 501 | if os_guard.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = os_guard` [INFO] [stdout] 502 | let vec = os_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:504:13 [INFO] [stdout] | [INFO] [stdout] 504 | return Ok(ret_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 504 - return Ok(ret_val); [INFO] [stdout] 504 + Ok(ret_val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:507:13 [INFO] [stdout] | [INFO] [stdout] 507 | return Err(WmError { msg: format!("Cannot retrieve device OS list: {}", guard_err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 507 - return Err(WmError { msg: format!("Cannot retrieve device OS list: {}", guard_err.to_string()) }); [INFO] [stdout] 507 + Err(WmError { msg: format!("Cannot retrieve device OS list: {}", guard_err.to_string()) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:507:94 [INFO] [stdout] | [INFO] [stdout] 507 | return Err(WmError { msg: format!("Cannot retrieve device OS list: {}", guard_err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/./wmclient.rs:636:17 [INFO] [stdout] | [INFO] [stdout] 636 | / let mut ov: Vec = Vec::new(); [INFO] [stdout] 637 | | ov.push(ov_item.device_os_version.clone()); [INFO] [stdout] | |___________________________________________________________^ help: consider using the `vec![]` macro: `let ov: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_data` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:517:26 [INFO] [stdout] | [INFO] [stdout] 516 | if os_data.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = os_data` [INFO] [stdout] 517 | let wm_err = os_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_ver_map_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:523:30 [INFO] [stdout] | [INFO] [stdout] 522 | if os_ver_map_guard.is_ok() { [INFO] [stdout] | --------------------------- help: try: `if let Ok() = os_ver_map_guard` [INFO] [stdout] 523 | let os_ver_map = os_ver_map_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/./wmclient.rs:676:12 [INFO] [stdout] | [INFO] [stdout] 676 | if !dev_makes_guard.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dev_makes_guard.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dev_makes_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:680:29 [INFO] [stdout] | [INFO] [stdout] 676 | if !dev_makes_guard.is_ok() { [INFO] [stdout] | ----------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 680 | let dev_makes = dev_makes_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res_string` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:693:100 [INFO] [stdout] | [INFO] [stdout] 692 | if res_string.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = res_string` [INFO] [stdout] 693 | let _res: Result, serde_json::Error> = serde_json::from_str(res_string.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:695:37 [INFO] [stdout] | [INFO] [stdout] 694 | if _res.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = _res` [INFO] [stdout] 695 | mk_models = _res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `make_model.marketing_name` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:713:34 [INFO] [stdout] | [INFO] [stdout] 712 | if make_model.marketing_name.is_some() { [INFO] [stdout] | -------------------------------------- help: try: `if let Some() = make_model.marketing_name` [INFO] [stdout] 713 | marketing_name = make_model.marketing_name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:744:9 [INFO] [stdout] | [INFO] [stdout] 744 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 744 - return None; [INFO] [stdout] 744 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:538:96 [INFO] [stdout] | [INFO] [stdout] 538 | Err(WmError { msg: format!("Cannot retrieve device OS versions list: {}", guard_err.to_string()) }) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:678:92 [INFO] [stdout] | [INFO] [stdout] 678 | return Some(WmError { msg: format!("Cannot download device makes data: {}", err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `makes_data` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:546:26 [INFO] [stdout] | [INFO] [stdout] 545 | if makes_data.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = makes_data` [INFO] [stdout] 546 | let wm_err = makes_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:552:23 [INFO] [stdout] | [INFO] [stdout] 551 | if guard.is_ok() { [INFO] [stdout] | ---------------- help: try: `if let Ok() = guard` [INFO] [stdout] 552 | let vec = guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/./wmclient.rs:681:16 [INFO] [stdout] | [INFO] [stdout] 681 | if dev_makes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dev_makes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:554:13 [INFO] [stdout] | [INFO] [stdout] 554 | return Ok(ret_val); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 554 - return Ok(ret_val); [INFO] [stdout] 554 + Ok(ret_val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:697:120 [INFO] [stdout] | [INFO] [stdout] 697 | ...parse device makes data {} ", _res.err().unwrap().to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:701:109 [INFO] [stdout] | [INFO] [stdout] 701 | return Some(WmError { msg: format!("Could not parse device makes data {} ", err.unwrap().to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/./wmclient.rs:722:17 [INFO] [stdout] | [INFO] [stdout] 722 | / let mut model_market_names: Vec = Vec::new(); [INFO] [stdout] 723 | | model_market_names.push(md_mk_name); [INFO] [stdout] | |____________________________________________________^ help: consider using the `vec![]` macro: `let model_market_names: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:557:13 [INFO] [stdout] | [INFO] [stdout] 557 | return Err(WmError { msg: format!("Cannot retrieve device makes list: {}", guard_err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 557 - return Err(WmError { msg: format!("Cannot retrieve device makes list: {}", guard_err.to_string()) }); [INFO] [stdout] 557 + Err(WmError { msg: format!("Cannot retrieve device makes list: {}", guard_err.to_string()) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:557:97 [INFO] [stdout] | [INFO] [stdout] 557 | return Err(WmError { msg: format!("Cannot retrieve device makes list: {}", guard_err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `makes_data` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:566:26 [INFO] [stdout] | [INFO] [stdout] 565 | if makes_data.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = makes_data` [INFO] [stdout] 566 | let wm_err = makes_data.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:572:36 [INFO] [stdout] | [INFO] [stdout] 571 | if guard.is_ok() { [INFO] [stdout] | ---------------- help: try: `if let Ok() = guard` [INFO] [stdout] 572 | let device_makes_map = guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `vec_opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:576:33 [INFO] [stdout] | [INFO] [stdout] 574 | if vec_opt.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = vec_opt` [INFO] [stdout] 575 | let mut ret_vec: Vec = Vec::new(); [INFO] [stdout] 576 | let md_mk_vec = vec_opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:584:17 [INFO] [stdout] | [INFO] [stdout] 584 | return Ok(ret_vec); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 584 - return Ok(ret_vec); [INFO] [stdout] 584 + Ok(ret_vec) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:586:17 [INFO] [stdout] | [INFO] [stdout] 586 | ... return Err(WmError { msg: format!("Error getting data from WM server: brand {} does not exist or has no devices", brand_name) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 586 - return Err(WmError { msg: format!("Error getting data from WM server: brand {} does not exist or has no devices", brand_name) }); [INFO] [stdout] 586 + Err(WmError { msg: format!("Error getting data from WM server: brand {} does not exist or has no devices", brand_name) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:590:13 [INFO] [stdout] | [INFO] [stdout] 590 | return Err(WmError { msg: format!("Error getting data from WM server: {}", guard_err.unwrap().to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 590 - return Err(WmError { msg: format!("Error getting data from WM server: {}", guard_err.unwrap().to_string()) }); [INFO] [stdout] 590 + Err(WmError { msg: format!("Error getting data from WM server: {}", guard_err.unwrap().to_string()) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:590:106 [INFO] [stdout] | [INFO] [stdout] 590 | return Err(WmError { msg: format!("Error getting data from WM server: {}", guard_err.unwrap().to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `os_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:597:26 [INFO] [stdout] | [INFO] [stdout] 596 | if os_guard.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = os_guard` [INFO] [stdout] 597 | let os_vec = os_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res_string` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:614:39 [INFO] [stdout] | [INFO] [stdout] 613 | if res_string.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = res_string` [INFO] [stdout] 614 | let os_vers_str = res_string.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:617:44 [INFO] [stdout] | [INFO] [stdout] 616 | if _res.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = _res` [INFO] [stdout] 617 | os_version_pairs = _res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:661:9 [INFO] [stdout] | [INFO] [stdout] 661 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 661 - return None; [INFO] [stdout] 661 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/./wmclient.rs:636:17 [INFO] [stdout] | [INFO] [stdout] 636 | / let mut ov: Vec = Vec::new(); [INFO] [stdout] 637 | | ov.push(ov_item.device_os_version.clone()); [INFO] [stdout] | |___________________________________________________________^ help: consider using the `vec![]` macro: `let ov: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/./wmclient.rs:676:12 [INFO] [stdout] | [INFO] [stdout] 676 | if !dev_makes_guard.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dev_makes_guard.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dev_makes_guard` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:680:29 [INFO] [stdout] | [INFO] [stdout] 676 | if !dev_makes_guard.is_ok() { [INFO] [stdout] | ----------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 680 | let dev_makes = dev_makes_guard.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `res_string` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:693:100 [INFO] [stdout] | [INFO] [stdout] 692 | if res_string.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = res_string` [INFO] [stdout] 693 | let _res: Result, serde_json::Error> = serde_json::from_str(res_string.unwrap().as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `_res` after checking its variant with `is_ok` [INFO] [stdout] --> src/./wmclient.rs:695:37 [INFO] [stdout] | [INFO] [stdout] 694 | if _res.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = _res` [INFO] [stdout] 695 | mk_models = _res.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `make_model.marketing_name` after checking its variant with `is_some` [INFO] [stdout] --> src/./wmclient.rs:713:34 [INFO] [stdout] | [INFO] [stdout] 712 | if make_model.marketing_name.is_some() { [INFO] [stdout] | -------------------------------------- help: try: `if let Some() = make_model.marketing_name` [INFO] [stdout] 713 | marketing_name = make_model.marketing_name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./wmclient.rs:744:9 [INFO] [stdout] | [INFO] [stdout] 744 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 744 - return None; [INFO] [stdout] 744 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:678:92 [INFO] [stdout] | [INFO] [stdout] 678 | return Some(WmError { msg: format!("Cannot download device makes data: {}", err.to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/./wmclient.rs:681:16 [INFO] [stdout] | [INFO] [stdout] 681 | if dev_makes.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dev_makes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:697:120 [INFO] [stdout] | [INFO] [stdout] 697 | ...parse device makes data {} ", _res.err().unwrap().to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/./wmclient.rs:701:109 [INFO] [stdout] | [INFO] [stdout] 701 | return Some(WmError { msg: format!("Could not parse device makes data {} ", err.unwrap().to_string()) }); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/./wmclient.rs:722:17 [INFO] [stdout] | [INFO] [stdout] 722 | / let mut model_market_names: Vec = Vec::new(); [INFO] [stdout] 723 | | model_market_names.push(md_mk_name); [INFO] [stdout] | |____________________________________________________^ help: consider using the `vec![]` macro: `let model_market_names: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./cache.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 59 | if opt.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = opt` [INFO] [stdout] 60 | let d_ref = opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./cache.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return None; [INFO] [stdout] 64 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `opt` after checking its variant with `is_some` [INFO] [stdout] --> src/./cache.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 59 | if opt.is_some() { [INFO] [stdout] | ---------------- help: try: `if let Some() = opt` [INFO] [stdout] 60 | let d_ref = opt.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/./cache.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return None; [INFO] [stdout] 64 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 34s [INFO] running `Command { std: "docker" "inspect" "379f86d104859ed6574b613f9c275fdcfea5c25462f263d67e768f72e1203910", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "379f86d104859ed6574b613f9c275fdcfea5c25462f263d67e768f72e1203910", kill_on_drop: false }` [INFO] [stdout] 379f86d104859ed6574b613f9c275fdcfea5c25462f263d67e768f72e1203910