[INFO] fetching crate wasmlet 0.0.2... [INFO] linting wasmlet-0.0.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate wasmlet 0.0.2 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate wasmlet 0.0.2 [INFO] finished tweaking crates.io crate wasmlet 0.0.2 [INFO] tweaked toml for crates.io crate wasmlet 0.0.2 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate wasmlet 0.0.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate wasmlet 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasmtime-cabish v0.5.0 [INFO] [stderr] Downloaded wasm-metadata v0.229.0 [INFO] [stderr] Downloaded wasmtime-jit-icache-coherence v33.0.2 [INFO] [stderr] Downloaded cranelift-srcgen v0.120.2 [INFO] [stderr] Downloaded cap-rand v3.4.4 [INFO] [stderr] Downloaded cranelift v0.120.2 [INFO] [stderr] Downloaded wasmtime-component-util v33.0.2 [INFO] [stderr] Downloaded ambient-authority v0.0.2 [INFO] [stderr] Downloaded cap-net-ext v3.4.4 [INFO] [stderr] Downloaded cranelift-jit v0.120.2 [INFO] [stderr] Downloaded wasi-preview1-component-adapter-provider v34.0.2 [INFO] [stderr] Downloaded cap-primitives v3.4.4 [INFO] [stderr] Downloaded wit-parser v0.229.0 [INFO] [stderr] Downloaded cranelift-codegen-meta v0.120.2 [INFO] [stderr] Downloaded wasmtime-component-macro v33.0.2 [INFO] [stderr] Downloaded winch-codegen v33.0.2 [INFO] [stderr] Downloaded wasmtime-environ v33.0.2 [INFO] [stderr] Downloaded wit-component v0.229.0 [INFO] [stderr] Downloaded regalloc2 v0.12.2 [INFO] [stderr] Downloaded wasmtime v33.0.2 [INFO] [stderr] Downloaded wasmtime-cranelift v33.0.2 [INFO] [stderr] Downloaded wasmparser v0.229.0 [INFO] [stderr] Downloaded cap-time-ext v3.4.4 [INFO] [stderr] Downloaded cranelift-assembler-x64-meta v0.120.2 [INFO] [stderr] Downloaded cc v1.2.31 [INFO] [stderr] Downloaded cap-std v3.4.4 [INFO] [stderr] Downloaded wasmtime-winch v33.0.2 [INFO] [stderr] Downloaded io-extras v0.18.4 [INFO] [stderr] Downloaded cranelift-assembler-x64 v0.120.2 [INFO] [stderr] Downloaded cranelift-codegen v0.120.2 [INFO] [stderr] Downloaded serde_json v1.0.142 [INFO] [stderr] Downloaded wasmtime-slab v33.0.2 [INFO] [stderr] Downloaded cranelift-frontend v0.120.2 [INFO] [stderr] Downloaded cranelift-isle v0.120.2 [INFO] [stderr] Downloaded pulley-interpreter v33.0.2 [INFO] [stderr] Downloaded rustix-linux-procfs v0.1.1 [INFO] [stderr] Downloaded psm v0.1.26 [INFO] [stderr] Downloaded wasmtime-wit-bindgen v33.0.2 [INFO] [stderr] Downloaded wasmtime-fiber v33.0.2 [INFO] [stderr] Downloaded cranelift-bitset v0.120.2 [INFO] [stderr] Downloaded wasmprinter v0.229.0 [INFO] [stderr] Downloaded wasm-encoder v0.229.0 [INFO] [stderr] Downloaded cranelift-module v0.120.2 [INFO] [stderr] Downloaded cap-fs-ext v3.4.4 [INFO] [stderr] Downloaded io-lifetimes v2.0.4 [INFO] [stderr] Downloaded cabish v0.2.0 [INFO] [stderr] Downloaded wasmtime-cache v33.0.2 [INFO] [stderr] Downloaded cranelift-bforest v0.120.2 [INFO] [stderr] Downloaded cranelift-control v0.120.2 [INFO] [stderr] Downloaded cranelift-native v0.120.2 [INFO] [stderr] Downloaded wasmtime-versioned-export-macros v33.0.2 [INFO] [stderr] Downloaded fs-set-times v0.20.3 [INFO] [stderr] Downloaded maybe-owned v0.3.4 [INFO] [stderr] Downloaded fd-lock v4.0.4 [INFO] [stderr] Downloaded winx v0.36.4 [INFO] [stderr] Downloaded system-interface v0.27.3 [INFO] [stderr] Downloaded memfd v0.6.4 [INFO] [stderr] Downloaded trait-variant v0.1.2 [INFO] [stderr] Downloaded wasmtime-asm-macros v33.0.2 [INFO] [stderr] Downloaded wasmtime-math v33.0.2 [INFO] [stderr] Downloaded cranelift-codegen-shared v0.120.2 [INFO] [stderr] Downloaded cranelift-entity v0.120.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3580c6fb681b3b55babdf458b4343649c443b2f25d2dd3afb9b19107b5c371e1 [INFO] running `Command { std: "docker" "start" "-a" "3580c6fb681b3b55babdf458b4343649c443b2f25d2dd3afb9b19107b5c371e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3580c6fb681b3b55babdf458b4343649c443b2f25d2dd3afb9b19107b5c371e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3580c6fb681b3b55babdf458b4343649c443b2f25d2dd3afb9b19107b5c371e1", kill_on_drop: false }` [INFO] [stdout] 3580c6fb681b3b55babdf458b4343649c443b2f25d2dd3afb9b19107b5c371e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bf1901009edd1fdfc36d0b16da20bc311611c04e88511d9ecb61741832118056 [INFO] running `Command { std: "docker" "start" "-a" "bf1901009edd1fdfc36d0b16da20bc311611c04e88511d9ecb61741832118056", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Compiling cranelift-srcgen v0.120.2 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Compiling cranelift-isle v0.120.2 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking cranelift-bitset v0.120.2 [INFO] [stderr] Compiling cranelift-assembler-x64-meta v0.120.2 [INFO] [stderr] Compiling pulley-interpreter v33.0.2 [INFO] [stderr] Compiling target-lexicon v0.13.2 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling cranelift-codegen-shared v0.120.2 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Compiling cranelift-assembler-x64 v0.120.2 [INFO] [stderr] Compiling cc v1.2.31 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking cranelift-entity v0.120.2 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Compiling cranelift-codegen-meta v0.120.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling wasmparser v0.229.0 [INFO] [stderr] Compiling serde_json v1.0.142 [INFO] [stderr] Checking bumpalo v3.19.0 [INFO] [stderr] Checking wasmtime-math v33.0.2 [INFO] [stderr] Compiling io-lifetimes v2.0.4 [INFO] [stderr] Checking arbitrary v1.4.1 [INFO] [stderr] Checking regalloc2 v0.12.2 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking cranelift-control v0.120.2 [INFO] [stderr] Checking cranelift-bforest v0.120.2 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Compiling cranelift-codegen v0.120.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Compiling wasmtime-versioned-export-macros v33.0.2 [INFO] [stderr] Compiling wasm-encoder v0.229.0 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling io-extras v0.18.4 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Compiling cap-primitives v3.4.4 [INFO] [stderr] Checking leb128fmt v0.1.0 [INFO] [stderr] Checking ambient-authority v0.0.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking cobs v0.3.0 [INFO] [stderr] Checking fs-set-times v0.20.3 [INFO] [stderr] Checking rustix-linux-procfs v0.1.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking maybe-owned v0.3.4 [INFO] [stderr] Compiling cpp_demangle v0.4.4 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking postcard v1.1.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking winnow v0.7.12 [INFO] [stderr] Compiling cap-std v3.4.4 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling id-arena v2.2.1 [INFO] [stderr] Checking wasmprinter v0.229.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling wasmtime-fiber v33.0.2 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking rustc-demangle v0.1.26 [INFO] [stderr] Compiling wasmtime-component-macro v33.0.2 [INFO] [stderr] Checking wasmtime-component-util v33.0.2 [INFO] [stderr] Compiling wasmtime-cache v33.0.2 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling wasmtime v33.0.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking wasmtime-jit-icache-coherence v33.0.2 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking wasmtime-asm-macros v33.0.2 [INFO] [stderr] Compiling rustls v0.23.31 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling wit-parser v0.229.0 [INFO] [stderr] Checking wasmtime-environ v33.0.2 [INFO] [stderr] Checking memfd v0.6.4 [INFO] [stderr] Checking rustls-webpki v0.103.4 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling trait-variant v0.1.2 [INFO] [stderr] Compiling cap-fs-ext v3.4.4 [INFO] [stderr] Checking wasmtime-slab v33.0.2 [INFO] [stderr] Compiling schemars v0.8.22 [INFO] [stderr] Compiling system-interface v0.27.3 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Compiling schemars_derive v0.8.22 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking region v3.0.2 [INFO] [stderr] Compiling wasmtime-wit-bindgen v33.0.2 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking wasm-metadata v0.229.0 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking raw-cpuid v11.5.0 [INFO] [stderr] Checking cabish v0.2.0 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking dyn-clone v1.0.20 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking cap-time-ext v3.4.4 [INFO] [stderr] Checking cap-rand v3.4.4 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking wit-component v0.229.0 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking cap-net-ext v3.4.4 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking libloading v0.8.8 [INFO] [stderr] Checking wasi-preview1-component-adapter-provider v34.0.2 [INFO] [stderr] Checking quanta v0.12.6 [INFO] [stderr] Checking cranelift-native v0.120.2 [INFO] [stderr] Checking cranelift-frontend v0.120.2 [INFO] [stderr] Checking cranelift-module v0.120.2 [INFO] [stderr] Checking cranelift v0.120.2 [INFO] [stderr] Checking cranelift-jit v0.120.2 [INFO] [stderr] Checking wasmtime-cranelift v33.0.2 [INFO] [stderr] Checking wasmtime-cabish v0.5.0 [INFO] [stderr] Checking wasmlet v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/engine/wasi/io/mod.rs:234:21 [INFO] [stdout] | [INFO] [stdout] 234 | let mut max = u64::try_from(max).unwrap_or(u64::MAX); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/engine/wasi/io/mod.rs:234:21 [INFO] [stdout] | [INFO] [stdout] 234 | let mut max = u64::try_from(max).unwrap_or(u64::MAX); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self` [INFO] [stdout] --> src/engine/wasi/filesystem/mod.rs:850:29 [INFO] [stdout] | [INFO] [stdout] 850 | async fn is_same_object(self, other: Self) -> wasmtime::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/engine/wasi/http/client.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 53 | ) -> impl Future< [INFO] [stdout] | __________^ [INFO] [stdout] 54 | | Output = wasmtime::Result< [INFO] [stdout] 55 | | Result< [INFO] [stdout] ... | [INFO] [stdout] 71 | | >, [INFO] [stdout] 72 | | > + Send; [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_body` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 202 | let body = get_body(&mut self.table, &body)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 202 - let body = get_body(&mut self.table, &body)?; [INFO] [stdout] 202 + let body = get_body(&self.table, &body)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:285:24 [INFO] [stdout] | [INFO] [stdout] 285 | if let Err(..) = tx.send(trailers) { [INFO] [stdout] | -------^^^^^^^-------------------- help: try: `if tx.send(trailers).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:424:16 [INFO] [stdout] | [INFO] [stdout] 424 | if let Err(..) = response_tx.send(response) { [INFO] [stdout] | -------^^^^^^^----------------------------- help: try: `if response_tx.send(response).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_fields_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:472:39 [INFO] [stdout] | [INFO] [stdout] 472 | let fields = get_fields_inner(&mut self.table, &fields)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 472 - let fields = get_fields_inner(&mut self.table, &fields)?; [INFO] [stdout] 472 + let fields = get_fields_inner(&self.table, &fields)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_fields_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:485:39 [INFO] [stdout] | [INFO] [stdout] 485 | let fields = get_fields_inner(&mut self.table, &fields)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 485 - let fields = get_fields_inner(&mut self.table, &fields)?; [INFO] [stdout] 485 + let fields = get_fields_inner(&self.table, &fields)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:647:50 [INFO] [stdout] | [INFO] [stdout] 647 | let Request { method, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 647 - let Request { method, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 647 + let Request { method, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:670:25 [INFO] [stdout] | [INFO] [stdout] 670 | } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 670 - } = get_request(&mut self.table, &req)?; [INFO] [stdout] 670 + } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:692:50 [INFO] [stdout] | [INFO] [stdout] 692 | let Request { scheme, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 692 - let Request { scheme, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 692 + let Request { scheme, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:714:53 [INFO] [stdout] | [INFO] [stdout] 714 | let Request { authority, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 714 - let Request { authority, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 714 + let Request { authority, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:768:58 [INFO] [stdout] | [INFO] [stdout] 768 | let IncomingRequest { method, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 768 - let IncomingRequest { method, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 768 + let IncomingRequest { method, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:778:25 [INFO] [stdout] | [INFO] [stdout] 778 | } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 778 - } = get_request(&mut self.table, &req)?; [INFO] [stdout] 778 + } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:783:58 [INFO] [stdout] | [INFO] [stdout] 783 | let IncomingRequest { scheme, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 783 - let IncomingRequest { scheme, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 783 + let IncomingRequest { scheme, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:788:61 [INFO] [stdout] | [INFO] [stdout] 788 | let IncomingRequest { authority, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 788 - let IncomingRequest { authority, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 788 + let IncomingRequest { authority, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request_options_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:819:40 [INFO] [stdout] | [INFO] [stdout] 819 | } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 819 - } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] 819 + } = *get_request_options_inner(&self.table, &opts)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request_options_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:849:40 [INFO] [stdout] | [INFO] [stdout] 849 | } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 849 - } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] 849 + } = *get_request_options_inner(&self.table, &opts)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request_options_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:879:40 [INFO] [stdout] | [INFO] [stdout] 879 | } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 879 - } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] 879 + } = *get_request_options_inner(&self.table, &opts)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_response` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:910:32 [INFO] [stdout] | [INFO] [stdout] 910 | let res = get_response(&mut self.table, &res)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 910 - let res = get_response(&mut self.table, &res)?; [INFO] [stdout] 910 + let res = get_response(&self.table, &res)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_response` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:969:32 [INFO] [stdout] | [INFO] [stdout] 969 | let res = get_response(&mut self.table, &res)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 969 - let res = get_response(&mut self.table, &res)?; [INFO] [stdout] 969 + let res = get_response(&self.table, &res)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/engine/wasi/io/mod.rs:230:66 [INFO] [stdout] | [INFO] [stdout] 230 | let max = match sockopt::socket_send_buffer_size(&stream) { [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:141:54 [INFO] [stdout] | [INFO] [stdout] 141 | let TcpSocket { tcp_state, .. } = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 141 - let TcpSocket { tcp_state, .. } = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 141 + let TcpSocket { tcp_state, .. } = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:151:31 [INFO] [stdout] | [INFO] [stdout] 151 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 151 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 151 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:163:31 [INFO] [stdout] | [INFO] [stdout] 163 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 163 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 163 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:171:31 [INFO] [stdout] | [INFO] [stdout] 171 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 171 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 171 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:176:31 [INFO] [stdout] | [INFO] [stdout] 176 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 176 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 176 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:181:31 [INFO] [stdout] | [INFO] [stdout] 181 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 181 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 181 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:198:31 [INFO] [stdout] | [INFO] [stdout] 198 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 198 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 198 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:207:31 [INFO] [stdout] | [INFO] [stdout] 207 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 207 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 207 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:215:31 [INFO] [stdout] | [INFO] [stdout] 215 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 215 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 215 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:232:31 [INFO] [stdout] | [INFO] [stdout] 232 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 232 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 232 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:241:31 [INFO] [stdout] | [INFO] [stdout] 241 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 241 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 241 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:249:31 [INFO] [stdout] | [INFO] [stdout] 249 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 249 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 249 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:258:31 [INFO] [stdout] | [INFO] [stdout] 258 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 258 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 258 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:266:31 [INFO] [stdout] | [INFO] [stdout] 266 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 266 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 266 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:275:31 [INFO] [stdout] | [INFO] [stdout] 275 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 275 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 275 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:283:31 [INFO] [stdout] | [INFO] [stdout] 283 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 283 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 283 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:300:31 [INFO] [stdout] | [INFO] [stdout] 300 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 300 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 300 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 145 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 145 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 145 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:153:31 [INFO] [stdout] | [INFO] [stdout] 153 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 153 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 153 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:158:31 [INFO] [stdout] | [INFO] [stdout] 158 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 158 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 158 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:166:31 [INFO] [stdout] | [INFO] [stdout] 166 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 166 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 166 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:175:31 [INFO] [stdout] | [INFO] [stdout] 175 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 175 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 175 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:183:31 [INFO] [stdout] | [INFO] [stdout] 183 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 183 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 183 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 192 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 192 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 192 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:200:31 [INFO] [stdout] | [INFO] [stdout] 200 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 200 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 200 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:209:31 [INFO] [stdout] | [INFO] [stdout] 209 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 209 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 209 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/engine/mod.rs:113:1 [INFO] [stdout] | [INFO] [stdout] 113 | / pub enum Cmd { [INFO] [stdout] 114 | | / ApplyManifest { [INFO] [stdout] 115 | | | manifest: Manifest, [INFO] [stdout] 116 | | | deadline: u64, [INFO] [stdout] 117 | | | result: oneshot::Sender>, [INFO] [stdout] 118 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 88 bytes [INFO] [stdout] 119 | | / Invoke { [INFO] [stdout] 120 | | | name: Box, [INFO] [stdout] 121 | | | invocation: WorkloadInvocation, [INFO] [stdout] 122 | | | result: oneshot::Sender>, [INFO] [stdout] 123 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 336 bytes [INFO] [stdout] 124 | | } [INFO] [stdout] | |___^ the entire enum is at least 336 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 121 - invocation: WorkloadInvocation, [INFO] [stdout] 121 + invocation: Box>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/engine/mod.rs:150:1 [INFO] [stdout] | [INFO] [stdout] 150 | / pub enum WorkloadInvocationPayload { [INFO] [stdout] 151 | | Dynamic(oneshot::Sender<(Store, oneshot::Sender>)>), [INFO] [stdout] | | ----------------------------------------------------------------------------------- the second-largest variant contains at least 8 bytes [INFO] [stdout] 152 | |/ WasiHttpHandler { [INFO] [stdout] 153 | || request: wasi::http::IncomingRequest, [INFO] [stdout] 154 | || response: wasi::http::ResponseOutparam, [INFO] [stdout] 155 | || result: oneshot::Sender>, [INFO] [stdout] 156 | || }, [INFO] [stdout] | ||_____- the largest variant contains at least 272 bytes [INFO] [stdout] 157 | | } [INFO] [stdout] | |__^ the entire enum is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 153 - request: wasi::http::IncomingRequest, [INFO] [stdout] 153 + request: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 216 | if let Err(..) = tx.send(target_store) { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if tx.send(target_store).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/engine/mod.rs:528:5 [INFO] [stdout] | [INFO] [stdout] 528 | / async fn handle_workload( [INFO] [stdout] 529 | | &self, [INFO] [stdout] 530 | | pre: InstancePre, [INFO] [stdout] 531 | | mut invocations: mpsc::Receiver>, [INFO] [stdout] ... | [INFO] [stdout] 536 | | shutdown: watch::Receiver, [INFO] [stdout] 537 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:652:52 [INFO] [stdout] | [INFO] [stdout] 652 | ... if let Err(..) = [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 652 ~ if result.send(Ok(DynamicWorkloadInvocationResult { [INFO] [stdout] 653 + store, [INFO] [stdout] 654 + params, [INFO] [stdout] 655 + results, [INFO] [stdout] 656 + tx: store_tx, [INFO] [stdout] 657 + })).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:670:52 [INFO] [stdout] | [INFO] [stdout] 670 | ... if let Err(..) = result.send(Err(err)) { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if result.send(Err(err)).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:677:44 [INFO] [stdout] | [INFO] [stdout] 677 | ... if let Err(..) = result.send(Err(err)) { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if result.send(Err(err)).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:688:36 [INFO] [stdout] | [INFO] [stdout] 688 | ... if let Err(..) = result.send({ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 688 ~ if result.send({ [INFO] [stdout] 689 + match instance { [INFO] [stdout] 690 + Ok(instance) => { [INFO] [stdout] 691 + let res = [INFO] [stdout] 692 + handle_http(&mut store, &instance, request, response) [INFO] [stdout] 693 + .await; [INFO] [stdout] 694 + if let Ok(()) = res { [INFO] [stdout] 695 + instance_tx.map(|tx| tx.try_send((instance, store))); [INFO] [stdout] 696 + } [INFO] [stdout] 697 + res [INFO] [stdout] 698 + } [INFO] [stdout] 699 + Err(err) => Err(err), [INFO] [stdout] 700 + } [INFO] [stdout] 701 ~ }).is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/engine/mod.rs:719:15 [INFO] [stdout] | [INFO] [stdout] 719 | name: &Box, [INFO] [stdout] | ^^^^^^^^^ help: try: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/engine/mod.rs:972:33 [INFO] [stdout] | [INFO] [stdout] 972 | .map(|(name, conf)| match conf { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 973 | | config::Plugin { src } => { [INFO] [stdout] 974 | | let plugin = Plugin::load(&*src) [INFO] [stdout] 975 | | .with_context(|| format!("failed to load plugin `{src}`"))?; [INFO] [stdout] ... | [INFO] [stdout] 978 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 972 ~ .map(|(name, conf)| { [INFO] [stdout] 973 + let config::Plugin { src } = conf; [INFO] [stdout] 974 + let plugin = Plugin::load(&*src) [INFO] [stdout] 975 + .with_context(|| format!("failed to load plugin `{src}`"))?; [INFO] [stdout] 976 + Ok((name, plugin)) [INFO] [stdout] 977 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `is_*` usually take `self` by mutable reference or `self` by reference or no `self` [INFO] [stdout] --> src/engine/wasi/filesystem/mod.rs:850:29 [INFO] [stdout] | [INFO] [stdout] 850 | async fn is_same_object(self, other: Self) -> wasmtime::Result { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/engine/wasi/http/client.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 53 | ) -> impl Future< [INFO] [stdout] | __________^ [INFO] [stdout] 54 | | Output = wasmtime::Result< [INFO] [stdout] 55 | | Result< [INFO] [stdout] ... | [INFO] [stdout] 71 | | >, [INFO] [stdout] 72 | | > + Send; [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_body` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 202 | let body = get_body(&mut self.table, &body)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 202 - let body = get_body(&mut self.table, &body)?; [INFO] [stdout] 202 + let body = get_body(&self.table, &body)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:285:24 [INFO] [stdout] | [INFO] [stdout] 285 | if let Err(..) = tx.send(trailers) { [INFO] [stdout] | -------^^^^^^^-------------------- help: try: `if tx.send(trailers).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:424:16 [INFO] [stdout] | [INFO] [stdout] 424 | if let Err(..) = response_tx.send(response) { [INFO] [stdout] | -------^^^^^^^----------------------------- help: try: `if response_tx.send(response).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_fields_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:472:39 [INFO] [stdout] | [INFO] [stdout] 472 | let fields = get_fields_inner(&mut self.table, &fields)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 472 - let fields = get_fields_inner(&mut self.table, &fields)?; [INFO] [stdout] 472 + let fields = get_fields_inner(&self.table, &fields)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_fields_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:485:39 [INFO] [stdout] | [INFO] [stdout] 485 | let fields = get_fields_inner(&mut self.table, &fields)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 485 - let fields = get_fields_inner(&mut self.table, &fields)?; [INFO] [stdout] 485 + let fields = get_fields_inner(&self.table, &fields)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:647:50 [INFO] [stdout] | [INFO] [stdout] 647 | let Request { method, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 647 - let Request { method, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 647 + let Request { method, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:670:25 [INFO] [stdout] | [INFO] [stdout] 670 | } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 670 - } = get_request(&mut self.table, &req)?; [INFO] [stdout] 670 + } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:692:50 [INFO] [stdout] | [INFO] [stdout] 692 | let Request { scheme, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 692 - let Request { scheme, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 692 + let Request { scheme, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:714:53 [INFO] [stdout] | [INFO] [stdout] 714 | let Request { authority, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 714 - let Request { authority, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 714 + let Request { authority, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:768:58 [INFO] [stdout] | [INFO] [stdout] 768 | let IncomingRequest { method, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 768 - let IncomingRequest { method, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 768 + let IncomingRequest { method, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:778:25 [INFO] [stdout] | [INFO] [stdout] 778 | } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 778 - } = get_request(&mut self.table, &req)?; [INFO] [stdout] 778 + } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:783:58 [INFO] [stdout] | [INFO] [stdout] 783 | let IncomingRequest { scheme, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 783 - let IncomingRequest { scheme, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 783 + let IncomingRequest { scheme, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:788:61 [INFO] [stdout] | [INFO] [stdout] 788 | let IncomingRequest { authority, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 788 - let IncomingRequest { authority, .. } = get_request(&mut self.table, &req)?; [INFO] [stdout] 788 + let IncomingRequest { authority, .. } = get_request(&self.table, &req)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request_options_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:819:40 [INFO] [stdout] | [INFO] [stdout] 819 | } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 819 - } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] 819 + } = *get_request_options_inner(&self.table, &opts)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request_options_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:849:40 [INFO] [stdout] | [INFO] [stdout] 849 | } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 849 - } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] 849 + } = *get_request_options_inner(&self.table, &opts)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_request_options_inner` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:879:40 [INFO] [stdout] | [INFO] [stdout] 879 | } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 879 - } = *get_request_options_inner(&mut self.table, &opts)? [INFO] [stdout] 879 + } = *get_request_options_inner(&self.table, &opts)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_response` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:910:32 [INFO] [stdout] | [INFO] [stdout] 910 | let res = get_response(&mut self.table, &res)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 910 - let res = get_response(&mut self.table, &res)?; [INFO] [stdout] 910 + let res = get_response(&self.table, &res)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_response` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/http/host/types.rs:969:32 [INFO] [stdout] | [INFO] [stdout] 969 | let res = get_response(&mut self.table, &res)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 969 - let res = get_response(&mut self.table, &res)?; [INFO] [stdout] 969 + let res = get_response(&self.table, &res)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/engine/wasi/io/mod.rs:230:66 [INFO] [stdout] | [INFO] [stdout] 230 | let max = match sockopt::socket_send_buffer_size(&stream) { [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:141:54 [INFO] [stdout] | [INFO] [stdout] 141 | let TcpSocket { tcp_state, .. } = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 141 - let TcpSocket { tcp_state, .. } = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 141 + let TcpSocket { tcp_state, .. } = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:151:31 [INFO] [stdout] | [INFO] [stdout] 151 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 151 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 151 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:163:31 [INFO] [stdout] | [INFO] [stdout] 163 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 163 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 163 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:171:31 [INFO] [stdout] | [INFO] [stdout] 171 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 171 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 171 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:176:31 [INFO] [stdout] | [INFO] [stdout] 176 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 176 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 176 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:181:31 [INFO] [stdout] | [INFO] [stdout] 181 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 181 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 181 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:198:31 [INFO] [stdout] | [INFO] [stdout] 198 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 198 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 198 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:207:31 [INFO] [stdout] | [INFO] [stdout] 207 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 207 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 207 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:215:31 [INFO] [stdout] | [INFO] [stdout] 215 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 215 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 215 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:232:31 [INFO] [stdout] | [INFO] [stdout] 232 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 232 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 232 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:241:31 [INFO] [stdout] | [INFO] [stdout] 241 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 241 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 241 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:249:31 [INFO] [stdout] | [INFO] [stdout] 249 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 249 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 249 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:258:31 [INFO] [stdout] | [INFO] [stdout] 258 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 258 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 258 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:266:31 [INFO] [stdout] | [INFO] [stdout] 266 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 266 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 266 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:275:31 [INFO] [stdout] | [INFO] [stdout] 275 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 275 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 275 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:283:31 [INFO] [stdout] | [INFO] [stdout] 283 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 283 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 283 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/tcp.rs:300:31 [INFO] [stdout] | [INFO] [stdout] 300 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 300 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 300 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 145 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 145 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 145 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:153:31 [INFO] [stdout] | [INFO] [stdout] 153 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 153 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 153 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:158:31 [INFO] [stdout] | [INFO] [stdout] 158 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 158 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 158 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:166:31 [INFO] [stdout] | [INFO] [stdout] 166 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 166 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 166 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:175:31 [INFO] [stdout] | [INFO] [stdout] 175 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 175 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 175 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:183:31 [INFO] [stdout] | [INFO] [stdout] 183 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 183 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 183 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 192 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 192 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 192 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:200:31 [INFO] [stdout] | [INFO] [stdout] 200 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 200 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 200 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `get_socket` doesn't need a mutable reference [INFO] [stdout] --> src/engine/wasi/sockets/host/udp.rs:209:31 [INFO] [stdout] | [INFO] [stdout] 209 | let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 209 - let sock = get_socket(&mut self.table, &socket)?; [INFO] [stdout] 209 + let sock = get_socket(&self.table, &socket)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/engine/mod.rs:113:1 [INFO] [stdout] | [INFO] [stdout] 113 | / pub enum Cmd { [INFO] [stdout] 114 | | / ApplyManifest { [INFO] [stdout] 115 | | | manifest: Manifest, [INFO] [stdout] 116 | | | deadline: u64, [INFO] [stdout] 117 | | | result: oneshot::Sender>, [INFO] [stdout] 118 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 88 bytes [INFO] [stdout] 119 | | / Invoke { [INFO] [stdout] 120 | | | name: Box, [INFO] [stdout] 121 | | | invocation: WorkloadInvocation, [INFO] [stdout] 122 | | | result: oneshot::Sender>, [INFO] [stdout] 123 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 336 bytes [INFO] [stdout] 124 | | } [INFO] [stdout] | |___^ the entire enum is at least 336 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 121 - invocation: WorkloadInvocation, [INFO] [stdout] 121 + invocation: Box>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/engine/mod.rs:150:1 [INFO] [stdout] | [INFO] [stdout] 150 | / pub enum WorkloadInvocationPayload { [INFO] [stdout] 151 | | Dynamic(oneshot::Sender<(Store, oneshot::Sender>)>), [INFO] [stdout] | | ----------------------------------------------------------------------------------- the second-largest variant contains at least 8 bytes [INFO] [stdout] 152 | |/ WasiHttpHandler { [INFO] [stdout] 153 | || request: wasi::http::IncomingRequest, [INFO] [stdout] 154 | || response: wasi::http::ResponseOutparam, [INFO] [stdout] 155 | || result: oneshot::Sender>, [INFO] [stdout] 156 | || }, [INFO] [stdout] | ||_____- the largest variant contains at least 272 bytes [INFO] [stdout] 157 | | } [INFO] [stdout] | |__^ the entire enum is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 153 - request: wasi::http::IncomingRequest, [INFO] [stdout] 153 + request: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 216 | if let Err(..) = tx.send(target_store) { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if tx.send(target_store).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/engine/mod.rs:528:5 [INFO] [stdout] | [INFO] [stdout] 528 | / async fn handle_workload( [INFO] [stdout] 529 | | &self, [INFO] [stdout] 530 | | pre: InstancePre, [INFO] [stdout] 531 | | mut invocations: mpsc::Receiver>, [INFO] [stdout] ... | [INFO] [stdout] 536 | | shutdown: watch::Receiver, [INFO] [stdout] 537 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:652:52 [INFO] [stdout] | [INFO] [stdout] 652 | ... if let Err(..) = [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 652 ~ if result.send(Ok(DynamicWorkloadInvocationResult { [INFO] [stdout] 653 + store, [INFO] [stdout] 654 + params, [INFO] [stdout] 655 + results, [INFO] [stdout] 656 + tx: store_tx, [INFO] [stdout] 657 + })).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:670:52 [INFO] [stdout] | [INFO] [stdout] 670 | ... if let Err(..) = result.send(Err(err)) { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if result.send(Err(err)).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:677:44 [INFO] [stdout] | [INFO] [stdout] 677 | ... if let Err(..) = result.send(Err(err)) { [INFO] [stdout] | -------^^^^^^^------------------------ help: try: `if result.send(Err(err)).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/engine/mod.rs:688:36 [INFO] [stdout] | [INFO] [stdout] 688 | ... if let Err(..) = result.send({ [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 688 ~ if result.send({ [INFO] [stdout] 689 + match instance { [INFO] [stdout] 690 + Ok(instance) => { [INFO] [stdout] 691 + let res = [INFO] [stdout] 692 + handle_http(&mut store, &instance, request, response) [INFO] [stdout] 693 + .await; [INFO] [stdout] 694 + if let Ok(()) = res { [INFO] [stdout] 695 + instance_tx.map(|tx| tx.try_send((instance, store))); [INFO] [stdout] 696 + } [INFO] [stdout] 697 + res [INFO] [stdout] 698 + } [INFO] [stdout] 699 + Err(err) => Err(err), [INFO] [stdout] 700 + } [INFO] [stdout] 701 ~ }).is_err() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/engine/mod.rs:719:15 [INFO] [stdout] | [INFO] [stdout] 719 | name: &Box, [INFO] [stdout] | ^^^^^^^^^ help: try: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> src/engine/mod.rs:972:33 [INFO] [stdout] | [INFO] [stdout] 972 | .map(|(name, conf)| match conf { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 973 | | config::Plugin { src } => { [INFO] [stdout] 974 | | let plugin = Plugin::load(&*src) [INFO] [stdout] 975 | | .with_context(|| format!("failed to load plugin `{src}`"))?; [INFO] [stdout] ... | [INFO] [stdout] 978 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 972 ~ .map(|(name, conf)| { [INFO] [stdout] 973 + let config::Plugin { src } = conf; [INFO] [stdout] 974 + let plugin = Plugin::load(&*src) [INFO] [stdout] 975 + .with_context(|| format!("failed to load plugin `{src}`"))?; [INFO] [stdout] 976 + Ok((name, plugin)) [INFO] [stdout] 977 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 24s [INFO] running `Command { std: "docker" "inspect" "bf1901009edd1fdfc36d0b16da20bc311611c04e88511d9ecb61741832118056", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf1901009edd1fdfc36d0b16da20bc311611c04e88511d9ecb61741832118056", kill_on_drop: false }` [INFO] [stdout] bf1901009edd1fdfc36d0b16da20bc311611c04e88511d9ecb61741832118056