[INFO] fetching crate wasm_svg_graphics 1.0.4... [INFO] linting wasm_svg_graphics-1.0.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate wasm_svg_graphics 1.0.4 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate wasm_svg_graphics 1.0.4 [INFO] finished tweaking crates.io crate wasm_svg_graphics 1.0.4 [INFO] tweaked toml for crates.io crate wasm_svg_graphics 1.0.4 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate wasm_svg_graphics 1.0.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding wasm-bindgen-test v0.2.50 (available: v0.3.64) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded svg_definitions v0.3.2 [INFO] [stderr] Downloaded wasm-bindgen-test v0.2.50 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.3.27 [INFO] [stderr] Downloaded wasm-bindgen-test-macro v0.2.50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6f906693f29b07fc857adb5168d7fe189957ecb9102ff1a1b8049b673ed3f76a [INFO] running `Command { std: "docker" "start" "-a" "6f906693f29b07fc857adb5168d7fe189957ecb9102ff1a1b8049b673ed3f76a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6f906693f29b07fc857adb5168d7fe189957ecb9102ff1a1b8049b673ed3f76a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f906693f29b07fc857adb5168d7fe189957ecb9102ff1a1b8049b673ed3f76a", kill_on_drop: false }` [INFO] [stdout] 6f906693f29b07fc857adb5168d7fe189957ecb9102ff1a1b8049b673ed3f76a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] be6e64ecaf1a31913996beae5243bf06b4ab67782dda45c06d992baf7ac2f993 [INFO] running `Command { std: "docker" "start" "-a" "be6e64ecaf1a31913996beae5243bf06b4ab67782dda45c06d992baf7ac2f993", kill_on_drop: false }` [INFO] [stderr] Checking svg_definitions v0.3.2 [INFO] [stderr] Checking js-sys v0.3.91 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.2.50 [INFO] [stderr] Checking web-sys v0.3.91 [INFO] [stderr] Checking wasm-bindgen-futures v0.3.27 [INFO] [stderr] Checking wasm-bindgen-test v0.2.50 [INFO] [stderr] Checking wasm_svg_graphics v1.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:63:68 [INFO] [stdout] | [INFO] [stdout] 63 | => write!(f, "Error '{}' with argument '{}'", self.description(), arg0), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:65:78 [INFO] [stdout] | [INFO] [stdout] 65 | => write!(f, "Error '{}' with arguments '{}' and '{}'", self.description(), arg0, arg1), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:66:46 [INFO] [stdout] | [INFO] [stdout] 66 | _ => write!(f, "Error: {}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | Dom(dom_error) => dom_error.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:108:64 [INFO] [stdout] | [INFO] [stdout] 108 | => write!(f, "Error '{}' with argument '{}'", self.description(), arg0), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:63:68 [INFO] [stdout] | [INFO] [stdout] 63 | => write!(f, "Error '{}' with argument '{}'", self.description(), arg0), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:65:78 [INFO] [stdout] | [INFO] [stdout] 65 | => write!(f, "Error '{}' with arguments '{}' and '{}'", self.description(), arg0, arg1), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:66:46 [INFO] [stdout] | [INFO] [stdout] 66 | _ => write!(f, "Error: {}", self.description()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:89:41 [INFO] [stdout] | [INFO] [stdout] 89 | Dom(dom_error) => dom_error.description(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/errors.rs:108:64 [INFO] [stdout] | [INFO] [stdout] 108 | => write!(f, "Error '{}' with argument '{}'", self.description(), arg0), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/default.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn curve( [INFO] [stdout] 28 | | sx: i32, [INFO] [stdout] 29 | | sy: i32, [INFO] [stdout] 30 | | ex: i32, [INFO] [stdout] ... | [INFO] [stdout] 35 | | cy2: i32, [INFO] [stdout] 36 | | ) -> SVGElem { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/renderer.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | format!("{}-{}", super::SHAPE_ID_PREFIX, format!("{:x}", id_hash)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/renderer.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 192 | if id_hash == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `id_hash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/renderer.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 217 | if id_hash == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `id_hash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/renderer.rs:288:12 [INFO] [stdout] | [INFO] [stdout] 288 | if id_hash == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `id_hash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/renderer.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | if id_hash == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `id_hash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/renderer.rs:750:12 [INFO] [stdout] | [INFO] [stdout] 750 | if !container.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `container.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/renderer.rs:770:9 [INFO] [stdout] | [INFO] [stdout] 770 | /// defined using [define_render](#method.define_render) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 770 | /// defined using [define_render](#method.define_render) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/renderer.rs:806:12 [INFO] [stdout] | [INFO] [stdout] 806 | if !container.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `container.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/default.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn curve( [INFO] [stdout] 28 | | sx: i32, [INFO] [stdout] 29 | | sy: i32, [INFO] [stdout] 30 | | ex: i32, [INFO] [stdout] ... | [INFO] [stdout] 35 | | cy2: i32, [INFO] [stdout] 36 | | ) -> SVGElem { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/renderer.rs:936:9 [INFO] [stdout] | [INFO] [stdout] 936 | /// defined using [define_render](#method.define_render) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 936 | /// defined using [define_render](#method.define_render) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/renderer.rs:1002:12 [INFO] [stdout] | [INFO] [stdout] 1002 | if !container.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `container.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `container` after checking its variant with `is_err` [INFO] [stdout] --> src/renderer.rs:1003:29 [INFO] [stdout] | [INFO] [stdout] 1002 | if !container.is_err() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 1003 | let container = container.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/renderer.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | format!("{}-{}", super::SHAPE_ID_PREFIX, format!("{:x}", id_hash)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/renderer.rs:192:12 [INFO] [stdout] | [INFO] [stdout] 192 | if id_hash == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `id_hash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/renderer.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 217 | if id_hash == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `id_hash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/renderer.rs:288:12 [INFO] [stdout] | [INFO] [stdout] 288 | if id_hash == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `id_hash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/renderer.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | if id_hash == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `id_hash.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/renderer.rs:750:12 [INFO] [stdout] | [INFO] [stdout] 750 | if !container.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `container.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/renderer.rs:770:9 [INFO] [stdout] | [INFO] [stdout] 770 | /// defined using [define_render](#method.define_render) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 770 | /// defined using [define_render](#method.define_render) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/renderer.rs:806:12 [INFO] [stdout] | [INFO] [stdout] 806 | if !container.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `container.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/renderer.rs:936:9 [INFO] [stdout] | [INFO] [stdout] 936 | /// defined using [define_render](#method.define_render) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 936 | /// defined using [define_render](#method.define_render) [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/renderer.rs:1002:12 [INFO] [stdout] | [INFO] [stdout] 1002 | if !container.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `container.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `container` after checking its variant with `is_err` [INFO] [stdout] --> src/renderer.rs:1003:29 [INFO] [stdout] | [INFO] [stdout] 1002 | if !container.is_err() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 1003 | let container = container.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.36s [INFO] running `Command { std: "docker" "inspect" "be6e64ecaf1a31913996beae5243bf06b4ab67782dda45c06d992baf7ac2f993", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be6e64ecaf1a31913996beae5243bf06b4ab67782dda45c06d992baf7ac2f993", kill_on_drop: false }` [INFO] [stdout] be6e64ecaf1a31913996beae5243bf06b4ab67782dda45c06d992baf7ac2f993