[INFO] fetching crate wallheaven 1.1.1... [INFO] linting wallheaven-1.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate wallheaven 1.1.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate wallheaven 1.1.1 [INFO] finished tweaking crates.io crate wallheaven 1.1.1 [INFO] tweaked toml for crates.io crate wallheaven 1.1.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate wallheaven 1.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate wallheaven 1.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pest_generator v2.7.11 [INFO] [stderr] Downloaded ordered-multimap v0.6.0 [INFO] [stderr] Downloaded async-trait v0.1.81 [INFO] [stderr] Downloaded rust-ini v0.19.0 [INFO] [stderr] Downloaded daemonize v0.5.0 [INFO] [stderr] Downloaded pest v2.7.11 [INFO] [stderr] Downloaded pest_derive v2.7.11 [INFO] [stderr] Downloaded pest_meta v2.7.11 [INFO] [stderr] Downloaded config v0.14.0 [INFO] [stderr] Downloaded field_accessor v0.5.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dcd02075c1e15a1be4e3e2dd02ca3800bdda3f4a4a4afec6136f737e2b44774d [INFO] running `Command { std: "docker" "start" "-a" "dcd02075c1e15a1be4e3e2dd02ca3800bdda3f4a4a4afec6136f737e2b44774d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dcd02075c1e15a1be4e3e2dd02ca3800bdda3f4a4a4afec6136f737e2b44774d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcd02075c1e15a1be4e3e2dd02ca3800bdda3f4a4a4afec6136f737e2b44774d", kill_on_drop: false }` [INFO] [stdout] dcd02075c1e15a1be4e3e2dd02ca3800bdda3f4a4a4afec6136f737e2b44774d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a4ac9b0b5b4dc08b481dfe489fe7a83b92fe0defb7b40aaf99471d37d1a9b0db [INFO] running `Command { std: "docker" "start" "-a" "a4ac9b0b5b4dc08b481dfe489fe7a83b92fe0defb7b40aaf99471d37d1a9b0db", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking webpki-roots v0.26.6 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking rust-ini v0.12.2 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking daemonize v0.5.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking dlv-list v0.5.2 [INFO] [stderr] Checking ordered-multimap v0.6.0 [INFO] [stderr] Checking rust-ini v0.19.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking axum-core v0.4.4 [INFO] [stderr] Compiling field_accessor v0.5.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking enquote v1.1.0 [INFO] [stderr] Checking wallpaper v3.2.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking rustls-webpki v0.102.7 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking tower v0.5.1 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking tower-http v0.5.2 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking config v0.14.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking axum v0.7.6 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking wallheaven v1.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wallheavend.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | if !output.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `output.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallheavend.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | return (StatusCode::OK, Json(json!({"wallpaper" : id }))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return (StatusCode::OK, Json(json!({"wallpaper" : id }))); [INFO] [stdout] 75 + (StatusCode::OK, Json(json!({"wallpaper" : id }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallheavend.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | / return ( [INFO] [stdout] 79 | | StatusCode::BAD_REQUEST, [INFO] [stdout] 80 | | Json(json!({"error" : msg.to_string().trim()})), [INFO] [stdout] 81 | | ); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 ~ ( [INFO] [stdout] 79 + StatusCode::BAD_REQUEST, [INFO] [stdout] 80 + Json(json!({"error" : msg.to_string().trim()})), [INFO] [stdout] 81 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallheavend.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / return ( [INFO] [stdout] 86 | | StatusCode::BAD_REQUEST, [INFO] [stdout] 87 | | Json(json!({"error" : e.to_string().trim()})), [INFO] [stdout] 88 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 ~ ( [INFO] [stdout] 86 + StatusCode::BAD_REQUEST, [INFO] [stdout] 87 + Json(json!({"error" : e.to_string().trim()})), [INFO] [stdout] 88 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wallheavend.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | if !output.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `output.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallheavend.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | return (StatusCode::OK, Json(json!({"wallpaper" : id }))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return (StatusCode::OK, Json(json!({"wallpaper" : id }))); [INFO] [stdout] 75 + (StatusCode::OK, Json(json!({"wallpaper" : id }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallheavend.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | / return ( [INFO] [stdout] 79 | | StatusCode::BAD_REQUEST, [INFO] [stdout] 80 | | Json(json!({"error" : msg.to_string().trim()})), [INFO] [stdout] 81 | | ); [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 ~ ( [INFO] [stdout] 79 + StatusCode::BAD_REQUEST, [INFO] [stdout] 80 + Json(json!({"error" : msg.to_string().trim()})), [INFO] [stdout] 81 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallheavend.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / return ( [INFO] [stdout] 86 | | StatusCode::BAD_REQUEST, [INFO] [stdout] 87 | | Json(json!({"error" : e.to_string().trim()})), [INFO] [stdout] 88 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 ~ ( [INFO] [stdout] 86 + StatusCode::BAD_REQUEST, [INFO] [stdout] 87 + Json(json!({"error" : e.to_string().trim()})), [INFO] [stdout] 88 + ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:18:22 [INFO] [stdout] | [INFO] [stdout] 18 | .set_default("categories".to_string(), "111".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"categories"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | .set_default("pages".to_string(), 5) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `"pages"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | .set_default("range".to_string(), "1M".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `"range"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | .set_default("ratios".to_string(), "landscape".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `"ratios"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return conf_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return conf_dir; [INFO] [stdout] 21 + conf_dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return conf_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return conf_dir; [INFO] [stdout] 25 + conf_dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return conf_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return conf_file; [INFO] [stdout] 44 + conf_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return config_file_path().into_os_string().into_string().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return config_file_path().into_os_string().into_string().unwrap(); [INFO] [stdout] 48 + config_file_path().into_os_string().into_string().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return cache_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return cache_dir; [INFO] [stdout] 55 + cache_dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return cache_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return cache_dir; [INFO] [stdout] 59 + cache_dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return format!("{}", filename); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return format!("{}", filename); [INFO] [stdout] 67 + format!("{}", filename) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/files.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | let filename = path_segments.last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ let mut path_segments = url.path_segments().unwrap(); [INFO] [stdout] 66 ~ let filename = path_segments.next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/files.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | return format!("{}", filename); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `filename.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | return v; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return v; [INFO] [stdout] 127 + v [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | return wpid[1].to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return wpid[1].to_string(); [INFO] [stdout] 135 + wpid[1].to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `post_script` after checking its variant with `is_ok` [INFO] [stdout] --> src/files.rs:164:27 [INFO] [stdout] | [INFO] [stdout] 162 | if post_script.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = post_script` [INFO] [stdout] 163 | let parsed_command = [INFO] [stdout] 164 | shlex::split(&post_script.unwrap()).expect("Failed to parse external script"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return Ok(()); [INFO] [stdout] 172 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Ok(()); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `writeln!` args [INFO] [stdout] --> src/files.rs:152:44 [INFO] [stdout] | [INFO] [stdout] 152 | writeln!(current, "{}", fname.display().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/files.rs:157:39 [INFO] [stdout] | [INFO] [stdout] 157 | println!("{}", fname.display().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/flags.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return flags; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return flags; [INFO] [stdout] 86 + flags [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/flags.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return Ok(bits.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return Ok(bits.to_string()); [INFO] [stdout] 91 + Ok(bits.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/flags.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(format!("should be bits e.g. 110")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return Err(format!("should be bits e.g. 110")); [INFO] [stdout] 93 + Err(format!("should be bits e.g. 110")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/flags.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(format!("should be bits e.g. 110")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"should be bits e.g. 110".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:18:22 [INFO] [stdout] | [INFO] [stdout] 18 | .set_default("categories".to_string(), "111".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"categories"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | .set_default("pages".to_string(), 5) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `"pages"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 22 | .set_default("range".to_string(), "1M".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `"range"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | .set_default("ratios".to_string(), "landscape".to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `"ratios"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | return conf_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return conf_dir; [INFO] [stdout] 21 + conf_dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return conf_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return conf_dir; [INFO] [stdout] 25 + conf_dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | return conf_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return conf_file; [INFO] [stdout] 44 + conf_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | return config_file_path().into_os_string().into_string().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return config_file_path().into_os_string().into_string().unwrap(); [INFO] [stdout] 48 + config_file_path().into_os_string().into_string().unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | return cache_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return cache_dir; [INFO] [stdout] 55 + cache_dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return cache_dir; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return cache_dir; [INFO] [stdout] 59 + cache_dir [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return format!("{}", filename); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return format!("{}", filename); [INFO] [stdout] 67 + format!("{}", filename) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/files.rs:66:20 [INFO] [stdout] | [INFO] [stdout] 66 | let filename = path_segments.last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ let mut path_segments = url.path_segments().unwrap(); [INFO] [stdout] 66 ~ let filename = path_segments.next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/files.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | return format!("{}", filename); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `filename.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return s; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return s; [INFO] [stdout] 11 + s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return v.choose(&mut rand::thread_rng()).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return v.choose(&mut rand::thread_rng()).unwrap().to_string(); [INFO] [stdout] 16 + v.choose(&mut rand::thread_rng()).unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return "None found...".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return "None found...".to_string(); [INFO] [stdout] 18 + "None found...".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn random_vec(v: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - pub fn random_vec(v: &Vec) -> String { [INFO] [stdout] 14 + pub fn random_vec(v: &[String]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if v.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return Ok(cache_to_vec(&sorting.file().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return Ok(cache_to_vec(&sorting.file().unwrap())); [INFO] [stdout] 27 + Ok(cache_to_vec(&sorting.file().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(fetch_query(sorting)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(fetch_query(sorting)?); [INFO] [stdout] 29 + Ok(fetch_query(sorting)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/wallhaven.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | return Ok(fetch_query(sorting)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 14 - return Ok(fetch_query(sorting)?); [INFO] [stdout] 14 + return fetch_query(sorting); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/wallhaven.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(fetch_query(sorting)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(fetch_query(sorting)?); [INFO] [stdout] 29 + return fetch_query(sorting); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / return Ok(cache_to_vec( [INFO] [stdout] 45 | | &collection_cache.into_os_string().into_string().unwrap(), [INFO] [stdout] 46 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ Ok(cache_to_vec( [INFO] [stdout] 45 + &collection_cache.into_os_string().into_string().unwrap(), [INFO] [stdout] 46 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(fetch_collection(id)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(fetch_collection(id)?); [INFO] [stdout] 49 + Ok(fetch_collection(id)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | return v; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return v; [INFO] [stdout] 127 + v [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | return wpid[1].to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return wpid[1].to_string(); [INFO] [stdout] 135 + wpid[1].to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `post_script` after checking its variant with `is_ok` [INFO] [stdout] --> src/files.rs:164:27 [INFO] [stdout] | [INFO] [stdout] 162 | if post_script.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = post_script` [INFO] [stdout] 163 | let parsed_command = [INFO] [stdout] 164 | shlex::split(&post_script.unwrap()).expect("Failed to parse external script"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return Ok(()); [INFO] [stdout] 172 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wallhaven.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | collection_cache.push(&label); [INFO] [stdout] | ^^^^^^ help: change this to: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/files.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 180 - return Ok(()); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `writeln!` args [INFO] [stdout] --> src/files.rs:152:44 [INFO] [stdout] | [INFO] [stdout] 152 | writeln!(current, "{}", fname.display().to_string())?; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> src/files.rs:157:39 [INFO] [stdout] | [INFO] [stdout] 157 | println!("{}", fname.display().to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/wallhaven.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(fetch_collection(id)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(fetch_collection(id)?); [INFO] [stdout] 49 + return fetch_collection(id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return Ok(wallpapers); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return Ok(wallpapers); [INFO] [stdout] 92 + Ok(wallpapers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | return Err(anyhow!(CustomError::new("No wallpapers found"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return Err(anyhow!(CustomError::new("No wallpapers found"))); [INFO] [stdout] 94 + Err(anyhow!(CustomError::new("No wallpapers found"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/wallhaven.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | if wallpapers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!wallpapers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wallhaven.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 109 | let response = fetch_json_string(&url.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `url.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return Ok(wallpapers); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return Ok(wallpapers); [INFO] [stdout] 148 + Ok(wallpapers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | return Err(anyhow!(CustomError::new("No wallpapers found"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return Err(anyhow!(CustomError::new("No wallpapers found"))); [INFO] [stdout] 150 + Err(anyhow!(CustomError::new("No wallpapers found"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/wallhaven.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 146 | if wallpapers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!wallpapers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wallhaven.rs:155:38 [INFO] [stdout] | [INFO] [stdout] 155 | let response = fetch_json_string(&url.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `url.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/wallhaven.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 170 | let collections: Vec<(String, u32)>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `collections` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 | [INFO] [stdout] 172 ~ let collections: Vec<(String, u32)> = if collection_id_cache.exists() { [INFO] [stdout] 173 | let collections_list = cache_to_vec(".collections"); [INFO] [stdout] 174 ~ collection_to_tuple_pairs(collections_list)? [INFO] [stdout] 175 | } else { [INFO] [stdout] 176 | let collections_list = fetch_collections_data()?; [INFO] [stdout] 177 | vec_to_cache(&collections_list, ".collections")?; [INFO] [stdout] 178 ~ collection_to_tuple_pairs(collections_list)? [INFO] [stdout] 179 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/wallhaven.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 202 | return Some(id.clone()); [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | return Ok(collections); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return Ok(collections); [INFO] [stdout] 231 + Ok(collections) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wallhaven.rs:223:38 [INFO] [stdout] | [INFO] [stdout] 223 | let response = fetch_json_string(&url.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `url.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wallhaven.rs:258:38 [INFO] [stdout] | [INFO] [stdout] 258 | let response = fetch_json_string(&url.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `url.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Ok(()); [INFO] [stdout] 55 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `flags.collection` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:26:49 [INFO] [stdout] | [INFO] [stdout] 25 | if flags.collection.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = flags.collection` [INFO] [stdout] 26 | let wallpapers = wallhaven::collection(&flags.collection.unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `flags.id` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:54:43 [INFO] [stdout] | [INFO] [stdout] 53 | if flags.id.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = flags.id` [INFO] [stdout] 54 | let wallpaper = wallhaven::by_id(&flags.id.unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/flags.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | return flags; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return flags; [INFO] [stdout] 86 + flags [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/flags.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return Ok(bits.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return Ok(bits.to_string()); [INFO] [stdout] 91 + Ok(bits.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/flags.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(format!("should be bits e.g. 110")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 93 - return Err(format!("should be bits e.g. 110")); [INFO] [stdout] 93 + Err(format!("should be bits e.g. 110")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/flags.rs:93:20 [INFO] [stdout] | [INFO] [stdout] 93 | return Err(format!("should be bits e.g. 110")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"should be bits e.g. 110".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return s; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return s; [INFO] [stdout] 11 + s [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return v.choose(&mut rand::thread_rng()).unwrap().to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return v.choose(&mut rand::thread_rng()).unwrap().to_string(); [INFO] [stdout] 16 + v.choose(&mut rand::thread_rng()).unwrap().to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | return "None found...".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return "None found...".to_string(); [INFO] [stdout] 18 + "None found...".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn random_vec(v: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - pub fn random_vec(v: &Vec) -> String { [INFO] [stdout] 14 + pub fn random_vec(v: &[String]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 15 | if v.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!v.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return Ok(cache_to_vec(&sorting.file().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return Ok(cache_to_vec(&sorting.file().unwrap())); [INFO] [stdout] 27 + Ok(cache_to_vec(&sorting.file().unwrap())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(fetch_query(sorting)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(fetch_query(sorting)?); [INFO] [stdout] 29 + Ok(fetch_query(sorting)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/wallhaven.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | return Ok(fetch_query(sorting)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 14 - return Ok(fetch_query(sorting)?); [INFO] [stdout] 14 + return fetch_query(sorting); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/wallhaven.rs:29:16 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(fetch_query(sorting)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(fetch_query(sorting)?); [INFO] [stdout] 29 + return fetch_query(sorting); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / return Ok(cache_to_vec( [INFO] [stdout] 45 | | &collection_cache.into_os_string().into_string().unwrap(), [INFO] [stdout] 46 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 ~ Ok(cache_to_vec( [INFO] [stdout] 45 + &collection_cache.into_os_string().into_string().unwrap(), [INFO] [stdout] 46 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(fetch_collection(id)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(fetch_collection(id)?); [INFO] [stdout] 49 + Ok(fetch_collection(id)?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wallhaven.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | collection_cache.push(&label); [INFO] [stdout] | ^^^^^^ help: change this to: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/wallhaven.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok(fetch_collection(id)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 49 - return Ok(fetch_collection(id)?); [INFO] [stdout] 49 + return fetch_collection(id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return Ok(wallpapers); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return Ok(wallpapers); [INFO] [stdout] 92 + Ok(wallpapers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | return Err(anyhow!(CustomError::new("No wallpapers found"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return Err(anyhow!(CustomError::new("No wallpapers found"))); [INFO] [stdout] 94 + Err(anyhow!(CustomError::new("No wallpapers found"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/wallhaven.rs:89:8 [INFO] [stdout] | [INFO] [stdout] 89 | if wallpapers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!wallpapers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wallhaven.rs:109:38 [INFO] [stdout] | [INFO] [stdout] 109 | let response = fetch_json_string(&url.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `url.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return Ok(wallpapers); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return Ok(wallpapers); [INFO] [stdout] 148 + Ok(wallpapers) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | return Err(anyhow!(CustomError::new("No wallpapers found"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 150 - return Err(anyhow!(CustomError::new("No wallpapers found"))); [INFO] [stdout] 150 + Err(anyhow!(CustomError::new("No wallpapers found"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/wallhaven.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 146 | if wallpapers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!wallpapers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wallhaven.rs:155:38 [INFO] [stdout] | [INFO] [stdout] 155 | let response = fetch_json_string(&url.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `url.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/wallhaven.rs:170:5 [INFO] [stdout] | [INFO] [stdout] 170 | let collections: Vec<(String, u32)>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `collections` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 | [INFO] [stdout] 172 ~ let collections: Vec<(String, u32)> = if collection_id_cache.exists() { [INFO] [stdout] 173 | let collections_list = cache_to_vec(".collections"); [INFO] [stdout] 174 ~ collection_to_tuple_pairs(collections_list)? [INFO] [stdout] 175 | } else { [INFO] [stdout] 176 | let collections_list = fetch_collections_data()?; [INFO] [stdout] 177 | vec_to_cache(&collections_list, ".collections")?; [INFO] [stdout] 178 ~ collection_to_tuple_pairs(collections_list)? [INFO] [stdout] 179 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/wallhaven.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 202 | return Some(id.clone()); [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/wallhaven.rs:231:5 [INFO] [stdout] | [INFO] [stdout] 231 | return Ok(collections); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 231 - return Ok(collections); [INFO] [stdout] 231 + Ok(collections) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wallhaven.rs:223:38 [INFO] [stdout] | [INFO] [stdout] 223 | let response = fetch_json_string(&url.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `url.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/wallhaven.rs:258:38 [INFO] [stdout] | [INFO] [stdout] 258 | let response = fetch_json_string(&url.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `url.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Ok(()); [INFO] [stdout] 55 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `flags.collection` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:26:49 [INFO] [stdout] | [INFO] [stdout] 25 | if flags.collection.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = flags.collection` [INFO] [stdout] 26 | let wallpapers = wallhaven::collection(&flags.collection.unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `flags.id` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:54:43 [INFO] [stdout] | [INFO] [stdout] 53 | if flags.id.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = flags.id` [INFO] [stdout] 54 | let wallpaper = wallhaven::by_id(&flags.id.unwrap())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.29s [INFO] running `Command { std: "docker" "inspect" "a4ac9b0b5b4dc08b481dfe489fe7a83b92fe0defb7b40aaf99471d37d1a9b0db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4ac9b0b5b4dc08b481dfe489fe7a83b92fe0defb7b40aaf99471d37d1a9b0db", kill_on_drop: false }` [INFO] [stdout] a4ac9b0b5b4dc08b481dfe489fe7a83b92fe0defb7b40aaf99471d37d1a9b0db