[INFO] fetching crate walc_model 0.5.2... [INFO] linting walc_model-0.5.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate walc_model 0.5.2 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate walc_model 0.5.2 [INFO] finished tweaking crates.io crate walc_model 0.5.2 [INFO] tweaked toml for crates.io crate walc_model 0.5.2 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate walc_model 0.5.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 318219cb8dc942e2aafb7bc98ead5209413dbade91c0a13a45529e38283315f8 [INFO] running `Command { std: "docker" "start" "-a" "318219cb8dc942e2aafb7bc98ead5209413dbade91c0a13a45529e38283315f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "318219cb8dc942e2aafb7bc98ead5209413dbade91c0a13a45529e38283315f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "318219cb8dc942e2aafb7bc98ead5209413dbade91c0a13a45529e38283315f8", kill_on_drop: false }` [INFO] [stdout] 318219cb8dc942e2aafb7bc98ead5209413dbade91c0a13a45529e38283315f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f29e0812c885ef151eb39382c8da77f2bf584a808133d41f1dcc215fbe385b9 [INFO] running `Command { std: "docker" "start" "-a" "1f29e0812c885ef151eb39382c8da77f2bf584a808133d41f1dcc215fbe385b9", kill_on_drop: false }` [INFO] [stderr] Checking walc_model v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `interpret` is never used [INFO] [stdout] --> src/ast/treewalk_interpreter.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn interpret(ast: &ASTNode) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUSH` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | PUSH, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Push` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADD` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | ADD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Add` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUBTRACT` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | SUBTRACT, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Subtract` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MULTIPLY` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | MULTIPLY, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Multiply` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DIVIDE` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | DIVIDE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Divide` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXP` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | EXP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Exp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn interpret(bytes: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - pub fn interpret(bytes: &Vec) -> Result { [INFO] [stdout] 48 + pub fn interpret(bytes: &[u8]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub mod ast; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/ast/ast.rs:22:55 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn postorder_traverse ()>(&self, visit_fn: &mut Visitor) { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ast/ast.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | visit_fn(&self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast/treewalk_interpreter.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - errors.push_str("Internal error: invalid token.\n"); [INFO] [stdout] 36 - return [INFO] [stdout] 35 + errors.push_str("Internal error: invalid token.\n"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/frontend/lexer.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUSH` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | PUSH, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Push` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADD` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | ADD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Add` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUBTRACT` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | SUBTRACT, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Subtract` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MULTIPLY` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | MULTIPLY, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Multiply` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DIVIDE` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | DIVIDE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Divide` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EXP` contains a capitalized acronym [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | EXP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Exp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bytecode/bytecode_interpreter.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn interpret(bytes: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 48 - pub fn interpret(bytes: &Vec) -> Result { [INFO] [stdout] 48 + pub fn interpret(bytes: &[u8]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/parser.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | assert!(lexemes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lexemes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 64 | if !left.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `left.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:64:34 [INFO] [stdout] | [INFO] [stdout] 64 | if !left.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `right.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:107:16 [INFO] [stdout] | [INFO] [stdout] 107 | if !left.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `left.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:107:34 [INFO] [stdout] | [INFO] [stdout] 107 | if !left.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `right.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | if !root_expression.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_expression.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:150:45 [INFO] [stdout] | [INFO] [stdout] 150 | if !root_expression.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `right.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/lib.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub mod ast; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib.rs:30:38 [INFO] [stdout] | [INFO] [stdout] 30 | Err(lex_error) => return Err(String::from(lex_error)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `lex_error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib.rs:34:46 [INFO] [stdout] | [INFO] [stdout] 34 | Some(Err(parse_error)) => return Err(String::from(parse_error)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `parse_error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib.rs:40:35 [INFO] [stdout] | [INFO] [stdout] 40 | Err(runtime_error) => Err(String::from(runtime_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `runtime_error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/ast/ast.rs:22:55 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn postorder_traverse ()>(&self, visit_fn: &mut Visitor) { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ast/ast.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | visit_fn(&self); [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ast/treewalk_interpreter.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 36 | return [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - errors.push_str("Internal error: invalid token.\n"); [INFO] [stdout] 36 - return [INFO] [stdout] 35 + errors.push_str("Internal error: invalid token.\n"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/frontend/lexer.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | EOF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/frontend/parser.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | assert!(lexemes.len() > 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!lexemes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:64:16 [INFO] [stdout] | [INFO] [stdout] 64 | if !left.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `left.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:64:34 [INFO] [stdout] | [INFO] [stdout] 64 | if !left.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `right.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:107:16 [INFO] [stdout] | [INFO] [stdout] 107 | if !left.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `left.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:107:34 [INFO] [stdout] | [INFO] [stdout] 107 | if !left.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `right.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:150:16 [INFO] [stdout] | [INFO] [stdout] 150 | if !root_expression.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `root_expression.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/frontend/parser.rs:150:45 [INFO] [stdout] | [INFO] [stdout] 150 | if !root_expression.is_err() && !right.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `right.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib.rs:30:38 [INFO] [stdout] | [INFO] [stdout] 30 | Err(lex_error) => return Err(String::from(lex_error)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `lex_error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib.rs:34:46 [INFO] [stdout] | [INFO] [stdout] 34 | Some(Err(parse_error)) => return Err(String::from(parse_error)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `parse_error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/lib.rs:40:35 [INFO] [stdout] | [INFO] [stdout] 40 | Err(runtime_error) => Err(String::from(runtime_error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `runtime_error` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.57s [INFO] running `Command { std: "docker" "inspect" "1f29e0812c885ef151eb39382c8da77f2bf584a808133d41f1dcc215fbe385b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f29e0812c885ef151eb39382c8da77f2bf584a808133d41f1dcc215fbe385b9", kill_on_drop: false }` [INFO] [stdout] 1f29e0812c885ef151eb39382c8da77f2bf584a808133d41f1dcc215fbe385b9