[INFO] fetching crate w65c02s 0.9.2...
[INFO] linting w65c02s-0.9.2 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate w65c02s 0.9.2 into /workspace/builds/worker-0-tc1/source
[INFO] started tweaking crates.io crate w65c02s 0.9.2
[INFO] finished tweaking crates.io crate w65c02s 0.9.2
[INFO] tweaked toml for crates.io crate w65c02s 0.9.2 written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate w65c02s 0.9.2 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 88dee60060dd0f8090499d56a81b4d53f3bddb130ca8efb60d2153178f673fb1
[INFO] running `Command { std: "docker" "start" "-a" "88dee60060dd0f8090499d56a81b4d53f3bddb130ca8efb60d2153178f673fb1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "88dee60060dd0f8090499d56a81b4d53f3bddb130ca8efb60d2153178f673fb1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "88dee60060dd0f8090499d56a81b4d53f3bddb130ca8efb60d2153178f673fb1", kill_on_drop: false }`
[INFO] [stdout] 88dee60060dd0f8090499d56a81b4d53f3bddb130ca8efb60d2153178f673fb1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 03bff5b1be0d1c71425f0df3e51bb85c88a20e981b4d0180dd7cc72cbc3895c0
[INFO] running `Command { std: "docker" "start" "-a" "03bff5b1be0d1c71425f0df3e51bb85c88a20e981b4d0180dd7cc72cbc3895c0", kill_on_drop: false }`
[INFO] [stderr]     Checking w65c02s v0.9.2 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/test.rs:24:48
[INFO] [stdout]    |
[INFO] [stdout] 24 |             serial_in, serial_out: Vec::new(), ram: ram
[INFO] [stdout]    |                                                ^^^^^^^^ help: replace it with: `ram`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/addressing_modes.rs:68:65
[INFO] [stdout]    |
[INFO] [stdout] 68 |     fn get_operand<S: System>(system: &mut S, cpu: &mut W65C02S) -> () {
[INFO] [stdout]    |                                                                 ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/addressing_modes.rs:75:58
[INFO] [stdout]    |
[INFO] [stdout] 75 |     fn get_operand<S: System>(_: &mut S, _: &mut W65C02S) -> () {}
[INFO] [stdout]    |                                                          ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/addressing_modes.rs:329:13
[INFO] [stdout]     |
[INFO] [stdout] 329 |             cpu.irq_pending = cpu.irq_pending | old_irq_pending;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.irq_pending |= old_irq_pending`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]     = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/addressing_modes.rs:367:13
[INFO] [stdout]     |
[INFO] [stdout] 367 |             cpu.irq_pending = cpu.irq_pending | old_irq_pending;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.irq_pending |= old_irq_pending`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/instructions.rs:102:33
[INFO] [stdout]     |
[INFO] [stdout] 102 |         if data & self.a == 0 { self.p = self.p | P_Z }
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.p |= P_Z`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/instructions.rs:103:16
[INFO] [stdout]     |
[INFO] [stdout] 103 |         else { self.p = self.p & !P_Z }
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.p &= !P_Z`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/instructions.rs:109:33
[INFO] [stdout]     |
[INFO] [stdout] 109 |         if data & self.a == 0 { self.p = self.p | P_Z }
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.p |= P_Z`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/instructions.rs:110:16
[INFO] [stdout]     |
[INFO] [stdout] 110 |         else { self.p = self.p & !P_Z }
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.p &= !P_Z`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `Range::contains` implementation
[INFO] [stdout]    --> src/instructions.rs:369:16
[INFO] [stdout]     |
[INFO] [stdout] 369 |             if val >= 0x80 && val < 0xFF80 { self.p |= P_V }
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x80..0xFF80).contains(&val)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout]     = note: `#[warn(clippy::manual_range_contains)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `W65C02S`
[INFO] [stdout]    --> src/lib.rs:250:5
[INFO] [stdout]     |
[INFO] [stdout] 250 | /     pub fn new() -> W65C02S {
[INFO] [stdout] 251 | |         W65C02S {
[INFO] [stdout] 252 | |             state: State::HasBeenReset,
[INFO] [stdout] 253 | |             pc: 0xFFFF,
[INFO] [stdout] ...   |
[INFO] [stdout] 262 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 246 + impl Default for W65C02S {
[INFO] [stdout] 247 +     fn default() -> Self {
[INFO] [stdout] 248 +         Self::new()
[INFO] [stdout] 249 +     }
[INFO] [stdout] 250 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:350:25
[INFO] [stdout]     |
[INFO] [stdout] 350 |         self.nmi_edge = self.nmi_edge || (!self.nmi_edge && nmi);
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 350 -         self.nmi_edge = self.nmi_edge || (!self.nmi_edge && nmi);
[INFO] [stdout] 350 +         self.nmi_edge = !(!self.nmi_edge && !nmi);
[INFO] [stdout]     |
[INFO] [stdout] 350 -         self.nmi_edge = self.nmi_edge || (!self.nmi_edge && nmi);
[INFO] [stdout] 350 +         self.nmi_edge = self.nmi_edge || nmi;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/addressing_modes.rs:68:65
[INFO] [stdout]    |
[INFO] [stdout] 68 |     fn get_operand<S: System>(system: &mut S, cpu: &mut W65C02S) -> () {
[INFO] [stdout]    |                                                                 ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]    = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]   --> src/addressing_modes.rs:75:58
[INFO] [stdout]    |
[INFO] [stdout] 75 |     fn get_operand<S: System>(_: &mut S, _: &mut W65C02S) -> () {}
[INFO] [stdout]    |                                                          ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/addressing_modes.rs:329:13
[INFO] [stdout]     |
[INFO] [stdout] 329 |             cpu.irq_pending = cpu.irq_pending | old_irq_pending;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.irq_pending |= old_irq_pending`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]     = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/addressing_modes.rs:367:13
[INFO] [stdout]     |
[INFO] [stdout] 367 |             cpu.irq_pending = cpu.irq_pending | old_irq_pending;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu.irq_pending |= old_irq_pending`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/instructions.rs:102:33
[INFO] [stdout]     |
[INFO] [stdout] 102 |         if data & self.a == 0 { self.p = self.p | P_Z }
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.p |= P_Z`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/instructions.rs:103:16
[INFO] [stdout]     |
[INFO] [stdout] 103 |         else { self.p = self.p & !P_Z }
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.p &= !P_Z`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/instructions.rs:109:33
[INFO] [stdout]     |
[INFO] [stdout] 109 |         if data & self.a == 0 { self.p = self.p | P_Z }
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.p |= P_Z`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/instructions.rs:110:16
[INFO] [stdout]     |
[INFO] [stdout] 110 |         else { self.p = self.p & !P_Z }
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.p &= !P_Z`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual `Range::contains` implementation
[INFO] [stdout]    --> src/instructions.rs:369:16
[INFO] [stdout]     |
[INFO] [stdout] 369 |             if val >= 0x80 && val < 0xFF80 { self.p |= P_V }
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0x80..0xFF80).contains(&val)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
[INFO] [stdout]     = note: `#[warn(clippy::manual_range_contains)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]   --> src/test.rs:20:17
[INFO] [stdout]    |
[INFO] [stdout] 20 |                 addr = addr + 1;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^ help: replace it with: `addr += 1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting integer literal to `i8` is unnecessary
[INFO] [stdout]    --> src/test.rs:104:22
[INFO] [stdout]     |
[INFO] [stdout] 104 |             op::BRA, -10 as i8 as u8,
[INFO] [stdout]     |                      ^^^^^^^^^ help: try: `-10_i8`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `W65C02S`
[INFO] [stdout]    --> src/lib.rs:250:5
[INFO] [stdout]     |
[INFO] [stdout] 250 | /     pub fn new() -> W65C02S {
[INFO] [stdout] 251 | |         W65C02S {
[INFO] [stdout] 252 | |             state: State::HasBeenReset,
[INFO] [stdout] 253 | |             pc: 0xFFFF,
[INFO] [stdout] ...   |
[INFO] [stdout] 262 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 246 + impl Default for W65C02S {
[INFO] [stdout] 247 +     fn default() -> Self {
[INFO] [stdout] 248 +         Self::new()
[INFO] [stdout] 249 +     }
[INFO] [stdout] 250 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:350:25
[INFO] [stdout]     |
[INFO] [stdout] 350 |         self.nmi_edge = self.nmi_edge || (!self.nmi_edge && nmi);
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 350 -         self.nmi_edge = self.nmi_edge || (!self.nmi_edge && nmi);
[INFO] [stdout] 350 +         self.nmi_edge = !(!self.nmi_edge && !nmi);
[INFO] [stdout]     |
[INFO] [stdout] 350 -         self.nmi_edge = self.nmi_edge || (!self.nmi_edge && nmi);
[INFO] [stdout] 350 +         self.nmi_edge = self.nmi_edge || nmi;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.71s
[INFO] running `Command { std: "docker" "inspect" "03bff5b1be0d1c71425f0df3e51bb85c88a20e981b4d0180dd7cc72cbc3895c0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "03bff5b1be0d1c71425f0df3e51bb85c88a20e981b4d0180dd7cc72cbc3895c0", kill_on_drop: false }`
[INFO] [stdout] 03bff5b1be0d1c71425f0df3e51bb85c88a20e981b4d0180dd7cc72cbc3895c0