[INFO] fetching crate vroom 0.1.0... [INFO] linting vroom-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate vroom 0.1.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate vroom 0.1.0 [INFO] finished tweaking crates.io crate vroom 0.1.0 [INFO] tweaked toml for crates.io crate vroom 0.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate vroom 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate vroom 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5ac64eedf18ac43c4f8e44ba56b370e87099d0eb71c81cd11670c438a6097b6 [INFO] running `Command { std: "docker" "start" "-a" "a5ac64eedf18ac43c4f8e44ba56b370e87099d0eb71c81cd11670c438a6097b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5ac64eedf18ac43c4f8e44ba56b370e87099d0eb71c81cd11670c438a6097b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5ac64eedf18ac43c4f8e44ba56b370e87099d0eb71c81cd11670c438a6097b6", kill_on_drop: false }` [INFO] [stdout] a5ac64eedf18ac43c4f8e44ba56b370e87099d0eb71c81cd11670c438a6097b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3dfe31e5827c79612ea1ac1e5cc9466cb0ecf83aa7d5c06ce044a77fb4122249 [INFO] running `Command { std: "docker" "start" "-a" "3dfe31e5827c79612ea1ac1e5cc9466cb0ecf83aa7d5c06ce044a77fb4122249", kill_on_drop: false }` [INFO] [stderr] Checking vroom v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | '_' => return Transform::Goto(Go::LastNonSpace), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - '_' => return Transform::Goto(Go::LastNonSpace), [INFO] [stdout] 39 + '_' => Transform::Goto(Go::LastNonSpace), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 40 | _ => return Transform::None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - _ => return Transform::None, [INFO] [stdout] 40 + _ => Transform::None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | return transforms; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return transforms; [INFO] [stdout] 147 + transforms [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:44:41 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn parse_transforms(transformation: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 - pub fn parse_transforms(transformation: &String) -> Vec { [INFO] [stdout] 44 + pub fn parse_transforms(transformation: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:82:36 [INFO] [stdout] | [INFO] [stdout] 82 | } else if state == "$".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"$"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:86:36 [INFO] [stdout] | [INFO] [stdout] 86 | } else if state == "0".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"0"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:89:36 [INFO] [stdout] | [INFO] [stdout] 89 | } else if state == "^".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"^"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:92:36 [INFO] [stdout] | [INFO] [stdout] 92 | } else if state == "A".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"A"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:96:36 [INFO] [stdout] | [INFO] [stdout] 96 | } else if state == "I".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"I"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:100:36 [INFO] [stdout] | [INFO] [stdout] 100 | } else if state == "i".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"i"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | } else if state == "a".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:106:36 [INFO] [stdout] | [INFO] [stdout] 106 | } else if state == "l".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"l"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:109:36 [INFO] [stdout] | [INFO] [stdout] 109 | } else if state == "h".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"h"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:112:36 [INFO] [stdout] | [INFO] [stdout] 112 | } else if state == "w".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"w"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:115:36 [INFO] [stdout] | [INFO] [stdout] 115 | } else if state == "W".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"W"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 118 | } else if state == "e".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:121:36 [INFO] [stdout] | [INFO] [stdout] 121 | } else if state == "E".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"E"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | } else if state == "b".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:127:36 [INFO] [stdout] | [INFO] [stdout] 127 | } else if state == "B".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"B"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/parser.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | / match mode { [INFO] [stdout] 137 | | Mode::Insert(p) => { [INFO] [stdout] 138 | | if p { [INFO] [stdout] 139 | | transforms.push(Transform::InsertRight(state.to_string())); [INFO] [stdout] ... | [INFO] [stdout] 144 | | _ => {} [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 136 ~ if let Mode::Insert(p) = mode { [INFO] [stdout] 137 + if p { [INFO] [stdout] 138 + transforms.push(Transform::InsertRight(state.to_string())); [INFO] [stdout] 139 + } else { [INFO] [stdout] 140 + transforms.push(Transform::Insert(state.to_string())); [INFO] [stdout] 141 + } [INFO] [stdout] 142 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/transform.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | let enable_debug = !env::var("VROOM_DEBUG").is_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("VROOM_DEBUG").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/transform.rs:23:35 [INFO] [stdout] | [INFO] [stdout] 23 | debug(&modified, pos, &transform); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | '_' => return Transform::Goto(Go::LastNonSpace), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - '_' => return Transform::Goto(Go::LastNonSpace), [INFO] [stdout] 39 + '_' => Transform::Goto(Go::LastNonSpace), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 40 | _ => return Transform::None, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - _ => return Transform::None, [INFO] [stdout] 40 + _ => Transform::None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | return transforms; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return transforms; [INFO] [stdout] 147 + transforms [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:44:41 [INFO] [stdout] | [INFO] [stdout] 44 | pub fn parse_transforms(transformation: &String) -> Vec { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 - pub fn parse_transforms(transformation: &String) -> Vec { [INFO] [stdout] 44 + pub fn parse_transforms(transformation: &str) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:82:36 [INFO] [stdout] | [INFO] [stdout] 82 | } else if state == "$".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"$"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/transform.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | / if pos > 0 { [INFO] [stdout] 47 | | pos -= 1; [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________________^ help: try: `pos = pos.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `insert_str()` using a single-character converted to string [INFO] [stdout] --> src/transform.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 61 | modified.insert_str(pos, &c.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `insert` without `to_string()`: `modified.insert(pos, *c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return 0; [INFO] [stdout] 25 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:1:29 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn find_prev_word(line: &String, pos: usize, big: bool) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn find_prev_word(line: &String, pos: usize, big: bool) -> usize { [INFO] [stdout] 1 + pub fn find_prev_word(line: &str, pos: usize, big: bool) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:86:36 [INFO] [stdout] | [INFO] [stdout] 86 | } else if state == "0".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"0"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:89:36 [INFO] [stdout] | [INFO] [stdout] 89 | } else if state == "^".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"^"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:92:36 [INFO] [stdout] | [INFO] [stdout] 92 | } else if state == "A".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"A"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:96:36 [INFO] [stdout] | [INFO] [stdout] 96 | } else if state == "I".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"I"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:100:36 [INFO] [stdout] | [INFO] [stdout] 100 | } else if state == "i".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"i"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:103:36 [INFO] [stdout] | [INFO] [stdout] 103 | } else if state == "a".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"a"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | / if flag { [INFO] [stdout] 8 | | if ch.is_alphanumeric() || nonbreak.contains(&ch) { [INFO] [stdout] 9 | | return pos - i + 1; [INFO] [stdout] 10 | | } [INFO] [stdout] 11 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 7 ~ if flag [INFO] [stdout] 8 ~ && (ch.is_alphanumeric() || nonbreak.contains(&ch)) { [INFO] [stdout] 9 | return pos - i + 1; [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:106:36 [INFO] [stdout] | [INFO] [stdout] 106 | } else if state == "l".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"l"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:109:36 [INFO] [stdout] | [INFO] [stdout] 109 | } else if state == "h".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"h"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return line.len() - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return line.len() - 1; [INFO] [stdout] 63 + line.len() - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn find_next_word(line: &String, pos: usize, big: bool, e: bool) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - pub fn find_next_word(line: &String, pos: usize, big: bool, e: bool) -> usize { [INFO] [stdout] 28 + pub fn find_next_word(line: &str, pos: usize, big: bool, e: bool) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / if flag { [INFO] [stdout] 34 | | if ch.is_alphanumeric() || nonbreak.contains(&ch) { [INFO] [stdout] 35 | | return i + pos; [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if flag [INFO] [stdout] 34 ~ && (ch.is_alphanumeric() || nonbreak.contains(&ch)) { [INFO] [stdout] 35 | return i + pos; [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return pos; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return pos; [INFO] [stdout] 76 + pos [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:66:24 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn find_char(line: &String, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - pub fn find_char(line: &String, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] 66 + pub fn find_char(line: &str, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | return pos; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return pos; [INFO] [stdout] 88 + pos [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn find_char_rev(line: &String, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - pub fn find_char_rev(line: &String, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] 78 + pub fn find_char_rev(line: &str, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:112:36 [INFO] [stdout] | [INFO] [stdout] 112 | } else if state == "w".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"w"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:115:36 [INFO] [stdout] | [INFO] [stdout] 115 | } else if state == "W".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"W"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 118 | } else if state == "e".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"e"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:121:36 [INFO] [stdout] | [INFO] [stdout] 121 | } else if state == "E".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"E"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 124 | } else if state == "b".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"b"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/parser.rs:127:36 [INFO] [stdout] | [INFO] [stdout] 127 | } else if state == "B".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `"B"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/parser.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | / match mode { [INFO] [stdout] 137 | | Mode::Insert(p) => { [INFO] [stdout] 138 | | if p { [INFO] [stdout] 139 | | transforms.push(Transform::InsertRight(state.to_string())); [INFO] [stdout] ... | [INFO] [stdout] 144 | | _ => {} [INFO] [stdout] 145 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 136 ~ if let Mode::Insert(p) = mode { [INFO] [stdout] 137 + if p { [INFO] [stdout] 138 + transforms.push(Transform::InsertRight(state.to_string())); [INFO] [stdout] 139 + } else { [INFO] [stdout] 140 + transforms.push(Transform::Insert(state.to_string())); [INFO] [stdout] 141 + } [INFO] [stdout] 142 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return 0; [INFO] [stdout] 97 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn find_first_non_whitespace(line: &String) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - pub fn find_first_non_whitespace(line: &String) -> usize { [INFO] [stdout] 91 + pub fn find_first_non_whitespace(line: &str) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | return line.len() - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return line.len() - 1; [INFO] [stdout] 106 + line.len() - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:100:39 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn find_last_non_whitespace(line: &String) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 100 - pub fn find_last_non_whitespace(line: &String) -> usize { [INFO] [stdout] 100 + pub fn find_last_non_whitespace(line: &str) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:28:40 [INFO] [stdout] | [INFO] [stdout] 28 | for (_, line) in reader.lines().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 28 - for (_, line) in reader.lines().enumerate() { [INFO] [stdout] 28 + for line in reader.lines() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/transform.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | let enable_debug = !env::var("VROOM_DEBUG").is_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `env::var("VROOM_DEBUG").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/transform.rs:23:35 [INFO] [stdout] | [INFO] [stdout] 23 | debug(&modified, pos, &transform); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `transform` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/transform.rs:46:21 [INFO] [stdout] | [INFO] [stdout] 46 | / if pos > 0 { [INFO] [stdout] 47 | | pos -= 1; [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________________^ help: try: `pos = pos.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `insert_str()` using a single-character converted to string [INFO] [stdout] --> src/transform.rs:61:21 [INFO] [stdout] | [INFO] [stdout] 61 | modified.insert_str(pos, &c.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `insert` without `to_string()`: `modified.insert(pos, *c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return 0; [INFO] [stdout] 25 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:1:29 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn find_prev_word(line: &String, pos: usize, big: bool) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 - pub fn find_prev_word(line: &String, pos: usize, big: bool) -> usize { [INFO] [stdout] 1 + pub fn find_prev_word(line: &str, pos: usize, big: bool) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | / if flag { [INFO] [stdout] 8 | | if ch.is_alphanumeric() || nonbreak.contains(&ch) { [INFO] [stdout] 9 | | return pos - i + 1; [INFO] [stdout] 10 | | } [INFO] [stdout] 11 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 7 ~ if flag [INFO] [stdout] 8 ~ && (ch.is_alphanumeric() || nonbreak.contains(&ch)) { [INFO] [stdout] 9 | return pos - i + 1; [INFO] [stdout] 10 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | return line.len() - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return line.len() - 1; [INFO] [stdout] 63 + line.len() - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:28:29 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn find_next_word(line: &String, pos: usize, big: bool, e: bool) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - pub fn find_next_word(line: &String, pos: usize, big: bool, e: bool) -> usize { [INFO] [stdout] 28 + pub fn find_next_word(line: &str, pos: usize, big: bool, e: bool) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / if flag { [INFO] [stdout] 34 | | if ch.is_alphanumeric() || nonbreak.contains(&ch) { [INFO] [stdout] 35 | | return i + pos; [INFO] [stdout] 36 | | } [INFO] [stdout] 37 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 33 ~ if flag [INFO] [stdout] 34 ~ && (ch.is_alphanumeric() || nonbreak.contains(&ch)) { [INFO] [stdout] 35 | return i + pos; [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return pos; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return pos; [INFO] [stdout] 76 + pos [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:66:24 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn find_char(line: &String, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - pub fn find_char(line: &String, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] 66 + pub fn find_char(line: &str, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | return pos; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return pos; [INFO] [stdout] 88 + pos [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn find_char_rev(line: &String, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 78 - pub fn find_char_rev(line: &String, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] 78 + pub fn find_char_rev(line: &str, item: &char, pos: usize, t: bool) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return 0; [INFO] [stdout] 97 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:91:40 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn find_first_non_whitespace(line: &String) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 91 - pub fn find_first_non_whitespace(line: &String) -> usize { [INFO] [stdout] 91 + pub fn find_first_non_whitespace(line: &str) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 106 | return line.len() - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return line.len() - 1; [INFO] [stdout] 106 + line.len() - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:100:39 [INFO] [stdout] | [INFO] [stdout] 100 | pub fn find_last_non_whitespace(line: &String) -> usize { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 100 - pub fn find_last_non_whitespace(line: &String) -> usize { [INFO] [stdout] 100 + pub fn find_last_non_whitespace(line: &str) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:28:40 [INFO] [stdout] | [INFO] [stdout] 28 | for (_, line) in reader.lines().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 28 - for (_, line) in reader.lines().enumerate() { [INFO] [stdout] 28 + for line in reader.lines() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "3dfe31e5827c79612ea1ac1e5cc9466cb0ecf83aa7d5c06ce044a77fb4122249", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3dfe31e5827c79612ea1ac1e5cc9466cb0ecf83aa7d5c06ce044a77fb4122249", kill_on_drop: false }` [INFO] [stdout] 3dfe31e5827c79612ea1ac1e5cc9466cb0ecf83aa7d5c06ce044a77fb4122249