[INFO] fetching crate vrf-mod 0.1.2... [INFO] linting vrf-mod-0.1.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate vrf-mod 0.1.2 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate vrf-mod 0.1.2 [INFO] finished tweaking crates.io crate vrf-mod 0.1.2 [INFO] tweaked toml for crates.io crate vrf-mod 0.1.2 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate vrf-mod 0.1.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate vrf-mod 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror-impl v1.0.34 [INFO] [stderr] Downloaded once_cell v1.13.1 [INFO] [stderr] Downloaded hmac-sha256 v1.1.4 [INFO] [stderr] Downloaded thiserror v1.0.34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 734b3479adb08366dda22e88b218b8edb4eafc88ffeae628be852b30f2e238a6 [INFO] running `Command { std: "docker" "start" "-a" "734b3479adb08366dda22e88b218b8edb4eafc88ffeae628be852b30f2e238a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "734b3479adb08366dda22e88b218b8edb4eafc88ffeae628be852b30f2e238a6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "734b3479adb08366dda22e88b218b8edb4eafc88ffeae628be852b30f2e238a6", kill_on_drop: false }` [INFO] [stdout] 734b3479adb08366dda22e88b218b8edb4eafc88ffeae628be852b30f2e238a6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93ca5c62cb38d6d62e29932fbd0ff5298a7c383fa8b43564977d2641bfe6c3b4 [INFO] running `Command { std: "docker" "start" "-a" "93ca5c62cb38d6d62e29932fbd0ff5298a7c383fa8b43564977d2641bfe6c3b4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling openssl v0.10.41 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Checking hmac-sha256 v1.1.4 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Compiling openssl-sys v0.9.75 [INFO] [stderr] Compiling openssl-macros v0.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.34 [INFO] [stderr] Checking thiserror v1.0.34 [INFO] [stderr] Checking vrf-mod v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: accessing first element with `error.errors().get(0)` [INFO] [stdout] --> src/vrf/mod.rs:102:15 [INFO] [stdout] | [INFO] [stdout] 102 | match error.errors().get(0).map(openssl::error::Error::code) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `error.errors().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vrf/mod.rs:180:27 [INFO] [stdout] | [INFO] [stdout] 180 | signature.mod_exp(&message, d, n, &mut self.bn_ctx)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `message` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vrf/mod.rs:208:25 [INFO] [stdout] | [INFO] [stdout] 208 | message.mod_exp(&signature, e, n, &mut self.bn_ctx)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `signature` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/vrf/mod.rs:236:26 [INFO] [stdout] | [INFO] [stdout] 236 | let iterations = (mask_len + &self.hlen - 1) / &self.hlen ; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.hlen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/vrf/mod.rs:236:26 [INFO] [stdout] | [INFO] [stdout] 236 | let iterations = (mask_len + &self.hlen - 1) / &self.hlen ; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `mask_len.div_ceil(*&self.hlen)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/vrf/mod.rs:236:27 [INFO] [stdout] | [INFO] [stdout] 236 | let iterations = (mask_len + &self.hlen - 1) / &self.hlen ; [INFO] [stdout] | ^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.hlen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vrf/mod.rs:244:32 [INFO] [stdout] | [INFO] [stdout] 244 | self.hasher.update(&mgf_seed).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `mgf_seed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vrf/mod.rs:279:12 [INFO] [stdout] | [INFO] [stdout] 279 | if !(*k < 4_294_967_296usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*k >= 4_294_967_296usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vrf/mod.rs:298:23 [INFO] [stdout] | [INFO] [stdout] 298 | let m = os2ip(&em.as_slice()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `em.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vrf/mod.rs:373:13 [INFO] [stdout] | [INFO] [stdout] 373 | return Err(Error::InvalidProof); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 373 - return Err(Error::InvalidProof); [INFO] [stdout] 373 + Err(Error::InvalidProof) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ecvrf/primitives.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | let zeroes = if length % 8 > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace with: `!length.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/primitives.rs:92:6 [INFO] [stdout] | [INFO] [stdout] 92 | [&zeroes.as_slice(), data].concat() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `zeroes.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `error.errors().get(0)` [INFO] [stdout] --> src/ecvrf/mod.rs:78:15 [INFO] [stdout] | [INFO] [stdout] 78 | match error.errors().get(0).map(openssl::error::Error::code) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `error.errors().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/ecvrf/mod.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | / match h { [INFO] [stdout] 187 | | Ok(hash_point) => Some(hash_point), [INFO] [stdout] 188 | | _ => None, [INFO] [stdout] 189 | | } [INFO] [stdout] | |_____________^ help: replace with: `h.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/mod.rs:263:21 [INFO] [stdout] | [INFO] [stdout] 263 | &padded_secret_key.as_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `padded_secret_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/mod.rs:264:21 [INFO] [stdout] | [INFO] [stdout] 264 | &padded_data.as_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `padded_data.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:267:17 [INFO] [stdout] | [INFO] [stdout] 267 | &k, [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:269:27 [INFO] [stdout] | [INFO] [stdout] 269 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:269:31 [INFO] [stdout] | [INFO] [stdout] 269 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:274:27 [INFO] [stdout] | [INFO] [stdout] 274 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:274:31 [INFO] [stdout] | [INFO] [stdout] 274 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | &k, [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:290:27 [INFO] [stdout] | [INFO] [stdout] 290 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:290:31 [INFO] [stdout] | [INFO] [stdout] 290 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/mod.rs:322:28 [INFO] [stdout] | [INFO] [stdout] 322 | self.hasher.update(&concatenate_points?.as_slice()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `concatenate_points?.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ecvrf/mod.rs:392:25 [INFO] [stdout] | [INFO] [stdout] 392 | let pt_len = if self.qlen % 8 > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `!self.qlen.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ecvrf/mod.rs:397:24 [INFO] [stdout] | [INFO] [stdout] 397 | let c_len = if self.n % 8 > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace with: `!self.n.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/mod.rs:479:26 [INFO] [stdout] | [INFO] [stdout] 479 | let pi_string = [&gamma_string.as_slice(), c_string.as_slice(), s_string.as_slice()].concat(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `gamma_string.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ecvrf/mod.rs:622:13 [INFO] [stdout] | [INFO] [stdout] 622 | return Err(Error::InvalidProof); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 622 - return Err(Error::InvalidProof); [INFO] [stdout] 622 + Err(Error::InvalidProof) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `error.errors().get(0)` [INFO] [stdout] --> src/vrf/mod.rs:102:15 [INFO] [stdout] | [INFO] [stdout] 102 | match error.errors().get(0).map(openssl::error::Error::code) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `error.errors().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vrf/mod.rs:180:27 [INFO] [stdout] | [INFO] [stdout] 180 | signature.mod_exp(&message, d, n, &mut self.bn_ctx)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `message` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vrf/mod.rs:208:25 [INFO] [stdout] | [INFO] [stdout] 208 | message.mod_exp(&signature, e, n, &mut self.bn_ctx)?; [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `signature` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/vrf/mod.rs:236:26 [INFO] [stdout] | [INFO] [stdout] 236 | let iterations = (mask_len + &self.hlen - 1) / &self.hlen ; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.hlen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/vrf/mod.rs:236:26 [INFO] [stdout] | [INFO] [stdout] 236 | let iterations = (mask_len + &self.hlen - 1) / &self.hlen ; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `mask_len.div_ceil(*&self.hlen)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/vrf/mod.rs:236:27 [INFO] [stdout] | [INFO] [stdout] 236 | let iterations = (mask_len + &self.hlen - 1) / &self.hlen ; [INFO] [stdout] | ^^^^^^^^^^^---------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `self.hlen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vrf/mod.rs:244:32 [INFO] [stdout] | [INFO] [stdout] 244 | self.hasher.update(&mgf_seed).unwrap(); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `mgf_seed` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vrf/mod.rs:279:12 [INFO] [stdout] | [INFO] [stdout] 279 | if !(*k < 4_294_967_296usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*k >= 4_294_967_296usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vrf/mod.rs:298:23 [INFO] [stdout] | [INFO] [stdout] 298 | let m = os2ip(&em.as_slice()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `em.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vrf/mod.rs:373:13 [INFO] [stdout] | [INFO] [stdout] 373 | return Err(Error::InvalidProof); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 373 - return Err(Error::InvalidProof); [INFO] [stdout] 373 + Err(Error::InvalidProof) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ecvrf/primitives.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | let zeroes = if length % 8 > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace with: `!length.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/primitives.rs:92:6 [INFO] [stdout] | [INFO] [stdout] 92 | [&zeroes.as_slice(), data].concat() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `zeroes.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/primitives.rs:117:40 [INFO] [stdout] | [INFO] [stdout] 117 | let order = BigNum::from_slice(&order_.as_slice()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `order_.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/primitives.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | &data.as_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `data.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `error.errors().get(0)` [INFO] [stdout] --> src/ecvrf/mod.rs:78:15 [INFO] [stdout] | [INFO] [stdout] 78 | match error.errors().get(0).map(openssl::error::Error::code) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `error.errors().first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/ecvrf/mod.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | / match h { [INFO] [stdout] 187 | | Ok(hash_point) => Some(hash_point), [INFO] [stdout] 188 | | _ => None, [INFO] [stdout] 189 | | } [INFO] [stdout] | |_____________^ help: replace with: `h.ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/mod.rs:263:21 [INFO] [stdout] | [INFO] [stdout] 263 | &padded_secret_key.as_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `padded_secret_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/mod.rs:264:21 [INFO] [stdout] | [INFO] [stdout] 264 | &padded_data.as_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `padded_data.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:267:17 [INFO] [stdout] | [INFO] [stdout] 267 | &k, [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:269:27 [INFO] [stdout] | [INFO] [stdout] 269 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:269:31 [INFO] [stdout] | [INFO] [stdout] 269 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:274:27 [INFO] [stdout] | [INFO] [stdout] 274 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:274:31 [INFO] [stdout] | [INFO] [stdout] 274 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:288:17 [INFO] [stdout] | [INFO] [stdout] 288 | &k, [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:290:27 [INFO] [stdout] | [INFO] [stdout] 290 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/ecvrf/mod.rs:290:31 [INFO] [stdout] | [INFO] [stdout] 290 | v = HMAC::mac(&v, &k); [INFO] [stdout] | ^^ help: change this to: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/mod.rs:322:28 [INFO] [stdout] | [INFO] [stdout] 322 | self.hasher.update(&concatenate_points?.as_slice()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `concatenate_points?.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ecvrf/mod.rs:392:25 [INFO] [stdout] | [INFO] [stdout] 392 | let pt_len = if self.qlen % 8 > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `!self.qlen.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ecvrf/mod.rs:397:24 [INFO] [stdout] | [INFO] [stdout] 397 | let c_len = if self.n % 8 > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace with: `!self.n.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ecvrf/mod.rs:479:26 [INFO] [stdout] | [INFO] [stdout] 479 | let pi_string = [&gamma_string.as_slice(), c_string.as_slice(), s_string.as_slice()].concat(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `gamma_string.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ecvrf/mod.rs:622:13 [INFO] [stdout] | [INFO] [stdout] 622 | return Err(Error::InvalidProof); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 622 - return Err(Error::InvalidProof); [INFO] [stdout] 622 + Err(Error::InvalidProof) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.53s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: openssl v0.10.41 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 4` [INFO] running `Command { std: "docker" "inspect" "93ca5c62cb38d6d62e29932fbd0ff5298a7c383fa8b43564977d2641bfe6c3b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93ca5c62cb38d6d62e29932fbd0ff5298a7c383fa8b43564977d2641bfe6c3b4", kill_on_drop: false }` [INFO] [stdout] 93ca5c62cb38d6d62e29932fbd0ff5298a7c383fa8b43564977d2641bfe6c3b4