[INFO] fetching crate vole 0.1.1... [INFO] linting vole-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate vole 0.1.1 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate vole 0.1.1 [INFO] finished tweaking crates.io crate vole 0.1.1 [INFO] tweaked toml for crates.io crate vole 0.1.1 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate vole 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate vole 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded smallbitvec v2.5.1 [INFO] [stderr] Downloaded tracing-attributes v0.1.21 [INFO] [stderr] Downloaded test-log v0.2.10 [INFO] [stderr] Downloaded anyhow v1.0.57 [INFO] [stderr] Downloaded unicode-segmentation v1.9.0 [INFO] [stderr] Downloaded tracing-core v0.1.26 [INFO] [stderr] Downloaded tracing v0.1.34 [INFO] [stderr] Downloaded tracing-appender v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f364a43c1784f39f1df47d802c8209a1e3022714db7c16ac060f40d03226b221 [INFO] running `Command { std: "docker" "start" "-a" "f364a43c1784f39f1df47d802c8209a1e3022714db7c16ac060f40d03226b221", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f364a43c1784f39f1df47d802c8209a1e3022714db7c16ac060f40d03226b221", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f364a43c1784f39f1df47d802c8209a1e3022714db7c16ac060f40d03226b221", kill_on_drop: false }` [INFO] [stdout] f364a43c1784f39f1df47d802c8209a1e3022714db7c16ac060f40d03226b221 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b28141d38e9ce86a469a7fb082cc3ee4b0967739c3e3072e763c9e61ec21ef8 [INFO] running `Command { std: "docker" "start" "-a" "6b28141d38e9ce86a469a7fb082cc3ee4b0967739c3e3072e763c9e61ec21ef8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Checking tracing-core v0.1.26 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Compiling semver v1.0.9 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Compiling anyhow v1.0.57 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking cpu-time v1.0.0 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking seahash v4.1.0 [INFO] [stderr] Checking smallbitvec v2.5.1 [INFO] [stderr] Checking plotters-backend v0.3.2 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking criterion-plot v0.4.4 [INFO] [stderr] Checking plotters-svg v0.3.1 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling tracing-attributes v0.1.21 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Compiling test-log v0.2.10 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking tracing v0.1.34 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.5 [INFO] [stderr] Checking tracing-appender v0.1.2 [INFO] [stderr] Checking vole v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/domain_state.rs:95:37 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn refine_partition_cell_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 101 | F: Fn(&usize) -> T, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/domain_state.rs:106:37 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn base_refine_partition_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 111 | F: Fn(&usize) -> T, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/domain_state.rs:116:41 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn extended_refine_partition_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 121 | F: Fn(&usize) -> T, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/partition_stack.rs:431:37 [INFO] [stdout] | [INFO] [stdout] 431 | pub fn refine_partition_cell_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 438 | F: Fn(&usize) -> O, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/partition_stack.rs:486:37 [INFO] [stdout] | [INFO] [stdout] 486 | pub fn base_refine_partition_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 492 | F: Fn(&usize) -> O, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/partition_stack.rs:503:41 [INFO] [stdout] | [INFO] [stdout] 503 | pub fn extended_refine_partition_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 509 | F: Fn(&usize) -> O, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/vole/search/checkers.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / /// Check when we reach a candidate solution [INFO] [stdout] 10 | | [INFO] [stdout] | |_^ [INFO] [stdout] 11 | /// Check if current DomainState produces a smaller canonical image [INFO] [stdout] 12 | pub fn check_canonical(in_state: &mut State, sols: &mut Solutions) { [INFO] [stdout] | ---------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 10 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/selector.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | fn find_best_cell(state: &State, func: F) -> usize [INFO] [stdout] | ^ [INFO] [stdout] 25 | where [INFO] [stdout] 26 | F: Fn(&State, usize) -> T, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/datastructures/digraph.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | &**self.digraph [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&self.digraph` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/domain_state.rs:95:37 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn refine_partition_cell_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 101 | F: Fn(&usize) -> T, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] = note: `#[warn(clippy::multiple_bound_locations)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/domain_state.rs:106:37 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn base_refine_partition_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 111 | F: Fn(&usize) -> T, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/domain_state.rs:116:41 [INFO] [stdout] | [INFO] [stdout] 116 | pub fn extended_refine_partition_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 121 | F: Fn(&usize) -> T, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/partition_stack.rs:431:37 [INFO] [stdout] | [INFO] [stdout] 431 | pub fn refine_partition_cell_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 438 | F: Fn(&usize) -> O, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/partition_stack.rs:486:37 [INFO] [stdout] | [INFO] [stdout] 486 | pub fn base_refine_partition_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 492 | F: Fn(&usize) -> O, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/partition_stack.rs:503:41 [INFO] [stdout] | [INFO] [stdout] 503 | pub fn extended_refine_partition_by( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 509 | F: Fn(&usize) -> O, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/vole/search/checkers.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / /// Check when we reach a candidate solution [INFO] [stdout] 10 | | [INFO] [stdout] | |_^ [INFO] [stdout] 11 | /// Check if current DomainState produces a smaller canonical image [INFO] [stdout] 12 | pub fn check_canonical(in_state: &mut State, sols: &mut Solutions) { [INFO] [stdout] | ---------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 10 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bound is defined in more than one place [INFO] [stdout] --> src/vole/selector.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 24 | fn find_best_cell(state: &State, func: F) -> usize [INFO] [stdout] | ^ [INFO] [stdout] 25 | where [INFO] [stdout] 26 | F: Fn(&State, usize) -> T, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | orbit_mins: vec![usize::max_value(); size], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - orbit_mins: vec![usize::max_value(); size], [INFO] [stdout] 16 + orbit_mins: vec![usize::MAX; size], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:17:34 [INFO] [stdout] | [INFO] [stdout] 17 | depth_explored: vec![usize::max_value(); size], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - depth_explored: vec![usize::max_value(); size], [INFO] [stdout] 17 + depth_explored: vec![usize::MAX; size], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 23 | self.orbit_mins.push(usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 23 - self.orbit_mins.push(usize::max_value()); [INFO] [stdout] 23 + self.orbit_mins.push(usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | self.depth_explored.push(usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - self.depth_explored.push(usize::max_value()); [INFO] [stdout] 24 + self.depth_explored.push(usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:37:37 [INFO] [stdout] | [INFO] [stdout] 37 | while self.orbit_mins[p] != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 37 - while self.orbit_mins[p] != usize::max_value() { [INFO] [stdout] 37 + while self.orbit_mins[p] != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | self.orbit_mins[base] = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 72 - self.orbit_mins[base] = usize::max_value(); [INFO] [stdout] 72 + self.orbit_mins[base] = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:87:34 [INFO] [stdout] | [INFO] [stdout] 87 | if self.orbit_mins[c] != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 87 - if self.orbit_mins[c] != usize::max_value() { [INFO] [stdout] 87 + if self.orbit_mins[c] != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/datastructures/unionfind.rs:111:41 [INFO] [stdout] | [INFO] [stdout] 111 | let mut orbs: Vec> = h.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `h.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gap_chat.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | &mut (self.out_file.as_mut().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(self.out_file.as_mut().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/partition_stack.rs:141:26 [INFO] [stdout] | [INFO] [stdout] 141 | self.splits.push(usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 141 - self.splits.push(usize::max_value()); [INFO] [stdout] 141 + self.splits.push(usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/partition_stack.rs:365:23 [INFO] [stdout] | [INFO] [stdout] 365 | if unsplit == usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 365 - if unsplit == usize::max_value() { [INFO] [stdout] 365 + if unsplit == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/refiners/gaprefiner.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | let mut new_vertlabels = vec![usize::max_value(); extended_start + extra_points]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 48 - let mut new_vertlabels = vec![usize::max_value(); extended_start + extra_points]; [INFO] [stdout] 48 + let mut new_vertlabels = vec![usize::MAX; extended_start + extra_points]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/refiners/gaprefiner.rs:51:46 [INFO] [stdout] | [INFO] [stdout] 51 | *label = *part.get(i).unwrap_or(&usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 51 - *label = *part.get(i).unwrap_or(&usize::max_value()); [INFO] [stdout] 51 + *label = *part.get(i).unwrap_or(&usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/refiners/gaprefiner.rs:54:86 [INFO] [stdout] | [INFO] [stdout] 54 | new_vertlabels[i + extended_start] = *part.get(i + base_size).unwrap_or(&usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 54 - new_vertlabels[i + extended_start] = *part.get(i + base_size).unwrap_or(&usize::max_value()); [INFO] [stdout] 54 + new_vertlabels[i + extended_start] = *part.get(i + base_size).unwrap_or(&usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/refiners/gaprefiner.rs:155:80 [INFO] [stdout] | [INFO] [stdout] 155 | state.extended_refine_partition_by(|x| part.get(*x).unwrap_or(&usize::max_value()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 155 - state.extended_refine_partition_by(|x| part.get(*x).unwrap_or(&usize::max_value()))?; [INFO] [stdout] 155 + state.extended_refine_partition_by(|x| part.get(*x).unwrap_or(&usize::MAX))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vole/refiners/refiner_store.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | return self.refiners.iter().map(|r| r.any_image(p, Side::Left)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return self.refiners.iter().map(|r| r.any_image(p, Side::Left)).collect(); [INFO] [stdout] 101 + self.refiners.iter().map(|r| r.any_image(p, Side::Left)).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/vole/refiners/simple.rs:358:53 [INFO] [stdout] | [INFO] [stdout] 358 | state.add_invariant_fact(set.iter().any(|x| x.len() == 0))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vole/search/mod.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | assert!(!(doing_first_branch && !sols.orbit_needs_searching(c, depth))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!doing_first_branch || sols.orbit_needs_searching(c, depth)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/datastructures/small_int_set.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn sorted_iter(&mut self) -> ::std::slice::Iter { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 33 | pub fn sorted_iter(&mut self) -> ::std::slice::Iter<'_, usize> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/datastructures/sortedvec.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn iter(&self) -> std::slice::Iter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 28 | pub fn iter(&self) -> std::slice::Iter<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/datastructures/digraph.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | &**self.digraph [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `&self.digraph` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/datastructures/digraph.rs:296:17 [INFO] [stdout] | [INFO] [stdout] 296 | assert!(!(d < d)); [INFO] [stdout] | ^^^^^^^^ help: try: `(d >= d)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/datastructures/digraph.rs:333:17 [INFO] [stdout] | [INFO] [stdout] 333 | assert!(!(d < de)); [INFO] [stdout] | ^^^^^^^^^ help: try: `(d >= de)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | orbit_mins: vec![usize::max_value(); size], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 16 - orbit_mins: vec![usize::max_value(); size], [INFO] [stdout] 16 + orbit_mins: vec![usize::MAX; size], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:17:34 [INFO] [stdout] | [INFO] [stdout] 17 | depth_explored: vec![usize::max_value(); size], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 17 - depth_explored: vec![usize::max_value(); size], [INFO] [stdout] 17 + depth_explored: vec![usize::MAX; size], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:23:34 [INFO] [stdout] | [INFO] [stdout] 23 | self.orbit_mins.push(usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 23 - self.orbit_mins.push(usize::max_value()); [INFO] [stdout] 23 + self.orbit_mins.push(usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | self.depth_explored.push(usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - self.depth_explored.push(usize::max_value()); [INFO] [stdout] 24 + self.depth_explored.push(usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:37:37 [INFO] [stdout] | [INFO] [stdout] 37 | while self.orbit_mins[p] != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 37 - while self.orbit_mins[p] != usize::max_value() { [INFO] [stdout] 37 + while self.orbit_mins[p] != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | self.orbit_mins[base] = usize::max_value(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 72 - self.orbit_mins[base] = usize::max_value(); [INFO] [stdout] 72 + self.orbit_mins[base] = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/datastructures/unionfind.rs:87:34 [INFO] [stdout] | [INFO] [stdout] 87 | if self.orbit_mins[c] != usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 87 - if self.orbit_mins[c] != usize::max_value() { [INFO] [stdout] 87 + if self.orbit_mins[c] != usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: iterating on a map's values [INFO] [stdout] --> src/datastructures/unionfind.rs:111:41 [INFO] [stdout] | [INFO] [stdout] 111 | let mut orbs: Vec> = h.into_iter().map(|(_, v)| v).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `h.into_values()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map [INFO] [stdout] = note: `#[warn(clippy::iter_kv_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/gap_chat.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | &mut (self.out_file.as_mut().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(self.out_file.as_mut().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/perm/mod.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 199 | assert!(!(Permutation::id() < Permutation::id())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(Permutation::id() >= Permutation::id())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/perm/mod.rs:201:17 [INFO] [stdout] | [INFO] [stdout] 201 | assert!(!(Permutation::id() < Permutation::from_vec(vec![0, 1, 2]))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(Permutation::id() >= Permutation::from_vec(vec![0, 1, 2]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/perm/mod.rs:206:17 [INFO] [stdout] | [INFO] [stdout] 206 | assert!(!(id > cycle)); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `(id <= cycle)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/partition_stack.rs:141:26 [INFO] [stdout] | [INFO] [stdout] 141 | self.splits.push(usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 141 - self.splits.push(usize::max_value()); [INFO] [stdout] 141 + self.splits.push(usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/partition_stack.rs:365:23 [INFO] [stdout] | [INFO] [stdout] 365 | if unsplit == usize::max_value() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 365 - if unsplit == usize::max_value() { [INFO] [stdout] 365 + if unsplit == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/refiners/gaprefiner.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | let mut new_vertlabels = vec![usize::max_value(); extended_start + extra_points]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 48 - let mut new_vertlabels = vec![usize::max_value(); extended_start + extra_points]; [INFO] [stdout] 48 + let mut new_vertlabels = vec![usize::MAX; extended_start + extra_points]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/refiners/gaprefiner.rs:51:46 [INFO] [stdout] | [INFO] [stdout] 51 | *label = *part.get(i).unwrap_or(&usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 51 - *label = *part.get(i).unwrap_or(&usize::max_value()); [INFO] [stdout] 51 + *label = *part.get(i).unwrap_or(&usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/refiners/gaprefiner.rs:54:86 [INFO] [stdout] | [INFO] [stdout] 54 | new_vertlabels[i + extended_start] = *part.get(i + base_size).unwrap_or(&usize::max_value()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 54 - new_vertlabels[i + extended_start] = *part.get(i + base_size).unwrap_or(&usize::max_value()); [INFO] [stdout] 54 + new_vertlabels[i + extended_start] = *part.get(i + base_size).unwrap_or(&usize::MAX); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric method [INFO] [stdout] --> src/vole/refiners/gaprefiner.rs:155:80 [INFO] [stdout] | [INFO] [stdout] 155 | state.extended_refine_partition_by(|x| part.get(*x).unwrap_or(&usize::max_value()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 155 - state.extended_refine_partition_by(|x| part.get(*x).unwrap_or(&usize::max_value()))?; [INFO] [stdout] 155 + state.extended_refine_partition_by(|x| part.get(*x).unwrap_or(&usize::MAX))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vole/refiners/refiner_store.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | return self.refiners.iter().map(|r| r.any_image(p, Side::Left)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return self.refiners.iter().map(|r| r.any_image(p, Side::Left)).collect(); [INFO] [stdout] 101 + self.refiners.iter().map(|r| r.any_image(p, Side::Left)).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/vole/refiners/simple.rs:358:53 [INFO] [stdout] | [INFO] [stdout] 358 | state.add_invariant_fact(set.iter().any(|x| x.len() == 0))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vole/search/mod.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | assert!(!(doing_first_branch && !sols.orbit_needs_searching(c, depth))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!doing_first_branch || sols.orbit_needs_searching(c, depth)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/datastructures/sortedvec.rs:77:33 [INFO] [stdout] | [INFO] [stdout] 77 | let t: SortedVec = vec![4, 3, 1].iter().map(|&x| x + 1).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: you can use an array directly: `[4, 3, 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/datastructures/small_int_set.rs:33:24 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn sorted_iter(&mut self) -> ::std::slice::Iter { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 33 | pub fn sorted_iter(&mut self) -> ::std::slice::Iter<'_, usize> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/datastructures/sortedvec.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn iter(&self) -> std::slice::Iter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 28 | pub fn iter(&self) -> std::slice::Iter<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 44.57s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.3.5 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 5` [INFO] running `Command { std: "docker" "inspect" "6b28141d38e9ce86a469a7fb082cc3ee4b0967739c3e3072e763c9e61ec21ef8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b28141d38e9ce86a469a7fb082cc3ee4b0967739c3e3072e763c9e61ec21ef8", kill_on_drop: false }` [INFO] [stdout] 6b28141d38e9ce86a469a7fb082cc3ee4b0967739c3e3072e763c9e61ec21ef8