[INFO] fetching crate voiceflousion 0.3.1... [INFO] linting voiceflousion-0.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate voiceflousion 0.3.1 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate voiceflousion 0.3.1 [INFO] finished tweaking crates.io crate voiceflousion 0.3.1 [INFO] tweaked toml for crates.io crate voiceflousion 0.3.1 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate voiceflousion 0.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 203 packages to latest compatible versions [INFO] [stderr] Adding axum v0.7.9 (available: v0.8.8) [INFO] [stderr] Adding axum-core v0.4.5 (available: v0.5.6) [INFO] [stderr] Adding derive_more v1.0.0 (available: v2.1.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] [stderr] Adding reqwest v0.12.28 (available: v0.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97fdeb6ef3aca2bdbdb4dc40a9937c795bf24a05043f954558e4886645e8fcb3 [INFO] running `Command { std: "docker" "start" "-a" "97fdeb6ef3aca2bdbdb4dc40a9937c795bf24a05043f954558e4886645e8fcb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97fdeb6ef3aca2bdbdb4dc40a9937c795bf24a05043f954558e4886645e8fcb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97fdeb6ef3aca2bdbdb4dc40a9937c795bf24a05043f954558e4886645e8fcb3", kill_on_drop: false }` [INFO] [stdout] 97fdeb6ef3aca2bdbdb4dc40a9937c795bf24a05043f954558e4886645e8fcb3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 80da9ca2cc9393937a0a2134a705226024432466599b1df593f8768d9ea9b26b [INFO] running `Command { std: "docker" "start" "-a" "80da9ca2cc9393937a0a2134a705226024432466599b1df593f8768d9ea9b26b", kill_on_drop: false }` [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking iri-string v0.7.10 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking openssl v0.10.76 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking native-tls v0.2.18 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking voiceflousion v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/lib.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | #[cfg(any(feature = "server"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "server"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/lib.rs:5:7 [INFO] [stdout] | [INFO] [stdout] 5 | #[cfg(any(feature = "server"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "server"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `client::get_last_sent_message` [INFO] [stdout] --> src/core/traits/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | client::get_last_sent_message [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `client::get_last_sent_message` [INFO] [stdout] --> src/core/traits/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | client::get_last_sent_message [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Intent` is never constructed [INFO] [stdout] --> src/core/voiceflow/request_structures/action_type.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) enum ActionType { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 14 | Intent, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ActionType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `intent` is never used [INFO] [stdout] --> src/core/voiceflow/request_structures/action.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 28 | impl ActionBuilder { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 70 | pub fn intent(mut self, name: String, path: String) -> Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/core/traits/client.rs:153:64 [INFO] [stdout] | [INFO] [stdout] 153 | let voiceflow_button = previous_message.get_button(button_index.clone())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `button_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Intent` is never constructed [INFO] [stdout] --> src/core/voiceflow/request_structures/action_type.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) enum ActionType { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 14 | Intent, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ActionType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `intent` is never used [INFO] [stdout] --> src/core/voiceflow/request_structures/action.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 28 | impl ActionBuilder { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 70 | pub fn intent(mut self, name: String, path: String) -> Self { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/core/traits/client.rs:225:109 [INFO] [stdout] | [INFO] [stdout] 225 | ...interaction_time, update_state, button_index.clone()).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*button_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/core/traits/client.rs:235:84 [INFO] [stdout] | [INFO] [stdout] 235 | self.handle_carousel_switch(&locked_session, interaction_time, switch_direction.clone()).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*switch_direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/core/traits/client.rs:282:5 [INFO] [stdout] | [INFO] [stdout] 282 | / if let Some(responder) = response.last(){ [INFO] [stdout] 283 | | Some(responder.create_sent_message()) [INFO] [stdout] 284 | | } [INFO] [stdout] 285 | | else{ [INFO] [stdout] 286 | | None [INFO] [stdout] 287 | | } [INFO] [stdout] | |_____^ help: try: `response.last().map(|responder| responder.create_sent_message())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/core/traits/client.rs:153:64 [INFO] [stdout] | [INFO] [stdout] 153 | let voiceflow_button = previous_message.get_button(button_index.clone())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `button_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/traits/sender.rs:89:42 [INFO] [stdout] | [INFO] [stdout] 89 | async fn send_text(&self, client_id: &String, text: VoiceflowText, chat_id: &String) -> VoiceflousionResult; [INFO] [stdout] | ^^^^^^^ help: change this to: `&'life1 str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/traits/sender.rs:89:81 [INFO] [stdout] | [INFO] [stdout] 89 | async fn send_text(&self, client_id: &String, text: VoiceflowText, chat_id: &String) -> VoiceflousionResult; [INFO] [stdout] | ^^^^^^^ help: change this to: `&'life2 str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/core/traits/client.rs:225:109 [INFO] [stdout] | [INFO] [stdout] 225 | ...interaction_time, update_state, button_index.clone()).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*button_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/traits/sender.rs:102:43 [INFO] [stdout] | [INFO] [stdout] 102 | async fn send_image(&self, client_id: &String, image: VoiceflowImage, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:102:84 [INFO] [stdout] | [INFO] [stdout] 102 | async fn send_image(&self, client_id: &String, image: VoiceflowImage, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:115:45 [INFO] [stdout] | [INFO] [stdout] 115 | async fn send_buttons(&self, client_id: &String, buttons: VoiceflowButtons, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:115:90 [INFO] [stdout] | [INFO] [stdout] 115 | ...ring, buttons: VoiceflowButtons, chat_id: &String) -> VoiceflousionResult; [INFO] [stdout] | ^^^^^^^ help: change this to: `&'life2 str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/traits/sender.rs:128:42 [INFO] [stdout] | [INFO] [stdout] 128 | async fn send_card(&self, client_id: &String, card: VoiceflowCard, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:128:81 [INFO] [stdout] | [INFO] [stdout] 128 | async fn send_card(&self, client_id: &String, card: VoiceflowCard, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:141:46 [INFO] [stdout] | [INFO] [stdout] 141 | async fn send_carousel(&self, client_id: &String, carousel: VoiceflowCarousel, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:141:93 [INFO] [stdout] | [INFO] [stdout] 141 | ...ng, carousel: VoiceflowCarousel, chat_id: &String) -> VoiceflousionResult; [INFO] [stdout] | ^^^^^^^ help: change this to: `&'life2 str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `bool` which implements the `Copy` trait [INFO] [stdout] --> src/core/traits/client.rs:235:84 [INFO] [stdout] | [INFO] [stdout] 235 | self.handle_carousel_switch(&locked_session, interaction_time, switch_direction.clone()).await [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*switch_direction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/core/traits/client.rs:282:5 [INFO] [stdout] | [INFO] [stdout] 282 | / if let Some(responder) = response.last(){ [INFO] [stdout] 283 | | Some(responder.create_sent_message()) [INFO] [stdout] 284 | | } [INFO] [stdout] 285 | | else{ [INFO] [stdout] 286 | | None [INFO] [stdout] 287 | | } [INFO] [stdout] | |_____^ help: try: `response.last().map(|responder| responder.create_sent_message())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/traits/sender.rs:89:42 [INFO] [stdout] | [INFO] [stdout] 89 | async fn send_text(&self, client_id: &String, text: VoiceflowText, chat_id: &String) -> VoiceflousionResult; [INFO] [stdout] | ^^^^^^^ help: change this to: `&'life1 str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/traits/sender.rs:89:81 [INFO] [stdout] | [INFO] [stdout] 89 | async fn send_text(&self, client_id: &String, text: VoiceflowText, chat_id: &String) -> VoiceflousionResult; [INFO] [stdout] | ^^^^^^^ help: change this to: `&'life2 str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/traits/sender.rs:102:43 [INFO] [stdout] | [INFO] [stdout] 102 | async fn send_image(&self, client_id: &String, image: VoiceflowImage, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:102:84 [INFO] [stdout] | [INFO] [stdout] 102 | async fn send_image(&self, client_id: &String, image: VoiceflowImage, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:115:45 [INFO] [stdout] | [INFO] [stdout] 115 | async fn send_buttons(&self, client_id: &String, buttons: VoiceflowButtons, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:115:90 [INFO] [stdout] | [INFO] [stdout] 115 | ...ring, buttons: VoiceflowButtons, chat_id: &String) -> VoiceflousionResult; [INFO] [stdout] | ^^^^^^^ help: change this to: `&'life2 str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/traits/sender.rs:128:42 [INFO] [stdout] | [INFO] [stdout] 128 | async fn send_card(&self, client_id: &String, card: VoiceflowCard, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:128:81 [INFO] [stdout] | [INFO] [stdout] 128 | async fn send_card(&self, client_id: &String, card: VoiceflowCard, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:141:46 [INFO] [stdout] | [INFO] [stdout] 141 | async fn send_carousel(&self, client_id: &String, carousel: VoiceflowCarousel, chat_id: &String) -> VoiceflousionResult src/core/traits/sender.rs:141:93 [INFO] [stdout] | [INFO] [stdout] 141 | ...ng, carousel: VoiceflowCarousel, chat_id: &String) -> VoiceflousionResult; [INFO] [stdout] | ^^^^^^^ help: change this to: `&'life2 str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/session_wrappers/session_map.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | !(now - last_interaction > *duration * 1000_i64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(now - last_interaction <= *duration * 1000_i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core/session_wrappers/session_map.rs:154:17 [INFO] [stdout] | [INFO] [stdout] 154 | !(now - last_interaction > *duration * 1000_i64) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(now - last_interaction <= *duration * 1000_i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/core/subtypes/atomic_timestamp.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 20 | let timestamp: i64 = if let Some(time) = timestamp { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 21 | | time [INFO] [stdout] 22 | | } else { [INFO] [stdout] 23 | | -1 [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_________^ help: replace with: `timestamp.unwrap_or(-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/core/subtypes/atomic_timestamp.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 20 | let timestamp: i64 = if let Some(time) = timestamp { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 21 | | time [INFO] [stdout] 22 | | } else { [INFO] [stdout] 23 | | -1 [INFO] [stdout] 24 | | }; [INFO] [stdout] | |_________^ help: replace with: `timestamp.unwrap_or(-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/core/subtypes/atomic_timestamp.rs:54:25 [INFO] [stdout] | [INFO] [stdout] 54 | let timestamp = if let Some(interaction) = timestamp { [INFO] [stdout] | _________________________^ [INFO] [stdout] 55 | | interaction [INFO] [stdout] 56 | | } else { [INFO] [stdout] 57 | | -1 [INFO] [stdout] 58 | | }; [INFO] [stdout] | |_________^ help: replace with: `timestamp.unwrap_or(-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/core/subtypes/atomic_timestamp.rs:54:25 [INFO] [stdout] | [INFO] [stdout] 54 | let timestamp = if let Some(interaction) = timestamp { [INFO] [stdout] | _________________________^ [INFO] [stdout] 55 | | interaction [INFO] [stdout] 56 | | } else { [INFO] [stdout] 57 | | -1 [INFO] [stdout] 58 | | }; [INFO] [stdout] | |_________^ help: replace with: `timestamp.unwrap_or(-1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/core/subtypes/http_client.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 51 | let connection_duration = if let Some(duration) = connection_duration{ [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 52 | | duration [INFO] [stdout] 53 | | } [INFO] [stdout] 54 | | else{ [INFO] [stdout] 55 | | 120 [INFO] [stdout] 56 | | }; [INFO] [stdout] | |_________^ help: replace with: `connection_duration.unwrap_or(120)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this pattern reimplements `Option::unwrap_or` [INFO] [stdout] --> src/core/subtypes/http_client.rs:51:35 [INFO] [stdout] | [INFO] [stdout] 51 | let connection_duration = if let Some(duration) = connection_duration{ [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 52 | | duration [INFO] [stdout] 53 | | } [INFO] [stdout] 54 | | else{ [INFO] [stdout] 55 | | 120 [INFO] [stdout] 56 | | }; [INFO] [stdout] | |_________^ help: replace with: `connection_duration.unwrap_or(120)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/voiceflow/voiceflow_client.rs:298:94 [INFO] [stdout] | [INFO] [stdout] 298 | pub async fn send_message(&self, session: &VoiceflowSession, state: Option, text: &String) -> VoiceflowMessage { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 298 ~ pub async fn send_message(&self, session: &VoiceflowSession, state: Option, text: &str) -> VoiceflowMessage { [INFO] [stdout] 299 ~ let action = ActionBuilder::new(ActionType::Text).text(text.to_owned()).build(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/core/voiceflow/voiceflow_client.rs:298:94 [INFO] [stdout] | [INFO] [stdout] 298 | pub async fn send_message(&self, session: &VoiceflowSession, state: Option, text: &String) -> VoiceflowMessage { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 298 ~ pub async fn send_message(&self, session: &VoiceflowSession, state: Option, text: &str) -> VoiceflowMessage { [INFO] [stdout] 299 ~ let action = ActionBuilder::new(ActionType::Text).text(text.to_owned()).build(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 37 | async fn to_blocks(self) -> VoiceflousionResult> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 37 | async fn to_blocks(self) -> VoiceflousionResult> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:70:36 [INFO] [stdout] | [INFO] [stdout] 70 | pub(crate) async fn to_message(self) -> VoiceflousionResult{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:70:36 [INFO] [stdout] | [INFO] [stdout] 70 | pub(crate) async fn to_message(self) -> VoiceflousionResult{ [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:95:36 [INFO] [stdout] | [INFO] [stdout] 95 | current_data.push_str(&line[5..].trim()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | if line.starts_with("data:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 91 ~ if let Some() = line.strip_prefix("data:") { [INFO] [stdout] 92 | if !current_data.is_empty() { [INFO] [stdout] 93 | current_data.push('\n'); [INFO] [stdout] 94 | } [INFO] [stdout] 95 ~ current_data.push_str(&.trim()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:95:36 [INFO] [stdout] | [INFO] [stdout] 95 | current_data.push_str(&line[5..].trim()); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | if line.starts_with("data:") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 91 ~ if let Some() = line.strip_prefix("data:") { [INFO] [stdout] 92 | if !current_data.is_empty() { [INFO] [stdout] 93 | current_data.push('\n'); [INFO] [stdout] 94 | } [INFO] [stdout] 95 ~ current_data.push_str(&.trim()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:95:35 [INFO] [stdout] | [INFO] [stdout] 95 | current_data.push_str(&line[5..].trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `line[5..].trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:96:16 [INFO] [stdout] | [INFO] [stdout] 96 | } else if line.is_empty() { [INFO] [stdout] | ________________^ [INFO] [stdout] 97 | | if !current_data.is_empty() { [INFO] [stdout] 98 | | events.push(current_data.clone()); [INFO] [stdout] 99 | | current_data.clear(); [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 96 ~ } else if line.is_empty() [INFO] [stdout] 97 ~ && !current_data.is_empty() { [INFO] [stdout] 98 | events.push(current_data.clone()); [INFO] [stdout] 99 | current_data.clear(); [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:95:35 [INFO] [stdout] | [INFO] [stdout] 95 | current_data.push_str(&line[5..].trim()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `line[5..].trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response.rs:96:16 [INFO] [stdout] | [INFO] [stdout] 96 | } else if line.is_empty() { [INFO] [stdout] | ________________^ [INFO] [stdout] 97 | | if !current_data.is_empty() { [INFO] [stdout] 98 | | events.push(current_data.clone()); [INFO] [stdout] 99 | | current_data.clear(); [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 96 ~ } else if line.is_empty() [INFO] [stdout] 97 ~ && !current_data.is_empty() { [INFO] [stdout] 98 | events.push(current_data.clone()); [INFO] [stdout] 99 | current_data.clear(); [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response_block_processor.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | / match buttons_options { [INFO] [stdout] 220 | | VoiceflowButtonsOption::Text(text) => message.push(VoiceflowBlock::Text(text)), [INFO] [stdout] 221 | | _ => {}, [INFO] [stdout] 222 | | } [INFO] [stdout] | |_________^ help: try: `if let VoiceflowButtonsOption::Text(text) = buttons_options { message.push(VoiceflowBlock::Text(text)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/core/voiceflow/response_structures/voiceflow_response_block_processor.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | / match buttons_options { [INFO] [stdout] 220 | | VoiceflowButtonsOption::Text(text) => message.push(VoiceflowBlock::Text(text)), [INFO] [stdout] 221 | | _ => {}, [INFO] [stdout] 222 | | } [INFO] [stdout] | |_________^ help: try: `if let VoiceflowButtonsOption::Text(text) = buttons_options { message.push(VoiceflowBlock::Text(text)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_carousel.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | /// Mixed carousels (some cards with images and others without) are not allowed and will trigger an error during initialization. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 22 | /// Mixed carousels (some cards with images and others without) are not allowed and will trigger an error during initialization. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_carousel.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | /// Mixed carousels (some cards with images and others without) are not allowed and will trigger an error during initialization. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 22 | /// Mixed carousels (some cards with images and others without) are not allowed and will trigger an error during initialization. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_carousel.rs:319:18 [INFO] [stdout] | [INFO] [stdout] 319 | .map(|card| VoiceflowCard::from_value(card)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VoiceflowCard::from_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_carousel.rs:319:18 [INFO] [stdout] | [INFO] [stdout] 319 | .map(|card| VoiceflowCard::from_value(card)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VoiceflowCard::from_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_carousel.rs:318:14 [INFO] [stdout] | [INFO] [stdout] 318 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_carousel.rs:318:14 [INFO] [stdout] | [INFO] [stdout] 318 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_carousel.rs:321:67 [INFO] [stdout] | [INFO] [stdout] 321 | let cards: Vec = cards_option?.into_iter().filter_map(|card| card).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_carousel.rs:321:67 [INFO] [stdout] | [INFO] [stdout] 321 | let cards: Vec = cards_option?.into_iter().filter_map(|card| card).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] = note: `#[warn(clippy::filter_map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_buttons.rs:176:18 [INFO] [stdout] | [INFO] [stdout] 176 | .map(|button| VoiceflowButton::from_value(button)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VoiceflowButton::from_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_buttons.rs:176:18 [INFO] [stdout] | [INFO] [stdout] 176 | .map(|button| VoiceflowButton::from_value(button)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `VoiceflowButton::from_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_buttons.rs:175:102 [INFO] [stdout] | [INFO] [stdout] 175 | let buttons_option: Result>, VoiceflousionError> = buttons_value.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_buttons.rs:175:102 [INFO] [stdout] | [INFO] [stdout] 175 | let buttons_option: Result>, VoiceflousionError> = buttons_value.into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_buttons.rs:180:73 [INFO] [stdout] | [INFO] [stdout] 180 | let buttons: Vec = buttons_option?.into_iter().filter_map(|button| button).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `filter_map` with an identity function [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_buttons.rs:180:73 [INFO] [stdout] | [INFO] [stdout] 180 | let buttons: Vec = buttons_option?.into_iter().filter_map(|button| button).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_map_identity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_card.rs:144:23 [INFO] [stdout] | [INFO] [stdout] 144 | let payload = value["trace"].get("payload").unwrap_or_else(|| value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 144 - let payload = value["trace"].get("payload").unwrap_or_else(|| value); [INFO] [stdout] 144 + let payload = value["trace"].get("payload").unwrap_or(value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/core/voiceflow/dialog_blocks/voiceflow_card.rs:144:23 [INFO] [stdout] | [INFO] [stdout] 144 | let payload = value["trace"].get("payload").unwrap_or_else(|| value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 144 - let payload = value["trace"].get("payload").unwrap_or_else(|| value); [INFO] [stdout] 144 + let payload = value["trace"].get("payload").unwrap_or(value); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/core/base_structs/sessions_manager.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | if let Some(interval) = manager.cleanup_interval.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `manager.cleanup_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/core/base_structs/sessions_manager.rs:72:33 [INFO] [stdout] | [INFO] [stdout] 72 | if let Some(interval) = manager.cleanup_interval.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `manager.cleanup_interval` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/core/base_structs/client_base.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Some(token) = secret_auth_token{ [INFO] [stdout] 64 | | Some(BotAuthToken::new(token)) [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | else{ [INFO] [stdout] 67 | | None [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________________^ help: try: `secret_auth_token.map(BotAuthToken::new)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/core/base_structs/client_base.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Some(token) = secret_auth_token{ [INFO] [stdout] 64 | | Some(BotAuthToken::new(token)) [INFO] [stdout] 65 | | } [INFO] [stdout] 66 | | else{ [INFO] [stdout] 67 | | None [INFO] [stdout] 68 | | } [INFO] [stdout] | |_________________^ help: try: `secret_auth_token.map(BotAuthToken::new)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ClientsManager` [INFO] [stdout] --> src/core/base_structs/clients_manager.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / pub fn new() -> Self { [INFO] [stdout] 32 | | Self { [INFO] [stdout] 33 | | clients: Arc::new(RwLock::new(HashMap::>::new())) [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for ClientsManager { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ClientsManager` [INFO] [stdout] --> src/core/base_structs/clients_manager.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / pub fn new() -> Self { [INFO] [stdout] 32 | | Self { [INFO] [stdout] 33 | | clients: Arc::new(RwLock::new(HashMap::>::new())) [INFO] [stdout] 34 | | } [INFO] [stdout] 35 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for ClientsManager { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/core/base_structs/clients_manager.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / let _ = clients_vec.into_iter().for_each(|client| { [INFO] [stdout] 61 | | hash_map.insert(client.client_base().client_id().clone(), Arc::new(client)); [INFO] [stdout] 62 | | }); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 60 - let _ = clients_vec.into_iter().for_each(|client| { [INFO] [stdout] 60 + clients_vec.into_iter().for_each(|client| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/core/base_structs/clients_manager.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / let _ = clients_vec.into_iter().for_each(|client| { [INFO] [stdout] 61 | | hash_map.insert(client.client_base().client_id().clone(), Arc::new(client)); [INFO] [stdout] 62 | | }); [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 60 - let _ = clients_vec.into_iter().for_each(|client| { [INFO] [stdout] 60 + clients_vec.into_iter().for_each(|client| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/session_wrappers/session.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 100 | pub(super) fn try_lock(&self) -> VoiceflousionResult>{ [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 100 | pub(super) fn try_lock(&self) -> VoiceflousionResult>{ [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/core/session_wrappers/session.rs:100:28 [INFO] [stdout] | [INFO] [stdout] 100 | pub(super) fn try_lock(&self) -> VoiceflousionResult>{ [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 100 | pub(super) fn try_lock(&self) -> VoiceflousionResult>{ [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.60s [INFO] running `Command { std: "docker" "inspect" "80da9ca2cc9393937a0a2134a705226024432466599b1df593f8768d9ea9b26b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80da9ca2cc9393937a0a2134a705226024432466599b1df593f8768d9ea9b26b", kill_on_drop: false }` [INFO] [stdout] 80da9ca2cc9393937a0a2134a705226024432466599b1df593f8768d9ea9b26b