[INFO] fetching crate verilog-netlist-parser 0.1.0... [INFO] linting verilog-netlist-parser-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate verilog-netlist-parser 0.1.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate verilog-netlist-parser 0.1.0 [INFO] finished tweaking crates.io crate verilog-netlist-parser 0.1.0 [INFO] tweaked toml for crates.io crate verilog-netlist-parser 0.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate verilog-netlist-parser 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate verilog-netlist-parser 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cpufeatures v0.2.9 [INFO] [stderr] Downloaded thiserror-impl v1.0.49 [INFO] [stderr] Downloaded proc-macro2 v1.0.67 [INFO] [stderr] Downloaded ucd-trie v0.1.6 [INFO] [stderr] Downloaded clap_lex v0.2.4 [INFO] [stderr] Downloaded winapi-util v0.1.6 [INFO] [stderr] Downloaded thiserror v1.0.49 [INFO] [stderr] Downloaded os_str_bytes v6.6.1 [INFO] [stderr] Downloaded pest v2.7.4 [INFO] [stderr] Downloaded textwrap v0.16.0 [INFO] [stderr] Downloaded pest_derive v2.7.4 [INFO] [stderr] Downloaded syn v2.0.37 [INFO] [stderr] Downloaded memchr v2.6.3 [INFO] [stderr] Downloaded termcolor v1.3.0 [INFO] [stderr] Downloaded pest_generator v2.7.4 [INFO] [stderr] Downloaded pest_meta v2.7.4 [INFO] [stderr] Downloaded clap v3.2.25 [INFO] [stderr] Downloaded cbindgen v0.26.0 [INFO] [stderr] Downloaded libc v0.2.148 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f0a64ba7e6d722a653342d2c388e467d93eecf6850904971bdaa0ece3c91a8c5 [INFO] running `Command { std: "docker" "start" "-a" "f0a64ba7e6d722a653342d2c388e467d93eecf6850904971bdaa0ece3c91a8c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f0a64ba7e6d722a653342d2c388e467d93eecf6850904971bdaa0ece3c91a8c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f0a64ba7e6d722a653342d2c388e467d93eecf6850904971bdaa0ece3c91a8c5", kill_on_drop: false }` [INFO] [stdout] f0a64ba7e6d722a653342d2c388e467d93eecf6850904971bdaa0ece3c91a8c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70311c2014e15e6d0130e71bfc8c6469699d023bc2502cbcbf931c51c2401e9b [INFO] running `Command { std: "docker" "start" "-a" "70311c2014e15e6d0130e71bfc8c6469699d023bc2502cbcbf931c51c2401e9b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Compiling bitflags v2.4.1 [INFO] [stderr] Compiling linux-raw-sys v0.4.10 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Compiling os_str_bytes v6.6.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling fastrand v2.0.1 [INFO] [stderr] Compiling textwrap v0.16.0 [INFO] [stderr] Compiling itoa v1.0.9 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling ryu v1.0.15 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling cbindgen v0.26.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling termcolor v1.3.0 [INFO] [stderr] Compiling memchr v2.6.3 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling clap_lex v0.2.4 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling clap v3.2.25 [INFO] [stderr] Compiling tempfile v3.8.1 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Checking pest v2.7.4 [INFO] [stderr] Compiling pest_meta v2.7.4 [INFO] [stderr] Compiling pest_generator v2.7.4 [INFO] [stderr] Compiling pest_derive v2.7.4 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling verilog-netlist-parser v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:105:50 [INFO] [stdout] | [INFO] [stdout] 105 | VerilogIndexID { id: VerilogID::new(id), index: index, formatted_index_id: formatted_index_id } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:105:64 [INFO] [stdout] | [INFO] [stdout] 105 | VerilogIndexID { id: VerilogID::new(id), index: index, formatted_index_id: formatted_index_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatted_index_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | range_from: range_from, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `range_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | range_to: range_to, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `range_to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | formatted_slice_id: formatted_slice_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatted_slice_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:263:26 [INFO] [stdout] | [INFO] [stdout] 263 | VerilogNetExpr { line_no: line_no } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `line_no` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:279:68 [INFO] [stdout] | [INFO] [stdout] 279 | VerilogNetIDExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id: verilog_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:318:72 [INFO] [stdout] | [INFO] [stdout] 318 | VerilogNetConcatExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id_concat: verilog_id_concat } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id_concat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:361:71 [INFO] [stdout] | [INFO] [stdout] 361 | VerilogConstantExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id: verilog_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:400:37 [INFO] [stdout] | [INFO] [stdout] 400 | VerilogPortRefPortConnect { port_id: port_id, net_expr: net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:400:55 [INFO] [stdout] | [INFO] [stdout] 400 | VerilogPortRefPortConnect { port_id: port_id, net_expr: net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:467:23 [INFO] [stdout] | [INFO] [stdout] 467 | VerilogStmt { line_no: line_no } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `line_no` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:495:13 [INFO] [stdout] | [INFO] [stdout] 495 | port_connections: port_connections, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_connections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:839:58 [INFO] [stdout] | [INFO] [stdout] 839 | VerilogAssign { stmt: VerilogStmt::new(line_no), left_net_expr: left_net_expr, right_net_expr: right_net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:105:50 [INFO] [stdout] | [INFO] [stdout] 105 | VerilogIndexID { id: VerilogID::new(id), index: index, formatted_index_id: formatted_index_id } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:839:88 [INFO] [stdout] | [INFO] [stdout] 839 | VerilogAssign { stmt: VerilogStmt::new(line_no), left_net_expr: left_net_expr, right_net_expr: right_net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:105:64 [INFO] [stdout] | [INFO] [stdout] 105 | VerilogIndexID { id: VerilogID::new(id), index: index, formatted_index_id: formatted_index_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatted_index_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:896:55 [INFO] [stdout] | [INFO] [stdout] 896 | VerilogDcl { stmt: VerilogStmt::new(line_no), dcl_type: dcl_type, dcl_name: dcl_name.to_string(), range: range } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | range_from: range_from, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `range_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:896:107 [INFO] [stdout] | [INFO] [stdout] 896 | VerilogDcl { stmt: VerilogStmt::new(line_no), dcl_type: dcl_type, dcl_name: dcl_name.to_string(), range: range } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | range_to: range_to, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `range_to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:938:56 [INFO] [stdout] | [INFO] [stdout] 938 | VerilogDcls { stmt: VerilogStmt::new(line_no), verilog_dcls: verilog_dcls } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_dcls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | formatted_slice_id: formatted_slice_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatted_slice_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:263:26 [INFO] [stdout] | [INFO] [stdout] 263 | VerilogNetExpr { line_no: line_no } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `line_no` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:279:68 [INFO] [stdout] | [INFO] [stdout] 279 | VerilogNetIDExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id: verilog_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:318:72 [INFO] [stdout] | [INFO] [stdout] 318 | VerilogNetConcatExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id_concat: verilog_id_concat } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id_concat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:361:71 [INFO] [stdout] | [INFO] [stdout] 361 | VerilogConstantExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id: verilog_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:400:37 [INFO] [stdout] | [INFO] [stdout] 400 | VerilogPortRefPortConnect { port_id: port_id, net_expr: net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:400:55 [INFO] [stdout] | [INFO] [stdout] 400 | VerilogPortRefPortConnect { port_id: port_id, net_expr: net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:467:23 [INFO] [stdout] | [INFO] [stdout] 467 | VerilogStmt { line_no: line_no } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `line_no` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:495:13 [INFO] [stdout] | [INFO] [stdout] 495 | port_connections: port_connections, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_connections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:998:13 [INFO] [stdout] | [INFO] [stdout] 998 | port_list: port_list, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:999:13 [INFO] [stdout] | [INFO] [stdout] 999 | module_stmts: module_stmts, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_stmts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:839:58 [INFO] [stdout] | [INFO] [stdout] 839 | VerilogAssign { stmt: VerilogStmt::new(line_no), left_net_expr: left_net_expr, right_net_expr: right_net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:839:88 [INFO] [stdout] | [INFO] [stdout] 839 | VerilogAssign { stmt: VerilogStmt::new(line_no), left_net_expr: left_net_expr, right_net_expr: right_net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:896:55 [INFO] [stdout] | [INFO] [stdout] 896 | VerilogDcl { stmt: VerilogStmt::new(line_no), dcl_type: dcl_type, dcl_name: dcl_name.to_string(), range: range } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:896:107 [INFO] [stdout] | [INFO] [stdout] 896 | VerilogDcl { stmt: VerilogStmt::new(line_no), dcl_type: dcl_type, dcl_name: dcl_name.to_string(), range: range } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:938:56 [INFO] [stdout] | [INFO] [stdout] 938 | VerilogDcls { stmt: VerilogStmt::new(line_no), verilog_dcls: verilog_dcls } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_dcls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:998:13 [INFO] [stdout] | [INFO] [stdout] 998 | port_list: port_list, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:999:13 [INFO] [stdout] | [INFO] [stdout] 999 | module_stmts: module_stmts, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_stmts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pest::error` [INFO] [stdout] --> src/verilog_parser/mod.rs:855:9 [INFO] [stdout] | [INFO] [stdout] 855 | use pest::error; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 69 | let raw_pointer = Box::into_raw(rust_verilog_id_pointer); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 70 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 69 ~ [INFO] [stdout] 70 ~ Box::into_raw(rust_verilog_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 112 | let raw_pointer = Box::into_raw(rust_verilog_index_id_pointer); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 113 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 112 ~ [INFO] [stdout] 113 ~ Box::into_raw(rust_verilog_index_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 170 | let raw_pointer = Box::into_raw(rust_verilog_slice_id_pointer); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 171 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 ~ Box::into_raw(rust_verilog_slice_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 202 | let raw_pointer = Box::into_raw(rust_verilog_net_id_expr_pointer); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 203 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 202 ~ [INFO] [stdout] 203 ~ Box::into_raw(rust_verilog_net_id_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:197:22 [INFO] [stdout] | [INFO] [stdout] 197 | let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 197 - let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] 197 + let verilog_id = verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 197 | let verilog_id = &**verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 228 | let raw_pointer = Box::into_raw(rust_verilog_net_concat_expr_pointer); [INFO] [stdout] | ---------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 229 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 228 ~ [INFO] [stdout] 229 ~ Box::into_raw(rust_verilog_net_concat_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 254 | let raw_pointer = Box::into_raw(rust_verilog_constant_expr_pointer); [INFO] [stdout] | -------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 255 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 254 ~ [INFO] [stdout] 255 ~ Box::into_raw(rust_verilog_constant_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:249:22 [INFO] [stdout] | [INFO] [stdout] 249 | let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 249 - let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] 249 + let verilog_id = verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 249 | let verilog_id = &**verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 311 | let raw_pointer = Box::into_raw(rust_verilog_module_pointer); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 312 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 311 ~ [INFO] [stdout] 312 ~ Box::into_raw(rust_verilog_module_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 339 | let raw_pointer = Box::into_raw(rust_verilog_dcl_pointer); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 340 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 339 ~ [INFO] [stdout] 340 ~ Box::into_raw(rust_verilog_dcl_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:359:5 [INFO] [stdout] | [INFO] [stdout] 358 | let raw_pointer = Box::into_raw(rust_verilog_dcls_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 359 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 358 ~ [INFO] [stdout] 359 ~ Box::into_raw(rust_verilog_dcls_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:389:5 [INFO] [stdout] | [INFO] [stdout] 388 | let raw_pointer = Box::into_raw(rust_verilog_inst_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 389 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 388 ~ [INFO] [stdout] 389 ~ Box::into_raw(rust_verilog_inst_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:417:5 [INFO] [stdout] | [INFO] [stdout] 416 | let raw_pointer = Box::into_raw(rust_verilog_assign_pointer); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 417 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 416 ~ [INFO] [stdout] 417 ~ Box::into_raw(rust_verilog_assign_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:409:27 [INFO] [stdout] | [INFO] [stdout] 409 | let c_left_net_expr = &*left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 409 - let c_left_net_expr = &*left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] 409 + let c_left_net_expr = left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 409 | let c_left_net_expr = &**left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:410:28 [INFO] [stdout] | [INFO] [stdout] 410 | let c_right_net_expr = &*right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 410 - let c_right_net_expr = &*right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] 410 + let c_right_net_expr = right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 410 | let c_right_net_expr = &**right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:435:21 [INFO] [stdout] | [INFO] [stdout] 435 | let c_port_id = &*port_id as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 435 - let c_port_id = &*port_id as *const _ as *const c_void; [INFO] [stdout] 435 + let c_port_id = port_id as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 435 | let c_port_id = &**port_id as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:499:9 [INFO] [stdout] | [INFO] [stdout] 498 | let raw_pointer = Box::into_raw(rust_verilog_file_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 499 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 498 ~ [INFO] [stdout] 499 ~ Box::into_raw(rust_verilog_file_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | / impl Default for VerilogID { [INFO] [stdout] 90 | | fn default() -> Self { [INFO] [stdout] 91 | | VerilogID { id: String::new() } [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 53 + #[derive(Default)] [INFO] [stdout] 54 | pub struct VerilogID { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | &self.id.get_base_name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.id.get_base_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 69 | let raw_pointer = Box::into_raw(rust_verilog_id_pointer); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 70 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 69 ~ [INFO] [stdout] 70 ~ Box::into_raw(rust_verilog_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 112 | let raw_pointer = Box::into_raw(rust_verilog_index_id_pointer); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 113 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 112 ~ [INFO] [stdout] 113 ~ Box::into_raw(rust_verilog_index_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | &self.id.get_base_name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.id.get_base_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 170 | let raw_pointer = Box::into_raw(rust_verilog_slice_id_pointer); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 171 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 ~ Box::into_raw(rust_verilog_slice_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:226:33 [INFO] [stdout] | [INFO] [stdout] 226 | fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 202 | let raw_pointer = Box::into_raw(rust_verilog_net_id_expr_pointer); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 203 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 202 ~ [INFO] [stdout] 203 ~ Box::into_raw(rust_verilog_net_id_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:197:22 [INFO] [stdout] | [INFO] [stdout] 197 | let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 197 - let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] 197 + let verilog_id = verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 197 | let verilog_id = &**verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:285:37 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 228 | let raw_pointer = Box::into_raw(rust_verilog_net_concat_expr_pointer); [INFO] [stdout] | ---------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 229 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 228 ~ [INFO] [stdout] 229 ~ Box::into_raw(rust_verilog_net_concat_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 254 | let raw_pointer = Box::into_raw(rust_verilog_constant_expr_pointer); [INFO] [stdout] | -------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 255 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 254 ~ [INFO] [stdout] 255 ~ Box::into_raw(rust_verilog_constant_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:249:22 [INFO] [stdout] | [INFO] [stdout] 249 | let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 249 - let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] 249 + let verilog_id = verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 249 | let verilog_id = &**verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | &self.verilog_id_concat.first().unwrap().get_verilog_id() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.verilog_id_concat.first().unwrap().get_verilog_id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 311 | let raw_pointer = Box::into_raw(rust_verilog_module_pointer); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 312 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 311 ~ [INFO] [stdout] 312 ~ Box::into_raw(rust_verilog_module_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 339 | let raw_pointer = Box::into_raw(rust_verilog_dcl_pointer); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 340 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 339 ~ [INFO] [stdout] 340 ~ Box::into_raw(rust_verilog_dcl_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:367:37 [INFO] [stdout] | [INFO] [stdout] 367 | pub fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:359:5 [INFO] [stdout] | [INFO] [stdout] 358 | let raw_pointer = Box::into_raw(rust_verilog_dcls_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 359 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 358 ~ [INFO] [stdout] 359 ~ Box::into_raw(rust_verilog_dcls_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:403:34 [INFO] [stdout] | [INFO] [stdout] 403 | pub fn get_port_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:389:5 [INFO] [stdout] | [INFO] [stdout] 388 | let raw_pointer = Box::into_raw(rust_verilog_inst_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 389 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 388 ~ [INFO] [stdout] 389 ~ Box::into_raw(rust_verilog_inst_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:417:5 [INFO] [stdout] | [INFO] [stdout] 416 | let raw_pointer = Box::into_raw(rust_verilog_assign_pointer); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 417 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 416 ~ [INFO] [stdout] 417 ~ Box::into_raw(rust_verilog_assign_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:409:27 [INFO] [stdout] | [INFO] [stdout] 409 | let c_left_net_expr = &*left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 409 - let c_left_net_expr = &*left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] 409 + let c_left_net_expr = left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 409 | let c_left_net_expr = &**left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:481:23 [INFO] [stdout] | [INFO] [stdout] 481 | port_connections: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:410:28 [INFO] [stdout] | [INFO] [stdout] 410 | let c_right_net_expr = &*right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 410 - let c_right_net_expr = &*right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] 410 + let c_right_net_expr = right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 410 | let c_right_net_expr = &**right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:435:21 [INFO] [stdout] | [INFO] [stdout] 435 | let c_port_id = &*port_id as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 435 - let c_port_id = &*port_id as *const _ as *const c_void; [INFO] [stdout] 435 + let c_port_id = port_id as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 435 | let c_port_id = &**port_id as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:499:9 [INFO] [stdout] | [INFO] [stdout] 498 | let raw_pointer = Box::into_raw(rust_verilog_file_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 499 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 498 ~ [INFO] [stdout] 499 ~ Box::into_raw(rust_verilog_file_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:489:27 [INFO] [stdout] | [INFO] [stdout] 489 | port_connections: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:515:44 [INFO] [stdout] | [INFO] [stdout] 515 | pub fn get_port_connections(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:563:20 [INFO] [stdout] | [INFO] [stdout] 563 | if !stmt.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `stmt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stmt` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:567:24 [INFO] [stdout] | [INFO] [stdout] 566 | if stmt.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = stmt` [INFO] [stdout] 567 | if stmt.unwrap().is_verilog_dcls_stmt() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stmt` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:568:49 [INFO] [stdout] | [INFO] [stdout] 566 | if stmt.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = stmt` [INFO] [stdout] 567 | if stmt.unwrap().is_verilog_dcls_stmt() { [INFO] [stdout] 568 | let verilog_dcls_stmt = stmt.unwrap().as_any().downcast_ref::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | / impl Default for VerilogID { [INFO] [stdout] 90 | | fn default() -> Self { [INFO] [stdout] 91 | | VerilogID { id: String::new() } [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 53 + #[derive(Default)] [INFO] [stdout] 54 | pub struct VerilogID { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | &self.id.get_base_name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.id.get_base_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:625:40 [INFO] [stdout] | [INFO] [stdout] 625 | fn get_dcl_range(&self, dcls_stmt: &Box, dcl_name: &str) -> Option<(i32, i32)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:638:9 [INFO] [stdout] | [INFO] [stdout] 638 | return range; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 638 - return range; [INFO] [stdout] 638 + range [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:808:9 [INFO] [stdout] | [INFO] [stdout] 808 | return port_connect_net_option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 808 - return port_connect_net_option; [INFO] [stdout] 808 + port_connect_net_option [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | &self.id.get_base_name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.id.get_base_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:226:33 [INFO] [stdout] | [INFO] [stdout] 226 | fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:285:37 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | &self.verilog_id_concat.first().unwrap().get_verilog_id() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.verilog_id_concat.first().unwrap().get_verilog_id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:367:37 [INFO] [stdout] | [INFO] [stdout] 367 | pub fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:403:34 [INFO] [stdout] | [INFO] [stdout] 403 | pub fn get_port_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:846:40 [INFO] [stdout] | [INFO] [stdout] 846 | pub fn get_left_net_expr(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseNetExpr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:850:41 [INFO] [stdout] | [INFO] [stdout] 850 | pub fn get_right_net_expr(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseNetExpr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:481:23 [INFO] [stdout] | [INFO] [stdout] 481 | port_connections: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:489:27 [INFO] [stdout] | [INFO] [stdout] 489 | port_connections: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:515:44 [INFO] [stdout] | [INFO] [stdout] 515 | pub fn get_port_connections(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:933:19 [INFO] [stdout] | [INFO] [stdout] 933 | verilog_dcls: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:563:20 [INFO] [stdout] | [INFO] [stdout] 563 | if !stmt.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `stmt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:937:46 [INFO] [stdout] | [INFO] [stdout] 937 | pub fn new(line_no: usize, verilog_dcls: Vec>) -> VerilogDcls { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stmt` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:567:24 [INFO] [stdout] | [INFO] [stdout] 566 | if stmt.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = stmt` [INFO] [stdout] 567 | if stmt.unwrap().is_verilog_dcls_stmt() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stmt` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:568:49 [INFO] [stdout] | [INFO] [stdout] 566 | if stmt.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = stmt` [INFO] [stdout] 567 | if stmt.unwrap().is_verilog_dcls_stmt() { [INFO] [stdout] 568 | let verilog_dcls_stmt = stmt.unwrap().as_any().downcast_ref::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:944:40 [INFO] [stdout] | [INFO] [stdout] 944 | pub fn get_verilog_dcls(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `K` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:968:1 [INFO] [stdout] | [INFO] [stdout] 968 | / pub enum PortDclType { [INFO] [stdout] 969 | | KInput = 0, [INFO] [stdout] 970 | | KInputWire = 1, [INFO] [stdout] 971 | | KInout = 2, [INFO] [stdout] ... | [INFO] [stdout] 976 | | KOutputReg = 7, [INFO] [stdout] 977 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1016:9 [INFO] [stdout] | [INFO] [stdout] 1016 | self.module_stmts.iter().map(|module_stmt| module_stmt.clone()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.module_stmts.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1018:44 [INFO] [stdout] | [INFO] [stdout] 1018 | pub fn erase_stmt(&mut self, the_stmt: &Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1035:56 [INFO] [stdout] | [INFO] [stdout] 1035 | pub fn find_dcls_stmt(&self, name: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:625:40 [INFO] [stdout] | [INFO] [stdout] 625 | fn get_dcl_range(&self, dcls_stmt: &Box, dcl_name: &str) -> Option<(i32, i32)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:638:9 [INFO] [stdout] | [INFO] [stdout] 638 | return range; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 638 - return range; [INFO] [stdout] 638 + range [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:808:9 [INFO] [stdout] | [INFO] [stdout] 808 | return port_connect_net_option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 808 - return port_connect_net_option; [INFO] [stdout] 808 + port_connect_net_option [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:846:40 [INFO] [stdout] | [INFO] [stdout] 846 | pub fn get_left_net_expr(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseNetExpr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:850:41 [INFO] [stdout] | [INFO] [stdout] 850 | pub fn get_right_net_expr(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseNetExpr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:933:19 [INFO] [stdout] | [INFO] [stdout] 933 | verilog_dcls: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:937:46 [INFO] [stdout] | [INFO] [stdout] 937 | pub fn new(line_no: usize, verilog_dcls: Vec>) -> VerilogDcls { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:944:40 [INFO] [stdout] | [INFO] [stdout] 944 | pub fn get_verilog_dcls(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `K` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:968:1 [INFO] [stdout] | [INFO] [stdout] 968 | / pub enum PortDclType { [INFO] [stdout] 969 | | KInput = 0, [INFO] [stdout] 970 | | KInputWire = 1, [INFO] [stdout] 971 | | KInout = 2, [INFO] [stdout] ... | [INFO] [stdout] 976 | | KOutputReg = 7, [INFO] [stdout] 977 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1016:9 [INFO] [stdout] | [INFO] [stdout] 1016 | self.module_stmts.iter().map(|module_stmt| module_stmt.clone()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.module_stmts.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1018:44 [INFO] [stdout] | [INFO] [stdout] 1018 | pub fn erase_stmt(&mut self, the_stmt: &Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1035:56 [INFO] [stdout] | [INFO] [stdout] 1035 | pub fn find_dcls_stmt(&self, name: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:18:43 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair) -> Result<&str, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 34 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:50:6 [INFO] [stdout] | [INFO] [stdout] 50 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 55 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 56 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 60 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 61 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 65 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 66 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 70 | let verilog_dcls = process_inner_wire_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 71 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 70 ~ [INFO] [stdout] 71 ~ process_inner_wire_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:83:6 [INFO] [stdout] | [INFO] [stdout] 83 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:100:79 [INFO] [stdout] | [INFO] [stdout] 100 | let verilog_dcl = verilog_data::VerilogDcl::new(port_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:113:79 [INFO] [stdout] | [INFO] [stdout] 113 | let verilog_dcl = verilog_data::VerilogDcl::new(port_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:129:6 [INFO] [stdout] | [INFO] [stdout] 129 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:145:79 [INFO] [stdout] | [INFO] [stdout] 145 | let verilog_dcl = verilog_data::VerilogDcl::new(wire_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:158:79 [INFO] [stdout] | [INFO] [stdout] 158 | let verilog_dcl = verilog_data::VerilogDcl::new(wire_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:173:6 [INFO] [stdout] | [INFO] [stdout] 173 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 177 | let verilog_assign = process_assign_declaration(pair); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 178 | verilog_assign [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 177 ~ [INFO] [stdout] 178 ~ process_assign_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 181 | let verilog_inst = process_inst_declaration(pair); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 182 | verilog_inst [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 181 ~ [INFO] [stdout] 182 ~ process_inst_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:193:6 [INFO] [stdout] | [INFO] [stdout] 193 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:18:43 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair) -> Result<&str, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 34 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:50:6 [INFO] [stdout] | [INFO] [stdout] 50 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 55 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 56 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 60 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 61 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 65 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 66 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 70 | let verilog_dcls = process_inner_wire_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 71 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 70 ~ [INFO] [stdout] 71 ~ process_inner_wire_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:83:6 [INFO] [stdout] | [INFO] [stdout] 83 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:100:79 [INFO] [stdout] | [INFO] [stdout] 100 | let verilog_dcl = verilog_data::VerilogDcl::new(port_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:276:6 [INFO] [stdout] | [INFO] [stdout] 276 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:330:6 [INFO] [stdout] | [INFO] [stdout] 330 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:113:79 [INFO] [stdout] | [INFO] [stdout] 113 | let verilog_dcl = verilog_data::VerilogDcl::new(port_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:129:6 [INFO] [stdout] | [INFO] [stdout] 129 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:371:6 [INFO] [stdout] | [INFO] [stdout] 371 | ) -> Result>, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/mod.rs:371:13 [INFO] [stdout] | [INFO] [stdout] 371 | ) -> Result>, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:145:79 [INFO] [stdout] | [INFO] [stdout] 145 | let verilog_dcl = verilog_data::VerilogDcl::new(wire_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:392:6 [INFO] [stdout] | [INFO] [stdout] 392 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:158:79 [INFO] [stdout] | [INFO] [stdout] 158 | let verilog_dcl = verilog_data::VerilogDcl::new(wire_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:417:6 [INFO] [stdout] | [INFO] [stdout] 417 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:173:6 [INFO] [stdout] | [INFO] [stdout] 173 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:422:13 [INFO] [stdout] | [INFO] [stdout] 421 | let verilog_inst = process_inner_inst_declaration(pair); [INFO] [stdout] | -------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 422 | verilog_inst [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 421 ~ [INFO] [stdout] 422 ~ process_inner_inst_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 177 | let verilog_assign = process_assign_declaration(pair); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 178 | verilog_assign [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 177 ~ [INFO] [stdout] 178 ~ process_assign_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 181 | let verilog_inst = process_inst_declaration(pair); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 182 | verilog_inst [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 181 ~ [INFO] [stdout] 182 ~ process_inst_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/mod.rs:432:15 [INFO] [stdout] | [INFO] [stdout] 432 | dcl_stmt: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&verilog_data::VerilogDcl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:193:6 [INFO] [stdout] | [INFO] [stdout] 193 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/verilog_parser/mod.rs:444:13 [INFO] [stdout] | [INFO] [stdout] 444 | / let mut verilog_dcl_vec: Vec> = Vec::new(); [INFO] [stdout] 445 | | verilog_dcl_vec.push(Box::new(new_dcl_stmt)); [INFO] [stdout] | |_________________________________________________________^ help: consider using the `vec![]` macro: `let verilog_dcl_vec: Vec> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:502:36 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 502 | let is_first_greater = range.unwrap().0 > range.unwrap().1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:502:55 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 502 | let is_first_greater = range.unwrap().0 > range.unwrap().1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:503:29 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 503 | let mut index = range.unwrap().0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:504:48 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 504 | while is_first_greater && index >= range.unwrap().1 || !is_first_greater && index <= range.unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:504:98 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 504 | while is_first_greater && index >= range.unwrap().1 || !is_first_greater && index <= range.unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/mod.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | return port_connect_net; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 535 - return port_connect_net; [INFO] [stdout] 535 + port_connect_net [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:276:6 [INFO] [stdout] | [INFO] [stdout] 276 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:330:6 [INFO] [stdout] | [INFO] [stdout] 330 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port_connect_net` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/mod.rs:549:32 [INFO] [stdout] | [INFO] [stdout] 548 | if port_connect_net.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = port_connect_net` [INFO] [stdout] 549 | new_one_net_expr = port_connect_net.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:371:6 [INFO] [stdout] | [INFO] [stdout] 371 | ) -> Result>, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/mod.rs:371:13 [INFO] [stdout] | [INFO] [stdout] 371 | ) -> Result>, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:392:6 [INFO] [stdout] | [INFO] [stdout] 392 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:417:6 [INFO] [stdout] | [INFO] [stdout] 417 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:422:13 [INFO] [stdout] | [INFO] [stdout] 421 | let verilog_inst = process_inner_inst_declaration(pair); [INFO] [stdout] | -------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 422 | verilog_inst [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 421 ~ [INFO] [stdout] 422 ~ process_inner_inst_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/mod.rs:432:15 [INFO] [stdout] | [INFO] [stdout] 432 | dcl_stmt: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&verilog_data::VerilogDcl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/verilog_parser/mod.rs:444:13 [INFO] [stdout] | [INFO] [stdout] 444 | / let mut verilog_dcl_vec: Vec> = Vec::new(); [INFO] [stdout] 445 | | verilog_dcl_vec.push(Box::new(new_dcl_stmt)); [INFO] [stdout] | |_________________________________________________________^ help: consider using the `vec![]` macro: `let verilog_dcl_vec: Vec> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:502:36 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 502 | let is_first_greater = range.unwrap().0 > range.unwrap().1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:502:55 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 502 | let is_first_greater = range.unwrap().0 > range.unwrap().1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:503:29 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 503 | let mut index = range.unwrap().0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:504:48 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 504 | while is_first_greater && index >= range.unwrap().1 || !is_first_greater && index <= range.unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:504:98 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 504 | while is_first_greater && index >= range.unwrap().1 || !is_first_greater && index <= range.unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/mod.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | return port_connect_net; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 535 - return port_connect_net; [INFO] [stdout] 535 + port_connect_net [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port_connect_net` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/mod.rs:549:32 [INFO] [stdout] | [INFO] [stdout] 548 | if port_connect_net.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = port_connect_net` [INFO] [stdout] 549 | new_one_net_expr = port_connect_net.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/verilog_parser/mod.rs:887:17 [INFO] [stdout] | [INFO] [stdout] 887 | assert!(!parse_result_clone.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_result_clone.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/verilog_parser/mod.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair) -> Result<&str, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair<'_, Rule>) -> Result<&str, pest::error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/verilog_parser/mod.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair) -> Result<&str, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair<'_, Rule>) -> Result<&str, pest::error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:105:50 [INFO] [stdout] | [INFO] [stdout] 105 | VerilogIndexID { id: VerilogID::new(id), index: index, formatted_index_id: formatted_index_id } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:105:64 [INFO] [stdout] | [INFO] [stdout] 105 | VerilogIndexID { id: VerilogID::new(id), index: index, formatted_index_id: formatted_index_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatted_index_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | range_from: range_from, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `range_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | range_to: range_to, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `range_to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | formatted_slice_id: formatted_slice_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatted_slice_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:263:26 [INFO] [stdout] | [INFO] [stdout] 263 | VerilogNetExpr { line_no: line_no } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `line_no` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:279:68 [INFO] [stdout] | [INFO] [stdout] 279 | VerilogNetIDExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id: verilog_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:318:72 [INFO] [stdout] | [INFO] [stdout] 318 | VerilogNetConcatExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id_concat: verilog_id_concat } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id_concat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:361:71 [INFO] [stdout] | [INFO] [stdout] 361 | VerilogConstantExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id: verilog_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:400:37 [INFO] [stdout] | [INFO] [stdout] 400 | VerilogPortRefPortConnect { port_id: port_id, net_expr: net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:400:55 [INFO] [stdout] | [INFO] [stdout] 400 | VerilogPortRefPortConnect { port_id: port_id, net_expr: net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:467:23 [INFO] [stdout] | [INFO] [stdout] 467 | VerilogStmt { line_no: line_no } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `line_no` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:495:13 [INFO] [stdout] | [INFO] [stdout] 495 | port_connections: port_connections, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_connections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:839:58 [INFO] [stdout] | [INFO] [stdout] 839 | VerilogAssign { stmt: VerilogStmt::new(line_no), left_net_expr: left_net_expr, right_net_expr: right_net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:839:88 [INFO] [stdout] | [INFO] [stdout] 839 | VerilogAssign { stmt: VerilogStmt::new(line_no), left_net_expr: left_net_expr, right_net_expr: right_net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:896:55 [INFO] [stdout] | [INFO] [stdout] 896 | VerilogDcl { stmt: VerilogStmt::new(line_no), dcl_type: dcl_type, dcl_name: dcl_name.to_string(), range: range } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:896:107 [INFO] [stdout] | [INFO] [stdout] 896 | VerilogDcl { stmt: VerilogStmt::new(line_no), dcl_type: dcl_type, dcl_name: dcl_name.to_string(), range: range } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:938:56 [INFO] [stdout] | [INFO] [stdout] 938 | VerilogDcls { stmt: VerilogStmt::new(line_no), verilog_dcls: verilog_dcls } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_dcls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:998:13 [INFO] [stdout] | [INFO] [stdout] 998 | port_list: port_list, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:999:13 [INFO] [stdout] | [INFO] [stdout] 999 | module_stmts: module_stmts, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_stmts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:105:50 [INFO] [stdout] | [INFO] [stdout] 105 | VerilogIndexID { id: VerilogID::new(id), index: index, formatted_index_id: formatted_index_id } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:105:64 [INFO] [stdout] | [INFO] [stdout] 105 | VerilogIndexID { id: VerilogID::new(id), index: index, formatted_index_id: formatted_index_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatted_index_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | range_from: range_from, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `range_from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pest::error` [INFO] [stdout] --> src/verilog_parser/mod.rs:855:9 [INFO] [stdout] | [INFO] [stdout] 855 | use pest::error; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | range_to: range_to, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `range_to` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | formatted_slice_id: formatted_slice_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `formatted_slice_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:263:26 [INFO] [stdout] | [INFO] [stdout] 263 | VerilogNetExpr { line_no: line_no } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `line_no` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:279:68 [INFO] [stdout] | [INFO] [stdout] 279 | VerilogNetIDExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id: verilog_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:318:72 [INFO] [stdout] | [INFO] [stdout] 318 | VerilogNetConcatExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id_concat: verilog_id_concat } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id_concat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:361:71 [INFO] [stdout] | [INFO] [stdout] 361 | VerilogConstantExpr { net_expr: VerilogNetExpr::new(line_no), verilog_id: verilog_id } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:400:37 [INFO] [stdout] | [INFO] [stdout] 400 | VerilogPortRefPortConnect { port_id: port_id, net_expr: net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:400:55 [INFO] [stdout] | [INFO] [stdout] 400 | VerilogPortRefPortConnect { port_id: port_id, net_expr: net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:467:23 [INFO] [stdout] | [INFO] [stdout] 467 | VerilogStmt { line_no: line_no } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `line_no` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:495:13 [INFO] [stdout] | [INFO] [stdout] 495 | port_connections: port_connections, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_connections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:839:58 [INFO] [stdout] | [INFO] [stdout] 839 | VerilogAssign { stmt: VerilogStmt::new(line_no), left_net_expr: left_net_expr, right_net_expr: right_net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `left_net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:839:88 [INFO] [stdout] | [INFO] [stdout] 839 | VerilogAssign { stmt: VerilogStmt::new(line_no), left_net_expr: left_net_expr, right_net_expr: right_net_expr } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `right_net_expr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:896:55 [INFO] [stdout] | [INFO] [stdout] 896 | VerilogDcl { stmt: VerilogStmt::new(line_no), dcl_type: dcl_type, dcl_name: dcl_name.to_string(), range: range } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:896:107 [INFO] [stdout] | [INFO] [stdout] 896 | VerilogDcl { stmt: VerilogStmt::new(line_no), dcl_type: dcl_type, dcl_name: dcl_name.to_string(), range: range } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:938:56 [INFO] [stdout] | [INFO] [stdout] 938 | VerilogDcls { stmt: VerilogStmt::new(line_no), verilog_dcls: verilog_dcls } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `verilog_dcls` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:998:13 [INFO] [stdout] | [INFO] [stdout] 998 | port_list: port_list, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `port_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:999:13 [INFO] [stdout] | [INFO] [stdout] 999 | module_stmts: module_stmts, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_stmts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 69 | let raw_pointer = Box::into_raw(rust_verilog_id_pointer); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 70 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 69 ~ [INFO] [stdout] 70 ~ Box::into_raw(rust_verilog_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 112 | let raw_pointer = Box::into_raw(rust_verilog_index_id_pointer); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 113 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 112 ~ [INFO] [stdout] 113 ~ Box::into_raw(rust_verilog_index_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 170 | let raw_pointer = Box::into_raw(rust_verilog_slice_id_pointer); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 171 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 ~ Box::into_raw(rust_verilog_slice_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 202 | let raw_pointer = Box::into_raw(rust_verilog_net_id_expr_pointer); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 203 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 202 ~ [INFO] [stdout] 203 ~ Box::into_raw(rust_verilog_net_id_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:197:22 [INFO] [stdout] | [INFO] [stdout] 197 | let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 197 - let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] 197 + let verilog_id = verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 197 | let verilog_id = &**verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 228 | let raw_pointer = Box::into_raw(rust_verilog_net_concat_expr_pointer); [INFO] [stdout] | ---------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 229 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 228 ~ [INFO] [stdout] 229 ~ Box::into_raw(rust_verilog_net_concat_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 254 | let raw_pointer = Box::into_raw(rust_verilog_constant_expr_pointer); [INFO] [stdout] | -------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 255 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 254 ~ [INFO] [stdout] 255 ~ Box::into_raw(rust_verilog_constant_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:249:22 [INFO] [stdout] | [INFO] [stdout] 249 | let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 249 - let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] 249 + let verilog_id = verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 249 | let verilog_id = &**verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 311 | let raw_pointer = Box::into_raw(rust_verilog_module_pointer); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 312 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 311 ~ [INFO] [stdout] 312 ~ Box::into_raw(rust_verilog_module_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 339 | let raw_pointer = Box::into_raw(rust_verilog_dcl_pointer); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 340 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 339 ~ [INFO] [stdout] 340 ~ Box::into_raw(rust_verilog_dcl_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:359:5 [INFO] [stdout] | [INFO] [stdout] 358 | let raw_pointer = Box::into_raw(rust_verilog_dcls_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 359 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 358 ~ [INFO] [stdout] 359 ~ Box::into_raw(rust_verilog_dcls_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:389:5 [INFO] [stdout] | [INFO] [stdout] 388 | let raw_pointer = Box::into_raw(rust_verilog_inst_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 389 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 388 ~ [INFO] [stdout] 389 ~ Box::into_raw(rust_verilog_inst_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:417:5 [INFO] [stdout] | [INFO] [stdout] 416 | let raw_pointer = Box::into_raw(rust_verilog_assign_pointer); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 417 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 416 ~ [INFO] [stdout] 417 ~ Box::into_raw(rust_verilog_assign_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:409:27 [INFO] [stdout] | [INFO] [stdout] 409 | let c_left_net_expr = &*left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 409 - let c_left_net_expr = &*left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] 409 + let c_left_net_expr = left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 409 | let c_left_net_expr = &**left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:410:28 [INFO] [stdout] | [INFO] [stdout] 410 | let c_right_net_expr = &*right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 410 - let c_right_net_expr = &*right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] 410 + let c_right_net_expr = right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 410 | let c_right_net_expr = &**right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:435:21 [INFO] [stdout] | [INFO] [stdout] 435 | let c_port_id = &*port_id as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 435 - let c_port_id = &*port_id as *const _ as *const c_void; [INFO] [stdout] 435 + let c_port_id = port_id as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 435 | let c_port_id = &**port_id as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:499:9 [INFO] [stdout] | [INFO] [stdout] 498 | let raw_pointer = Box::into_raw(rust_verilog_file_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 499 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 498 ~ [INFO] [stdout] 499 ~ Box::into_raw(rust_verilog_file_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | / impl Default for VerilogID { [INFO] [stdout] 90 | | fn default() -> Self { [INFO] [stdout] 91 | | VerilogID { id: String::new() } [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 53 + #[derive(Default)] [INFO] [stdout] 54 | pub struct VerilogID { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | &self.id.get_base_name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.id.get_base_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | &self.id.get_base_name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.id.get_base_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:226:33 [INFO] [stdout] | [INFO] [stdout] 226 | fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:285:37 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | &self.verilog_id_concat.first().unwrap().get_verilog_id() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.verilog_id_concat.first().unwrap().get_verilog_id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:367:37 [INFO] [stdout] | [INFO] [stdout] 367 | pub fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:403:34 [INFO] [stdout] | [INFO] [stdout] 403 | pub fn get_port_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:481:23 [INFO] [stdout] | [INFO] [stdout] 481 | port_connections: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 69 | let raw_pointer = Box::into_raw(rust_verilog_id_pointer); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 70 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 69 ~ [INFO] [stdout] 70 ~ Box::into_raw(rust_verilog_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:113:5 [INFO] [stdout] | [INFO] [stdout] 112 | let raw_pointer = Box::into_raw(rust_verilog_index_id_pointer); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 113 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 112 ~ [INFO] [stdout] 113 ~ Box::into_raw(rust_verilog_index_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:489:27 [INFO] [stdout] | [INFO] [stdout] 489 | port_connections: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:515:44 [INFO] [stdout] | [INFO] [stdout] 515 | pub fn get_port_connections(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:563:20 [INFO] [stdout] | [INFO] [stdout] 563 | if !stmt.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `stmt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stmt` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:567:24 [INFO] [stdout] | [INFO] [stdout] 566 | if stmt.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = stmt` [INFO] [stdout] 567 | if stmt.unwrap().is_verilog_dcls_stmt() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stmt` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:568:49 [INFO] [stdout] | [INFO] [stdout] 566 | if stmt.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = stmt` [INFO] [stdout] 567 | if stmt.unwrap().is_verilog_dcls_stmt() { [INFO] [stdout] 568 | let verilog_dcls_stmt = stmt.unwrap().as_any().downcast_ref::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:171:5 [INFO] [stdout] | [INFO] [stdout] 170 | let raw_pointer = Box::into_raw(rust_verilog_slice_id_pointer); [INFO] [stdout] | --------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 171 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 170 ~ [INFO] [stdout] 171 ~ Box::into_raw(rust_verilog_slice_id_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 202 | let raw_pointer = Box::into_raw(rust_verilog_net_id_expr_pointer); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 203 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 202 ~ [INFO] [stdout] 203 ~ Box::into_raw(rust_verilog_net_id_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:197:22 [INFO] [stdout] | [INFO] [stdout] 197 | let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 197 - let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] 197 + let verilog_id = verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 197 | let verilog_id = &**verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 228 | let raw_pointer = Box::into_raw(rust_verilog_net_concat_expr_pointer); [INFO] [stdout] | ---------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 229 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 228 ~ [INFO] [stdout] 229 ~ Box::into_raw(rust_verilog_net_concat_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:625:40 [INFO] [stdout] | [INFO] [stdout] 625 | fn get_dcl_range(&self, dcls_stmt: &Box, dcl_name: &str) -> Option<(i32, i32)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:255:5 [INFO] [stdout] | [INFO] [stdout] 254 | let raw_pointer = Box::into_raw(rust_verilog_constant_expr_pointer); [INFO] [stdout] | -------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 255 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 254 ~ [INFO] [stdout] 255 ~ Box::into_raw(rust_verilog_constant_expr_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:638:9 [INFO] [stdout] | [INFO] [stdout] 638 | return range; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 638 - return range; [INFO] [stdout] 638 + range [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:249:22 [INFO] [stdout] | [INFO] [stdout] 249 | let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 249 - let verilog_id = &*verilog_id_box as *const _ as *const c_void; [INFO] [stdout] 249 + let verilog_id = verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 249 | let verilog_id = &**verilog_id_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:808:9 [INFO] [stdout] | [INFO] [stdout] 808 | return port_connect_net_option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 808 - return port_connect_net_option; [INFO] [stdout] 808 + port_connect_net_option [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 311 | let raw_pointer = Box::into_raw(rust_verilog_module_pointer); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 312 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 311 ~ [INFO] [stdout] 312 ~ Box::into_raw(rust_verilog_module_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 339 | let raw_pointer = Box::into_raw(rust_verilog_dcl_pointer); [INFO] [stdout] | ---------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 340 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 339 ~ [INFO] [stdout] 340 ~ Box::into_raw(rust_verilog_dcl_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:359:5 [INFO] [stdout] | [INFO] [stdout] 358 | let raw_pointer = Box::into_raw(rust_verilog_dcls_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 359 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 358 ~ [INFO] [stdout] 359 ~ Box::into_raw(rust_verilog_dcls_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:389:5 [INFO] [stdout] | [INFO] [stdout] 388 | let raw_pointer = Box::into_raw(rust_verilog_inst_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 389 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 388 ~ [INFO] [stdout] 389 ~ Box::into_raw(rust_verilog_inst_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:417:5 [INFO] [stdout] | [INFO] [stdout] 416 | let raw_pointer = Box::into_raw(rust_verilog_assign_pointer); [INFO] [stdout] | ------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 417 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 416 ~ [INFO] [stdout] 417 ~ Box::into_raw(rust_verilog_assign_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:409:27 [INFO] [stdout] | [INFO] [stdout] 409 | let c_left_net_expr = &*left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 409 - let c_left_net_expr = &*left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] 409 + let c_left_net_expr = left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 409 | let c_left_net_expr = &**left_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:410:28 [INFO] [stdout] | [INFO] [stdout] 410 | let c_right_net_expr = &*right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 410 - let c_right_net_expr = &*right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] 410 + let c_right_net_expr = right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 410 | let c_right_net_expr = &**right_net_expr_box as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:435:21 [INFO] [stdout] | [INFO] [stdout] 435 | let c_port_id = &*port_id as *const _ as *const c_void; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 435 - let c_port_id = &*port_id as *const _ as *const c_void; [INFO] [stdout] 435 + let c_port_id = port_id as *const _ as *const c_void; [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 435 | let c_port_id = &**port_id as *const _ as *const c_void; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:846:40 [INFO] [stdout] | [INFO] [stdout] 846 | pub fn get_left_net_expr(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseNetExpr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:850:41 [INFO] [stdout] | [INFO] [stdout] 850 | pub fn get_right_net_expr(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseNetExpr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/verilog_c_api.rs:499:9 [INFO] [stdout] | [INFO] [stdout] 498 | let raw_pointer = Box::into_raw(rust_verilog_file_pointer); [INFO] [stdout] | ----------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 499 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 498 ~ [INFO] [stdout] 499 ~ Box::into_raw(rust_verilog_file_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:933:19 [INFO] [stdout] | [INFO] [stdout] 933 | verilog_dcls: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:937:46 [INFO] [stdout] | [INFO] [stdout] 937 | pub fn new(line_no: usize, verilog_dcls: Vec>) -> VerilogDcls { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:944:40 [INFO] [stdout] | [INFO] [stdout] 944 | pub fn get_verilog_dcls(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `K` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:968:1 [INFO] [stdout] | [INFO] [stdout] 968 | / pub enum PortDclType { [INFO] [stdout] 969 | | KInput = 0, [INFO] [stdout] 970 | | KInputWire = 1, [INFO] [stdout] 971 | | KInout = 2, [INFO] [stdout] ... | [INFO] [stdout] 976 | | KOutputReg = 7, [INFO] [stdout] 977 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1016:9 [INFO] [stdout] | [INFO] [stdout] 1016 | self.module_stmts.iter().map(|module_stmt| module_stmt.clone()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.module_stmts.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1018:44 [INFO] [stdout] | [INFO] [stdout] 1018 | pub fn erase_stmt(&mut self, the_stmt: &Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:89:1 [INFO] [stdout] | [INFO] [stdout] 89 | / impl Default for VerilogID { [INFO] [stdout] 90 | | fn default() -> Self { [INFO] [stdout] 91 | | VerilogID { id: String::new() } [INFO] [stdout] 92 | | } [INFO] [stdout] 93 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 53 + #[derive(Default)] [INFO] [stdout] 54 | pub struct VerilogID { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1035:56 [INFO] [stdout] | [INFO] [stdout] 1035 | pub fn find_dcls_stmt(&self, name: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | &self.id.get_base_name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.id.get_base_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 199 | &self.id.get_base_name() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.id.get_base_name()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:226:33 [INFO] [stdout] | [INFO] [stdout] 226 | fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] = note: `#[warn(clippy::borrowed_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:285:37 [INFO] [stdout] | [INFO] [stdout] 285 | pub fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:340:9 [INFO] [stdout] | [INFO] [stdout] 340 | &self.verilog_id_concat.first().unwrap().get_verilog_id() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.verilog_id_concat.first().unwrap().get_verilog_id()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:367:37 [INFO] [stdout] | [INFO] [stdout] 367 | pub fn get_verilog_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:403:34 [INFO] [stdout] | [INFO] [stdout] 403 | pub fn get_port_id(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseID` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:481:23 [INFO] [stdout] | [INFO] [stdout] 481 | port_connections: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:489:27 [INFO] [stdout] | [INFO] [stdout] 489 | port_connections: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:515:44 [INFO] [stdout] | [INFO] [stdout] 515 | pub fn get_port_connections(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:563:20 [INFO] [stdout] | [INFO] [stdout] 563 | if !stmt.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `stmt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stmt` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:567:24 [INFO] [stdout] | [INFO] [stdout] 566 | if stmt.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = stmt` [INFO] [stdout] 567 | if stmt.unwrap().is_verilog_dcls_stmt() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `stmt` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:568:49 [INFO] [stdout] | [INFO] [stdout] 566 | if stmt.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = stmt` [INFO] [stdout] 567 | if stmt.unwrap().is_verilog_dcls_stmt() { [INFO] [stdout] 568 | let verilog_dcls_stmt = stmt.unwrap().as_any().downcast_ref::().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:625:40 [INFO] [stdout] | [INFO] [stdout] 625 | fn get_dcl_range(&self, dcls_stmt: &Box, dcl_name: &str) -> Option<(i32, i32)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:638:9 [INFO] [stdout] | [INFO] [stdout] 638 | return range; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 638 - return range; [INFO] [stdout] 638 + range [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:808:9 [INFO] [stdout] | [INFO] [stdout] 808 | return port_connect_net_option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 808 - return port_connect_net_option; [INFO] [stdout] 808 + port_connect_net_option [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:846:40 [INFO] [stdout] | [INFO] [stdout] 846 | pub fn get_left_net_expr(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseNetExpr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:850:41 [INFO] [stdout] | [INFO] [stdout] 850 | pub fn get_right_net_expr(&self) -> &Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseNetExpr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:18:43 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair) -> Result<&str, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 34 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:50:6 [INFO] [stdout] | [INFO] [stdout] 50 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 55 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 56 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 60 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 61 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 65 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 66 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 70 | let verilog_dcls = process_inner_wire_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 71 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 70 ~ [INFO] [stdout] 71 ~ process_inner_wire_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:83:6 [INFO] [stdout] | [INFO] [stdout] 83 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:100:79 [INFO] [stdout] | [INFO] [stdout] 100 | let verilog_dcl = verilog_data::VerilogDcl::new(port_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:933:19 [INFO] [stdout] | [INFO] [stdout] 933 | verilog_dcls: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:937:46 [INFO] [stdout] | [INFO] [stdout] 937 | pub fn new(line_no: usize, verilog_dcls: Vec>) -> VerilogDcls { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:944:40 [INFO] [stdout] | [INFO] [stdout] 944 | pub fn get_verilog_dcls(&self) -> &Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:113:79 [INFO] [stdout] | [INFO] [stdout] 113 | let verilog_dcl = verilog_data::VerilogDcl::new(port_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `K` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:968:1 [INFO] [stdout] | [INFO] [stdout] 968 | / pub enum PortDclType { [INFO] [stdout] 969 | | KInput = 0, [INFO] [stdout] 970 | | KInputWire = 1, [INFO] [stdout] 971 | | KInout = 2, [INFO] [stdout] ... | [INFO] [stdout] 976 | | KOutputReg = 7, [INFO] [stdout] 977 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:129:6 [INFO] [stdout] | [INFO] [stdout] 129 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:145:79 [INFO] [stdout] | [INFO] [stdout] 145 | let verilog_dcl = verilog_data::VerilogDcl::new(wire_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1016:9 [INFO] [stdout] | [INFO] [stdout] 1016 | self.module_stmts.iter().map(|module_stmt| module_stmt.clone()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.module_stmts.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1018:44 [INFO] [stdout] | [INFO] [stdout] 1018 | pub fn erase_stmt(&mut self, the_stmt: &Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:158:79 [INFO] [stdout] | [INFO] [stdout] 158 | let verilog_dcl = verilog_data::VerilogDcl::new(wire_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/verilog_data.rs:1035:56 [INFO] [stdout] | [INFO] [stdout] 1035 | pub fn find_dcls_stmt(&self, name: &str) -> Option<&Box> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&dyn VerilogVirtualBaseStmt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:173:6 [INFO] [stdout] | [INFO] [stdout] 173 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 177 | let verilog_assign = process_assign_declaration(pair); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 178 | verilog_assign [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 177 ~ [INFO] [stdout] 178 ~ process_assign_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 181 | let verilog_inst = process_inst_declaration(pair); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 182 | verilog_inst [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 181 ~ [INFO] [stdout] 182 ~ process_inst_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:193:6 [INFO] [stdout] | [INFO] [stdout] 193 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:276:6 [INFO] [stdout] | [INFO] [stdout] 276 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:330:6 [INFO] [stdout] | [INFO] [stdout] 330 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:371:6 [INFO] [stdout] | [INFO] [stdout] 371 | ) -> Result>, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/mod.rs:371:13 [INFO] [stdout] | [INFO] [stdout] 371 | ) -> Result>, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:392:6 [INFO] [stdout] | [INFO] [stdout] 392 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:417:6 [INFO] [stdout] | [INFO] [stdout] 417 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:422:13 [INFO] [stdout] | [INFO] [stdout] 421 | let verilog_inst = process_inner_inst_declaration(pair); [INFO] [stdout] | -------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 422 | verilog_inst [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 421 ~ [INFO] [stdout] 422 ~ process_inner_inst_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/mod.rs:432:15 [INFO] [stdout] | [INFO] [stdout] 432 | dcl_stmt: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&verilog_data::VerilogDcl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/verilog_parser/mod.rs:444:13 [INFO] [stdout] | [INFO] [stdout] 444 | / let mut verilog_dcl_vec: Vec> = Vec::new(); [INFO] [stdout] 445 | | verilog_dcl_vec.push(Box::new(new_dcl_stmt)); [INFO] [stdout] | |_________________________________________________________^ help: consider using the `vec![]` macro: `let verilog_dcl_vec: Vec> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:502:36 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 502 | let is_first_greater = range.unwrap().0 > range.unwrap().1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:502:55 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 502 | let is_first_greater = range.unwrap().0 > range.unwrap().1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:503:29 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 503 | let mut index = range.unwrap().0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:504:48 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 504 | while is_first_greater && index >= range.unwrap().1 || !is_first_greater && index <= range.unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:504:98 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 504 | while is_first_greater && index >= range.unwrap().1 || !is_first_greater && index <= range.unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/mod.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | return port_connect_net; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 535 - return port_connect_net; [INFO] [stdout] 535 + port_connect_net [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port_connect_net` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/mod.rs:549:32 [INFO] [stdout] | [INFO] [stdout] 548 | if port_connect_net.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = port_connect_net` [INFO] [stdout] 549 | new_one_net_expr = port_connect_net.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/verilog_parser/mod.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair) -> Result<&str, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair<'_, Rule>) -> Result<&str, pest::error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:18:43 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair) -> Result<&str, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:34:6 [INFO] [stdout] | [INFO] [stdout] 34 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:50:6 [INFO] [stdout] | [INFO] [stdout] 50 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 55 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 56 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 55 ~ [INFO] [stdout] 56 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 60 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 61 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 60 ~ [INFO] [stdout] 61 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 65 | let verilog_dcls = process_inner_port_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 66 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 65 ~ [INFO] [stdout] 66 ~ process_inner_port_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 70 | let verilog_dcls = process_inner_wire_declaration(pair, dcl_type); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 71 | verilog_dcls [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 70 ~ [INFO] [stdout] 71 ~ process_inner_wire_declaration(pair, dcl_type) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:83:6 [INFO] [stdout] | [INFO] [stdout] 83 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:100:79 [INFO] [stdout] | [INFO] [stdout] 100 | let verilog_dcl = verilog_data::VerilogDcl::new(port_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:113:79 [INFO] [stdout] | [INFO] [stdout] 113 | let verilog_dcl = verilog_data::VerilogDcl::new(port_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:129:6 [INFO] [stdout] | [INFO] [stdout] 129 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:145:79 [INFO] [stdout] | [INFO] [stdout] 145 | let verilog_dcl = verilog_data::VerilogDcl::new(wire_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DclType` which implements the `Copy` trait [INFO] [stdout] --> src/verilog_parser/mod.rs:158:79 [INFO] [stdout] | [INFO] [stdout] 158 | let verilog_dcl = verilog_data::VerilogDcl::new(wire_line_no, dcl_type.clone(), &dcl_name, range); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dcl_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:173:6 [INFO] [stdout] | [INFO] [stdout] 173 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 177 | let verilog_assign = process_assign_declaration(pair); [INFO] [stdout] | ------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 178 | verilog_assign [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 177 ~ [INFO] [stdout] 178 ~ process_assign_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 181 | let verilog_inst = process_inst_declaration(pair); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 182 | verilog_inst [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 181 ~ [INFO] [stdout] 182 ~ process_inst_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:193:6 [INFO] [stdout] | [INFO] [stdout] 193 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:276:6 [INFO] [stdout] | [INFO] [stdout] 276 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:330:6 [INFO] [stdout] | [INFO] [stdout] 330 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:371:6 [INFO] [stdout] | [INFO] [stdout] 371 | ) -> Result>, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/verilog_parser/mod.rs:371:13 [INFO] [stdout] | [INFO] [stdout] 371 | ) -> Result>, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:392:6 [INFO] [stdout] | [INFO] [stdout] 392 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/verilog_parser/mod.rs:417:6 [INFO] [stdout] | [INFO] [stdout] 417 | ) -> Result, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/verilog_parser/mod.rs:422:13 [INFO] [stdout] | [INFO] [stdout] 421 | let verilog_inst = process_inner_inst_declaration(pair); [INFO] [stdout] | -------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 422 | verilog_inst [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 421 ~ [INFO] [stdout] 422 ~ process_inner_inst_declaration(pair) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stdout] --> src/verilog_parser/mod.rs:432:15 [INFO] [stdout] | [INFO] [stdout] 432 | dcl_stmt: &Box, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&verilog_data::VerilogDcl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/verilog_parser/mod.rs:444:13 [INFO] [stdout] | [INFO] [stdout] 444 | / let mut verilog_dcl_vec: Vec> = Vec::new(); [INFO] [stdout] 445 | | verilog_dcl_vec.push(Box::new(new_dcl_stmt)); [INFO] [stdout] | |_________________________________________________________^ help: consider using the `vec![]` macro: `let verilog_dcl_vec: Vec> = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:502:36 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 502 | let is_first_greater = range.unwrap().0 > range.unwrap().1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:502:55 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 502 | let is_first_greater = range.unwrap().0 > range.unwrap().1; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:503:29 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 503 | let mut index = range.unwrap().0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:504:48 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 504 | while is_first_greater && index >= range.unwrap().1 || !is_first_greater && index <= range.unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `range` after checking its variant with `is_none` [INFO] [stdout] --> src/verilog_parser/mod.rs:504:98 [INFO] [stdout] | [INFO] [stdout] 493 | if range.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = range` [INFO] [stdout] ... [INFO] [stdout] 504 | while is_first_greater && index >= range.unwrap().1 || !is_first_greater && index <= range.unwrap().1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verilog_parser/mod.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | return port_connect_net; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 535 - return port_connect_net; [INFO] [stdout] 535 + port_connect_net [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `port_connect_net` after checking its variant with `is_some` [INFO] [stdout] --> src/verilog_parser/mod.rs:549:32 [INFO] [stdout] | [INFO] [stdout] 548 | if port_connect_net.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = port_connect_net` [INFO] [stdout] 549 | new_one_net_expr = port_connect_net.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/verilog_parser/mod.rs:887:17 [INFO] [stdout] | [INFO] [stdout] 887 | assert!(!parse_result_clone.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_result_clone.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/verilog_parser/mod.rs:18:28 [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair) -> Result<&str, pest::error::Error> { [INFO] [stdout] | ^^^^^^^^^^ ^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 18 | fn process_module_id(pair: Pair<'_, Rule>) -> Result<&str, pest::error::Error> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.48s [INFO] running `Command { std: "docker" "inspect" "70311c2014e15e6d0130e71bfc8c6469699d023bc2502cbcbf931c51c2401e9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70311c2014e15e6d0130e71bfc8c6469699d023bc2502cbcbf931c51c2401e9b", kill_on_drop: false }` [INFO] [stdout] 70311c2014e15e6d0130e71bfc8c6469699d023bc2502cbcbf931c51c2401e9b