[INFO] fetching crate verilization-compiler 0.1.0... [INFO] linting verilization-compiler-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate verilization-compiler 0.1.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate verilization-compiler 0.1.0 [INFO] finished tweaking crates.io crate verilization-compiler 0.1.0 [INFO] tweaked toml for crates.io crate verilization-compiler 0.1.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate verilization-compiler 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding memchr v2.3.4 (available: v2.8.0) [INFO] [stderr] Adding nom v6.2.2 (available: v8.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bitvec v0.19.6 [INFO] [stderr] Downloaded pathdiff v0.2.3 [INFO] [stderr] Downloaded lexical-core v0.7.6 [INFO] [stderr] Downloaded memchr v2.3.4 [INFO] [stderr] Downloaded nom v6.2.2 [INFO] [stderr] Downloaded radium v0.5.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fbaf04e6425446ff634d58ba76551fc78b3fb3e4d46a1875c5ab1fbc01ac2208 [INFO] running `Command { std: "docker" "start" "-a" "fbaf04e6425446ff634d58ba76551fc78b3fb3e4d46a1875c5ab1fbc01ac2208", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fbaf04e6425446ff634d58ba76551fc78b3fb3e4d46a1875c5ab1fbc01ac2208", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fbaf04e6425446ff634d58ba76551fc78b3fb3e4d46a1875c5ab1fbc01ac2208", kill_on_drop: false }` [INFO] [stdout] fbaf04e6425446ff634d58ba76551fc78b3fb3e4d46a1875c5ab1fbc01ac2208 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db974d4eaae390400d13e28bef91561ecacdfb18b5e52e70abbe12d793e6fc85 [INFO] running `Command { std: "docker" "start" "-a" "db974d4eaae390400d13e28bef91561ecacdfb18b5e52e70abbe12d793e6fc85", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Compiling nom v6.2.2 [INFO] [stderr] Checking bitvec v0.19.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking verilization-compiler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:215:4 [INFO] [stdout] | [INFO] [stdout] 215 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:216:4 [INFO] [stdout] | [INFO] [stdout] 216 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:217:4 [INFO] [stdout] | [INFO] [stdout] 217 | value: value, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:310:4 [INFO] [stdout] | [INFO] [stdout] 310 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | imports: imports, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:313:5 [INFO] [stdout] | [INFO] [stdout] 313 | value_type: value_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:440:4 [INFO] [stdout] | [INFO] [stdout] 440 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:442:5 [INFO] [stdout] | [INFO] [stdout] 442 | imports: imports, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:443:5 [INFO] [stdout] | [INFO] [stdout] 443 | type_params: type_params, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:444:5 [INFO] [stdout] | [INFO] [stdout] 444 | is_final: is_final, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_final` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:460:6 [INFO] [stdout] | [INFO] [stdout] 460 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:462:6 [INFO] [stdout] | [INFO] [stdout] 462 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:494:6 [INFO] [stdout] | [INFO] [stdout] 494 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:574:4 [INFO] [stdout] | [INFO] [stdout] 574 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:581:5 [INFO] [stdout] | [INFO] [stdout] 581 | imports: imports, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:582:5 [INFO] [stdout] | [INFO] [stdout] 582 | type_params: type_params, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:645:5 [INFO] [stdout] | [INFO] [stdout] 645 | fields: fields, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:788:4 [INFO] [stdout] | [INFO] [stdout] 788 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:845:4 [INFO] [stdout] | [INFO] [stdout] 845 | metadata: metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:933:99 [INFO] [stdout] | [INFO] [stdout] 933 | ...stant)| self.add_constant(ConstantBuilder { name: name, constant: constant }))?; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:933:111 [INFO] [stdout] | [INFO] [stdout] 933 | ...onstant(ConstantBuilder { name: name, constant: constant }))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `constant` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:935:98 [INFO] [stdout] | [INFO] [stdout] 935 | TypeDefinition::StructType(type_def) => self.add_struct_type(VersionedTypeDefinitionBuilder { name: name, t: type_def }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:936:94 [INFO] [stdout] | [INFO] [stdout] 936 | TypeDefinition::EnumType(type_def) => self.add_enum_type(VersionedTypeDefinitionBuilder { name: name, t: type_def }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:937:95 [INFO] [stdout] | [INFO] [stdout] 937 | ...d_extern_type(ExternTypeDefinitionBuilder { name: name, t: type_def, has_integer: false, has_string: false, has_sequence: false,... [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:997:6 [INFO] [stdout] | [INFO] [stdout] 997 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1004:6 [INFO] [stdout] | [INFO] [stdout] 1004 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1050:6 [INFO] [stdout] | [INFO] [stdout] 1050 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1052:6 [INFO] [stdout] | [INFO] [stdout] 1052 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1058:6 [INFO] [stdout] | [INFO] [stdout] 1058 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1060:6 [INFO] [stdout] | [INFO] [stdout] 1060 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:307:6 [INFO] [stdout] | [INFO] [stdout] 307 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:309:6 [INFO] [stdout] | [INFO] [stdout] 309 | type_def: type_def, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `type_def` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:310:6 [INFO] [stdout] | [INFO] [stdout] 310 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:325:6 [INFO] [stdout] | [INFO] [stdout] 325 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:327:6 [INFO] [stdout] | [INFO] [stdout] 327 | type_def: type_def, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `type_def` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:328:6 [INFO] [stdout] | [INFO] [stdout] 328 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:340:6 [INFO] [stdout] | [INFO] [stdout] 340 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:342:6 [INFO] [stdout] | [INFO] [stdout] 342 | type_def: type_def, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `type_def` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:588:148 [INFO] [stdout] | [INFO] [stdout] 588 | ...dName { package: model::PackageName::new(), name: name, })) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:772:4 [INFO] [stdout] | [INFO] [stdout] 772 | type_args: type_args, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:814:6 [INFO] [stdout] | [INFO] [stdout] 814 | cases: cases, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `cases` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:829:3 [INFO] [stdout] | [INFO] [stdout] 829 | type_params: type_params, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:830:3 [INFO] [stdout] | [INFO] [stdout] 830 | params: params, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:832:3 [INFO] [stdout] | [INFO] [stdout] 832 | implementation: implementation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implementation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:877:5 [INFO] [stdout] | [INFO] [stdout] 877 | cases: cases, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `cases` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:930:5 [INFO] [stdout] | [INFO] [stdout] 930 | cases: cases, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `cases` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:261:4 [INFO] [stdout] | [INFO] [stdout] 261 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:269:44 [INFO] [stdout] | [INFO] [stdout] 269 | Ok((input, model::Type { name: qual_name, args: args })) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 100 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:362:4 [INFO] [stdout] | [INFO] [stdout] 362 | name: name [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 360 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:403:71 [INFO] [stdout] | [INFO] [stdout] 403 | let name = model::QualifiedName { package: current_package.clone(), name: name, }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:484:71 [INFO] [stdout] | [INFO] [stdout] 484 | let name = model::QualifiedName { package: current_package.clone(), name: name, }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:215:4 [INFO] [stdout] | [INFO] [stdout] 215 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:216:4 [INFO] [stdout] | [INFO] [stdout] 216 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:217:4 [INFO] [stdout] | [INFO] [stdout] 217 | value: value, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:310:4 [INFO] [stdout] | [INFO] [stdout] 310 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | imports: imports, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:313:5 [INFO] [stdout] | [INFO] [stdout] 313 | value_type: value_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:608:71 [INFO] [stdout] | [INFO] [stdout] 608 | let name = model::QualifiedName { package: current_package.clone(), name: name, }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:440:4 [INFO] [stdout] | [INFO] [stdout] 440 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:442:5 [INFO] [stdout] | [INFO] [stdout] 442 | imports: imports, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/type_check.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:443:5 [INFO] [stdout] | [INFO] [stdout] 443 | type_params: type_params, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:444:5 [INFO] [stdout] | [INFO] [stdout] 444 | is_final: is_final, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_final` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:460:6 [INFO] [stdout] | [INFO] [stdout] 460 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:462:6 [INFO] [stdout] | [INFO] [stdout] 462 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:494:6 [INFO] [stdout] | [INFO] [stdout] 494 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/type_check.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:574:4 [INFO] [stdout] | [INFO] [stdout] 574 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:581:5 [INFO] [stdout] | [INFO] [stdout] 581 | imports: imports, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `imports` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:582:5 [INFO] [stdout] | [INFO] [stdout] 582 | type_params: type_params, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:645:5 [INFO] [stdout] | [INFO] [stdout] 645 | fields: fields, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:788:4 [INFO] [stdout] | [INFO] [stdout] 788 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:845:4 [INFO] [stdout] | [INFO] [stdout] 845 | metadata: metadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:933:99 [INFO] [stdout] | [INFO] [stdout] 933 | ...stant)| self.add_constant(ConstantBuilder { name: name, constant: constant }))?; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:933:111 [INFO] [stdout] | [INFO] [stdout] 933 | ...onstant(ConstantBuilder { name: name, constant: constant }))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `constant` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:935:98 [INFO] [stdout] | [INFO] [stdout] 935 | TypeDefinition::StructType(type_def) => self.add_struct_type(VersionedTypeDefinitionBuilder { name: name, t: type_def }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:936:94 [INFO] [stdout] | [INFO] [stdout] 936 | TypeDefinition::EnumType(type_def) => self.add_enum_type(VersionedTypeDefinitionBuilder { name: name, t: type_def }), [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:937:95 [INFO] [stdout] | [INFO] [stdout] 937 | ...d_extern_type(ExternTypeDefinitionBuilder { name: name, t: type_def, has_integer: false, has_string: false, has_sequence: false,... [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:997:6 [INFO] [stdout] | [INFO] [stdout] 997 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1004:6 [INFO] [stdout] | [INFO] [stdout] 1004 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1050:6 [INFO] [stdout] | [INFO] [stdout] 1050 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1052:6 [INFO] [stdout] | [INFO] [stdout] 1052 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1058:6 [INFO] [stdout] | [INFO] [stdout] 1058 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model.rs:1060:6 [INFO] [stdout] | [INFO] [stdout] 1060 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:307:6 [INFO] [stdout] | [INFO] [stdout] 307 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:309:6 [INFO] [stdout] | [INFO] [stdout] 309 | type_def: type_def, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `type_def` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:310:6 [INFO] [stdout] | [INFO] [stdout] 310 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:325:6 [INFO] [stdout] | [INFO] [stdout] 325 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:327:6 [INFO] [stdout] | [INFO] [stdout] 327 | type_def: type_def, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `type_def` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:328:6 [INFO] [stdout] | [INFO] [stdout] 328 | ver_type: ver_type, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ver_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:340:6 [INFO] [stdout] | [INFO] [stdout] 340 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:342:6 [INFO] [stdout] | [INFO] [stdout] 342 | type_def: type_def, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `type_def` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:588:148 [INFO] [stdout] | [INFO] [stdout] 588 | ...dName { package: model::PackageName::new(), name: name, })) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:772:4 [INFO] [stdout] | [INFO] [stdout] 772 | type_args: type_args, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:814:6 [INFO] [stdout] | [INFO] [stdout] 814 | cases: cases, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `cases` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:829:3 [INFO] [stdout] | [INFO] [stdout] 829 | type_params: type_params, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:830:3 [INFO] [stdout] | [INFO] [stdout] 830 | params: params, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:832:3 [INFO] [stdout] | [INFO] [stdout] 832 | implementation: implementation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `implementation` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:877:5 [INFO] [stdout] | [INFO] [stdout] 877 | cases: cases, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `cases` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lang/generator.rs:930:5 [INFO] [stdout] | [INFO] [stdout] 930 | cases: cases, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `cases` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:261:4 [INFO] [stdout] | [INFO] [stdout] 261 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:269:44 [INFO] [stdout] | [INFO] [stdout] 269 | Ok((input, model::Type { name: qual_name, args: args })) [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:362:4 [INFO] [stdout] | [INFO] [stdout] 362 | name: name [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 360 | package: package, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:403:71 [INFO] [stdout] | [INFO] [stdout] 403 | let name = model::QualifiedName { package: current_package.clone(), name: name, }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:484:71 [INFO] [stdout] | [INFO] [stdout] 484 | let name = model::QualifiedName { package: current_package.clone(), name: name, }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:608:71 [INFO] [stdout] | [INFO] [stdout] 608 | let name = model::QualifiedName { package: current_package.clone(), name: name, }; [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/type_check.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/type_check.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | model: model, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PackageName` [INFO] [stdout] --> src/model.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> PackageName { [INFO] [stdout] 17 | | PackageName { [INFO] [stdout] 18 | | package: Vec::new(), [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for PackageName { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/model.rs:22:2 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn from_str(pkg: &str) -> PackageName { [INFO] [stdout] 23 | | PackageName { [INFO] [stdout] 24 | | package: [INFO] [stdout] 25 | | if pkg.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/model.rs:85:2 [INFO] [stdout] | [INFO] [stdout] 85 | / pub fn from_str(name: &str) -> Option { [INFO] [stdout] 86 | | let mut iter = name.split("."); [INFO] [stdout] 87 | | if let Some(part) = iter.next() { [INFO] [stdout] 88 | | let mut pkg_parts = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/model.rs:91:4 [INFO] [stdout] | [INFO] [stdout] 91 | while let Some(part) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for part in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/model.rs:201:26 [INFO] [stdout] | [INFO] [stdout] 201 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 202 | | Named { [INFO] [stdout] 203 | | model: self.model, [INFO] [stdout] 204 | | name: self.name, [INFO] [stdout] ... | [INFO] [stdout] 207 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/model.rs:244:22 [INFO] [stdout] | [INFO] [stdout] 244 | pub fn field_values<'a>(&'a self) -> &'a HashMap { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 244 - pub fn field_values<'a>(&'a self) -> &'a HashMap { [INFO] [stdout] 244 + pub fn field_values(&self) -> &HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ConstantValueRecordBuilder` [INFO] [stdout] --> src/model.rs:259:2 [INFO] [stdout] | [INFO] [stdout] 259 | / pub fn new() -> Self { [INFO] [stdout] 260 | | ConstantValueRecordBuilder { [INFO] [stdout] 261 | | field_names: HashSet::new(), [INFO] [stdout] 262 | | record: ConstantValueRecord { [INFO] [stdout] ... | [INFO] [stdout] 266 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 258 + impl Default for ConstantValueRecordBuilder { [INFO] [stdout] 259 + fn default() -> Self { [INFO] [stdout] 260 + Self::new() [INFO] [stdout] 261 + } [INFO] [stdout] 262 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/model.rs:320:3 [INFO] [stdout] | [INFO] [stdout] 320 | / if self.constant.versions.contains_key(&version) { [INFO] [stdout] 321 | | Err(ModelError::DuplicateVersion(self.name.clone(), version.clone())) [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | else { [INFO] [stdout] 324 | | self.constant.versions.insert(version, value); [INFO] [stdout] 325 | | Ok(()) [INFO] [stdout] 326 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/model.rs:521:6 [INFO] [stdout] | [INFO] [stdout] 521 | self.last_explicit_version().map(|ver| ver.clone()).unwrap_or(BigUint::zero()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.last_explicit_version().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PackageName` [INFO] [stdout] --> src/model.rs:16:2 [INFO] [stdout] | [INFO] [stdout] 16 | / pub fn new() -> PackageName { [INFO] [stdout] 17 | | PackageName { [INFO] [stdout] 18 | | package: Vec::new(), [INFO] [stdout] 19 | | } [INFO] [stdout] 20 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 15 + impl Default for PackageName { [INFO] [stdout] 16 + fn default() -> Self { [INFO] [stdout] 17 + Self::new() [INFO] [stdout] 18 + } [INFO] [stdout] 19 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/model.rs:22:2 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn from_str(pkg: &str) -> PackageName { [INFO] [stdout] 23 | | PackageName { [INFO] [stdout] 24 | | package: [INFO] [stdout] 25 | | if pkg.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/model.rs:85:2 [INFO] [stdout] | [INFO] [stdout] 85 | / pub fn from_str(name: &str) -> Option { [INFO] [stdout] 86 | | let mut iter = name.split("."); [INFO] [stdout] 87 | | if let Some(part) = iter.next() { [INFO] [stdout] 88 | | let mut pkg_parts = Vec::new(); [INFO] [stdout] ... | [INFO] [stdout] 106 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/model.rs:91:4 [INFO] [stdout] | [INFO] [stdout] 91 | while let Some(part) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for part in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/model.rs:923:18 [INFO] [stdout] | [INFO] [stdout] 923 | pub fn has_type<'a>(&'a self, name: &QualifiedName) -> bool { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 923 - pub fn has_type<'a>(&'a self, name: &QualifiedName) -> bool { [INFO] [stdout] 923 + pub fn has_type(&self, name: &QualifiedName) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/model.rs:201:26 [INFO] [stdout] | [INFO] [stdout] 201 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 202 | | Named { [INFO] [stdout] 203 | | model: self.model, [INFO] [stdout] 204 | | name: self.name, [INFO] [stdout] ... | [INFO] [stdout] 207 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/model.rs:244:22 [INFO] [stdout] | [INFO] [stdout] 244 | pub fn field_values<'a>(&'a self) -> &'a HashMap { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 244 - pub fn field_values<'a>(&'a self) -> &'a HashMap { [INFO] [stdout] 244 + pub fn field_values(&self) -> &HashMap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ConstantValueRecordBuilder` [INFO] [stdout] --> src/model.rs:259:2 [INFO] [stdout] | [INFO] [stdout] 259 | / pub fn new() -> Self { [INFO] [stdout] 260 | | ConstantValueRecordBuilder { [INFO] [stdout] 261 | | field_names: HashSet::new(), [INFO] [stdout] 262 | | record: ConstantValueRecord { [INFO] [stdout] ... | [INFO] [stdout] 266 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 258 + impl Default for ConstantValueRecordBuilder { [INFO] [stdout] 259 + fn default() -> Self { [INFO] [stdout] 260 + Self::new() [INFO] [stdout] 261 + } [INFO] [stdout] 262 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/model.rs:320:3 [INFO] [stdout] | [INFO] [stdout] 320 | / if self.constant.versions.contains_key(&version) { [INFO] [stdout] 321 | | Err(ModelError::DuplicateVersion(self.name.clone(), version.clone())) [INFO] [stdout] 322 | | } [INFO] [stdout] 323 | | else { [INFO] [stdout] 324 | | self.constant.versions.insert(version, value); [INFO] [stdout] 325 | | Ok(()) [INFO] [stdout] 326 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:82:11 [INFO] [stdout] | [INFO] [stdout] 82 | name: &name, [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:132:14 [INFO] [stdout] | [INFO] [stdout] 132 | ... name: &name, [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/model.rs:521:6 [INFO] [stdout] | [INFO] [stdout] 521 | self.last_explicit_version().map(|ver| ver.clone()).unwrap_or(BigUint::zero()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.last_explicit_version().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lang/generator.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 300 | .zip(lang_args.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 300 - .zip(lang_args.clone().into_iter()) [INFO] [stdout] 300 + .zip(lang_args.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lang/generator.rs:318:11 [INFO] [stdout] | [INFO] [stdout] 318 | .zip(lang_args.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 318 - .zip(lang_args.clone().into_iter()) [INFO] [stdout] 318 + .zip(lang_args.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lang/generator.rs:336:11 [INFO] [stdout] | [INFO] [stdout] 336 | .zip(lang_args.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 336 - .zip(lang_args.clone().into_iter()) [INFO] [stdout] 336 + .zip(lang_args.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/lang/generator.rs:348:46 [INFO] [stdout] | [INFO] [stdout] 348 | ...peParameter(name) => type_args.get(&name).ok_or_else(|| GeneratorError::CouldNotResolveTypeParameter(name))?.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 348 - model::ScopeLookup::TypeParameter(name) => type_args.get(&name).ok_or_else(|| GeneratorError::CouldNotResolveTypeParameter(name))?.clone(), [INFO] [stdout] 348 + model::ScopeLookup::TypeParameter(name) => type_args.get(&name).ok_or(GeneratorError::CouldNotResolveTypeParameter(name))?.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/model.rs:923:18 [INFO] [stdout] | [INFO] [stdout] 923 | pub fn has_type<'a>(&'a self, name: &QualifiedName) -> bool { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 923 - pub fn has_type<'a>(&'a self, name: &QualifiedName) -> bool { [INFO] [stdout] 923 + pub fn has_type(&self, name: &QualifiedName) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lang/generator.rs:519:38 [INFO] [stdout] | [INFO] [stdout] 519 | let args = args.into_iter().zip(case_params.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 519 - let args = args.into_iter().zip(case_params.into_iter()) [INFO] [stdout] 519 + let args = args.into_iter().zip(case_params) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/lang/generator.rs:584:22 [INFO] [stdout] | [INFO] [stdout] 584 | let constant = self.model().get_constant(&name).ok_or_else(|| GeneratorError::CouldNotFind(name))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 584 - let constant = self.model().get_constant(&name).ok_or_else(|| GeneratorError::CouldNotFind(name))?; [INFO] [stdout] 584 + let constant = self.model().get_constant(&name).ok_or(GeneratorError::CouldNotFind(name))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:82:11 [INFO] [stdout] | [INFO] [stdout] 82 | name: &name, [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:665:76 [INFO] [stdout] | [INFO] [stdout] 665 | .map(|param| model::Type { name: model::QualifiedName::from_parts(&[], ¶m), args: vec!() }) [INFO] [stdout] | ^^^^^^ help: change this to: `param` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:132:14 [INFO] [stdout] | [INFO] [stdout] 132 | ... name: &name, [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:739:86 [INFO] [stdout] | [INFO] [stdout] 739 | type_params_as_args.push(model::Type { name: model::QualifiedName::from_parts(&[], ¶m), args: vec!() }); [INFO] [stdout] | ^^^^^^ help: change this to: `param` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:740:47 [INFO] [stdout] | [INFO] [stdout] 740 | let t1 = Gen::Lang::convert_prev_type_param(¶m); [INFO] [stdout] | ^^^^^^ help: change this to: `param` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:741:50 [INFO] [stdout] | [INFO] [stdout] 741 | let t2 = Gen::Lang::convert_current_type_param(¶m); [INFO] [stdout] | ^^^^^^ help: change this to: `param` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lang/generator.rs:300:11 [INFO] [stdout] | [INFO] [stdout] 300 | .zip(lang_args.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 300 - .zip(lang_args.clone().into_iter()) [INFO] [stdout] 300 + .zip(lang_args.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lang/generator.rs:318:11 [INFO] [stdout] | [INFO] [stdout] 318 | .zip(lang_args.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 318 - .zip(lang_args.clone().into_iter()) [INFO] [stdout] 318 + .zip(lang_args.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lang/generator.rs:336:11 [INFO] [stdout] | [INFO] [stdout] 336 | .zip(lang_args.clone().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 336 - .zip(lang_args.clone().into_iter()) [INFO] [stdout] 336 + .zip(lang_args.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/lang/generator.rs:348:46 [INFO] [stdout] | [INFO] [stdout] 348 | ...peParameter(name) => type_args.get(&name).ok_or_else(|| GeneratorError::CouldNotResolveTypeParameter(name))?.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 348 - model::ScopeLookup::TypeParameter(name) => type_args.get(&name).ok_or_else(|| GeneratorError::CouldNotResolveTypeParameter(name))?.clone(), [INFO] [stdout] 348 + model::ScopeLookup::TypeParameter(name) => type_args.get(&name).ok_or(GeneratorError::CouldNotResolveTypeParameter(name))?.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/lang/generator.rs:519:38 [INFO] [stdout] | [INFO] [stdout] 519 | let args = args.into_iter().zip(case_params.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 519 - let args = args.into_iter().zip(case_params.into_iter()) [INFO] [stdout] 519 + let args = args.into_iter().zip(case_params) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/lang/generator.rs:584:22 [INFO] [stdout] | [INFO] [stdout] 584 | let constant = self.model().get_constant(&name).ok_or_else(|| GeneratorError::CouldNotFind(name))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `ok_or` instead [INFO] [stdout] | [INFO] [stdout] 584 - let constant = self.model().get_constant(&name).ok_or_else(|| GeneratorError::CouldNotFind(name))?; [INFO] [stdout] 584 + let constant = self.model().get_constant(&name).ok_or(GeneratorError::CouldNotFind(name))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:665:76 [INFO] [stdout] | [INFO] [stdout] 665 | .map(|param| model::Type { name: model::QualifiedName::from_parts(&[], ¶m), args: vec!() }) [INFO] [stdout] | ^^^^^^ help: change this to: `param` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:739:86 [INFO] [stdout] | [INFO] [stdout] 739 | type_params_as_args.push(model::Type { name: model::QualifiedName::from_parts(&[], ¶m), args: vec!() }); [INFO] [stdout] | ^^^^^^ help: change this to: `param` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:740:47 [INFO] [stdout] | [INFO] [stdout] 740 | let t1 = Gen::Lang::convert_prev_type_param(¶m); [INFO] [stdout] | ^^^^^^ help: change this to: `param` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lang/generator.rs:741:50 [INFO] [stdout] | [INFO] [stdout] 741 | let t2 = Gen::Lang::convert_current_type_param(¶m); [INFO] [stdout] | ^^^^^^ help: change this to: `param` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:294:20 [INFO] [stdout] | [INFO] [stdout] 294 | .unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:310:20 [INFO] [stdout] | [INFO] [stdout] 310 | .unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/parser.rs:352:2 [INFO] [stdout] | [INFO] [stdout] 352 | while let Some(part) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for part in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:604:42 [INFO] [stdout] | [INFO] [stdout] 604 | let literals = literals.unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/type_check.rs:41:46 [INFO] [stdout] | [INFO] [stdout] 41 | self.check_type(version, &arg)?; [INFO] [stdout] | ^^^^ help: change this to: `arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/type_check.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 47 | if t.args.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!t.args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/type_check.rs:65:28 [INFO] [stdout] | [INFO] [stdout] 65 | ... if !(type_def.last_explicit_version().ok_or_else(|| TypeCheckError::CouldNotFindLastVersion(name.clone()))? <= version) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(type_def.last_explicit_version().ok_or_else(|| TypeCheckError::CouldNotFindLastVersion(name.clone()))? > version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/type_check.rs:74:45 [INFO] [stdout] | [INFO] [stdout] 74 | if !self.check_is_final(&arg, version)? { [INFO] [stdout] | ^^^^ help: change this to: `arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:294:20 [INFO] [stdout] | [INFO] [stdout] 294 | .unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:310:20 [INFO] [stdout] | [INFO] [stdout] 310 | .unwrap_or_else(|| Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/parser.rs:352:2 [INFO] [stdout] | [INFO] [stdout] 352 | while let Some(part) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for part in iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/model_loader.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | while let Some(other) = models.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for other in models` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/memory_output_handler.rs:15:39 [INFO] [stdout] | [INFO] [stdout] 15 | Ok(self.files.entry(filename).or_insert_with(Vec::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&num_bigint::BigUint` instead of cloning the inner type [INFO] [stdout] --> src/model.rs:480:30 [INFO] [stdout] | [INFO] [stdout] 480 | .max_by_key(|(ver, _)| ver.clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/parser.rs:604:42 [INFO] [stdout] | [INFO] [stdout] 604 | let literals = literals.unwrap_or_else(|| Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/type_check.rs:41:46 [INFO] [stdout] | [INFO] [stdout] 41 | self.check_type(version, &arg)?; [INFO] [stdout] | ^^^^ help: change this to: `arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/type_check.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 47 | if t.args.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!t.args.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/type_check.rs:65:28 [INFO] [stdout] | [INFO] [stdout] 65 | ... if !(type_def.last_explicit_version().ok_or_else(|| TypeCheckError::CouldNotFindLastVersion(name.clone()))? <= version) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(type_def.last_explicit_version().ok_or_else(|| TypeCheckError::CouldNotFindLastVersion(name.clone()))? > version)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/type_check.rs:74:45 [INFO] [stdout] | [INFO] [stdout] 74 | if !self.check_is_final(&arg, version)? { [INFO] [stdout] | ^^^^ help: change this to: `arg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/model_loader.rs:37:2 [INFO] [stdout] | [INFO] [stdout] 37 | while let Some(other) = models.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for other in models` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/memory_output_handler.rs:15:39 [INFO] [stdout] | [INFO] [stdout] 15 | Ok(self.files.entry(filename).or_insert_with(Vec::new)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&num_bigint::BigUint` instead of cloning the inner type [INFO] [stdout] --> src/model.rs:480:30 [INFO] [stdout] | [INFO] [stdout] 480 | .max_by_key(|(ver, _)| ver.clone()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.84s [INFO] running `Command { std: "docker" "inspect" "db974d4eaae390400d13e28bef91561ecacdfb18b5e52e70abbe12d793e6fc85", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db974d4eaae390400d13e28bef91561ecacdfb18b5e52e70abbe12d793e6fc85", kill_on_drop: false }` [INFO] [stdout] db974d4eaae390400d13e28bef91561ecacdfb18b5e52e70abbe12d793e6fc85