[INFO] fetching crate verify_string 0.1.3... [INFO] linting verify_string-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate verify_string 0.1.3 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate verify_string 0.1.3 [INFO] finished tweaking crates.io crate verify_string 0.1.3 [INFO] tweaked toml for crates.io crate verify_string 0.1.3 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate verify_string 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 31 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f0f45c8ee886605b3badb35e06e25217a7db9e06d91f37265566876358258ab [INFO] running `Command { std: "docker" "start" "-a" "5f0f45c8ee886605b3badb35e06e25217a7db9e06d91f37265566876358258ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f0f45c8ee886605b3badb35e06e25217a7db9e06d91f37265566876358258ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f0f45c8ee886605b3badb35e06e25217a7db9e06d91f37265566876358258ab", kill_on_drop: false }` [INFO] [stdout] 5f0f45c8ee886605b3badb35e06e25217a7db9e06d91f37265566876358258ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5e4fe0277d4e7fd9c8ef02cca6e84411efc5739290969c01a3fb1b95732b84f4 [INFO] running `Command { std: "docker" "start" "-a" "5e4fe0277d4e7fd9c8ef02cca6e84411efc5739290969c01a3fb1b95732b84f4", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling derive_builder_core v0.20.2 [INFO] [stderr] Compiling derive_builder_macro v0.20.2 [INFO] [stderr] Checking derive_builder v0.20.2 [INFO] [stderr] Checking verify_string v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: allow(text_direction_codepoint_in_literal) is ignored unless specified at crate level [INFO] [stdout] --> src/invisibilities.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | #![allow(text_direction_codepoint_in_literal)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_attributes)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: allow(text_direction_codepoint_in_literal) is ignored unless specified at crate level [INFO] [stdout] --> src/invisibilities.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | #![allow(text_direction_codepoint_in_literal)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_attributes)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/verify.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | assert!(!rule.verify("1234567890").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rule.verify("1234567890").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/verify.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | assert!(!rule.verify("").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rule.verify("").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/verify.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | assert!(!rule.verify("Mason").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rule.verify("Mason").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/verify.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 50 | assert!(!rule.verify("Mason").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rule.verify("Mason").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/verify.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | assert!(!rule.verify("Mason").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rule.verify("Mason").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/verify.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | assert!(!rule.verify("󠇦Mason").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rule.verify("󠇦Mason").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.57s [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/verify.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 80 | assert!(!rule.verify("Mason󠇦").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rule.verify("Mason󠇦").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/verify.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | assert!(!rule.verify("Mason").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rule.verify("Mason").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/verify.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | assert!(!rule.verify("Ma󠇦son").is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `rule.verify("Ma󠇦son").is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/verify.rs:113:52 [INFO] [stdout] | [INFO] [stdout] 113 | let start_end_regex = regex_start_end_char(&INVISIBILITIES).expect("make regex failed"); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `INVISIBILITIES` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "5e4fe0277d4e7fd9c8ef02cca6e84411efc5739290969c01a3fb1b95732b84f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5e4fe0277d4e7fd9c8ef02cca6e84411efc5739290969c01a3fb1b95732b84f4", kill_on_drop: false }` [INFO] [stdout] 5e4fe0277d4e7fd9c8ef02cca6e84411efc5739290969c01a3fb1b95732b84f4