[INFO] fetching crate velodyne 0.1.1... [INFO] linting velodyne-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate velodyne 0.1.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate velodyne 0.1.1 [INFO] finished tweaking crates.io crate velodyne 0.1.1 [INFO] tweaked toml for crates.io crate velodyne 0.1.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate velodyne 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 54 packages to latest compatible versions [INFO] [stderr] Adding structopt v0.2.18 (available: v0.3.26) [INFO] [stderr] Adding structopt-derive v0.2.18 (available: v0.4.18) [INFO] [stderr] Adding xml-rs v0.8.28 (available: v1.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded memmap v0.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] afd5b469087d83f15d2b7d4c249e92190f79f5b2b9df5e5cd7b68a969e93823b [INFO] running `Command { std: "docker" "start" "-a" "afd5b469087d83f15d2b7d4c249e92190f79f5b2b9df5e5cd7b68a969e93823b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "afd5b469087d83f15d2b7d4c249e92190f79f5b2b9df5e5cd7b68a969e93823b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afd5b469087d83f15d2b7d4c249e92190f79f5b2b9df5e5cd7b68a969e93823b", kill_on_drop: false }` [INFO] [stdout] afd5b469087d83f15d2b7d4c249e92190f79f5b2b9df5e5cd7b68a969e93823b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] efeaf75ace94d27308149e913c667c5c8cdecd5e53b155eeacdd9dbb4d53a430 [INFO] running `Command { std: "docker" "start" "-a" "efeaf75ace94d27308149e913c667c5c8cdecd5e53b155eeacdd9dbb4d53a430", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling unicode-segmentation v1.12.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking velodyne v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/packet/udp.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | const DEFAULT_ADDR: &'static str = "0.0.0.0:2368"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/packet/udp.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | Self { socket: socket, buf: [0u8; PACKET_SIZE] } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | Ok(StatusListener { status: status, calib_db: calib_db, accum: accum }) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status.rs:55:45 [INFO] [stdout] | [INFO] [stdout] 55 | Ok(StatusListener { status: status, calib_db: calib_db, accum: accum }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `calib_db` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status.rs:55:65 [INFO] [stdout] | [INFO] [stdout] 55 | Ok(StatusListener { status: status, calib_db: calib_db, accum: accum }) [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `accum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status_accum.rs:183:49 [INFO] [stdout] | [INFO] [stdout] 183 | ... CycleState::Lasers{ laser: laser, part: part + 1 } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `laser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status_accum.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 343 | dt: dt, [INFO] [stdout] | ^^^^^^ help: replace it with: `dt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/hdl64/calib.rs:34:58 [INFO] [stdout] | [INFO] [stdout] 34 | let mut lasers: [LaserCalib; 64] = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/hdl64/status_accum.rs:384:29 [INFO] [stdout] | [INFO] [stdout] 384 | Ok(DateTime::::from_utc(dt, Utc)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/hdl64/status_accum.rs:53:24 [INFO] [stdout] | [INFO] [stdout] 53 | .ok_or(io::Error::new(ErrorKind::Other, [INFO] [stdout] | ________________________^ [INFO] [stdout] 54 | | "Failed to get packet data from packet listener"))?; [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 53 - .ok_or(io::Error::new(ErrorKind::Other, [INFO] [stdout] 54 - "Failed to get packet data from packet listener"))?; [INFO] [stdout] 53 + .ok_or(io::Error::other("Failed to get packet data from packet listener"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hdl64/status_accum.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 161 | if !(&vals[..5] == b"UNIT#") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&vals[..5] != b"UNIT#")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this OR pattern can be rewritten using a range [INFO] [stdout] --> src/hdl64/status_accum.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 171 | 0 | 1 | 2 => { [INFO] [stdout] | ^^^^^^^^^ help: try: `0..=2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns [INFO] [stdout] = note: `#[warn(clippy::manual_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/hdl64/status_accum.rs:398:1 [INFO] [stdout] | [INFO] [stdout] 398 | / impl Default for CycleState { [INFO] [stdout] 399 | | fn default() -> Self { CycleState::FirstCycle } [INFO] [stdout] 400 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 391 + #[derive(Default)] [INFO] [stdout] 392 | enum CycleState { [INFO] [stdout] 393 ~ #[default] [INFO] [stdout] 394 ~ FirstCycle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/hdl64/convertor.rs:71:6 [INFO] [stdout] | [INFO] [stdout] 71 | impl<'a> Convertor for Hdl64Convertor { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/hdl64/convertor.rs:80:32 [INFO] [stdout] | [INFO] [stdout] 80 | let mut prev_azimuth = std::u16::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 80 - let mut prev_azimuth = std::u16::MAX; [INFO] [stdout] 80 + let mut prev_azimuth = u16::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/hdl32.rs:24:32 [INFO] [stdout] | [INFO] [stdout] 24 | let mut prev_azimuth = std::u16::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - let mut prev_azimuth = std::u16::MAX; [INFO] [stdout] 24 + let mut prev_azimuth = u16::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[hdl64::calib::LaserCalib; 64]` does not permit being left uninitialized [INFO] [stdout] --> src/hdl64/calib.rs:34:53 [INFO] [stdout] | [INFO] [stdout] 34 | let mut lasers: [LaserCalib; 64] = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: integers must be initialized (in this struct field) [INFO] [stdout] --> src/hdl64/calib.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub min_intensity: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling structopt-derive v0.2.18 [INFO] [stderr] Checking structopt v0.2.18 [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/packet/udp.rs:7:22 [INFO] [stdout] | [INFO] [stdout] 7 | const DEFAULT_ADDR: &'static str = "0.0.0.0:2368"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/packet/udp.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | Self { socket: socket, buf: [0u8; PACKET_SIZE] } [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | Ok(StatusListener { status: status, calib_db: calib_db, accum: accum }) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `status` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status.rs:55:45 [INFO] [stdout] | [INFO] [stdout] 55 | Ok(StatusListener { status: status, calib_db: calib_db, accum: accum }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `calib_db` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status.rs:55:65 [INFO] [stdout] | [INFO] [stdout] 55 | Ok(StatusListener { status: status, calib_db: calib_db, accum: accum }) [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `accum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status_accum.rs:183:49 [INFO] [stdout] | [INFO] [stdout] 183 | ... CycleState::Lasers{ laser: laser, part: part + 1 } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `laser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/hdl64/status_accum.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 343 | dt: dt, [INFO] [stdout] | ^^^^^^ help: replace it with: `dt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> examples/hdl64_statuses.rs:92:5 [INFO] [stdout] | [INFO] [stdout] 92 | / loop { [INFO] [stdout] 93 | | let (_, _meta) = match point_source.process_points(|_: FullPoint| {})? { [INFO] [stdout] 94 | | Some(meta) => meta, [INFO] [stdout] 95 | | None => break, [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 92 ~ while let Some(meta) = point_source.process_points(|_: FullPoint| {})? { [INFO] [stdout] 93 + let (_, _meta) = meta; [INFO] [stdout] 94 + .. [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> examples/hdl64_statuses.rs:121:39 [INFO] [stdout] | [INFO] [stdout] 121 | let timeout = timeout.map(|t| Duration::from_secs(t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Duration::from_secs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/hdl64/calib.rs:34:58 [INFO] [stdout] | [INFO] [stdout] 34 | let mut lasers: [LaserCalib; 64] = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/raw_statuses.rs:7:29 [INFO] [stdout] | [INFO] [stdout] 7 | fn main() -> Result<(), Box>{ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 7 | fn main() -> Result<(), Box>{ [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> examples/raw_statuses.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / loop { [INFO] [stdout] 11 | | let (meta, _) = match source.next_packet()? { [INFO] [stdout] 12 | | Some((_, raw_packet)) => parse_packet(raw_packet), [INFO] [stdout] 13 | | None => break, [INFO] [stdout] ... | [INFO] [stdout] 16 | | println!("{}\t{}\t{}", status.id, status.value, status.id as char); [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 10 ~ while let Some((_, raw_packet)) = source.next_packet()? { [INFO] [stdout] 11 + let (meta, _) = parse_packet(raw_packet); [INFO] [stdout] 12 + .. [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::DateTime::::from_utc`: Use TimeZone::from_utc_datetime() or DateTime::from_naive_utc_and_offset instead [INFO] [stdout] --> src/hdl64/status_accum.rs:384:29 [INFO] [stdout] | [INFO] [stdout] 384 | Ok(DateTime::::from_utc(dt, Utc)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/hdl64/status_accum.rs:53:24 [INFO] [stdout] | [INFO] [stdout] 53 | .ok_or(io::Error::new(ErrorKind::Other, [INFO] [stdout] | ________________________^ [INFO] [stdout] 54 | | "Failed to get packet data from packet listener"))?; [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 53 - .ok_or(io::Error::new(ErrorKind::Other, [INFO] [stdout] 54 - "Failed to get packet data from packet listener"))?; [INFO] [stdout] 53 + .ok_or(io::Error::other("Failed to get packet data from packet listener"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/hdl64/status_accum.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 161 | if !(&vals[..5] == b"UNIT#") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&vals[..5] != b"UNIT#")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this OR pattern can be rewritten using a range [INFO] [stdout] --> src/hdl64/status_accum.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 171 | 0 | 1 | 2 => { [INFO] [stdout] | ^^^^^^^^^ help: try: `0..=2` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_patterns [INFO] [stdout] = note: `#[warn(clippy::manual_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/hdl64/status_accum.rs:398:1 [INFO] [stdout] | [INFO] [stdout] 398 | / impl Default for CycleState { [INFO] [stdout] 399 | | fn default() -> Self { CycleState::FirstCycle } [INFO] [stdout] 400 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 391 + #[derive(Default)] [INFO] [stdout] 392 | enum CycleState { [INFO] [stdout] 393 ~ #[default] [INFO] [stdout] 394 ~ FirstCycle, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/hdl64/convertor.rs:71:6 [INFO] [stdout] | [INFO] [stdout] 71 | impl<'a> Convertor for Hdl64Convertor { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/hdl64/convertor.rs:80:32 [INFO] [stdout] | [INFO] [stdout] 80 | let mut prev_azimuth = std::u16::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 80 - let mut prev_azimuth = std::u16::MAX; [INFO] [stdout] 80 + let mut prev_azimuth = u16::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/hdl32.rs:24:32 [INFO] [stdout] | [INFO] [stdout] 24 | let mut prev_azimuth = std::u16::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 24 - let mut prev_azimuth = std::u16::MAX; [INFO] [stdout] 24 + let mut prev_azimuth = u16::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `[hdl64::calib::LaserCalib; 64]` does not permit being left uninitialized [INFO] [stdout] --> src/hdl64/calib.rs:34:53 [INFO] [stdout] | [INFO] [stdout] 34 | let mut lasers: [LaserCalib; 64] = unsafe { mem::uninitialized() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: integers must be initialized (in this struct field) [INFO] [stdout] --> src/hdl64/calib.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub min_intensity: u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.32s [INFO] running `Command { std: "docker" "inspect" "efeaf75ace94d27308149e913c667c5c8cdecd5e53b155eeacdd9dbb4d53a430", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efeaf75ace94d27308149e913c667c5c8cdecd5e53b155eeacdd9dbb4d53a430", kill_on_drop: false }` [INFO] [stdout] efeaf75ace94d27308149e913c667c5c8cdecd5e53b155eeacdd9dbb4d53a430