[INFO] fetching crate vegas-rs 0.1.0...
[INFO] linting vegas-rs-0.1.0 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate vegas-rs 0.1.0 into /workspace/builds/worker-5-tc1/source
[INFO] started tweaking crates.io crate vegas-rs 0.1.0
[INFO] finished tweaking crates.io crate vegas-rs 0.1.0
[INFO] tweaked toml for crates.io crate vegas-rs 0.1.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate vegas-rs 0.1.0 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]      Locking 10 packages to latest compatible versions
[INFO] [stderr]       Adding rand v0.3.23 (available: v0.10.0)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] a5ca5289801357c429c1c5c18e8fd8ed7521d4facc0ac7b89087c551535d8290
[INFO] running `Command { std: "docker" "start" "-a" "a5ca5289801357c429c1c5c18e8fd8ed7521d4facc0ac7b89087c551535d8290", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a5ca5289801357c429c1c5c18e8fd8ed7521d4facc0ac7b89087c551535d8290", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a5ca5289801357c429c1c5c18e8fd8ed7521d4facc0ac7b89087c551535d8290", kill_on_drop: false }`
[INFO] [stdout] a5ca5289801357c429c1c5c18e8fd8ed7521d4facc0ac7b89087c551535d8290
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] ffbe720480ab4a8934665b736121d6e253cbb0a39b77fc6f1cdfbc811fd57f61
[INFO] running `Command { std: "docker" "start" "-a" "ffbe720480ab4a8934665b736121d6e253cbb0a39b77fc6f1cdfbc811fd57f61", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking vegas-rs v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/vegas/lattice.rs:353:21
[INFO] [stdout]     |
[INFO] [stdout] 353 |         Adjacency { lims: lims, nbhs: nbhs, }
[INFO] [stdout]     |                     ^^^^^^^^^^ help: replace it with: `lims`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/vegas/lattice.rs:353:33
[INFO] [stdout]     |
[INFO] [stdout] 353 |         Adjacency { lims: lims, nbhs: nbhs, }
[INFO] [stdout]     |                                 ^^^^^^^^^^ help: replace it with: `nbhs`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/vegas/energy.rs:28:29
[INFO] [stdout]    |
[INFO] [stdout] 28 |         ExchangeComponent { adjacency: adjacency }
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjacency`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/vegas/integrator.rs:23:32
[INFO] [stdout]    |
[INFO] [stdout] 23 |         MetropolisIntegrator { temp: temp }
[INFO] [stdout]    |                                ^^^^^^^^^^ help: replace it with: `temp`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `state::StateConstructors`
[INFO] [stdout]  --> src/vegas/integrator.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use state::StateConstructors;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `Locator` is never constructed
[INFO] [stdout]    --> src/vegas/lattice.rs:367:8
[INFO] [stdout]     |
[INFO] [stdout] 367 | struct Locator {
[INFO] [stdout]     |        ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated items `locate` and `for_cubic` are never used
[INFO] [stdout]    --> src/vegas/lattice.rs:377:8
[INFO] [stdout]     |
[INFO] [stdout] 375 | impl Locator {
[INFO] [stdout]     | ------------ associated items in this implementation
[INFO] [stdout] 376 |
[INFO] [stdout] 377 |     fn locate(&self, site: &Site) -> Option<(f64, f64, f64)> {
[INFO] [stdout]     |        ^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 396 |     pub fn for_cubic(a: f64) -> Locator {
[INFO] [stdout]     |            ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/vegas/lattice.rs:33:12
[INFO] [stdout]    |
[INFO] [stdout] 33 |         if !(site.atom < self.natoms) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(site.atom >= self.natoms)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `LatticeBuilder`
[INFO] [stdout]    --> src/vegas/lattice.rs:121:5
[INFO] [stdout]     |
[INFO] [stdout] 121 | /     pub fn new() -> LatticeBuilder {
[INFO] [stdout] 122 | |         LatticeBuilder {
[INFO] [stdout] 123 | |             pbc: (true, true, true),
[INFO] [stdout] 124 | |             shape: (10u32, 10u32, 10u32),
[INFO] [stdout] ...   |
[INFO] [stdout] 128 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 120 + impl Default for LatticeBuilder {
[INFO] [stdout] 121 +     fn default() -> Self {
[INFO] [stdout] 122 +         Self::new()
[INFO] [stdout] 123 +     }
[INFO] [stdout] 124 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/vegas/lattice.rs:230:9
[INFO] [stdout]     |
[INFO] [stdout] 230 |         self.cur_at = self.cur_at + 1;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur_at += 1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]     = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/vegas/lattice.rs:231:9
[INFO] [stdout]     |
[INFO] [stdout] 231 | /         match self.cur_cell {
[INFO] [stdout] 232 | |             None => None,
[INFO] [stdout] 233 | |             Some((x, y, z)) => Some(Site {
[INFO] [stdout] 234 | |                 cell: (x as i64, y as i64, z as i64),
[INFO] [stdout] 235 | |                 atom: at,
[INFO] [stdout] 236 | |             }),
[INFO] [stdout] 237 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 231 ~         self.cur_cell.map(|(x, y, z)| Site {
[INFO] [stdout] 232 +                 cell: (x as i64, y as i64, z as i64),
[INFO] [stdout] 233 +                 atom: at,
[INFO] [stdout] 234 +             })
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/vegas/lattice.rs:347:35
[INFO] [stdout]     |
[INFO] [stdout] 347 |                     lattice.index(&site).expect("Site outside lattice")
[INFO] [stdout]     |                                   ^^^^^ help: change this to: `site`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/vegas/lattice.rs:349:24
[INFO] [stdout]     |
[INFO] [stdout] 349 |             let last = lims.last().unwrap().clone();
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*lims.last().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a
[INFO] [stdout]    --> src/vegas/lattice.rs:356:20
[INFO] [stdout]     |
[INFO] [stdout] 356 |     pub fn nbhs_of<'a>(&'a self, item: usize) -> Option<&'a[usize]> {
[INFO] [stdout]     |                    ^^   ^^                               ^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stdout]     = note: `#[warn(clippy::needless_lifetimes)]` on by default
[INFO] [stdout] help: elide the lifetimes
[INFO] [stdout]     |
[INFO] [stdout] 356 -     pub fn nbhs_of<'a>(&'a self, item: usize) -> Option<&'a[usize]> {
[INFO] [stdout] 356 +     pub fn nbhs_of(&self, item: usize) -> Option<&[usize]> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]    --> src/vegas/lattice.rs:360:19
[INFO] [stdout]     |
[INFO] [stdout] 360 |         let low = self.lims[item] as usize;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.lims[item]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]    --> src/vegas/lattice.rs:361:18
[INFO] [stdout]     |
[INFO] [stdout] 361 |         let hi = self.lims[item + 1] as usize;
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.lims[item + 1]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/vegas/lattice.rs:353:21
[INFO] [stdout]     |
[INFO] [stdout] 353 |         Adjacency { lims: lims, nbhs: nbhs, }
[INFO] [stdout]     |                     ^^^^^^^^^^ help: replace it with: `lims`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/vegas/lattice.rs:353:33
[INFO] [stdout]     |
[INFO] [stdout] 353 |         Adjacency { lims: lims, nbhs: nbhs, }
[INFO] [stdout]     |                                 ^^^^^^^^^^ help: replace it with: `nbhs`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/vegas/energy.rs:28:29
[INFO] [stdout]    |
[INFO] [stdout] 28 |         ExchangeComponent { adjacency: adjacency }
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `adjacency`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/vegas/integrator.rs:23:32
[INFO] [stdout]    |
[INFO] [stdout] 23 |         MetropolisIntegrator { temp: temp }
[INFO] [stdout]    |                                ^^^^^^^^^^ help: replace it with: `temp`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `state::StateConstructors`
[INFO] [stdout]  --> src/vegas/integrator.rs:7:5
[INFO] [stdout]   |
[INFO] [stdout] 7 | use state::StateConstructors;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `Locator` is never constructed
[INFO] [stdout]    --> src/vegas/lattice.rs:367:8
[INFO] [stdout]     |
[INFO] [stdout] 367 | struct Locator {
[INFO] [stdout]     |        ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated items `locate` and `for_cubic` are never used
[INFO] [stdout]    --> src/vegas/lattice.rs:377:8
[INFO] [stdout]     |
[INFO] [stdout] 375 | impl Locator {
[INFO] [stdout]     | ------------ associated items in this implementation
[INFO] [stdout] 376 |
[INFO] [stdout] 377 |     fn locate(&self, site: &Site) -> Option<(f64, f64, f64)> {
[INFO] [stdout]     |        ^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 396 |     pub fn for_cubic(a: f64) -> Locator {
[INFO] [stdout]     |            ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/vegas/lattice.rs:33:12
[INFO] [stdout]    |
[INFO] [stdout] 33 |         if !(site.atom < self.natoms) {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(site.atom >= self.natoms)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `LatticeBuilder`
[INFO] [stdout]    --> src/vegas/lattice.rs:121:5
[INFO] [stdout]     |
[INFO] [stdout] 121 | /     pub fn new() -> LatticeBuilder {
[INFO] [stdout] 122 | |         LatticeBuilder {
[INFO] [stdout] 123 | |             pbc: (true, true, true),
[INFO] [stdout] 124 | |             shape: (10u32, 10u32, 10u32),
[INFO] [stdout] ...   |
[INFO] [stdout] 128 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 120 + impl Default for LatticeBuilder {
[INFO] [stdout] 121 +     fn default() -> Self {
[INFO] [stdout] 122 +         Self::new()
[INFO] [stdout] 123 +     }
[INFO] [stdout] 124 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of an assign operation
[INFO] [stdout]    --> src/vegas/lattice.rs:230:9
[INFO] [stdout]     |
[INFO] [stdout] 230 |         self.cur_at = self.cur_at + 1;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.cur_at += 1`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stdout]     = note: `#[warn(clippy::assign_op_pattern)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/vegas/lattice.rs:231:9
[INFO] [stdout]     |
[INFO] [stdout] 231 | /         match self.cur_cell {
[INFO] [stdout] 232 | |             None => None,
[INFO] [stdout] 233 | |             Some((x, y, z)) => Some(Site {
[INFO] [stdout] 234 | |                 cell: (x as i64, y as i64, z as i64),
[INFO] [stdout] 235 | |                 atom: at,
[INFO] [stdout] 236 | |             }),
[INFO] [stdout] 237 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 231 ~         self.cur_cell.map(|(x, y, z)| Site {
[INFO] [stdout] 232 +                 cell: (x as i64, y as i64, z as i64),
[INFO] [stdout] 233 +                 atom: at,
[INFO] [stdout] 234 +             })
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/vegas/lattice.rs:347:35
[INFO] [stdout]     |
[INFO] [stdout] 347 |                     lattice.index(&site).expect("Site outside lattice")
[INFO] [stdout]     |                                   ^^^^^ help: change this to: `site`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait
[INFO] [stdout]    --> src/vegas/lattice.rs:349:24
[INFO] [stdout]     |
[INFO] [stdout] 349 |             let last = lims.last().unwrap().clone();
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*lims.last().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a
[INFO] [stdout]    --> src/vegas/lattice.rs:356:20
[INFO] [stdout]     |
[INFO] [stdout] 356 |     pub fn nbhs_of<'a>(&'a self, item: usize) -> Option<&'a[usize]> {
[INFO] [stdout]     |                    ^^   ^^                               ^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stdout]     = note: `#[warn(clippy::needless_lifetimes)]` on by default
[INFO] [stdout] help: elide the lifetimes
[INFO] [stdout]     |
[INFO] [stdout] 356 -     pub fn nbhs_of<'a>(&'a self, item: usize) -> Option<&'a[usize]> {
[INFO] [stdout] 356 +     pub fn nbhs_of(&self, item: usize) -> Option<&[usize]> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]    --> src/vegas/lattice.rs:360:19
[INFO] [stdout]     |
[INFO] [stdout] 360 |         let low = self.lims[item] as usize;
[INFO] [stdout]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.lims[item]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`)
[INFO] [stdout]    --> src/vegas/lattice.rs:361:18
[INFO] [stdout]     |
[INFO] [stdout] 361 |         let hi = self.lims[item + 1] as usize;
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.lims[item + 1]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/bin/main.rs:41:9
[INFO] [stdout]    |
[INFO] [stdout] 41 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty string literal in `println!`
[INFO] [stdout]   --> src/bin/main.rs:41:9
[INFO] [stdout]    |
[INFO] [stdout] 41 |         println!("");
[INFO] [stdout]    |         ^^^^^^^^^--^
[INFO] [stdout]    |                  |
[INFO] [stdout]    |                  help: remove the empty string
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stdout]    = note: `#[warn(clippy::println_empty_string)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.41s
[INFO] running `Command { std: "docker" "inspect" "ffbe720480ab4a8934665b736121d6e253cbb0a39b77fc6f1cdfbc811fd57f61", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ffbe720480ab4a8934665b736121d6e253cbb0a39b77fc6f1cdfbc811fd57f61", kill_on_drop: false }`
[INFO] [stdout] ffbe720480ab4a8934665b736121d6e253cbb0a39b77fc6f1cdfbc811fd57f61