[INFO] fetching crate vcd_parser 0.2.2... [INFO] linting vcd_parser-0.2.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate vcd_parser 0.2.2 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate vcd_parser 0.2.2 [INFO] finished tweaking crates.io crate vcd_parser 0.2.2 [INFO] tweaked toml for crates.io crate vcd_parser 0.2.2 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate vcd_parser 0.2.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate vcd_parser 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro2 v1.0.67 [INFO] [stderr] Downloaded serde v1.0.190 [INFO] [stderr] Downloaded memchr v2.6.3 [INFO] [stderr] Downloaded pest_derive v2.7.4 [INFO] [stderr] Downloaded pest_meta v2.7.4 [INFO] [stderr] Downloaded serde_json v1.0.107 [INFO] [stderr] Downloaded thiserror v1.0.48 [INFO] [stderr] Downloaded pest_generator v2.7.4 [INFO] [stderr] Downloaded termcolor v1.3.0 [INFO] [stderr] Downloaded pest v2.7.4 [INFO] [stderr] Downloaded serde_derive v1.0.190 [INFO] [stderr] Downloaded cbindgen v0.26.0 [INFO] [stderr] Downloaded thiserror-impl v1.0.48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec0ab9564e3b3b55ee293fd2afd3379936c9fc98070f92e89a6e1b31b516bbf9 [INFO] running `Command { std: "docker" "start" "-a" "ec0ab9564e3b3b55ee293fd2afd3379936c9fc98070f92e89a6e1b31b516bbf9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec0ab9564e3b3b55ee293fd2afd3379936c9fc98070f92e89a6e1b31b516bbf9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec0ab9564e3b3b55ee293fd2afd3379936c9fc98070f92e89a6e1b31b516bbf9", kill_on_drop: false }` [INFO] [stdout] ec0ab9564e3b3b55ee293fd2afd3379936c9fc98070f92e89a6e1b31b516bbf9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 395ec86b1f4cf2f3202214365aab3f43376e2bb726735cda7aacd84ab73514f3 [INFO] running `Command { std: "docker" "start" "-a" "395ec86b1f4cf2f3202214365aab3f43376e2bb726735cda7aacd84ab73514f3", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling thiserror v1.0.48 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Compiling bitflags v2.4.1 [INFO] [stderr] Compiling linux-raw-sys v0.4.10 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling os_str_bytes v6.6.1 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling cbindgen v0.26.0 [INFO] [stderr] Compiling itoa v1.0.9 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling termcolor v1.3.0 [INFO] [stderr] Compiling fastrand v2.0.1 [INFO] [stderr] Compiling memchr v2.6.3 [INFO] [stderr] Compiling textwrap v0.16.0 [INFO] [stderr] Compiling ryu v1.0.15 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling clap_lex v0.2.4 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling clap v3.2.25 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling tempfile v3.8.1 [INFO] [stderr] Compiling thiserror-impl v1.0.48 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Compiling pest v2.7.4 [INFO] [stderr] Compiling pest_meta v2.7.4 [INFO] [stderr] Compiling pest_generator v2.7.4 [INFO] [stderr] Compiling pest_derive v2.7.4 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling vcd_parser v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `multithreading` [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:504:23 [INFO] [stdout] | [INFO] [stdout] 504 | #[cfg(feature = "multithreading")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `multithreading` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `multithreading` [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:511:27 [INFO] [stdout] | [INFO] [stdout] 511 | #[cfg(not(feature = "multithreading"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `multithreading` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `multithreading` [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:504:23 [INFO] [stdout] | [INFO] [stdout] 504 | #[cfg(feature = "multithreading")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `multithreading` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `multithreading` [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:511:27 [INFO] [stdout] | [INFO] [stdout] 511 | #[cfg(not(feature = "multithreading"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `multithreading` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | let raw_pointer = Box::into_raw(signal_tc_pointer); [INFO] [stdout] | --------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 118 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 117 ~ [INFO] [stdout] 118 ~ Box::into_raw(signal_tc_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 138 | let raw_pointer = Box::into_raw(signal_duration_pointer); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 139 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 138 ~ [INFO] [stdout] 139 ~ Box::into_raw(signal_duration_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 155 | let raw_pointer = Box::into_raw(indexes_pointer); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 156 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 155 ~ [INFO] [stdout] 156 ~ Box::into_raw(indexes_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 200 | let raw_pointer = Box::into_raw(vcd_signal_pointer); [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 201 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 200 ~ [INFO] [stdout] 201 ~ Box::into_raw(vcd_signal_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(i32, i32)>` which implements the `Copy` trait [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:170:32 [INFO] [stdout] | [INFO] [stdout] 170 | let bus_index_option = (*c_vcd_signal).get_bus_index().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(*c_vcd_signal).get_bus_index()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `VCDVariableType` which implements the `Copy` trait [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:179:27 [INFO] [stdout] | [INFO] [stdout] 179 | let signal_type = (*c_vcd_signal).get_signal_type().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(*c_vcd_signal).get_signal_type()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 256 | let raw_pointer = Box::into_raw(vcd_scope_pointer); [INFO] [stdout] | --------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 257 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 256 ~ [INFO] [stdout] 257 ~ Box::into_raw(vcd_scope_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 307 | let raw_pointer = Box::into_raw(vcd_file_pointer); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 308 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 307 ~ [INFO] [stdout] 308 ~ Box::into_raw(vcd_file_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:380:9 [INFO] [stdout] | [INFO] [stdout] 379 | let raw_pointer = Box::into_raw(vec_res_pointer); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 380 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 379 ~ [INFO] [stdout] 380 ~ Box::into_raw(vec_res_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:347:17 [INFO] [stdout] | [INFO] [stdout] 346 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 347 | find_scope [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 346 ~ [INFO] [stdout] 347 ~ (find_scope_closure.closure)(&the_scope, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:346:63 [INFO] [stdout] | [INFO] [stdout] 346 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `the_scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 396 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 397 | find_scope [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 396 ~ [INFO] [stdout] 397 ~ (find_scope_closure.closure)(&the_scope, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:396:63 [INFO] [stdout] | [INFO] [stdout] 396 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `the_scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:422:17 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | --------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 422 | find_signal [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 421 ~ [INFO] [stdout] 422 ~ (find_signal_closure.closure)(&the_signal, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:421:65 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `the_signal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:421:78 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | ^^^^^^ help: change this to: `r_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:173:43 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:202:43 [INFO] [stdout] | [INFO] [stdout] 202 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 243 | pub closure: Box>, &str) -> Option>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:277:18 [INFO] [stdout] | [INFO] [stdout] 277 | pub closure: Box>, &str) -> Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | let raw_pointer = Box::into_raw(signal_tc_pointer); [INFO] [stdout] | --------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 118 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 117 ~ [INFO] [stdout] 118 ~ Box::into_raw(signal_tc_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 138 | let raw_pointer = Box::into_raw(signal_duration_pointer); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 139 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 138 ~ [INFO] [stdout] 139 ~ Box::into_raw(signal_duration_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:350:47 [INFO] [stdout] | [INFO] [stdout] 350 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 155 | let raw_pointer = Box::into_raw(indexes_pointer); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 156 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 155 ~ [INFO] [stdout] 156 ~ Box::into_raw(indexes_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 200 | let raw_pointer = Box::into_raw(vcd_signal_pointer); [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 201 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 200 ~ [INFO] [stdout] 201 ~ Box::into_raw(vcd_signal_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(i32, i32)>` which implements the `Copy` trait [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:170:32 [INFO] [stdout] | [INFO] [stdout] 170 | let bus_index_option = (*c_vcd_signal).get_bus_index().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(*c_vcd_signal).get_bus_index()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `VCDVariableType` which implements the `Copy` trait [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:179:27 [INFO] [stdout] | [INFO] [stdout] 179 | let signal_type = (*c_vcd_signal).get_signal_type().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(*c_vcd_signal).get_signal_type()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 256 | let raw_pointer = Box::into_raw(vcd_scope_pointer); [INFO] [stdout] | --------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 257 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 256 ~ [INFO] [stdout] 257 ~ Box::into_raw(vcd_scope_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:400:47 [INFO] [stdout] | [INFO] [stdout] 400 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 307 | let raw_pointer = Box::into_raw(vcd_file_pointer); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 308 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 307 ~ [INFO] [stdout] 308 ~ Box::into_raw(vcd_file_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:380:9 [INFO] [stdout] | [INFO] [stdout] 379 | let raw_pointer = Box::into_raw(vec_res_pointer); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 380 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 379 ~ [INFO] [stdout] 380 ~ Box::into_raw(vec_res_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:347:17 [INFO] [stdout] | [INFO] [stdout] 346 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 347 | find_scope [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 346 ~ [INFO] [stdout] 347 ~ (find_scope_closure.closure)(&the_scope, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:346:63 [INFO] [stdout] | [INFO] [stdout] 346 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `the_scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:493:9 [INFO] [stdout] | [INFO] [stdout] 493 | thread_pool: &ThreadPool, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thread_pool` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:525:17 [INFO] [stdout] | [INFO] [stdout] 525 | thread_pool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Bit` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / pub enum VCDValue { [INFO] [stdout] 26 | | BitScalar(VCDBit), [INFO] [stdout] 27 | | BitVector(Vec), [INFO] [stdout] 28 | | BitReal(f64), [INFO] [stdout] 29 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 396 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 397 | find_scope [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 396 ~ [INFO] [stdout] 397 ~ (find_scope_closure.closure)(&the_scope, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:396:63 [INFO] [stdout] | [INFO] [stdout] 396 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `the_scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:422:17 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | --------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 422 | find_signal [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 421 ~ [INFO] [stdout] 422 ~ (find_signal_closure.closure)(&the_signal, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:421:65 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `the_signal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:421:78 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | ^^^^^^ help: change this to: `r_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Scope` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / pub enum VCDScopeType { [INFO] [stdout] 175 | | ScopeBegin, [INFO] [stdout] 176 | | ScopeFork, [INFO] [stdout] 177 | | ScopeFunction, [INFO] [stdout] ... | [INFO] [stdout] 181 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:173:43 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:202:43 [INFO] [stdout] | [INFO] [stdout] 202 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | / if self.signal_values.contains_key(&signal_hash) { [INFO] [stdout] 358 | | let signal_vec = self.signal_values.get_mut(&signal_hash).unwrap(); [INFO] [stdout] 359 | | signal_vec.push_back(signal_value); [INFO] [stdout] 360 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 363 | | self.signal_values.insert(signal_hash, signal_vec); [INFO] [stdout] 364 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 243 | pub closure: Box>, &str) -> Option>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | return &self.signal_tc_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return &self.signal_tc_vec; [INFO] [stdout] 371 + &self.signal_tc_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | return &self.signal_duration_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 382 - return &self.signal_duration_vec; [INFO] [stdout] 382 + &self.signal_duration_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | return &mut self.vcd_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 - return &mut self.vcd_file; [INFO] [stdout] 403 + &mut self.vcd_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | return self.vcd_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 407 - return self.vcd_file; [INFO] [stdout] 407 + self.vcd_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:277:18 [INFO] [stdout] | [INFO] [stdout] 277 | pub closure: Box>, &str) -> Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:411:9 [INFO] [stdout] | [INFO] [stdout] 411 | return &mut self.scope_stack; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return &mut self.scope_stack; [INFO] [stdout] 411 + &mut self.scope_stack [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:414:9 [INFO] [stdout] | [INFO] [stdout] 414 | return self.scope_stack.is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 414 - return self.scope_stack.is_empty(); [INFO] [stdout] 414 + self.scope_stack.is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | return self.current_time; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 423 - return self.current_time; [INFO] [stdout] 423 + self.current_time [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:350:47 [INFO] [stdout] | [INFO] [stdout] 350 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:400:47 [INFO] [stdout] | [INFO] [stdout] 400 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:493:9 [INFO] [stdout] | [INFO] [stdout] 493 | thread_pool: &ThreadPool, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thread_pool` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:525:17 [INFO] [stdout] | [INFO] [stdout] 525 | thread_pool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Bit` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / pub enum VCDValue { [INFO] [stdout] 26 | | BitScalar(VCDBit), [INFO] [stdout] 27 | | BitVector(Vec), [INFO] [stdout] 28 | | BitReal(f64), [INFO] [stdout] 29 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Scope` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / pub enum VCDScopeType { [INFO] [stdout] 175 | | ScopeBegin, [INFO] [stdout] 176 | | ScopeFork, [INFO] [stdout] 177 | | ScopeFunction, [INFO] [stdout] ... | [INFO] [stdout] 181 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | / if self.signal_values.contains_key(&signal_hash) { [INFO] [stdout] 358 | | let signal_vec = self.signal_values.get_mut(&signal_hash).unwrap(); [INFO] [stdout] 359 | | signal_vec.push_back(signal_value); [INFO] [stdout] 360 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 363 | | self.signal_values.insert(signal_hash, signal_vec); [INFO] [stdout] 364 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | return &self.signal_tc_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return &self.signal_tc_vec; [INFO] [stdout] 371 + &self.signal_tc_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | return &self.signal_duration_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 382 - return &self.signal_duration_vec; [INFO] [stdout] 382 + &self.signal_duration_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | return &mut self.vcd_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 - return &mut self.vcd_file; [INFO] [stdout] 403 + &mut self.vcd_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | return self.vcd_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 407 - return self.vcd_file; [INFO] [stdout] 407 + self.vcd_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:411:9 [INFO] [stdout] | [INFO] [stdout] 411 | return &mut self.scope_stack; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return &mut self.scope_stack; [INFO] [stdout] 411 + &mut self.scope_stack [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:414:9 [INFO] [stdout] | [INFO] [stdout] 414 | return self.scope_stack.is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 414 - return self.scope_stack.is_empty(); [INFO] [stdout] 414 + self.scope_stack.is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | return self.current_time; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 423 - return self.current_time; [INFO] [stdout] 423 + self.current_time [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let mut inner_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/mod.rs:70:43 [INFO] [stdout] | [INFO] [stdout] 70 | new_scope.borrow_mut().set_scope_type(&scope_type); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `scope_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:107:39 [INFO] [stdout] | [INFO] [stdout] 107 | let mut slice_pairs = inner_pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `inner_pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:141:41 [INFO] [stdout] | [INFO] [stdout] 141 | let mut scalar_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:168:44 [INFO] [stdout] | [INFO] [stdout] 168 | let mut bitvector_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:202:39 [INFO] [stdout] | [INFO] [stdout] 202 | let mut real_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/vcd_parser/mod.rs:250:47 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn parse_vcd_file(vcd_file_path: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let mut inner_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/mod.rs:70:43 [INFO] [stdout] | [INFO] [stdout] 70 | new_scope.borrow_mut().set_scope_type(&scope_type); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `scope_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:107:39 [INFO] [stdout] | [INFO] [stdout] 107 | let mut slice_pairs = inner_pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `inner_pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:141:41 [INFO] [stdout] | [INFO] [stdout] 141 | let mut scalar_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:168:44 [INFO] [stdout] | [INFO] [stdout] 168 | let mut bitvector_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:202:39 [INFO] [stdout] | [INFO] [stdout] 202 | let mut real_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/vcd_parser/mod.rs:250:47 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn parse_vcd_file(vcd_file_path: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vcd_parser/mod.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | assert!(!parse_result_clone.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_result_clone.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `multithreading` [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:504:23 [INFO] [stdout] | [INFO] [stdout] 504 | #[cfg(feature = "multithreading")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `multithreading` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `multithreading` [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:511:27 [INFO] [stdout] | [INFO] [stdout] 511 | #[cfg(not(feature = "multithreading"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `multithreading` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `multithreading` [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:504:23 [INFO] [stdout] | [INFO] [stdout] 504 | #[cfg(feature = "multithreading")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `multithreading` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `multithreading` [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:511:27 [INFO] [stdout] | [INFO] [stdout] 511 | #[cfg(not(feature = "multithreading"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `multithreading` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | let raw_pointer = Box::into_raw(signal_tc_pointer); [INFO] [stdout] | --------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 118 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 117 ~ [INFO] [stdout] 118 ~ Box::into_raw(signal_tc_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 138 | let raw_pointer = Box::into_raw(signal_duration_pointer); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 139 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 138 ~ [INFO] [stdout] 139 ~ Box::into_raw(signal_duration_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 155 | let raw_pointer = Box::into_raw(indexes_pointer); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 156 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 155 ~ [INFO] [stdout] 156 ~ Box::into_raw(indexes_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 200 | let raw_pointer = Box::into_raw(vcd_signal_pointer); [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 201 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 200 ~ [INFO] [stdout] 201 ~ Box::into_raw(vcd_signal_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(i32, i32)>` which implements the `Copy` trait [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:170:32 [INFO] [stdout] | [INFO] [stdout] 170 | let bus_index_option = (*c_vcd_signal).get_bus_index().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(*c_vcd_signal).get_bus_index()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `VCDVariableType` which implements the `Copy` trait [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:179:27 [INFO] [stdout] | [INFO] [stdout] 179 | let signal_type = (*c_vcd_signal).get_signal_type().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(*c_vcd_signal).get_signal_type()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 256 | let raw_pointer = Box::into_raw(vcd_scope_pointer); [INFO] [stdout] | --------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 257 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 256 ~ [INFO] [stdout] 257 ~ Box::into_raw(vcd_scope_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 307 | let raw_pointer = Box::into_raw(vcd_file_pointer); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 308 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 307 ~ [INFO] [stdout] 308 ~ Box::into_raw(vcd_file_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:380:9 [INFO] [stdout] | [INFO] [stdout] 379 | let raw_pointer = Box::into_raw(vec_res_pointer); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 380 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 379 ~ [INFO] [stdout] 380 ~ Box::into_raw(vec_res_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:347:17 [INFO] [stdout] | [INFO] [stdout] 346 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 347 | find_scope [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 346 ~ [INFO] [stdout] 347 ~ (find_scope_closure.closure)(&the_scope, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:346:63 [INFO] [stdout] | [INFO] [stdout] 346 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `the_scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 396 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 397 | find_scope [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 396 ~ [INFO] [stdout] 397 ~ (find_scope_closure.closure)(&the_scope, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:396:63 [INFO] [stdout] | [INFO] [stdout] 396 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `the_scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:422:17 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | --------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 422 | find_signal [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 421 ~ [INFO] [stdout] 422 ~ (find_signal_closure.closure)(&the_signal, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:421:65 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `the_signal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:421:78 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | ^^^^^^ help: change this to: `r_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | let raw_pointer = Box::into_raw(signal_tc_pointer); [INFO] [stdout] | --------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 118 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 117 ~ [INFO] [stdout] 118 ~ Box::into_raw(signal_tc_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 138 | let raw_pointer = Box::into_raw(signal_duration_pointer); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 139 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 138 ~ [INFO] [stdout] 139 ~ Box::into_raw(signal_duration_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 155 | let raw_pointer = Box::into_raw(indexes_pointer); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 156 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 155 ~ [INFO] [stdout] 156 ~ Box::into_raw(indexes_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 200 | let raw_pointer = Box::into_raw(vcd_signal_pointer); [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 201 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 200 ~ [INFO] [stdout] 201 ~ Box::into_raw(vcd_signal_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:173:43 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option<(i32, i32)>` which implements the `Copy` trait [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:170:32 [INFO] [stdout] | [INFO] [stdout] 170 | let bus_index_option = (*c_vcd_signal).get_bus_index().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(*c_vcd_signal).get_bus_index()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `VCDVariableType` which implements the `Copy` trait [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:179:27 [INFO] [stdout] | [INFO] [stdout] 179 | let signal_type = (*c_vcd_signal).get_signal_type().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*(*c_vcd_signal).get_signal_type()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:202:43 [INFO] [stdout] | [INFO] [stdout] 202 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 256 | let raw_pointer = Box::into_raw(vcd_scope_pointer); [INFO] [stdout] | --------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 257 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 256 ~ [INFO] [stdout] 257 ~ Box::into_raw(vcd_scope_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 243 | pub closure: Box>, &str) -> Option>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 307 | let raw_pointer = Box::into_raw(vcd_file_pointer); [INFO] [stdout] | -------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 308 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 307 ~ [INFO] [stdout] 308 ~ Box::into_raw(vcd_file_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:277:18 [INFO] [stdout] | [INFO] [stdout] 277 | pub closure: Box>, &str) -> Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:380:9 [INFO] [stdout] | [INFO] [stdout] 379 | let raw_pointer = Box::into_raw(vec_res_pointer); [INFO] [stdout] | ------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 380 | raw_pointer [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 379 ~ [INFO] [stdout] 380 ~ Box::into_raw(vec_res_pointer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:347:17 [INFO] [stdout] | [INFO] [stdout] 346 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 347 | find_scope [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 346 ~ [INFO] [stdout] 347 ~ (find_scope_closure.closure)(&the_scope, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:346:63 [INFO] [stdout] | [INFO] [stdout] 346 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `the_scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:350:47 [INFO] [stdout] | [INFO] [stdout] 350 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:397:17 [INFO] [stdout] | [INFO] [stdout] 396 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ------------------------------------------------------------------ unnecessary `let` binding [INFO] [stdout] 397 | find_scope [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 396 ~ [INFO] [stdout] 397 ~ (find_scope_closure.closure)(&the_scope, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:396:63 [INFO] [stdout] | [INFO] [stdout] 396 | let find_scope = (find_scope_closure.closure)(&the_scope, &r_str); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `the_scope` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:422:17 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | --------------------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 422 | find_signal [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 421 ~ [INFO] [stdout] 422 ~ (find_signal_closure.closure)(&the_signal, &r_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:421:65 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `the_signal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/vcd_c_api.rs:421:78 [INFO] [stdout] | [INFO] [stdout] 421 | let find_signal = (find_signal_closure.closure)(&the_signal, &r_str); [INFO] [stdout] | ^^^^^^ help: change this to: `r_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:400:47 [INFO] [stdout] | [INFO] [stdout] 400 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:493:9 [INFO] [stdout] | [INFO] [stdout] 493 | thread_pool: &ThreadPool, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thread_pool` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:525:17 [INFO] [stdout] | [INFO] [stdout] 525 | thread_pool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Bit` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / pub enum VCDValue { [INFO] [stdout] 26 | | BitScalar(VCDBit), [INFO] [stdout] 27 | | BitVector(Vec), [INFO] [stdout] 28 | | BitReal(f64), [INFO] [stdout] 29 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:173:43 [INFO] [stdout] | [INFO] [stdout] 173 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] = note: `#[warn(clippy::needless_option_as_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:202:43 [INFO] [stdout] | [INFO] [stdout] 202 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:243:18 [INFO] [stdout] | [INFO] [stdout] 243 | pub closure: Box>, &str) -> Option>>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Scope` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / pub enum VCDScopeType { [INFO] [stdout] 175 | | ScopeBegin, [INFO] [stdout] 176 | | ScopeFork, [INFO] [stdout] 177 | | ScopeFunction, [INFO] [stdout] ... | [INFO] [stdout] 181 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:277:18 [INFO] [stdout] | [INFO] [stdout] 277 | pub closure: Box>, &str) -> Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:350:47 [INFO] [stdout] | [INFO] [stdout] 350 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | / if self.signal_values.contains_key(&signal_hash) { [INFO] [stdout] 358 | | let signal_vec = self.signal_values.get_mut(&signal_hash).unwrap(); [INFO] [stdout] 359 | | signal_vec.push_back(signal_value); [INFO] [stdout] 360 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 363 | | self.signal_values.insert(signal_hash, signal_vec); [INFO] [stdout] 364 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | return &self.signal_tc_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return &self.signal_tc_vec; [INFO] [stdout] 371 + &self.signal_tc_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | return &self.signal_duration_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 382 - return &self.signal_duration_vec; [INFO] [stdout] 382 + &self.signal_duration_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | return &mut self.vcd_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 - return &mut self.vcd_file; [INFO] [stdout] 403 + &mut self.vcd_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: derefed type is same as origin [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:400:47 [INFO] [stdout] | [INFO] [stdout] 400 | if let Some(signal_time_values) = signal_time_values.as_deref() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `signal_time_values` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_option_as_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | return self.vcd_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 407 - return self.vcd_file; [INFO] [stdout] 407 + self.vcd_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:411:9 [INFO] [stdout] | [INFO] [stdout] 411 | return &mut self.scope_stack; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return &mut self.scope_stack; [INFO] [stdout] 411 + &mut self.scope_stack [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:414:9 [INFO] [stdout] | [INFO] [stdout] 414 | return self.scope_stack.is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 414 - return self.scope_stack.is_empty(); [INFO] [stdout] 414 + self.scope_stack.is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | return self.current_time; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 423 - return self.current_time; [INFO] [stdout] 423 + self.current_time [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:493:9 [INFO] [stdout] | [INFO] [stdout] 493 | thread_pool: &ThreadPool, [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_thread_pool` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/vcd_parser/vcd_calc_tc_sp.rs:525:17 [INFO] [stdout] | [INFO] [stdout] 525 | thread_pool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Bit` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:25:1 [INFO] [stdout] | [INFO] [stdout] 25 | / pub enum VCDValue { [INFO] [stdout] 26 | | BitScalar(VCDBit), [INFO] [stdout] 27 | | BitVector(Vec), [INFO] [stdout] 28 | | BitReal(f64), [INFO] [stdout] 29 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Scope` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / pub enum VCDScopeType { [INFO] [stdout] 175 | | ScopeBegin, [INFO] [stdout] 176 | | ScopeFork, [INFO] [stdout] 177 | | ScopeFunction, [INFO] [stdout] ... | [INFO] [stdout] 181 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:357:9 [INFO] [stdout] | [INFO] [stdout] 357 | / if self.signal_values.contains_key(&signal_hash) { [INFO] [stdout] 358 | | let signal_vec = self.signal_values.get_mut(&signal_hash).unwrap(); [INFO] [stdout] 359 | | signal_vec.push_back(signal_value); [INFO] [stdout] 360 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 363 | | self.signal_values.insert(signal_hash, signal_vec); [INFO] [stdout] 364 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: consider using the `Entry` API: https://doc.rust-lang.org/std/collections/struct.HashMap.html#entry-api [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:371:9 [INFO] [stdout] | [INFO] [stdout] 371 | return &self.signal_tc_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 371 - return &self.signal_tc_vec; [INFO] [stdout] 371 + &self.signal_tc_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 382 | return &self.signal_duration_vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 382 - return &self.signal_duration_vec; [INFO] [stdout] 382 + &self.signal_duration_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 403 | return &mut self.vcd_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 403 - return &mut self.vcd_file; [INFO] [stdout] 403 + &mut self.vcd_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:407:9 [INFO] [stdout] | [INFO] [stdout] 407 | return self.vcd_file; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 407 - return self.vcd_file; [INFO] [stdout] 407 + self.vcd_file [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:411:9 [INFO] [stdout] | [INFO] [stdout] 411 | return &mut self.scope_stack; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return &mut self.scope_stack; [INFO] [stdout] 411 + &mut self.scope_stack [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:414:9 [INFO] [stdout] | [INFO] [stdout] 414 | return self.scope_stack.is_empty(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 414 - return self.scope_stack.is_empty(); [INFO] [stdout] 414 + self.scope_stack.is_empty() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vcd_parser/vcd_data.rs:423:9 [INFO] [stdout] | [INFO] [stdout] 423 | return self.current_time; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 423 - return self.current_time; [INFO] [stdout] 423 + self.current_time [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let mut inner_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/mod.rs:70:43 [INFO] [stdout] | [INFO] [stdout] 70 | new_scope.borrow_mut().set_scope_type(&scope_type); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `scope_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:107:39 [INFO] [stdout] | [INFO] [stdout] 107 | let mut slice_pairs = inner_pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `inner_pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:141:41 [INFO] [stdout] | [INFO] [stdout] 141 | let mut scalar_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:168:44 [INFO] [stdout] | [INFO] [stdout] 168 | let mut bitvector_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:202:39 [INFO] [stdout] | [INFO] [stdout] 202 | let mut real_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/vcd_parser/mod.rs:250:47 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn parse_vcd_file(vcd_file_path: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let mut inner_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/vcd_parser/mod.rs:70:43 [INFO] [stdout] | [INFO] [stdout] 70 | new_scope.borrow_mut().set_scope_type(&scope_type); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `scope_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:107:39 [INFO] [stdout] | [INFO] [stdout] 107 | let mut slice_pairs = inner_pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `inner_pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:141:41 [INFO] [stdout] | [INFO] [stdout] 141 | let mut scalar_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:168:44 [INFO] [stdout] | [INFO] [stdout] 168 | let mut bitvector_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `pest::iterators::Pairs<'_, vcd_parser::Rule>` [INFO] [stdout] --> src/vcd_parser/mod.rs:202:39 [INFO] [stdout] | [INFO] [stdout] 202 | let mut real_value_change_pairs = pair.into_inner().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `pair.into_inner()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/vcd_parser/mod.rs:250:47 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn parse_vcd_file(vcd_file_path: &str) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 184 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `pest::error::Error`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/vcd_parser/mod.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | assert!(!parse_result_clone.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_result_clone.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.31s [INFO] running `Command { std: "docker" "inspect" "395ec86b1f4cf2f3202214365aab3f43376e2bb726735cda7aacd84ab73514f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "395ec86b1f4cf2f3202214365aab3f43376e2bb726735cda7aacd84ab73514f3", kill_on_drop: false }` [INFO] [stdout] 395ec86b1f4cf2f3202214365aab3f43376e2bb726735cda7aacd84ab73514f3