[INFO] fetching crate v_escape_derive 0.9.1... [INFO] linting v_escape_derive-0.9.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate v_escape_derive 0.9.1 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate v_escape_derive 0.9.1 [INFO] finished tweaking crates.io crate v_escape_derive 0.9.1 [INFO] tweaked toml for crates.io crate v_escape_derive 0.9.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate v_escape_derive 0.9.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.117) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 557de1f8c46bf7ddf538ff0e17909822200b94f95d029ca3a6273c873465a990 [INFO] running `Command { std: "docker" "start" "-a" "557de1f8c46bf7ddf538ff0e17909822200b94f95d029ca3a6273c873465a990", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "557de1f8c46bf7ddf538ff0e17909822200b94f95d029ca3a6273c873465a990", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "557de1f8c46bf7ddf538ff0e17909822200b94f95d029ca3a6273c873465a990", kill_on_drop: false }` [INFO] [stdout] 557de1f8c46bf7ddf538ff0e17909822200b94f95d029ca3a6273c873465a990 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 54c74f89f019edd9170eecf88c1bef2b3d0221987ecfd3e3b28782b8bf60abe2 [INFO] running `Command { std: "docker" "start" "-a" "54c74f89f019edd9170eecf88c1bef2b3d0221987ecfd3e3b28782b8bf60abe2", kill_on_drop: false }` [INFO] [stderr] Checking proc-macro2 v1.0.106 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking quote v1.0.45 [INFO] [stderr] Checking v_escape_derive v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/generator.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | d.sort_unstable_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 201 - d.sort_unstable_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 201 + d.sort_unstable_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | assert!(!(p1.ch == p2.ch), "{:?} and {:?} are repeated", p1, p2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(p1.ch != p2.ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/lib.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | match n < (std::i8::MAX as u8) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 84 - match n < (std::i8::MAX as u8) { [INFO] [stdout] 84 + match n < (i8::MAX as u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/generator.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(pairs: &[Pair], simd: bool, avx: bool) -> Generator { [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(pairs: &[Pair], simd: bool, avx: bool) -> Generator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/generator.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | d.sort_unstable_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 201 - d.sort_unstable_by(|a, b| b.1.cmp(&a.1)); [INFO] [stdout] 201 + d.sort_unstable_by_key(|b| std::cmp::Reverse(b.1)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | assert!(!(p1.ch == p2.ch), "{:?} and {:?} are repeated", p1, p2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `(p1.ch != p2.ch)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/lib.rs:84:20 [INFO] [stdout] | [INFO] [stdout] 84 | match n < (std::i8::MAX as u8) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 84 - match n < (std::i8::MAX as u8) { [INFO] [stdout] 84 + match n < (i8::MAX as u8) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/generator.rs:19:23 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(pairs: &[Pair], simd: bool, avx: bool) -> Generator { [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(pairs: &[Pair], simd: bool, avx: bool) -> Generator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.65s [INFO] running `Command { std: "docker" "inspect" "54c74f89f019edd9170eecf88c1bef2b3d0221987ecfd3e3b28782b8bf60abe2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54c74f89f019edd9170eecf88c1bef2b3d0221987ecfd3e3b28782b8bf60abe2", kill_on_drop: false }` [INFO] [stdout] 54c74f89f019edd9170eecf88c1bef2b3d0221987ecfd3e3b28782b8bf60abe2