[INFO] fetching crate v-storage 0.1.3... [INFO] linting v-storage-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate v-storage 0.1.3 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate v-storage 0.1.3 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate v-storage 0.1.3 [INFO] tweaked toml for crates.io crate v-storage 0.1.3 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate v-storage 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate v-storage 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rusty_tarantool v0.3.0 [INFO] [stderr] Downloaded chrono-tz v0.5.3 [INFO] [stderr] Downloaded rmpv v1.3.0 [INFO] [stderr] Downloaded v_authorization v0.4.0 [INFO] [stderr] Downloaded lmdb-rs-m v0.8.1 [INFO] [stderr] Downloaded v-individual-model v0.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6536d136883a8b102d3257a11bb3e46e9d540943638a2e72bc9c80cb988d0601 [INFO] running `Command { std: "docker" "start" "-a" "6536d136883a8b102d3257a11bb3e46e9d540943638a2e72bc9c80cb988d0601", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6536d136883a8b102d3257a11bb3e46e9d540943638a2e72bc9c80cb988d0601", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6536d136883a8b102d3257a11bb3e46e9d540943638a2e72bc9c80cb988d0601", kill_on_drop: false }` [INFO] [stdout] 6536d136883a8b102d3257a11bb3e46e9d540943638a2e72bc9c80cb988d0601 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f321272c045ac6e01d616403a33360951ddf9dcde83c9e3abe3cfeccb8fec934 [INFO] running `Command { std: "docker" "start" "-a" "f321272c045ac6e01d616403a33360951ddf9dcde83c9e3abe3cfeccb8fec934", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.20 [INFO] [stderr] Compiling find-msvc-tools v0.1.4 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling rust_decimal v1.36.0 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Checking oxiri v0.1.1 [INFO] [stderr] Checking rio_api v0.5.3 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Checking rio_turtle v0.5.3 [INFO] [stderr] Compiling cc v1.2.43 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling syn v2.0.108 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Checking v-cbr-codec v0.7.1 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling liblmdb-sys-m v0.2.4 [INFO] [stderr] Compiling nng-sys v1.4.0-rc.0 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Compiling chrono-tz v0.5.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking lmdb-rs-m v0.8.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking v-individual-model v0.2.1 [INFO] [stderr] Checking v_authorization v0.4.0 [INFO] [stderr] Checking nng v1.0.1 [INFO] [stderr] Checking v-storage v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lmdb_storage.rs:394:25 [INFO] [stdout] | [INFO] [stdout] 394 | / if let MdbError::Other(c, _) = e { [INFO] [stdout] 395 | | if c == -30792 && grow_db(db_env, path) { [INFO] [stdout] 396 | | return remove_from_lmdb(db_env, db_handle, key, path); [INFO] [stdout] 397 | | } [INFO] [stdout] 398 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 394 ~ if let MdbError::Other(c, _) = e [INFO] [stdout] 395 ~ && c == -30792 && grow_db(db_env, path) { [INFO] [stdout] 396 | return remove_from_lmdb(db_env, db_handle, key, path); [INFO] [stdout] 397 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lmdb_storage.rs:433:25 [INFO] [stdout] | [INFO] [stdout] 433 | / if let MdbError::Other(c, _) = e { [INFO] [stdout] 434 | | if c == -30792 && grow_db(db_env, path) { [INFO] [stdout] 435 | | return put_kv_lmdb(db_env, db_handle, key, val, path); [INFO] [stdout] 436 | | } [INFO] [stdout] 437 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 433 ~ if let MdbError::Other(c, _) = e [INFO] [stdout] 434 ~ && c == -30792 && grow_db(db_env, path) { [INFO] [stdout] 435 | return put_kv_lmdb(db_env, db_handle, key, val, path); [INFO] [stdout] 436 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/vstorage.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | / impl Default for VStorageEnum { [INFO] [stdout] 30 | | fn default() -> Self { [INFO] [stdout] 31 | | VStorageEnum::None [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 20 + #[derive(Default)] [INFO] [stdout] 21 | pub enum VStorageEnum { [INFO] [stdout] 22 | Memory(crate::memory_storage::MemoryStorage), [INFO] [stdout] ... [INFO] [stdout] 26 | Tarantool(crate::tt_storage::TTStorage), [INFO] [stdout] 27 ~ #[default] [INFO] [stdout] 28 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `memory_storage` [INFO] [stdout] --> examples/factory_patterns.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let memory_storage = StorageBuilder::new() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_memory_storage` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `generic_memory` [INFO] [stdout] --> examples/factory_patterns.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let generic_memory = StorageBuilder::new() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_generic_memory` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `provider_generic_lmdb` [INFO] [stdout] --> examples/factory_patterns.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 156 | let provider_generic_lmdb = StorageProvider::lmdb_generic("/tmp/generic_provider", StorageMode::ReadOnly, None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_provider_generic_lmdb` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `provider_generic_remote` [INFO] [stdout] --> examples/factory_patterns.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | let provider_generic_remote = StorageProvider::remote_generic("127.0.0.1:8080"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_provider_generic_remote` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `inner_storage` [INFO] [stdout] --> examples/storage_types.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | if let Some(inner_storage) = generic_storage.storage() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_inner_storage` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/integration_tests.rs:63:17 [INFO] [stdout] | [INFO] [stdout] 63 | assert!(!provider_storage.get_v(StorageId::Individuals, "nonexistent").is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `provider_storage.get_v(StorageId::Individuals, "nonexistent").is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lmdb_storage.rs:394:25 [INFO] [stdout] | [INFO] [stdout] 394 | / if let MdbError::Other(c, _) = e { [INFO] [stdout] 395 | | if c == -30792 && grow_db(db_env, path) { [INFO] [stdout] 396 | | return remove_from_lmdb(db_env, db_handle, key, path); [INFO] [stdout] 397 | | } [INFO] [stdout] 398 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 394 ~ if let MdbError::Other(c, _) = e [INFO] [stdout] 395 ~ && c == -30792 && grow_db(db_env, path) { [INFO] [stdout] 396 | return remove_from_lmdb(db_env, db_handle, key, path); [INFO] [stdout] 397 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lmdb_storage.rs:433:25 [INFO] [stdout] | [INFO] [stdout] 433 | / if let MdbError::Other(c, _) = e { [INFO] [stdout] 434 | | if c == -30792 && grow_db(db_env, path) { [INFO] [stdout] 435 | | return put_kv_lmdb(db_env, db_handle, key, val, path); [INFO] [stdout] 436 | | } [INFO] [stdout] 437 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 433 ~ if let MdbError::Other(c, _) = e [INFO] [stdout] 434 ~ && c == -30792 && grow_db(db_env, path) { [INFO] [stdout] 435 | return put_kv_lmdb(db_env, db_handle, key, val, path); [INFO] [stdout] 436 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/vstorage.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | / impl Default for VStorageEnum { [INFO] [stdout] 30 | | fn default() -> Self { [INFO] [stdout] 31 | | VStorageEnum::None [INFO] [stdout] 32 | | } [INFO] [stdout] 33 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 20 + #[derive(Default)] [INFO] [stdout] 21 | pub enum VStorageEnum { [INFO] [stdout] 22 | Memory(crate::memory_storage::MemoryStorage), [INFO] [stdout] ... [INFO] [stdout] 26 | Tarantool(crate::tt_storage::TTStorage), [INFO] [stdout] 27 ~ #[default] [INFO] [stdout] 28 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.92s [INFO] running `Command { std: "docker" "inspect" "f321272c045ac6e01d616403a33360951ddf9dcde83c9e3abe3cfeccb8fec934", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f321272c045ac6e01d616403a33360951ddf9dcde83c9e3abe3cfeccb8fec934", kill_on_drop: false }` [INFO] [stdout] f321272c045ac6e01d616403a33360951ddf9dcde83c9e3abe3cfeccb8fec934