[INFO] fetching crate unsafe-unicorn 0.0.1... [INFO] linting unsafe-unicorn-0.0.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate unsafe-unicorn 0.0.1 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate unsafe-unicorn 0.0.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate unsafe-unicorn 0.0.1 [INFO] tweaked toml for crates.io crate unsafe-unicorn 0.0.1 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate unsafe-unicorn 0.0.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 58 packages to latest compatible versions [INFO] [stderr] Adding git2 v0.6.11 (available: v0.20.4) [INFO] [stderr] Adding lazy_static v0.2.11 (available: v1.5.0) [INFO] [stderr] Adding prettytable-rs v0.6.7 (available: v0.10.0) [INFO] [stderr] Adding regex v0.2.11 (available: v1.12.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded git2 v0.6.11 [INFO] [stderr] Downloaded memchr v1.0.2 [INFO] [stderr] Downloaded libgit2-sys v0.6.19 [INFO] [stderr] Downloaded prettytable-rs v0.6.7 [INFO] [stderr] Downloaded csv v0.15.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b81194589af00e3181c5cd222f5daf8718725e297997c0d04d8283ec86e1fa0d [INFO] running `Command { std: "docker" "start" "-a" "b81194589af00e3181c5cd222f5daf8718725e297997c0d04d8283ec86e1fa0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b81194589af00e3181c5cd222f5daf8718725e297997c0d04d8283ec86e1fa0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b81194589af00e3181c5cd222f5daf8718725e297997c0d04d8283ec86e1fa0d", kill_on_drop: false }` [INFO] [stdout] b81194589af00e3181c5cd222f5daf8718725e297997c0d04d8283ec86e1fa0d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fc2a65a1baf0d7980b47591ab547b863a1324d07763a499d4a440a845a0a3455 [INFO] running `Command { std: "docker" "start" "-a" "fc2a65a1baf0d7980b47591ab547b863a1324d07763a499d4a440a845a0a3455", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Compiling libz-sys v1.1.25 [INFO] [stderr] Compiling curl-sys v0.4.86+curl-8.19.0 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking openssl-sys v0.9.112 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking unsafe-unicorn v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lib.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | /// exclude tests etc from analysis [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/lib.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / lazy_static!{ [INFO] [stdout] 18 | | static ref REGEXES: RegexSet = RegexSet::new(&[ [INFO] [stdout] 19 | | r"```", // block comment [INFO] [stdout] 20 | | r"^//|^\s/\*|^\s\*|^\s\*/", //comment [INFO] [stdout] ... | [INFO] [stdout] 26 | | ]).unwrap(); [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/lib.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / lazy_static!{ [INFO] [stdout] 31 | | static ref EXCLUDE: Vec<&'static str> = vec!( [INFO] [stdout] 32 | | ".git", [INFO] [stdout] 33 | | "tests", [INFO] [stdout] ... | [INFO] [stdout] 36 | | ); [INFO] [stdout] 37 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:18:48 [INFO] [stdout] | [INFO] [stdout] 18 | static ref REGEXES: RegexSet = RegexSet::new(&[ [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 19 | | r"```", // block comment [INFO] [stdout] 20 | | r"^//|^\s/\*|^\s\*|^\s\*/", //comment [INFO] [stdout] 21 | | r"\s*fn\s+[a-zA-Z_]*", //function [INFO] [stdout] ... | [INFO] [stdout] 25 | | r"panic", //panic [INFO] [stdout] 26 | | ]).unwrap(); [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 ~ static ref REGEXES: RegexSet = RegexSet::new([ [INFO] [stdout] 19 + r"```", // block comment [INFO] [stdout] 20 + r"^//|^\s/\*|^\s\*|^\s\*/", //comment [INFO] [stdout] 21 + r"\s*fn\s+[a-zA-Z_]*", //function [INFO] [stdout] 22 + r"\s*unsafe impl.*for.*", //unsafe impl [INFO] [stdout] 23 + r"\s*unsafe\s*\{.*\}", //unsafe one liner [INFO] [stdout] 24 + r".*unsafe\s*\{", //more unsafe [INFO] [stdout] 25 + r"panic", //panic [INFO] [stdout] 26 ~ ]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Cloc` [INFO] [stdout] --> src/lib.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / pub fn new() -> Cloc { [INFO] [stdout] 60 | | Cloc { [INFO] [stdout] 61 | | verbose: ClocVerbosity::Crate, [INFO] [stdout] 62 | | stats: vec!(), [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for Cloc { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cloc` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/lib.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:90:52 [INFO] [stdout] | [INFO] [stdout] 90 | subdirs.push((dir.to_owned(), fs::read_dir(&Path::new(dir))?)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `Path::new(dir)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/lib.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | let (dir_name, paths) = subdirs.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 92 ~ while let Some((dir_name, paths)) = subdirs.pop(){ [INFO] [stdout] 93 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/lib.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 166 - write!(f, "\n")?; [INFO] [stdout] 166 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/lib.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 175 - write!(f, "\n")?; [INFO] [stdout] 175 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | !(self.total_fns > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.total_fns <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:279:35 [INFO] [stdout] | [INFO] [stdout] 279 | subdirs.push(fs::read_dir(&Path::new(dir)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `Path::new(dir)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:331:16 [INFO] [stdout] | [INFO] [stdout] 331 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking git2 v0.6.11 [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lib.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | /// exclude tests etc from analysis [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/lib.rs:17:1 [INFO] [stdout] | [INFO] [stdout] 17 | / lazy_static!{ [INFO] [stdout] 18 | | static ref REGEXES: RegexSet = RegexSet::new(&[ [INFO] [stdout] 19 | | r"```", // block comment [INFO] [stdout] 20 | | r"^//|^\s/\*|^\s\*|^\s\*/", //comment [INFO] [stdout] ... | [INFO] [stdout] 26 | | ]).unwrap(); [INFO] [stdout] 27 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/lib.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / lazy_static!{ [INFO] [stdout] 31 | | static ref EXCLUDE: Vec<&'static str> = vec!( [INFO] [stdout] 32 | | ".git", [INFO] [stdout] 33 | | "tests", [INFO] [stdout] ... | [INFO] [stdout] 36 | | ); [INFO] [stdout] 37 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:18:48 [INFO] [stdout] | [INFO] [stdout] 18 | static ref REGEXES: RegexSet = RegexSet::new(&[ [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 19 | | r"```", // block comment [INFO] [stdout] 20 | | r"^//|^\s/\*|^\s\*|^\s\*/", //comment [INFO] [stdout] 21 | | r"\s*fn\s+[a-zA-Z_]*", //function [INFO] [stdout] ... | [INFO] [stdout] 25 | | r"panic", //panic [INFO] [stdout] 26 | | ]).unwrap(); [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 18 ~ static ref REGEXES: RegexSet = RegexSet::new([ [INFO] [stdout] 19 + r"```", // block comment [INFO] [stdout] 20 + r"^//|^\s/\*|^\s\*|^\s\*/", //comment [INFO] [stdout] 21 + r"\s*fn\s+[a-zA-Z_]*", //function [INFO] [stdout] 22 + r"\s*unsafe impl.*for.*", //unsafe impl [INFO] [stdout] 23 + r"\s*unsafe\s*\{.*\}", //unsafe one liner [INFO] [stdout] 24 + r".*unsafe\s*\{", //more unsafe [INFO] [stdout] 25 + r"panic", //panic [INFO] [stdout] 26 ~ ]).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Cloc` [INFO] [stdout] --> src/lib.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | / pub fn new() -> Cloc { [INFO] [stdout] 60 | | Cloc { [INFO] [stdout] 61 | | verbose: ClocVerbosity::Crate, [INFO] [stdout] 62 | | stats: vec!(), [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 58 + impl Default for Cloc { [INFO] [stdout] 59 + fn default() -> Self { [INFO] [stdout] 60 + Self::new() [INFO] [stdout] 61 + } [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Cloc` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/lib.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:90:52 [INFO] [stdout] | [INFO] [stdout] 90 | subdirs.push((dir.to_owned(), fs::read_dir(&Path::new(dir))?)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `Path::new(dir)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to pop elements from a `Vec` in a loop [INFO] [stdout] --> src/lib.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 93 | let (dir_name, paths) = subdirs.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_while_let_some [INFO] [stdout] = note: `#[warn(clippy::manual_while_let_some)]` on by default [INFO] [stdout] help: consider using a `while..let` loop [INFO] [stdout] | [INFO] [stdout] 92 ~ while let Some((dir_name, paths)) = subdirs.pop(){ [INFO] [stdout] 93 ~ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/lib.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 166 - write!(f, "\n")?; [INFO] [stdout] 166 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/lib.rs:175:13 [INFO] [stdout] | [INFO] [stdout] 175 | write!(f, "\n")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 175 - write!(f, "\n")?; [INFO] [stdout] 175 + writeln!(f)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | !(self.total_fns > 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.total_fns <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/lib.rs:279:35 [INFO] [stdout] | [INFO] [stdout] 279 | subdirs.push(fs::read_dir(&Path::new(dir)).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `Path::new(dir)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:331:16 [INFO] [stdout] | [INFO] [stdout] 331 | if line.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.14s [INFO] running `Command { std: "docker" "inspect" "fc2a65a1baf0d7980b47591ab547b863a1324d07763a499d4a440a845a0a3455", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc2a65a1baf0d7980b47591ab547b863a1324d07763a499d4a440a845a0a3455", kill_on_drop: false }` [INFO] [stdout] fc2a65a1baf0d7980b47591ab547b863a1324d07763a499d4a440a845a0a3455