[INFO] fetching crate unitrix 0.0.4... [INFO] linting unitrix-0.0.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate unitrix 0.0.4 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate unitrix 0.0.4 [INFO] finished tweaking crates.io crate unitrix 0.0.4 [INFO] tweaked toml for crates.io crate unitrix 0.0.4 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate unitrix 0.0.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate unitrix 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30374d396fb8b965a402b9d16ded2ca563d5deae79880369c5f8cdc6c8e82603 [INFO] running `Command { std: "docker" "start" "-a" "30374d396fb8b965a402b9d16ded2ca563d5deae79880369c5f8cdc6c8e82603", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30374d396fb8b965a402b9d16ded2ca563d5deae79880369c5f8cdc6c8e82603", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30374d396fb8b965a402b9d16ded2ca563d5deae79880369c5f8cdc6c8e82603", kill_on_drop: false }` [INFO] [stdout] 30374d396fb8b965a402b9d16ded2ca563d5deae79880369c5f8cdc6c8e82603 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c0d2e6afa892875107bafb72ba049bc352d312815333504d5cdad19a13c2a58 [INFO] running `Command { std: "docker" "start" "-a" "4c0d2e6afa892875107bafb72ba049bc352d312815333504d5cdad19a13c2a58", kill_on_drop: false }` [INFO] [stderr] Checking unitrix v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/sealed.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// 密封模块(Sealed)限制 trait 实现,保证 API 稳定性 [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | /// 密封 trait,防止外部实现 [INFO] [stdout] 4 | pub trait Sealed {} [INFO] [stdout] | ---------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// 密封模块(Sealed)限制 trait 实现,保证 API 稳定性 [INFO] [stdout] 1 + //! 密封模块(Sealed)限制 trait 实现,保证 API 稳定性 [INFO] [stdout] | [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 2 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/sealed.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /// 密封模块(Sealed)限制 trait 实现,保证 API 稳定性 [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | /// 密封 trait,防止外部实现 [INFO] [stdout] 4 | pub trait Sealed {} [INFO] [stdout] | ---------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 - /// 密封模块(Sealed)限制 trait 实现,保证 API 稳定性 [INFO] [stdout] 1 + //! 密封模块(Sealed)限制 trait 实现,保证 API 稳定性 [INFO] [stdout] | [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 2 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/constant/add.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / /// 说明:有进位,说明有低位数,目前B1已经被P1替换,本位NonZero [INFO] [stdout] 25 | | [INFO] [stdout] | |_^ [INFO] [stdout] 26 | pub trait AddWithCarry {// NonZero [INFO] [stdout] | ---------------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/constant/add.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / /// 说明:有进位,说明有低位数,目前B1已经被P1替换,本位NonZero [INFO] [stdout] 25 | | [INFO] [stdout] | |_^ [INFO] [stdout] 26 | pub trait AddWithCarry {// NonZero [INFO] [stdout] | ---------------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/constant/standardization.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / /// Converts B1 to P1 when higher bit H is Z0 [INFO] [stdout] 21 | | [INFO] [stdout] | |_^ [INFO] [stdout] 22 | pub trait IfB1 { [INFO] [stdout] | -------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/constant/standardization.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / /// Converts B1 to P1 when higher bit H is Z0 [INFO] [stdout] 21 | | [INFO] [stdout] | |_^ [INFO] [stdout] 22 | pub trait IfB1 { [INFO] [stdout] | -------------- the comment documents this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/variable.rs:170:1 [INFO] [stdout] | [INFO] [stdout] 170 | / /// 实现 Var 与常量的除法运算(部分实现) [INFO] [stdout] 171 | | [INFO] [stdout] 172 | | /// V / 0 未实现 [INFO] [stdout] 173 | | [INFO] [stdout] | |_^ [INFO] [stdout] 174 | /// V / 1 = V [INFO] [stdout] 175 | impl Div for Var { [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the documentation should include the empty lines include them in the comment [INFO] [stdout] | [INFO] [stdout] 171 + /// [INFO] [stdout] 172 | /// V / 0 未实现 [INFO] [stdout] 173 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/variable.rs:170:1 [INFO] [stdout] | [INFO] [stdout] 170 | / /// 实现 Var 与常量的除法运算(部分实现) [INFO] [stdout] 171 | | [INFO] [stdout] 172 | | /// V / 0 未实现 [INFO] [stdout] 173 | | [INFO] [stdout] | |_^ [INFO] [stdout] 174 | /// V / 1 = V [INFO] [stdout] 175 | impl Div for Var { [INFO] [stdout] | - the comment documents this implementation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the documentation should include the empty lines include them in the comment [INFO] [stdout] | [INFO] [stdout] 171 + /// [INFO] [stdout] 172 | /// V / 0 未实现 [INFO] [stdout] 173 + /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Symbol` is never used [INFO] [stdout] --> src/quantity/unitary.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Symbol: Unitary { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DisplayWrapper` is never constructed [INFO] [stdout] --> src/quantity/unitary.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct DisplayWrapper(pub T); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `+` in `Mul` impl [INFO] [stdout] --> src/constant/mul.rs:96:11 [INFO] [stdout] | [INFO] [stdout] 96 | i + B0::new() // I + B0 [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stdout] = note: `#[warn(clippy::suspicious_arithmetic_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `Symbol` is never used [INFO] [stdout] --> src/quantity/unitary.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait Symbol: Unitary { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DisplayWrapper` is never constructed [INFO] [stdout] --> src/quantity/unitary.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct DisplayWrapper(pub T); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/null.rs:19:20 [INFO] [stdout] | [INFO] [stdout] 19 | assert_eq!(Null::default(), Null); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 19 - assert_eq!(Null::default(), Null); [INFO] [stdout] 19 + assert_eq!(Null, Null); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/null.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | assert!(!(Null < Null)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(Null >= Null)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/null.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 29 | assert!(!(Null > Null)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `(Null <= Null)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Prefix` [INFO] [stdout] --> src/quantity/prefix.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Self { [INFO] [stdout] 23 | | Prefix(PhantomData) [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 19 + impl Default for Prefix { [INFO] [stdout] 20 + fn default() -> Self { [INFO] [stdout] 21 + Self::new() [INFO] [stdout] 22 + } [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/quantity/dimension.rs:78:29 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn pow(self) -> Dimension< [INFO] [stdout] | _____________________________^ [INFO] [stdout] 79 | | Prod, [INFO] [stdout] 80 | | Prod, [INFO] [stdout] 81 | | Prod, [INFO] [stdout] ... | [INFO] [stdout] 85 | | Prod, [INFO] [stdout] 86 | | > [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: suspicious use of `+` in `Mul` impl [INFO] [stdout] --> src/constant/mul.rs:96:11 [INFO] [stdout] | [INFO] [stdout] 96 | i + B0::new() // I + B0 [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stdout] = note: `#[warn(clippy::suspicious_arithmetic_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Prefix` [INFO] [stdout] --> src/quantity/prefix.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | / pub fn new() -> Self { [INFO] [stdout] 23 | | Prefix(PhantomData) [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 19 + impl Default for Prefix { [INFO] [stdout] 20 + fn default() -> Self { [INFO] [stdout] 21 + Self::new() [INFO] [stdout] 22 + } [INFO] [stdout] 23 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/quantity/dimension.rs:78:29 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn pow(self) -> Dimension< [INFO] [stdout] | _____________________________^ [INFO] [stdout] 79 | | Prod, [INFO] [stdout] 80 | | Prod, [INFO] [stdout] 81 | | Prod, [INFO] [stdout] ... | [INFO] [stdout] 85 | | Prod, [INFO] [stdout] 86 | | > [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.42s [INFO] running `Command { std: "docker" "inspect" "4c0d2e6afa892875107bafb72ba049bc352d312815333504d5cdad19a13c2a58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c0d2e6afa892875107bafb72ba049bc352d312815333504d5cdad19a13c2a58", kill_on_drop: false }` [INFO] [stdout] 4c0d2e6afa892875107bafb72ba049bc352d312815333504d5cdad19a13c2a58