[INFO] fetching crate unifi_protect 0.5.2... [INFO] linting unifi_protect-0.5.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate unifi_protect 0.5.2 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate unifi_protect 0.5.2 [INFO] finished tweaking crates.io crate unifi_protect 0.5.2 [INFO] tweaked toml for crates.io crate unifi_protect 0.5.2 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate unifi_protect 0.5.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 170 packages to latest compatible versions [INFO] [stderr] Adding http v0.2.12 (available: v1.4.0) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 20c1dade39ba0c5e2664a15cd330d7b25cf87681631057f2699dbea38ff78cee [INFO] running `Command { std: "docker" "start" "-a" "20c1dade39ba0c5e2664a15cd330d7b25cf87681631057f2699dbea38ff78cee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "20c1dade39ba0c5e2664a15cd330d7b25cf87681631057f2699dbea38ff78cee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20c1dade39ba0c5e2664a15cd330d7b25cf87681631057f2699dbea38ff78cee", kill_on_drop: false }` [INFO] [stdout] 20c1dade39ba0c5e2664a15cd330d7b25cf87681631057f2699dbea38ff78cee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c051e561f2b3ad4356e4338a48e36c72056203ee7e386281028e9ee13f1ca6c0 [INFO] running `Command { std: "docker" "start" "-a" "c051e561f2b3ad4356e4338a48e36c72056203ee7e386281028e9ee13f1ca6c0", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking unifi_protect v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap` on `error_msg` after checking its variant with `is_some` [INFO] [stdout] --> src/api/download_footage.rs:56:48 [INFO] [stdout] | [INFO] [stdout] 55 | if error_msg.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = error_msg` [INFO] [stdout] 56 | eprintln!("Error: {}", error_msg.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api/download_footage.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return Ok(false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return Ok(false) [INFO] [stdout] 70 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/api/fetch_cameras.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if !parsed_cameras_result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_cameras_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parsed_cameras_result` after checking its variant with `is_err` [INFO] [stdout] --> src/api/fetch_cameras.rs:39:28 [INFO] [stdout] | [INFO] [stdout] 38 | if !parsed_cameras_result.is_err() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] 39 | self.cameras = parsed_cameras_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/api/fetch_cameras.rs:26:98 [INFO] [stdout] | [INFO] [stdout] 26 | return Err(format!("Failed to parse camera-data: {}", cameras_raw_text.err().unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/api/fetch_cameras.rs:32:110 [INFO] [stdout] | [INFO] [stdout] 32 | return Err(format!("Failed to parse camera-data: {}", parsed_cameras_simple_result.err().unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/api/fetch_cameras.rs:41:103 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(format!("Failed to parse camera-data: {}", parsed_cameras_result.err().unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return Err("Failed to log in!"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return Err("Failed to log in!"); [INFO] [stdout] 66 + Err("Failed to log in!") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth.rs:96:16 [INFO] [stdout] | [INFO] [stdout] 96 | if !csrf_token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `csrf_token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `csrf_token` after checking its variant with `is_none` [INFO] [stdout] --> src/auth.rs:98:45 [INFO] [stdout] | [INFO] [stdout] 96 | if !csrf_token.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 97 | self.headers [INFO] [stdout] 98 | .insert("X-CSRF-Token", csrf_token.unwrap().parse().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/auth.rs:93:59 [INFO] [stdout] | [INFO] [stdout] 93 | .and_then(|value| value.to_str().ok().map(|s| String::from(s))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `error_msg` after checking its variant with `is_some` [INFO] [stdout] --> src/api/download_footage.rs:56:48 [INFO] [stdout] | [INFO] [stdout] 55 | if error_msg.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = error_msg` [INFO] [stdout] 56 | eprintln!("Error: {}", error_msg.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api/download_footage.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return Ok(false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return Ok(false) [INFO] [stdout] 70 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/api/fetch_cameras.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 38 | if !parsed_cameras_result.is_err() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_cameras_result.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `parsed_cameras_result` after checking its variant with `is_err` [INFO] [stdout] --> src/api/fetch_cameras.rs:39:28 [INFO] [stdout] | [INFO] [stdout] 38 | if !parsed_cameras_result.is_err() { [INFO] [stdout] | ------------------------------ the check is happening here [INFO] [stdout] 39 | self.cameras = parsed_cameras_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/api/fetch_cameras.rs:26:98 [INFO] [stdout] | [INFO] [stdout] 26 | return Err(format!("Failed to parse camera-data: {}", cameras_raw_text.err().unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/api/fetch_cameras.rs:32:110 [INFO] [stdout] | [INFO] [stdout] 32 | return Err(format!("Failed to parse camera-data: {}", parsed_cameras_simple_result.err().unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/api/fetch_cameras.rs:41:103 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(format!("Failed to parse camera-data: {}", parsed_cameras_result.err().unwrap().to_string())); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/auth.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | return Err("Failed to log in!"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return Err("Failed to log in!"); [INFO] [stdout] 66 + Err("Failed to log in!") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/auth.rs:96:16 [INFO] [stdout] | [INFO] [stdout] 96 | if !csrf_token.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `csrf_token.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `csrf_token` after checking its variant with `is_none` [INFO] [stdout] --> src/auth.rs:98:45 [INFO] [stdout] | [INFO] [stdout] 96 | if !csrf_token.is_none() { [INFO] [stdout] | -------------------- the check is happening here [INFO] [stdout] 97 | self.headers [INFO] [stdout] 98 | .insert("X-CSRF-Token", csrf_token.unwrap().parse().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/auth.rs:93:59 [INFO] [stdout] | [INFO] [stdout] 93 | .and_then(|value| value.to_str().ok().map(|s| String::from(s))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 42.19s [INFO] running `Command { std: "docker" "inspect" "c051e561f2b3ad4356e4338a48e36c72056203ee7e386281028e9ee13f1ca6c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c051e561f2b3ad4356e4338a48e36c72056203ee7e386281028e9ee13f1ca6c0", kill_on_drop: false }` [INFO] [stdout] c051e561f2b3ad4356e4338a48e36c72056203ee7e386281028e9ee13f1ca6c0