[INFO] fetching crate unhtml 0.8.0...
[INFO] linting unhtml-0.8.0 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate unhtml 0.8.0 into /workspace/builds/worker-1-tc1/source
[INFO] started tweaking crates.io crate unhtml 0.8.0
[INFO] finished tweaking crates.io crate unhtml 0.8.0
[INFO] tweaked toml for crates.io crate unhtml 0.8.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate unhtml 0.8.0 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] Updating crates.io index
[INFO] [stderr] Blocking waiting for file lock on package cache
[INFO] [stderr] Locking 72 packages to latest compatible versions
[INFO] [stderr] Adding derive_more v0.99.20 (available: v2.1.1)
[INFO] [stderr] Adding scraper v0.12.0 (available: v0.26.0)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] Downloading crates ...
[INFO] [stderr] Downloaded markup5ever v0.10.1
[INFO] [stderr] Downloaded html5ever v0.25.2
[INFO] [stderr] Downloaded scraper v0.12.0
[INFO] [stderr] Downloaded unhtml_derive v0.8.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] a78802612f0e7024de6aa6d5a2d42a1bf475e9fb12980f27d04f06fabb12455f
[INFO] running `Command { std: "docker" "start" "-a" "a78802612f0e7024de6aa6d5a2d42a1bf475e9fb12980f27d04f06fabb12455f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a78802612f0e7024de6aa6d5a2d42a1bf475e9fb12980f27d04f06fabb12455f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a78802612f0e7024de6aa6d5a2d42a1bf475e9fb12980f27d04f06fabb12455f", kill_on_drop: false }`
[INFO] [stdout] a78802612f0e7024de6aa6d5a2d42a1bf475e9fb12980f27d04f06fabb12455f
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 514ec220e28cbc098b97cb3ae7f5b0b2b99528e2258c515d4a9dd45c7e156e76
[INFO] running `Command { std: "docker" "start" "-a" "514ec220e28cbc098b97cb3ae7f5b0b2b99528e2258c515d4a9dd45c7e156e76", kill_on_drop: false }`
[INFO] [stderr] Compiling siphasher v0.3.11
[INFO] [stderr] Compiling getrandom v0.1.16
[INFO] [stderr] Compiling zerocopy v0.8.42
[INFO] [stderr] Compiling siphasher v1.0.2
[INFO] [stderr] Compiling rand_core v0.6.4
[INFO] [stderr] Compiling syn v1.0.109
[INFO] [stderr] Checking precomputed-hash v0.1.1
[INFO] [stderr] Compiling phf_shared v0.8.0
[INFO] [stderr] Checking mac v0.1.1
[INFO] [stderr] Checking futf v0.1.5
[INFO] [stderr] Checking serde v1.0.228
[INFO] [stderr] Compiling rand_core v0.5.1
[INFO] [stderr] Checking phf_shared v0.11.3
[INFO] [stderr] Checking dtoa v1.0.11
[INFO] [stderr] Compiling rand v0.8.5
[INFO] [stderr] Compiling rand_pcg v0.2.1
[INFO] [stderr] Checking tendril v0.4.3
[INFO] [stderr] Compiling cssparser-macros v0.6.1
[INFO] [stderr] Checking dtoa-short v0.3.5
[INFO] [stderr] Checking matches v0.1.10
[INFO] [stderr] Checking nodrop v0.1.14
[INFO] [stderr] Checking stable_deref_trait v1.2.1
[INFO] [stderr] Compiling derive_more v0.99.20
[INFO] [stderr] Checking servo_arc v0.1.1
[INFO] [stderr] Checking thin-slice v0.1.1
[INFO] [stderr] Checking string_cache v0.8.9
[INFO] [stderr] Checking ego-tree v0.6.3
[INFO] [stderr] Compiling phf_generator v0.11.3
[INFO] [stderr] Compiling string_cache_codegen v0.5.4
[INFO] [stderr] Compiling cssparser v0.27.2
[INFO] [stderr] Compiling html5ever v0.25.2
[INFO] [stderr] Compiling ppv-lite86 v0.2.21
[INFO] [stderr] Compiling rand_chacha v0.2.2
[INFO] [stderr] Compiling rand v0.7.3
[INFO] [stderr] Compiling phf_generator v0.8.0
[INFO] [stderr] Compiling phf_codegen v0.8.0
[INFO] [stderr] Compiling phf_macros v0.8.0
[INFO] [stderr] Compiling markup5ever v0.10.1
[INFO] [stderr] Compiling selectors v0.22.0
[INFO] [stderr] Checking phf v0.8.0
[INFO] [stderr] Checking scraper v0.12.0
[INFO] [stderr] Checking unhtml v0.8.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout] --> src/traits.rs:85:12
[INFO] [stdout] |
[INFO] [stdout] 85 | Ok(match T::from_inner_text(select) {
[INFO] [stdout] | ____________^
[INFO] [stdout] 86 | | Ok(ret) => Some(ret),
[INFO] [stdout] 87 | | Err(_) => None,
[INFO] [stdout] 88 | | })
[INFO] [stdout] | |_________^ help: replace with: `T::from_inner_text(select).ok()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout] --> src/traits.rs:92:12
[INFO] [stdout] |
[INFO] [stdout] 92 | Ok(match T::from_attr(select, attr) {
[INFO] [stdout] | ____________^
[INFO] [stdout] 93 | | Ok(ret) => Some(ret),
[INFO] [stdout] 94 | | Err(_) => None,
[INFO] [stdout] 95 | | })
[INFO] [stdout] | |_________^ help: replace with: `T::from_attr(select, attr).ok()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout] --> src/traits.rs:104:12
[INFO] [stdout] |
[INFO] [stdout] 104 | Ok(match T::from_elements(select) {
[INFO] [stdout] | ____________^
[INFO] [stdout] 105 | | Ok(ret) => Some(ret),
[INFO] [stdout] 106 | | Err(_) => None,
[INFO] [stdout] 107 | | })
[INFO] [stdout] | |_________^ help: replace with: `T::from_elements(select).ok()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout] --> src/test/from_html.rs:101:13
[INFO] [stdout] |
[INFO] [stdout] 101 | assert!(!result.is_ok());
[INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout] --> src/test/from_text.rs:83:13
[INFO] [stdout] |
[INFO] [stdout] 83 | assert!(!foo_result.is_ok());
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `foo_result.is_err()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout] --> src/test/from_text.rs:165:13
[INFO] [stdout] |
[INFO] [stdout] 165 | assert!(!foo_result.is_ok());
[INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `foo_result.is_err()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout] --> src/traits.rs:85:12
[INFO] [stdout] |
[INFO] [stdout] 85 | Ok(match T::from_inner_text(select) {
[INFO] [stdout] | ____________^
[INFO] [stdout] 86 | | Ok(ret) => Some(ret),
[INFO] [stdout] 87 | | Err(_) => None,
[INFO] [stdout] 88 | | })
[INFO] [stdout] | |_________^ help: replace with: `T::from_inner_text(select).ok()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout] --> src/traits.rs:92:12
[INFO] [stdout] |
[INFO] [stdout] 92 | Ok(match T::from_attr(select, attr) {
[INFO] [stdout] | ____________^
[INFO] [stdout] 93 | | Ok(ret) => Some(ret),
[INFO] [stdout] 94 | | Err(_) => None,
[INFO] [stdout] 95 | | })
[INFO] [stdout] | |_________^ help: replace with: `T::from_attr(select, attr).ok()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stdout] warning: manual implementation of `ok`
[INFO] [stdout] --> src/traits.rs:104:12
[INFO] [stdout] |
[INFO] [stdout] 104 | Ok(match T::from_elements(select) {
[INFO] [stdout] | ____________^
[INFO] [stdout] 105 | | Ok(ret) => Some(ret),
[INFO] [stdout] 106 | | Err(_) => None,
[INFO] [stdout] 107 | | })
[INFO] [stdout] | |_________^ help: replace with: `T::from_elements(select).ok()`
[INFO] [stdout] |
[INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err
[INFO] [stdout]
[INFO] [stdout]
[INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.34s
[INFO] running `Command { std: "docker" "inspect" "514ec220e28cbc098b97cb3ae7f5b0b2b99528e2258c515d4a9dd45c7e156e76", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "514ec220e28cbc098b97cb3ae7f5b0b2b99528e2258c515d4a9dd45c7e156e76", kill_on_drop: false }`
[INFO] [stdout] 514ec220e28cbc098b97cb3ae7f5b0b2b99528e2258c515d4a9dd45c7e156e76