[INFO] fetching crate uid_store 0.1.9... [INFO] linting uid_store-0.1.9 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate uid_store 0.1.9 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate uid_store 0.1.9 [INFO] finished tweaking crates.io crate uid_store 0.1.9 [INFO] tweaked toml for crates.io crate uid_store 0.1.9 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate uid_store 0.1.9 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac26f776d738c57175955d80cc3204d4f46285d05f6cf417c7eab41b92bdd7f1 [INFO] running `Command { std: "docker" "start" "-a" "ac26f776d738c57175955d80cc3204d4f46285d05f6cf417c7eab41b92bdd7f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac26f776d738c57175955d80cc3204d4f46285d05f6cf417c7eab41b92bdd7f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac26f776d738c57175955d80cc3204d4f46285d05f6cf417c7eab41b92bdd7f1", kill_on_drop: false }` [INFO] [stdout] ac26f776d738c57175955d80cc3204d4f46285d05f6cf417c7eab41b92bdd7f1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60c523cbac39ad7e731432e605bdb8b686cf675eae9557912935510a555ae1b5 [INFO] running `Command { std: "docker" "start" "-a" "60c523cbac39ad7e731432e605bdb8b686cf675eae9557912935510a555ae1b5", kill_on_drop: false }` [INFO] [stderr] Checking uid_store v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `UidStore` [INFO] [stdout] --> src/lib.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / pub fn new() -> UidStore { [INFO] [stdout] 79 | | UidStore { [INFO] [stdout] 80 | | items: HashSet::new(), [INFO] [stdout] 81 | | } [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 77 + impl Default for UidStore { [INFO] [stdout] 78 + fn default() -> Self { [INFO] [stdout] 79 + Self::new() [INFO] [stdout] 80 + } [INFO] [stdout] 81 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | uid = uid / CHARSET.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uid /= CHARSET.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | if c >= 'A' && c <= 'Z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('A'..='Z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:243:19 [INFO] [stdout] | [INFO] [stdout] 243 | } else if c >= 'a' && c <= 'z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('a'..='z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:244:36 [INFO] [stdout] | [INFO] [stdout] 244 | value = (c as usize) - ('a' as usize) as usize + 26; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `('a' as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:245:19 [INFO] [stdout] | [INFO] [stdout] 245 | } else if c >= '0' && c <= '9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `UidStore` [INFO] [stdout] --> src/lib.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | / pub fn new() -> UidStore { [INFO] [stdout] 79 | | UidStore { [INFO] [stdout] 80 | | items: HashSet::new(), [INFO] [stdout] 81 | | } [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 77 + impl Default for UidStore { [INFO] [stdout] 78 + fn default() -> Self { [INFO] [stdout] 79 + Self::new() [INFO] [stdout] 80 + } [INFO] [stdout] 81 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | uid = uid / CHARSET.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uid /= CHARSET.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | if c >= 'A' && c <= 'Z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('A'..='Z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:243:19 [INFO] [stdout] | [INFO] [stdout] 243 | } else if c >= 'a' && c <= 'z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('a'..='z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:244:36 [INFO] [stdout] | [INFO] [stdout] 244 | value = (c as usize) - ('a' as usize) as usize + 26; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `('a' as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:245:19 [INFO] [stdout] | [INFO] [stdout] 245 | } else if c >= '0' && c <= '9' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:322:21 [INFO] [stdout] | [INFO] [stdout] 322 | assert!(!v.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `v.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loops only once with `_` being `0..100000` [INFO] [stdout] --> src/lib.rs:309:18 [INFO] [stdout] | [INFO] [stdout] 309 | for _ in [0..100000] { [INFO] [stdout] | ^^^^^^^^^^^ help: did you mean to iterate over the range instead?: `0..100000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_element_loop [INFO] [stdout] = note: `#[warn(clippy::single_element_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an array of `Range` that is only one element [INFO] [stdout] --> src/lib.rs:309:18 [INFO] [stdout] | [INFO] [stdout] 309 | for _ in [0..100000] { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init [INFO] [stdout] = note: `#[warn(clippy::single_range_in_vec_init)]` on by default [INFO] [stdout] help: if you wanted a `Vec` that contains the entire range, try [INFO] [stdout] | [INFO] [stdout] 309 - for _ in [0..100000] { [INFO] [stdout] 309 + for _ in (0..100000).collect::>() { [INFO] [stdout] | [INFO] [stdout] help: if you wanted an array of len 100000, try [INFO] [stdout] | [INFO] [stdout] 309 - for _ in [0..100000] { [INFO] [stdout] 309 + for _ in [0; 100000] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loops only once with `_` being `0..50000` [INFO] [stdout] --> src/lib.rs:315:18 [INFO] [stdout] | [INFO] [stdout] 315 | for _ in [0..50000] { [INFO] [stdout] | ^^^^^^^^^^ help: did you mean to iterate over the range instead?: `0..50000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_element_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an array of `Range` that is only one element [INFO] [stdout] --> src/lib.rs:315:18 [INFO] [stdout] | [INFO] [stdout] 315 | for _ in [0..50000] { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init [INFO] [stdout] help: if you wanted a `Vec` that contains the entire range, try [INFO] [stdout] | [INFO] [stdout] 315 - for _ in [0..50000] { [INFO] [stdout] 315 + for _ in (0..50000).collect::>() { [INFO] [stdout] | [INFO] [stdout] help: if you wanted an array of len 50000, try [INFO] [stdout] | [INFO] [stdout] 315 - for _ in [0..50000] { [INFO] [stdout] 315 + for _ in [0; 50000] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loops only once with `_` being `0..50000` [INFO] [stdout] --> src/lib.rs:320:18 [INFO] [stdout] | [INFO] [stdout] 320 | for _ in [0..50000] { [INFO] [stdout] | ^^^^^^^^^^ help: did you mean to iterate over the range instead?: `0..50000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_element_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an array of `Range` that is only one element [INFO] [stdout] --> src/lib.rs:320:18 [INFO] [stdout] | [INFO] [stdout] 320 | for _ in [0..50000] { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_range_in_vec_init [INFO] [stdout] help: if you wanted a `Vec` that contains the entire range, try [INFO] [stdout] | [INFO] [stdout] 320 - for _ in [0..50000] { [INFO] [stdout] 320 + for _ in (0..50000).collect::>() { [INFO] [stdout] | [INFO] [stdout] help: if you wanted an array of len 50000, try [INFO] [stdout] | [INFO] [stdout] 320 - for _ in [0..50000] { [INFO] [stdout] 320 + for _ in [0; 50000] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:323:35 [INFO] [stdout] | [INFO] [stdout] 323 | let v = uid_to_number(&v.unwrap()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `v.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "60c523cbac39ad7e731432e605bdb8b686cf675eae9557912935510a555ae1b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60c523cbac39ad7e731432e605bdb8b686cf675eae9557912935510a555ae1b5", kill_on_drop: false }` [INFO] [stdout] 60c523cbac39ad7e731432e605bdb8b686cf675eae9557912935510a555ae1b5