[INFO] fetching crate twitter_text_conformance 0.2.0... [INFO] linting twitter_text_conformance-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate twitter_text_conformance 0.2.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate twitter_text_conformance 0.2.0 [INFO] finished tweaking crates.io crate twitter_text_conformance 0.2.0 [INFO] tweaked toml for crates.io crate twitter_text_conformance 0.2.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate twitter_text_conformance 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding serde_yaml v0.7.5 (available: v0.9.34+deprecated) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded twitter_text_parser v0.2.0 [INFO] [stderr] Downloaded twitter_text_config v0.2.0 [INFO] [stderr] Downloaded twitter-text v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c2dc47124a876c38f279117fda94b940a189610e682cf2c7d3934fd3e4430cf [INFO] running `Command { std: "docker" "start" "-a" "4c2dc47124a876c38f279117fda94b940a189610e682cf2c7d3934fd3e4430cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c2dc47124a876c38f279117fda94b940a189610e682cf2c7d3934fd3e4430cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c2dc47124a876c38f279117fda94b940a189610e682cf2c7d3934fd3e4430cf", kill_on_drop: false }` [INFO] [stdout] 4c2dc47124a876c38f279117fda94b940a189610e682cf2c7d3934fd3e4430cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fab4e0b5beb4b179379d75e1cc4a9abbff0616435ab8bdcc349276a4b529a0bc [INFO] running `Command { std: "docker" "start" "-a" "fab4e0b5beb4b179379d75e1cc4a9abbff0616435ab8bdcc349276a4b529a0bc", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling pest v2.8.6 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling pest_meta v2.8.6 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling pest_generator v2.8.6 [INFO] [stderr] Compiling pest_derive v2.8.6 [INFO] [stderr] Checking twitter_text_parser v0.2.0 [INFO] [stderr] Checking twitter_text_config v0.2.0 [INFO] [stderr] Checking twitter-text v0.2.0 [INFO] [stderr] Checking twitter_text_conformance v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> tests/emoji.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::u32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> tests/emoji.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | .filter_map(|result| result.ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> tests/emoji.rs:22:38 [INFO] [stdout] | [INFO] [stdout] 22 | let emoji_strings: Vec = f.lines() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/emoji.rs:25:21 [INFO] [stdout] | [INFO] [stdout] 25 | .filter(|s| !(s.trim().len() == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(s.trim().len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> tests/emoji.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | .filter(|s| !(s.trim().len() == 0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.trim().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> tests/emoji.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | / match s.find(";") { [INFO] [stdout] 29 | | Some(ss) => { [INFO] [stdout] 30 | | let code: String = s.chars().take(ss).collect(); [INFO] [stdout] 31 | | let codes = code.trim().split(" "); [INFO] [stdout] ... | [INFO] [stdout] 42 | | None => {} [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 ~ if let Some(ss) = s.find(";") { [INFO] [stdout] 29 + let code: String = s.chars().take(ss).collect(); [INFO] [stdout] 30 + let codes = code.trim().split(" "); [INFO] [stdout] 31 + let chars: Vec = codes.map(|sss| { [INFO] [stdout] 32 + let digit = u32::from_str_radix(sss, 16).unwrap(); [INFO] [stdout] 33 + char::from_u32(digit).unwrap() [INFO] [stdout] 34 + }).collect(); [INFO] [stdout] 35 + [INFO] [stdout] 36 + for c in chars { [INFO] [stdout] 37 + test_str.push(c); [INFO] [stdout] 38 + } [INFO] [stdout] 39 + test_str.push_str("|test"); [INFO] [stdout] 40 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> tests/validate.rs:63:25 [INFO] [stdout] | [INFO] [stdout] 63 | type ValidationFn<'a> = std::ops::Fn(&str) -> bool + 'a; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 63 | type ValidationFn<'a> = dyn std::ops::Fn(&str) -> bool + 'a; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.27s [INFO] running `Command { std: "docker" "inspect" "fab4e0b5beb4b179379d75e1cc4a9abbff0616435ab8bdcc349276a4b529a0bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fab4e0b5beb4b179379d75e1cc4a9abbff0616435ab8bdcc349276a4b529a0bc", kill_on_drop: false }` [INFO] [stdout] fab4e0b5beb4b179379d75e1cc4a9abbff0616435ab8bdcc349276a4b529a0bc