[INFO] fetching crate tweld 0.2.1-alpha.nu-str-eng... [INFO] linting tweld-0.2.1-alpha.nu-str-eng against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tweld 0.2.1-alpha.nu-str-eng into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate tweld 0.2.1-alpha.nu-str-eng [INFO] finished tweaking crates.io crate tweld 0.2.1-alpha.nu-str-eng [INFO] tweaked toml for crates.io crate tweld 0.2.1-alpha.nu-str-eng written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tweld 0.2.1-alpha.nu-str-eng on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate tweld 0.2.1-alpha.nu-str-eng already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 982c05ac0c4d3a7d3206acb3256459f34d5d7ce051ff5129bb150be6f6f7f254 [INFO] running `Command { std: "docker" "start" "-a" "982c05ac0c4d3a7d3206acb3256459f34d5d7ce051ff5129bb150be6f6f7f254", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "982c05ac0c4d3a7d3206acb3256459f34d5d7ce051ff5129bb150be6f6f7f254", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "982c05ac0c4d3a7d3206acb3256459f34d5d7ce051ff5129bb150be6f6f7f254", kill_on_drop: false }` [INFO] [stdout] 982c05ac0c4d3a7d3206acb3256459f34d5d7ce051ff5129bb150be6f6f7f254 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3746c9b603a51f1348fc00bb78d661206ce7ba2703b355c59c1b178429316084 [INFO] running `Command { std: "docker" "start" "-a" "3746c9b603a51f1348fc00bb78d661206ce7ba2703b355c59c1b178429316084", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking tweld v0.2.1-alpha.nu-str-eng (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `parser::TweldDsl` [INFO] [stdout] --> src/builder.rs:3:44 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{models::{Modifier, TokenPart}, parser::TweldDsl}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parser::TweldDsl` [INFO] [stdout] --> src/builder.rs:3:44 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{models::{Modifier, TokenPart}, parser::TweldDsl}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `value` is never read [INFO] [stdout] --> src/builder.rs:11:69 [INFO] [stdout] | [INFO] [stdout] 11 | TokenPart::Plain(mut value) => { full.push_str(&value); value = value.replace(" ", "") }, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:112:27 [INFO] [stdout] | [INFO] [stdout] 112 | let ignore_char = char == ' ' [INFO] [stdout] | ___________________________^ [INFO] [stdout] 113 | | || char == '\t' [INFO] [stdout] 114 | | || char == '{' [INFO] [stdout] 115 | | || char == '"' [INFO] [stdout] 116 | | || char == '\'' [INFO] [stdout] 117 | | || char == '\''; [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 112 - let ignore_char = char == ' ' [INFO] [stdout] 113 - || char == '\t' [INFO] [stdout] 114 - || char == '{' [INFO] [stdout] 115 - || char == '"' [INFO] [stdout] 116 - || char == '\'' [INFO] [stdout] 117 - || char == '\''; [INFO] [stdout] 112 + let ignore_char = !(char != ' ' && char != '\t' && char != '{' && char != '"' && char != '\''); [INFO] [stdout] | [INFO] [stdout] 112 - let ignore_char = char == ' ' [INFO] [stdout] 113 - || char == '\t' [INFO] [stdout] 114 - || char == '{' [INFO] [stdout] 115 - || char == '"' [INFO] [stdout] 116 - || char == '\'' [INFO] [stdout] 117 - || char == '\''; [INFO] [stdout] 112 + let ignore_char = char == ' ' || char == '\t' || char == '{' || char == '"' || char == '\''; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/parser.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | while let Some(char) = clean_chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for char in clean_chars.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:158:28 [INFO] [stdout] | [INFO] [stdout] 158 | if word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:183:28 [INFO] [stdout] | [INFO] [stdout] 183 | if word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:198:43 [INFO] [stdout] | [INFO] [stdout] 198 | if word_terminator && word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:208:28 [INFO] [stdout] | [INFO] [stdout] 208 | if word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 213 | if modifiers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!modifiers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:254:43 [INFO] [stdout] | [INFO] [stdout] 254 | if word_terminator && word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/parser.rs:292:51 [INFO] [stdout] | [INFO] [stdout] 292 | ... start_index = left_word [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 293 | | ... .parse() [INFO] [stdout] 294 | | ... .and_then(|r| Ok(Some(r))) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 292 ~ start_index = left_word [INFO] [stdout] 293 + .parse().map(|r| Some(r)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/parser.rs:301:49 [INFO] [stdout] | [INFO] [stdout] 301 | ... end_index = right_word [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 302 | | ... .parse() [INFO] [stdout] 303 | | ... .and_then(|r| Ok(Some(r))) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 301 ~ end_index = right_word [INFO] [stdout] 302 + .parse().map(|r| Some(r)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:320:28 [INFO] [stdout] | [INFO] [stdout] 320 | if modifiers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!modifiers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:355:12 [INFO] [stdout] | [INFO] [stdout] 355 | if word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builder.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return full; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return full; [INFO] [stdout] 41 + full [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/builder.rs:17:74 [INFO] [stdout] | [INFO] [stdout] 17 | Modifier::Plural => { if !value.ends_with('s') { value.push_str("s"); } }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `value.push('s')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/scanner.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | / if let Some(TokenTree::Group(grp)) = tokens.peek() { [INFO] [stdout] 19 | | if grp.delimiter() == Delimiter::Bracket { [INFO] [stdout] 20 | | // We found @[ ... ]! Consume the bracket group. [INFO] [stdout] 21 | | let bracket_group = if let TokenTree::Group(grp) = tokens.next().unwrap() { [INFO] [stdout] ... | [INFO] [stdout] 35 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some(TokenTree::Group(grp)) = tokens.peek() [INFO] [stdout] 19 ~ && grp.delimiter() == Delimiter::Bracket { [INFO] [stdout] 20 | // We found @[ ... ]! Consume the bracket group. [INFO] [stdout] ... [INFO] [stdout] 33 | continue; [INFO] [stdout] 34 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `value` is never read [INFO] [stdout] --> src/builder.rs:11:69 [INFO] [stdout] | [INFO] [stdout] 11 | TokenPart::Plain(mut value) => { full.push_str(&value); value = value.replace(" ", "") }, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:112:27 [INFO] [stdout] | [INFO] [stdout] 112 | let ignore_char = char == ' ' [INFO] [stdout] | ___________________________^ [INFO] [stdout] 113 | | || char == '\t' [INFO] [stdout] 114 | | || char == '{' [INFO] [stdout] 115 | | || char == '"' [INFO] [stdout] 116 | | || char == '\'' [INFO] [stdout] 117 | | || char == '\''; [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 112 - let ignore_char = char == ' ' [INFO] [stdout] 113 - || char == '\t' [INFO] [stdout] 114 - || char == '{' [INFO] [stdout] 115 - || char == '"' [INFO] [stdout] 116 - || char == '\'' [INFO] [stdout] 117 - || char == '\''; [INFO] [stdout] 112 + let ignore_char = !(char != ' ' && char != '\t' && char != '{' && char != '"' && char != '\''); [INFO] [stdout] | [INFO] [stdout] 112 - let ignore_char = char == ' ' [INFO] [stdout] 113 - || char == '\t' [INFO] [stdout] 114 - || char == '{' [INFO] [stdout] 115 - || char == '"' [INFO] [stdout] 116 - || char == '\'' [INFO] [stdout] 117 - || char == '\''; [INFO] [stdout] 112 + let ignore_char = char == ' ' || char == '\t' || char == '{' || char == '"' || char == '\''; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/parser.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | while let Some(char) = clean_chars.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for char in clean_chars.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:158:28 [INFO] [stdout] | [INFO] [stdout] 158 | if word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:183:28 [INFO] [stdout] | [INFO] [stdout] 183 | if word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:198:43 [INFO] [stdout] | [INFO] [stdout] 198 | if word_terminator && word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:208:28 [INFO] [stdout] | [INFO] [stdout] 208 | if word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:213:28 [INFO] [stdout] | [INFO] [stdout] 213 | if modifiers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!modifiers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:254:43 [INFO] [stdout] | [INFO] [stdout] 254 | if word_terminator && word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/parser.rs:292:51 [INFO] [stdout] | [INFO] [stdout] 292 | ... start_index = left_word [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 293 | | ... .parse() [INFO] [stdout] 294 | | ... .and_then(|r| Ok(Some(r))) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 292 ~ start_index = left_word [INFO] [stdout] 293 + .parse().map(|r| Some(r)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/parser.rs:301:49 [INFO] [stdout] | [INFO] [stdout] 301 | ... end_index = right_word [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 302 | | ... .parse() [INFO] [stdout] 303 | | ... .and_then(|r| Ok(Some(r))) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 301 ~ end_index = right_word [INFO] [stdout] 302 + .parse().map(|r| Some(r)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:320:28 [INFO] [stdout] | [INFO] [stdout] 320 | if modifiers.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!modifiers.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:355:12 [INFO] [stdout] | [INFO] [stdout] 355 | if word.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!word.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/builder.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | return full; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return full; [INFO] [stdout] 41 + full [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/builder.rs:17:74 [INFO] [stdout] | [INFO] [stdout] 17 | Modifier::Plural => { if !value.ends_with('s') { value.push_str("s"); } }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `value.push('s')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/scanner.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | / if let Some(TokenTree::Group(grp)) = tokens.peek() { [INFO] [stdout] 19 | | if grp.delimiter() == Delimiter::Bracket { [INFO] [stdout] 20 | | // We found @[ ... ]! Consume the bracket group. [INFO] [stdout] 21 | | let bracket_group = if let TokenTree::Group(grp) = tokens.next().unwrap() { [INFO] [stdout] ... | [INFO] [stdout] 35 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 18 ~ if let Some(TokenTree::Group(grp)) = tokens.peek() [INFO] [stdout] 19 ~ && grp.delimiter() == Delimiter::Bracket { [INFO] [stdout] 20 | // We found @[ ... ]! Consume the bracket group. [INFO] [stdout] ... [INFO] [stdout] 33 | continue; [INFO] [stdout] 34 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tests.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / mod tests { [INFO] [stdout] 4 | | use crate::scanner::scan_tokens; [INFO] [stdout] 5 | | use proc_macro2::TokenStream; [INFO] [stdout] 6 | | use quote::quote; [INFO] [stdout] ... | [INFO] [stdout] 374 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/tests.rs:16:38 [INFO] [stdout] | [INFO] [stdout] 16 | let result = scan_tokens(TokenStream::from(input)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `TokenStream::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/tests.rs:29:38 [INFO] [stdout] | [INFO] [stdout] 29 | let result = scan_tokens(TokenStream::from(input)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `TokenStream::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/tests.rs:201:38 [INFO] [stdout] | [INFO] [stdout] 201 | let result = scan_tokens(TokenStream::from(input)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `TokenStream::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/tests.rs:286:38 [INFO] [stdout] | [INFO] [stdout] 286 | let result = scan_tokens(TokenStream::from(input)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `TokenStream::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/tests.rs:333:38 [INFO] [stdout] | [INFO] [stdout] 333 | let result = scan_tokens(TokenStream::from(input)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `TokenStream::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> src/tests.rs:366:38 [INFO] [stdout] | [INFO] [stdout] 366 | let result = scan_tokens(TokenStream::from(input)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `TokenStream::from()`: `input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.30s [INFO] running `Command { std: "docker" "inspect" "3746c9b603a51f1348fc00bb78d661206ce7ba2703b355c59c1b178429316084", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3746c9b603a51f1348fc00bb78d661206ce7ba2703b355c59c1b178429316084", kill_on_drop: false }` [INFO] [stdout] 3746c9b603a51f1348fc00bb78d661206ce7ba2703b355c59c1b178429316084