[INFO] fetching crate tw_pack_lib 0.1.21... [INFO] linting tw_pack_lib-0.1.21 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tw_pack_lib 0.1.21 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate tw_pack_lib 0.1.21 [INFO] finished tweaking crates.io crate tw_pack_lib 0.1.21 [INFO] tweaked toml for crates.io crate tw_pack_lib 0.1.21 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tw_pack_lib 0.1.21 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.11.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cached_file_view v0.1.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e4ce5ce24f71b99a625f2539269cdbb79a820015d6f64fd17ac09654c1832392 [INFO] running `Command { std: "docker" "start" "-a" "e4ce5ce24f71b99a625f2539269cdbb79a820015d6f64fd17ac09654c1832392", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e4ce5ce24f71b99a625f2539269cdbb79a820015d6f64fd17ac09654c1832392", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4ce5ce24f71b99a625f2539269cdbb79a820015d6f64fd17ac09654c1832392", kill_on_drop: false }` [INFO] [stdout] e4ce5ce24f71b99a625f2539269cdbb79a820015d6f64fd17ac09654c1832392 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8c8223afbd60b317e5d6d7d3c0d93c64d3fda87ee4d3990925eb09fdd8df0cd [INFO] running `Command { std: "docker" "start" "-a" "a8c8223afbd60b317e5d6d7d3c0d93c64d3fda87ee4d3990925eb09fdd8df0cd", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking cached_file_view v0.1.4 [INFO] [stderr] Checking tw_pack_lib v0.1.21 (/opt/rustwide/workdir) [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/crypto.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | let padded_length = ciphertext.len() + 7 & !7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(ciphertext.len() + 7) & !7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parse.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | begin: begin [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/crypto.rs:42:25 [INFO] [stdout] | [INFO] [stdout] 42 | let padded_length = ciphertext.len() + 7 & !7; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(ciphertext.len() + 7) & !7` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parse.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | begin: begin [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `begin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `begin` is never read [INFO] [stdout] --> src/lib.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 110 | pub struct PackFile { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 111 | view: FileView, [INFO] [stdout] 112 | begin: FileViewMapping [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PackFile` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/build.rs:20:33 [INFO] [stdout] | [INFO] [stdout] 20 | prefix.to_owned() + &"\\".to_owned() + &entry.file_name().into_string().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"\\"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/build.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | / fn write_header>( [INFO] [stdout] 38 | | output_file: &mut File, [INFO] [stdout] 39 | | version: ::PFHVersion, [INFO] [stdout] 40 | | bitmask: ::PFHFlags, [INFO] [stdout] ... | [INFO] [stdout] 46 | | packed_files: &Vec

[INFO] [stdout] 47 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/build.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | packed_files: &Vec

[INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - packed_files: &Vec

[INFO] [stdout] 46 + packed_files: &[P] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/build.rs:140:140 [INFO] [stdout] | [INFO] [stdout] 140 | ...2, packed_file_index_size, pack_files, &packed_files)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `packed_files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/crypto.rs:25:28 [INFO] [stdout] | [INFO] [stdout] 25 | let c = ciphertext[idx as usize] ^ !key ^ get_key_at(idx); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/crypto.rs:27:81 [INFO] [stdout] | [INFO] [stdout] 27 | println!("{:X} ({}) = {:X} ^ {:X} ^ {:X}", c, c as char, ciphertext[idx as usize], !key, get_key_at(idx)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/crypto.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | assert!(padded_length % 8 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `padded_length.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto.rs:69:32 [INFO] [stdout] | [INFO] [stdout] 69 | eax ^= read_padded_u32(&ciphertext, esi..esi + 4); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `ciphertext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto.rs:78:36 [INFO] [stdout] | [INFO] [stdout] 78 | let _edx = read_padded_u32(&ciphertext, esi + 4..esi + 8); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `ciphertext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | if get_preamble(&raw_data) == ::PFH4_PREAMBLE { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | } else if get_preamble(&raw_data) == ::PFH5_PREAMBLE { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:106:27 [INFO] [stdout] | [INFO] [stdout] 106 | if has_big_header(&raw_data) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:112:58 [INFO] [stdout] | [INFO] [stdout] 112 | panic!("Invalid preamble! ###{:?}", get_preamble(&raw_data)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | get_bitmask(&view).contains(::PFHFlags::HAS_BIG_HEADER) [INFO] [stdout] | ^^^^^ help: change this to: `view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | get_bitmask(&view).contains(::PFHFlags::HAS_ENCRYPTED_INDEX) [INFO] [stdout] | ^^^^^ help: change this to: `view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:125:17 [INFO] [stdout] | [INFO] [stdout] 125 | get_bitmask(&view).contains(::PFHFlags::HAS_INDEX_WITH_TIMESTAMPS) [INFO] [stdout] | ^^^^^ help: change this to: `view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | get_bitmask(&view).contains(::PFHFlags::HAS_ENCRYPTED_CONTENT) [INFO] [stdout] | ^^^^^ help: change this to: `view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 133 | get_preamble(&raw_data) == ::PFH5_PREAMBLE && has_encrypted_content(&raw_data) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:133:73 [INFO] [stdout] | [INFO] [stdout] 133 | get_preamble(&raw_data) == ::PFH5_PREAMBLE && has_encrypted_content(&raw_data) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/parse.rs:162:108 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(LittleEndian::read_u32(&self.view.read(self.index_position as u64..self.index_position as u64 + 4 as u64)?.to_vec())) [INFO] [stdout] | ^^^^^^^^ help: try: `4_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:171:50 [INFO] [stdout] | [INFO] [stdout] 171 | item_length = if has_encrypted_index(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:179:58 [INFO] [stdout] | [INFO] [stdout] 179 | let timestamp = if has_index_with_timestamps(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:187:29 [INFO] [stdout] | [INFO] [stdout] 187 | if get_preamble(&self.view) == ::PFH5_PREAMBLE && !has_big_header(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:187:79 [INFO] [stdout] | [INFO] [stdout] 187 | if get_preamble(&self.view) == ::PFH5_PREAMBLE && !has_big_header(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:191:67 [INFO] [stdout] | [INFO] [stdout] 191 | ... let remaining_index_size = get_packed_file_index_size(&self.view) - (self.index_position - get_static_header_size(&self.view)... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:191:127 [INFO] [stdout] | [INFO] [stdout] 191 | ...f.index_position - get_static_header_size(&self.view) - get_pack_file_index_size(&self.view)); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:191:166 [INFO] [stdout] | [INFO] [stdout] 191 | ...ze(&self.view) - get_pack_file_index_size(&self.view)); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:192:59 [INFO] [stdout] | [INFO] [stdout] 192 | let (file_path, len) = if has_encrypted_index(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:212:63 [INFO] [stdout] | [INFO] [stdout] 212 | let padded_item_length = if has_encrypted_content(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:226:28 [INFO] [stdout] | [INFO] [stdout] 226 | if has_padding(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:237:61 [INFO] [stdout] | [INFO] [stdout] 237 | is_encrypted: has_encrypted_content(&self.view), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/parse.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 251 | / match self.get_next() { [INFO] [stdout] 252 | | Ok(item) => Some(item), [INFO] [stdout] 253 | | Err(_) => None [INFO] [stdout] 254 | | } [INFO] [stdout] | |_________^ help: replace with: `self.get_next().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse.rs:281:8 [INFO] [stdout] | [INFO] [stdout] 281 | if !::PFHFlags::from_bits(LittleEndian::read_u32(&file_view.read(0x04..0x08)?.to_vec()) & !0xf).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `::PFHFlags::from_bits(LittleEndian::read_u32(&file_view.read(0x04..0x08)?.to_vec()) & !0xf).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:233:86 [INFO] [stdout] | [INFO] [stdout] 233 | ...nge.end - lazy.range.start, format!("{} != {}", plaintext.len(), lazy.range.end - lazy.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 233 - assert!(plaintext.len() as u64 == lazy.range.end - lazy.range.start, format!("{} != {}", plaintext.len(), lazy.range.end - lazy.range.start)); [INFO] [stdout] 233 + assert!(plaintext.len() as u64 == lazy.range.end - lazy.range.start, "{} != {}", plaintext.len(), lazy.range.end - lazy.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:254:90 [INFO] [stdout] | [INFO] [stdout] 254 | ...nge.end - lazy.range.start, format!("{} != {}", plaintext.len(), lazy.range.end - lazy.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 254 - assert!(plaintext.len() as u64 == lazy.range.end - lazy.range.start, format!("{} != {}", plaintext.len(), lazy.range.end - lazy.range.start)); [INFO] [stdout] 254 + assert!(plaintext.len() as u64 == lazy.range.end - lazy.range.start, "{} != {}", plaintext.len(), lazy.range.end - lazy.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `begin` is never read [INFO] [stdout] --> src/lib.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 110 | pub struct PackFile { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 111 | view: FileView, [INFO] [stdout] 112 | begin: FileViewMapping [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PackFile` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/build.rs:20:33 [INFO] [stdout] | [INFO] [stdout] 20 | prefix.to_owned() + &"\\".to_owned() + &entry.file_name().into_string().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: use: `"\\"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/build.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | / fn write_header>( [INFO] [stdout] 38 | | output_file: &mut File, [INFO] [stdout] 39 | | version: ::PFHVersion, [INFO] [stdout] 40 | | bitmask: ::PFHFlags, [INFO] [stdout] ... | [INFO] [stdout] 46 | | packed_files: &Vec

[INFO] [stdout] 47 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/build.rs:46:19 [INFO] [stdout] | [INFO] [stdout] 46 | packed_files: &Vec

[INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - packed_files: &Vec

[INFO] [stdout] 46 + packed_files: &[P] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/build.rs:140:140 [INFO] [stdout] | [INFO] [stdout] 140 | ...2, packed_file_index_size, pack_files, &packed_files)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `packed_files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/crypto.rs:25:28 [INFO] [stdout] | [INFO] [stdout] 25 | let c = ciphertext[idx as usize] ^ !key ^ get_key_at(idx); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/crypto.rs:27:81 [INFO] [stdout] | [INFO] [stdout] 27 | println!("{:X} ({}) = {:X} ^ {:X} ^ {:X}", c, c as char, ciphertext[idx as usize], !key, get_key_at(idx)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/crypto.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | assert!(padded_length % 8 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `padded_length.is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto.rs:69:32 [INFO] [stdout] | [INFO] [stdout] 69 | eax ^= read_padded_u32(&ciphertext, esi..esi + 4); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `ciphertext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/crypto.rs:78:36 [INFO] [stdout] | [INFO] [stdout] 78 | let _edx = read_padded_u32(&ciphertext, esi + 4..esi + 8); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `ciphertext` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | if get_preamble(&raw_data) == ::PFH4_PREAMBLE { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:105:28 [INFO] [stdout] | [INFO] [stdout] 105 | } else if get_preamble(&raw_data) == ::PFH5_PREAMBLE { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:106:27 [INFO] [stdout] | [INFO] [stdout] 106 | if has_big_header(&raw_data) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:112:58 [INFO] [stdout] | [INFO] [stdout] 112 | panic!("Invalid preamble! ###{:?}", get_preamble(&raw_data)) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | get_bitmask(&view).contains(::PFHFlags::HAS_BIG_HEADER) [INFO] [stdout] | ^^^^^ help: change this to: `view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | get_bitmask(&view).contains(::PFHFlags::HAS_ENCRYPTED_INDEX) [INFO] [stdout] | ^^^^^ help: change this to: `view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:125:17 [INFO] [stdout] | [INFO] [stdout] 125 | get_bitmask(&view).contains(::PFHFlags::HAS_INDEX_WITH_TIMESTAMPS) [INFO] [stdout] | ^^^^^ help: change this to: `view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | get_bitmask(&view).contains(::PFHFlags::HAS_ENCRYPTED_CONTENT) [INFO] [stdout] | ^^^^^ help: change this to: `view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:133:18 [INFO] [stdout] | [INFO] [stdout] 133 | get_preamble(&raw_data) == ::PFH5_PREAMBLE && has_encrypted_content(&raw_data) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:133:73 [INFO] [stdout] | [INFO] [stdout] 133 | get_preamble(&raw_data) == ::PFH5_PREAMBLE && has_encrypted_content(&raw_data) [INFO] [stdout] | ^^^^^^^^^ help: change this to: `raw_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/parse.rs:162:108 [INFO] [stdout] | [INFO] [stdout] 162 | Ok(LittleEndian::read_u32(&self.view.read(self.index_position as u64..self.index_position as u64 + 4 as u64)?.to_vec())) [INFO] [stdout] | ^^^^^^^^ help: try: `4_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:171:50 [INFO] [stdout] | [INFO] [stdout] 171 | item_length = if has_encrypted_index(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:179:58 [INFO] [stdout] | [INFO] [stdout] 179 | let timestamp = if has_index_with_timestamps(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:187:29 [INFO] [stdout] | [INFO] [stdout] 187 | if get_preamble(&self.view) == ::PFH5_PREAMBLE && !has_big_header(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:187:79 [INFO] [stdout] | [INFO] [stdout] 187 | if get_preamble(&self.view) == ::PFH5_PREAMBLE && !has_big_header(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:191:67 [INFO] [stdout] | [INFO] [stdout] 191 | ... let remaining_index_size = get_packed_file_index_size(&self.view) - (self.index_position - get_static_header_size(&self.view)... [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:191:127 [INFO] [stdout] | [INFO] [stdout] 191 | ...f.index_position - get_static_header_size(&self.view) - get_pack_file_index_size(&self.view)); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:191:166 [INFO] [stdout] | [INFO] [stdout] 191 | ...ze(&self.view) - get_pack_file_index_size(&self.view)); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:192:59 [INFO] [stdout] | [INFO] [stdout] 192 | let (file_path, len) = if has_encrypted_index(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:212:63 [INFO] [stdout] | [INFO] [stdout] 212 | let padded_item_length = if has_encrypted_content(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:226:28 [INFO] [stdout] | [INFO] [stdout] 226 | if has_padding(&self.view) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:237:61 [INFO] [stdout] | [INFO] [stdout] 237 | is_encrypted: has_encrypted_content(&self.view), [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/parse.rs:251:9 [INFO] [stdout] | [INFO] [stdout] 251 | / match self.get_next() { [INFO] [stdout] 252 | | Ok(item) => Some(item), [INFO] [stdout] 253 | | Err(_) => None [INFO] [stdout] 254 | | } [INFO] [stdout] | |_________^ help: replace with: `self.get_next().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parse.rs:281:8 [INFO] [stdout] | [INFO] [stdout] 281 | if !::PFHFlags::from_bits(LittleEndian::read_u32(&file_view.read(0x04..0x08)?.to_vec()) & !0xf).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `::PFHFlags::from_bits(LittleEndian::read_u32(&file_view.read(0x04..0x08)?.to_vec()) & !0xf).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:233:86 [INFO] [stdout] | [INFO] [stdout] 233 | ...nge.end - lazy.range.start, format!("{} != {}", plaintext.len(), lazy.range.end - lazy.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 233 - assert!(plaintext.len() as u64 == lazy.range.end - lazy.range.start, format!("{} != {}", plaintext.len(), lazy.range.end - lazy.range.start)); [INFO] [stdout] 233 + assert!(plaintext.len() as u64 == lazy.range.end - lazy.range.start, "{} != {}", plaintext.len(), lazy.range.end - lazy.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:254:90 [INFO] [stdout] | [INFO] [stdout] 254 | ...nge.end - lazy.range.start, format!("{} != {}", plaintext.len(), lazy.range.end - lazy.range.start)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `assert!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `assert!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 254 - assert!(plaintext.len() as u64 == lazy.range.end - lazy.range.start, format!("{} != {}", plaintext.len(), lazy.range.end - lazy.range.start)); [INFO] [stdout] 254 + assert!(plaintext.len() as u64 == lazy.range.end - lazy.range.start, "{} != {}", plaintext.len(), lazy.range.end - lazy.range.start); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/build/mod.rs:12:45 [INFO] [stdout] | [INFO] [stdout] 12 | tw_pack_lib::build_pack_from_filesystem(&Path::new(&"tests/build/loadingscreen"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(&"tests/build/loadingscreen")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.70s [INFO] running `Command { std: "docker" "inspect" "a8c8223afbd60b317e5d6d7d3c0d93c64d3fda87ee4d3990925eb09fdd8df0cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8c8223afbd60b317e5d6d7d3c0d93c64d3fda87ee4d3990925eb09fdd8df0cd", kill_on_drop: false }` [INFO] [stdout] a8c8223afbd60b317e5d6d7d3c0d93c64d3fda87ee4d3990925eb09fdd8df0cd