[INFO] fetching crate tuigui 0.23.0... [INFO] linting tuigui-0.23.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tuigui 0.23.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate tuigui 0.23.0 [INFO] finished tweaking crates.io crate tuigui 0.23.0 [INFO] tweaked toml for crates.io crate tuigui 0.23.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tuigui 0.23.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding crossterm v0.28.1 (available: v0.29.0) [INFO] [stderr] Adding hashbrown v0.14.5 (available: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded owo-colors v4.3.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7dbffb46c763d4840c9c1859a2e74a11e60127d101cb1aac3f0dfa00a490f675 [INFO] running `Command { std: "docker" "start" "-a" "7dbffb46c763d4840c9c1859a2e74a11e60127d101cb1aac3f0dfa00a490f675", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7dbffb46c763d4840c9c1859a2e74a11e60127d101cb1aac3f0dfa00a490f675", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7dbffb46c763d4840c9c1859a2e74a11e60127d101cb1aac3f0dfa00a490f675", kill_on_drop: false }` [INFO] [stdout] 7dbffb46c763d4840c9c1859a2e74a11e60127d101cb1aac3f0dfa00a490f675 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8558cf6b359c802a02770b0563d1b9346fb66fcacd9aa34499603e61b27ce7ff [INFO] running `Command { std: "docker" "start" "-a" "8558cf6b359c802a02770b0563d1b9346fb66fcacd9aa34499603e61b27ce7ff", kill_on_drop: false }` [INFO] [stderr] Compiling owo-colors v4.3.0 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking tuigui v0.23.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you should consider adding a `Default` implementation for `WidgetData` [INFO] [stdout] --> src/widget.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn new() -> Self { [INFO] [stdout] 28 | | Self { [INFO] [stdout] 29 | | animation_data: AnimationData::new(), [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 26 + impl Default for WidgetData { [INFO] [stdout] 27 + fn default() -> Self { [INFO] [stdout] 28 + Self::new() [INFO] [stdout] 29 + } [INFO] [stdout] 30 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `WidgetData` [INFO] [stdout] --> src/widget.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | / pub fn new() -> Self { [INFO] [stdout] 28 | | Self { [INFO] [stdout] 29 | | animation_data: AnimationData::new(), [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 26 + impl Default for WidgetData { [INFO] [stdout] 27 + fn default() -> Self { [INFO] [stdout] 28 + Self::new() [INFO] [stdout] 29 + } [INFO] [stdout] 30 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AnimationData` [INFO] [stdout] --> src/widget.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / pub fn new() -> Self { [INFO] [stdout] 42 | | Self { [INFO] [stdout] 43 | | creation_time: std::time::Instant::now(), [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 40 + impl Default for AnimationData { [INFO] [stdout] 41 + fn default() -> Self { [INFO] [stdout] 42 + Self::new() [INFO] [stdout] 43 + } [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widget.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | return self.creation_time; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return self.creation_time; [INFO] [stdout] 54 + self.creation_time [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widget.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return std::time::Instant::now() - self.creation_time(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return std::time::Instant::now() - self.creation_time(); [INFO] [stdout] 59 + std::time::Instant::now() - self.creation_time() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AnimationData` [INFO] [stdout] --> src/widget.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / pub fn new() -> Self { [INFO] [stdout] 42 | | Self { [INFO] [stdout] 43 | | creation_time: std::time::Instant::now(), [INFO] [stdout] 44 | | } [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 40 + impl Default for AnimationData { [INFO] [stdout] 41 + fn default() -> Self { [INFO] [stdout] 42 + Self::new() [INFO] [stdout] 43 + } [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widget.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | return self.creation_time; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return self.creation_time; [INFO] [stdout] 54 + self.creation_time [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widget.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | return std::time::Instant::now() - self.creation_time(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return std::time::Instant::now() - self.creation_time(); [INFO] [stdout] 59 + std::time::Instant::now() - self.creation_time() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widget.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | return new_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return new_size; [INFO] [stdout] 201 + new_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animation.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return animated_transform; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return animated_transform; [INFO] [stdout] 26 + animated_transform [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widget.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 201 | return new_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 201 - return new_size; [INFO] [stdout] 201 + new_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animation.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return animated_transform; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return animated_transform; [INFO] [stdout] 26 + animated_transform [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/style.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | impl Into for AnsiColor { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 41 ~ impl From for Color { [INFO] [stdout] 42 ~ fn from(val: AnsiColor) -> Self { [INFO] [stdout] 43 ~ Color::Ansi(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/style.rs:47:1 [INFO] [stdout] | [INFO] [stdout] 47 | impl Into for Color { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 47 ~ impl From for StyleGround { [INFO] [stdout] 48 ~ fn from(val: Color) -> Self { [INFO] [stdout] 49 ~ StyleGround::Color(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/style.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | impl Into for AnsiColor { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 41 ~ impl From for Color { [INFO] [stdout] 42 ~ fn from(val: AnsiColor) -> Self { [INFO] [stdout] 43 ~ Color::Ansi(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/style.rs:47:1 [INFO] [stdout] | [INFO] [stdout] 47 | impl Into for Color { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 47 ~ impl From for StyleGround { [INFO] [stdout] 48 ~ fn from(val: Color) -> Self { [INFO] [stdout] 49 ~ StyleGround::Color(val) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/style.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | impl> Into for Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 53 ~ impl> From> for StyleGround { [INFO] [stdout] 54 ~ fn from(val: Option) -> Self { [INFO] [stdout] 55 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/style.rs:53:1 [INFO] [stdout] | [INFO] [stdout] 53 | impl> Into for Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 53 ~ impl> From> for StyleGround { [INFO] [stdout] 54 ~ fn from(val: Option) -> Self { [INFO] [stdout] 55 ~ match val { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / return match self { [INFO] [stdout] 121 | | Self::Clear => true, [INFO] [stdout] 122 | | Self::Color(_) => true, [INFO] [stdout] 123 | | Self::Transparent(_) => false, [INFO] [stdout] 124 | | Self::Filler(_) => false, [INFO] [stdout] 125 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 ~ match self { [INFO] [stdout] 121 + Self::Clear => true, [INFO] [stdout] 122 + Self::Color(_) => true, [INFO] [stdout] 123 + Self::Transparent(_) => false, [INFO] [stdout] 124 + Self::Filler(_) => false, [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | / return match self { [INFO] [stdout] 131 | | Self::Color(_) => true, [INFO] [stdout] 132 | | _ => false, [INFO] [stdout] 133 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 ~ match self { [INFO] [stdout] 131 + Self::Color(_) => true, [INFO] [stdout] 132 + _ => false, [INFO] [stdout] 133 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/style.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 130 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 131 | | Self::Color(_) => true, [INFO] [stdout] 132 | | _ => false, [INFO] [stdout] 133 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 130 - return match self { [INFO] [stdout] 131 - Self::Color(_) => true, [INFO] [stdout] 132 - _ => false, [INFO] [stdout] 133 - }; [INFO] [stdout] 130 + return matches!(self, Self::Color(_)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | / return match self { [INFO] [stdout] 139 | | Self::Clear => true, [INFO] [stdout] 140 | | _ => false, [INFO] [stdout] 141 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 ~ match self { [INFO] [stdout] 139 + Self::Clear => true, [INFO] [stdout] 140 + _ => false, [INFO] [stdout] 141 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/style.rs:138:16 [INFO] [stdout] | [INFO] [stdout] 138 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 139 | | Self::Clear => true, [INFO] [stdout] 140 | | _ => false, [INFO] [stdout] 141 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 138 - return match self { [INFO] [stdout] 139 - Self::Clear => true, [INFO] [stdout] 140 - _ => false, [INFO] [stdout] 141 - }; [INFO] [stdout] 138 + return matches!(self, Self::Clear); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Style` [INFO] [stdout] --> src/style.rs:154:5 [INFO] [stdout] | [INFO] [stdout] 154 | / pub fn new() -> Self { [INFO] [stdout] 155 | | Self { [INFO] [stdout] 156 | | fg: StyleGround::Clear, [INFO] [stdout] 157 | | bg: StyleGround::Clear, [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 153 + impl Default for Style { [INFO] [stdout] 154 + fn default() -> Self { [INFO] [stdout] 155 + Self::new() [INFO] [stdout] 156 + } [INFO] [stdout] 157 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return self; [INFO] [stdout] 165 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | / return match self { [INFO] [stdout] 121 | | Self::Clear => true, [INFO] [stdout] 122 | | Self::Color(_) => true, [INFO] [stdout] 123 | | Self::Transparent(_) => false, [INFO] [stdout] 124 | | Self::Filler(_) => false, [INFO] [stdout] 125 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 ~ match self { [INFO] [stdout] 121 + Self::Clear => true, [INFO] [stdout] 122 + Self::Color(_) => true, [INFO] [stdout] 123 + Self::Transparent(_) => false, [INFO] [stdout] 124 + Self::Filler(_) => false, [INFO] [stdout] 125 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | / return match self { [INFO] [stdout] 131 | | Self::Color(_) => true, [INFO] [stdout] 132 | | _ => false, [INFO] [stdout] 133 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 130 ~ match self { [INFO] [stdout] 131 + Self::Color(_) => true, [INFO] [stdout] 132 + _ => false, [INFO] [stdout] 133 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return self; [INFO] [stdout] 171 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/style.rs:130:16 [INFO] [stdout] | [INFO] [stdout] 130 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 131 | | Self::Color(_) => true, [INFO] [stdout] 132 | | _ => false, [INFO] [stdout] 133 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 130 - return match self { [INFO] [stdout] 131 - Self::Color(_) => true, [INFO] [stdout] 132 - _ => false, [INFO] [stdout] 133 - }; [INFO] [stdout] 130 + return matches!(self, Self::Color(_)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | / return match self { [INFO] [stdout] 139 | | Self::Clear => true, [INFO] [stdout] 140 | | _ => false, [INFO] [stdout] 141 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 ~ match self { [INFO] [stdout] 139 + Self::Clear => true, [INFO] [stdout] 140 + _ => false, [INFO] [stdout] 141 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/style.rs:138:16 [INFO] [stdout] | [INFO] [stdout] 138 | return match self { [INFO] [stdout] | ________________^ [INFO] [stdout] 139 | | Self::Clear => true, [INFO] [stdout] 140 | | _ => false, [INFO] [stdout] 141 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 138 - return match self { [INFO] [stdout] 139 - Self::Clear => true, [INFO] [stdout] 140 - _ => false, [INFO] [stdout] 141 - }; [INFO] [stdout] 138 + return matches!(self, Self::Clear); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return self; [INFO] [stdout] 177 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return self; [INFO] [stdout] 185 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | return self.effects.contains(&effect); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return self.effects.contains(&effect); [INFO] [stdout] 189 + self.effects.contains(&effect) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Style` [INFO] [stdout] --> src/style.rs:154:5 [INFO] [stdout] | [INFO] [stdout] 154 | / pub fn new() -> Self { [INFO] [stdout] 155 | | Self { [INFO] [stdout] 156 | | fg: StyleGround::Clear, [INFO] [stdout] 157 | | bg: StyleGround::Clear, [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 153 + impl Default for Style { [INFO] [stdout] 154 + fn default() -> Self { [INFO] [stdout] 155 + Self::new() [INFO] [stdout] 156 + } [INFO] [stdout] 157 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return self; [INFO] [stdout] 165 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:171:9 [INFO] [stdout] | [INFO] [stdout] 171 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 171 - return self; [INFO] [stdout] 171 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return self; [INFO] [stdout] 177 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return self; [INFO] [stdout] 185 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/style.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | return self.effects.contains(&effect); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 189 - return self.effects.contains(&effect); [INFO] [stdout] 189 + self.effects.contains(&effect) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CrosstermBackend` [INFO] [stdout] --> src/backends/b_crossterm.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | / pub fn new() -> Self { [INFO] [stdout] 66 | | Self { [INFO] [stdout] 67 | | stdout: io::stdout(), [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 64 + impl Default for CrosstermBackend { [INFO] [stdout] 65 + fn default() -> Self { [INFO] [stdout] 66 + Self::new() [INFO] [stdout] 67 + } [INFO] [stdout] 68 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `CrosstermBackend` [INFO] [stdout] --> src/backends/b_crossterm.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | / pub fn new() -> Self { [INFO] [stdout] 66 | | Self { [INFO] [stdout] 67 | | stdout: io::stdout(), [INFO] [stdout] 68 | | } [INFO] [stdout] 69 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 64 + impl Default for CrosstermBackend { [INFO] [stdout] 65 + fn default() -> Self { [INFO] [stdout] 66 + Self::new() [INFO] [stdout] 67 + } [INFO] [stdout] 68 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OwoColorsContentProcessor` [INFO] [stdout] --> src/content_processors/p_owo_colors.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / pub fn new() -> Self { [INFO] [stdout] 10 | | Self {} [INFO] [stdout] 11 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 8 + impl Default for OwoColorsContentProcessor { [INFO] [stdout] 9 + fn default() -> Self { [INFO] [stdout] 10 + Self::new() [INFO] [stdout] 11 + } [INFO] [stdout] 12 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/content_processors/p_owo_colors.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return result; [INFO] [stdout] 40 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OwoColorsContentProcessor` [INFO] [stdout] --> src/content_processors/p_owo_colors.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / pub fn new() -> Self { [INFO] [stdout] 10 | | Self {} [INFO] [stdout] 11 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 8 + impl Default for OwoColorsContentProcessor { [INFO] [stdout] 9 + fn default() -> Self { [INFO] [stdout] 10 + Self::new() [INFO] [stdout] 11 + } [INFO] [stdout] 12 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BareBonesContentProcessor` [INFO] [stdout] --> src/content_processors/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> Self { [INFO] [stdout] 22 | | Self {} [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for BareBonesContentProcessor { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/content_processors/p_owo_colors.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return result; [INFO] [stdout] 40 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / return Position { [INFO] [stdout] 30 | | col: match orien { [INFO] [stdout] 31 | | Orientation::Horizontal => single, [INFO] [stdout] 32 | | Orientation::Vertical => opposite, [INFO] [stdout] ... | [INFO] [stdout] 37 | | }, [INFO] [stdout] 38 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Position { [INFO] [stdout] 30 + col: match orien { [INFO] [stdout] 31 + Orientation::Horizontal => single, [INFO] [stdout] 32 + Orientation::Vertical => opposite, [INFO] [stdout] 33 + }, [INFO] [stdout] 34 + row: match orien { [INFO] [stdout] 35 + Orientation::Horizontal => opposite, [INFO] [stdout] 36 + Orientation::Vertical => single, [INFO] [stdout] 37 + }, [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / return Size { [INFO] [stdout] 43 | | cols: match orien { [INFO] [stdout] 44 | | Orientation::Horizontal => single, [INFO] [stdout] 45 | | Orientation::Vertical => opposite, [INFO] [stdout] ... | [INFO] [stdout] 50 | | }, [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 ~ Size { [INFO] [stdout] 43 + cols: match orien { [INFO] [stdout] 44 + Orientation::Horizontal => single, [INFO] [stdout] 45 + Orientation::Vertical => opposite, [INFO] [stdout] 46 + }, [INFO] [stdout] 47 + rows: match orien { [INFO] [stdout] 48 + Orientation::Horizontal => opposite, [INFO] [stdout] 49 + Orientation::Vertical => single, [INFO] [stdout] 50 + }, [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return orien == Orientation::Horizontal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return orien == Orientation::Horizontal; [INFO] [stdout] 55 + orien == Orientation::Horizontal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/box_container.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if canvas.is_visible() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.is_visible()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/box_container.rs:176:32 [INFO] [stdout] | [INFO] [stdout] 176 | ... if check == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!check` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BareBonesContentProcessor` [INFO] [stdout] --> src/content_processors/mod.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> Self { [INFO] [stdout] 22 | | Self {} [INFO] [stdout] 23 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for BareBonesContentProcessor { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `canvas_vec` [INFO] [stdout] --> src/widgets/box_container.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 226 | for i in 0..self.widgets.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 226 - for i in 0..self.widgets.len() { [INFO] [stdout] 226 + for (i, ) in canvas_vec.iter_mut().enumerate().take(self.widgets.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / return Position { [INFO] [stdout] 30 | | col: match orien { [INFO] [stdout] 31 | | Orientation::Horizontal => single, [INFO] [stdout] 32 | | Orientation::Vertical => opposite, [INFO] [stdout] ... | [INFO] [stdout] 37 | | }, [INFO] [stdout] 38 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ Position { [INFO] [stdout] 30 + col: match orien { [INFO] [stdout] 31 + Orientation::Horizontal => single, [INFO] [stdout] 32 + Orientation::Vertical => opposite, [INFO] [stdout] 33 + }, [INFO] [stdout] 34 + row: match orien { [INFO] [stdout] 35 + Orientation::Horizontal => opposite, [INFO] [stdout] 36 + Orientation::Vertical => single, [INFO] [stdout] 37 + }, [INFO] [stdout] 38 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | / return WidgetInfo { [INFO] [stdout] 247 | | size_info: WidgetSizeInfo::Dynamic { [INFO] [stdout] 248 | | min: size_min, [INFO] [stdout] 249 | | max: None, [INFO] [stdout] 250 | | }, [INFO] [stdout] 251 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 ~ WidgetInfo { [INFO] [stdout] 247 + size_info: WidgetSizeInfo::Dynamic { [INFO] [stdout] 248 + min: size_min, [INFO] [stdout] 249 + max: None, [INFO] [stdout] 250 + }, [INFO] [stdout] 251 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | / return Size { [INFO] [stdout] 43 | | cols: match orien { [INFO] [stdout] 44 | | Orientation::Horizontal => single, [INFO] [stdout] 45 | | Orientation::Vertical => opposite, [INFO] [stdout] ... | [INFO] [stdout] 50 | | }, [INFO] [stdout] 51 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 ~ Size { [INFO] [stdout] 43 + cols: match orien { [INFO] [stdout] 44 + Orientation::Horizontal => single, [INFO] [stdout] 45 + Orientation::Vertical => opposite, [INFO] [stdout] 46 + }, [INFO] [stdout] 47 + rows: match orien { [INFO] [stdout] 48 + Orientation::Horizontal => opposite, [INFO] [stdout] 49 + Orientation::Vertical => single, [INFO] [stdout] 50 + }, [INFO] [stdout] 51 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | return orien == Orientation::Horizontal; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return orien == Orientation::Horizontal; [INFO] [stdout] 55 + orien == Orientation::Horizontal [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/box_container.rs:77:12 [INFO] [stdout] | [INFO] [stdout] 77 | if canvas.is_visible() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.is_visible()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 255 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - return &mut self.widget_data; [INFO] [stdout] 255 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/margin_container.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if canvas.is_visible() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.is_visible()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/box_container.rs:176:32 [INFO] [stdout] | [INFO] [stdout] 176 | ... if check == false { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `!check` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/widgets/margin_container.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | let size: Size; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `size` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 47 ~ [INFO] [stdout] 48 | [INFO] [stdout] 49 ~ let size: Size = if canvas.transform.size.rows < subtract.rows || canvas.transform.size.cols < subtract.cols { [INFO] [stdout] 50 ~ subtract [INFO] [stdout] 51 | } else { [INFO] [stdout] 52 ~ canvas.transform.size - subtract [INFO] [stdout] 53 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `canvas_vec` [INFO] [stdout] --> src/widgets/box_container.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 226 | for i in 0..self.widgets.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 226 - for i in 0..self.widgets.len() { [INFO] [stdout] 226 + for (i, ) in canvas_vec.iter_mut().enumerate().take(self.widgets.len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/margin_container.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / return WidgetInfo { [INFO] [stdout] 99 | | size_info, [INFO] [stdout] 100 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 ~ WidgetInfo { [INFO] [stdout] 99 + size_info, [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/widgets/margin_container.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | let size_info: WidgetSizeInfo; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `size_info` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 66 ~ [INFO] [stdout] 67 | [INFO] [stdout] ... [INFO] [stdout] 72 | [INFO] [stdout] 73 ~ let size_info: WidgetSizeInfo = if addition == Size::new(0, 0) { [INFO] [stdout] 74 ~ child_info.size_info [INFO] [stdout] 75 | } [INFO] [stdout] 76 | [INFO] [stdout] 77 | else { [INFO] [stdout] 78 ~ match child_info.size_info { [INFO] [stdout] 79 | WidgetSizeInfo::Dynamic { min, max } => { [INFO] [stdout] ... [INFO] [stdout] 94 | ), [INFO] [stdout] 95 ~ } [INFO] [stdout] 96 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/widgets/margin_container.rs:82:35 [INFO] [stdout] | [INFO] [stdout] 82 | let new_max = match max { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 83 | | Some(s) => Some(s + addition), [INFO] [stdout] 84 | | None => None, [INFO] [stdout] 85 | | }; [INFO] [stdout] | |_____________________^ help: try: `max.map(|s| s + addition)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | / return WidgetInfo { [INFO] [stdout] 247 | | size_info: WidgetSizeInfo::Dynamic { [INFO] [stdout] 248 | | min: size_min, [INFO] [stdout] 249 | | max: None, [INFO] [stdout] 250 | | }, [INFO] [stdout] 251 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 ~ WidgetInfo { [INFO] [stdout] 247 + size_info: WidgetSizeInfo::Dynamic { [INFO] [stdout] 248 + min: size_min, [INFO] [stdout] 249 + max: None, [INFO] [stdout] 250 + }, [INFO] [stdout] 251 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/margin_container.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return &mut self.widget_data; [INFO] [stdout] 104 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/box_container.rs:255:9 [INFO] [stdout] | [INFO] [stdout] 255 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 255 - return &mut self.widget_data; [INFO] [stdout] 255 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/margin_container.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | if canvas.is_visible() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.is_visible()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/widgets/margin_container.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | let size: Size; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `size` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 47 ~ [INFO] [stdout] 48 | [INFO] [stdout] 49 ~ let size: Size = if canvas.transform.size.rows < subtract.rows || canvas.transform.size.cols < subtract.cols { [INFO] [stdout] 50 ~ subtract [INFO] [stdout] 51 | } else { [INFO] [stdout] 52 ~ canvas.transform.size - subtract [INFO] [stdout] 53 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/margin_container.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | / return WidgetInfo { [INFO] [stdout] 99 | | size_info, [INFO] [stdout] 100 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 ~ WidgetInfo { [INFO] [stdout] 99 + size_info, [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/widgets/margin_container.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | let size_info: WidgetSizeInfo; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `size_info` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 66 ~ [INFO] [stdout] 67 | [INFO] [stdout] ... [INFO] [stdout] 72 | [INFO] [stdout] 73 ~ let size_info: WidgetSizeInfo = if addition == Size::new(0, 0) { [INFO] [stdout] 74 ~ child_info.size_info [INFO] [stdout] 75 | } [INFO] [stdout] 76 | [INFO] [stdout] 77 | else { [INFO] [stdout] 78 ~ match child_info.size_info { [INFO] [stdout] 79 | WidgetSizeInfo::Dynamic { min, max } => { [INFO] [stdout] ... [INFO] [stdout] 94 | ), [INFO] [stdout] 95 ~ } [INFO] [stdout] 96 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/widgets/margin_container.rs:82:35 [INFO] [stdout] | [INFO] [stdout] 82 | let new_max = match max { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 83 | | Some(s) => Some(s + addition), [INFO] [stdout] 84 | | None => None, [INFO] [stdout] 85 | | }; [INFO] [stdout] | |_____________________^ help: try: `max.map(|s| s + addition)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/margin_container.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return &mut self.widget_data; [INFO] [stdout] 104 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/anchor_container.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if canvas.is_visible() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.is_visible()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/anchor_container.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return &mut self.widget_data; [INFO] [stdout] 144 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/anchor_container.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if canvas.is_visible() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.is_visible()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/anchor_container.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return &mut self.widget_data; [INFO] [stdout] 144 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/animation_container.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if self.is_playing == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.is_playing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/animation_container.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return self.is_playing; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return self.is_playing; [INFO] [stdout] 68 + self.is_playing [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/animation_container.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return self.is_done; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return self.is_done; [INFO] [stdout] 73 + self.is_done [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/animation_container.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 102 | if is_playing && is_done == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!is_done` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/animation_container.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return self.widget.widget_info(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return self.widget.widget_info(); [INFO] [stdout] 148 + self.widget.widget_info() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/animation_container.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return &mut self.widget_data; [INFO] [stdout] 152 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/animation_container.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 43 | if self.is_playing == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.is_playing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/animation_container.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return self.is_playing; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return self.is_playing; [INFO] [stdout] 68 + self.is_playing [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/widgets/shader_container.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / if shader_config.whole_area == false { [INFO] [stdout] 54 | | if canvas.changed_at(local_position) == false { [INFO] [stdout] 55 | | return; [INFO] [stdout] 56 | | } [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 53 ~ if shader_config.whole_area == false [INFO] [stdout] 54 ~ && canvas.changed_at(local_position) == false { [INFO] [stdout] 55 | return; [INFO] [stdout] 56 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/shader_container.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if shader_config.whole_area == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!shader_config.whole_area` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/animation_container.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | return self.is_done; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return self.is_done; [INFO] [stdout] 73 + self.is_done [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/shader_container.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | if canvas.changed_at(local_position) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.changed_at(local_position)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/animation_container.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 102 | if is_playing && is_done == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!is_done` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/animation_container.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | return self.widget.widget_info(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 148 - return self.widget.widget_info(); [INFO] [stdout] 148 + self.widget.widget_info() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/shader_container.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return self.widget.widget_info(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return self.widget.widget_info(); [INFO] [stdout] 91 + self.widget.widget_info() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/animation_container.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return &mut self.widget_data; [INFO] [stdout] 152 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/shader_container.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return &mut self.widget_data; [INFO] [stdout] 95 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/float_container.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return self.widget.widget_info(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return self.widget.widget_info(); [INFO] [stdout] 31 + self.widget.widget_info() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/float_container.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return &mut self.widget_data; [INFO] [stdout] 35 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/widgets/shader_container.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / if shader_config.whole_area == false { [INFO] [stdout] 54 | | if canvas.changed_at(local_position) == false { [INFO] [stdout] 55 | | return; [INFO] [stdout] 56 | | } [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 53 ~ if shader_config.whole_area == false [INFO] [stdout] 54 ~ && canvas.changed_at(local_position) == false { [INFO] [stdout] 55 | return; [INFO] [stdout] 56 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/shader_container.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if shader_config.whole_area == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!shader_config.whole_area` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/shader_container.rs:54:12 [INFO] [stdout] | [INFO] [stdout] 54 | if canvas.changed_at(local_position) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.changed_at(local_position)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/grow_container.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return &mut self.widget_data; [INFO] [stdout] 53 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/shader_container.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | return self.widget.widget_info(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 91 - return self.widget.widget_info(); [INFO] [stdout] 91 + self.widget.widget_info() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/shader_container.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return &mut self.widget_data; [INFO] [stdout] 95 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/layers.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if canvas.is_visible() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.is_visible()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/layers.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return &mut self.widget_data; [INFO] [stdout] 49 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/float_container.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | return self.widget.widget_info(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return self.widget.widget_info(); [INFO] [stdout] 31 + self.widget.widget_info() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/float_container.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return &mut self.widget_data; [INFO] [stdout] 35 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/grow_container.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - return &mut self.widget_data; [INFO] [stdout] 53 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/label.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return lbl; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return lbl; [INFO] [stdout] 37 + lbl [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/widgets/layers.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if canvas.is_visible() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!canvas.is_visible()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/layers.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return &mut self.widget_data; [INFO] [stdout] 49 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/label.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return &mut self.widget_data; [INFO] [stdout] 89 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/widget_pointer.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return &mut self.widget_data; [INFO] [stdout] 77 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/widget_dyn.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self.widget.widget_info(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self.widget.widget_info(); [INFO] [stdout] 25 + self.widget.widget_info() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/widget_dyn.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return &mut self.widget_data; [INFO] [stdout] 29 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/label.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return lbl; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return lbl; [INFO] [stdout] 37 + lbl [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/fill.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return &mut self.widget_data; [INFO] [stdout] 39 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/label.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return &mut self.widget_data; [INFO] [stdout] 89 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/widget_pointer.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return &mut self.widget_data; [INFO] [stdout] 77 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PixelGrid` [INFO] [stdout] --> src/widgets/pixel_grid.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / pub fn new() -> Self { [INFO] [stdout] 36 | | Self { [INFO] [stdout] 37 | | filler: None, [INFO] [stdout] 38 | | dual_char_top: DUAL_CHAR_TOP, [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 34 + impl Default for PixelGrid { [INFO] [stdout] 35 + fn default() -> Self { [INFO] [stdout] 36 + Self::new() [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/pixel_grid.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | / return match self.pixels.get(&position) { [INFO] [stdout] 58 | | Some(s) => Some(*s), [INFO] [stdout] 59 | | None => self.filler, [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 ~ match self.pixels.get(&position) { [INFO] [stdout] 58 + Some(s) => Some(*s), [INFO] [stdout] 59 + None => self.filler, [INFO] [stdout] 60 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/widget_dyn.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self.widget.widget_info(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self.widget.widget_info(); [INFO] [stdout] 25 + self.widget.widget_info() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/widgets/pixel_grid.rs:69:36 [INFO] [stdout] | [INFO] [stdout] 69 | let color: Option = match color { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 70 | | Some(s) => Some(s.into()), [INFO] [stdout] 71 | | None => None, [INFO] [stdout] 72 | | }; [INFO] [stdout] | |_________^ help: try: `color.map(|s| s.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/widget_dyn.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return &mut self.widget_data; [INFO] [stdout] 29 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/pixel_grid.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return content; [INFO] [stdout] 105 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/widgets/pixel_grid.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | let content: Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `content` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 89 ~ [INFO] [stdout] 90 | [INFO] [stdout] 91 ~ let content: Option = if top_pixel == bottom_pixel { [INFO] [stdout] 92 ~ Some(match top_pixel { [INFO] [stdout] 93 | Some(s) => Content::Styled(self.single_char, Style::new().fg(Some(s))), [INFO] [stdout] 94 | None => Content::Styled(' ', Style::new().bg(self.transparent_style_ground)), [INFO] [stdout] 95 ~ }) [INFO] [stdout] 96 | } else { [INFO] [stdout] 97 ~ Some(match (top_pixel, bottom_pixel) { [INFO] [stdout] 98 | (Some(top), Some(bottom)) => Content::Styled(self.dual_char_top, Style::new().fg(Some(top)).bg(Some(bottom))), [INFO] [stdout] ... [INFO] [stdout] 101 | _ => unreachable!(), [INFO] [stdout] 102 ~ }) [INFO] [stdout] 103 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/fill.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return &mut self.widget_data; [INFO] [stdout] 39 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/pixel_grid.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return &mut self.widget_data; [INFO] [stdout] 151 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/animation_dyn.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return self.animation.animated_transform(original_transform, duration_seconds); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return self.animation.animated_transform(original_transform, duration_seconds); [INFO] [stdout] 19 + self.animation.animated_transform(original_transform, duration_seconds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/animation_dyn.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return self.animation.is_done(duration_seconds); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return self.animation.is_done(duration_seconds); [INFO] [stdout] 23 + self.animation.is_done(duration_seconds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `PixelGrid` [INFO] [stdout] --> src/widgets/pixel_grid.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / pub fn new() -> Self { [INFO] [stdout] 36 | | Self { [INFO] [stdout] 37 | | filler: None, [INFO] [stdout] 38 | | dual_char_top: DUAL_CHAR_TOP, [INFO] [stdout] ... | [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 34 + impl Default for PixelGrid { [INFO] [stdout] 35 + fn default() -> Self { [INFO] [stdout] 36 + Self::new() [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/quadratic_bezier.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / return self.end.apply_quadratic_bezier( [INFO] [stdout] 40 | | self.control, [INFO] [stdout] 41 | | original_transform, [INFO] [stdout] 42 | | t, [INFO] [stdout] 43 | | functions::quadratic_bezier, [INFO] [stdout] 44 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ self.end.apply_quadratic_bezier( [INFO] [stdout] 40 + self.control, [INFO] [stdout] 41 + original_transform, [INFO] [stdout] 42 + t, [INFO] [stdout] 43 + functions::quadratic_bezier, [INFO] [stdout] 44 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/pixel_grid.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | / return match self.pixels.get(&position) { [INFO] [stdout] 58 | | Some(s) => Some(*s), [INFO] [stdout] 59 | | None => self.filler, [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 ~ match self.pixels.get(&position) { [INFO] [stdout] 58 + Some(s) => Some(*s), [INFO] [stdout] 59 + None => self.filler, [INFO] [stdout] 60 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/widgets/pixel_grid.rs:69:36 [INFO] [stdout] | [INFO] [stdout] 69 | let color: Option = match color { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 70 | | Some(s) => Some(s.into()), [INFO] [stdout] 71 | | None => None, [INFO] [stdout] 72 | | }; [INFO] [stdout] | |_________^ help: try: `color.map(|s| s.into())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/quadratic_bezier.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return duration_seconds >= self.last_for_seconds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return duration_seconds >= self.last_for_seconds; [INFO] [stdout] 48 + duration_seconds >= self.last_for_seconds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/pixel_grid.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return content; [INFO] [stdout] 105 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/widgets/pixel_grid.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | let content: Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `content` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 89 ~ [INFO] [stdout] 90 | [INFO] [stdout] 91 ~ let content: Option = if top_pixel == bottom_pixel { [INFO] [stdout] 92 ~ Some(match top_pixel { [INFO] [stdout] 93 | Some(s) => Content::Styled(self.single_char, Style::new().fg(Some(s))), [INFO] [stdout] 94 | None => Content::Styled(' ', Style::new().bg(self.transparent_style_ground)), [INFO] [stdout] 95 ~ }) [INFO] [stdout] 96 | } else { [INFO] [stdout] 97 ~ Some(match (top_pixel, bottom_pixel) { [INFO] [stdout] 98 | (Some(top), Some(bottom)) => Content::Styled(self.dual_char_top, Style::new().fg(Some(top)).bg(Some(bottom))), [INFO] [stdout] ... [INFO] [stdout] 101 | _ => unreachable!(), [INFO] [stdout] 102 ~ }) [INFO] [stdout] 103 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/cubic_bezier.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / return self.end.apply_cubic_bezier( [INFO] [stdout] 43 | | self.end_control, [INFO] [stdout] 44 | | original_transform, [INFO] [stdout] 45 | | self.original_control, [INFO] [stdout] 46 | | t, [INFO] [stdout] 47 | | functions::cubic_bezier, [INFO] [stdout] 48 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 ~ self.end.apply_cubic_bezier( [INFO] [stdout] 43 + self.end_control, [INFO] [stdout] 44 + original_transform, [INFO] [stdout] 45 + self.original_control, [INFO] [stdout] 46 + t, [INFO] [stdout] 47 + functions::cubic_bezier, [INFO] [stdout] 48 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/cubic_bezier.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return duration_seconds >= self.last_for_seconds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return duration_seconds >= self.last_for_seconds; [INFO] [stdout] 52 + duration_seconds >= self.last_for_seconds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return a + (b - a) * t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return a + (b - a) * t; [INFO] [stdout] 29 + a + (b - a) * t [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return lerp(a, b, t * t * (3.0 - 2.0 * t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return lerp(a, b, t * t * (3.0 - 2.0 * t)); [INFO] [stdout] 33 + lerp(a, b, t * t * (3.0 - 2.0 * t)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/widgets/pixel_grid.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return &mut self.widget_data; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return &mut self.widget_data; [INFO] [stdout] 151 + &mut self.widget_data [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return lerp(l1, l2, t); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return lerp(l1, l2, t); [INFO] [stdout] 40 + lerp(l1, l2, t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return lerp(q1, q2, t); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return lerp(q1, q2, t); [INFO] [stdout] 51 + lerp(q1, q2, t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/animation_dyn.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return self.animation.animated_transform(original_transform, duration_seconds); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return self.animation.animated_transform(original_transform, duration_seconds); [INFO] [stdout] 19 + self.animation.animated_transform(original_transform, duration_seconds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/animation_dyn.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | return self.animation.is_done(duration_seconds); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return self.animation.is_done(duration_seconds); [INFO] [stdout] 23 + self.animation.is_done(duration_seconds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return self.end.apply_lerp(original_transform, t, self.lerp); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return self.end.apply_lerp(original_transform, t, self.lerp); [INFO] [stdout] 92 + self.end.apply_lerp(original_transform, t, self.lerp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/quadratic_bezier.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / return self.end.apply_quadratic_bezier( [INFO] [stdout] 40 | | self.control, [INFO] [stdout] 41 | | original_transform, [INFO] [stdout] 42 | | t, [INFO] [stdout] 43 | | functions::quadratic_bezier, [INFO] [stdout] 44 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 ~ self.end.apply_quadratic_bezier( [INFO] [stdout] 40 + self.control, [INFO] [stdout] 41 + original_transform, [INFO] [stdout] 42 + t, [INFO] [stdout] 43 + functions::quadratic_bezier, [INFO] [stdout] 44 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return duration_seconds >= self.last_for_seconds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return duration_seconds >= self.last_for_seconds; [INFO] [stdout] 96 + duration_seconds >= self.last_for_seconds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/quadratic_bezier.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return duration_seconds >= self.last_for_seconds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return duration_seconds >= self.last_for_seconds; [INFO] [stdout] 48 + duration_seconds >= self.last_for_seconds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shaders/shader_dyn.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return self.shader.apply(canvas, position, content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return self.shader.apply(canvas, position, content); [INFO] [stdout] 20 + self.shader.apply(canvas, position, content) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shaders/shader_dyn.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return self.shader.config(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return self.shader.config(); [INFO] [stdout] 24 + self.shader.config() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/cubic_bezier.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / return self.end.apply_cubic_bezier( [INFO] [stdout] 43 | | self.end_control, [INFO] [stdout] 44 | | original_transform, [INFO] [stdout] 45 | | self.original_control, [INFO] [stdout] 46 | | t, [INFO] [stdout] 47 | | functions::cubic_bezier, [INFO] [stdout] 48 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 ~ self.end.apply_cubic_bezier( [INFO] [stdout] 43 + self.end_control, [INFO] [stdout] 44 + original_transform, [INFO] [stdout] 45 + self.original_control, [INFO] [stdout] 46 + t, [INFO] [stdout] 47 + functions::cubic_bezier, [INFO] [stdout] 48 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/cubic_bezier.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | return duration_seconds >= self.last_for_seconds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return duration_seconds >= self.last_for_seconds; [INFO] [stdout] 52 + duration_seconds >= self.last_for_seconds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return a + (b - a) * t; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return a + (b - a) * t; [INFO] [stdout] 29 + a + (b - a) * t [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return lerp(a, b, t * t * (3.0 - 2.0 * t)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return lerp(a, b, t * t * (3.0 - 2.0 * t)); [INFO] [stdout] 33 + lerp(a, b, t * t * (3.0 - 2.0 * t)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return lerp(l1, l2, t); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return lerp(l1, l2, t); [INFO] [stdout] 40 + lerp(l1, l2, t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | return lerp(q1, q2, t); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return lerp(q1, q2, t); [INFO] [stdout] 51 + lerp(q1, q2, t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EventState` [INFO] [stdout] --> src/event.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn new() -> Self { [INFO] [stdout] 30 | | Self { [INFO] [stdout] 31 | | mouse: MouseState::new(), [INFO] [stdout] 32 | | terminal: TerminalState::new(), [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for EventState { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / return EventStateFrame { [INFO] [stdout] 39 | | mouse: self.mouse.calculate_frame(prev.mouse), [INFO] [stdout] 40 | | terminal: self.terminal.calculate_frame(prev.terminal), [INFO] [stdout] 41 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 ~ EventStateFrame { [INFO] [stdout] 39 + mouse: self.mouse.calculate_frame(prev.mouse), [INFO] [stdout] 40 + terminal: self.terminal.calculate_frame(prev.terminal), [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:92:9 [INFO] [stdout] | [INFO] [stdout] 92 | return self.end.apply_lerp(original_transform, t, self.lerp); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 92 - return self.end.apply_lerp(original_transform, t, self.lerp); [INFO] [stdout] 92 + self.end.apply_lerp(original_transform, t, self.lerp) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / return match (current, prev) { [INFO] [stdout] 61 | | (true, true) => Focus::Focused, [INFO] [stdout] 62 | | (false, false) => Focus::Unfocused, [INFO] [stdout] 63 | | (true, false) => Focus::JustNowFocused, [INFO] [stdout] 64 | | (false, true) => Focus::JustNowUnfocused, [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 ~ match (current, prev) { [INFO] [stdout] 61 + (true, true) => Focus::Focused, [INFO] [stdout] 62 + (false, false) => Focus::Unfocused, [INFO] [stdout] 63 + (true, false) => Focus::JustNowFocused, [INFO] [stdout] 64 + (false, true) => Focus::JustNowUnfocused, [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/animations/mod.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 96 | return duration_seconds >= self.last_for_seconds; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 96 - return duration_seconds >= self.last_for_seconds; [INFO] [stdout] 96 + duration_seconds >= self.last_for_seconds [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shaders/shader_dyn.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return self.shader.apply(canvas, position, content); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return self.shader.apply(canvas, position, content); [INFO] [stdout] 20 + self.shader.apply(canvas, position, content) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/shaders/shader_dyn.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return self.shader.config(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return self.shader.config(); [INFO] [stdout] 24 + self.shader.config() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TerminalState` [INFO] [stdout] --> src/event.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / pub fn new() -> Self { [INFO] [stdout] 87 | | Self { [INFO] [stdout] 88 | | focused: true, [INFO] [stdout] 89 | | paste: None, [INFO] [stdout] 90 | | } [INFO] [stdout] 91 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 85 + impl Default for TerminalState { [INFO] [stdout] 86 + fn default() -> Self { [INFO] [stdout] 87 + Self::new() [INFO] [stdout] 88 + } [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / return TerminalStateFrame { [INFO] [stdout] 96 | | focused: Focus::calculate(self.focused, prev.focused), [INFO] [stdout] 97 | | paste: self.paste.clone(), [INFO] [stdout] 98 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 ~ TerminalStateFrame { [INFO] [stdout] 96 + focused: Focus::calculate(self.focused, prev.focused), [INFO] [stdout] 97 + paste: self.paste.clone(), [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `EventState` [INFO] [stdout] --> src/event.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | / pub fn new() -> Self { [INFO] [stdout] 30 | | Self { [INFO] [stdout] 31 | | mouse: MouseState::new(), [INFO] [stdout] 32 | | terminal: TerminalState::new(), [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 28 + impl Default for EventState { [INFO] [stdout] 29 + fn default() -> Self { [INFO] [stdout] 30 + Self::new() [INFO] [stdout] 31 + } [INFO] [stdout] 32 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / return EventStateFrame { [INFO] [stdout] 39 | | mouse: self.mouse.calculate_frame(prev.mouse), [INFO] [stdout] 40 | | terminal: self.terminal.calculate_frame(prev.terminal), [INFO] [stdout] 41 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 ~ EventStateFrame { [INFO] [stdout] 39 + mouse: self.mouse.calculate_frame(prev.mouse), [INFO] [stdout] 40 + terminal: self.terminal.calculate_frame(prev.terminal), [INFO] [stdout] 41 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MouseState` [INFO] [stdout] --> src/event.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | / pub fn new() -> Self { [INFO] [stdout] 124 | | Self { [INFO] [stdout] 125 | | buttons: MouseButtonsState::new(), [INFO] [stdout] 126 | | position: Position::zero(), [INFO] [stdout] ... | [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 122 + impl Default for MouseState { [INFO] [stdout] 123 + fn default() -> Self { [INFO] [stdout] 124 + Self::new() [INFO] [stdout] 125 + } [INFO] [stdout] 126 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / return match (current, prev) { [INFO] [stdout] 61 | | (true, true) => Focus::Focused, [INFO] [stdout] 62 | | (false, false) => Focus::Unfocused, [INFO] [stdout] 63 | | (true, false) => Focus::JustNowFocused, [INFO] [stdout] 64 | | (false, true) => Focus::JustNowUnfocused, [INFO] [stdout] 65 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 60 ~ match (current, prev) { [INFO] [stdout] 61 + (true, true) => Focus::Focused, [INFO] [stdout] 62 + (false, false) => Focus::Unfocused, [INFO] [stdout] 63 + (true, false) => Focus::JustNowFocused, [INFO] [stdout] 64 + (false, true) => Focus::JustNowUnfocused, [INFO] [stdout] 65 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / return MouseStateFrame { [INFO] [stdout] 134 | | buttons: self.buttons.calculate_frame(prev.buttons), [INFO] [stdout] 135 | | position: self.position, [INFO] [stdout] 136 | | scroll: self.scroll.scroll_diff(prev.scroll), [INFO] [stdout] 137 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 ~ MouseStateFrame { [INFO] [stdout] 134 + buttons: self.buttons.calculate_frame(prev.buttons), [INFO] [stdout] 135 + position: self.position, [INFO] [stdout] 136 + scroll: self.scroll.scroll_diff(prev.scroll), [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MouseScrollState` [INFO] [stdout] --> src/event.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | / pub fn new() -> Self { [INFO] [stdout] 151 | | Self { [INFO] [stdout] 152 | | cols: 0, [INFO] [stdout] 153 | | rows: 0, [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 149 + impl Default for MouseScrollState { [INFO] [stdout] 150 + fn default() -> Self { [INFO] [stdout] 151 + Self::new() [INFO] [stdout] 152 + } [INFO] [stdout] 153 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | / return Position::new( [INFO] [stdout] 162 | | (self.cols - prev.cols) as i16, [INFO] [stdout] 163 | | (self.rows - prev.rows) as i16, [INFO] [stdout] 164 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 ~ Position::new( [INFO] [stdout] 162 + (self.cols - prev.cols) as i16, [INFO] [stdout] 163 + (self.rows - prev.rows) as i16, [INFO] [stdout] 164 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TerminalState` [INFO] [stdout] --> src/event.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 86 | / pub fn new() -> Self { [INFO] [stdout] 87 | | Self { [INFO] [stdout] 88 | | focused: true, [INFO] [stdout] 89 | | paste: None, [INFO] [stdout] 90 | | } [INFO] [stdout] 91 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 85 + impl Default for TerminalState { [INFO] [stdout] 86 + fn default() -> Self { [INFO] [stdout] 87 + Self::new() [INFO] [stdout] 88 + } [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / return TerminalStateFrame { [INFO] [stdout] 96 | | focused: Focus::calculate(self.focused, prev.focused), [INFO] [stdout] 97 | | paste: self.paste.clone(), [INFO] [stdout] 98 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 ~ TerminalStateFrame { [INFO] [stdout] 96 + focused: Focus::calculate(self.focused, prev.focused), [INFO] [stdout] 97 + paste: self.paste.clone(), [INFO] [stdout] 98 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MouseButtonsState` [INFO] [stdout] --> src/event.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | / pub fn new() -> Self { [INFO] [stdout] 204 | | Self { [INFO] [stdout] 205 | | left: false, [INFO] [stdout] 206 | | middle: false, [INFO] [stdout] ... | [INFO] [stdout] 209 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 202 + impl Default for MouseButtonsState { [INFO] [stdout] 203 + fn default() -> Self { [INFO] [stdout] 204 + Self::new() [INFO] [stdout] 205 + } [INFO] [stdout] 206 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | / return match button { [INFO] [stdout] 214 | | MouseButton::Left => self.left, [INFO] [stdout] 215 | | MouseButton::Middle => self.middle, [INFO] [stdout] 216 | | MouseButton::Right => self.right, [INFO] [stdout] 217 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 ~ match button { [INFO] [stdout] 214 + MouseButton::Left => self.left, [INFO] [stdout] 215 + MouseButton::Middle => self.middle, [INFO] [stdout] 216 + MouseButton::Right => self.right, [INFO] [stdout] 217 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | / return MouseButtonsStateFrame { [INFO] [stdout] 223 | | left: MouseButtonFrame::calculate(self.left, prev.left), [INFO] [stdout] 224 | | middle: MouseButtonFrame::calculate(self.middle, prev.middle), [INFO] [stdout] 225 | | right: MouseButtonFrame::calculate(self.right, prev.right), [INFO] [stdout] 226 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 ~ MouseButtonsStateFrame { [INFO] [stdout] 223 + left: MouseButtonFrame::calculate(self.left, prev.left), [INFO] [stdout] 224 + middle: MouseButtonFrame::calculate(self.middle, prev.middle), [INFO] [stdout] 225 + right: MouseButtonFrame::calculate(self.right, prev.right), [INFO] [stdout] 226 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MouseState` [INFO] [stdout] --> src/event.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | / pub fn new() -> Self { [INFO] [stdout] 124 | | Self { [INFO] [stdout] 125 | | buttons: MouseButtonsState::new(), [INFO] [stdout] 126 | | position: Position::zero(), [INFO] [stdout] ... | [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 122 + impl Default for MouseState { [INFO] [stdout] 123 + fn default() -> Self { [INFO] [stdout] 124 + Self::new() [INFO] [stdout] 125 + } [INFO] [stdout] 126 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | / return MouseStateFrame { [INFO] [stdout] 134 | | buttons: self.buttons.calculate_frame(prev.buttons), [INFO] [stdout] 135 | | position: self.position, [INFO] [stdout] 136 | | scroll: self.scroll.scroll_diff(prev.scroll), [INFO] [stdout] 137 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 ~ MouseStateFrame { [INFO] [stdout] 134 + buttons: self.buttons.calculate_frame(prev.buttons), [INFO] [stdout] 135 + position: self.position, [INFO] [stdout] 136 + scroll: self.scroll.scroll_diff(prev.scroll), [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | / return match (current, prev) { [INFO] [stdout] 246 | | (false, false) => MouseButtonFrame::Up, [INFO] [stdout] 247 | | (true, true) => MouseButtonFrame::Down, [INFO] [stdout] 248 | | (true, false) => MouseButtonFrame::Pressed, [INFO] [stdout] 249 | | (false, true) => MouseButtonFrame::Released, [INFO] [stdout] 250 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 ~ match (current, prev) { [INFO] [stdout] 246 + (false, false) => MouseButtonFrame::Up, [INFO] [stdout] 247 + (true, true) => MouseButtonFrame::Down, [INFO] [stdout] 248 + (true, false) => MouseButtonFrame::Pressed, [INFO] [stdout] 249 + (false, true) => MouseButtonFrame::Released, [INFO] [stdout] 250 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MouseScrollState` [INFO] [stdout] --> src/event.rs:150:5 [INFO] [stdout] | [INFO] [stdout] 150 | / pub fn new() -> Self { [INFO] [stdout] 151 | | Self { [INFO] [stdout] 152 | | cols: 0, [INFO] [stdout] 153 | | rows: 0, [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 149 + impl Default for MouseScrollState { [INFO] [stdout] 150 + fn default() -> Self { [INFO] [stdout] 151 + Self::new() [INFO] [stdout] 152 + } [INFO] [stdout] 153 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | / return Position::new( [INFO] [stdout] 162 | | (self.cols - prev.cols) as i16, [INFO] [stdout] 163 | | (self.rows - prev.rows) as i16, [INFO] [stdout] 164 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 ~ Position::new( [INFO] [stdout] 162 + (self.cols - prev.cols) as i16, [INFO] [stdout] 163 + (self.rows - prev.rows) as i16, [INFO] [stdout] 164 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `MouseButtonsState` [INFO] [stdout] --> src/event.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | / pub fn new() -> Self { [INFO] [stdout] 204 | | Self { [INFO] [stdout] 205 | | left: false, [INFO] [stdout] 206 | | middle: false, [INFO] [stdout] ... | [INFO] [stdout] 209 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 202 + impl Default for MouseButtonsState { [INFO] [stdout] 203 + fn default() -> Self { [INFO] [stdout] 204 + Self::new() [INFO] [stdout] 205 + } [INFO] [stdout] 206 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 213 | / return match button { [INFO] [stdout] 214 | | MouseButton::Left => self.left, [INFO] [stdout] 215 | | MouseButton::Middle => self.middle, [INFO] [stdout] 216 | | MouseButton::Right => self.right, [INFO] [stdout] 217 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 ~ match button { [INFO] [stdout] 214 + MouseButton::Left => self.left, [INFO] [stdout] 215 + MouseButton::Middle => self.middle, [INFO] [stdout] 216 + MouseButton::Right => self.right, [INFO] [stdout] 217 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | / return MouseButtonsStateFrame { [INFO] [stdout] 223 | | left: MouseButtonFrame::calculate(self.left, prev.left), [INFO] [stdout] 224 | | middle: MouseButtonFrame::calculate(self.middle, prev.middle), [INFO] [stdout] 225 | | right: MouseButtonFrame::calculate(self.right, prev.right), [INFO] [stdout] 226 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 ~ MouseButtonsStateFrame { [INFO] [stdout] 223 + left: MouseButtonFrame::calculate(self.left, prev.left), [INFO] [stdout] 224 + middle: MouseButtonFrame::calculate(self.middle, prev.middle), [INFO] [stdout] 225 + right: MouseButtonFrame::calculate(self.right, prev.right), [INFO] [stdout] 226 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/event.rs:245:9 [INFO] [stdout] | [INFO] [stdout] 245 | / return match (current, prev) { [INFO] [stdout] 246 | | (false, false) => MouseButtonFrame::Up, [INFO] [stdout] 247 | | (true, true) => MouseButtonFrame::Down, [INFO] [stdout] 248 | | (true, false) => MouseButtonFrame::Pressed, [INFO] [stdout] 249 | | (false, true) => MouseButtonFrame::Released, [INFO] [stdout] 250 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 245 ~ match (current, prev) { [INFO] [stdout] 246 + (false, false) => MouseButtonFrame::Up, [INFO] [stdout] 247 + (true, true) => MouseButtonFrame::Down, [INFO] [stdout] 248 + (true, false) => MouseButtonFrame::Pressed, [INFO] [stdout] 249 + (false, true) => MouseButtonFrame::Released, [INFO] [stdout] 250 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 169 | if self.setup_config.alt_screen == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.setup_config.alt_screen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | return self.last_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return self.last_size; [INFO] [stdout] 198 + self.last_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | return self.last_draw; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return self.last_draw; [INFO] [stdout] 203 + self.last_draw [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | / match self.last_draw() { [INFO] [stdout] 209 | | Some(s) => Some(std::time::Instant::now() - s), [INFO] [stdout] 210 | | None => None, [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________^ help: try: `self.last_draw().map(|s| std::time::Instant::now() - s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | return should_draw; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return should_draw; [INFO] [stdout] 229 + should_draw [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:221:21 [INFO] [stdout] | [INFO] [stdout] 221 | / if s < frame_delay { [INFO] [stdout] 222 | | should_draw = false; [INFO] [stdout] 223 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ Some(s) [INFO] [stdout] 221 ~ if s < frame_delay => { [INFO] [stdout] 222 | should_draw = false; [INFO] [stdout] 223 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | / match self.duration_since_last_draw() { [INFO] [stdout] 220 | | Some(s) => { [INFO] [stdout] 221 | | if s < frame_delay { [INFO] [stdout] 222 | | should_draw = false; [INFO] [stdout] ... | [INFO] [stdout] 225 | | None => (), [INFO] [stdout] 226 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 219 ~ if let Some(s) = self.duration_since_last_draw() { [INFO] [stdout] 220 + if s < frame_delay { [INFO] [stdout] 221 + should_draw = false; [INFO] [stdout] 222 + } [INFO] [stdout] 223 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | return self.front_buffer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - return self.front_buffer; [INFO] [stdout] 234 + self.front_buffer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | / return match self.front_buffer_index() { [INFO] [stdout] 240 | | 0 => 1, [INFO] [stdout] 241 | | 1 => 0, [INFO] [stdout] 242 | | _ => unreachable!(), [INFO] [stdout] 243 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 239 ~ match self.front_buffer_index() { [INFO] [stdout] 240 + 0 => 1, [INFO] [stdout] 241 + 1 => 0, [INFO] [stdout] 242 + _ => unreachable!(), [INFO] [stdout] 243 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:261:12 [INFO] [stdout] | [INFO] [stdout] 261 | if self.should_draw() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.should_draw()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:302:12 [INFO] [stdout] | [INFO] [stdout] 302 | if self.config.allow_screen_tearing == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.config.allow_screen_tearing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:315:24 [INFO] [stdout] | [INFO] [stdout] 315 | || self.config.damaged_only == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.config.damaged_only` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | if self.config.allow_screen_tearing == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.config.allow_screen_tearing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 169 | if self.setup_config.alt_screen == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.setup_config.alt_screen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | return self.event_state.calculate_frame(self.last_event_state.clone().unwrap_or(self.event_state.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 363 - return self.event_state.calculate_frame(self.last_event_state.clone().unwrap_or(self.event_state.clone())); [INFO] [stdout] 363 + self.event_state.calculate_frame(self.last_event_state.clone().unwrap_or(self.event_state.clone())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 368 | return self.last_event_state.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 368 - return self.last_event_state.clone(); [INFO] [stdout] 368 + self.last_event_state.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:198:9 [INFO] [stdout] | [INFO] [stdout] 198 | return self.last_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return self.last_size; [INFO] [stdout] 198 + self.last_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return &self.filler; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return &self.filler; [INFO] [stdout] 399 + &self.filler [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | return self.last_draw; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return self.last_draw; [INFO] [stdout] 203 + self.last_draw [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | / match self.last_draw() { [INFO] [stdout] 209 | | Some(s) => Some(std::time::Instant::now() - s), [INFO] [stdout] 210 | | None => None, [INFO] [stdout] 211 | | } [INFO] [stdout] | |_________^ help: try: `self.last_draw().map(|s| std::time::Instant::now() - s)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | return should_draw; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - return should_draw; [INFO] [stdout] 229 + should_draw [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/lib.rs:221:21 [INFO] [stdout] | [INFO] [stdout] 221 | / if s < frame_delay { [INFO] [stdout] 222 | | should_draw = false; [INFO] [stdout] 223 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 220 ~ Some(s) [INFO] [stdout] 221 ~ if s < frame_delay => { [INFO] [stdout] 222 | should_draw = false; [INFO] [stdout] 223 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | / match self.duration_since_last_draw() { [INFO] [stdout] 220 | | Some(s) => { [INFO] [stdout] 221 | | if s < frame_delay { [INFO] [stdout] 222 | | should_draw = false; [INFO] [stdout] ... | [INFO] [stdout] 225 | | None => (), [INFO] [stdout] 226 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 219 ~ if let Some(s) = self.duration_since_last_draw() { [INFO] [stdout] 220 + if s < frame_delay { [INFO] [stdout] 221 + should_draw = false; [INFO] [stdout] 222 + } [INFO] [stdout] 223 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | return self.front_buffer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 234 - return self.front_buffer; [INFO] [stdout] 234 + self.front_buffer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | / return match self.front_buffer_index() { [INFO] [stdout] 240 | | 0 => 1, [INFO] [stdout] 241 | | 1 => 0, [INFO] [stdout] 242 | | _ => unreachable!(), [INFO] [stdout] 243 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 239 ~ match self.front_buffer_index() { [INFO] [stdout] 240 + 0 => 1, [INFO] [stdout] 241 + 1 => 0, [INFO] [stdout] 242 + _ => unreachable!(), [INFO] [stdout] 243 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:425:9 [INFO] [stdout] | [INFO] [stdout] 425 | return self.map.get(&position); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 425 - return self.map.get(&position); [INFO] [stdout] 425 + self.map.get(&position) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:461:9 [INFO] [stdout] | [INFO] [stdout] 461 | / return Self { [INFO] [stdout] 462 | | transform, [INFO] [stdout] 463 | | buffer_pointer, [INFO] [stdout] 464 | | set_by_canvas: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 467 | | filler, [INFO] [stdout] 468 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 461 ~ Self { [INFO] [stdout] 462 + transform, [INFO] [stdout] 463 + buffer_pointer, [INFO] [stdout] 464 + set_by_canvas: HashMap::new(), [INFO] [stdout] 465 + transform_original: transform, [INFO] [stdout] 466 + depth, [INFO] [stdout] 467 + filler, [INFO] [stdout] 468 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:474:9 [INFO] [stdout] | [INFO] [stdout] 474 | / return Self::new( [INFO] [stdout] 475 | | transform.offset_by(self.transform.position), [INFO] [stdout] 476 | | self.depth + 1, [INFO] [stdout] 477 | | self.buffer_pointer, [INFO] [stdout] 478 | | self.filler.clone(), [INFO] [stdout] 479 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 474 ~ Self::new( [INFO] [stdout] 475 + transform.offset_by(self.transform.position), [INFO] [stdout] 476 + self.depth + 1, [INFO] [stdout] 477 + self.buffer_pointer, [INFO] [stdout] 478 + self.filler.clone(), [INFO] [stdout] 479 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return self.new_child(Transform::new(Position::zero(), self.transform.size)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return self.new_child(Transform::new(Position::zero(), self.transform.size)); [INFO] [stdout] 485 + self.new_child(Transform::new(Position::zero(), self.transform.size)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 491 | return self.depth; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 491 - return self.depth; [INFO] [stdout] 491 + self.depth [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:261:12 [INFO] [stdout] | [INFO] [stdout] 261 | if self.should_draw() == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.should_draw()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:497:9 [INFO] [stdout] | [INFO] [stdout] 497 | return self.depth == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 497 - return self.depth == 0; [INFO] [stdout] 497 + self.depth == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:528:9 [INFO] [stdout] | [INFO] [stdout] 528 | return self.transform_original; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 528 - return self.transform_original; [INFO] [stdout] 528 + self.transform_original [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:302:12 [INFO] [stdout] | [INFO] [stdout] 302 | if self.config.allow_screen_tearing == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.config.allow_screen_tearing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:540:9 [INFO] [stdout] | [INFO] [stdout] 540 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 540 - return true; [INFO] [stdout] 540 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:547:16 [INFO] [stdout] | [INFO] [stdout] 547 | return !(self.set_by_canvas.get(&position) == None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.set_by_canvas.get(&position) != None)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 547 | return !(self.set_by_canvas.get(&position) == None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 547 - return !(self.set_by_canvas.get(&position) == None); [INFO] [stdout] 547 + !(self.set_by_canvas.get(&position) == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/lib.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | return !(self.set_by_canvas.get(&position) == None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.set_by_canvas.get(&position).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:315:24 [INFO] [stdout] | [INFO] [stdout] 315 | || self.config.damaged_only == false [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.config.damaged_only` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:561:9 [INFO] [stdout] | [INFO] [stdout] 561 | return buffer.get(real_position); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 561 - return buffer.get(real_position); [INFO] [stdout] 561 + buffer.get(real_position) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 553 | if self.transform.zero_position().contains_point(position) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.transform.zero_position().contains_point(position)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:331:12 [INFO] [stdout] | [INFO] [stdout] 331 | if self.config.allow_screen_tearing == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.config.allow_screen_tearing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:567:12 [INFO] [stdout] | [INFO] [stdout] 567 | if self.transform.zero_position().contains_point(position) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.transform.zero_position().contains_point(position)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:640:5 [INFO] [stdout] | [INFO] [stdout] 640 | return style; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 640 - return style; [INFO] [stdout] 640 + style [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | return self.event_state.calculate_frame(self.last_event_state.clone().unwrap_or(self.event_state.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 363 - return self.event_state.calculate_frame(self.last_event_state.clone().unwrap_or(self.event_state.clone())); [INFO] [stdout] 363 + self.event_state.calculate_frame(self.last_event_state.clone().unwrap_or(self.event_state.clone())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 368 | return self.last_event_state.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 368 - return self.last_event_state.clone(); [INFO] [stdout] 368 + self.last_event_state.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return &self.filler; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return &self.filler; [INFO] [stdout] 399 + &self.filler [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:425:9 [INFO] [stdout] | [INFO] [stdout] 425 | return self.map.get(&position); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 425 - return self.map.get(&position); [INFO] [stdout] 425 + self.map.get(&position) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:461:9 [INFO] [stdout] | [INFO] [stdout] 461 | / return Self { [INFO] [stdout] 462 | | transform, [INFO] [stdout] 463 | | buffer_pointer, [INFO] [stdout] 464 | | set_by_canvas: HashMap::new(), [INFO] [stdout] ... | [INFO] [stdout] 467 | | filler, [INFO] [stdout] 468 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 461 ~ Self { [INFO] [stdout] 462 + transform, [INFO] [stdout] 463 + buffer_pointer, [INFO] [stdout] 464 + set_by_canvas: HashMap::new(), [INFO] [stdout] 465 + transform_original: transform, [INFO] [stdout] 466 + depth, [INFO] [stdout] 467 + filler, [INFO] [stdout] 468 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:654:5 [INFO] [stdout] | [INFO] [stdout] 654 | / return match (damaged, last_damaged) { [INFO] [stdout] 655 | | (Some(damaged), Some(last_damaged)) => Some(damaged.combined_area(last_damaged)), [INFO] [stdout] 656 | | (Some(damaged), None) => Some(damaged), [INFO] [stdout] 657 | | (None, Some(last_damaged)) => Some(last_damaged), [INFO] [stdout] 658 | | (None, None) => None, [INFO] [stdout] 659 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 654 ~ match (damaged, last_damaged) { [INFO] [stdout] 655 + (Some(damaged), Some(last_damaged)) => Some(damaged.combined_area(last_damaged)), [INFO] [stdout] 656 + (Some(damaged), None) => Some(damaged), [INFO] [stdout] 657 + (None, Some(last_damaged)) => Some(last_damaged), [INFO] [stdout] 658 + (None, None) => None, [INFO] [stdout] 659 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:474:9 [INFO] [stdout] | [INFO] [stdout] 474 | / return Self::new( [INFO] [stdout] 475 | | transform.offset_by(self.transform.position), [INFO] [stdout] 476 | | self.depth + 1, [INFO] [stdout] 477 | | self.buffer_pointer, [INFO] [stdout] 478 | | self.filler.clone(), [INFO] [stdout] 479 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 474 ~ Self::new( [INFO] [stdout] 475 + transform.offset_by(self.transform.position), [INFO] [stdout] 476 + self.depth + 1, [INFO] [stdout] 477 + self.buffer_pointer, [INFO] [stdout] 478 + self.filler.clone(), [INFO] [stdout] 479 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:485:9 [INFO] [stdout] | [INFO] [stdout] 485 | return self.new_child(Transform::new(Position::zero(), self.transform.size)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 485 - return self.new_child(Transform::new(Position::zero(), self.transform.size)); [INFO] [stdout] 485 + self.new_child(Transform::new(Position::zero(), self.transform.size)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 491 | return self.depth; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 491 - return self.depth; [INFO] [stdout] 491 + self.depth [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:497:9 [INFO] [stdout] | [INFO] [stdout] 497 | return self.depth == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 497 - return self.depth == 0; [INFO] [stdout] 497 + self.depth == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:528:9 [INFO] [stdout] | [INFO] [stdout] 528 | return self.transform_original; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 528 - return self.transform_original; [INFO] [stdout] 528 + self.transform_original [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:540:9 [INFO] [stdout] | [INFO] [stdout] 540 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 540 - return true; [INFO] [stdout] 540 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:685:9 [INFO] [stdout] | [INFO] [stdout] 685 | return Self::new(Position::zero(), self.size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 685 - return Self::new(Position::zero(), self.size); [INFO] [stdout] 685 + Self::new(Position::zero(), self.size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:691:9 [INFO] [stdout] | [INFO] [stdout] 691 | return Self::new(self.position + offset, self.size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 691 - return Self::new(self.position + offset, self.size); [INFO] [stdout] 691 + Self::new(self.position + offset, self.size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:547:16 [INFO] [stdout] | [INFO] [stdout] 547 | return !(self.set_by_canvas.get(&position) == None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.set_by_canvas.get(&position) != None)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:547:9 [INFO] [stdout] | [INFO] [stdout] 547 | return !(self.set_by_canvas.get(&position) == None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 547 - return !(self.set_by_canvas.get(&position) == None); [INFO] [stdout] 547 + !(self.set_by_canvas.get(&position) == None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:724:9 [INFO] [stdout] | [INFO] [stdout] 724 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 724 - return false; [INFO] [stdout] 724 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/lib.rs:547:17 [INFO] [stdout] | [INFO] [stdout] 547 | return !(self.set_by_canvas.get(&position) == None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.set_by_canvas.get(&position).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:716:9 [INFO] [stdout] | [INFO] [stdout] 716 | / if position.col >= self.position.col [INFO] [stdout] 717 | | && position.row >= self.position.row { [INFO] [stdout] 718 | | if position.col < self.size.cols as i16 + self.position.col [INFO] [stdout] 719 | | && position.row < self.size.rows as i16 + self.position.row { [INFO] [stdout] ... | [INFO] [stdout] 722 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 717 ~ && position.row >= self.position.row [INFO] [stdout] 718 ~ && position.col < self.size.cols as i16 + self.position.col [INFO] [stdout] 719 | && position.row < self.size.rows as i16 + self.position.row { [INFO] [stdout] 720 | return true; [INFO] [stdout] 721 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:561:9 [INFO] [stdout] | [INFO] [stdout] 561 | return buffer.get(real_position); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 561 - return buffer.get(real_position); [INFO] [stdout] 561 + buffer.get(real_position) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:553:12 [INFO] [stdout] | [INFO] [stdout] 553 | if self.transform.zero_position().contains_point(position) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.transform.zero_position().contains_point(position)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:743:9 [INFO] [stdout] | [INFO] [stdout] 743 | return self.combined_area(Self::new(position, Size::new(1, 1))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 743 - return self.combined_area(Self::new(position, Size::new(1, 1))); [INFO] [stdout] 743 + self.combined_area(Self::new(position, Size::new(1, 1))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:567:12 [INFO] [stdout] | [INFO] [stdout] 567 | if self.transform.zero_position().contains_point(position) == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.transform.zero_position().contains_point(position)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 783 - return total; [INFO] [stdout] 783 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:640:5 [INFO] [stdout] | [INFO] [stdout] 640 | return style; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 640 - return style; [INFO] [stdout] 640 + style [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:788:9 [INFO] [stdout] | [INFO] [stdout] 788 | / return Self::new( [INFO] [stdout] 789 | | Position { [INFO] [stdout] 790 | | col: f(self.position.col as f64, b.position.col as f64, t) as i16, [INFO] [stdout] 791 | | row: f(self.position.row as f64, b.position.row as f64, t) as i16, [INFO] [stdout] ... | [INFO] [stdout] 796 | | }, [INFO] [stdout] 797 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 788 ~ Self::new( [INFO] [stdout] 789 + Position { [INFO] [stdout] 790 + col: f(self.position.col as f64, b.position.col as f64, t) as i16, [INFO] [stdout] 791 + row: f(self.position.row as f64, b.position.row as f64, t) as i16, [INFO] [stdout] 792 + }, [INFO] [stdout] 793 + Size { [INFO] [stdout] 794 + cols: f(self.size.cols as f64, b.size.cols as f64, t) as u16, [INFO] [stdout] 795 + rows: f(self.size.rows as f64, b.size.rows as f64, t) as u16, [INFO] [stdout] 796 + }, [INFO] [stdout] 797 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:802:9 [INFO] [stdout] | [INFO] [stdout] 802 | / return Self::new( [INFO] [stdout] 803 | | Position { [INFO] [stdout] 804 | | col: f(self.position.col as f64, control.position.col as f64, b.position.col as f64, t) as i16, [INFO] [stdout] 805 | | row: f(self.position.row as f64, control.position.row as f64, b.position.row as f64, t) as i16, [INFO] [stdout] ... | [INFO] [stdout] 810 | | }, [INFO] [stdout] 811 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 802 ~ Self::new( [INFO] [stdout] 803 + Position { [INFO] [stdout] 804 + col: f(self.position.col as f64, control.position.col as f64, b.position.col as f64, t) as i16, [INFO] [stdout] 805 + row: f(self.position.row as f64, control.position.row as f64, b.position.row as f64, t) as i16, [INFO] [stdout] 806 + }, [INFO] [stdout] 807 + Size { [INFO] [stdout] 808 + cols: f(self.size.cols as f64, control.size.cols as f64, b.size.cols as f64, t) as u16, [INFO] [stdout] 809 + rows: f(self.size.rows as f64, control.size.rows as f64, b.size.rows as f64, t) as u16, [INFO] [stdout] 810 + }, [INFO] [stdout] 811 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:816:9 [INFO] [stdout] | [INFO] [stdout] 816 | / ... return Self::new( [INFO] [stdout] 817 | | ... Position { [INFO] [stdout] 818 | | ... col: f(self.position.col as f64, a_control.position.col as f64, b.position.col as f64, b_control.position.col as f6... [INFO] [stdout] 819 | | ... row: f(self.position.row as f64, a_control.position.row as f64, b.position.row as f64, b_control.position.row as f6... [INFO] [stdout] ... | [INFO] [stdout] 824 | | ... }, [INFO] [stdout] 825 | | ... ); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 816 ~ Self::new( [INFO] [stdout] 817 + Position { [INFO] [stdout] 818 + col: f(self.position.col as f64, a_control.position.col as f64, b.position.col as f64, b_control.position.col as f64, t) as i16, [INFO] [stdout] 819 + row: f(self.position.row as f64, a_control.position.row as f64, b.position.row as f64, b_control.position.row as f64, t) as i16, [INFO] [stdout] 820 + }, [INFO] [stdout] 821 + Size { [INFO] [stdout] 822 + cols: f(self.size.cols as f64, a_control.size.cols as f64, b.size.cols as f64, b_control.size.cols as f64, t) as u16, [INFO] [stdout] 823 + rows: f(self.size.rows as f64, a_control.size.rows as f64, b.size.rows as f64, b_control.size.rows as f64, t) as u16, [INFO] [stdout] 824 + }, [INFO] [stdout] 825 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:654:5 [INFO] [stdout] | [INFO] [stdout] 654 | / return match (damaged, last_damaged) { [INFO] [stdout] 655 | | (Some(damaged), Some(last_damaged)) => Some(damaged.combined_area(last_damaged)), [INFO] [stdout] 656 | | (Some(damaged), None) => Some(damaged), [INFO] [stdout] 657 | | (None, Some(last_damaged)) => Some(last_damaged), [INFO] [stdout] 658 | | (None, None) => None, [INFO] [stdout] 659 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 654 ~ match (damaged, last_damaged) { [INFO] [stdout] 655 + (Some(damaged), Some(last_damaged)) => Some(damaged.combined_area(last_damaged)), [INFO] [stdout] 656 + (Some(damaged), None) => Some(damaged), [INFO] [stdout] 657 + (None, Some(last_damaged)) => Some(last_damaged), [INFO] [stdout] 658 + (None, None) => None, [INFO] [stdout] 659 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:857:9 [INFO] [stdout] | [INFO] [stdout] 857 | return (self.cols as u32) * (self.rows as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 857 - return (self.cols as u32) * (self.rows as u32); [INFO] [stdout] 857 + (self.cols as u32) * (self.rows as u32) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:685:9 [INFO] [stdout] | [INFO] [stdout] 685 | return Self::new(Position::zero(), self.size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 685 - return Self::new(Position::zero(), self.size); [INFO] [stdout] 685 + Self::new(Position::zero(), self.size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:691:9 [INFO] [stdout] | [INFO] [stdout] 691 | return Self::new(self.position + offset, self.size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 691 - return Self::new(self.position + offset, self.size); [INFO] [stdout] 691 + Self::new(self.position + offset, self.size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:724:9 [INFO] [stdout] | [INFO] [stdout] 724 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 724 - return false; [INFO] [stdout] 724 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:716:9 [INFO] [stdout] | [INFO] [stdout] 716 | / if position.col >= self.position.col [INFO] [stdout] 717 | | && position.row >= self.position.row { [INFO] [stdout] 718 | | if position.col < self.size.cols as i16 + self.position.col [INFO] [stdout] 719 | | && position.row < self.size.rows as i16 + self.position.row { [INFO] [stdout] ... | [INFO] [stdout] 722 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 717 ~ && position.row >= self.position.row [INFO] [stdout] 718 ~ && position.col < self.size.cols as i16 + self.position.col [INFO] [stdout] 719 | && position.row < self.size.rows as i16 + self.position.row { [INFO] [stdout] 720 | return true; [INFO] [stdout] 721 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:743:9 [INFO] [stdout] | [INFO] [stdout] 743 | return self.combined_area(Self::new(position, Size::new(1, 1))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 743 - return self.combined_area(Self::new(position, Size::new(1, 1))); [INFO] [stdout] 743 + self.combined_area(Self::new(position, Size::new(1, 1))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:783:9 [INFO] [stdout] | [INFO] [stdout] 783 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 783 - return total; [INFO] [stdout] 783 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:788:9 [INFO] [stdout] | [INFO] [stdout] 788 | / return Self::new( [INFO] [stdout] 789 | | Position { [INFO] [stdout] 790 | | col: f(self.position.col as f64, b.position.col as f64, t) as i16, [INFO] [stdout] 791 | | row: f(self.position.row as f64, b.position.row as f64, t) as i16, [INFO] [stdout] ... | [INFO] [stdout] 796 | | }, [INFO] [stdout] 797 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 788 ~ Self::new( [INFO] [stdout] 789 + Position { [INFO] [stdout] 790 + col: f(self.position.col as f64, b.position.col as f64, t) as i16, [INFO] [stdout] 791 + row: f(self.position.row as f64, b.position.row as f64, t) as i16, [INFO] [stdout] 792 + }, [INFO] [stdout] 793 + Size { [INFO] [stdout] 794 + cols: f(self.size.cols as f64, b.size.cols as f64, t) as u16, [INFO] [stdout] 795 + rows: f(self.size.rows as f64, b.size.rows as f64, t) as u16, [INFO] [stdout] 796 + }, [INFO] [stdout] 797 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:802:9 [INFO] [stdout] | [INFO] [stdout] 802 | / return Self::new( [INFO] [stdout] 803 | | Position { [INFO] [stdout] 804 | | col: f(self.position.col as f64, control.position.col as f64, b.position.col as f64, t) as i16, [INFO] [stdout] 805 | | row: f(self.position.row as f64, control.position.row as f64, b.position.row as f64, t) as i16, [INFO] [stdout] ... | [INFO] [stdout] 810 | | }, [INFO] [stdout] 811 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 802 ~ Self::new( [INFO] [stdout] 803 + Position { [INFO] [stdout] 804 + col: f(self.position.col as f64, control.position.col as f64, b.position.col as f64, t) as i16, [INFO] [stdout] 805 + row: f(self.position.row as f64, control.position.row as f64, b.position.row as f64, t) as i16, [INFO] [stdout] 806 + }, [INFO] [stdout] 807 + Size { [INFO] [stdout] 808 + cols: f(self.size.cols as f64, control.size.cols as f64, b.size.cols as f64, t) as u16, [INFO] [stdout] 809 + rows: f(self.size.rows as f64, control.size.rows as f64, b.size.rows as f64, t) as u16, [INFO] [stdout] 810 + }, [INFO] [stdout] 811 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:816:9 [INFO] [stdout] | [INFO] [stdout] 816 | / ... return Self::new( [INFO] [stdout] 817 | | ... Position { [INFO] [stdout] 818 | | ... col: f(self.position.col as f64, a_control.position.col as f64, b.position.col as f64, b_control.position.col as f6... [INFO] [stdout] 819 | | ... row: f(self.position.row as f64, a_control.position.row as f64, b.position.row as f64, b_control.position.row as f6... [INFO] [stdout] ... | [INFO] [stdout] 824 | | ... }, [INFO] [stdout] 825 | | ... ); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 816 ~ Self::new( [INFO] [stdout] 817 + Position { [INFO] [stdout] 818 + col: f(self.position.col as f64, a_control.position.col as f64, b.position.col as f64, b_control.position.col as f64, t) as i16, [INFO] [stdout] 819 + row: f(self.position.row as f64, a_control.position.row as f64, b.position.row as f64, b_control.position.row as f64, t) as i16, [INFO] [stdout] 820 + }, [INFO] [stdout] 821 + Size { [INFO] [stdout] 822 + cols: f(self.size.cols as f64, a_control.size.cols as f64, b.size.cols as f64, b_control.size.cols as f64, t) as u16, [INFO] [stdout] 823 + rows: f(self.size.rows as f64, a_control.size.rows as f64, b.size.rows as f64, b_control.size.rows as f64, t) as u16, [INFO] [stdout] 824 + }, [INFO] [stdout] 825 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:857:9 [INFO] [stdout] | [INFO] [stdout] 857 | return (self.cols as u32) * (self.rows as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 857 - return (self.cols as u32) * (self.rows as u32); [INFO] [stdout] 857 + (self.cols as u32) * (self.rows as u32) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/animations/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | #[derive(Debug, Clone, Copy, PartialEq, PartialOrd)] [INFO] [stdout] | --------- in this derive macro expansion [INFO] [stdout] ... [INFO] [stdout] 59 | pub lerp: fn(f64, f64, f64) -> f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] = note: `#[warn(unpredictable_function_pointer_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/animations/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | #[derive(Debug, Clone, Copy, PartialEq, PartialOrd)] [INFO] [stdout] | ---------- in this derive macro expansion [INFO] [stdout] ... [INFO] [stdout] 59 | pub lerp: fn(f64, f64, f64) -> f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/animations/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | #[derive(Debug, Clone, Copy, PartialEq, PartialOrd)] [INFO] [stdout] | --------- in this derive macro expansion [INFO] [stdout] ... [INFO] [stdout] 59 | pub lerp: fn(f64, f64, f64) -> f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] = note: `#[warn(unpredictable_function_pointer_comparisons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/animations/mod.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | #[derive(Debug, Clone, Copy, PartialEq, PartialOrd)] [INFO] [stdout] | ---------- in this derive macro expansion [INFO] [stdout] ... [INFO] [stdout] 59 | pub lerp: fn(f64, f64, f64) -> f64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.08s [INFO] running `Command { std: "docker" "inspect" "8558cf6b359c802a02770b0563d1b9346fb66fcacd9aa34499603e61b27ce7ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8558cf6b359c802a02770b0563d1b9346fb66fcacd9aa34499603e61b27ce7ff", kill_on_drop: false }` [INFO] [stdout] 8558cf6b359c802a02770b0563d1b9346fb66fcacd9aa34499603e61b27ce7ff