[INFO] fetching crate tui-suite 0.1.0... [INFO] linting tui-suite-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tui-suite 0.1.0 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate tui-suite 0.1.0 [INFO] finished tweaking crates.io crate tui-suite 0.1.0 [INFO] tweaked toml for crates.io crate tui-suite 0.1.0 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tui-suite 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate tui-suite 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pulldown-cmark v0.12.2 [INFO] [stderr] Downloaded tpnote-html2md v0.3.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 406b4f165d179c44c798147f2e95aef7dcfdc383b041f09f576f1adae86d9465 [INFO] running `Command { std: "docker" "start" "-a" "406b4f165d179c44c798147f2e95aef7dcfdc383b041f09f576f1adae86d9465", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "406b4f165d179c44c798147f2e95aef7dcfdc383b041f09f576f1adae86d9465", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "406b4f165d179c44c798147f2e95aef7dcfdc383b041f09f576f1adae86d9465", kill_on_drop: false }` [INFO] [stdout] 406b4f165d179c44c798147f2e95aef7dcfdc383b041f09f576f1adae86d9465 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6128303afac87b6f19d8815d542be80461e0184113f9ea3406fdf5412e395547 [INFO] running `Command { std: "docker" "start" "-a" "6128303afac87b6f19d8815d542be80461e0184113f9ea3406fdf5412e395547", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling phf_shared v0.13.1 [INFO] [stderr] Compiling fastrand v2.3.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy v0.8.35 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Checking rustix v1.1.3 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling phf_generator v0.13.1 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Checking phf v0.13.1 [INFO] [stderr] Compiling phf_codegen v0.13.1 [INFO] [stderr] Compiling string_cache_codegen v0.6.1 [INFO] [stderr] Checking string_cache v0.9.0 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling pulldown-cmark v0.12.2 [INFO] [stderr] Compiling web_atoms v0.2.3 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking getopts v0.2.24 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking str_indices v0.4.4 [INFO] [stderr] Checking pulldown-cmark-escape v0.11.0 [INFO] [stderr] Checking open v5.3.3 [INFO] [stderr] Checking ropey v1.6.1 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking directories v6.0.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking keyring v3.6.3 [INFO] [stderr] Checking markup5ever v0.36.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking html5ever v0.36.1 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking tpnote-html2md v0.3.4 [INFO] [stderr] Checking html2text v0.12.6 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.18 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tokio-test v0.4.5 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking tui-suite v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/calendar/layout.rs:75:42 [INFO] [stdout] | [INFO] [stdout] 75 | let end_row = (end_time.hour() * 2 + (end_time.minute() + 29) / 30) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `end_time.minute().div_ceil(30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/calendar/model.rs:48:1 [INFO] [stdout] | [INFO] [stdout] 48 | / impl Default for EventStatus { [INFO] [stdout] 49 | | fn default() -> Self { [INFO] [stdout] 50 | | EventStatus::Confirmed [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Default)] [INFO] [stdout] 43 | pub enum EventStatus { [INFO] [stdout] 44 ~ #[default] [INFO] [stdout] 45 ~ Confirmed, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/calendar/render.rs:107:16 [INFO] [stdout] | [INFO] [stdout] 107 | if time_row % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `time_row.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/calendar/render.rs:297:16 [INFO] [stdout] | [INFO] [stdout] 297 | if time_row % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `time_row.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/calendar/sync.rs:148:44 [INFO] [stdout] | [INFO] [stdout] 148 | let start = ge.start.as_ref().and_then(|dt| convert_datetime(dt))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `convert_datetime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/calendar/sync.rs:149:40 [INFO] [stdout] | [INFO] [stdout] 149 | let end = ge.end.as_ref().and_then(|dt| convert_datetime(dt))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `convert_datetime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/editor/doc.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / pub fn from_str(s: &str) -> Self { [INFO] [stdout] 49 | | Self { [INFO] [stdout] 50 | | rope: Rope::from_str(s), [INFO] [stdout] 51 | | cursor: Cursor::default(), [INFO] [stdout] ... | [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `editor::doc::Document` [INFO] [stdout] --> src/editor/doc.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | / pub fn to_string(&self) -> String { [INFO] [stdout] 146 | | self.rope.to_string() [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `editor::doc::Document` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/editor/render.rs:335:16 [INFO] [stdout] | [INFO] [stdout] 335 | let rows = (width + wrap_width - 1) / wrap_width; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `width.div_ceil(wrap_width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | / if app.palette.is_some() { [INFO] [stdout] 116 | | app.close_palette(); [INFO] [stdout] 117 | | return; [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 114 ~ Action::ClosePalette [INFO] [stdout] 115 ~ if app.palette.is_some() => { [INFO] [stdout] 116 | app.close_palette(); [INFO] [stdout] 117 | return; [INFO] [stdout] 118 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | / if app.inbox.view_mode == InboxViewMode::List { [INFO] [stdout] 193 | | if let Some(email) = app.inbox.selected_email() { [INFO] [stdout] 194 | | let email_id = email.id.clone(); [INFO] [stdout] 195 | | let store = get_token_store(); [INFO] [stdout] ... | [INFO] [stdout] 209 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 191 ~ Action::OpenEmail [INFO] [stdout] 192 ~ if app.inbox.view_mode == InboxViewMode::List => { [INFO] [stdout] 193 | if let Some(email) = app.inbox.selected_email() { [INFO] [stdout] ... [INFO] [stdout] 208 | } [INFO] [stdout] 209 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/calendar/layout.rs:75:42 [INFO] [stdout] | [INFO] [stdout] 75 | let end_row = (end_time.hour() * 2 + (end_time.minute() + 29) / 30) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `end_time.minute().div_ceil(30)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:718:13 [INFO] [stdout] | [INFO] [stdout] 718 | / if setup.step.has_browser_action() { [INFO] [stdout] 719 | | if let Err(e) = setup.open_browser() { [INFO] [stdout] 720 | | setup.error = Some(e); [INFO] [stdout] 721 | | } [INFO] [stdout] 722 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 717 ~ KeyCode::Char('o') | KeyCode::Char('O') [INFO] [stdout] 718 ~ if setup.step.has_browser_action() => { [INFO] [stdout] 719 | if let Err(e) = setup.open_browser() { [INFO] [stdout] 720 | setup.error = Some(e); [INFO] [stdout] 721 | } [INFO] [stdout] 722 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:726:13 [INFO] [stdout] | [INFO] [stdout] 726 | / if setup.step.is_input_step() { [INFO] [stdout] 727 | | if let Ok(mut clipboard) = arboard::Clipboard::new() { [INFO] [stdout] 728 | | if let Ok(text) = clipboard.get_text() { [INFO] [stdout] 729 | | setup.paste(&text); [INFO] [stdout] ... | [INFO] [stdout] 732 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 724 ~ KeyCode::Char('v') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 725 | // Paste from clipboard [INFO] [stdout] 726 ~ && setup.step.is_input_step() => { [INFO] [stdout] 727 | if let Ok(mut clipboard) = arboard::Clipboard::new() { [INFO] [stdout] ... [INFO] [stdout] 731 | } [INFO] [stdout] 732 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:735:13 [INFO] [stdout] | [INFO] [stdout] 735 | / if setup.step.is_input_step() { [INFO] [stdout] 736 | | setup.type_char(c); [INFO] [stdout] 737 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 734 ~ KeyCode::Char(c) [INFO] [stdout] 735 ~ if setup.step.is_input_step() => { [INFO] [stdout] 736 | setup.type_char(c); [INFO] [stdout] 737 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:740:13 [INFO] [stdout] | [INFO] [stdout] 740 | / if setup.step.is_input_step() { [INFO] [stdout] 741 | | setup.backspace(); [INFO] [stdout] 742 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 739 ~ KeyCode::Backspace [INFO] [stdout] 740 ~ if setup.step.is_input_step() => { [INFO] [stdout] 741 | setup.backspace(); [INFO] [stdout] 742 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/calendar/model.rs:48:1 [INFO] [stdout] | [INFO] [stdout] 48 | / impl Default for EventStatus { [INFO] [stdout] 49 | | fn default() -> Self { [INFO] [stdout] 50 | | EventStatus::Confirmed [INFO] [stdout] 51 | | } [INFO] [stdout] 52 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 42 + #[derive(Default)] [INFO] [stdout] 43 | pub enum EventStatus { [INFO] [stdout] 44 ~ #[default] [INFO] [stdout] 45 ~ Confirmed, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/calendar/render.rs:107:16 [INFO] [stdout] | [INFO] [stdout] 107 | if time_row % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `time_row.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/calendar/render.rs:297:16 [INFO] [stdout] | [INFO] [stdout] 297 | if time_row % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `time_row.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/calendar/sync.rs:148:44 [INFO] [stdout] | [INFO] [stdout] 148 | let start = ge.start.as_ref().and_then(|dt| convert_datetime(dt))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `convert_datetime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/calendar/sync.rs:149:40 [INFO] [stdout] | [INFO] [stdout] 149 | let end = ge.end.as_ref().and_then(|dt| convert_datetime(dt))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `convert_datetime` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/drive/mod.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | / loop { [INFO] [stdout] 261 | | let Some(start) = html.find(&start_tag) else { break }; [INFO] [stdout] 262 | | let Some(end_rel) = html[start..].find(&end_tag) else { [INFO] [stdout] 263 | | break; [INFO] [stdout] ... | [INFO] [stdout] 266 | | html.replace_range(start..end, ""); [INFO] [stdout] 267 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(start) = html.find(&start_tag) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/drive/mod.rs:273:5 [INFO] [stdout] | [INFO] [stdout] 273 | / loop { [INFO] [stdout] 274 | | let Some(start) = html.find(&start_tag) else { break }; [INFO] [stdout] 275 | | let Some(close_rel) = html[start..].find('>') else { [INFO] [stdout] 276 | | break; [INFO] [stdout] ... | [INFO] [stdout] 279 | | html.replace_range(start..end, ""); [INFO] [stdout] 280 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(start) = html.find(&start_tag) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/editor/doc.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / pub fn from_str(s: &str) -> Self { [INFO] [stdout] 49 | | Self { [INFO] [stdout] 50 | | rope: Rope::from_str(s), [INFO] [stdout] 51 | | cursor: Cursor::default(), [INFO] [stdout] ... | [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `editor::doc::Document` [INFO] [stdout] --> src/editor/doc.rs:145:5 [INFO] [stdout] | [INFO] [stdout] 145 | / pub fn to_string(&self) -> String { [INFO] [stdout] 146 | | self.rope.to_string() [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `editor::doc::Document` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/editor/render.rs:335:16 [INFO] [stdout] | [INFO] [stdout] 335 | let rows = (width + wrap_width - 1) / wrap_width; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `width.div_ceil(wrap_width)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | / if app.palette.is_some() { [INFO] [stdout] 116 | | app.close_palette(); [INFO] [stdout] 117 | | return; [INFO] [stdout] 118 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 114 ~ Action::ClosePalette [INFO] [stdout] 115 ~ if app.palette.is_some() => { [INFO] [stdout] 116 | app.close_palette(); [INFO] [stdout] 117 | return; [INFO] [stdout] 118 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:192:13 [INFO] [stdout] | [INFO] [stdout] 192 | / if app.inbox.view_mode == InboxViewMode::List { [INFO] [stdout] 193 | | if let Some(email) = app.inbox.selected_email() { [INFO] [stdout] 194 | | let email_id = email.id.clone(); [INFO] [stdout] 195 | | let store = get_token_store(); [INFO] [stdout] ... | [INFO] [stdout] 209 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 191 ~ Action::OpenEmail [INFO] [stdout] 192 ~ if app.inbox.view_mode == InboxViewMode::List => { [INFO] [stdout] 193 | if let Some(email) = app.inbox.selected_email() { [INFO] [stdout] ... [INFO] [stdout] 208 | } [INFO] [stdout] 209 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:718:13 [INFO] [stdout] | [INFO] [stdout] 718 | / if setup.step.has_browser_action() { [INFO] [stdout] 719 | | if let Err(e) = setup.open_browser() { [INFO] [stdout] 720 | | setup.error = Some(e); [INFO] [stdout] 721 | | } [INFO] [stdout] 722 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 717 ~ KeyCode::Char('o') | KeyCode::Char('O') [INFO] [stdout] 718 ~ if setup.step.has_browser_action() => { [INFO] [stdout] 719 | if let Err(e) = setup.open_browser() { [INFO] [stdout] 720 | setup.error = Some(e); [INFO] [stdout] 721 | } [INFO] [stdout] 722 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:726:13 [INFO] [stdout] | [INFO] [stdout] 726 | / if setup.step.is_input_step() { [INFO] [stdout] 727 | | if let Ok(mut clipboard) = arboard::Clipboard::new() { [INFO] [stdout] 728 | | if let Ok(text) = clipboard.get_text() { [INFO] [stdout] 729 | | setup.paste(&text); [INFO] [stdout] ... | [INFO] [stdout] 732 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 724 ~ KeyCode::Char('v') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 725 | // Paste from clipboard [INFO] [stdout] 726 ~ && setup.step.is_input_step() => { [INFO] [stdout] 727 | if let Ok(mut clipboard) = arboard::Clipboard::new() { [INFO] [stdout] ... [INFO] [stdout] 731 | } [INFO] [stdout] 732 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:735:13 [INFO] [stdout] | [INFO] [stdout] 735 | / if setup.step.is_input_step() { [INFO] [stdout] 736 | | setup.type_char(c); [INFO] [stdout] 737 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 734 ~ KeyCode::Char(c) [INFO] [stdout] 735 ~ if setup.step.is_input_step() => { [INFO] [stdout] 736 | setup.type_char(c); [INFO] [stdout] 737 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/engine/input.rs:740:13 [INFO] [stdout] | [INFO] [stdout] 740 | / if setup.step.is_input_step() { [INFO] [stdout] 741 | | setup.backspace(); [INFO] [stdout] 742 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 739 ~ KeyCode::Backspace [INFO] [stdout] 740 ~ if setup.step.is_input_step() => { [INFO] [stdout] 741 | setup.backspace(); [INFO] [stdout] 742 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/drive/mod.rs:260:5 [INFO] [stdout] | [INFO] [stdout] 260 | / loop { [INFO] [stdout] 261 | | let Some(start) = html.find(&start_tag) else { break }; [INFO] [stdout] 262 | | let Some(end_rel) = html[start..].find(&end_tag) else { [INFO] [stdout] 263 | | break; [INFO] [stdout] ... | [INFO] [stdout] 266 | | html.replace_range(start..end, ""); [INFO] [stdout] 267 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(start) = html.find(&start_tag) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/drive/mod.rs:273:5 [INFO] [stdout] | [INFO] [stdout] 273 | / loop { [INFO] [stdout] 274 | | let Some(start) = html.find(&start_tag) else { break }; [INFO] [stdout] 275 | | let Some(close_rel) = html[start..].find('>') else { [INFO] [stdout] 276 | | break; [INFO] [stdout] ... | [INFO] [stdout] 279 | | html.replace_range(start..end, ""); [INFO] [stdout] 280 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(start) = html.find(&start_tag) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 33.90s [INFO] running `Command { std: "docker" "inspect" "6128303afac87b6f19d8815d542be80461e0184113f9ea3406fdf5412e395547", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6128303afac87b6f19d8815d542be80461e0184113f9ea3406fdf5412e395547", kill_on_drop: false }` [INFO] [stdout] 6128303afac87b6f19d8815d542be80461e0184113f9ea3406fdf5412e395547