[INFO] fetching crate tsink-server 0.10.0... [INFO] linting tsink-server-0.10.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tsink-server 0.10.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate tsink-server 0.10.0 [INFO] finished tweaking crates.io crate tsink-server 0.10.0 [INFO] tweaked toml for crates.io crate tsink-server 0.10.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tsink-server 0.10.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate tsink-server 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tsink v0.10.0 [INFO] [stderr] Downloaded roaring v0.11.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba5c14d053032aae5f1da3ffa06e04b722fae0b2108833974c7e60fdae89ca74 [INFO] running `Command { std: "docker" "start" "-a" "ba5c14d053032aae5f1da3ffa06e04b722fae0b2108833974c7e60fdae89ca74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba5c14d053032aae5f1da3ffa06e04b722fae0b2108833974c7e60fdae89ca74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba5c14d053032aae5f1da3ffa06e04b722fae0b2108833974c7e60fdae89ca74", kill_on_drop: false }` [INFO] [stdout] ba5c14d053032aae5f1da3ffa06e04b722fae0b2108833974c7e60fdae89ca74 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9f16a3862bff644da53e584de9d84702742678ae70d75b11b610615a28e1773c [INFO] running `Command { std: "docker" "start" "-a" "9f16a3862bff644da53e584de9d84702742678ae70d75b11b610615a28e1773c", kill_on_drop: false }` [INFO] [stderr] Compiling aws-lc-rs v1.16.0 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.0 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling linux-raw-sys v0.12.1 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Compiling bytes v1.11.1 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Checking rusticata-macros v4.1.0 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling protoc-bin-vendored-linux-x86_32 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-s390_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-macos-x86_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-win32 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-x86_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-macos-aarch_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-ppcle_64 v3.2.0 [INFO] [stderr] Compiling protoc-bin-vendored-linux-aarch_64 v3.2.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking roaring v0.11.3 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Compiling protoc-bin-vendored v3.2.0 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking memmap2 v0.9.8 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking clap_builder v4.5.51 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Compiling petgraph v0.8.3 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling aws-lc-sys v0.37.1 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling tokio-macros v2.6.1 [INFO] [stderr] Compiling prost-derive v0.14.3 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling asn1-rs-impl v0.2.0 [INFO] [stderr] Compiling asn1-rs-derive v0.6.0 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking asn1-rs v0.7.1 [INFO] [stderr] Compiling prost v0.14.3 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.51 [INFO] [stderr] Compiling prost-types v0.14.3 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking der-parser v10.0.0 [INFO] [stderr] Checking oid-registry v0.8.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking x509-parser v0.17.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling prost-build v0.14.3 [INFO] [stderr] Checking tsink v0.10.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling tsink-server v0.10.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/bin/tsink-migrate.rs:1102:65 [INFO] [stdout] | [INFO] [stdout] 1102 | for (selector, result) in plan.selectors.iter().zip(response.results.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1102 - for (selector, result) in plan.selectors.iter().zip(response.results.into_iter()) { [INFO] [stdout] 1102 + for (selector, result) in plan.selectors.iter().zip(response.results) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/bin/tsink-migrate.rs:1166:52 [INFO] [stdout] | [INFO] [stdout] 1166 | for (selector, result) in selectors.iter().zip(response.results.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1166 - for (selector, result) in selectors.iter().zip(response.results.into_iter()) { [INFO] [stdout] 1166 + for (selector, result) in selectors.iter().zip(response.results) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/bin/tsink-migrate.rs:2462:18 [INFO] [stdout] | [INFO] [stdout] 2462 | .zip(row.timestamps.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 2462 - .zip(row.timestamps.into_iter()) [INFO] [stdout] 2462 + .zip(row.timestamps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/bin/tsink-migrate.rs:1102:65 [INFO] [stdout] | [INFO] [stdout] 1102 | for (selector, result) in plan.selectors.iter().zip(response.results.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1102 - for (selector, result) in plan.selectors.iter().zip(response.results.into_iter()) { [INFO] [stdout] 1102 + for (selector, result) in plan.selectors.iter().zip(response.results) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/bin/tsink-migrate.rs:1166:52 [INFO] [stdout] | [INFO] [stdout] 1166 | for (selector, result) in selectors.iter().zip(response.results.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1166 - for (selector, result) in selectors.iter().zip(response.results.into_iter()) { [INFO] [stdout] 1166 + for (selector, result) in selectors.iter().zip(response.results) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/bin/tsink-migrate.rs:2462:18 [INFO] [stdout] | [INFO] [stdout] 2462 | .zip(row.timestamps.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 2462 - .zip(row.timestamps.into_iter()) [INFO] [stdout] 2462 + .zip(row.timestamps) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cluster/distributed_storage.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 303 | points.sort_by(|left, right| left.timestamp.cmp(&right.timestamp)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 303 - points.sort_by(|left, right| left.timestamp.cmp(&right.timestamp)); [INFO] [stdout] 303 + points.sort_by_key(|left| left.timestamp); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cluster/hotspot.rs:497:5 [INFO] [stdout] | [INFO] [stdout] 497 | shards.sort_by(|left, right| left.shard.cmp(&right.shard)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 497 - shards.sort_by(|left, right| left.shard.cmp(&right.shard)); [INFO] [stdout] 497 + shards.sort_by_key(|left| left.shard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/handlers/public_api/remote_read.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 239 | .and_then(|selection| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 240 | | tenant::fanout_selection_for_tenant(&selection, tenant_id).map_err(|err| { [INFO] [stdout] 241 | | ReadFanoutError::InvalidRequest { [INFO] [stdout] 242 | | message: format!("invalid remote-read matchers: {err}"), [INFO] [stdout] 243 | | } [INFO] [stdout] 244 | | }) [INFO] [stdout] 245 | | })?; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/cluster/query.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | / RemoteSelectSeries { [INFO] [stdout] 230 | | node_id: String, [INFO] [stdout] 231 | | endpoint: String, [INFO] [stdout] 232 | | source: RpcError, [INFO] [stdout] 233 | | }, [INFO] [stdout] | |_____- the variant `RemoteSelectSeries` contains at least 144 bytes [INFO] [stdout] 234 | / RemoteListMetrics { [INFO] [stdout] 235 | | node_id: String, [INFO] [stdout] 236 | | endpoint: String, [INFO] [stdout] 237 | | source: RpcError, [INFO] [stdout] 238 | | }, [INFO] [stdout] | |_____- the variant `RemoteListMetrics` contains at least 144 bytes [INFO] [stdout] 239 | / RemoteSelectBatch { [INFO] [stdout] 240 | | node_id: String, [INFO] [stdout] 241 | | endpoint: String, [INFO] [stdout] 242 | | series_count: usize, [INFO] [stdout] 243 | | source: RpcError, [INFO] [stdout] 244 | | }, [INFO] [stdout] | |_____- the largest variant contains at least 152 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cluster::query::ReadFanoutError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/tenant.rs:1487:17 [INFO] [stdout] | [INFO] [stdout] 1487 | points.sort_by(|left, right| left.timestamp.cmp(&right.timestamp)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1487 - points.sort_by(|left, right| left.timestamp.cmp(&right.timestamp)); [INFO] [stdout] 1487 + points.sort_by_key(|left| left.timestamp); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cluster/distributed_storage.rs:303:9 [INFO] [stdout] | [INFO] [stdout] 303 | points.sort_by(|left, right| left.timestamp.cmp(&right.timestamp)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 303 - points.sort_by(|left, right| left.timestamp.cmp(&right.timestamp)); [INFO] [stdout] 303 + points.sort_by_key(|left| left.timestamp); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/cluster/hotspot.rs:497:5 [INFO] [stdout] | [INFO] [stdout] 497 | shards.sort_by(|left, right| left.shard.cmp(&right.shard)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 497 - shards.sort_by(|left, right| left.shard.cmp(&right.shard)); [INFO] [stdout] 497 + shards.sort_by_key(|left| left.shard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/handlers/public_api/promql.rs:645:20 [INFO] [stdout] | [INFO] [stdout] 645 | exemplars: &[(i64, f64, &[(&str, &str)])], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this closure is very large [INFO] [stdout] --> src/handlers/public_api/remote_read.rs:239:19 [INFO] [stdout] | [INFO] [stdout] 239 | .and_then(|selection| { [INFO] [stdout] | ___________________^ [INFO] [stdout] 240 | | tenant::fanout_selection_for_tenant(&selection, tenant_id).map_err(|err| { [INFO] [stdout] 241 | | ReadFanoutError::InvalidRequest { [INFO] [stdout] 242 | | message: format!("invalid remote-read matchers: {err}"), [INFO] [stdout] 243 | | } [INFO] [stdout] 244 | | }) [INFO] [stdout] 245 | | })?; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] ::: src/cluster/query.rs:229:5 [INFO] [stdout] | [INFO] [stdout] 229 | / RemoteSelectSeries { [INFO] [stdout] 230 | | node_id: String, [INFO] [stdout] 231 | | endpoint: String, [INFO] [stdout] 232 | | source: RpcError, [INFO] [stdout] 233 | | }, [INFO] [stdout] | |_____- the variant `RemoteSelectSeries` contains at least 144 bytes [INFO] [stdout] 234 | / RemoteListMetrics { [INFO] [stdout] 235 | | node_id: String, [INFO] [stdout] 236 | | endpoint: String, [INFO] [stdout] 237 | | source: RpcError, [INFO] [stdout] 238 | | }, [INFO] [stdout] | |_____- the variant `RemoteListMetrics` contains at least 144 bytes [INFO] [stdout] 239 | / RemoteSelectBatch { [INFO] [stdout] 240 | | node_id: String, [INFO] [stdout] 241 | | endpoint: String, [INFO] [stdout] 242 | | series_count: usize, [INFO] [stdout] 243 | | source: RpcError, [INFO] [stdout] 244 | | }, [INFO] [stdout] | |_____- the largest variant contains at least 152 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `cluster::query::ReadFanoutError`, for example by boxing large elements or replacing it with `Box` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/tenant.rs:1487:17 [INFO] [stdout] | [INFO] [stdout] 1487 | points.sort_by(|left, right| left.timestamp.cmp(&right.timestamp)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1487 - points.sort_by(|left, right| left.timestamp.cmp(&right.timestamp)); [INFO] [stdout] 1487 + points.sort_by_key(|left| left.timestamp); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:725:40 [INFO] [stdout] | [INFO] [stdout] 725 | let config = parse_server_args(args.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 725 - let config = parse_server_args(args.into_iter()) [INFO] [stdout] 725 + let config = parse_server_args(args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:751:37 [INFO] [stdout] | [INFO] [stdout] 751 | let err = parse_server_args(args.into_iter()).expect_err("tls key should be required"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 751 - let err = parse_server_args(args.into_iter()).expect_err("tls key should be required"); [INFO] [stdout] 751 + let err = parse_server_args(args).expect_err("tls key should be required"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:759:31 [INFO] [stdout] | [INFO] [stdout] 759 | parse_server_args(args.into_iter()).expect_err("admin API without auth must fail"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 759 - parse_server_args(args.into_iter()).expect_err("admin API without auth must fail"); [INFO] [stdout] 759 + parse_server_args(args).expect_err("admin API without auth must fail"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:772:40 [INFO] [stdout] | [INFO] [stdout] 772 | let config = parse_server_args(args.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 772 - let config = parse_server_args(args.into_iter()) [INFO] [stdout] 772 + let config = parse_server_args(args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:786:31 [INFO] [stdout] | [INFO] [stdout] 786 | parse_server_args(args.into_iter()).expect("rbac config should satisfy admin auth"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 786 - parse_server_args(args.into_iter()).expect("rbac config should satisfy admin auth"); [INFO] [stdout] 786 + parse_server_args(args).expect("rbac config should satisfy admin auth"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:801:40 [INFO] [stdout] | [INFO] [stdout] 801 | let config = parse_server_args(args.into_iter()).expect("tenant config path should parse"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 801 - let config = parse_server_args(args.into_iter()).expect("tenant config path should parse"); [INFO] [stdout] 801 + let config = parse_server_args(args).expect("tenant config path should parse"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:817:31 [INFO] [stdout] | [INFO] [stdout] 817 | parse_server_args(args.into_iter()).expect_err("admin path prefix without admin API"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 817 - parse_server_args(args.into_iter()).expect_err("admin path prefix without admin API"); [INFO] [stdout] 817 + parse_server_args(args).expect_err("admin path prefix without admin API"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:836:31 [INFO] [stdout] | [INFO] [stdout] 836 | parse_server_args(args.into_iter()).expect("edge sync args should parse successfully"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 836 - parse_server_args(args.into_iter()).expect("edge sync args should parse successfully"); [INFO] [stdout] 836 + parse_server_args(args).expect("edge sync args should parse successfully"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:857:37 [INFO] [stdout] | [INFO] [stdout] 857 | let err = parse_server_args(args.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 857 - let err = parse_server_args(args.into_iter()) [INFO] [stdout] 857 + let err = parse_server_args(args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:870:37 [INFO] [stdout] | [INFO] [stdout] 870 | let err = parse_server_args(args.into_iter()).expect_err("node id must be required"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 870 - let err = parse_server_args(args.into_iter()).expect_err("node id must be required"); [INFO] [stdout] 870 + let err = parse_server_args(args).expect_err("node id must be required"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:882:37 [INFO] [stdout] | [INFO] [stdout] 882 | let err = parse_server_args(args.into_iter()).expect_err("bind must be required"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 882 - let err = parse_server_args(args.into_iter()).expect_err("bind must be required"); [INFO] [stdout] 882 + let err = parse_server_args(args).expect_err("bind must be required"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:904:40 [INFO] [stdout] | [INFO] [stdout] 904 | let config = parse_server_args(args.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 904 - let config = parse_server_args(args.into_iter()) [INFO] [stdout] 904 + let config = parse_server_args(args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:936:31 [INFO] [stdout] | [INFO] [stdout] 936 | parse_server_args(args.into_iter()).expect("consistency flags should parse cleanly"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 936 - parse_server_args(args.into_iter()).expect("consistency flags should parse cleanly"); [INFO] [stdout] 936 + parse_server_args(args).expect("consistency flags should parse cleanly"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:969:31 [INFO] [stdout] | [INFO] [stdout] 969 | parse_server_args(args.into_iter()).expect("cluster internal auth token should parse"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 969 - parse_server_args(args.into_iter()).expect("cluster internal auth token should parse"); [INFO] [stdout] 969 + parse_server_args(args).expect("cluster internal auth token should parse"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:982:37 [INFO] [stdout] | [INFO] [stdout] 982 | let err = parse_server_args(args.into_iter()).expect_err("empty token should fail"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 982 - let err = parse_server_args(args.into_iter()).expect_err("empty token should fail"); [INFO] [stdout] 982 + let err = parse_server_args(args).expect_err("empty token should fail"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:989:37 [INFO] [stdout] | [INFO] [stdout] 989 | let err = parse_server_args(args.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 989 - let err = parse_server_args(args.into_iter()) [INFO] [stdout] 989 + let err = parse_server_args(args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:1012:37 [INFO] [stdout] | [INFO] [stdout] 1012 | let err = parse_server_args(args.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1012 - let err = parse_server_args(args.into_iter()) [INFO] [stdout] 1012 + let err = parse_server_args(args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:1038:31 [INFO] [stdout] | [INFO] [stdout] 1038 | parse_server_args(args.into_iter()).expect("query-only compute node should parse"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1038 - parse_server_args(args.into_iter()).expect("query-only compute node should parse"); [INFO] [stdout] 1038 + parse_server_args(args).expect("query-only compute node should parse"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:1060:31 [INFO] [stdout] | [INFO] [stdout] 1060 | parse_server_args(args.into_iter()).expect("legacy listener flags should parse"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1060 - parse_server_args(args.into_iter()).expect("legacy listener flags should parse"); [INFO] [stdout] 1060 + parse_server_args(args).expect("legacy listener flags should parse"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:1070:37 [INFO] [stdout] | [INFO] [stdout] 1070 | let err = parse_server_args(args.into_iter()).expect_err("empty statsd tenant should fail"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/main.rs:507:8 [INFO] [stdout] | [INFO] [stdout] 507 | I: IntoIterator, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 1070 - let err = parse_server_args(args.into_iter()).expect_err("empty statsd tenant should fail"); [INFO] [stdout] 1070 + let err = parse_server_args(args).expect_err("empty statsd tenant should fail"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 17s [INFO] running `Command { std: "docker" "inspect" "9f16a3862bff644da53e584de9d84702742678ae70d75b11b610615a28e1773c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f16a3862bff644da53e584de9d84702742678ae70d75b11b610615a28e1773c", kill_on_drop: false }` [INFO] [stdout] 9f16a3862bff644da53e584de9d84702742678ae70d75b11b610615a28e1773c