[INFO] fetching crate tsid 0.3.4... [INFO] linting tsid-0.3.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tsid 0.3.4 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate tsid 0.3.4 [INFO] finished tweaking crates.io crate tsid 0.3.4 [INFO] tweaked toml for crates.io crate tsid 0.3.4 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tsid 0.3.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate tsid 0.3.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cc v1.1.7 [INFO] [stderr] Downloaded bson v2.11.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 83ce2d39b656272c822cde40b82b2f0de7040a4bc712fa851cf75a62a67ab456 [INFO] running `Command { std: "docker" "start" "-a" "83ce2d39b656272c822cde40b82b2f0de7040a4bc712fa851cf75a62a67ab456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "83ce2d39b656272c822cde40b82b2f0de7040a4bc712fa851cf75a62a67ab456", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83ce2d39b656272c822cde40b82b2f0de7040a4bc712fa851cf75a62a67ab456", kill_on_drop: false }` [INFO] [stdout] 83ce2d39b656272c822cde40b82b2f0de7040a4bc712fa851cf75a62a67ab456 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 930b5a3ad11dd3547b7a9b70fd315cd83dd89a4007544f87411009b4f8e5b0d1 [INFO] running `Command { std: "docker" "start" "-a" "930b5a3ad11dd3547b7a9b70fd315cd83dd89a4007544f87411009b4f8e5b0d1", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling phf_macros v0.11.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tsid v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tsid/conversions.rs:22:66 [INFO] [stdout] | [INFO] [stdout] 22 | if !value.as_bytes().iter().all(|c| REVERSE.contains_key(&c)) { [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tsid/display.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return f.write_str(chars.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return f.write_str(chars.as_str()); [INFO] [stdout] 24 + f.write_str(chars.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking bson v2.11.0 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tsid/conversions.rs:22:66 [INFO] [stdout] | [INFO] [stdout] 22 | if !value.as_bytes().iter().all(|c| REVERSE.contains_key(&c)) { [INFO] [stdout] | ^^ help: change this to: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsid/conversions.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | assert!(!TSID::try_from("").is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `TSID::try_from("").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsid/conversions.rs:86:17 [INFO] [stdout] | [INFO] [stdout] 86 | assert!(!TSID::try_from("0123456789AB").is_ok()); // Too short (12) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `TSID::try_from("0123456789AB").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/tsid/conversions.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | assert!(!TSID::try_from("0123456789ABCC").is_ok()); // Too long (14) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `TSID::try_from("0123456789ABCC").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tsid/display.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | return f.write_str(chars.as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return f.write_str(chars.as_str()); [INFO] [stdout] 24 + f.write_str(chars.as_str()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `assert!` args [INFO] [stdout] --> src/tsid/display.rs:40:16 [INFO] [stdout] | [INFO] [stdout] 40 | id2.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `assert!` args [INFO] [stdout] --> src/tsid/mod.rs:141:16 [INFO] [stdout] | [INFO] [stdout] 141 | id2.to_string(), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.53s [INFO] running `Command { std: "docker" "inspect" "930b5a3ad11dd3547b7a9b70fd315cd83dd89a4007544f87411009b4f8e5b0d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "930b5a3ad11dd3547b7a9b70fd315cd83dd89a4007544f87411009b4f8e5b0d1", kill_on_drop: false }` [INFO] [stdout] 930b5a3ad11dd3547b7a9b70fd315cd83dd89a4007544f87411009b4f8e5b0d1