[INFO] fetching crate trout 0.4.0... [INFO] linting trout-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate trout 0.4.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate trout 0.4.0 [INFO] finished tweaking crates.io crate trout 0.4.0 [INFO] tweaked toml for crates.io crate trout 0.4.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate trout 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate trout 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded want v0.3.0 [INFO] [stderr] Downloaded tokio-macros v1.7.0 [INFO] [stderr] Downloaded num_cpus v1.13.1 [INFO] [stderr] Downloaded httparse v1.5.1 [INFO] [stderr] Downloaded futures-task v0.3.19 [INFO] [stderr] Downloaded tower-service v0.3.1 [INFO] [stderr] Downloaded pin-project-lite v0.2.8 [INFO] [stderr] Downloaded http v0.2.6 [INFO] [stderr] Downloaded ntapi v0.3.6 [INFO] [stderr] Downloaded futures-channel v0.3.19 [INFO] [stderr] Downloaded futures-core v0.3.19 [INFO] [stderr] Downloaded futures-util v0.3.19 [INFO] [stderr] Downloaded libc v0.2.112 [INFO] [stderr] Downloaded itoa v1.0.1 [INFO] [stderr] Downloaded http-body v0.4.4 [INFO] [stderr] Downloaded httpdate v1.0.2 [INFO] [stderr] Downloaded bytes v1.1.0 [INFO] [stderr] Downloaded try-lock v0.2.3 [INFO] [stderr] Downloaded miow v0.3.7 [INFO] [stderr] Downloaded tokio v1.15.0 [INFO] [stderr] Downloaded socket2 v0.4.2 [INFO] [stderr] Downloaded tracing v0.1.29 [INFO] [stderr] Downloaded syn v1.0.85 [INFO] [stderr] Downloaded mio v0.7.14 [INFO] [stderr] Downloaded hyper v0.14.16 [INFO] [stderr] Downloaded proc-macro2 v1.0.36 [INFO] [stderr] Downloaded tracing-core v0.1.21 [INFO] [stderr] Downloaded percent-encoding v2.1.0 [INFO] [stderr] Downloaded log v0.4.14 [INFO] [stderr] Downloaded quote v1.0.14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3d63b904c2aede6e0e98d914d37166d96151d8e1155e2afddc0e98778cb50ca [INFO] running `Command { std: "docker" "start" "-a" "e3d63b904c2aede6e0e98d914d37166d96151d8e1155e2afddc0e98778cb50ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3d63b904c2aede6e0e98d914d37166d96151d8e1155e2afddc0e98778cb50ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3d63b904c2aede6e0e98d914d37166d96151d8e1155e2afddc0e98778cb50ca", kill_on_drop: false }` [INFO] [stdout] e3d63b904c2aede6e0e98d914d37166d96151d8e1155e2afddc0e98778cb50ca [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dffd6db258bcfe0dce196f7cc5836abeb50ca9c8f79ffb92b0282e26fd6a5af8 [INFO] running `Command { std: "docker" "start" "-a" "dffd6db258bcfe0dce196f7cc5836abeb50ca9c8f79ffb92b0282e26fd6a5af8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Compiling syn v1.0.85 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Compiling futures-task v0.3.19 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Compiling futures-channel v0.3.19 [INFO] [stderr] Compiling httparse v1.5.1 [INFO] [stderr] Checking tracing-core v0.1.21 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking tracing v0.1.29 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking socket2 v0.4.2 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking trout v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/node.rs:36:33 [INFO] [stdout] | [INFO] [stdout] 36 | let mut remaining = &path[self.0.len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/node.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | if path.starts_with(self.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 35 ~ if let Some() = path.strip_prefix(self.0) { [INFO] [stdout] 36 ~ let mut remaining = ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/node.rs:120:15 [INFO] [stdout] | [INFO] [stdout] 120 | handlers: HashMap T + Send + Sync>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/node.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if !self.handlers.insert(method, Box::new(handler)).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.handlers.insert(method, Box::new(handler)).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/node.rs:209:37 [INFO] [stdout] | [INFO] [stdout] 209 | match self.handlers.get(&req.method()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `req.method()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | fn path<'a>(&'a self) -> &'a str; [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 28 - fn path<'a>(&'a self) -> &'a str; [INFO] [stdout] 28 + fn path(&self) -> &str; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 30 | fn method<'a>(&'a self) -> &Self::Method; [INFO] [stdout] | ^^ ^^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 30 - fn method<'a>(&'a self) -> &Self::Method; [INFO] [stdout] 30 + fn method(&self) -> &Self::Method; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | &self [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/lib.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 30 | fn method<'a>(&'a self) -> &Self::Method; [INFO] [stdout] | -- ^^^^^^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 30 | fn method<'a>(&'a self) -> &'a Self::Method; [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking hyper v0.14.16 [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/node.rs:36:33 [INFO] [stdout] | [INFO] [stdout] 36 | let mut remaining = &path[self.0.len()..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/node.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | if path.starts_with(self.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 35 ~ if let Some() = path.strip_prefix(self.0) { [INFO] [stdout] 36 ~ let mut remaining = ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/node.rs:120:15 [INFO] [stdout] | [INFO] [stdout] 120 | handlers: HashMap T + Send + Sync>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/node.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 146 | if !self.handlers.insert(method, Box::new(handler)).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.handlers.insert(method, Box::new(handler)).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/node.rs:209:37 [INFO] [stdout] | [INFO] [stdout] 209 | match self.handlers.get(&req.method()) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `req.method()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | fn path<'a>(&'a self) -> &'a str; [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 28 - fn path<'a>(&'a self) -> &'a str; [INFO] [stdout] 28 + fn path(&self) -> &str; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 30 | fn method<'a>(&'a self) -> &Self::Method; [INFO] [stdout] | ^^ ^^ ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 30 - fn method<'a>(&'a self) -> &Self::Method; [INFO] [stdout] 30 + fn method(&self) -> &Self::Method; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | &self [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/lib.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 30 | fn method<'a>(&'a self) -> &Self::Method; [INFO] [stdout] | -- ^^^^^^^^^^^^^ the same lifetime is elided here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 30 | fn method<'a>(&'a self) -> &'a Self::Method; [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.32s [INFO] running `Command { std: "docker" "inspect" "dffd6db258bcfe0dce196f7cc5836abeb50ca9c8f79ffb92b0282e26fd6a5af8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dffd6db258bcfe0dce196f7cc5836abeb50ca9c8f79ffb92b0282e26fd6a5af8", kill_on_drop: false }` [INFO] [stdout] dffd6db258bcfe0dce196f7cc5836abeb50ca9c8f79ffb92b0282e26fd6a5af8