[INFO] fetching crate trctl 2.7.10... [INFO] linting trctl-2.7.10 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate trctl 2.7.10 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate trctl 2.7.10 [INFO] finished tweaking crates.io crate trctl 2.7.10 [INFO] tweaked toml for crates.io crate trctl 2.7.10 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate trctl 2.7.10 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate trctl 2.7.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded transmission-rpc v0.5.0 [INFO] [stderr] Downloaded value-bag v1.11.1 [INFO] [stderr] Downloaded enum-iterator v2.1.0 [INFO] [stderr] Downloaded wfd v0.1.7 [INFO] [stderr] Downloaded hostname v0.4.1 [INFO] [stderr] Downloaded magnet-uri v0.2.0 [INFO] [stderr] Downloaded byte-unit v5.1.6 [INFO] [stderr] Downloaded email-encoding v0.4.1 [INFO] [stderr] Downloaded clap v4.5.36 [INFO] [stderr] Downloaded ascii v1.1.0 [INFO] [stderr] Downloaded chumsky v0.9.3 [INFO] [stderr] Downloaded bendy v0.3.3 [INFO] [stderr] Downloaded zvariant v5.4.0 [INFO] [stderr] Downloaded rusqlite v0.34.0 [INFO] [stderr] Downloaded rust_decimal v1.37.1 [INFO] [stderr] Downloaded clap_builder v4.5.36 [INFO] [stderr] Downloaded quick-xml v0.37.4 [INFO] [stderr] Downloaded zbus v5.5.0 [INFO] [stderr] Downloaded winnow v0.7.6 [INFO] [stderr] Downloaded async-std v1.13.1 [INFO] [stderr] Downloaded quinn-proto v0.11.10 [INFO] [stderr] Downloaded lettre v0.11.15 [INFO] [stderr] Downloaded openssl-sys v0.9.107 [INFO] [stderr] Downloaded notify-rust v4.11.7 [INFO] [stderr] Downloaded quinn-udp v0.5.11 [INFO] [stderr] Downloaded clap_complete v4.5.47 [INFO] [stderr] Downloaded native-dialog v0.7.0 [INFO] [stderr] Downloaded tauri-winrt-notification v0.7.2 [INFO] [stderr] Downloaded zbus_macros v5.5.0 [INFO] [stderr] Downloaded confy v0.6.1 [INFO] [stderr] Downloaded mac-notification-sys v0.6.4 [INFO] [stderr] Downloaded zvariant_derive v5.4.0 [INFO] [stderr] Downloaded versions v5.0.1 [INFO] [stderr] Downloaded libsqlite3-sys v0.32.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f8a64dabcaa0a0fddde9ea968542596e7110b7edc8bb45a0a28f8901ca0361ec [INFO] running `Command { std: "docker" "start" "-a" "f8a64dabcaa0a0fddde9ea968542596e7110b7edc8bb45a0a28f8901ca0361ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f8a64dabcaa0a0fddde9ea968542596e7110b7edc8bb45a0a28f8901ca0361ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f8a64dabcaa0a0fddde9ea968542596e7110b7edc8bb45a0a28f8901ca0361ec", kill_on_drop: false }` [INFO] [stdout] f8a64dabcaa0a0fddde9ea968542596e7110b7edc8bb45a0a28f8901ca0361ec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb8f2eaa151a126bc0509b0916c5133cd035fe38dd351d7685aba1faada1ecb9 [INFO] running `Command { std: "docker" "start" "-a" "cb8f2eaa151a126bc0509b0916c5133cd035fe38dd351d7685aba1faada1ecb9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling cc v1.2.19 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Compiling winnow v0.7.6 [INFO] [stderr] Compiling icu_locid_transform_data v1.5.1 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling indexmap v2.9.0 [INFO] [stderr] Compiling icu_properties_data v1.5.1 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling icu_normalizer_data v1.5.1 [INFO] [stderr] Checking futures-lite v2.6.0 [INFO] [stderr] Checking unicode-ident v1.0.18 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rustls v0.23.26 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling endi v1.1.0 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking event-listener v5.4.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Compiling openssl v0.10.72 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Compiling libsqlite3-sys v0.32.0 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Compiling rust_decimal v1.37.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking clap_builder v4.5.36 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling openssl-sys v0.9.107 [INFO] [stderr] Compiling psm v0.1.25 [INFO] [stderr] Compiling stacker v0.1.20 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling toml_edit v0.22.24 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking tokio v1.44.2 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking async-executor v1.13.1 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling time-core v0.1.4 [INFO] [stderr] Compiling anyhow v1.0.97 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Compiling time-macros v0.2.22 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking chumsky v0.9.3 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking hostname v0.4.1 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking email-encoding v0.4.1 [INFO] [stderr] Checking hashlink v0.10.0 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking utf8-width v0.1.7 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking quoted_printable v0.5.1 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking versions v5.0.1 [INFO] [stderr] Compiling trctl v2.7.10 (/opt/rustwide/workdir) [INFO] [stderr] Checking email_address v0.2.9 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking faccess v0.2.4 [INFO] [stderr] Checking sha-1 v0.10.1 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking rusqlite v0.34.0 [INFO] [stderr] Checking whoami v1.6.0 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking base32 v0.5.1 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking rustls-webpki v0.103.1 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking bendy v0.3.3 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling enumflags2_derive v0.7.11 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Compiling enum-iterator-derive v1.4.0 [INFO] [stderr] Checking enum-iterator v2.1.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking native-dialog v0.7.0 [INFO] [stderr] Checking polling v3.7.4 [INFO] [stderr] Checking hyper-util v0.1.11 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking clap v4.5.36 [INFO] [stderr] Checking clap_complete v4.5.47 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking async-io v2.4.0 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking async-process v2.3.0 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking hyper-rustls v0.27.5 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking enumflags2 v0.7.11 [INFO] [stderr] Checking zvariant_utils v3.2.0 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.40 [INFO] [stderr] Checking serde_urlencoded v0.5.5 [INFO] [stderr] Checking byte-unit v5.1.6 [INFO] [stderr] Checking magnet-uri v0.2.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Compiling zvariant_derive v5.4.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking toml v0.8.20 [INFO] [stderr] Checking reqwest v0.12.15 [INFO] [stderr] Checking lettre v0.11.15 [INFO] [stderr] Compiling zvariant v5.4.0 [INFO] [stderr] Checking confy v0.6.1 [INFO] [stderr] Checking transmission-rpc v0.5.0 [INFO] [stderr] Checking zbus_names v4.2.0 [INFO] [stderr] Compiling zbus_macros v5.5.0 [INFO] [stderr] Checking zbus v5.5.0 [INFO] [stderr] Checking notify-rust v4.11.7 [INFO] [stdout] warning: `#[ignore]` without reason [INFO] [stdout] --> src/console.rs:897:5 [INFO] [stdout] | [INFO] [stdout] 897 | #[ignore] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: add a reason with `= ".."` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignore_without_reason [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(clippy::all, clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::ignore_without_reason)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[ignore]` without reason [INFO] [stdout] --> src/console.rs:909:5 [INFO] [stdout] | [INFO] [stdout] 909 | #[ignore] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: add a reason with `= ".."` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignore_without_reason [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[ignore]` without reason [INFO] [stdout] --> src/lib.rs:692:5 [INFO] [stdout] | [INFO] [stdout] 692 | #[ignore] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: add a reason with `= ".."` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ignore_without_reason [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/client.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / impl Default for Sort { [INFO] [stdout] 175 | | fn default() -> Self { [INFO] [stdout] 176 | | Self::Id [INFO] [stdout] 177 | | } [INFO] [stdout] 178 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(clippy::all, clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 166 + #[derive(Default)] [INFO] [stdout] 167 | pub enum Sort { [INFO] [stdout] 168 ~ #[default] [INFO] [stdout] 169 ~ Id, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/client.rs:204:21 [INFO] [stdout] | [INFO] [stdout] 204 | torrents.sort_unstable_by(|x, y| y.id.cmp(&x.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 - torrents.sort_unstable_by(|x, y| y.id.cmp(&x.id)); [INFO] [stdout] 204 + torrents.sort_unstable_by_key(|y| std::cmp::Reverse(y.id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/client.rs:206:21 [INFO] [stdout] | [INFO] [stdout] 206 | torrents.sort_unstable_by(|x, y| x.id.cmp(&y.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 206 - torrents.sort_unstable_by(|x, y| x.id.cmp(&y.id)); [INFO] [stdout] 206 + torrents.sort_unstable_by_key(|x| x.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly cloning a `String` by calling `to_string` on its dereferenced type [INFO] [stdout] --> src/client.rs:246:55 [INFO] [stdout] | [INFO] [stdout] 246 | v.extend(qcmd.hsh.iter().map(|i| Id::Hash(i.to_string()))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using: `i.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone [INFO] [stdout] = note: `#[warn(clippy::implicit_clone)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/client.rs:174:1 [INFO] [stdout] | [INFO] [stdout] 174 | / impl Default for Sort { [INFO] [stdout] 175 | | fn default() -> Self { [INFO] [stdout] 176 | | Self::Id [INFO] [stdout] 177 | | } [INFO] [stdout] 178 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(clippy::all, clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 166 + #[derive(Default)] [INFO] [stdout] 167 | pub enum Sort { [INFO] [stdout] 168 ~ #[default] [INFO] [stdout] 169 ~ Id, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/client.rs:204:21 [INFO] [stdout] | [INFO] [stdout] 204 | torrents.sort_unstable_by(|x, y| y.id.cmp(&x.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 - torrents.sort_unstable_by(|x, y| y.id.cmp(&x.id)); [INFO] [stdout] 204 + torrents.sort_unstable_by_key(|y| std::cmp::Reverse(y.id)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/client.rs:206:21 [INFO] [stdout] | [INFO] [stdout] 206 | torrents.sort_unstable_by(|x, y| x.id.cmp(&y.id)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 206 - torrents.sort_unstable_by(|x, y| x.id.cmp(&y.id)); [INFO] [stdout] 206 + torrents.sort_unstable_by_key(|x| x.id); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly cloning a `String` by calling `to_string` on its dereferenced type [INFO] [stdout] --> src/client.rs:246:55 [INFO] [stdout] | [INFO] [stdout] 246 | v.extend(qcmd.hsh.iter().map(|i| Id::Hash(i.to_string()))); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using: `i.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_clone [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(clippy::all, clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::implicit_clone)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/console.rs:372:33 [INFO] [stdout] | [INFO] [stdout] 372 | self.do_log(format_args!("{:#}", err), log::Level::Error, false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 372 - self.do_log(format_args!("{:#}", err), log::Level::Error, false) [INFO] [stdout] 372 + self.do_log(format_args!("{err:#}"), log::Level::Error, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variables can be used directly in the `format!` string [INFO] [stdout] --> src/console.rs:372:33 [INFO] [stdout] | [INFO] [stdout] 372 | self.do_log(format_args!("{:#}", err), log::Level::Error, false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args [INFO] [stdout] = note: `#[warn(clippy::uninlined_format_args)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 372 - self.do_log(format_args!("{:#}", err), log::Level::Error, false) [INFO] [stdout] 372 + self.do_log(format_args!("{err:#}"), log::Level::Error, false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field name starts with the struct's name [INFO] [stdout] --> src/display.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | status: TorrentStatus, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_field_names [INFO] [stdout] = note: `#[warn(clippy::struct_field_names)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:261:25 [INFO] [stdout] | [INFO] [stdout] 261 | width = if width < 7 { 0 } else { width - 7 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:315:29 [INFO] [stdout] | [INFO] [stdout] 315 | width = if width < 4 { 0 } else { width - 4 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:322:29 [INFO] [stdout] | [INFO] [stdout] 322 | width = if width < 4 { 0 } else { width - 4 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:329:29 [INFO] [stdout] | [INFO] [stdout] 329 | width = if width < 4 { 0 } else { width - 4 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:336:29 [INFO] [stdout] | [INFO] [stdout] 336 | width = if width < 5 { 0 } else { width - 5 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:375:29 [INFO] [stdout] | [INFO] [stdout] 375 | width = if width < 1 { 0 } else { width - 1 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:385:21 [INFO] [stdout] | [INFO] [stdout] 385 | width = if width < 4 { 0 } else { width - 4 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field name starts with the struct's name [INFO] [stdout] --> src/display.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | status: TorrentStatus, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_field_names [INFO] [stdout] = note: `#[warn(clippy::struct_field_names)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:261:25 [INFO] [stdout] | [INFO] [stdout] 261 | width = if width < 7 { 0 } else { width - 7 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:315:29 [INFO] [stdout] | [INFO] [stdout] 315 | width = if width < 4 { 0 } else { width - 4 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:322:29 [INFO] [stdout] | [INFO] [stdout] 322 | width = if width < 4 { 0 } else { width - 4 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:329:29 [INFO] [stdout] | [INFO] [stdout] 329 | width = if width < 4 { 0 } else { width - 4 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:336:29 [INFO] [stdout] | [INFO] [stdout] 336 | width = if width < 5 { 0 } else { width - 5 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:375:29 [INFO] [stdout] | [INFO] [stdout] 375 | width = if width < 1 { 0 } else { width - 1 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual arithmetic check found [INFO] [stdout] --> src/display.rs:385:21 [INFO] [stdout] | [INFO] [stdout] 385 | width = if width < 4 { 0 } else { width - 4 } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `width.saturating_sub(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: indexing into a string with a character position where a byte index is expected [INFO] [stdout] --> src/escape.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | escaped_string.push_str(&input[..i]); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: a character can take up more than one byte, so they are not interchangeable [INFO] [stdout] note: position comes from the enumerate iterator [INFO] [stdout] --> src/escape.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | for (i, ch) in input.chars().enumerate() { [INFO] [stdout] | ^ ^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_indices_as_byte_indices [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(clippy::all, clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::char_indices_as_byte_indices)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: consider using `.char_indices()` instead [INFO] [stdout] | [INFO] [stdout] 6 - for (i, ch) in input.chars().enumerate() { [INFO] [stdout] 6 + for (i, ch) in input.char_indices() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: indexing into a string with a character position where a byte index is expected [INFO] [stdout] --> src/escape.rs:26:29 [INFO] [stdout] | [INFO] [stdout] 26 | for ch in input[i..].chars() { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: a character can take up more than one byte, so they are not interchangeable [INFO] [stdout] note: position comes from the enumerate iterator [INFO] [stdout] --> src/escape.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | for (i, ch) in input.chars().enumerate() { [INFO] [stdout] | ^ ^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_indices_as_byte_indices [INFO] [stdout] help: consider using `.char_indices()` instead [INFO] [stdout] | [INFO] [stdout] 6 - for (i, ch) in input.chars().enumerate() { [INFO] [stdout] 6 + for (i, ch) in input.char_indices() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: indexing into a string with a character position where a byte index is expected [INFO] [stdout] --> src/escape.rs:22:46 [INFO] [stdout] | [INFO] [stdout] 22 | escaped_string.push_str(&input[..i]); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: a character can take up more than one byte, so they are not interchangeable [INFO] [stdout] note: position comes from the enumerate iterator [INFO] [stdout] --> src/escape.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | for (i, ch) in input.chars().enumerate() { [INFO] [stdout] | ^ ^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_indices_as_byte_indices [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | #![warn(clippy::all, clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::char_indices_as_byte_indices)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: consider using `.char_indices()` instead [INFO] [stdout] | [INFO] [stdout] 6 - for (i, ch) in input.chars().enumerate() { [INFO] [stdout] 6 + for (i, ch) in input.char_indices() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: indexing into a string with a character position where a byte index is expected [INFO] [stdout] --> src/escape.rs:26:29 [INFO] [stdout] | [INFO] [stdout] 26 | for ch in input[i..].chars() { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: a character can take up more than one byte, so they are not interchangeable [INFO] [stdout] note: position comes from the enumerate iterator [INFO] [stdout] --> src/escape.rs:6:10 [INFO] [stdout] | [INFO] [stdout] 6 | for (i, ch) in input.chars().enumerate() { [INFO] [stdout] | ^ ^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_indices_as_byte_indices [INFO] [stdout] help: consider using `.char_indices()` instead [INFO] [stdout] | [INFO] [stdout] 6 - for (i, ch) in input.chars().enumerate() { [INFO] [stdout] 6 + for (i, ch) in input.char_indices() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 06s [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/escape.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn zsh(input: &str) -> Cow { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 4 | pub fn zsh(input: &str) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/escape.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn zsh(input: &str) -> Cow { [INFO] [stdout] | ^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 4 | pub fn zsh(input: &str) -> Cow<'_, str> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "cb8f2eaa151a126bc0509b0916c5133cd035fe38dd351d7685aba1faada1ecb9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb8f2eaa151a126bc0509b0916c5133cd035fe38dd351d7685aba1faada1ecb9", kill_on_drop: false }` [INFO] [stdout] cb8f2eaa151a126bc0509b0916c5133cd035fe38dd351d7685aba1faada1ecb9