[INFO] fetching crate tract-cuda 0.22.1... [INFO] linting tract-cuda-0.22.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tract-cuda 0.22.1 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate tract-cuda 0.22.1 [INFO] finished tweaking crates.io crate tract-cuda 0.22.1 [INFO] tweaked toml for crates.io crate tract-cuda 0.22.1 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tract-cuda 0.22.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate tract-cuda 0.22.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tract-data v0.22.1 [INFO] [stderr] Downloaded nom-language v0.1.0 [INFO] [stderr] Downloaded scan_fmt v0.2.6 [INFO] [stderr] Downloaded dyn-hash v0.2.2 [INFO] [stderr] Downloaded string-interner v0.15.0 [INFO] [stderr] Downloaded liquid v0.26.8 [INFO] [stderr] Downloaded liquid-derive v0.26.8 [INFO] [stderr] Downloaded tract-linalg v0.22.1 [INFO] [stderr] Downloaded tract-transformers v0.22.1 [INFO] [stderr] Downloaded tract-gpu v0.22.1 [INFO] [stderr] Downloaded liquid-lib v0.26.8 [INFO] [stderr] Downloaded tract-core v0.22.1 [INFO] [stderr] Downloaded liquid-core v0.26.8 [INFO] [stderr] Downloaded tract-nnef v0.22.1 [INFO] [stderr] Downloaded cudarc v0.16.6 [INFO] [stderr] Downloaded safetensors v0.6.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 93b727b1ee85358c0ba9eb0939970ff310b2e453b1ddfc1a96c68010dfc09958 [INFO] running `Command { std: "docker" "start" "-a" "93b727b1ee85358c0ba9eb0939970ff310b2e453b1ddfc1a96c68010dfc09958", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "93b727b1ee85358c0ba9eb0939970ff310b2e453b1ddfc1a96c68010dfc09958", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93b727b1ee85358c0ba9eb0939970ff310b2e453b1ddfc1a96c68010dfc09958", kill_on_drop: false }` [INFO] [stdout] 93b727b1ee85358c0ba9eb0939970ff310b2e453b1ddfc1a96c68010dfc09958 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8bd0ea5c1b60b73d11369bddb2d42b15c7bab276899a5bc9a5297ea564a1f787 [INFO] running `Command { std: "docker" "start" "-a" "8bd0ea5c1b60b73d11369bddb2d42b15c7bab276899a5bc9a5297ea564a1f787", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Compiling libc v0.2.164 [INFO] [stderr] Compiling pest v2.8.6 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling regex-syntax v0.8.9 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling deranged v0.5.8 [INFO] [stderr] Compiling anymap2 v0.13.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling doc-comment v0.3.4 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling unicode-normalization v0.1.25 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking dyn-hash v0.2.2 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Compiling pastey v0.1.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking anymap3 v1.0.1 [INFO] [stderr] Compiling cudarc v0.16.6 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking filetime v0.2.27 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand_xorshift v0.4.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling pest_meta v2.8.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Compiling half v2.4.1 [INFO] [stderr] Checking ndarray v0.16.1 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling liquid-derive v0.26.8 [INFO] [stderr] Checking xattr v1.4.0 [INFO] [stderr] Checking tempfile v3.17.1 [INFO] [stderr] Checking rustfft v6.4.1 [INFO] [stderr] Checking tar v0.4.44 [INFO] [stderr] Checking rusty-fork v0.3.1 [INFO] [stderr] Compiling pest_generator v2.8.6 [INFO] [stderr] Checking proptest v1.10.0 [INFO] [stderr] Checking nom-language v0.1.0 [INFO] [stderr] Compiling pest_derive v2.8.6 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking scan_fmt v0.2.6 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking string-interner v0.15.0 [INFO] [stderr] Compiling kstring v2.0.2 [INFO] [stderr] Checking safetensors v0.6.2 [INFO] [stderr] Compiling liquid-core v0.26.8 [INFO] [stderr] Checking tract-data v0.22.1 [INFO] [stderr] Checking liquid-lib v0.26.8 [INFO] [stderr] Checking liquid v0.26.8 [INFO] [stderr] Compiling tract-linalg v0.22.1 [INFO] [stderr] Checking tract-core v0.22.1 [INFO] [stderr] Checking tract-nnef v0.22.1 [INFO] [stderr] Checking tract-gpu v0.22.1 [INFO] [stderr] Checking tract-transformers v0.22.1 [INFO] [stderr] Checking tract-cuda v0.22.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/kernels/array/concat.rs:95:50 [INFO] [stdout] | [INFO] [stdout] 95 | for (input, offset) in inputs.iter().zip(offsets.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 95 - for (input, offset) in inputs.iter().zip(offsets.into_iter()) { [INFO] [stdout] 95 + for (input, offset) in inputs.iter().zip(offsets) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/kernels/matmul/mod.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / impl Default for CudaGemmImplKind { [INFO] [stdout] 25 | | fn default() -> Self { [INFO] [stdout] 26 | | Self::Ggml [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 20 + #[derive(Default)] [INFO] [stdout] 21 | pub enum CudaGemmImplKind { [INFO] [stdout] 22 ~ #[default] [INFO] [stdout] 23 ~ Ggml, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/kernels/array/concat.rs:95:50 [INFO] [stdout] | [INFO] [stdout] 95 | for (input, offset) in inputs.iter().zip(offsets.into_iter()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 95 - for (input, offset) in inputs.iter().zip(offsets.into_iter()) { [INFO] [stdout] 95 + for (input, offset) in inputs.iter().zip(offsets) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `F` goes unused in function definition [INFO] [stdout] --> src/kernels/array/permute_axes.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | fn run_test_case(shape: &[usize], axes: &[usize]) -> TractResult<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default [INFO] [stdout] help: consider removing the parameter [INFO] [stdout] | [INFO] [stdout] 138 - fn run_test_case(shape: &[usize], axes: &[usize]) -> TractResult<()> { [INFO] [stdout] 138 + fn run_test_case(shape: &[usize], axes: &[usize]) -> TractResult<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `f32` [INFO] [stdout] --> src/kernels/matmul/ggml/mod.rs:672:63 [INFO] [stdout] | [INFO] [stdout] 672 | let b_data: Vec = b_data.into_iter().map(|x| x.into()).collect(); [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/kernels/matmul/mod.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | / impl Default for CudaGemmImplKind { [INFO] [stdout] 25 | | fn default() -> Self { [INFO] [stdout] 26 | | Self::Ggml [INFO] [stdout] 27 | | } [INFO] [stdout] 28 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 20 + #[derive(Default)] [INFO] [stdout] 21 | pub enum CudaGemmImplKind { [INFO] [stdout] 22 ~ #[default] [INFO] [stdout] 23 ~ Ggml, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/kernels/matmul/mod.rs:438:42 [INFO] [stdout] | [INFO] [stdout] 438 | if a_dt == DatumType::F16 && !(b_dt == DatumType::F16) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(b_dt != DatumType::F16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/kernels/matmul/mod.rs:441:42 [INFO] [stdout] | [INFO] [stdout] 441 | if b_dt == DatumType::F16 && !(a_dt == DatumType::F16) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(a_dt != DatumType::F16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/kernels/matmul/mod.rs:551:31 [INFO] [stdout] | [INFO] [stdout] 551 | b_offset: 1 * n * k * dt.size_of(), [INFO] [stdout] | ^^^^^ help: consider reducing it to: `n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/kernels/matmul/mod.rs:626:31 [INFO] [stdout] | [INFO] [stdout] 626 | a_offset: 1 * m * k * dt.size_of(), [INFO] [stdout] | ^^^^^ help: consider reducing it to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/kernels/matmul/mod.rs:630:31 [INFO] [stdout] | [INFO] [stdout] 630 | c_offset: 1 * m * n * dt.size_of(), [INFO] [stdout] | ^^^^^ help: consider reducing it to: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/ops/change_axes.rs:239:26 [INFO] [stdout] | [INFO] [stdout] 239 | let cuda_model = CudaTransform::default().transform_into(model)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 239 - let cuda_model = CudaTransform::default().transform_into(model)?; [INFO] [stdout] 239 + let cuda_model = CudaTransform.transform_into(model)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/ops/dyn_kv_cache.rs:239:30 [INFO] [stdout] | [INFO] [stdout] 239 | let cuda_model = CudaTransform::default().transform_into(model)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 239 - let cuda_model = CudaTransform::default().transform_into(model)?; [INFO] [stdout] 239 + let cuda_model = CudaTransform.transform_into(model)?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ops/dyn_kv_cache.rs:255:40 [INFO] [stdout] | [INFO] [stdout] 255 | Tensor::from_shape(&shape, &(0..len).map(|f| f.as_()).collect::>())?; [INFO] [stdout] | ^^^^^^ help: change this to: `shape` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ops/slice.rs:122:17 [INFO] [stdout] | [INFO] [stdout] 122 | &shape, [INFO] [stdout] | ^^^^^^ help: change this to: `shape` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `eval_with_session` doesn't need a mutable reference [INFO] [stdout] --> src/ops/slice.rs:135:63 [INFO] [stdout] | [INFO] [stdout] 135 | let cuda_output = cuda_slice.eval_with_session(0, &mut session_state, tvec![a_cuda])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 135 - let cuda_output = cuda_slice.eval_with_session(0, &mut session_state, tvec![a_cuda])?; [INFO] [stdout] 135 + let cuda_output = cuda_slice.eval_with_session(0, &session_state, tvec![a_cuda])?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 50.65s [INFO] running `Command { std: "docker" "inspect" "8bd0ea5c1b60b73d11369bddb2d42b15c7bab276899a5bc9a5297ea564a1f787", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8bd0ea5c1b60b73d11369bddb2d42b15c7bab276899a5bc9a5297ea564a1f787", kill_on_drop: false }` [INFO] [stdout] 8bd0ea5c1b60b73d11369bddb2d42b15c7bab276899a5bc9a5297ea564a1f787