[INFO] fetching crate tower-http-cache-plus 0.0.2... [INFO] linting tower-http-cache-plus-0.0.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tower-http-cache-plus 0.0.2 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate tower-http-cache-plus 0.0.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate tower-http-cache-plus 0.0.2 [INFO] tweaked toml for crates.io crate tower-http-cache-plus 0.0.2 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tower-http-cache-plus 0.0.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate tower-http-cache-plus 0.0.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest Rust 1.94 compatible versions [INFO] [stderr] Adding kutil v0.0.6 [INFO] [stderr] Adding kutil-std-macros v0.0.5 [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded objc2-system-configuration v0.3.2 [INFO] [stderr] Downloaded tagptr v0.2.0 [INFO] [stderr] Downloaded if_chain v1.0.3 [INFO] [stderr] Downloaded utf8-chars v3.0.6 [INFO] [stderr] Downloaded ctrlc v3.5.2 [INFO] [stderr] Downloaded duration-str v0.21.0 [INFO] [stderr] Downloaded deluxe-core v0.5.0 [INFO] [stderr] Downloaded compression-codecs v0.4.37 [INFO] [stderr] Downloaded netdev v0.40.1 [INFO] [stderr] Downloaded seize v0.5.1 [INFO] [stderr] Downloaded async-compression v0.4.41 [INFO] [stderr] Downloaded kutil v0.0.6 [INFO] [stderr] Downloaded moka v0.12.14 [INFO] [stderr] Downloaded dlopen2 v0.5.0 [INFO] [stderr] Downloaded deluxe-macros v0.5.0 [INFO] [stderr] Downloaded deluxe v0.5.0 [INFO] [stderr] Downloaded netlink-packet-route v0.29.0 [INFO] [stderr] Downloaded netlink-packet-core v0.8.1 [INFO] [stderr] Downloaded kutil-std-macros v0.0.5 [INFO] [stderr] Downloaded objc2-security v0.3.2 [INFO] [stderr] Downloaded mac-addr v0.3.0 [INFO] [stderr] Downloaded netlink-sys v0.8.8 [INFO] [stderr] Downloaded nix v0.31.2 [INFO] [stderr] Downloaded papaya v0.2.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 196bba835eeab08fe8fc59a761674f21063df37eb9fdfe7a0e66fa78d3756378 [INFO] running `Command { std: "docker" "start" "-a" "196bba835eeab08fe8fc59a761674f21063df37eb9fdfe7a0e66fa78d3756378", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "196bba835eeab08fe8fc59a761674f21063df37eb9fdfe7a0e66fa78d3756378", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "196bba835eeab08fe8fc59a761674f21063df37eb9fdfe7a0e66fa78d3756378", kill_on_drop: false }` [INFO] [stdout] 196bba835eeab08fe8fc59a761674f21063df37eb9fdfe7a0e66fa78d3756378 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de602a098a859371ba7ed783671faecd72edf59e9c97afd723c3c13e6423926f [INFO] running `Command { std: "docker" "start" "-a" "de602a098a859371ba7ed783671faecd72edf59e9c97afd723c3c13e6423926f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Compiling toml_datetime v0.6.11 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling arrayvec v0.7.6 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling nix v0.31.2 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling if_chain v1.0.3 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Checking time-core v0.1.8 [INFO] [stderr] Compiling rust_decimal v1.40.0 [INFO] [stderr] Checking num-conv v0.2.0 [INFO] [stderr] Compiling convert_case v0.10.0 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking netlink-packet-core v0.8.1 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Checking compression-core v0.4.31 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking rustc-demangle v0.1.27 [INFO] [stderr] Checking winnow v0.7.15 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Checking mac-addr v0.3.0 [INFO] [stderr] Compiling kutil v0.0.6 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking outref v0.5.2 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking utf8-chars v3.0.6 [INFO] [stderr] Checking bytestring v1.5.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking bimap v0.6.3 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking seize v0.5.1 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking netlink-packet-route v0.29.0 [INFO] [stderr] Checking netlink-sys v0.8.8 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking papaya v0.2.3 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Checking ctrlc v3.5.2 [INFO] [stderr] Checking addr2line v0.25.1 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking backtrace v0.3.76 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling deluxe-core v0.5.0 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.11 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking pin-project v1.1.11 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling deluxe-macros v0.5.0 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking netdev v0.40.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking compression-codecs v0.4.37 [INFO] [stderr] Checking async-compression v0.4.41 [INFO] [stderr] Checking duration-str v0.21.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Compiling deluxe v0.5.0 [INFO] [stderr] Compiling kutil-std-macros v0.0.5 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking tower-http-cache-plus v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/service.rs:133:25 [INFO] [stdout] | [INFO] [stdout] 133 | encoding.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/service.rs:150:29 [INFO] [stdout] | [INFO] [stdout] 150 | ... encoding.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/cache/body.rs:120:33 [INFO] [stdout] | [INFO] [stdout] 120 | .insert(to_encoding.clone(), bytes.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*to_encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/cache/body.rs:139:41 [INFO] [stdout] | [INFO] [stdout] 139 | ... .insert(to_encoding.clone(), bytes.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*to_encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/cache/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | mod cache; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/cache/key/common.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | / pub fn new( [INFO] [stdout] 59 | | method: Method, [INFO] [stdout] 60 | | path: Option, [INFO] [stdout] 61 | | query: Option, [INFO] [stdout] ... | [INFO] [stdout] 67 | | extensions: Option>, [INFO] [stdout] 68 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cache/key/common.rs:159:18 [INFO] [stdout] | [INFO] [stdout] 159 | .map(|host| AsRef::::as_ref(host)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `AsRef::::as_ref` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cache/key/common.rs:165:18 [INFO] [stdout] | [INFO] [stdout] 165 | .map(|path| AsRef::::as_ref(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `AsRef::::as_ref` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/cache/key/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | mod key; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/cache/response.rs:163:23 [INFO] [stdout] | [INFO] [stdout] 163 | duration: self.duration.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.duration` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/cache/response.rs:210:58 [INFO] [stdout] | [INFO] [stdout] 210 | .set_into_header_value(CONTENT_ENCODING, encoding.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cache/middleware/request.rs:37:33 [INFO] [stdout] | [INFO] [stdout] 37 | let mut skip_cache = if !configuration.cache.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `configuration.cache.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cache/middleware/request.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 80 | / if !enabled_encodings.is_empty() { [INFO] [stdout] 81 | | self.headers() [INFO] [stdout] 82 | | .accept_encoding() [INFO] [stdout] 83 | | .best(enabled_encodings) [INFO] [stdout] ... | [INFO] [stdout] 88 | | return Encoding::Identity; [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 79 ~ Some(enabled_encodings) [INFO] [stdout] 80 ~ if !enabled_encodings.is_empty() => { [INFO] [stdout] 81 | self.headers() [INFO] [stdout] ... [INFO] [stdout] 86 | .into() [INFO] [stdout] 87 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache/middleware/responses/cached.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 62 | match self.to_response(&encoding, configuration).await { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cache/middleware/responses/upstream.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / if min_body_size != 0 { [INFO] [stdout] 101 | | if content_length < min_body_size { [INFO] [stdout] 102 | | tracing::debug!("not encoding to {} (too small)", encoding); [INFO] [stdout] 103 | | return (Encoding::Identity, true); [INFO] [stdout] 104 | | } [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if min_body_size != 0 [INFO] [stdout] 101 ~ && content_length < min_body_size { [INFO] [stdout] 102 | tracing::debug!("not encoding to {} (too small)", encoding); [INFO] [stdout] 103 | return (Encoding::Identity, true); [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/service.rs:133:25 [INFO] [stdout] | [INFO] [stdout] 133 | encoding.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/service.rs:150:29 [INFO] [stdout] | [INFO] [stdout] 150 | ... encoding.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/cache/body.rs:120:33 [INFO] [stdout] | [INFO] [stdout] 120 | .insert(to_encoding.clone(), bytes.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*to_encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/cache/body.rs:139:41 [INFO] [stdout] | [INFO] [stdout] 139 | ... .insert(to_encoding.clone(), bytes.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*to_encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/cache/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | mod cache; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/cache/key/common.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | / pub fn new( [INFO] [stdout] 59 | | method: Method, [INFO] [stdout] 60 | | path: Option, [INFO] [stdout] 61 | | query: Option, [INFO] [stdout] ... | [INFO] [stdout] 67 | | extensions: Option>, [INFO] [stdout] 68 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cache/key/common.rs:159:18 [INFO] [stdout] | [INFO] [stdout] 159 | .map(|host| AsRef::::as_ref(host)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `AsRef::::as_ref` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/cache/key/common.rs:165:18 [INFO] [stdout] | [INFO] [stdout] 165 | .map(|path| AsRef::::as_ref(path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `AsRef::::as_ref` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/cache/key/mod.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | mod key; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/cache/response.rs:163:23 [INFO] [stdout] | [INFO] [stdout] 163 | duration: self.duration.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.duration` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Encoding` which implements the `Copy` trait [INFO] [stdout] --> src/cache/response.rs:210:58 [INFO] [stdout] | [INFO] [stdout] 210 | .set_into_header_value(CONTENT_ENCODING, encoding.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cache/middleware/request.rs:37:33 [INFO] [stdout] | [INFO] [stdout] 37 | let mut skip_cache = if !configuration.cache.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `configuration.cache.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/cache/middleware/request.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 80 | / if !enabled_encodings.is_empty() { [INFO] [stdout] 81 | | self.headers() [INFO] [stdout] 82 | | .accept_encoding() [INFO] [stdout] 83 | | .best(enabled_encodings) [INFO] [stdout] ... | [INFO] [stdout] 88 | | return Encoding::Identity; [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 79 ~ Some(enabled_encodings) [INFO] [stdout] 80 ~ if !enabled_encodings.is_empty() => { [INFO] [stdout] 81 | self.headers() [INFO] [stdout] ... [INFO] [stdout] 86 | .into() [INFO] [stdout] 87 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/cache/middleware/responses/cached.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 62 | match self.to_response(&encoding, configuration).await { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `encoding` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/cache/middleware/responses/upstream.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / if min_body_size != 0 { [INFO] [stdout] 101 | | if content_length < min_body_size { [INFO] [stdout] 102 | | tracing::debug!("not encoding to {} (too small)", encoding); [INFO] [stdout] 103 | | return (Encoding::Identity, true); [INFO] [stdout] 104 | | } [INFO] [stdout] 105 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if min_body_size != 0 [INFO] [stdout] 101 ~ && content_length < min_body_size { [INFO] [stdout] 102 | tracing::debug!("not encoding to {} (too small)", encoding); [INFO] [stdout] 103 | return (Encoding::Identity, true); [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 08s [INFO] running `Command { std: "docker" "inspect" "de602a098a859371ba7ed783671faecd72edf59e9c97afd723c3c13e6423926f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de602a098a859371ba7ed783671faecd72edf59e9c97afd723c3c13e6423926f", kill_on_drop: false }` [INFO] [stdout] de602a098a859371ba7ed783671faecd72edf59e9c97afd723c3c13e6423926f