[INFO] fetching crate topo_sort 0.4.0... [INFO] linting topo_sort-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate topo_sort 0.4.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate topo_sort 0.4.0 [INFO] finished tweaking crates.io crate topo_sort 0.4.0 [INFO] tweaked toml for crates.io crate topo_sort 0.4.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate topo_sort 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.13.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 03852f5309417afabf4b5d8d925ac8e358f7f9e9ca0003b325efe7f1e13f9b8c [INFO] running `Command { std: "docker" "start" "-a" "03852f5309417afabf4b5d8d925ac8e358f7f9e9ca0003b325efe7f1e13f9b8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "03852f5309417afabf4b5d8d925ac8e358f7f9e9ca0003b325efe7f1e13f9b8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03852f5309417afabf4b5d8d925ac8e358f7f9e9ca0003b325efe7f1e13f9b8c", kill_on_drop: false }` [INFO] [stdout] 03852f5309417afabf4b5d8d925ac8e358f7f9e9ca0003b325efe7f1e13f9b8c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 25e562839c336993e2ddb55120b744b2fae1e68ce5c53ce5faeb7a5a1a072945 [INFO] running `Command { std: "docker" "start" "-a" "25e562839c336993e2ddb55120b744b2fae1e68ce5c53ce5faeb7a5a1a072945", kill_on_drop: false }` [INFO] [stderr] Checking topo_sort v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/lib.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | self.nodes().flatten().map(|node| node.clone()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.nodes().flatten().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/lib.rs:368:27 [INFO] [stdout] | [INFO] [stdout] 368 | .map(|result| result.map(|node| node.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `result.cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/lib.rs:599:6 [INFO] [stdout] | [INFO] [stdout] 599 | impl<'d, T> IntoTopoSortNodeIter [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/lib.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | self.nodes().flatten().map(|node| node.clone()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.nodes().flatten().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/lib.rs:368:27 [INFO] [stdout] | [INFO] [stdout] 368 | .map(|result| result.map(|node| node.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `result.cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/lib.rs:599:6 [INFO] [stdout] | [INFO] [stdout] 599 | impl<'d, T> IntoTopoSortNodeIter [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:726:17 [INFO] [stdout] | [INFO] [stdout] 726 | assert!(!topo_sort.try_vec_nodes().is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `topo_sort.try_vec_nodes().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:741:17 [INFO] [stdout] | [INFO] [stdout] 741 | assert!(!topo_sort.try_vec_nodes().is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `topo_sort.try_vec_nodes().is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s [INFO] running `Command { std: "docker" "inspect" "25e562839c336993e2ddb55120b744b2fae1e68ce5c53ce5faeb7a5a1a072945", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25e562839c336993e2ddb55120b744b2fae1e68ce5c53ce5faeb7a5a1a072945", kill_on_drop: false }` [INFO] [stdout] 25e562839c336993e2ddb55120b744b2fae1e68ce5c53ce5faeb7a5a1a072945