[INFO] fetching crate todoterminal 0.1.6... [INFO] linting todoterminal-0.1.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate todoterminal 0.1.6 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate todoterminal 0.1.6 [INFO] finished tweaking crates.io crate todoterminal 0.1.6 [INFO] tweaked toml for crates.io crate todoterminal 0.1.6 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate todoterminal 0.1.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate todoterminal 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded qrcode v0.14.1 [INFO] [stderr] Downloaded security-framework-sys v2.12.1 [INFO] [stderr] Downloaded cc v1.2.4 [INFO] [stderr] Downloaded qr2term v0.3.3 [INFO] [stderr] Downloaded reqwest v0.12.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 45cfe77aa93d85e9848179d7dde087d16ba40fe4eaba006bbd5a6674266b97c7 [INFO] running `Command { std: "docker" "start" "-a" "45cfe77aa93d85e9848179d7dde087d16ba40fe4eaba006bbd5a6674266b97c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45cfe77aa93d85e9848179d7dde087d16ba40fe4eaba006bbd5a6674266b97c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45cfe77aa93d85e9848179d7dde087d16ba40fe4eaba006bbd5a6674266b97c7", kill_on_drop: false }` [INFO] [stdout] 45cfe77aa93d85e9848179d7dde087d16ba40fe4eaba006bbd5a6674266b97c7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 277f8810fbe93c658fd3894c9a9a0c419cf3d3f5909db27cc0b17e05c9c3f61b [INFO] running `Command { std: "docker" "start" "-a" "277f8810fbe93c658fd3894c9a9a0c419cf3d3f5909db27cc0b17e05c9c3f61b", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Compiling libc v0.2.168 [INFO] [stderr] Compiling cc v1.2.4 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling serde v1.0.216 [INFO] [stderr] Compiling rustix v0.38.42 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Checking qrcode v0.14.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking qr2term v0.3.3 [INFO] [stderr] Compiling openssl v0.10.68 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking tokio v1.42.0 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.7 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking hyper v1.5.2 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.9 [INFO] [stderr] Checking todoterminal v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 137 | if !contents.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `contents.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:137:8 [INFO] [stdout] | [INFO] [stdout] 137 | if !contents.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `contents.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/main.rs:403:37 [INFO] [stdout] | [INFO] [stdout] 403 | let repo_name = repo_root.split('/').last().unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 - let repo_name = repo_root.split('/').last().unwrap_or_default(); [INFO] [stdout] 403 + let repo_name = repo_root.split('/').next_back().unwrap_or_default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:406:54 [INFO] [stdout] | [INFO] [stdout] 406 | for todo in find_todo(&path, &file, regex.clone(), repo_name) { [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/main.rs:403:37 [INFO] [stdout] | [INFO] [stdout] 403 | let repo_name = repo_root.split('/').last().unwrap_or_default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 403 - let repo_name = repo_root.split('/').last().unwrap_or_default(); [INFO] [stdout] 403 + let repo_name = repo_root.split('/').next_back().unwrap_or_default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:406:54 [INFO] [stdout] | [INFO] [stdout] 406 | for todo in find_todo(&path, &file, regex.clone(), repo_name) { [INFO] [stdout] | ^^^^^ help: change this to: `file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `eprintln!` args [INFO] [stdout] --> src/main.rs:583:80 [INFO] [stdout] | [INFO] [stdout] 583 | eprintln!("Error: {}", json_response["error"].as_str().unwrap().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `eprintln!` args [INFO] [stdout] --> src/main.rs:583:80 [INFO] [stdout] | [INFO] [stdout] 583 | eprintln!("Error: {}", json_response["error"].as_str().unwrap().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.27s [INFO] running `Command { std: "docker" "inspect" "277f8810fbe93c658fd3894c9a9a0c419cf3d3f5909db27cc0b17e05c9c3f61b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "277f8810fbe93c658fd3894c9a9a0c419cf3d3f5909db27cc0b17e05c9c3f61b", kill_on_drop: false }` [INFO] [stdout] 277f8810fbe93c658fd3894c9a9a0c419cf3d3f5909db27cc0b17e05c9c3f61b