[INFO] fetching crate tobz1000-petgraph 0.5.1-tobz1000... [INFO] linting tobz1000-petgraph-0.5.1-tobz1000 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tobz1000-petgraph 0.5.1-tobz1000 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate tobz1000-petgraph 0.5.1-tobz1000 [INFO] finished tweaking crates.io crate tobz1000-petgraph 0.5.1-tobz1000 [INFO] tweaked toml for crates.io crate tobz1000-petgraph 0.5.1-tobz1000 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tobz1000-petgraph 0.5.1-tobz1000 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 36 packages to latest compatible versions [INFO] [stderr] Adding defmac v0.1.3 (available: v0.2.1) [INFO] [stderr] Adding fixedbitset v0.3.2 (available: v0.5.7) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.13.0) [INFO] [stderr] Adding itertools v0.8.2 (available: v0.14.0) [INFO] [stderr] Adding odds v0.2.26 (available: v0.4.0) [INFO] [stderr] Adding quickcheck v0.8.5 (available: v1.1.0) [INFO] [stderr] Adding rand v0.5.6 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded defmac v0.1.3 [INFO] [stderr] Downloaded fixedbitset v0.3.2 [INFO] [stderr] Downloaded quickcheck v0.8.5 [INFO] [stderr] Downloaded odds v0.2.26 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c17951818b1eddff705eb94410407073d91ac7f6d3e85e5fbbb9f189812ed6c3 [INFO] running `Command { std: "docker" "start" "-a" "c17951818b1eddff705eb94410407073d91ac7f6d3e85e5fbbb9f189812ed6c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c17951818b1eddff705eb94410407073d91ac7f6d3e85e5fbbb9f189812ed6c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c17951818b1eddff705eb94410407073d91ac7f6d3e85e5fbbb9f189812ed6c3", kill_on_drop: false }` [INFO] [stdout] c17951818b1eddff705eb94410407073d91ac7f6d3e85e5fbbb9f189812ed6c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7b885fb67e42ad0c55b6fa8c3a2ed6af83623b4547f5b8df8e5a39a0647b3784 [INFO] running `Command { std: "docker" "start" "-a" "7b885fb67e42ad0c55b6fa8c3a2ed6af83623b4547f5b8df8e5a39a0647b3784", kill_on_drop: false }` [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking fixedbitset v0.3.2 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking defmac v0.1.3 [INFO] [stderr] Checking odds v0.2.26 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking tobz1000-petgraph v0.5.1-tobz1000 (/opt/rustwide/workdir) [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 142 | fn neighbors(self: Self, a: Self::NodeId) -> Self::Neighbors; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 142 - fn neighbors(self: Self, a: Self::NodeId) -> Self::Neighbors; [INFO] [stdout] 142 + fn neighbors(self, a: Self::NodeId) -> Self::Neighbors; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:508:23 [INFO] [stdout] | [INFO] [stdout] 508 | fn node_bound(self: &Self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 508 - fn node_bound(self: &Self) -> usize; [INFO] [stdout] 508 + fn node_bound(&self) -> usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:510:21 [INFO] [stdout] | [INFO] [stdout] 510 | fn to_index(self: &Self, a: Self::NodeId) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 510 - fn to_index(self: &Self, a: Self::NodeId) -> usize; [INFO] [stdout] 510 + fn to_index(&self, a: Self::NodeId) -> usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:512:23 [INFO] [stdout] | [INFO] [stdout] 512 | fn from_index(self: &Self, i: usize) -> Self::NodeId; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 512 - fn from_index(self: &Self, i: usize) -> Self::NodeId; [INFO] [stdout] 512 + fn from_index(&self, i: usize) -> Self::NodeId; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:522:19 [INFO] [stdout] | [INFO] [stdout] 522 | fn node_count(self: &Self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 522 - fn node_count(self: &Self) -> usize; [INFO] [stdout] 522 + fn node_count(&self) -> usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:608:18 [INFO] [stdout] | [INFO] [stdout] 608 | fn visit_map(self: &Self) -> Self::Map; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 608 - fn visit_map(self: &Self) -> Self::Map; [INFO] [stdout] 608 + fn visit_map(&self) -> Self::Map; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:610:18 [INFO] [stdout] | [INFO] [stdout] 610 | fn reset_map(self: &Self, map: &mut Self::Map); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 610 - fn reset_map(self: &Self, map: &mut Self::Map); [INFO] [stdout] 610 + fn reset_map(&self, map: &mut Self::Map); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:709:25 [INFO] [stdout] | [INFO] [stdout] 709 | fn adjacency_matrix(self: &Self) -> Self::AdjMatrix; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 709 - fn adjacency_matrix(self: &Self) -> Self::AdjMatrix; [INFO] [stdout] 709 + fn adjacency_matrix(&self) -> Self::AdjMatrix; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:713:20 [INFO] [stdout] | [INFO] [stdout] 713 | fn is_adjacent(self: &Self, matrix: &Self::AdjMatrix, a: Self::NodeId, b: Self::NodeId) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 713 - fn is_adjacent(self: &Self, matrix: &Self::AdjMatrix, a: Self::NodeId, b: Self::NodeId) -> bool; [INFO] [stdout] 713 + fn is_adjacent(&self, matrix: &Self::AdjMatrix, a: Self::NodeId, b: Self::NodeId) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:740:19 [INFO] [stdout] | [INFO] [stdout] 740 | fn edge_count(self: &Self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 740 - fn edge_count(self: &Self) -> usize; [INFO] [stdout] 740 + fn edge_count(&self) -> usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/data.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | fn node_weight(self: &Self, id: Self::NodeId) -> Option<&Self::NodeWeight>; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 16 - fn node_weight(self: &Self, id: Self::NodeId) -> Option<&Self::NodeWeight>; [INFO] [stdout] 16 + fn node_weight(&self, id: Self::NodeId) -> Option<&Self::NodeWeight>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/data.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | fn edge_weight(self: &Self, id: Self::EdgeId) -> Option<&Self::EdgeWeight>; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 17 - fn edge_weight(self: &Self, id: Self::EdgeId) -> Option<&Self::EdgeWeight>; [INFO] [stdout] 17 + fn edge_weight(&self, id: Self::EdgeId) -> Option<&Self::EdgeWeight>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/data.rs:35:24 [INFO] [stdout] | [INFO] [stdout] 35 | fn node_weight_mut(self: &mut Self, id: Self::NodeId) -> Option<&mut Self::NodeWeight>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 35 - fn node_weight_mut(self: &mut Self, id: Self::NodeId) -> Option<&mut Self::NodeWeight>; [INFO] [stdout] 35 + fn node_weight_mut(&mut self, id: Self::NodeId) -> Option<&mut Self::NodeWeight>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/data.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | fn edge_weight_mut(self: &mut Self, id: Self::EdgeId) -> Option<&mut Self::EdgeWeight>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 36 - fn edge_weight_mut(self: &mut Self, id: Self::EdgeId) -> Option<&mut Self::EdgeWeight>; [INFO] [stdout] 36 + fn edge_weight_mut(&mut self, id: Self::EdgeId) -> Option<&mut Self::EdgeWeight>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/algo/dominators.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | node: node [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:142:18 [INFO] [stdout] | [INFO] [stdout] 142 | fn neighbors(self: Self, a: Self::NodeId) -> Self::Neighbors; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 142 - fn neighbors(self: Self, a: Self::NodeId) -> Self::Neighbors; [INFO] [stdout] 142 + fn neighbors(self, a: Self::NodeId) -> Self::Neighbors; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:508:23 [INFO] [stdout] | [INFO] [stdout] 508 | fn node_bound(self: &Self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 508 - fn node_bound(self: &Self) -> usize; [INFO] [stdout] 508 + fn node_bound(&self) -> usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:510:21 [INFO] [stdout] | [INFO] [stdout] 510 | fn to_index(self: &Self, a: Self::NodeId) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 510 - fn to_index(self: &Self, a: Self::NodeId) -> usize; [INFO] [stdout] 510 + fn to_index(&self, a: Self::NodeId) -> usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:512:23 [INFO] [stdout] | [INFO] [stdout] 512 | fn from_index(self: &Self, i: usize) -> Self::NodeId; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 512 - fn from_index(self: &Self, i: usize) -> Self::NodeId; [INFO] [stdout] 512 + fn from_index(&self, i: usize) -> Self::NodeId; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:522:19 [INFO] [stdout] | [INFO] [stdout] 522 | fn node_count(self: &Self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 522 - fn node_count(self: &Self) -> usize; [INFO] [stdout] 522 + fn node_count(&self) -> usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:608:18 [INFO] [stdout] | [INFO] [stdout] 608 | fn visit_map(self: &Self) -> Self::Map; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 608 - fn visit_map(self: &Self) -> Self::Map; [INFO] [stdout] 608 + fn visit_map(&self) -> Self::Map; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:610:18 [INFO] [stdout] | [INFO] [stdout] 610 | fn reset_map(self: &Self, map: &mut Self::Map); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 610 - fn reset_map(self: &Self, map: &mut Self::Map); [INFO] [stdout] 610 + fn reset_map(&self, map: &mut Self::Map); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:709:25 [INFO] [stdout] | [INFO] [stdout] 709 | fn adjacency_matrix(self: &Self) -> Self::AdjMatrix; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 709 - fn adjacency_matrix(self: &Self) -> Self::AdjMatrix; [INFO] [stdout] 709 + fn adjacency_matrix(&self) -> Self::AdjMatrix; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:713:20 [INFO] [stdout] | [INFO] [stdout] 713 | fn is_adjacent(self: &Self, matrix: &Self::AdjMatrix, a: Self::NodeId, b: Self::NodeId) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 713 - fn is_adjacent(self: &Self, matrix: &Self::AdjMatrix, a: Self::NodeId, b: Self::NodeId) -> bool; [INFO] [stdout] 713 + fn is_adjacent(&self, matrix: &Self::AdjMatrix, a: Self::NodeId, b: Self::NodeId) -> bool; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/visit/mod.rs:740:19 [INFO] [stdout] | [INFO] [stdout] 740 | fn edge_count(self: &Self) -> usize; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 740 - fn edge_count(self: &Self) -> usize; [INFO] [stdout] 740 + fn edge_count(&self) -> usize; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/data.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 16 | fn node_weight(self: &Self, id: Self::NodeId) -> Option<&Self::NodeWeight>; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 16 - fn node_weight(self: &Self, id: Self::NodeId) -> Option<&Self::NodeWeight>; [INFO] [stdout] 16 + fn node_weight(&self, id: Self::NodeId) -> Option<&Self::NodeWeight>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/data.rs:17:20 [INFO] [stdout] | [INFO] [stdout] 17 | fn edge_weight(self: &Self, id: Self::EdgeId) -> Option<&Self::EdgeWeight>; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 17 - fn edge_weight(self: &Self, id: Self::EdgeId) -> Option<&Self::EdgeWeight>; [INFO] [stdout] 17 + fn edge_weight(&self, id: Self::EdgeId) -> Option<&Self::EdgeWeight>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/data.rs:35:24 [INFO] [stdout] | [INFO] [stdout] 35 | fn node_weight_mut(self: &mut Self, id: Self::NodeId) -> Option<&mut Self::NodeWeight>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 35 - fn node_weight_mut(self: &mut Self, id: Self::NodeId) -> Option<&mut Self::NodeWeight>; [INFO] [stdout] 35 + fn node_weight_mut(&mut self, id: Self::NodeId) -> Option<&mut Self::NodeWeight>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/data.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | fn edge_weight_mut(self: &mut Self, id: Self::EdgeId) -> Option<&mut Self::EdgeWeight>; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 36 - fn edge_weight_mut(self: &mut Self, id: Self::EdgeId) -> Option<&mut Self::EdgeWeight>; [INFO] [stdout] 36 + fn edge_weight_mut(&mut self, id: Self::EdgeId) -> Option<&mut Self::EdgeWeight>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/algo/dominators.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | node: node [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `first_error` is never read [INFO] [stdout] --> src/csr.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 132 | pub struct EdgesNotSorted { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 133 | first_error: (usize, usize), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EdgesNotSorted` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/visit/dfsvisit.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / if let Control::Break(_) = *self { [INFO] [stdout] 100 | | true [INFO] [stdout] 101 | | } else { [INFO] [stdout] 102 | | false [INFO] [stdout] 103 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 99 - if let Control::Break(_) = *self { [INFO] [stdout] 100 - true [INFO] [stdout] 101 - } else { [INFO] [stdout] 102 - false [INFO] [stdout] 103 - } [INFO] [stdout] 99 + matches!(*self, Control::Break(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/visit/traversal.rs:471:6 [INFO] [stdout] | [INFO] [stdout] 471 | impl<'a, C, W: ?Sized> Walker for &'a mut W [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 471 - impl<'a, C, W: ?Sized> Walker for &'a mut W [INFO] [stdout] 471 + impl Walker for &mut W [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/visit/mod.rs:96:6 [INFO] [stdout] | [INFO] [stdout] 96 | impl<'a, G> GraphRef for &'a G where G: GraphBase {} [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 96 - impl<'a, G> GraphRef for &'a G where G: GraphBase {} [INFO] [stdout] 96 + impl GraphRef for &G where G: GraphBase {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/visit/mod.rs:352:6 [INFO] [stdout] | [INFO] [stdout] 352 | impl<'a, N, E> EdgeRef for (N, N, &'a E) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 352 - impl<'a, N, E> EdgeRef for (N, N, &'a E) [INFO] [stdout] 352 + impl EdgeRef for (N, N, &E) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `first_error` is never read [INFO] [stdout] --> src/csr.rs:133:5 [INFO] [stdout] | [INFO] [stdout] 132 | pub struct EdgesNotSorted { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 133 | first_error: (usize, usize), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EdgesNotSorted` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/visit/mod.rs:410:6 [INFO] [stdout] | [INFO] [stdout] 410 | impl<'a, Id, W> NodeRef for (Id, &'a W) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 410 - impl<'a, Id, W> NodeRef for (Id, &'a W) [INFO] [stdout] 410 + impl NodeRef for (Id, &W) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/visit/dfsvisit.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | / if let Control::Break(_) = *self { [INFO] [stdout] 100 | | true [INFO] [stdout] 101 | | } else { [INFO] [stdout] 102 | | false [INFO] [stdout] 103 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 99 - if let Control::Break(_) = *self { [INFO] [stdout] 100 - true [INFO] [stdout] 101 - } else { [INFO] [stdout] 102 - false [INFO] [stdout] 103 - } [INFO] [stdout] 99 + matches!(*self, Control::Break(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/data.rs:415:27 [INFO] [stdout] | [INFO] [stdout] 415 | let mut elt = match self.iter.next() { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 416 | | None => return None, [INFO] [stdout] 417 | | Some(elt) => elt, [INFO] [stdout] 418 | | }; [INFO] [stdout] | |_____________^ help: try instead: `self.iter.next()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/data.rs:431:27 [INFO] [stdout] | [INFO] [stdout] 431 | let is_node = if let Element::Node { .. } = elt { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 432 | | true [INFO] [stdout] 433 | | } else { [INFO] [stdout] 434 | | false [INFO] [stdout] 435 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 431 - let is_node = if let Element::Node { .. } = elt { [INFO] [stdout] 432 - true [INFO] [stdout] 433 - } else { [INFO] [stdout] 434 - false [INFO] [stdout] 435 - }; [INFO] [stdout] 431 + let is_node = matches!(elt, Element::Node { .. }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/visit/traversal.rs:471:6 [INFO] [stdout] | [INFO] [stdout] 471 | impl<'a, C, W: ?Sized> Walker for &'a mut W [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 471 - impl<'a, C, W: ?Sized> Walker for &'a mut W [INFO] [stdout] 471 + impl Walker for &mut W [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/adj.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 70 | | EdgeReference { [INFO] [stdout] 71 | | id: self.id, [INFO] [stdout] 72 | | edge: self.edge, [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/visit/mod.rs:96:6 [INFO] [stdout] | [INFO] [stdout] 96 | impl<'a, G> GraphRef for &'a G where G: GraphBase {} [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 96 - impl<'a, G> GraphRef for &'a G where G: GraphBase {} [INFO] [stdout] 96 + impl GraphRef for &G where G: GraphBase {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/visit/mod.rs:352:6 [INFO] [stdout] | [INFO] [stdout] 352 | impl<'a, N, E> EdgeRef for (N, N, &'a E) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 352 - impl<'a, N, E> EdgeRef for (N, N, &'a E) [INFO] [stdout] 352 + impl EdgeRef for (N, N, &E) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/visit/mod.rs:410:6 [INFO] [stdout] | [INFO] [stdout] 410 | impl<'a, Id, W> NodeRef for (Id, &'a W) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 410 - impl<'a, Id, W> NodeRef for (Id, &'a W) [INFO] [stdout] 410 + impl NodeRef for (Id, &W) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/adj.rs:431:6 [INFO] [stdout] | [INFO] [stdout] 431 | impl<'a, E, Ix: IndexType> visit::IntoNodeIdentifiers for &'a List { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 431 - impl<'a, E, Ix: IndexType> visit::IntoNodeIdentifiers for &'a List { [INFO] [stdout] 431 + impl visit::IntoNodeIdentifiers for &List { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/adj.rs:449:6 [INFO] [stdout] | [INFO] [stdout] 449 | impl<'a, Ix: IndexType, E> visit::IntoNodeReferences for &'a List { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 449 - impl<'a, Ix: IndexType, E> visit::IntoNodeReferences for &'a List { [INFO] [stdout] 449 + impl visit::IntoNodeReferences for &List { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/algo/dominators.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | while let Some(next) = self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in self.iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/algo/dominators.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | const UNDEFINED: usize = ::std::usize::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 144 - const UNDEFINED: usize = ::std::usize::MAX; [INFO] [stdout] 144 + const UNDEFINED: usize = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/algo/dominators.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | debug_assert!(!dominators.iter().any(|&dom| dom == UNDEFINED)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dominators.contains(&UNDEFINED)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/algo/dominators.rs:264:18 [INFO] [stdout] | [INFO] [stdout] 264 | .unwrap_or_else(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/algo/dominators.rs:272:6 [INFO] [stdout] | [INFO] [stdout] 272 | ) -> (Vec, HashMap>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/algo/tred.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | /// To get such a representation, use the function [`dag_to_toposorted_adjacency_list`]. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 97 | /// To get such a representation, use the function [`dag_to_toposorted_adjacency_list`]. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/data.rs:415:27 [INFO] [stdout] | [INFO] [stdout] 415 | let mut elt = match self.iter.next() { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 416 | | None => return None, [INFO] [stdout] 417 | | Some(elt) => elt, [INFO] [stdout] 418 | | }; [INFO] [stdout] | |_____________^ help: try instead: `self.iter.next()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/data.rs:431:27 [INFO] [stdout] | [INFO] [stdout] 431 | let is_node = if let Element::Node { .. } = elt { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 432 | | true [INFO] [stdout] 433 | | } else { [INFO] [stdout] 434 | | false [INFO] [stdout] 435 | | }; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 431 - let is_node = if let Element::Node { .. } = elt { [INFO] [stdout] 432 - true [INFO] [stdout] 433 - } else { [INFO] [stdout] 434 - false [INFO] [stdout] 435 - }; [INFO] [stdout] 431 + let is_node = matches!(elt, Element::Node { .. }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `clone` on a `Copy` type [INFO] [stdout] --> src/adj.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | fn clone(&self) -> Self { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 70 | | EdgeReference { [INFO] [stdout] 71 | | id: self.id, [INFO] [stdout] 72 | | edge: self.edge, [INFO] [stdout] 73 | | } [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____^ help: change this to: `{ *self }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_clone_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_clone_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/algo/mod.rs:653:17 [INFO] [stdout] | [INFO] [stdout] 653 | sort_edges: BinaryHeap>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/algo/mod.rs:793:6 [INFO] [stdout] | [INFO] [stdout] 793 | ) -> Result<(Vec, Vec>), NegativeCycle> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/adj.rs:431:6 [INFO] [stdout] | [INFO] [stdout] 431 | impl<'a, E, Ix: IndexType> visit::IntoNodeIdentifiers for &'a List { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 431 - impl<'a, E, Ix: IndexType> visit::IntoNodeIdentifiers for &'a List { [INFO] [stdout] 431 + impl visit::IntoNodeIdentifiers for &List { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/adj.rs:449:6 [INFO] [stdout] | [INFO] [stdout] 449 | impl<'a, Ix: IndexType, E> visit::IntoNodeReferences for &'a List { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 449 - impl<'a, Ix: IndexType, E> visit::IntoNodeReferences for &'a List { [INFO] [stdout] 449 + impl visit::IntoNodeReferences for &List { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `node` is used as a loop counter [INFO] [stdout] --> src/csr.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 182 | 'outer: for r in &mut rows { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `'outer: for (node, r) in (&mut rows).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/csr.rs:210:29 [INFO] [stdout] | [INFO] [stdout] 210 | if !last_target.map_or(true, |x| m > x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 210 - if !last_target.map_or(true, |x| m > x) { [INFO] [stdout] 210 + if !last_target.is_none_or(|x| m > x) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/algo/dominators.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | while let Some(next) = self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next in self.iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/algo/dominators.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | const UNDEFINED: usize = ::std::usize::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 144 - const UNDEFINED: usize = ::std::usize::MAX; [INFO] [stdout] 144 + const UNDEFINED: usize = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/algo/dominators.rs:223:20 [INFO] [stdout] | [INFO] [stdout] 223 | debug_assert!(!dominators.iter().any(|&dom| dom == UNDEFINED)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dominators.contains(&UNDEFINED)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/csr.rs:344:19 [INFO] [stdout] | [INFO] [stdout] 344 | let end = self [INFO] [stdout] | ___________________^ [INFO] [stdout] 345 | | .row [INFO] [stdout] 346 | | .get(a.index() + 1) [INFO] [stdout] 347 | | .cloned() [INFO] [stdout] 348 | | .unwrap_or_else(|| self.column.len()); [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 348 - .unwrap_or_else(|| self.column.len()); [INFO] [stdout] 348 + .unwrap_or(self.column.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `unwrap_or_else` to construct default value [INFO] [stdout] --> src/algo/dominators.rs:264:18 [INFO] [stdout] | [INFO] [stdout] 264 | .unwrap_or_else(Vec::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/algo/dominators.rs:272:6 [INFO] [stdout] | [INFO] [stdout] 272 | ) -> (Vec, HashMap>) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/algo/tred.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | /// To get such a representation, use the function [`dag_to_toposorted_adjacency_list`]. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 97 | /// To get such a representation, use the function [`dag_to_toposorted_adjacency_list`]. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/csr.rs:694:6 [INFO] [stdout] | [INFO] [stdout] 694 | impl<'a, N, E, Ty, Ix> IntoNodeIdentifiers for &'a Csr [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 694 - impl<'a, N, E, Ty, Ix> IntoNodeIdentifiers for &'a Csr [INFO] [stdout] 694 + impl IntoNodeIdentifiers for &Csr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for unsafe trait missing `# Safety` section [INFO] [stdout] --> src/graph_impl/mod.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | pub unsafe trait IndexType: Copy + Default + Hash + Ord + fmt::Debug + 'static { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/graph_impl/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | ::std::usize::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 50 - ::std::usize::MAX [INFO] [stdout] 50 + usize::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/graph_impl/mod.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | ::std::u32::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 65 - ::std::u32::MAX [INFO] [stdout] 65 + u32::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/graph_impl/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | ::std::u16::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 80 - ::std::u16::MAX [INFO] [stdout] 80 + u16::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/graph_impl/mod.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | ::std::u8::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 95 - ::std::u8::MAX [INFO] [stdout] 95 + u8::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/algo/mod.rs:653:17 [INFO] [stdout] | [INFO] [stdout] 653 | sort_edges: BinaryHeap>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/algo/mod.rs:793:6 [INFO] [stdout] | [INFO] [stdout] 793 | ) -> Result<(Vec, Vec>), NegativeCycle> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:323:5 [INFO] [stdout] | [INFO] [stdout] 323 | /// force the last node to shift its index to take its place. Similarly, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 323 | /// force the last node to shift its index to take its place. Similarly, [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:324:5 [INFO] [stdout] | [INFO] [stdout] 324 | /// removing an edge shifts the index of the last edge. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 324 | /// removing an edge shifts the index of the last edge. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | /// intervals (from 0 to *n* - 1 for *n* nodes) simplifies some graph algorithms. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 331 | /// intervals (from 0 to *n* - 1 for *n* nodes) simplifies some graph algorithms. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 334 | /// size may have better performance. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 334 | /// size may have better performance. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:337:5 [INFO] [stdout] | [INFO] [stdout] 337 | /// and `.neighbors(a).detach()`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 337 | /// and `.neighbors(a).detach()`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | /// differing weights or differing edges. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 340 | /// differing weights or differing edges. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `node` is used as a loop counter [INFO] [stdout] --> src/csr.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 182 | 'outer: for r in &mut rows { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `'outer: for (node, r) in (&mut rows).enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/csr.rs:210:29 [INFO] [stdout] | [INFO] [stdout] 210 | if !last_target.map_or(true, |x| m > x) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 210 - if !last_target.map_or(true, |x| m > x) { [INFO] [stdout] 210 + if !last_target.is_none_or(|x| m > x) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/csr.rs:344:19 [INFO] [stdout] | [INFO] [stdout] 344 | let end = self [INFO] [stdout] | ___________________^ [INFO] [stdout] 345 | | .row [INFO] [stdout] 346 | | .get(a.index() + 1) [INFO] [stdout] 347 | | .cloned() [INFO] [stdout] 348 | | .unwrap_or_else(|| self.column.len()); [INFO] [stdout] | |_________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 348 - .unwrap_or_else(|| self.column.len()); [INFO] [stdout] 348 + .unwrap_or(self.column.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/graph_impl/mod.rs:1045:38 [INFO] [stdout] | [INFO] [stdout] 1045 | pub fn into_nodes_edges(self) -> (Vec>, Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/csr.rs:694:6 [INFO] [stdout] | [INFO] [stdout] 694 | impl<'a, N, E, Ty, Ix> IntoNodeIdentifiers for &'a Csr [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 694 - impl<'a, N, E, Ty, Ix> IntoNodeIdentifiers for &'a Csr [INFO] [stdout] 694 + impl IntoNodeIdentifiers for &Csr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/graph_impl/mod.rs:1700:9 [INFO] [stdout] | [INFO] [stdout] 1700 | while let Some(edge) = self.edges.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for edge in self.edges.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/csr.rs:836:19 [INFO] [stdout] | [INFO] [stdout] 836 | while let Some(_) = dfs.next(&m) {} [INFO] [stdout] | ----------^^^^^^^--------------- help: try: `while dfs.next(&m).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/csr.rs:848:19 [INFO] [stdout] | [INFO] [stdout] 848 | while let Some(_) = dfs.next(&m) {} [INFO] [stdout] | ----------^^^^^^^--------------- help: try: `while dfs.next(&m).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/graph_impl/frozen.rs:62:10 [INFO] [stdout] | [INFO] [stdout] 62 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 63 | | &mut as Index>::Output, [INFO] [stdout] 64 | | &mut as Index>::Output, [INFO] [stdout] 65 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | /// *m*, but *not all* indices in the range are valid, since gaps are formed [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 57 | /// *m*, but *not all* indices in the range are valid, since gaps are formed [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | /// by deletions. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 58 | /// by deletions. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | /// size may have better performance. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 61 | /// size may have better performance. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | /// (as long as associated data `N` and `E` are). [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 66 | /// (as long as associated data `N` and `E` are). [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `Some(..)` [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:249:24 [INFO] [stdout] | [INFO] [stdout] 249 | let _old = replace(&mut node_slot.weight, Some(weight)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::replace()` instead: `node_slot.weight.replace(weight)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_some [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_some)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `Some(..)` [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:340:28 [INFO] [stdout] | [INFO] [stdout] 340 | let _old = replace(&mut edge.weight, Some(weight)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::replace()` instead: `edge.weight.replace(weight)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_some [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for unsafe trait missing `# Safety` section [INFO] [stdout] --> src/graph_impl/mod.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | pub unsafe trait IndexType: Copy + Default + Hash + Ord + fmt::Debug + 'static { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/graph_impl/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | ::std::usize::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 50 - ::std::usize::MAX [INFO] [stdout] 50 + usize::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/graph_impl/mod.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | ::std::u32::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 65 - ::std::u32::MAX [INFO] [stdout] 65 + u32::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/graph_impl/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | ::std::u16::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 80 - ::std::u16::MAX [INFO] [stdout] 80 + u16::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/graph_impl/mod.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | ::std::u8::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 95 - ::std::u8::MAX [INFO] [stdout] 95 + u8::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:323:5 [INFO] [stdout] | [INFO] [stdout] 323 | /// force the last node to shift its index to take its place. Similarly, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 323 | /// force the last node to shift its index to take its place. Similarly, [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:324:5 [INFO] [stdout] | [INFO] [stdout] 324 | /// removing an edge shifts the index of the last edge. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 324 | /// removing an edge shifts the index of the last edge. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:331:5 [INFO] [stdout] | [INFO] [stdout] 331 | /// intervals (from 0 to *n* - 1 for *n* nodes) simplifies some graph algorithms. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 331 | /// intervals (from 0 to *n* - 1 for *n* nodes) simplifies some graph algorithms. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:334:5 [INFO] [stdout] | [INFO] [stdout] 334 | /// size may have better performance. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 334 | /// size may have better performance. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:337:5 [INFO] [stdout] | [INFO] [stdout] 337 | /// and `.neighbors(a).detach()`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 337 | /// and `.neighbors(a).detach()`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/mod.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | /// differing weights or differing edges. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 340 | /// differing weights or differing edges. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | /// identifier, duplicated into several places in the data structure. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 46 | /// identifier, duplicated into several places in the data structure. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | /// It must be suitable as a hash table key (implementing `Eq + Hash`). [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 47 | /// It must be suitable as a hash table key (implementing `Eq + Hash`). [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | /// The node type must also implement `Ord` so that the implementation can [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 48 | /// The node type must also implement `Ord` so that the implementation can [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | /// order the pair (`a`, `b`) for an edge connecting any two nodes `a` and `b`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 49 | /// order the pair (`a`, `b`) for an edge connecting any two nodes `a` and `b`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | /// undirected. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 52 | /// undirected. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graphmap.rs:182:29 [INFO] [stdout] | [INFO] [stdout] 182 | self.nodes.entry(n).or_insert(Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/graph_impl/mod.rs:1045:38 [INFO] [stdout] | [INFO] [stdout] 1045 | pub fn into_nodes_edges(self) -> (Vec>, Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | mapping: vec![std::usize::MAX; c0], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 51 - mapping: vec![std::usize::MAX; c0], [INFO] [stdout] 51 + mapping: vec![usize::MAX; c0], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:92:55 [INFO] [stdout] | [INFO] [stdout] 92 | self.mapping[self.graph.to_index(from)] = std::usize::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 92 - self.mapping[self.graph.to_index(from)] = std::usize::MAX; [INFO] [stdout] 92 + self.mapping[self.graph.to_index(from)] = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:119:68 [INFO] [stdout] | [INFO] [stdout] 119 | elt > 0 && self.mapping[from_index + index] == std::usize::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 119 - elt > 0 && self.mapping[from_index + index] == std::usize::MAX [INFO] [stdout] 119 + elt > 0 && self.mapping[from_index + index] == usize::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:133:68 [INFO] [stdout] | [INFO] [stdout] 133 | elt > 0 && self.mapping[from_index + index] == std::usize::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 133 - elt > 0 && self.mapping[from_index + index] == std::usize::MAX [INFO] [stdout] 133 + elt > 0 && self.mapping[from_index + index] == usize::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:143:43 [INFO] [stdout] | [INFO] [stdout] 143 | .find(|&(_, &elt)| elt == std::usize::MAX) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 143 - .find(|&(_, &elt)| elt == std::usize::MAX) [INFO] [stdout] 143 + .find(|&(_, &elt)| elt == usize::MAX) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/graph_impl/mod.rs:1700:9 [INFO] [stdout] | [INFO] [stdout] 1700 | while let Some(edge) = self.edges.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for edge in self.edges.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:321:35 [INFO] [stdout] | [INFO] [stdout] 321 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 380 | if r_succ!(0) > r_succ!(1) { [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `r_succ` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 321 - if m_neigh == std::usize::MAX { [INFO] [stdout] 321 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:321:35 [INFO] [stdout] | [INFO] [stdout] 321 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 380 | if r_succ!(0) > r_succ!(1) { [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `r_succ` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 321 - if m_neigh == std::usize::MAX { [INFO] [stdout] 321 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/isomorphism.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / if st.0.graph.is_directed() { [INFO] [stdout] 385 | | if r_pred!(0) > r_pred!(1) { [INFO] [stdout] 386 | | return false; [INFO] [stdout] 387 | | } [INFO] [stdout] 388 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 384 ~ if st.0.graph.is_directed() [INFO] [stdout] 385 ~ && r_pred!(0) > r_pred!(1) { [INFO] [stdout] 386 | return false; [INFO] [stdout] 387 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:347:35 [INFO] [stdout] | [INFO] [stdout] 347 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 385 | if r_pred!(0) > r_pred!(1) { [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `r_pred` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 347 - if m_neigh == std::usize::MAX { [INFO] [stdout] 347 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:347:35 [INFO] [stdout] | [INFO] [stdout] 347 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 385 | if r_pred!(0) > r_pred!(1) { [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `r_pred` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 347 - if m_neigh == std::usize::MAX { [INFO] [stdout] 347 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/isomorphism.rs:391:9 [INFO] [stdout] | [INFO] [stdout] 391 | / if NM::enabled() { [INFO] [stdout] 392 | | if !node_match.eq(st.0.graph, st.1.graph, nodes.0, nodes.1) { [INFO] [stdout] 393 | | return false; [INFO] [stdout] 394 | | } [INFO] [stdout] 395 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 391 ~ if NM::enabled() [INFO] [stdout] 392 ~ && !node_match.eq(st.0.graph, st.1.graph, nodes.0, nodes.1) { [INFO] [stdout] 393 | return false; [INFO] [stdout] 394 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:409:39 [INFO] [stdout] | [INFO] [stdout] 409 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 459 | edge_feasibility!(0); [INFO] [stdout] | -------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `edge_feasibility` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 409 - if m_neigh == std::usize::MAX { [INFO] [stdout] 409 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:436:43 [INFO] [stdout] | [INFO] [stdout] 436 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 459 | edge_feasibility!(0); [INFO] [stdout] | -------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `edge_feasibility` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 436 - if m_neigh == std::usize::MAX { [INFO] [stdout] 436 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/graph_impl/frozen.rs:62:10 [INFO] [stdout] | [INFO] [stdout] 62 | ) -> ( [INFO] [stdout] | __________^ [INFO] [stdout] 63 | | &mut as Index>::Output, [INFO] [stdout] 64 | | &mut as Index>::Output, [INFO] [stdout] 65 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:409:39 [INFO] [stdout] | [INFO] [stdout] 409 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 460 | edge_feasibility!(1); [INFO] [stdout] | -------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `edge_feasibility` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 409 - if m_neigh == std::usize::MAX { [INFO] [stdout] 409 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:436:43 [INFO] [stdout] | [INFO] [stdout] 436 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 460 | edge_feasibility!(1); [INFO] [stdout] | -------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `edge_feasibility` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 436 - if m_neigh == std::usize::MAX { [INFO] [stdout] 436 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | /// *m*, but *not all* indices in the range are valid, since gaps are formed [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 57 | /// *m*, but *not all* indices in the range are valid, since gaps are formed [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | /// by deletions. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 58 | /// by deletions. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | /// size may have better performance. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 61 | /// size may have better performance. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | /// (as long as associated data `N` and `E` are). [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 66 | /// (as long as associated data `N` and `E` are). [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:588:31 [INFO] [stdout] | [INFO] [stdout] 588 | pop_state(&mut st, nodes); [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:590:40 [INFO] [stdout] | [INFO] [stdout] 590 | match next_from_ix(&mut st, nodes.0, open_list) { [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:601:54 [INFO] [stdout] | [INFO] [stdout] 601 | Frame::Outer => match next_candidate(&mut st) { [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:612:36 [INFO] [stdout] | [INFO] [stdout] 612 | if is_feasible(&mut st, nodes, node_match, edge_match) { [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:613:36 [INFO] [stdout] | [INFO] [stdout] 613 | push_state(&mut st, nodes); [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:624:35 [INFO] [stdout] | [INFO] [stdout] 624 | pop_state(&mut st, nodes); [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:626:40 [INFO] [stdout] | [INFO] [stdout] 626 | match next_from_ix(&mut st, nodes.0, open_list) { [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `Some(..)` [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:249:24 [INFO] [stdout] | [INFO] [stdout] 249 | let _old = replace(&mut node_slot.weight, Some(weight)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::replace()` instead: `node_slot.weight.replace(weight)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_some [INFO] [stdout] = note: `#[warn(clippy::mem_replace_option_with_some)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/iter_format.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'a, F, I, K, V> fmt::Debug for DebugMap [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing an `Option` with `Some(..)` [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:340:28 [INFO] [stdout] | [INFO] [stdout] 340 | let _old = replace(&mut edge.weight, Some(weight)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider `Option::replace()` instead: `edge.weight.replace(weight)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_option_with_some [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/matrix_graph.rs:126:1 [INFO] [stdout] | [INFO] [stdout] 126 | impl Into> for NotZero { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 126 ~ impl From> for Option { [INFO] [stdout] 127 ~ fn from(val: NotZero) -> Self { [INFO] [stdout] 128 ~ if !val.is_null() { [INFO] [stdout] 129 ~ Some(val.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/matrix_graph.rs:364:26 [INFO] [stdout] | [INFO] [stdout] 364 | let old_weight = mem::replace(&mut self.node_adjacencies[p], Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.node_adjacencies[p])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix_graph.rs:939:31 [INFO] [stdout] | [INFO] [stdout] 935 | if self.current.is_none() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = &mut self.current` [INFO] [stdout] ... [INFO] [stdout] 939 | let current = self.current.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | /// identifier, duplicated into several places in the data structure. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 46 | /// identifier, duplicated into several places in the data structure. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | /// It must be suitable as a hash table key (implementing `Eq + Hash`). [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 47 | /// It must be suitable as a hash table key (implementing `Eq + Hash`). [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:281:6 [INFO] [stdout] | [INFO] [stdout] 281 | impl<'a, Ix, E> IntoWeightedEdge for (Ix, Ix, &'a E) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 281 - impl<'a, Ix, E> IntoWeightedEdge for (Ix, Ix, &'a E) [INFO] [stdout] 281 + impl IntoWeightedEdge for (Ix, Ix, &E) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:292:6 [INFO] [stdout] | [INFO] [stdout] 292 | impl<'a, Ix, E> IntoWeightedEdge for &'a (Ix, Ix) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 292 - impl<'a, Ix, E> IntoWeightedEdge for &'a (Ix, Ix) [INFO] [stdout] 292 + impl IntoWeightedEdge for &(Ix, Ix) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:304:6 [INFO] [stdout] | [INFO] [stdout] 304 | impl<'a, Ix, E> IntoWeightedEdge for &'a (Ix, Ix, E) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 304 - impl<'a, Ix, E> IntoWeightedEdge for &'a (Ix, Ix, E) [INFO] [stdout] 304 + impl IntoWeightedEdge for &(Ix, Ix, E) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | /// The node type must also implement `Ord` so that the implementation can [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 48 | /// The node type must also implement `Ord` so that the implementation can [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | /// order the pair (`a`, `b`) for an edge connecting any two nodes `a` and `b`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 49 | /// order the pair (`a`, `b`) for an edge connecting any two nodes `a` and `b`. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/graphmap.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | /// undirected. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 52 | /// undirected. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/graphmap.rs:182:29 [INFO] [stdout] | [INFO] [stdout] 182 | self.nodes.entry(n).or_insert(Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/adj.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn edge_indices(&self) -> EdgeIndices { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 304 | pub fn edge_indices(&self) -> EdgeIndices<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/algo/dominators.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn strict_dominators(&self, node: N) -> Option> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 56 | pub fn strict_dominators(&self, node: N) -> Option> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/algo/dominators.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn dominators(&self, node: N) -> Option> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 72 | pub fn dominators(&self, node: N) -> Option> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/algo/dominators.rs:85:37 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn immediately_dominated_by(&self, node: N) -> DominatedByIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 85 | pub fn immediately_dominated_by(&self, node: N) -> DominatedByIter<'_, N> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/csr.rs:386:18 [INFO] [stdout] | [INFO] [stdout] 386 | pub fn edges(&self, a: NodeIndex) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 386 | pub fn edges(&self, a: NodeIndex) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:771:22 [INFO] [stdout] | [INFO] [stdout] 771 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 771 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:794:31 [INFO] [stdout] | [INFO] [stdout] 794 | pub fn neighbors_directed(&self, a: NodeIndex, dir: Direction) -> Neighbors { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 794 | pub fn neighbors_directed(&self, a: NodeIndex, dir: Direction) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:818:33 [INFO] [stdout] | [INFO] [stdout] 818 | pub fn neighbors_undirected(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 818 | pub fn neighbors_undirected(&self, a: NodeIndex) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:836:18 [INFO] [stdout] | [INFO] [stdout] 836 | pub fn edges(&self, a: NodeIndex) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 836 | pub fn edges(&self, a: NodeIndex) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:851:27 [INFO] [stdout] | [INFO] [stdout] 851 | pub fn edges_directed(&self, a: NodeIndex, dir: Direction) -> Edges { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 851 | pub fn edges_directed(&self, a: NodeIndex, dir: Direction) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:871:9 [INFO] [stdout] | [INFO] [stdout] 871 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 874 | ) -> EdgesConnecting { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 874 | ) -> EdgesConnecting<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:967:22 [INFO] [stdout] | [INFO] [stdout] 967 | pub fn externals(&self, dir: Direction) -> Externals { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 967 | pub fn externals(&self, dir: Direction) -> Externals<'_, N, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:998:29 [INFO] [stdout] | [INFO] [stdout] 998 | pub fn node_weights_mut(&mut self) -> NodeWeightsMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 998 | pub fn node_weights_mut(&mut self) -> NodeWeightsMut<'_, N, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:1015:28 [INFO] [stdout] | [INFO] [stdout] 1015 | pub fn edge_references(&self) -> EdgeReferences { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1015 | pub fn edge_references(&self) -> EdgeReferences<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:1025:29 [INFO] [stdout] | [INFO] [stdout] 1025 | pub fn edge_weights_mut(&mut self) -> EdgeWeightsMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1025 | pub fn edge_weights_mut(&mut self) -> EdgeWeightsMut<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:1544:12 [INFO] [stdout] | [INFO] [stdout] 1544 | edges: &mut [Edge], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 1547 | ) -> EdgesWalkerMut [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1547 | ) -> EdgesWalkerMut<'_, E, Ix> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:488:25 [INFO] [stdout] | [INFO] [stdout] 488 | pub fn node_indices(&self) -> NodeIndices { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 488 | pub fn node_indices(&self) -> NodeIndices<'_, N, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:533:25 [INFO] [stdout] | [INFO] [stdout] 533 | pub fn edge_indices(&self) -> EdgeIndices { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 533 | pub fn edge_indices(&self) -> EdgeIndices<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:592:22 [INFO] [stdout] | [INFO] [stdout] 592 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 592 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:611:31 [INFO] [stdout] | [INFO] [stdout] 611 | pub fn neighbors_directed(&self, a: NodeIndex, dir: Direction) -> Neighbors { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 611 | pub fn neighbors_directed(&self, a: NodeIndex, dir: Direction) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:634:33 [INFO] [stdout] | [INFO] [stdout] 634 | pub fn neighbors_undirected(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 634 | pub fn neighbors_undirected(&self, a: NodeIndex) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:652:18 [INFO] [stdout] | [INFO] [stdout] 652 | pub fn edges(&self, a: NodeIndex) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 652 | pub fn edges(&self, a: NodeIndex) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:667:27 [INFO] [stdout] | [INFO] [stdout] 667 | pub fn edges_directed(&self, a: NodeIndex, dir: Direction) -> Edges { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 667 | pub fn edges_directed(&self, a: NodeIndex, dir: Direction) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:691:22 [INFO] [stdout] | [INFO] [stdout] 691 | pub fn externals(&self, dir: Direction) -> Externals { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 691 | pub fn externals(&self, dir: Direction) -> Externals<'_, N, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:315:18 [INFO] [stdout] | [INFO] [stdout] 315 | pub fn nodes(&self) -> Nodes { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 315 | pub fn nodes(&self) -> Nodes<'_, N> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:328:22 [INFO] [stdout] | [INFO] [stdout] 328 | pub fn neighbors(&self, a: N) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 328 | pub fn neighbors(&self, a: N) -> Neighbors<'_, N, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:348:31 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn neighbors_directed(&self, a: N, dir: Direction) -> NeighborsDirected { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 348 | pub fn neighbors_directed(&self, a: N, dir: Direction) -> NeighborsDirected<'_, N, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:368:18 [INFO] [stdout] | [INFO] [stdout] 368 | pub fn edges(&self, from: N) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 368 | pub fn edges(&self, from: N) -> Edges<'_, N, E, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:391:22 [INFO] [stdout] | [INFO] [stdout] 391 | pub fn all_edges(&self) -> AllEdges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 391 | pub fn all_edges(&self) -> AllEdges<'_, N, E, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:402:26 [INFO] [stdout] | [INFO] [stdout] 402 | pub fn all_edges_mut(&mut self) -> AllEdgesMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 402 | pub fn all_edges_mut(&mut self) -> AllEdgesMut<'_, N, E, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/iter_format.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | fn format(self, separator: &str) -> Format [INFO] [stdout] | ^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 48 | fn format(self, separator: &str) -> Format<'_, Self> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | mapping: vec![std::usize::MAX; c0], [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 51 - mapping: vec![std::usize::MAX; c0], [INFO] [stdout] 51 + mapping: vec![usize::MAX; c0], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:425:22 [INFO] [stdout] | [INFO] [stdout] 425 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 425 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors<'_, Ty, Null, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:92:55 [INFO] [stdout] | [INFO] [stdout] 92 | self.mapping[self.graph.to_index(from)] = std::usize::MAX; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 92 - self.mapping[self.graph.to_index(from)] = std::usize::MAX; [INFO] [stdout] 92 + self.mapping[self.graph.to_index(from)] = usize::MAX; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:440:18 [INFO] [stdout] | [INFO] [stdout] 440 | pub fn edges(&self, a: NodeIndex) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 440 | pub fn edges(&self, a: NodeIndex) -> Edges<'_, Ty, Null, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 513 | ) -> Neighbors { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 513 | ) -> Neighbors<'_, Directed, Null, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:532:27 [INFO] [stdout] | [INFO] [stdout] 532 | pub fn edges_directed(&self, a: NodeIndex, d: Direction) -> Edges { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 532 | pub fn edges_directed(&self, a: NodeIndex, d: Direction) -> Edges<'_, Directed, Null, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:901:17 [INFO] [stdout] | [INFO] [stdout] 901 | fn iter_ids(&self) -> IdIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 901 | fn iter_ids(&self) -> IdIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:119:68 [INFO] [stdout] | [INFO] [stdout] 119 | elt > 0 && self.mapping[from_index + index] == std::usize::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 119 - elt > 0 && self.mapping[from_index + index] == std::usize::MAX [INFO] [stdout] 119 + elt > 0 && self.mapping[from_index + index] == usize::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:133:68 [INFO] [stdout] | [INFO] [stdout] 133 | elt > 0 && self.mapping[from_index + index] == std::usize::MAX [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 133 - elt > 0 && self.mapping[from_index + index] == std::usize::MAX [INFO] [stdout] 133 + elt > 0 && self.mapping[from_index + index] == usize::MAX [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:143:43 [INFO] [stdout] | [INFO] [stdout] 143 | .find(|&(_, &elt)| elt == std::usize::MAX) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 143 - .find(|&(_, &elt)| elt == std::usize::MAX) [INFO] [stdout] 143 + .find(|&(_, &elt)| elt == usize::MAX) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:321:35 [INFO] [stdout] | [INFO] [stdout] 321 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 380 | if r_succ!(0) > r_succ!(1) { [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `r_succ` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 321 - if m_neigh == std::usize::MAX { [INFO] [stdout] 321 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:321:35 [INFO] [stdout] | [INFO] [stdout] 321 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 380 | if r_succ!(0) > r_succ!(1) { [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `r_succ` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 321 - if m_neigh == std::usize::MAX { [INFO] [stdout] 321 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/isomorphism.rs:384:9 [INFO] [stdout] | [INFO] [stdout] 384 | / if st.0.graph.is_directed() { [INFO] [stdout] 385 | | if r_pred!(0) > r_pred!(1) { [INFO] [stdout] 386 | | return false; [INFO] [stdout] 387 | | } [INFO] [stdout] 388 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 384 ~ if st.0.graph.is_directed() [INFO] [stdout] 385 ~ && r_pred!(0) > r_pred!(1) { [INFO] [stdout] 386 | return false; [INFO] [stdout] 387 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:347:35 [INFO] [stdout] | [INFO] [stdout] 347 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 385 | if r_pred!(0) > r_pred!(1) { [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `r_pred` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 347 - if m_neigh == std::usize::MAX { [INFO] [stdout] 347 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:347:35 [INFO] [stdout] | [INFO] [stdout] 347 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 385 | if r_pred!(0) > r_pred!(1) { [INFO] [stdout] | ---------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `r_pred` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 347 - if m_neigh == std::usize::MAX { [INFO] [stdout] 347 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/isomorphism.rs:391:9 [INFO] [stdout] | [INFO] [stdout] 391 | / if NM::enabled() { [INFO] [stdout] 392 | | if !node_match.eq(st.0.graph, st.1.graph, nodes.0, nodes.1) { [INFO] [stdout] 393 | | return false; [INFO] [stdout] 394 | | } [INFO] [stdout] 395 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 391 ~ if NM::enabled() [INFO] [stdout] 392 ~ && !node_match.eq(st.0.graph, st.1.graph, nodes.0, nodes.1) { [INFO] [stdout] 393 | return false; [INFO] [stdout] 394 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:409:39 [INFO] [stdout] | [INFO] [stdout] 409 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 459 | edge_feasibility!(0); [INFO] [stdout] | -------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `edge_feasibility` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 409 - if m_neigh == std::usize::MAX { [INFO] [stdout] 409 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:436:43 [INFO] [stdout] | [INFO] [stdout] 436 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 459 | edge_feasibility!(0); [INFO] [stdout] | -------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `edge_feasibility` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 436 - if m_neigh == std::usize::MAX { [INFO] [stdout] 436 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:409:39 [INFO] [stdout] | [INFO] [stdout] 409 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 460 | edge_feasibility!(1); [INFO] [stdout] | -------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `edge_feasibility` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 409 - if m_neigh == std::usize::MAX { [INFO] [stdout] 409 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/isomorphism.rs:436:43 [INFO] [stdout] | [INFO] [stdout] 436 | if m_neigh == std::usize::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 460 | edge_feasibility!(1); [INFO] [stdout] | -------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `edge_feasibility` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 436 - if m_neigh == std::usize::MAX { [INFO] [stdout] 436 + if m_neigh == usize::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:588:31 [INFO] [stdout] | [INFO] [stdout] 588 | pop_state(&mut st, nodes); [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:590:40 [INFO] [stdout] | [INFO] [stdout] 590 | match next_from_ix(&mut st, nodes.0, open_list) { [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:601:54 [INFO] [stdout] | [INFO] [stdout] 601 | Frame::Outer => match next_candidate(&mut st) { [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:612:36 [INFO] [stdout] | [INFO] [stdout] 612 | if is_feasible(&mut st, nodes, node_match, edge_match) { [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:613:36 [INFO] [stdout] | [INFO] [stdout] 613 | push_state(&mut st, nodes); [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:624:35 [INFO] [stdout] | [INFO] [stdout] 624 | pop_state(&mut st, nodes); [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/isomorphism.rs:626:40 [INFO] [stdout] | [INFO] [stdout] 626 | match next_from_ix(&mut st, nodes.0, open_list) { [INFO] [stdout] | ^^^^^^^ help: change this to: `st` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/iter_format.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | impl<'a, F, I, K, V> fmt::Debug for DebugMap [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/matrix_graph.rs:126:1 [INFO] [stdout] | [INFO] [stdout] 126 | impl Into> for NotZero { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From>` [INFO] [stdout] | [INFO] [stdout] 126 ~ impl From> for Option { [INFO] [stdout] 127 ~ fn from(val: NotZero) -> Self { [INFO] [stdout] 128 ~ if !val.is_null() { [INFO] [stdout] 129 ~ Some(val.0) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/matrix_graph.rs:364:26 [INFO] [stdout] | [INFO] [stdout] 364 | let old_weight = mem::replace(&mut self.node_adjacencies[p], Default::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.node_adjacencies[p])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.current` after checking its variant with `is_none` [INFO] [stdout] --> src/matrix_graph.rs:939:31 [INFO] [stdout] | [INFO] [stdout] 935 | if self.current.is_none() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = &mut self.current` [INFO] [stdout] ... [INFO] [stdout] 939 | let current = self.current.as_mut().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/matrix_graph.rs:1274:9 [INFO] [stdout] | [INFO] [stdout] 1274 | assert_eq!(*g.edge_weight(a, b), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1274 - assert_eq!(*g.edge_weight(a, b), true); [INFO] [stdout] 1274 + assert!(*g.edge_weight(a, b)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/matrix_graph.rs:1275:9 [INFO] [stdout] | [INFO] [stdout] 1275 | assert_eq!(*g.edge_weight(b, c), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1275 - assert_eq!(*g.edge_weight(b, c), false); [INFO] [stdout] 1275 + assert!(!(*g.edge_weight(b, c))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `Ty` goes unused in function definition [INFO] [stdout] --> benches/common/factories.rs:156:16 [INFO] [stdout] | [INFO] [stdout] 156 | fn parse_graph(s: &str) -> G [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing the parameter [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/k_shortest_path.rs:23:29 [INFO] [stdout] | [INFO] [stdout] 23 | graph.extend_with_edges(&[ [INFO] [stdout] | _____________________________^ [INFO] [stdout] 24 | | (a, b), [INFO] [stdout] 25 | | (b, c), [INFO] [stdout] 26 | | (c, d), [INFO] [stdout] ... | [INFO] [stdout] 43 | | (m, e), [INFO] [stdout] 44 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 ~ graph.extend_with_edges([ [INFO] [stdout] 24 + (a, b), [INFO] [stdout] 25 + (b, c), [INFO] [stdout] 26 + (c, d), [INFO] [stdout] 27 + (b, f), [INFO] [stdout] 28 + (f, g), [INFO] [stdout] 29 + (c, g), [INFO] [stdout] 30 + (g, h), [INFO] [stdout] 31 + (d, e), [INFO] [stdout] 32 + (e, h), [INFO] [stdout] 33 + (h, i), [INFO] [stdout] 34 + (h, j), [INFO] [stdout] 35 + (h, k), [INFO] [stdout] 36 + (h, l), [INFO] [stdout] 37 + (i, m), [INFO] [stdout] 38 + (l, k), [INFO] [stdout] 39 + (j, k), [INFO] [stdout] 40 + (j, m), [INFO] [stdout] 41 + (k, m), [INFO] [stdout] 42 + (l, m), [INFO] [stdout] 43 + (m, e), [INFO] [stdout] 44 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/matrix_graph.rs:1495:66 [INFO] [stdout] | [INFO] [stdout] 1495 | let g: MatrixGraph = MatrixGraph::from_edges(&[ [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 1496 | | (0, 5), [INFO] [stdout] 1497 | | (0, 2), [INFO] [stdout] 1498 | | (0, 3), [INFO] [stdout] ... | [INFO] [stdout] 1504 | | (6, 6), [INFO] [stdout] 1505 | | ]); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1495 ~ let g: MatrixGraph = MatrixGraph::from_edges([ [INFO] [stdout] 1496 + (0, 5), [INFO] [stdout] 1497 + (0, 2), [INFO] [stdout] 1498 + (0, 3), [INFO] [stdout] 1499 + (0, 1), [INFO] [stdout] 1500 + (1, 3), [INFO] [stdout] 1501 + (2, 3), [INFO] [stdout] 1502 + (2, 4), [INFO] [stdout] 1503 + (4, 0), [INFO] [stdout] 1504 + (6, 6), [INFO] [stdout] 1505 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/matrix_graph.rs:1526:60 [INFO] [stdout] | [INFO] [stdout] 1526 | let g: UnMatrix = UnMatrix::from_edges(&[ [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 1527 | | (0, 5), [INFO] [stdout] 1528 | | (0, 2), [INFO] [stdout] 1529 | | (0, 3), [INFO] [stdout] ... | [INFO] [stdout] 1535 | | (6, 6), [INFO] [stdout] 1536 | | ]); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1526 ~ let g: UnMatrix = UnMatrix::from_edges([ [INFO] [stdout] 1527 + (0, 5), [INFO] [stdout] 1528 + (0, 2), [INFO] [stdout] 1529 + (0, 3), [INFO] [stdout] 1530 + (0, 1), [INFO] [stdout] 1531 + (1, 3), [INFO] [stdout] 1532 + (2, 3), [INFO] [stdout] 1533 + (2, 4), [INFO] [stdout] 1534 + (4, 0), [INFO] [stdout] 1535 + (6, 6), [INFO] [stdout] 1536 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/matrix_graph.rs:1561:66 [INFO] [stdout] | [INFO] [stdout] 1561 | let g: MatrixGraph = MatrixGraph::from_edges(&[ [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 1562 | | (0, 5), [INFO] [stdout] 1563 | | (0, 2), [INFO] [stdout] 1564 | | (0, 3), [INFO] [stdout] ... | [INFO] [stdout] 1570 | | (6, 6), [INFO] [stdout] 1571 | | ]); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1561 ~ let g: MatrixGraph = MatrixGraph::from_edges([ [INFO] [stdout] 1562 + (0, 5), [INFO] [stdout] 1563 + (0, 2), [INFO] [stdout] 1564 + (0, 3), [INFO] [stdout] 1565 + (0, 1), [INFO] [stdout] 1566 + (1, 3), [INFO] [stdout] 1567 + (2, 3), [INFO] [stdout] 1568 + (2, 4), [INFO] [stdout] 1569 + (4, 0), [INFO] [stdout] 1570 + (6, 6), [INFO] [stdout] 1571 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/operator.rs:13:29 [INFO] [stdout] | [INFO] [stdout] 13 | graph.extend_with_edges(&[(a, b), (b, c), (c, d)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(a, b), (b, c), (c, d)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/operator.rs:23:36 [INFO] [stdout] | [INFO] [stdout] 23 | expected_res.extend_with_edges(&[ [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 24 | | (a, c), [INFO] [stdout] 25 | | (a, d), [INFO] [stdout] 26 | | (b, a), [INFO] [stdout] ... | [INFO] [stdout] 32 | | (d, c), [INFO] [stdout] 33 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 ~ expected_res.extend_with_edges([ [INFO] [stdout] 24 + (a, c), [INFO] [stdout] 25 + (a, d), [INFO] [stdout] 26 + (b, a), [INFO] [stdout] 27 + (b, d), [INFO] [stdout] 28 + (c, a), [INFO] [stdout] 29 + (c, b), [INFO] [stdout] 30 + (d, a), [INFO] [stdout] 31 + (d, b), [INFO] [stdout] 32 + (d, c), [INFO] [stdout] 33 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/matrix_graph.rs:1578:60 [INFO] [stdout] | [INFO] [stdout] 1578 | let g: UnMatrix = UnMatrix::from_edges(&[ [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 1579 | | (0, 5), [INFO] [stdout] 1580 | | (0, 2), [INFO] [stdout] 1581 | | (0, 3), [INFO] [stdout] ... | [INFO] [stdout] 1587 | | (6, 6), [INFO] [stdout] 1588 | | ]); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1578 ~ let g: UnMatrix = UnMatrix::from_edges([ [INFO] [stdout] 1579 + (0, 5), [INFO] [stdout] 1580 + (0, 2), [INFO] [stdout] 1581 + (0, 3), [INFO] [stdout] 1582 + (0, 1), [INFO] [stdout] 1583 + (1, 3), [INFO] [stdout] 1584 + (2, 3), [INFO] [stdout] 1585 + (2, 4), [INFO] [stdout] 1586 + (4, 0), [INFO] [stdout] 1587 + (6, 6), [INFO] [stdout] 1588 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/simple_paths.rs:116:56 [INFO] [stdout] | [INFO] [stdout] 116 | let graph = DiGraph::::from_edges(&[ [INFO] [stdout] | ________________________________________________________^ [INFO] [stdout] 117 | | (0, 1), [INFO] [stdout] 118 | | (0, 2), [INFO] [stdout] 119 | | (0, 3), [INFO] [stdout] ... | [INFO] [stdout] 129 | | (5, 3), [INFO] [stdout] 130 | | ]); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 116 ~ let graph = DiGraph::::from_edges([ [INFO] [stdout] 117 + (0, 1), [INFO] [stdout] 118 + (0, 2), [INFO] [stdout] 119 + (0, 3), [INFO] [stdout] 120 + (1, 2), [INFO] [stdout] 121 + (1, 3), [INFO] [stdout] 122 + (2, 3), [INFO] [stdout] 123 + (2, 4), [INFO] [stdout] 124 + (3, 2), [INFO] [stdout] 125 + (3, 4), [INFO] [stdout] 126 + (4, 2), [INFO] [stdout] 127 + (4, 5), [INFO] [stdout] 128 + (5, 2), [INFO] [stdout] 129 + (5, 3), [INFO] [stdout] 130 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/simple_paths.rs:157:56 [INFO] [stdout] | [INFO] [stdout] 157 | let graph = DiGraph::::from_edges(&[(0, 1), (2, 1)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 1), (2, 1)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `Ty` goes unused in function definition [INFO] [stdout] --> benches/common/factories.rs:156:16 [INFO] [stdout] | [INFO] [stdout] 156 | fn parse_graph(s: &str) -> G [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing the parameter [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/simple_paths.rs:172:56 [INFO] [stdout] | [INFO] [stdout] 172 | let graph = DiGraph::::from_edges(&[(0, 1), (2, 1)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 1), (2, 1)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:281:6 [INFO] [stdout] | [INFO] [stdout] 281 | impl<'a, Ix, E> IntoWeightedEdge for (Ix, Ix, &'a E) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 281 - impl<'a, Ix, E> IntoWeightedEdge for (Ix, Ix, &'a E) [INFO] [stdout] 281 + impl IntoWeightedEdge for (Ix, Ix, &E) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:292:6 [INFO] [stdout] | [INFO] [stdout] 292 | impl<'a, Ix, E> IntoWeightedEdge for &'a (Ix, Ix) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 292 - impl<'a, Ix, E> IntoWeightedEdge for &'a (Ix, Ix) [INFO] [stdout] 292 + impl IntoWeightedEdge for &(Ix, Ix) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/lib.rs:304:6 [INFO] [stdout] | [INFO] [stdout] 304 | impl<'a, Ix, E> IntoWeightedEdge for &'a (Ix, Ix, E) [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 304 - impl<'a, Ix, E> IntoWeightedEdge for &'a (Ix, Ix, E) [INFO] [stdout] 304 + impl IntoWeightedEdge for &(Ix, Ix, E) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `Ty` goes unused in function definition [INFO] [stdout] --> benches/common/factories.rs:156:16 [INFO] [stdout] | [INFO] [stdout] 156 | fn parse_graph(s: &str) -> G [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing the parameter [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/adj.rs:304:25 [INFO] [stdout] | [INFO] [stdout] 304 | pub fn edge_indices(&self) -> EdgeIndices { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 304 | pub fn edge_indices(&self) -> EdgeIndices<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/algo/dominators.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn strict_dominators(&self, node: N) -> Option> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 56 | pub fn strict_dominators(&self, node: N) -> Option> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/algo/dominators.rs:72:23 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn dominators(&self, node: N) -> Option> { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 72 | pub fn dominators(&self, node: N) -> Option> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/algo/dominators.rs:85:37 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn immediately_dominated_by(&self, node: N) -> DominatedByIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 85 | pub fn immediately_dominated_by(&self, node: N) -> DominatedByIter<'_, N> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/csr.rs:386:18 [INFO] [stdout] | [INFO] [stdout] 386 | pub fn edges(&self, a: NodeIndex) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 386 | pub fn edges(&self, a: NodeIndex) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:771:22 [INFO] [stdout] | [INFO] [stdout] 771 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 771 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:794:31 [INFO] [stdout] | [INFO] [stdout] 794 | pub fn neighbors_directed(&self, a: NodeIndex, dir: Direction) -> Neighbors { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 794 | pub fn neighbors_directed(&self, a: NodeIndex, dir: Direction) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:818:33 [INFO] [stdout] | [INFO] [stdout] 818 | pub fn neighbors_undirected(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 818 | pub fn neighbors_undirected(&self, a: NodeIndex) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:836:18 [INFO] [stdout] | [INFO] [stdout] 836 | pub fn edges(&self, a: NodeIndex) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 836 | pub fn edges(&self, a: NodeIndex) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:851:27 [INFO] [stdout] | [INFO] [stdout] 851 | pub fn edges_directed(&self, a: NodeIndex, dir: Direction) -> Edges { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 851 | pub fn edges_directed(&self, a: NodeIndex, dir: Direction) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:871:9 [INFO] [stdout] | [INFO] [stdout] 871 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 874 | ) -> EdgesConnecting { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 874 | ) -> EdgesConnecting<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:967:22 [INFO] [stdout] | [INFO] [stdout] 967 | pub fn externals(&self, dir: Direction) -> Externals { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 967 | pub fn externals(&self, dir: Direction) -> Externals<'_, N, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:998:29 [INFO] [stdout] | [INFO] [stdout] 998 | pub fn node_weights_mut(&mut self) -> NodeWeightsMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 998 | pub fn node_weights_mut(&mut self) -> NodeWeightsMut<'_, N, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:1015:28 [INFO] [stdout] | [INFO] [stdout] 1015 | pub fn edge_references(&self) -> EdgeReferences { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1015 | pub fn edge_references(&self) -> EdgeReferences<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:1025:29 [INFO] [stdout] | [INFO] [stdout] 1025 | pub fn edge_weights_mut(&mut self) -> EdgeWeightsMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1025 | pub fn edge_weights_mut(&mut self) -> EdgeWeightsMut<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/mod.rs:1544:12 [INFO] [stdout] | [INFO] [stdout] 1544 | edges: &mut [Edge], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 1547 | ) -> EdgesWalkerMut [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 1547 | ) -> EdgesWalkerMut<'_, E, Ix> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:488:25 [INFO] [stdout] | [INFO] [stdout] 488 | pub fn node_indices(&self) -> NodeIndices { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 488 | pub fn node_indices(&self) -> NodeIndices<'_, N, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:533:25 [INFO] [stdout] | [INFO] [stdout] 533 | pub fn edge_indices(&self) -> EdgeIndices { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 533 | pub fn edge_indices(&self) -> EdgeIndices<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:592:22 [INFO] [stdout] | [INFO] [stdout] 592 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 592 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:611:31 [INFO] [stdout] | [INFO] [stdout] 611 | pub fn neighbors_directed(&self, a: NodeIndex, dir: Direction) -> Neighbors { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 611 | pub fn neighbors_directed(&self, a: NodeIndex, dir: Direction) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:634:33 [INFO] [stdout] | [INFO] [stdout] 634 | pub fn neighbors_undirected(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 634 | pub fn neighbors_undirected(&self, a: NodeIndex) -> Neighbors<'_, E, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:652:18 [INFO] [stdout] | [INFO] [stdout] 652 | pub fn edges(&self, a: NodeIndex) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 652 | pub fn edges(&self, a: NodeIndex) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:667:27 [INFO] [stdout] | [INFO] [stdout] 667 | pub fn edges_directed(&self, a: NodeIndex, dir: Direction) -> Edges { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 667 | pub fn edges_directed(&self, a: NodeIndex, dir: Direction) -> Edges<'_, E, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graph_impl/stable_graph/mod.rs:691:22 [INFO] [stdout] | [INFO] [stdout] 691 | pub fn externals(&self, dir: Direction) -> Externals { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 691 | pub fn externals(&self, dir: Direction) -> Externals<'_, N, Ty, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:315:18 [INFO] [stdout] | [INFO] [stdout] 315 | pub fn nodes(&self) -> Nodes { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 315 | pub fn nodes(&self) -> Nodes<'_, N> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:328:22 [INFO] [stdout] | [INFO] [stdout] 328 | pub fn neighbors(&self, a: N) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 328 | pub fn neighbors(&self, a: N) -> Neighbors<'_, N, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:348:31 [INFO] [stdout] | [INFO] [stdout] 348 | pub fn neighbors_directed(&self, a: N, dir: Direction) -> NeighborsDirected { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 348 | pub fn neighbors_directed(&self, a: N, dir: Direction) -> NeighborsDirected<'_, N, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:368:18 [INFO] [stdout] | [INFO] [stdout] 368 | pub fn edges(&self, from: N) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 368 | pub fn edges(&self, from: N) -> Edges<'_, N, E, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:391:22 [INFO] [stdout] | [INFO] [stdout] 391 | pub fn all_edges(&self) -> AllEdges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 391 | pub fn all_edges(&self) -> AllEdges<'_, N, E, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/graphmap.rs:402:26 [INFO] [stdout] | [INFO] [stdout] 402 | pub fn all_edges_mut(&mut self) -> AllEdgesMut { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 402 | pub fn all_edges_mut(&mut self) -> AllEdgesMut<'_, N, E, Ty> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/iter_format.rs:48:32 [INFO] [stdout] | [INFO] [stdout] 48 | fn format(self, separator: &str) -> Format [INFO] [stdout] | ^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 48 | fn format(self, separator: &str) -> Format<'_, Self> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:425:22 [INFO] [stdout] | [INFO] [stdout] 425 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 425 | pub fn neighbors(&self, a: NodeIndex) -> Neighbors<'_, Ty, Null, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:440:18 [INFO] [stdout] | [INFO] [stdout] 440 | pub fn edges(&self, a: NodeIndex) -> Edges { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 440 | pub fn edges(&self, a: NodeIndex) -> Edges<'_, Ty, Null, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:510:9 [INFO] [stdout] | [INFO] [stdout] 510 | &self, [INFO] [stdout] | ^^^^^ the lifetime is elided here [INFO] [stdout] ... [INFO] [stdout] 513 | ) -> Neighbors { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 513 | ) -> Neighbors<'_, Directed, Null, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:532:27 [INFO] [stdout] | [INFO] [stdout] 532 | pub fn edges_directed(&self, a: NodeIndex, d: Direction) -> Edges { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 532 | pub fn edges_directed(&self, a: NodeIndex, d: Direction) -> Edges<'_, Directed, Null, Ix> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/matrix_graph.rs:901:17 [INFO] [stdout] | [INFO] [stdout] 901 | fn iter_ids(&self) -> IdIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 901 | fn iter_ids(&self) -> IdIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> benches/dijkstra.rs:16:36 [INFO] [stdout] | [INFO] [stdout] 16 | let nodes: Vec> = (0..NODE_COUNT).into_iter().map(|i| g.add_node(i)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..NODE_COUNT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `nodes` [INFO] [stdout] --> benches/dijkstra.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | for j in j_from..j_to { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 22 - for j in j_from..j_to { [INFO] [stdout] 22 + for in nodes.iter().take(j_to).skip(j_from) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/iso.rs:445:41 [INFO] [stdout] | [INFO] [stdout] 445 | let g0 = Graph::<(), _>::from_edges(&[(0, 0, 1), (0, 1, 2), (0, 2, 3), (1, 2, 4)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 0, 1), (0, 1, 2), (0, 2, 3), (1, 2, 4)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/iso.rs:484:42 [INFO] [stdout] | [INFO] [stdout] 484 | let g0 = Graph::<(), ()>::from_edges(&[(0, 0), (0, 0), (0, 1), (1, 1), (1, 1), (1, 0)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 0), (0, 0), (0, 1), (1, 1), (1, 1), (1, 0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/iso.rs:486:42 [INFO] [stdout] | [INFO] [stdout] 486 | let g1 = Graph::<(), ()>::from_edges(&[(0, 0), (0, 1), (0, 1), (1, 1), (1, 0), (1, 0)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 0), (0, 1), (0, 1), (1, 1), (1, 0), (1, 0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/iso.rs:493:42 [INFO] [stdout] | [INFO] [stdout] 493 | let g0 = Graph::<(), ()>::from_edges(&[(0, 1), (1, 2), (2, 0)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 1), (1, 2), (2, 0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/iso.rs:494:48 [INFO] [stdout] | [INFO] [stdout] 494 | let g1 = MatrixGraph::<(), ()>::from_edges(&[(0, 1), (1, 2), (2, 0)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 1), (1, 2), (2, 0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/iso.rs:500:42 [INFO] [stdout] | [INFO] [stdout] 500 | let g0 = Graph::<(), ()>::from_edges(&[(0, 1), (1, 2), (2, 0)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 1), (1, 2), (2, 0)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/iso.rs:501:42 [INFO] [stdout] | [INFO] [stdout] 501 | let g1 = Graph::<(), ()>::from_edges(&[(0, 1), (1, 2), (2, 0), (2, 3)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 1), (1, 2), (2, 0), (2, 3)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::Range` [INFO] [stdout] --> benches/k_shortest_path.rs:16:36 [INFO] [stdout] | [INFO] [stdout] 16 | let nodes: Vec> = (0..NODE_COUNT).into_iter().map(|i| g.add_node(i)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..NODE_COUNT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `nodes` [INFO] [stdout] --> benches/k_shortest_path.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 22 | for j in j_from..j_to { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 22 - for j in j_from..j_to { [INFO] [stdout] 22 + for in nodes.iter().take(j_to).skip(j_from) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> benches/matrix_graph.rs:47:10 [INFO] [stdout] | [INFO] [stdout] 47 | .map(|(i, &node)| { [INFO] [stdout] | __________^ [INFO] [stdout] 48 | | let edges: Vec<_> = (0..5) [INFO] [stdout] 49 | | .map(|j| (i + j + 1) % nodes.len()) [INFO] [stdout] 50 | | .map(|j| (node, nodes[j])) [INFO] [stdout] ... | [INFO] [stdout] 54 | | }) [INFO] [stdout] 55 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 47 ~ .flat_map(|(i, &node)| { [INFO] [stdout] 48 + let edges: Vec<_> = (0..5) [INFO] [stdout] 49 + .map(|j| (i + j + 1) % nodes.len()) [INFO] [stdout] 50 + .map(|j| (node, nodes[j])) [INFO] [stdout] 51 + .collect(); [INFO] [stdout] 52 + [INFO] [stdout] 53 + edges [INFO] [stdout] 54 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> tests/graphmap.rs:128:19 [INFO] [stdout] | [INFO] [stdout] 128 | while let Some(_) = dfs.next(&gr) { [INFO] [stdout] | ----------^^^^^^^---------------- help: try: `while dfs.next(&gr).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> tests/graphmap.rs:136:19 [INFO] [stdout] | [INFO] [stdout] 136 | while let Some(_) = dfs.next(&gr) { [INFO] [stdout] | ----------^^^^^^^---------------- help: try: `while dfs.next(&gr).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/graphmap.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | assert!(!gr.add_edge(a, b, ()).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `gr.add_edge(a, b, ()).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/graphmap.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | assert!(!gr.add_edge(b, b, ()).is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `gr.add_edge(b, b, ()).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> tests/graph.rs:1827:6 [INFO] [stdout] | [INFO] [stdout] 1827 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/stable_graph.rs:68:63 [INFO] [stdout] | [INFO] [stdout] 68 | let mut gr: StableGraph<(), ()> = StableGraph::from_edges(&[ [INFO] [stdout] | _______________________________________________________________^ [INFO] [stdout] 69 | | (6, 0), [INFO] [stdout] 70 | | (0, 3), [INFO] [stdout] 71 | | (3, 6), [INFO] [stdout] ... | [INFO] [stdout] 79 | | (4, 1), [INFO] [stdout] 80 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 68 ~ let mut gr: StableGraph<(), ()> = StableGraph::from_edges([ [INFO] [stdout] 69 + (6, 0), [INFO] [stdout] 70 + (0, 3), [INFO] [stdout] 71 + (3, 6), [INFO] [stdout] 72 + (8, 6), [INFO] [stdout] 73 + (8, 2), [INFO] [stdout] 74 + (2, 5), [INFO] [stdout] 75 + (5, 8), [INFO] [stdout] 76 + (7, 5), [INFO] [stdout] 77 + (1, 7), [INFO] [stdout] 78 + (7, 4), [INFO] [stdout] 79 + (4, 1), [INFO] [stdout] 80 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/stable_graph.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 127 | gr.extend_with_edges(&[ [INFO] [stdout] | __________________________^ [INFO] [stdout] 128 | | (6, 0, e()), [INFO] [stdout] 129 | | (0, 3, e()), [INFO] [stdout] 130 | | (3, 6, e()), [INFO] [stdout] ... | [INFO] [stdout] 139 | | (4, 1, e()), [INFO] [stdout] 140 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 127 ~ gr.extend_with_edges([ [INFO] [stdout] 128 + (6, 0, e()), [INFO] [stdout] 129 + (0, 3, e()), [INFO] [stdout] 130 + (3, 6, e()), [INFO] [stdout] 131 + (8, 6, e()), [INFO] [stdout] 132 + (8, 2, e()), [INFO] [stdout] 133 + (2, 5, e()), [INFO] [stdout] 134 + (5, 8, e()), [INFO] [stdout] 135 + (7, 5, e()), [INFO] [stdout] 136 + (1, 7, e()), [INFO] [stdout] 137 + (7, 4, e()), [INFO] [stdout] 138 + (8, 6, e()), // parallel edge [INFO] [stdout] 139 + (4, 1, e()), [INFO] [stdout] 140 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/stable_graph.rs:280:25 [INFO] [stdout] | [INFO] [stdout] 280 | g.extend_with_edges(&[(a, b, 1), (a, c, 2), (b, c, 3), (c, c, 4), (a, d, 5)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(a, b, 1), (a, c, 2), (b, c, 3), (c, c, 4), (a, d, 5)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `nodes` [INFO] [stdout] --> tests/stable_graph.rs:373:14 [INFO] [stdout] | [INFO] [stdout] 373 | for i in 0..3 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 373 - for i in 0..3 { [INFO] [stdout] 373 + for in nodes.iter().take(3) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `a` and `b` are never read [INFO] [stdout] --> tests/graph.rs:1825:9 [INFO] [stdout] | [INFO] [stdout] 1824 | struct Record { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 1825 | a: i32, [INFO] [stdout] | ^ [INFO] [stdout] 1826 | b: &'static str, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `Record` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:757:26 [INFO] [stdout] | [INFO] [stdout] 757 | gr.extend_with_edges(&[ [INFO] [stdout] | __________________________^ [INFO] [stdout] 758 | | (a, b, 7.), [INFO] [stdout] 759 | | (a, d, 5.), [INFO] [stdout] 760 | | (d, b, 9.), [INFO] [stdout] ... | [INFO] [stdout] 768 | | (e, g, 9.), [INFO] [stdout] 769 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 757 ~ gr.extend_with_edges([ [INFO] [stdout] 758 + (a, b, 7.), [INFO] [stdout] 759 + (a, d, 5.), [INFO] [stdout] 760 + (d, b, 9.), [INFO] [stdout] 761 + (b, c, 8.), [INFO] [stdout] 762 + (b, e, 7.), [INFO] [stdout] 763 + (c, e, 5.), [INFO] [stdout] 764 + (d, e, 15.), [INFO] [stdout] 765 + (d, f, 6.), [INFO] [stdout] 766 + (f, e, 8.), [INFO] [stdout] 767 + (f, g, 11.), [INFO] [stdout] 768 + (e, g, 9.), [INFO] [stdout] 769 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:856:47 [INFO] [stdout] | [INFO] [stdout] 856 | let gr: Graph<(), ()> = Graph::from_edges(&[ [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 857 | | (6, 0), [INFO] [stdout] 858 | | (0, 3), [INFO] [stdout] 859 | | (3, 6), [INFO] [stdout] ... | [INFO] [stdout] 867 | | (4, 1), [INFO] [stdout] 868 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 856 ~ let gr: Graph<(), ()> = Graph::from_edges([ [INFO] [stdout] 857 + (6, 0), [INFO] [stdout] 858 + (0, 3), [INFO] [stdout] 859 + (3, 6), [INFO] [stdout] 860 + (8, 6), [INFO] [stdout] 861 + (8, 2), [INFO] [stdout] 862 + (2, 5), [INFO] [stdout] 863 + (5, 8), [INFO] [stdout] 864 + (7, 5), [INFO] [stdout] 865 + (1, 7), [INFO] [stdout] 866 + (7, 4), [INFO] [stdout] 867 + (4, 1), [INFO] [stdout] 868 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:926:26 [INFO] [stdout] | [INFO] [stdout] 926 | gr.extend_with_edges(&[(0, 0), (1, 0), (2, 0), (2, 1), (2, 2)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 0), (1, 0), (2, 0), (2, 1), (2, 2)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:938:47 [INFO] [stdout] | [INFO] [stdout] 938 | let gr: Graph<(), ()> = Graph::from_edges(&[ [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 939 | | (6, 0), [INFO] [stdout] 940 | | (0, 3), [INFO] [stdout] 941 | | (3, 6), [INFO] [stdout] ... | [INFO] [stdout] 949 | | (4, 1), [INFO] [stdout] 950 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 938 ~ let gr: Graph<(), ()> = Graph::from_edges([ [INFO] [stdout] 939 + (6, 0), [INFO] [stdout] 940 + (0, 3), [INFO] [stdout] 941 + (3, 6), [INFO] [stdout] 942 + (8, 6), [INFO] [stdout] 943 + (8, 2), [INFO] [stdout] 944 + (2, 5), [INFO] [stdout] 945 + (5, 8), [INFO] [stdout] 946 + (7, 5), [INFO] [stdout] 947 + (1, 7), [INFO] [stdout] 948 + (7, 4), [INFO] [stdout] 949 + (4, 1), [INFO] [stdout] 950 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:1006:26 [INFO] [stdout] | [INFO] [stdout] 1006 | gr.extend_with_edges(&[(0, 0), (1, 0), (2, 0), (2, 1), (2, 2)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 0), (1, 0), (2, 0), (2, 1), (2, 2)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:1020:47 [INFO] [stdout] | [INFO] [stdout] 1020 | let gr: Graph<(), ()> = Graph::from_edges(&[ [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 1021 | | (6, 0), [INFO] [stdout] 1022 | | (0, 3), [INFO] [stdout] 1023 | | (3, 6), [INFO] [stdout] ... | [INFO] [stdout] 1032 | | (4, 1), [INFO] [stdout] 1033 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1020 ~ let gr: Graph<(), ()> = Graph::from_edges([ [INFO] [stdout] 1021 + (6, 0), [INFO] [stdout] 1022 + (0, 3), [INFO] [stdout] 1023 + (3, 6), [INFO] [stdout] 1024 + (8, 6), [INFO] [stdout] 1025 + (8, 2), [INFO] [stdout] 1026 + (2, 3), [INFO] [stdout] 1027 + (2, 5), [INFO] [stdout] 1028 + (5, 8), [INFO] [stdout] 1029 + (7, 5), [INFO] [stdout] 1030 + (1, 7), [INFO] [stdout] 1031 + (7, 4), [INFO] [stdout] 1032 + (4, 1), [INFO] [stdout] 1033 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statement with no effect [INFO] [stdout] --> tests/graph.rs:1099:5 [INFO] [stdout] | [INFO] [stdout] 1099 | gr[b]; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stdout] = note: `#[warn(clippy::no_effect)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> tests/graph.rs:1194:33 [INFO] [stdout] | [INFO] [stdout] 1194 | assert_eq!(edge.weight, -1. * old[EdgeIndex::new(index)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `-old[EdgeIndex::new(index)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:1606:49 [INFO] [stdout] | [INFO] [stdout] 1606 | Graph::<(), (), Undirected>::from_edges(&[(0, 1), (0, 2), (0, 3), (1, 2), (1, 3), (2, 3)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 1), (0, 2), (0, 3), (1, 2), (1, 3), (2, 3)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:1618:60 [INFO] [stdout] | [INFO] [stdout] 1618 | let mut gr = Graph::::from_edges(&[ [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 1619 | | (0, 1, 2), [INFO] [stdout] 1620 | | (1, 1, 1), [INFO] [stdout] 1621 | | (0, 2, 0), [INFO] [stdout] 1622 | | (1, 2, 3), [INFO] [stdout] 1623 | | (2, 3, 3), [INFO] [stdout] 1624 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1618 ~ let mut gr = Graph::::from_edges([ [INFO] [stdout] 1619 + (0, 1, 2), [INFO] [stdout] 1620 + (1, 1, 1), [INFO] [stdout] 1621 + (0, 2, 0), [INFO] [stdout] 1622 + (1, 2, 3), [INFO] [stdout] 1623 + (2, 3, 3), [INFO] [stdout] 1624 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:1672:26 [INFO] [stdout] | [INFO] [stdout] 1672 | gr.extend_with_edges(&[(a, a), (a, b), (c, a), (a, a)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(a, a), (a, b), (c, a), (a, a)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:1721:26 [INFO] [stdout] | [INFO] [stdout] 1721 | gr.extend_with_edges(&[(a, a), (a, b), (c, a)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(a, a), (a, b), (c, a)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> tests/graph.rs:1743:11 [INFO] [stdout] | [INFO] [stdout] 1743 | fn degree<'a, G>(g: G, node: G::NodeId) -> usize [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `::NodeId` which implements the `Copy` trait [INFO] [stdout] --> tests/graph.rs:1749:25 [INFO] [stdout] | [INFO] [stdout] 1749 | let original_node = node.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `node` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:1760:61 [INFO] [stdout] | [INFO] [stdout] 1760 | let mut gr = Graph::::from_edges(&[ [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 1761 | | (0, 1), [INFO] [stdout] 1762 | | (1, 2), [INFO] [stdout] 1763 | | (1, 3), [INFO] [stdout] ... | [INFO] [stdout] 1768 | | (3, 5), [INFO] [stdout] 1769 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1760 ~ let mut gr = Graph::::from_edges([ [INFO] [stdout] 1761 + (0, 1), [INFO] [stdout] 1762 + (1, 2), [INFO] [stdout] 1763 + (1, 3), [INFO] [stdout] 1764 + (2, 4), [INFO] [stdout] 1765 + (3, 4), [INFO] [stdout] 1766 + (4, 4), [INFO] [stdout] 1767 + (4, 5), [INFO] [stdout] 1768 + (3, 5), [INFO] [stdout] 1769 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:2019:47 [INFO] [stdout] | [INFO] [stdout] 2019 | let gr: Graph<(), ()> = Graph::from_edges(&[ [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 2020 | | (0, 5), [INFO] [stdout] 2021 | | (0, 2), [INFO] [stdout] 2022 | | (0, 3), [INFO] [stdout] ... | [INFO] [stdout] 2028 | | (4, 5), [INFO] [stdout] 2029 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 2019 ~ let gr: Graph<(), ()> = Graph::from_edges([ [INFO] [stdout] 2020 + (0, 5), [INFO] [stdout] 2021 + (0, 2), [INFO] [stdout] 2022 + (0, 3), [INFO] [stdout] 2023 + (0, 1), [INFO] [stdout] 2024 + (1, 3), [INFO] [stdout] 2025 + (2, 3), [INFO] [stdout] 2026 + (2, 4), [INFO] [stdout] 2027 + (4, 0), [INFO] [stdout] 2028 + (4, 5), [INFO] [stdout] 2029 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:2121:27 [INFO] [stdout] | [INFO] [stdout] 2121 | Graph::from_edges(&[(0, 2), (1, 2), (0, 3), (1, 4), (2, 4), (4, 5), (3, 5)]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(0, 2), (1, 2), (0, 3), (1, 4), (2, 4), (4, 5), (3, 5)]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> tests/graph.rs:2124:15 [INFO] [stdout] | [INFO] [stdout] 2124 | while let Some(_) = dfs.next(&gr) {} [INFO] [stdout] | ----------^^^^^^^---------------- help: try: `while dfs.next(&gr).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> tests/graph.rs:2199:87 [INFO] [stdout] | [INFO] [stdout] 2199 | DiGraph::<_, _>::from_elements(elements.iter().cloned().filter_elements(|elt| match elt { [INFO] [stdout] | _______________________________________________________________________________________^ [INFO] [stdout] 2200 | | Node { ref weight } if **weight == "B" => false, [INFO] [stdout] 2201 | | _ => true, [INFO] [stdout] 2202 | | })); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 2199 - DiGraph::<_, _>::from_elements(elements.iter().cloned().filter_elements(|elt| match elt { [INFO] [stdout] 2200 - Node { ref weight } if **weight == "B" => false, [INFO] [stdout] 2201 - _ => true, [INFO] [stdout] 2202 - })); [INFO] [stdout] 2199 + DiGraph::<_, _>::from_elements(elements.iter().cloned().filter_elements(|elt| !matches!(elt, Node { ref weight } if **weight == "B"))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> tests/graph.rs:2219:43 [INFO] [stdout] | [INFO] [stdout] 2219 | let gr = UnGraph::<(), _>::from_edges(&[ [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 2220 | | // cycle [INFO] [stdout] 2221 | | (0, 1, 7), [INFO] [stdout] 2222 | | (1, 2, 9), [INFO] [stdout] ... | [INFO] [stdout] 2231 | | (2, 5, -3), [INFO] [stdout] 2232 | | ]); [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 2219 ~ let gr = UnGraph::<(), _>::from_edges([ [INFO] [stdout] 2220 + // cycle [INFO] [stdout] 2221 + (0, 1, 7), [INFO] [stdout] 2222 + (1, 2, 9), [INFO] [stdout] 2223 + (2, 1, 14), [INFO] [stdout] 2224 + // cycle [INFO] [stdout] 2225 + (3, 4, 10), [INFO] [stdout] 2226 + (4, 5, 2), [INFO] [stdout] 2227 + (5, 3, 9), [INFO] [stdout] 2228 + // cross edges [INFO] [stdout] 2229 + (0, 3, -1), [INFO] [stdout] 2230 + (1, 4, -2), [INFO] [stdout] 2231 + (2, 5, -3), [INFO] [stdout] 2232 ~ ]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> tests/graph.rs:2242:15 [INFO] [stdout] | [INFO] [stdout] 2242 | while let Some(_) = dfs.next(&positive_edges) {} [INFO] [stdout] | ----------^^^^^^^---------------------------- help: try: `while dfs.next(&positive_edges).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.42s [INFO] running `Command { std: "docker" "inspect" "7b885fb67e42ad0c55b6fa8c3a2ed6af83623b4547f5b8df8e5a39a0647b3784", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b885fb67e42ad0c55b6fa8c3a2ed6af83623b4547f5b8df8e5a39a0647b3784", kill_on_drop: false }` [INFO] [stdout] 7b885fb67e42ad0c55b6fa8c3a2ed6af83623b4547f5b8df8e5a39a0647b3784