[INFO] fetching crate titta 0.1.34...
[INFO] linting titta-0.1.34 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate titta 0.1.34 into /workspace/builds/worker-1-tc1/source
[INFO] started tweaking crates.io crate titta 0.1.34
[INFO] finished tweaking crates.io crate titta 0.1.34
[INFO] tweaked toml for crates.io crate titta 0.1.34 written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate titta 0.1.34 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate crates.io crate titta 0.1.34 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3cad523785232dd3df563d03ccc7233f18ac6803dcdf263b119e8ef0ef619324
[INFO] running `Command { std: "docker" "start" "-a" "3cad523785232dd3df563d03ccc7233f18ac6803dcdf263b119e8ef0ef619324", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3cad523785232dd3df563d03ccc7233f18ac6803dcdf263b119e8ef0ef619324", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3cad523785232dd3df563d03ccc7233f18ac6803dcdf263b119e8ef0ef619324", kill_on_drop: false }`
[INFO] [stdout] 3cad523785232dd3df563d03ccc7233f18ac6803dcdf263b119e8ef0ef619324
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 6fdcdb5bef0563eaa6c0eaf3088bd779047f998d16ee7f5385442328e72c8bb7
[INFO] running `Command { std: "docker" "start" "-a" "6fdcdb5bef0563eaa6c0eaf3088bd779047f998d16ee7f5385442328e72c8bb7", kill_on_drop: false }`
[INFO] [stderr]     Checking titta v0.1.34 (/opt/rustwide/workdir)
[INFO] [stdout] warning: constant `APP_REPO` is never used
[INFO] [stdout]  --> src/constants.rs:7:11
[INFO] [stdout]   |
[INFO] [stdout] 7 | pub const APP_REPO: &str = env!("CARGO_PKG_REPOSITORY");
[INFO] [stdout]   |           ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constant `APP_REPO` is never used
[INFO] [stdout]  --> src/constants.rs:7:11
[INFO] [stdout]   |
[INFO] [stdout] 7 | pub const APP_REPO: &str = env!("CARGO_PKG_REPOSITORY");
[INFO] [stdout]   |           ^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:136:9
[INFO] [stdout]     |
[INFO] [stdout] 136 |         return metadata.is_file() && permissions.mode() & 0o111 != 0;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 136 -         return metadata.is_file() && permissions.mode() & 0o111 != 0;
[INFO] [stdout] 136 +         metadata.is_file() && permissions.mode() & 0o111 != 0
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:189:16
[INFO] [stdout]     |
[INFO] [stdout] 189 |             if !(f_type == "") {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^ help: try: `(f_type != "")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/main.rs:141:9
[INFO] [stdout]     |
[INFO] [stdout] 141 |         let dir: PathBuf;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `dir` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 141 ~         
[INFO] [stdout] 142 ~         let dir: PathBuf = if self.use_opt_dir {
[INFO] [stdout] 143 ~             self.opt_dir.clone()
[INFO] [stdout] 144 |         } else {
[INFO] [stdout] 145 ~             self.current_dir.clone()
[INFO] [stdout] 146 ~         };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/main.rs:152:13
[INFO] [stdout]     |
[INFO] [stdout] 152 |             let f_type: String;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `f_type` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 152 ~             
[INFO] [stdout] 153 |
[INFO] [stdout] 154 ~             let f_type: String = if opath.as_mut().unwrap().path().is_dir() {
[INFO] [stdout] 155 ~                 "dir".to_string()
[INFO] [stdout] 156 |             } else {
[INFO] [stdout] 157 ~                 opath
[INFO] [stdout] 158 |                     .as_mut()
[INFO] [stdout] ...
[INFO] [stdout] 163 |                     .unwrap_or("")
[INFO] [stdout] 164 ~                     .to_string()
[INFO] [stdout] 165 ~             };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/main.rs:189:18
[INFO] [stdout]     |
[INFO] [stdout] 189 |             if !(f_type == "") {
[INFO] [stdout]     |                  ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `f_type.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]     = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:217:13
[INFO] [stdout]     |
[INFO] [stdout] 217 | /             if self.f_show_hidden == false {
[INFO] [stdout] 218 | |                 if is_hidden == true {
[INFO] [stdout] 219 | |                     continue;
[INFO] [stdout] 220 | |                 }
[INFO] [stdout] 221 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 217 ~             if self.f_show_hidden == false
[INFO] [stdout] 218 ~                 && is_hidden == true {
[INFO] [stdout] 219 |                     continue;
[INFO] [stdout] 220 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]    --> src/main.rs:217:16
[INFO] [stdout]     |
[INFO] [stdout] 217 |             if self.f_show_hidden == false {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.f_show_hidden`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]    --> src/main.rs:218:20
[INFO] [stdout]     |
[INFO] [stdout] 218 |                 if is_hidden == true {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^ help: try: `is_hidden`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:136:9
[INFO] [stdout]     |
[INFO] [stdout] 136 |         return metadata.is_file() && permissions.mode() & 0o111 != 0;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 136 -         return metadata.is_file() && permissions.mode() & 0o111 != 0;
[INFO] [stdout] 136 +         metadata.is_file() && permissions.mode() & 0o111 != 0
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:189:16
[INFO] [stdout]     |
[INFO] [stdout] 189 |             if !(f_type == "") {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^ help: try: `(f_type != "")`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/main.rs:141:9
[INFO] [stdout]     |
[INFO] [stdout] 141 |         let dir: PathBuf;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout]     = note: `#[warn(clippy::needless_late_init)]` on by default
[INFO] [stdout] help: move the declaration `dir` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 141 ~         
[INFO] [stdout] 142 ~         let dir: PathBuf = if self.use_opt_dir {
[INFO] [stdout] 143 ~             self.opt_dir.clone()
[INFO] [stdout] 144 |         } else {
[INFO] [stdout] 145 ~             self.current_dir.clone()
[INFO] [stdout] 146 ~         };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded late initialization
[INFO] [stdout]    --> src/main.rs:152:13
[INFO] [stdout]     |
[INFO] [stdout] 152 |             let f_type: String;
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
[INFO] [stdout] help: move the declaration `f_type` here and remove the assignments from the branches
[INFO] [stdout]     |
[INFO] [stdout] 152 ~             
[INFO] [stdout] 153 |
[INFO] [stdout] 154 ~             let f_type: String = if opath.as_mut().unwrap().path().is_dir() {
[INFO] [stdout] 155 ~                 "dir".to_string()
[INFO] [stdout] 156 |             } else {
[INFO] [stdout] 157 ~                 opath
[INFO] [stdout] 158 |                     .as_mut()
[INFO] [stdout] ...
[INFO] [stdout] 163 |                     .unwrap_or("")
[INFO] [stdout] 164 ~                     .to_string()
[INFO] [stdout] 165 ~             };
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]    --> src/main.rs:189:18
[INFO] [stdout]     |
[INFO] [stdout] 189 |             if !(f_type == "") {
[INFO] [stdout]     |                  ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `f_type.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]     = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/main.rs:217:13
[INFO] [stdout]     |
[INFO] [stdout] 217 | /             if self.f_show_hidden == false {
[INFO] [stdout] 218 | |                 if is_hidden == true {
[INFO] [stdout] 219 | |                     continue;
[INFO] [stdout] 220 | |                 }
[INFO] [stdout] 221 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 217 ~             if self.f_show_hidden == false
[INFO] [stdout] 218 ~                 && is_hidden == true {
[INFO] [stdout] 219 |                     continue;
[INFO] [stdout] 220 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]    --> src/main.rs:217:16
[INFO] [stdout]     |
[INFO] [stdout] 217 |             if self.f_show_hidden == false {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.f_show_hidden`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against true are unnecessary
[INFO] [stdout]    --> src/main.rs:218:20
[INFO] [stdout]     |
[INFO] [stdout] 218 |                 if is_hidden == true {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^ help: try: `is_hidden`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s
[INFO] running `Command { std: "docker" "inspect" "6fdcdb5bef0563eaa6c0eaf3088bd779047f998d16ee7f5385442328e72c8bb7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6fdcdb5bef0563eaa6c0eaf3088bd779047f998d16ee7f5385442328e72c8bb7", kill_on_drop: false }`
[INFO] [stdout] 6fdcdb5bef0563eaa6c0eaf3088bd779047f998d16ee7f5385442328e72c8bb7