[INFO] fetching crate timeforrust 0.1.0... [INFO] linting timeforrust-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate timeforrust 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate timeforrust 0.1.0 [INFO] finished tweaking crates.io crate timeforrust 0.1.0 [INFO] tweaked toml for crates.io crate timeforrust 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate timeforrust 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate timeforrust 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec4463df3569460f5c4cfd55bf5f63921c511a8b411142542d87359bc5be2884 [INFO] running `Command { std: "docker" "start" "-a" "ec4463df3569460f5c4cfd55bf5f63921c511a8b411142542d87359bc5be2884", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec4463df3569460f5c4cfd55bf5f63921c511a8b411142542d87359bc5be2884", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec4463df3569460f5c4cfd55bf5f63921c511a8b411142542d87359bc5be2884", kill_on_drop: false }` [INFO] [stdout] ec4463df3569460f5c4cfd55bf5f63921c511a8b411142542d87359bc5be2884 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b9d6aa302b0b71393bd2ca7e25d922d3757c871a8408eb993036f17a3468136 [INFO] running `Command { std: "docker" "start" "-a" "2b9d6aa302b0b71393bd2ca7e25d922d3757c871a8408eb993036f17a3468136", kill_on_drop: false }` [INFO] [stderr] Checking timeforrust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | timers: Arc<(Mutex>, Condvar)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u64, Duration, fn(u64))` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:62:54 [INFO] [stdout] | [INFO] [stdout] 62 | Some((&t, v)) if t <= now => (t, v.clone()), [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | / if result.is_err() { [INFO] [stdout] 79 | | if let Some(handler) = errors { [INFO] [stdout] 80 | | handler(&TimerPanic); [INFO] [stdout] 81 | | } [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 78 ~ if result.is_err() [INFO] [stdout] 79 ~ && let Some(handler) = errors { [INFO] [stdout] 80 | handler(&TimerPanic); [INFO] [stdout] 81 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | timers: Arc<(Mutex>, Condvar)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u64, Duration, fn(u64))` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:62:54 [INFO] [stdout] | [INFO] [stdout] 62 | Some((&t, v)) if t <= now => (t, v.clone()), [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | / if result.is_err() { [INFO] [stdout] 79 | | if let Some(handler) = errors { [INFO] [stdout] 80 | | handler(&TimerPanic); [INFO] [stdout] 81 | | } [INFO] [stdout] 82 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 78 ~ if result.is_err() [INFO] [stdout] 79 ~ && let Some(handler) = errors { [INFO] [stdout] 80 | handler(&TimerPanic); [INFO] [stdout] 81 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:198:17 [INFO] [stdout] | [INFO] [stdout] 198 | assert!(timer.stop.load(std::sync::atomic::Ordering::Relaxed) == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!timer.stop.load(std::sync::atomic::Ordering::Relaxed)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:219:17 [INFO] [stdout] | [INFO] [stdout] 219 | assert!(!timer.thread.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `timer.thread.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:223:17 [INFO] [stdout] | [INFO] [stdout] 223 | assert!(timer.len() == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `timer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.17s [INFO] running `Command { std: "docker" "inspect" "2b9d6aa302b0b71393bd2ca7e25d922d3757c871a8408eb993036f17a3468136", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b9d6aa302b0b71393bd2ca7e25d922d3757c871a8408eb993036f17a3468136", kill_on_drop: false }` [INFO] [stdout] 2b9d6aa302b0b71393bd2ca7e25d922d3757c871a8408eb993036f17a3468136