[INFO] fetching crate tiefdownlib 0.10.0... [INFO] linting tiefdownlib-0.10.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tiefdownlib 0.10.0 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate tiefdownlib 0.10.0 [INFO] finished tweaking crates.io crate tiefdownlib 0.10.0 [INFO] tweaked toml for crates.io crate tiefdownlib 0.10.0 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tiefdownlib 0.10.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate tiefdownlib 0.10.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b395f6120779fffc30c40b0285812e9cd4e1c457405cd1ba2ccae5d3a3cc4024 [INFO] running `Command { std: "docker" "start" "-a" "b395f6120779fffc30c40b0285812e9cd4e1c457405cd1ba2ccae5d3a3cc4024", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b395f6120779fffc30c40b0285812e9cd4e1c457405cd1ba2ccae5d3a3cc4024", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b395f6120779fffc30c40b0285812e9cd4e1c457405cd1ba2ccae5d3a3cc4024", kill_on_drop: false }` [INFO] [stdout] b395f6120779fffc30c40b0285812e9cd4e1c457405cd1ba2ccae5d3a3cc4024 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 94548334b546ca25fca5f3aa6f22cd49132b03d8d8eb7b88c963421154214dc9 [INFO] running `Command { std: "docker" "start" "-a" "94548334b546ca25fca5f3aa6f22cd49132b03d8d8eb7b88c963421154214dc9", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.26 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling iana-time-zone v0.1.63 [INFO] [stderr] Compiling winnow v0.7.10 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Checking jiff v0.2.14 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking colored v2.2.0 [INFO] [stderr] Checking backtrace v0.3.75 [INFO] [stderr] Checking eyre v0.6.12 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Compiling glob v0.3.2 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking fast-glob v1.0.0 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking color-eyre v0.6.5 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Compiling rstest_macros v0.25.0 [INFO] [stderr] Compiling tiefdownlib v0.10.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling toml_edit v0.22.27 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking colog v1.3.0 [INFO] [stderr] Checking assert_cmd v2.0.17 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking h2 v0.4.10 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking rstest v0.25.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking hyper-util v0.1.14 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.19 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/markdown_project_management.rs:305:1 [INFO] [stdout] | [INFO] [stdout] 305 | / /// A Result containing either an error or a Vec of MarkdownProject. [INFO] [stdout] 306 | | [INFO] [stdout] | |_^ [INFO] [stdout] 307 | pub fn get_markdown_projects(project: Option) -> Result> { [INFO] [stdout] | ---------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/markdown_project_management.rs:305:1 [INFO] [stdout] | [INFO] [stdout] 305 | / /// A Result containing either an error or a Vec of MarkdownProject. [INFO] [stdout] 306 | | [INFO] [stdout] | |_^ [INFO] [stdout] 307 | pub fn get_markdown_projects(project: Option) -> Result> { [INFO] [stdout] | ---------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/conversion.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | &conversion_input_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `conversion_input_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/conversion.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | &conversion_input_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `conversion_input_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/conversion.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 242 | markdown_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 242 - markdown_dir: &PathBuf, [INFO] [stdout] 242 + markdown_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/conversion.rs:267:17 [INFO] [stdout] | [INFO] [stdout] 267 | / &markdown_project_compiled_directory_path [INFO] [stdout] 268 | | .join(resource.file_name().unwrap_or(std::ffi::OsStr::new("."))), [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 267 ~ markdown_project_compiled_directory_path [INFO] [stdout] 268 ~ .join(resource.file_name().unwrap_or(std::ffi::OsStr::new("."))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/conversion.rs:301:45 [INFO] [stdout] | [INFO] [stdout] 301 | let resolved: Vec = available_profiles[profile_pos] [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 302 | | .templates [INFO] [stdout] 303 | | .iter() [INFO] [stdout] 304 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 301 ~ let resolved: Vec = available_profiles[profile_pos] [INFO] [stdout] 302 + .templates [INFO] [stdout] 303 + .iter().cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/conversion.rs:389:1 [INFO] [stdout] | [INFO] [stdout] 389 | / fn convert_template( [INFO] [stdout] 390 | | compiled_directory_path: &Path, [INFO] [stdout] 391 | | template: &Template, [INFO] [stdout] 392 | | project_path: &Path, [INFO] [stdout] ... | [INFO] [stdout] 398 | | injections: &Vec, [INFO] [stdout] 399 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/converters/common.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | custom_preprocessors: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - custom_preprocessors: &Vec, [INFO] [stdout] 26 + custom_preprocessors: &[PreProcessor], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/converters/common.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | let selected = preprocessors [INFO] [stdout] | ____________________^ [INFO] [stdout] 29 | | .clone() [INFO] [stdout] 30 | | .and_then(|p| Some(p.preprocessors.clone())) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 ~ let selected = preprocessors [INFO] [stdout] 29 + .clone().map(|p| p.preprocessors.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/converters/common.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 73 | let from_template = template [INFO] [stdout] | _________________________^ [INFO] [stdout] 74 | | .preprocessors [INFO] [stdout] 75 | | .clone() [INFO] [stdout] 76 | | .and_then(|p| Some(p.combined_output)); [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 ~ let from_template = template [INFO] [stdout] 74 + .preprocessors [INFO] [stdout] 75 ~ .clone().map(|p| p.combined_output); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/converters/common.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | let from_defaults = default_processors [INFO] [stdout] | _________________________^ [INFO] [stdout] 78 | | .as_ref() [INFO] [stdout] 79 | | .and_then(|p| Some(p.clone().combined_output)); [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ let from_defaults = default_processors [INFO] [stdout] 78 ~ .as_ref().map(|p| p.clone().combined_output); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/common.rs:87:1 [INFO] [stdout] | [INFO] [stdout] 87 | / pub(crate) fn run_preprocessors_on_inputs( [INFO] [stdout] 88 | | template: &Template, [INFO] [stdout] 89 | | project_directory_path: &Path, [INFO] [stdout] 90 | | compiled_directory_path: &Path, [INFO] [stdout] ... | [INFO] [stdout] 95 | | injections: &Vec, [INFO] [stdout] 96 | | ) -> Result> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/converters/common.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | preprocessors: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 94 - preprocessors: &Vec, [INFO] [stdout] 94 + preprocessors: &[PreProcessor], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/converters/common.rs:127:72 [INFO] [stdout] | [INFO] [stdout] 127 | let cli_args = preprocess_cli_args(&preprocessor.cli_args, &metadata_fields); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `metadata_fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::process::CommandArgs<'_>` [INFO] [stdout] --> src/converters/common.rs:147:17 [INFO] [stdout] | [INFO] [stdout] 147 | / cli.get_args() [INFO] [stdout] 148 | | .into_iter() [INFO] [stdout] | |________________________________^ help: consider removing `.into_iter()`: `cli.get_args()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/converters/common.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | / if !current_chunk.is_empty() { [INFO] [stdout] 194 | | if let Some(ext) = &chunk_extension { [INFO] [stdout] 195 | | chunks.push((current_chunk, ext.to_string_lossy().to_string())); [INFO] [stdout] 196 | | } [INFO] [stdout] 197 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 193 ~ if !current_chunk.is_empty() [INFO] [stdout] 194 ~ && let Some(ext) = &chunk_extension { [INFO] [stdout] 195 | chunks.push((current_chunk, ext.to_string_lossy().to_string())); [INFO] [stdout] 196 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/converters/common.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/converters/common.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/converters/common.rs:332:9 [INFO] [stdout] | [INFO] [stdout] 332 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/converters/common.rs:346:17 [INFO] [stdout] | [INFO] [stdout] 346 | injections: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 346 - injections: &Vec, [INFO] [stdout] 346 + injections: &[Injection], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converters/common.rs:417:17 [INFO] [stdout] | [INFO] [stdout] 417 | return Ok(vec![f.clone()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 417 - return Ok(vec![f.clone()]); [INFO] [stdout] 417 + Ok(vec![f.clone()]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/converters/common.rs:467:23 [INFO] [stdout] | [INFO] [stdout] 467 | .and_then(|n| match n.parse::() { [INFO] [stdout] | _______________________^ [INFO] [stdout] 468 | | Result::Ok(n) => Some(n), [INFO] [stdout] 469 | | Err(_e) => None, [INFO] [stdout] 470 | | }) [INFO] [stdout] | |_________^ help: replace with: `n.parse::().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/converters/common.rs:481:14 [INFO] [stdout] | [INFO] [stdout] 481 | results: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 481 - results: &Vec, [INFO] [stdout] 481 + results: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/converters/common.rs:489:38 [INFO] [stdout] | [INFO] [stdout] 489 | compiled_directory_path.join(&combined_output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `combined_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converters/common.rs:559:9 [INFO] [stdout] | [INFO] [stdout] 559 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 559 - return content; [INFO] [stdout] 559 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/custom_preprocessor_converter.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub(crate) fn convert_custom_preprocessors( [INFO] [stdout] 17 | | project_directory_path: &Path, [INFO] [stdout] 18 | | compiled_directory_path: &Path, [INFO] [stdout] 19 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 24 | | injections: &Vec, [INFO] [stdout] 25 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/converters/custom_preprocessor_converter.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if template.processor != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `template.processor.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/custom_processor_converter.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / pub(crate) fn convert_custom_processor( [INFO] [stdout] 20 | | project_directory_path: &Path, [INFO] [stdout] 21 | | compiled_directory_path: &Path, [INFO] [stdout] 22 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 27 | | injections: &Vec, [INFO] [stdout] 28 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/epub_converter.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / pub(crate) fn convert_epub( [INFO] [stdout] 23 | | project_directory_path: &Path, [INFO] [stdout] 24 | | compiled_directory_path: &Path, [INFO] [stdout] 25 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 30 | | injections: &Vec, [INFO] [stdout] 31 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> src/converters/epub_converter.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/tex_converter.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn convert_latex( [INFO] [stdout] 24 | | project_directory_path: &Path, [INFO] [stdout] 25 | | compiled_directory_path: &Path, [INFO] [stdout] 26 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 31 | | injections: &Vec, [INFO] [stdout] 32 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> src/converters/tex_converter.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/conversion.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | &conversion_input_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `conversion_input_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/conversion.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | &conversion_input_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `conversion_input_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/conversion.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 242 | markdown_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 242 - markdown_dir: &PathBuf, [INFO] [stdout] 242 + markdown_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/typst_converter.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / pub(crate) fn convert_typst( [INFO] [stdout] 24 | | project_directory_path: &Path, [INFO] [stdout] 25 | | compiled_directory_path: &Path, [INFO] [stdout] 26 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 31 | | injections: &Vec, [INFO] [stdout] 32 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> src/converters/typst_converter.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/conversion.rs:267:17 [INFO] [stdout] | [INFO] [stdout] 267 | / &markdown_project_compiled_directory_path [INFO] [stdout] 268 | | .join(resource.file_name().unwrap_or(std::ffi::OsStr::new("."))), [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 267 ~ markdown_project_compiled_directory_path [INFO] [stdout] 268 ~ .join(resource.file_name().unwrap_or(std::ffi::OsStr::new("."))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/conversion.rs:301:45 [INFO] [stdout] | [INFO] [stdout] 301 | let resolved: Vec = available_profiles[profile_pos] [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 302 | | .templates [INFO] [stdout] 303 | | .iter() [INFO] [stdout] 304 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 301 ~ let resolved: Vec = available_profiles[profile_pos] [INFO] [stdout] 302 + .templates [INFO] [stdout] 303 + .iter().cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/converters/typst_converter.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | metadata_file_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/converters/typst_converter.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | metadata_file_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/converters/typst_converter.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | metadata_file_content.push_str(")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/conversion.rs:389:1 [INFO] [stdout] | [INFO] [stdout] 389 | / fn convert_template( [INFO] [stdout] 390 | | compiled_directory_path: &Path, [INFO] [stdout] 391 | | template: &Template, [INFO] [stdout] 392 | | project_path: &Path, [INFO] [stdout] ... | [INFO] [stdout] 398 | | injections: &Vec, [INFO] [stdout] 399 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/converters/common.rs:26:27 [INFO] [stdout] | [INFO] [stdout] 26 | custom_preprocessors: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 26 - custom_preprocessors: &Vec, [INFO] [stdout] 26 + custom_preprocessors: &[PreProcessor], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/converters/common.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | let selected = preprocessors [INFO] [stdout] | ____________________^ [INFO] [stdout] 29 | | .clone() [INFO] [stdout] 30 | | .and_then(|p| Some(p.preprocessors.clone())) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 28 ~ let selected = preprocessors [INFO] [stdout] 29 + .clone().map(|p| p.preprocessors.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/converters/common.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 73 | let from_template = template [INFO] [stdout] | _________________________^ [INFO] [stdout] 74 | | .preprocessors [INFO] [stdout] 75 | | .clone() [INFO] [stdout] 76 | | .and_then(|p| Some(p.combined_output)); [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 73 ~ let from_template = template [INFO] [stdout] 74 + .preprocessors [INFO] [stdout] 75 ~ .clone().map(|p| p.combined_output); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/converters/common.rs:77:25 [INFO] [stdout] | [INFO] [stdout] 77 | let from_defaults = default_processors [INFO] [stdout] | _________________________^ [INFO] [stdout] 78 | | .as_ref() [INFO] [stdout] 79 | | .and_then(|p| Some(p.clone().combined_output)); [INFO] [stdout] | |______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ let from_defaults = default_processors [INFO] [stdout] 78 ~ .as_ref().map(|p| p.clone().combined_output); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/common.rs:87:1 [INFO] [stdout] | [INFO] [stdout] 87 | / pub(crate) fn run_preprocessors_on_inputs( [INFO] [stdout] 88 | | template: &Template, [INFO] [stdout] 89 | | project_directory_path: &Path, [INFO] [stdout] 90 | | compiled_directory_path: &Path, [INFO] [stdout] ... | [INFO] [stdout] 95 | | injections: &Vec, [INFO] [stdout] 96 | | ) -> Result> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/converters/common.rs:94:20 [INFO] [stdout] | [INFO] [stdout] 94 | preprocessors: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 94 - preprocessors: &Vec, [INFO] [stdout] 94 + preprocessors: &[PreProcessor], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/converters/common.rs:127:72 [INFO] [stdout] | [INFO] [stdout] 127 | let cli_args = preprocess_cli_args(&preprocessor.cli_args, &metadata_fields); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `metadata_fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::process::CommandArgs<'_>` [INFO] [stdout] --> src/converters/common.rs:147:17 [INFO] [stdout] | [INFO] [stdout] 147 | / cli.get_args() [INFO] [stdout] 148 | | .into_iter() [INFO] [stdout] | |________________________________^ help: consider removing `.into_iter()`: `cli.get_args()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/converters/common.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | / if !current_chunk.is_empty() { [INFO] [stdout] 194 | | if let Some(ext) = &chunk_extension { [INFO] [stdout] 195 | | chunks.push((current_chunk, ext.to_string_lossy().to_string())); [INFO] [stdout] 196 | | } [INFO] [stdout] 197 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 193 ~ if !current_chunk.is_empty() [INFO] [stdout] 194 ~ && let Some(ext) = &chunk_extension { [INFO] [stdout] 195 | chunks.push((current_chunk, ext.to_string_lossy().to_string())); [INFO] [stdout] 196 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/converters/common.rs:320:9 [INFO] [stdout] | [INFO] [stdout] 320 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/converters/common.rs:326:9 [INFO] [stdout] | [INFO] [stdout] 326 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/converters/common.rs:332:9 [INFO] [stdout] | [INFO] [stdout] 332 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/converters/common.rs:346:17 [INFO] [stdout] | [INFO] [stdout] 346 | injections: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 346 - injections: &Vec, [INFO] [stdout] 346 + injections: &[Injection], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converters/common.rs:417:17 [INFO] [stdout] | [INFO] [stdout] 417 | return Ok(vec![f.clone()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 417 - return Ok(vec![f.clone()]); [INFO] [stdout] 417 + Ok(vec![f.clone()]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/converters/common.rs:467:23 [INFO] [stdout] | [INFO] [stdout] 467 | .and_then(|n| match n.parse::() { [INFO] [stdout] | _______________________^ [INFO] [stdout] 468 | | Result::Ok(n) => Some(n), [INFO] [stdout] 469 | | Err(_e) => None, [INFO] [stdout] 470 | | }) [INFO] [stdout] | |_________^ help: replace with: `n.parse::().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/converters/common.rs:481:14 [INFO] [stdout] | [INFO] [stdout] 481 | results: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 481 - results: &Vec, [INFO] [stdout] 481 + results: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/converters/common.rs:489:38 [INFO] [stdout] | [INFO] [stdout] 489 | compiled_directory_path.join(&combined_output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `combined_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/converters/common.rs:559:9 [INFO] [stdout] | [INFO] [stdout] 559 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 559 - return content; [INFO] [stdout] 559 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/custom_preprocessor_converter.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | / pub(crate) fn convert_custom_preprocessors( [INFO] [stdout] 17 | | project_directory_path: &Path, [INFO] [stdout] 18 | | compiled_directory_path: &Path, [INFO] [stdout] 19 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 24 | | injections: &Vec, [INFO] [stdout] 25 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/converters/custom_preprocessor_converter.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | if template.processor != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `template.processor.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/manifest_model.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | / pub fn default() -> Self { [INFO] [stdout] 209 | | Self { [INFO] [stdout] 210 | | metadata_prefix: None, [INFO] [stdout] 211 | | } [INFO] [stdout] 212 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/custom_processor_converter.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | / pub(crate) fn convert_custom_processor( [INFO] [stdout] 20 | | project_directory_path: &Path, [INFO] [stdout] 21 | | compiled_directory_path: &Path, [INFO] [stdout] 22 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 27 | | injections: &Vec, [INFO] [stdout] 28 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/epub_converter.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / pub(crate) fn convert_epub( [INFO] [stdout] 23 | | project_directory_path: &Path, [INFO] [stdout] 24 | | compiled_directory_path: &Path, [INFO] [stdout] 25 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 30 | | injections: &Vec, [INFO] [stdout] 31 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> src/converters/epub_converter.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/tex_converter.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn convert_latex( [INFO] [stdout] 24 | | project_directory_path: &Path, [INFO] [stdout] 25 | | compiled_directory_path: &Path, [INFO] [stdout] 26 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 31 | | injections: &Vec, [INFO] [stdout] 32 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> src/converters/tex_converter.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/manifest_model.rs:385:38 [INFO] [stdout] | [INFO] [stdout] 385 | if metadata_fields.is_table() && metadata_fields.as_table().unwrap().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!metadata_fields.as_table().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/converters/typst_converter.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / pub(crate) fn convert_typst( [INFO] [stdout] 24 | | project_directory_path: &Path, [INFO] [stdout] 25 | | compiled_directory_path: &Path, [INFO] [stdout] 26 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 31 | | injections: &Vec, [INFO] [stdout] 32 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> src/converters/typst_converter.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/manifest_model.rs:421:5 [INFO] [stdout] | [INFO] [stdout] 421 | / if let Some(toml::Value::Table(custom)) = manifest.get_mut("custom_processors") { [INFO] [stdout] 422 | | if let Some(toml::Value::Array(preprocessors)) = custom.get_mut("preprocessors") { [INFO] [stdout] 423 | | for preproc in preprocessors { [INFO] [stdout] 424 | | if let toml::Value::Table(tbl) = preproc { [INFO] [stdout] ... | [INFO] [stdout] 463 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 421 ~ if let Some(toml::Value::Table(custom)) = manifest.get_mut("custom_processors") [INFO] [stdout] 422 ~ && let Some(toml::Value::Array(preprocessors)) = custom.get_mut("preprocessors") { [INFO] [stdout] 423 | for preproc in preprocessors { [INFO] [stdout] ... [INFO] [stdout] 461 | } [INFO] [stdout] 462 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/manifest_model.rs:468:17 [INFO] [stdout] | [INFO] [stdout] 468 | / if let Some(toml::Value::String(template_type)) = tbl.get_mut("template_type") { [INFO] [stdout] 469 | | if template_type == "CustomPandoc" { [INFO] [stdout] 470 | | *template_type = "CustomPreprocessors".to_string(); [INFO] [stdout] 471 | | } [INFO] [stdout] 472 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 468 ~ if let Some(toml::Value::String(template_type)) = tbl.get_mut("template_type") [INFO] [stdout] 469 ~ && template_type == "CustomPandoc" { [INFO] [stdout] 470 | *template_type = "CustomPreprocessors".to_string(); [INFO] [stdout] 471 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/converters/typst_converter.rs:142:5 [INFO] [stdout] | [INFO] [stdout] 142 | metadata_file_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/converters/typst_converter.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | metadata_file_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/converters/typst_converter.rs:156:5 [INFO] [stdout] | [INFO] [stdout] 156 | metadata_file_content.push_str(")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/project_management.rs:169:1 [INFO] [stdout] | [INFO] [stdout] 169 | / pub fn add_template( [INFO] [stdout] 170 | | project: Option, [INFO] [stdout] 171 | | template_name: String, [INFO] [stdout] 172 | | template_type: Option, [INFO] [stdout] ... | [INFO] [stdout] 181 | | footer_injections: Option>, [INFO] [stdout] 182 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `preprocessor_output` after checking its variant with `is_some` [INFO] [stdout] --> src/project_management.rs:216:44 [INFO] [stdout] | [INFO] [stdout] 213 | if preprocessor_output.is_some() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = preprocessor_output` [INFO] [stdout] ... [INFO] [stdout] 216 | combined_output: PathBuf::from(preprocessor_output.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/project_management.rs:216:30 [INFO] [stdout] | [INFO] [stdout] 216 | combined_output: PathBuf::from(preprocessor_output.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (16/7) [INFO] [stdout] --> src/project_management.rs:321:1 [INFO] [stdout] | [INFO] [stdout] 321 | / pub fn update_template( [INFO] [stdout] 322 | | project: Option, [INFO] [stdout] 323 | | template_name: String, [INFO] [stdout] 324 | | template_type: Option, [INFO] [stdout] ... | [INFO] [stdout] 337 | | footer_injections: Option>, [INFO] [stdout] 338 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> src/project_management.rs:355:58 [INFO] [stdout] | [INFO] [stdout] 355 | template.template_type = template_type.unwrap_or(template.template_type.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/project_management.rs:388:49 [INFO] [stdout] | [INFO] [stdout] 388 | preprocessors.combined_output = PathBuf::from(preprocessor_output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/project_management.rs:392:38 [INFO] [stdout] | [INFO] [stdout] 392 | combined_output: PathBuf::from(preprocessor_output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/manifest_model.rs:208:5 [INFO] [stdout] | [INFO] [stdout] 208 | / pub fn default() -> Self { [INFO] [stdout] 209 | | Self { [INFO] [stdout] 210 | | metadata_prefix: None, [INFO] [stdout] 211 | | } [INFO] [stdout] 212 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/project_management.rs:836:20 [INFO] [stdout] | [INFO] [stdout] 836 | && path [INFO] [stdout] | ____________________^ [INFO] [stdout] 837 | | .file_name() [INFO] [stdout] 838 | | .and_then(|name| name.to_str()) [INFO] [stdout] 839 | | .map_or(false, |name| regex.is_match(name)) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 839 - .map_or(false, |name| regex.is_match(name)) [INFO] [stdout] 839 + .is_some_and(|name| regex.is_match(name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> src/project_management.rs:843:5 [INFO] [stdout] | [INFO] [stdout] 843 | dirs_to_delete.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 843 - dirs_to_delete.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] 843 + dirs_to_delete.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/project_management.rs:890:12 [INFO] [stdout] | [INFO] [stdout] 890 | if !output.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `output.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `output` after checking its variant with `is_ok` [INFO] [stdout] --> src/project_management.rs:894:17 [INFO] [stdout] | [INFO] [stdout] 890 | if !output.is_ok() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 894 | output.unwrap_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template_management.rs:89:34 [INFO] [stdout] | [INFO] [stdout] 89 | create_lix_luafilter(&project_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template_management.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 157 | let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 157 - let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] 157 + let filename = file_url.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template_management.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 182 - let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] 182 + let filename = file_url.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/manifest_model.rs:385:38 [INFO] [stdout] | [INFO] [stdout] 385 | if metadata_fields.is_table() && metadata_fields.as_table().unwrap().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!metadata_fields.as_table().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/manifest_model.rs:421:5 [INFO] [stdout] | [INFO] [stdout] 421 | / if let Some(toml::Value::Table(custom)) = manifest.get_mut("custom_processors") { [INFO] [stdout] 422 | | if let Some(toml::Value::Array(preprocessors)) = custom.get_mut("preprocessors") { [INFO] [stdout] 423 | | for preproc in preprocessors { [INFO] [stdout] 424 | | if let toml::Value::Table(tbl) = preproc { [INFO] [stdout] ... | [INFO] [stdout] 463 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 421 ~ if let Some(toml::Value::Table(custom)) = manifest.get_mut("custom_processors") [INFO] [stdout] 422 ~ && let Some(toml::Value::Array(preprocessors)) = custom.get_mut("preprocessors") { [INFO] [stdout] 423 | for preproc in preprocessors { [INFO] [stdout] ... [INFO] [stdout] 461 | } [INFO] [stdout] 462 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/manifest_model.rs:468:17 [INFO] [stdout] | [INFO] [stdout] 468 | / if let Some(toml::Value::String(template_type)) = tbl.get_mut("template_type") { [INFO] [stdout] 469 | | if template_type == "CustomPandoc" { [INFO] [stdout] 470 | | *template_type = "CustomPreprocessors".to_string(); [INFO] [stdout] 471 | | } [INFO] [stdout] 472 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 468 ~ if let Some(toml::Value::String(template_type)) = tbl.get_mut("template_type") [INFO] [stdout] 469 ~ && template_type == "CustomPandoc" { [INFO] [stdout] 470 | *template_type = "CustomPreprocessors".to_string(); [INFO] [stdout] 471 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converters/epub_converter.rs:92:30 [INFO] [stdout] | [INFO] [stdout] 92 | let mut processor_args = vec!["-t", "epub3", "-f", "native"] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "epub3", "-f", "native"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/manifest_model.rs:147:27 [INFO] [stdout] | [INFO] [stdout] 147 | cli_args: vec!["-t", "latex"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "latex"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/manifest_model.rs:168:31 [INFO] [stdout] | [INFO] [stdout] 168 | cli_args: vec!["-t", "typst"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "typst"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/manifest_model.rs:191:27 [INFO] [stdout] | [INFO] [stdout] 191 | cli_args: vec!["-t", "native"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "native"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/project_management.rs:169:1 [INFO] [stdout] | [INFO] [stdout] 169 | / pub fn add_template( [INFO] [stdout] 170 | | project: Option, [INFO] [stdout] 171 | | template_name: String, [INFO] [stdout] 172 | | template_type: Option, [INFO] [stdout] ... | [INFO] [stdout] 181 | | footer_injections: Option>, [INFO] [stdout] 182 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `preprocessor_output` after checking its variant with `is_some` [INFO] [stdout] --> src/project_management.rs:216:44 [INFO] [stdout] | [INFO] [stdout] 213 | if preprocessor_output.is_some() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = preprocessor_output` [INFO] [stdout] ... [INFO] [stdout] 216 | combined_output: PathBuf::from(preprocessor_output.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/project_management.rs:216:30 [INFO] [stdout] | [INFO] [stdout] 216 | combined_output: PathBuf::from(preprocessor_output.unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (16/7) [INFO] [stdout] --> src/project_management.rs:321:1 [INFO] [stdout] | [INFO] [stdout] 321 | / pub fn update_template( [INFO] [stdout] 322 | | project: Option, [INFO] [stdout] 323 | | template_name: String, [INFO] [stdout] 324 | | template_type: Option, [INFO] [stdout] ... | [INFO] [stdout] 337 | | footer_injections: Option>, [INFO] [stdout] 338 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> src/project_management.rs:355:58 [INFO] [stdout] | [INFO] [stdout] 355 | template.template_type = template_type.unwrap_or(template.template_type.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/project_management.rs:388:49 [INFO] [stdout] | [INFO] [stdout] 388 | preprocessors.combined_output = PathBuf::from(preprocessor_output); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/project_management.rs:392:38 [INFO] [stdout] | [INFO] [stdout] 392 | combined_output: PathBuf::from(preprocessor_output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/project_management.rs:836:20 [INFO] [stdout] | [INFO] [stdout] 836 | && path [INFO] [stdout] | ____________________^ [INFO] [stdout] 837 | | .file_name() [INFO] [stdout] 838 | | .and_then(|name| name.to_str()) [INFO] [stdout] 839 | | .map_or(false, |name| regex.is_match(name)) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 839 - .map_or(false, |name| regex.is_match(name)) [INFO] [stdout] 839 + .is_some_and(|name| regex.is_match(name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> src/project_management.rs:843:5 [INFO] [stdout] | [INFO] [stdout] 843 | dirs_to_delete.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 843 - dirs_to_delete.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] 843 + dirs_to_delete.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/project_management.rs:890:12 [INFO] [stdout] | [INFO] [stdout] 890 | if !output.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `output.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `output` after checking its variant with `is_ok` [INFO] [stdout] --> src/project_management.rs:894:17 [INFO] [stdout] | [INFO] [stdout] 890 | if !output.is_ok() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 894 | output.unwrap_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/template_management.rs:89:34 [INFO] [stdout] | [INFO] [stdout] 89 | create_lix_luafilter(&project_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template_management.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 157 | let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 157 - let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] 157 + let filename = file_url.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template_management.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 182 | let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 182 - let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] 182 + let filename = file_url.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/converters/epub_converter.rs:92:30 [INFO] [stdout] | [INFO] [stdout] 92 | let mut processor_args = vec!["-t", "epub3", "-f", "native"] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "epub3", "-f", "native"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/manifest_model.rs:147:27 [INFO] [stdout] | [INFO] [stdout] 147 | cli_args: vec!["-t", "latex"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "latex"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/manifest_model.rs:168:31 [INFO] [stdout] | [INFO] [stdout] 168 | cli_args: vec!["-t", "typst"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "typst"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/manifest_model.rs:191:27 [INFO] [stdout] | [INFO] [stdout] 191 | cli_args: vec!["-t", "native"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "native"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.45s [INFO] running `Command { std: "docker" "inspect" "94548334b546ca25fca5f3aa6f22cd49132b03d8d8eb7b88c963421154214dc9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "94548334b546ca25fca5f3aa6f22cd49132b03d8d8eb7b88c963421154214dc9", kill_on_drop: false }` [INFO] [stdout] 94548334b546ca25fca5f3aa6f22cd49132b03d8d8eb7b88c963421154214dc9