[INFO] fetching crate thunk_simple 0.1.1... [INFO] linting thunk_simple-0.1.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate thunk_simple 0.1.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate thunk_simple 0.1.1 [INFO] finished tweaking crates.io crate thunk_simple 0.1.1 [INFO] tweaked toml for crates.io crate thunk_simple 0.1.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate thunk_simple 0.1.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 831e063017bd7c78025df64975cd0c50caba87abea499af54e7381cc667f3783 [INFO] running `Command { std: "docker" "start" "-a" "831e063017bd7c78025df64975cd0c50caba87abea499af54e7381cc667f3783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "831e063017bd7c78025df64975cd0c50caba87abea499af54e7381cc667f3783", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "831e063017bd7c78025df64975cd0c50caba87abea499af54e7381cc667f3783", kill_on_drop: false }` [INFO] [stdout] 831e063017bd7c78025df64975cd0c50caba87abea499af54e7381cc667f3783 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 29a35fe0f4198230280bf2efe1fbdc3591ba4d8e77680cd0b9f4837f25e0f4f9 [INFO] running `Command { std: "docker" "start" "-a" "29a35fe0f4198230280bf2efe1fbdc3591ba4d8e77680cd0b9f4837f25e0f4f9", kill_on_drop: false }` [INFO] [stderr] Checking thunk_simple v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / if let Some(thunk) = std::mem::take(&mut self.0) { [INFO] [stdout] 76 | | Some(thunk.unwrap()) [INFO] [stdout] 77 | | } else { [INFO] [stdout] 78 | | None [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ help: try: `std::mem::take(&mut self.0).map(|thunk| thunk.unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/lib.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | / if let Some(thunk) = std::mem::take(&mut self.0) { [INFO] [stdout] 76 | | Some(thunk.unwrap()) [INFO] [stdout] 77 | | } else { [INFO] [stdout] 78 | | None [INFO] [stdout] 79 | | } [INFO] [stdout] | |_________^ help: try: `std::mem::take(&mut self.0).map(|thunk| thunk.unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> benches/benches.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | / test::black_box((0..1000).fold(Thunk::<'_,()>::new_const(()),|prev_thunk: Thunk<()>,_| [INFO] [stdout] 18 | | prev_thunk.map(|prev_val| prev_val)) [INFO] [stdout] 19 | | .unwrap()) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 17 ~ let _: () = (0..1000).fold(Thunk::<'_,()>::new_const(()),|prev_thunk: Thunk<()>,_| [INFO] [stdout] 18 + prev_thunk.map(|prev_val| prev_val)) [INFO] [stdout] 19 + .unwrap(); [INFO] [stdout] 20 + test::black_box(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | assert_eq!(*external_state.borrow(),true,"Thunk modified external state before its unwrapping"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 16 - assert_eq!(*external_state.borrow(),true,"Thunk modified external state before its unwrapping"); [INFO] [stdout] 16 + assert!(*external_state.borrow(),"Thunk modified external state before its unwrapping"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | assert_eq!(*external_state.borrow(),false,"Thunk didn't modify state after its unwrapping"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 18 - assert_eq!(*external_state.borrow(),false,"Thunk didn't modify state after its unwrapping"); [INFO] [stdout] 18 + assert!(!(*external_state.borrow()),"Thunk didn't modify state after its unwrapping"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | assert_eq!(Thunk::<'_,bool>::new_const(true).unwrap(),true,"Thunk returned wrong value"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 23 - assert_eq!(Thunk::<'_,bool>::new_const(true).unwrap(),true,"Thunk returned wrong value"); [INFO] [stdout] 23 + assert!(Thunk::<'_,bool>::new_const(true).unwrap(),"Thunk returned wrong value"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | assert_eq!(thunk_dangerous.map(|v| v || false).unwrap(),false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 37 - assert_eq!(thunk_dangerous.map(|v| v || false).unwrap(),false); [INFO] [stdout] 37 + assert!(!thunk_dangerous.map(|v| v || false).unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/tests.rs:37:44 [INFO] [stdout] | [INFO] [stdout] 37 | assert_eq!(thunk_dangerous.map(|v| v || false).unwrap(),false); [INFO] [stdout] | ^^^^^^^^^^ help: try: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | assert_eq!(thunk_safe.unwrap(),false,"Thunk returned wrong value"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 48 - assert_eq!(thunk_safe.unwrap(),false,"Thunk returned wrong value"); [INFO] [stdout] 48 + assert!(!thunk_safe.unwrap(),"Thunk returned wrong value"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | ... assert_eq!(thunk_dangerous.map_lazy(|prev_val| prev_val.unwrap() || false).unwrap(),false); // Panics, because it unwraps prev... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 55 - assert_eq!(thunk_dangerous.map_lazy(|prev_val| prev_val.unwrap() || false).unwrap(),false); // Panics, because it unwraps previous thunk [INFO] [stdout] 55 + assert!(!thunk_dangerous.map_lazy(|prev_val| prev_val.unwrap() || false).unwrap()); // Panics, because it unwraps previous thunk [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> tests/tests.rs:55:56 [INFO] [stdout] | [INFO] [stdout] 55 | ... assert_eq!(thunk_dangerous.map_lazy(|prev_val| prev_val.unwrap() || false).unwrap(),false); // Panics, because it unwraps prev... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `prev_val.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:69:9 [INFO] [stdout] | [INFO] [stdout] 69 | assert_eq!(thunk_now_safe.unwrap(),true,"Thunk did not return correct value"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 69 - assert_eq!(thunk_now_safe.unwrap(),true,"Thunk did not return correct value"); [INFO] [stdout] 69 + assert!(thunk_now_safe.unwrap(),"Thunk did not return correct value"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/tests.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 87 | assert_eq!(reformed_thunk.unwrap(),true,"Thunk returned wrong value"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 87 - assert_eq!(reformed_thunk.unwrap(),true,"Thunk returned wrong value"); [INFO] [stdout] 87 + assert!(reformed_thunk.unwrap(),"Thunk returned wrong value"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.33s [INFO] running `Command { std: "docker" "inspect" "29a35fe0f4198230280bf2efe1fbdc3591ba4d8e77680cd0b9f4837f25e0f4f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29a35fe0f4198230280bf2efe1fbdc3591ba4d8e77680cd0b9f4837f25e0f4f9", kill_on_drop: false }` [INFO] [stdout] 29a35fe0f4198230280bf2efe1fbdc3591ba4d8e77680cd0b9f4837f25e0f4f9