[INFO] fetching crate three-d 0.18.2... [INFO] linting three-d-0.18.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate three-d 0.18.2 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate three-d 0.18.2 [INFO] finished tweaking crates.io crate three-d 0.18.2 [INFO] tweaked toml for crates.io crate three-d 0.18.2 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate three-d 0.18.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate three-d 0.18.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fdeflate v0.3.6 [INFO] [stderr] Downloaded block-sys v0.1.0-beta.1 [INFO] [stderr] Downloaded ndk-macro v0.3.0 [INFO] [stderr] Downloaded wayland-egl v0.29.5 [INFO] [stderr] Downloaded thiserror v2.0.3 [INFO] [stderr] Downloaded osmesa-sys v0.1.2 [INFO] [stderr] Downloaded cty v0.2.2 [INFO] [stderr] Downloaded wayland-sys v0.29.5 [INFO] [stderr] Downloaded read-fonts v0.22.5 [INFO] [stderr] Downloaded ecolor v0.29.1 [INFO] [stderr] Downloaded glutin_glx_sys v0.1.8 [INFO] [stderr] Downloaded glutin_wgl_sys v0.1.5 [INFO] [stderr] Downloaded egui_glow v0.29.1 [INFO] [stderr] Downloaded glow v0.14.2 [INFO] [stderr] Downloaded epaint v0.29.1 [INFO] [stderr] Downloaded freetype-rs v0.26.0 [INFO] [stderr] Downloaded glutin v0.30.10 [INFO] [stderr] Downloaded servo-fontconfig-sys v5.1.0 [INFO] [stderr] Downloaded ndk-glue v0.7.0 [INFO] [stderr] Downloaded cocoa v0.25.0 [INFO] [stderr] Downloaded glutin_glx_sys v0.4.0 [INFO] [stderr] Downloaded hyper v1.5.1 [INFO] [stderr] Downloaded tiny-skia v0.7.0 [INFO] [stderr] Downloaded lyon_tessellation v1.0.15 [INFO] [stderr] Downloaded expat-sys v2.1.6 [INFO] [stderr] Downloaded skrifa v0.22.3 [INFO] [stderr] Downloaded freetype-sys v0.13.1 [INFO] [stderr] Downloaded sctk-adwaita v0.4.3 [INFO] [stderr] Downloaded egui v0.29.1 [INFO] [stderr] Downloaded data-url v0.3.1 [INFO] [stderr] Downloaded wayland-cursor v0.29.5 [INFO] [stderr] Downloaded flate2 v1.0.35 [INFO] [stderr] Downloaded tiny-skia v0.8.4 [INFO] [stderr] Downloaded serde v1.0.215 [INFO] [stderr] Downloaded open-enum-derive v0.5.2 [INFO] [stderr] Downloaded gltf-derive v1.4.1 [INFO] [stderr] Downloaded thiserror-impl v2.0.3 [INFO] [stderr] Downloaded cc v1.2.1 [INFO] [stderr] Downloaded core-graphics v0.22.3 [INFO] [stderr] Downloaded ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Downloaded sctk-adwaita v0.5.4 [INFO] [stderr] Downloaded wayland-commons v0.29.5 [INFO] [stderr] Downloaded xml-rs v0.8.23 [INFO] [stderr] Downloaded raw-window-handle v0.4.3 [INFO] [stderr] Downloaded servo-fontconfig v0.5.1 [INFO] [stderr] Downloaded tiny-skia-path v0.7.0 [INFO] [stderr] Downloaded gltf v1.4.1 [INFO] [stderr] Downloaded tiny-skia-path v0.8.4 [INFO] [stderr] Downloaded three-d-asset v0.9.0 [INFO] [stderr] Downloaded objc-sys v0.2.0-beta.2 [INFO] [stderr] Downloaded lyon_algorithms v1.0.4 [INFO] [stderr] Downloaded image v0.25.5 [INFO] [stderr] Downloaded raw-window-handle v0.5.2 [INFO] [stderr] Downloaded epaint_default_fonts v0.29.1 [INFO] [stderr] Downloaded ttf-parser v0.25.0 [INFO] [stderr] Downloaded owned_ttf_parser v0.25.0 [INFO] [stderr] Downloaded wayland-client v0.29.5 [INFO] [stderr] Downloaded lyon v1.0.1 [INFO] [stderr] Downloaded gltf-json v1.4.1 [INFO] [stderr] Downloaded pcd-rs v0.12.0 [INFO] [stderr] Downloaded openssl-sys v0.9.104 [INFO] [stderr] Downloaded zerocopy-derive v0.6.6 [INFO] [stderr] Downloaded serde_derive v1.0.215 [INFO] [stderr] Downloaded reqwest v0.12.9 [INFO] [stderr] Downloaded wavefront_obj v10.0.0 [INFO] [stderr] Downloaded objc2 v0.3.0-beta.3.patch-leaks.3 [INFO] [stderr] Downloaded cocoa-foundation v0.1.2 [INFO] [stderr] Downloaded cgl v0.3.2 [INFO] [stderr] Downloaded lyon_geom v1.0.6 [INFO] [stderr] Downloaded zeno v0.2.3 [INFO] [stderr] Downloaded openssl v0.10.68 [INFO] [stderr] Downloaded web-sys v0.3.72 [INFO] [stderr] Downloaded cocoa v0.24.1 [INFO] [stderr] Downloaded dwrote v0.11.2 [INFO] [stderr] Downloaded glutin_egl_sys v0.5.1 [INFO] [stderr] Downloaded lyon_path v1.0.6 [INFO] [stderr] Downloaded font-types v0.7.3 [INFO] [stderr] Downloaded zerocopy v0.6.6 [INFO] [stderr] Downloaded unzip-n v0.1.2 [INFO] [stderr] Downloaded ndk v0.7.0 [INFO] [stderr] Downloaded block2 v0.2.0-alpha.6 [INFO] [stderr] Downloaded bytemuck_derive v1.8.0 [INFO] [stderr] Downloaded winit v0.28.7 [INFO] [stderr] Downloaded emath v0.29.1 [INFO] [stderr] Downloaded glutin_egl_sys v0.1.6 [INFO] [stderr] Downloaded glutin_gles2_sys v0.1.5 [INFO] [stderr] Downloaded noise v0.6.0 [INFO] [stderr] Downloaded pcd-rs-derive v0.12.0 [INFO] [stderr] Downloaded ab_glyph v0.2.29 [INFO] [stderr] Downloaded wayland-protocols v0.29.5 [INFO] [stderr] Downloaded zune-jpeg v0.4.13 [INFO] [stderr] Downloaded wayland-scanner v0.29.5 [INFO] [stderr] Downloaded objc2-encode v2.0.0-pre.2 [INFO] [stderr] Downloaded bytemuck v1.20.0 [INFO] [stderr] Downloaded png v0.17.14 [INFO] [stderr] Downloaded calloop v0.10.6 [INFO] [stderr] Downloaded glutin_wgl_sys v0.4.0 [INFO] [stderr] Downloaded fastrand v2.2.0 [INFO] [stderr] Downloaded xcursor v0.3.8 [INFO] [stderr] Downloaded swash v0.1.19 [INFO] [stderr] Downloaded yazi v0.1.6 [INFO] [stderr] Downloaded smithay-client-toolkit v0.16.1 [INFO] [stderr] Downloaded cmake v0.1.52 [INFO] [stderr] Downloaded windows-registry v0.2.0 [INFO] [stderr] Downloaded glutin v0.29.1 [INFO] [stderr] Downloaded open-enum v0.5.2 [INFO] [stderr] Downloaded libc v0.2.166 [INFO] [stderr] Downloaded android-activity v0.4.3 [INFO] [stderr] Downloaded lexical v5.2.2 [INFO] [stderr] Downloaded wayland-sys v0.30.1 [INFO] [stderr] Downloaded crossfont v0.5.2 [INFO] [stderr] Downloaded rustix v0.38.41 [INFO] [stderr] Downloaded winit v0.27.5 [INFO] [stderr] Downloaded ndk-sys v0.4.1+23.1.7779620 [INFO] [stderr] Downloaded syn v2.0.89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0df00e995dc3acb26724d3db04bb54de4a5e92fbf707f2419d0206c4acfc575f [INFO] running `Command { std: "docker" "start" "-a" "0df00e995dc3acb26724d3db04bb54de4a5e92fbf707f2419d0206c4acfc575f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0df00e995dc3acb26724d3db04bb54de4a5e92fbf707f2419d0206c4acfc575f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0df00e995dc3acb26724d3db04bb54de4a5e92fbf707f2419d0206c4acfc575f", kill_on_drop: false }` [INFO] [stdout] 0df00e995dc3acb26724d3db04bb54de4a5e92fbf707f2419d0206c4acfc575f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 167d612797210ba03e60b141942568592ec9c2ba4175edfe3eb772599e84b71b [INFO] running `Command { std: "docker" "start" "-a" "167d612797210ba03e60b141942568592ec9c2ba4175edfe3eb772599e84b71b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling libc v0.2.166 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling xml-rs v0.8.23 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling cc v1.2.1 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking litemap v0.7.4 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Checking bytemuck v1.20.0 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling httparse v1.9.5 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking fdeflate v0.3.6 [INFO] [stderr] Compiling openssl v0.10.68 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Compiling syn v2.0.89 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking png v0.17.14 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Compiling openssl-sys v0.9.104 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Checking ttf-parser v0.25.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking zune-jpeg v0.4.13 [INFO] [stderr] Checking tiny-skia-path v0.8.4 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling glutin_egl_sys v0.5.1 [INFO] [stderr] Compiling glutin_glx_sys v0.4.0 [INFO] [stderr] Compiling wayland-sys v0.30.1 [INFO] [stderr] Compiling thiserror v2.0.3 [INFO] [stderr] Checking rustls-pki-types v1.10.0 [INFO] [stderr] Compiling once_cell v1.20.2 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking owned_ttf_parser v0.25.0 [INFO] [stderr] Checking lexical v5.2.2 [INFO] [stderr] Checking tiny-skia v0.8.4 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Checking ab_glyph v0.2.29 [INFO] [stderr] Checking image v0.25.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling winit v0.28.7 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Compiling glutin v0.30.10 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Compiling unzip-n v0.1.2 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking wavefront_obj v10.0.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking data-url v0.3.1 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking glow v0.14.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking noise v0.6.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling gltf-derive v1.4.1 [INFO] [stderr] Compiling serde_derive v1.0.215 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v2.0.3 [INFO] [stderr] Compiling open-enum-derive v0.5.2 [INFO] [stderr] Compiling pcd-rs-derive v0.12.0 [INFO] [stderr] Checking tokio v1.41.1 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking open-enum v0.5.2 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking pcd-rs v0.12.0 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking gltf-json v1.4.1 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking hyper v1.5.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking gltf v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking reqwest v0.12.9 [INFO] [stderr] Checking three-d-asset v0.9.0 [INFO] [stderr] Checking sctk-adwaita v0.5.4 [INFO] [stderr] Checking three-d v0.18.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/core/buffer/element_buffer.rs:98:23 [INFO] [stdout] | [INFO] [stdout] 98 | self.count = (offset as u32 + indices.len() as u32).max(self.count); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | #![warn(clippy::all)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/core/buffer.rs:97:33 [INFO] [stdout] | [INFO] [stdout] 97 | self.attribute_count = (offset as u32 + data.len() as u32).max(self.attribute_count); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/texture/texture_cube_map.rs:483:17 [INFO] [stdout] | [INFO] [stdout] 483 | &fragment_shader_source, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `fragment_shader_source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `cpu_textures.get(0)` [INFO] [stdout] --> src/core/texture/texture2d_array.rs:27:27 [INFO] [stdout] | [INFO] [stdout] 27 | let cpu_texture = cpu_textures [INFO] [stdout] | ___________________________^ [INFO] [stdout] 28 | | .get(0) [INFO] [stdout] | |___________________^ help: try: `cpu_textures.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/core/buffer/element_buffer.rs:98:23 [INFO] [stdout] | [INFO] [stdout] 98 | self.count = (offset as u32 + indices.len() as u32).max(self.count); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | #![warn(clippy::all)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/core/render_states.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | / impl Default for Cull { [INFO] [stdout] 52 | | fn default() -> Self { [INFO] [stdout] 53 | | Self::None [INFO] [stdout] 54 | | } [INFO] [stdout] 55 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 40 + #[derive(Default)] [INFO] [stdout] 41 | pub enum Cull { [INFO] [stdout] 42 | /// Render both front- and backfacing triangles. [INFO] [stdout] 43 ~ #[default] [INFO] [stdout] 44 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/core/render_states.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | / impl Default for DepthTest { [INFO] [stdout] 77 | | fn default() -> Self { [INFO] [stdout] 78 | | Self::Less [INFO] [stdout] 79 | | } [INFO] [stdout] 80 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 65 + #[derive(Default)] [INFO] [stdout] 66 | pub enum DepthTest { [INFO] [stdout] 67 | Never, [INFO] [stdout] 68 ~ #[default] [INFO] [stdout] 69 ~ Less, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/core/render_states.rs:206:1 [INFO] [stdout] | [INFO] [stdout] 206 | / impl Default for Blend { [INFO] [stdout] 207 | | fn default() -> Self { [INFO] [stdout] 208 | | Self::Disabled [INFO] [stdout] 209 | | } [INFO] [stdout] 210 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 155 + #[derive(Default)] [INFO] [stdout] 156 | pub enum Blend { [INFO] [stdout] 157 | Enabled { [INFO] [stdout] ... [INFO] [stdout] 164 | }, [INFO] [stdout] 165 ~ #[default] [INFO] [stdout] 166 ~ Disabled, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/core/buffer.rs:97:33 [INFO] [stdout] | [INFO] [stdout] 97 | self.attribute_count = (offset as u32 + data.len() as u32).max(self.attribute_count); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/core/texture/texture_cube_map.rs:483:17 [INFO] [stdout] | [INFO] [stdout] 483 | &fragment_shader_source, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `fragment_shader_source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `cpu_textures.get(0)` [INFO] [stdout] --> src/core/texture/texture2d_array.rs:27:27 [INFO] [stdout] | [INFO] [stdout] 27 | let cpu_texture = cpu_textures [INFO] [stdout] | ___________________________^ [INFO] [stdout] 28 | | .get(0) [INFO] [stdout] | |___________________^ help: try: `cpu_textures.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `?Sized` bound is ignored because of a `Sized` requirement [INFO] [stdout] --> src/core/uniform.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | impl UniformDataType for &T {} [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: `T` cannot be unsized because of the bound [INFO] [stdout] --> src/core/uniform.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | impl UniformDataType for &T {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: ...because `UniformDataType` has the bound `DataType` [INFO] [stdout] = note: ...because `DataType` has the bound `Clone` [INFO] [stdout] = note: ...because `Clone` has the bound `Sized` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized [INFO] [stdout] = note: `#[warn(clippy::needless_maybe_sized)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: change the bounds that require `Sized`, or remove the `?Sized` bound [INFO] [stdout] | [INFO] [stdout] 28 - impl UniformDataType for &T {} [INFO] [stdout] 28 + impl UniformDataType for &T {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/core/render_states.rs:51:1 [INFO] [stdout] | [INFO] [stdout] 51 | / impl Default for Cull { [INFO] [stdout] 52 | | fn default() -> Self { [INFO] [stdout] 53 | | Self::None [INFO] [stdout] 54 | | } [INFO] [stdout] 55 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 40 + #[derive(Default)] [INFO] [stdout] 41 | pub enum Cull { [INFO] [stdout] 42 | /// Render both front- and backfacing triangles. [INFO] [stdout] 43 ~ #[default] [INFO] [stdout] 44 ~ None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/core/render_states.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | / impl Default for DepthTest { [INFO] [stdout] 77 | | fn default() -> Self { [INFO] [stdout] 78 | | Self::Less [INFO] [stdout] 79 | | } [INFO] [stdout] 80 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 65 + #[derive(Default)] [INFO] [stdout] 66 | pub enum DepthTest { [INFO] [stdout] 67 | Never, [INFO] [stdout] 68 ~ #[default] [INFO] [stdout] 69 ~ Less, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/core/render_states.rs:206:1 [INFO] [stdout] | [INFO] [stdout] 206 | / impl Default for Blend { [INFO] [stdout] 207 | | fn default() -> Self { [INFO] [stdout] 208 | | Self::Disabled [INFO] [stdout] 209 | | } [INFO] [stdout] 210 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 155 + #[derive(Default)] [INFO] [stdout] 156 | pub enum Blend { [INFO] [stdout] 157 | Enabled { [INFO] [stdout] ... [INFO] [stdout] 164 | }, [INFO] [stdout] 165 ~ #[default] [INFO] [stdout] 166 ~ Disabled, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/core/program.rs:503:13 [INFO] [stdout] | [INFO] [stdout] 503 | element_buffer.count() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `element_buffer.count()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/core/program.rs:563:13 [INFO] [stdout] | [INFO] [stdout] 563 | element_buffer.count() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `element_buffer.count()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `?Sized` bound is ignored because of a `Sized` requirement [INFO] [stdout] --> src/core/data_type.rs:232:20 [INFO] [stdout] | [INFO] [stdout] 232 | impl DataType for &T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: `T` cannot be unsized because of the bound [INFO] [stdout] --> src/core/data_type.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 232 | impl DataType for &T { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = note: ...because `DataType` has the bound `Clone` [INFO] [stdout] = note: ...because `Clone` has the bound `Sized` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized [INFO] [stdout] help: change the bounds that require `Sized`, or remove the `?Sized` bound [INFO] [stdout] | [INFO] [stdout] 232 - impl DataType for &T { [INFO] [stdout] 232 + impl DataType for &T { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/core.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | data.len() * std::mem::size_of::(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(data)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `?Sized` bound is ignored because of a `Sized` requirement [INFO] [stdout] --> src/core/uniform.rs:28:27 [INFO] [stdout] | [INFO] [stdout] 28 | impl UniformDataType for &T {} [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: `T` cannot be unsized because of the bound [INFO] [stdout] --> src/core/uniform.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | impl UniformDataType for &T {} [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] = note: ...because `UniformDataType` has the bound `DataType` [INFO] [stdout] = note: ...because `DataType` has the bound `Clone` [INFO] [stdout] = note: ...because `Clone` has the bound `Sized` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized [INFO] [stdout] = note: `#[warn(clippy::needless_maybe_sized)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: change the bounds that require `Sized`, or remove the `?Sized` bound [INFO] [stdout] | [INFO] [stdout] 28 - impl UniformDataType for &T {} [INFO] [stdout] 28 + impl UniformDataType for &T {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/core/program.rs:503:13 [INFO] [stdout] | [INFO] [stdout] 503 | element_buffer.count() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `element_buffer.count()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/core/program.rs:563:13 [INFO] [stdout] | [INFO] [stdout] 563 | element_buffer.count() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `element_buffer.count()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `?Sized` bound is ignored because of a `Sized` requirement [INFO] [stdout] --> src/core/data_type.rs:232:20 [INFO] [stdout] | [INFO] [stdout] 232 | impl DataType for &T { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: `T` cannot be unsized because of the bound [INFO] [stdout] --> src/core/data_type.rs:232:9 [INFO] [stdout] | [INFO] [stdout] 232 | impl DataType for &T { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] = note: ...because `DataType` has the bound `Clone` [INFO] [stdout] = note: ...because `Clone` has the bound `Sized` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_maybe_sized [INFO] [stdout] help: change the bounds that require `Sized`, or remove the `?Sized` bound [INFO] [stdout] | [INFO] [stdout] 232 - impl DataType for &T { [INFO] [stdout] 232 + impl DataType for &T { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual slice size calculation [INFO] [stdout] --> src/core.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | data.len() * std::mem::size_of::(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(data)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_size_calculation [INFO] [stdout] = note: `#[warn(clippy::manual_slice_size_calculation)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.alpha_cutout` after checking its variant with `is_some` [INFO] [stdout] --> src/renderer/material/deferred_physical_material.rs:221:25 [INFO] [stdout] | [INFO] [stdout] 217 | if self.alpha_cutout.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = self.alpha_cutout` [INFO] [stdout] ... [INFO] [stdout] 221 | self.alpha_cutout.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.alpha_cutout` after checking its variant with `is_some` [INFO] [stdout] --> src/renderer/material/deferred_physical_material.rs:221:25 [INFO] [stdout] | [INFO] [stdout] 217 | if self.alpha_cutout.is_some() { [INFO] [stdout] | ------------------------------ help: try: `if let Some() = self.alpha_cutout` [INFO] [stdout] ... [INFO] [stdout] 221 | self.alpha_cutout.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/renderer/light/environment.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | &Camera::new_2d(viewport), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Camera::new_2d(viewport)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/renderer/light/environment.rs:103:29 [INFO] [stdout] | [INFO] [stdout] 103 | ... &Camera::new_2d(viewport), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Camera::new_2d(viewport)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/renderer/light/environment.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | &Camera::new_2d(viewport), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Camera::new_2d(viewport)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/renderer/light/environment.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 66 | &Camera::new_2d(viewport), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Camera::new_2d(viewport)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/renderer/light/environment.rs:103:29 [INFO] [stdout] | [INFO] [stdout] 103 | ... &Camera::new_2d(viewport), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Camera::new_2d(viewport)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/renderer/light/environment.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | &Camera::new_2d(viewport), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Camera::new_2d(viewport)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/orbit_control.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | / if !*handled { [INFO] [stdout] 38 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | | let speed = 0.01; [INFO] [stdout] 40 | | camera.rotate_around_with_fixed_up( [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ } [INFO] [stdout] 37 ~ if !*handled => { [INFO] [stdout] 38 | if Some(MouseButton::Left) == *button { [INFO] [stdout] ... [INFO] [stdout] 47 | } [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/orbit_control.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 51 | / if !*handled { [INFO] [stdout] 52 | | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] 53 | | camera.zoom_towards( [INFO] [stdout] 54 | | self.target, [INFO] [stdout] ... | [INFO] [stdout] 60 | | change = true; [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 50 ~ Event::MouseWheel { delta, handled, .. } [INFO] [stdout] 51 ~ if !*handled => { [INFO] [stdout] 52 | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] ... [INFO] [stdout] 60 | change = true; [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/orbit_control.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | / if !*handled { [INFO] [stdout] 65 | | let speed = self.target.distance(camera.position()) + 0.1; [INFO] [stdout] 66 | | camera.zoom_towards( [INFO] [stdout] 67 | | self.target, [INFO] [stdout] ... | [INFO] [stdout] 73 | | change = true; [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ Event::PinchGesture { delta, handled, .. } [INFO] [stdout] 64 ~ if !*handled => { [INFO] [stdout] 65 | let speed = self.target.distance(camera.position()) + 0.1; [INFO] [stdout] ... [INFO] [stdout] 73 | change = true; [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/renderer/control/orbit_control.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | / if !*handled { [INFO] [stdout] 38 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | | let speed = 0.01; [INFO] [stdout] 40 | | camera.rotate_around_with_fixed_up( [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 37 ~ if !*handled [INFO] [stdout] 38 ~ && Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | let speed = 0.01; [INFO] [stdout] ... [INFO] [stdout] 46 | change = true; [INFO] [stdout] 47 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/free_orbit_control.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | / if !*handled { [INFO] [stdout] 38 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] 40 | | camera.rotate_around(self.target, speed * delta.0, speed * delta.1); [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ } [INFO] [stdout] 37 ~ if !*handled => { [INFO] [stdout] 38 | if Some(MouseButton::Left) == *button { [INFO] [stdout] ... [INFO] [stdout] 43 | } [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/free_orbit_control.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | / if !*handled { [INFO] [stdout] 48 | | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] 49 | | camera.zoom_towards( [INFO] [stdout] 50 | | self.target, [INFO] [stdout] ... | [INFO] [stdout] 56 | | change = true; [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 46 ~ Event::MouseWheel { delta, handled, .. } [INFO] [stdout] 47 ~ if !*handled => { [INFO] [stdout] 48 | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] ... [INFO] [stdout] 56 | change = true; [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/free_orbit_control.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | / if !*handled { [INFO] [stdout] 61 | | let speed = self.target.distance(camera.position()) + 0.1; [INFO] [stdout] 62 | | camera.zoom_towards( [INFO] [stdout] 63 | | self.target, [INFO] [stdout] ... | [INFO] [stdout] 69 | | change = true; [INFO] [stdout] 70 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 59 ~ Event::PinchGesture { delta, handled, .. } [INFO] [stdout] 60 ~ if !*handled => { [INFO] [stdout] 61 | let speed = self.target.distance(camera.position()) + 0.1; [INFO] [stdout] ... [INFO] [stdout] 69 | change = true; [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/renderer/control/free_orbit_control.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | / if !*handled { [INFO] [stdout] 38 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] 40 | | camera.rotate_around(self.target, speed * delta.0, speed * delta.1); [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 37 ~ if !*handled [INFO] [stdout] 38 ~ && Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] ... [INFO] [stdout] 42 | change = true; [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/first_person_control.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | / if !*handled { [INFO] [stdout] 30 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 31 | | camera.yaw(radians(delta.0 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] 32 | | camera.pitch(radians(delta.1 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ } [INFO] [stdout] 29 ~ if !*handled => { [INFO] [stdout] 30 | if Some(MouseButton::Left) == *button { [INFO] [stdout] ... [INFO] [stdout] 35 | } [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/first_person_control.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | / if !*handled { [INFO] [stdout] 40 | | let v = camera.view_direction() * self.speed * delta.1; [INFO] [stdout] 41 | | camera.translate(v); [INFO] [stdout] 42 | | *handled = true; [INFO] [stdout] 43 | | change = true; [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 38 ~ Event::MouseWheel { delta, handled, .. } [INFO] [stdout] 39 ~ if !*handled => { [INFO] [stdout] 40 | let v = camera.view_direction() * self.speed * delta.1; [INFO] [stdout] ... [INFO] [stdout] 43 | change = true; [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/renderer/control/first_person_control.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | / if !*handled { [INFO] [stdout] 30 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 31 | | camera.yaw(radians(delta.0 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] 32 | | camera.pitch(radians(delta.1 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 29 ~ if !*handled [INFO] [stdout] 30 ~ && Some(MouseButton::Left) == *button { [INFO] [stdout] 31 | camera.yaw(radians(delta.0 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] ... [INFO] [stdout] 34 | change = true; [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/fly_control.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | / if !*handled { [INFO] [stdout] 30 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 31 | | camera.yaw(radians(delta.0 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] 32 | | camera.pitch(radians(delta.1 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ } [INFO] [stdout] 29 ~ if !*handled => { [INFO] [stdout] 30 | if Some(MouseButton::Left) == *button { [INFO] [stdout] ... [INFO] [stdout] 44 | } [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/fly_control.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | / if !*handled { [INFO] [stdout] 49 | | let v = camera.view_direction() * self.speed * delta.1; [INFO] [stdout] 50 | | camera.translate(v); [INFO] [stdout] 51 | | *handled = true; [INFO] [stdout] 52 | | change = true; [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 47 ~ Event::MouseWheel { delta, handled, .. } [INFO] [stdout] 48 ~ if !*handled => { [INFO] [stdout] 49 | let v = camera.view_direction() * self.speed * delta.1; [INFO] [stdout] ... [INFO] [stdout] 52 | change = true; [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/orbit_control.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | / if !*handled { [INFO] [stdout] 38 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | | let speed = 0.01; [INFO] [stdout] 40 | | camera.rotate_around_with_fixed_up( [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ } [INFO] [stdout] 37 ~ if !*handled => { [INFO] [stdout] 38 | if Some(MouseButton::Left) == *button { [INFO] [stdout] ... [INFO] [stdout] 47 | } [INFO] [stdout] 48 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/orbit_control.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 51 | / if !*handled { [INFO] [stdout] 52 | | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] 53 | | camera.zoom_towards( [INFO] [stdout] 54 | | self.target, [INFO] [stdout] ... | [INFO] [stdout] 60 | | change = true; [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 50 ~ Event::MouseWheel { delta, handled, .. } [INFO] [stdout] 51 ~ if !*handled => { [INFO] [stdout] 52 | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] ... [INFO] [stdout] 60 | change = true; [INFO] [stdout] 61 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/orbit_control.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | / if !*handled { [INFO] [stdout] 65 | | let speed = self.target.distance(camera.position()) + 0.1; [INFO] [stdout] 66 | | camera.zoom_towards( [INFO] [stdout] 67 | | self.target, [INFO] [stdout] ... | [INFO] [stdout] 73 | | change = true; [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ Event::PinchGesture { delta, handled, .. } [INFO] [stdout] 64 ~ if !*handled => { [INFO] [stdout] 65 | let speed = self.target.distance(camera.position()) + 0.1; [INFO] [stdout] ... [INFO] [stdout] 73 | change = true; [INFO] [stdout] 74 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/renderer/control/orbit_control.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | / if !*handled { [INFO] [stdout] 38 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | | let speed = 0.01; [INFO] [stdout] 40 | | camera.rotate_around_with_fixed_up( [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 37 ~ if !*handled [INFO] [stdout] 38 ~ && Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | let speed = 0.01; [INFO] [stdout] ... [INFO] [stdout] 46 | change = true; [INFO] [stdout] 47 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/free_orbit_control.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | / if !*handled { [INFO] [stdout] 38 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] 40 | | camera.rotate_around(self.target, speed * delta.0, speed * delta.1); [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ } [INFO] [stdout] 37 ~ if !*handled => { [INFO] [stdout] 38 | if Some(MouseButton::Left) == *button { [INFO] [stdout] ... [INFO] [stdout] 43 | } [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/free_orbit_control.rs:47:21 [INFO] [stdout] | [INFO] [stdout] 47 | / if !*handled { [INFO] [stdout] 48 | | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] 49 | | camera.zoom_towards( [INFO] [stdout] 50 | | self.target, [INFO] [stdout] ... | [INFO] [stdout] 56 | | change = true; [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 46 ~ Event::MouseWheel { delta, handled, .. } [INFO] [stdout] 47 ~ if !*handled => { [INFO] [stdout] 48 | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] ... [INFO] [stdout] 56 | change = true; [INFO] [stdout] 57 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/free_orbit_control.rs:60:21 [INFO] [stdout] | [INFO] [stdout] 60 | / if !*handled { [INFO] [stdout] 61 | | let speed = self.target.distance(camera.position()) + 0.1; [INFO] [stdout] 62 | | camera.zoom_towards( [INFO] [stdout] 63 | | self.target, [INFO] [stdout] ... | [INFO] [stdout] 69 | | change = true; [INFO] [stdout] 70 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 59 ~ Event::PinchGesture { delta, handled, .. } [INFO] [stdout] 60 ~ if !*handled => { [INFO] [stdout] 61 | let speed = self.target.distance(camera.position()) + 0.1; [INFO] [stdout] ... [INFO] [stdout] 69 | change = true; [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/renderer/control/free_orbit_control.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | / if !*handled { [INFO] [stdout] 38 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] 40 | | camera.rotate_around(self.target, speed * delta.0, speed * delta.1); [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 37 ~ if !*handled [INFO] [stdout] 38 ~ && Some(MouseButton::Left) == *button { [INFO] [stdout] 39 | let speed = 0.01 * self.target.distance(camera.position()) + 0.001; [INFO] [stdout] ... [INFO] [stdout] 42 | change = true; [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/first_person_control.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | / if !*handled { [INFO] [stdout] 30 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 31 | | camera.yaw(radians(delta.0 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] 32 | | camera.pitch(radians(delta.1 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ } [INFO] [stdout] 29 ~ if !*handled => { [INFO] [stdout] 30 | if Some(MouseButton::Left) == *button { [INFO] [stdout] ... [INFO] [stdout] 35 | } [INFO] [stdout] 36 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/first_person_control.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 39 | / if !*handled { [INFO] [stdout] 40 | | let v = camera.view_direction() * self.speed * delta.1; [INFO] [stdout] 41 | | camera.translate(v); [INFO] [stdout] 42 | | *handled = true; [INFO] [stdout] 43 | | change = true; [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 38 ~ Event::MouseWheel { delta, handled, .. } [INFO] [stdout] 39 ~ if !*handled => { [INFO] [stdout] 40 | let v = camera.view_direction() * self.speed * delta.1; [INFO] [stdout] ... [INFO] [stdout] 43 | change = true; [INFO] [stdout] 44 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/renderer/control/first_person_control.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | / if !*handled { [INFO] [stdout] 30 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 31 | | camera.yaw(radians(delta.0 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] 32 | | camera.pitch(radians(delta.1 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] ... | [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 29 ~ if !*handled [INFO] [stdout] 30 ~ && Some(MouseButton::Left) == *button { [INFO] [stdout] 31 | camera.yaw(radians(delta.0 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] ... [INFO] [stdout] 34 | change = true; [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/fly_control.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | / if !*handled { [INFO] [stdout] 30 | | if Some(MouseButton::Left) == *button { [INFO] [stdout] 31 | | camera.yaw(radians(delta.0 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] 32 | | camera.pitch(radians(delta.1 * std::f32::consts::PI / 1800.0)); [INFO] [stdout] ... | [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 28 ~ } [INFO] [stdout] 29 ~ if !*handled => { [INFO] [stdout] 30 | if Some(MouseButton::Left) == *button { [INFO] [stdout] ... [INFO] [stdout] 44 | } [INFO] [stdout] 45 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/renderer/control/fly_control.rs:48:21 [INFO] [stdout] | [INFO] [stdout] 48 | / if !*handled { [INFO] [stdout] 49 | | let v = camera.view_direction() * self.speed * delta.1; [INFO] [stdout] 50 | | camera.translate(v); [INFO] [stdout] 51 | | *handled = true; [INFO] [stdout] 52 | | change = true; [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 47 ~ Event::MouseWheel { delta, handled, .. } [INFO] [stdout] 48 ~ if !*handled => { [INFO] [stdout] 49 | let v = camera.view_direction() * self.speed * delta.1; [INFO] [stdout] ... [INFO] [stdout] 52 | change = true; [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/renderer.rs:401:5 [INFO] [stdout] | [INFO] [stdout] 401 | return id; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 401 - return id; [INFO] [stdout] 401 + id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/window.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | //! from a [glow](https://crates.io/crates/glow) OpenGL/WebGL context. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 4 | //! from a [glow](https://crates.io/crates/glow) OpenGL/WebGL context. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/window/winit_window/frame_input_generator.rs:291:17 [INFO] [stdout] | [INFO] [stdout] 291 | / if is_printable_char(*ch) && !self.modifiers.ctrl && !self.modifiers.command { [INFO] [stdout] 292 | | self.events.push(crate::Event::Text(ch.to_string())); [INFO] [stdout] 293 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 290 ~ WindowEvent::ReceivedCharacter(ch) [INFO] [stdout] 291 ~ if is_printable_char(*ch) && !self.modifiers.ctrl && !self.modifiers.command => { [INFO] [stdout] 292 | self.events.push(crate::Event::Text(ch.to_string())); [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/renderer.rs:401:5 [INFO] [stdout] | [INFO] [stdout] 401 | return id; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 401 - return id; [INFO] [stdout] 401 + id [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/window.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | //! from a [glow](https://crates.io/crates/glow) OpenGL/WebGL context. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 4 | //! from a [glow](https://crates.io/crates/glow) OpenGL/WebGL context. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/window/winit_window/frame_input_generator.rs:291:17 [INFO] [stdout] | [INFO] [stdout] 291 | / if is_printable_char(*ch) && !self.modifiers.ctrl && !self.modifiers.command { [INFO] [stdout] 292 | | self.events.push(crate::Event::Text(ch.to_string())); [INFO] [stdout] 293 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 290 ~ WindowEvent::ReceivedCharacter(ch) [INFO] [stdout] 291 ~ if is_printable_char(*ch) && !self.modifiers.ctrl && !self.modifiers.command => { [INFO] [stdout] 292 | self.events.push(crate::Event::Text(ch.to_string())); [INFO] [stdout] 293 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window/winit_window/frame_io.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn screen(&self) -> RenderTarget { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 52 | pub fn screen(&self) -> RenderTarget<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window/winit_window/frame_io.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn screen(&self) -> RenderTarget { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 52 | pub fn screen(&self) -> RenderTarget<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 46.22s [INFO] running `Command { std: "docker" "inspect" "167d612797210ba03e60b141942568592ec9c2ba4175edfe3eb772599e84b71b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "167d612797210ba03e60b141942568592ec9c2ba4175edfe3eb772599e84b71b", kill_on_drop: false }` [INFO] [stdout] 167d612797210ba03e60b141942568592ec9c2ba4175edfe3eb772599e84b71b