[INFO] fetching crate test-ignore-if 0.1.0... [INFO] linting test-ignore-if-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate test-ignore-if 0.1.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate test-ignore-if 0.1.0 [INFO] finished tweaking crates.io crate test-ignore-if 0.1.0 [INFO] tweaked toml for crates.io crate test-ignore-if 0.1.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate test-ignore-if 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] [stderr] Adding darling v0.9.0 (available: v0.23.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (available: v1.0.106) [INFO] [stderr] Adding quote v0.6.13 (available: v1.0.45) [INFO] [stderr] Adding syn v0.15.44 (available: v2.0.117) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded darling_macro v0.9.0 [INFO] [stderr] Downloaded darling v0.9.0 [INFO] [stderr] Downloaded strsim v0.7.0 [INFO] [stderr] Downloaded darling_core v0.9.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 981d342bdc35305ea7a55b6ee7a69c8deb61d9aa190aecad06b66d3787452b42 [INFO] running `Command { std: "docker" "start" "-a" "981d342bdc35305ea7a55b6ee7a69c8deb61d9aa190aecad06b66d3787452b42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "981d342bdc35305ea7a55b6ee7a69c8deb61d9aa190aecad06b66d3787452b42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "981d342bdc35305ea7a55b6ee7a69c8deb61d9aa190aecad06b66d3787452b42", kill_on_drop: false }` [INFO] [stdout] 981d342bdc35305ea7a55b6ee7a69c8deb61d9aa190aecad06b66d3787452b42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb15b863d477096d52e8d721fa1a0550e666fc55b0156e12e91fdd07fad1fbe6 [INFO] running `Command { std: "docker" "start" "-a" "fb15b863d477096d52e8d721fa1a0550e666fc55b0156e12e91fdd07fad1fbe6", kill_on_drop: false }` [INFO] [stderr] Checking unicode-xid v0.1.0 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Checking ident_case v1.0.1 [INFO] [stderr] Checking proc-macro2 v0.4.30 [INFO] [stderr] Compiling darling_core v0.9.0 [INFO] [stderr] Checking quote v0.6.13 [INFO] [stderr] Checking syn v0.15.44 [INFO] [stderr] Compiling darling_macro v0.9.0 [INFO] [stderr] Checking darling v0.9.0 [INFO] [stderr] Checking test-ignore-if v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | if !std::env::var(format!( [INFO] [stdout] | ________^ [INFO] [stdout] 28 | | "TEST_IGNORE_IF_ENV_SET_ENABLED_FOR_{}", [INFO] [stdout] 29 | | attr.env_set [INFO] [stdout] 30 | | )) [INFO] [stdout] 31 | | .is_ok() [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 ~ if std::env::var(format!( [INFO] [stdout] 28 + "TEST_IGNORE_IF_ENV_SET_ENABLED_FOR_{}", [INFO] [stdout] 29 + attr.env_set [INFO] [stdout] 30 + )).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | if !std::env::var(format!( [INFO] [stdout] | ________^ [INFO] [stdout] 28 | | "TEST_IGNORE_IF_ENV_SET_ENABLED_FOR_{}", [INFO] [stdout] 29 | | attr.env_set [INFO] [stdout] 30 | | )) [INFO] [stdout] 31 | | .is_ok() [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 27 ~ if std::env::var(format!( [INFO] [stdout] 28 + "TEST_IGNORE_IF_ENV_SET_ENABLED_FOR_{}", [INFO] [stdout] 29 + attr.env_set [INFO] [stdout] 30 + )).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/lib.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | if attr.enabled.unwrap_or_else(|| true) && std::env::var(attr.env_set).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 43 - if attr.enabled.unwrap_or_else(|| true) && std::env::var(attr.env_set).is_ok() { [INFO] [stdout] 43 + if attr.enabled.unwrap_or(true) && std::env::var(attr.env_set).is_ok() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | panic!(format!( [INFO] [stdout] | ________________^ [INFO] [stdout] 34 | | "trying to use ignore_if_env_set for env var \"{}\" that is not enabled, you \ [INFO] [stdout] 35 | | need to add test_ignore_if_utils::enable_ignore_if_env_set_for(\"{}\") in your \ [INFO] [stdout] 36 | | build.rs", [INFO] [stdout] 37 | | attr.env_set, attr.env_set [INFO] [stdout] 38 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 33 ~ panic!( [INFO] [stdout] 34 | "trying to use ignore_if_env_set for env var \"{}\" that is not enabled, you \ [INFO] [stdout] ... [INFO] [stdout] 37 | attr.env_set, attr.env_set [INFO] [stdout] 38 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/lib.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | if attr.enabled.unwrap_or_else(|| true) && std::env::var(attr.env_set).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 43 - if attr.enabled.unwrap_or_else(|| true) && std::env::var(attr.env_set).is_ok() { [INFO] [stdout] 43 + if attr.enabled.unwrap_or(true) && std::env::var(attr.env_set).is_ok() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:33:16 [INFO] [stdout] | [INFO] [stdout] 33 | panic!(format!( [INFO] [stdout] | ________________^ [INFO] [stdout] 34 | | "trying to use ignore_if_env_set for env var \"{}\" that is not enabled, you \ [INFO] [stdout] 35 | | need to add test_ignore_if_utils::enable_ignore_if_env_set_for(\"{}\") in your \ [INFO] [stdout] 36 | | build.rs", [INFO] [stdout] 37 | | attr.env_set, attr.env_set [INFO] [stdout] 38 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 33 ~ panic!( [INFO] [stdout] 34 | "trying to use ignore_if_env_set for env var \"{}\" that is not enabled, you \ [INFO] [stdout] ... [INFO] [stdout] 37 | attr.env_set, attr.env_set [INFO] [stdout] 38 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.65s [INFO] running `Command { std: "docker" "inspect" "fb15b863d477096d52e8d721fa1a0550e666fc55b0156e12e91fdd07fad1fbe6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb15b863d477096d52e8d721fa1a0550e666fc55b0156e12e91fdd07fad1fbe6", kill_on_drop: false }` [INFO] [stdout] fb15b863d477096d52e8d721fa1a0550e666fc55b0156e12e91fdd07fad1fbe6