[INFO] fetching crate tebex_headless_rust 0.1.3... [INFO] linting tebex_headless_rust-0.1.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tebex_headless_rust 0.1.3 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate tebex_headless_rust 0.1.3 [INFO] finished tweaking crates.io crate tebex_headless_rust 0.1.3 [INFO] tweaked toml for crates.io crate tebex_headless_rust 0.1.3 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tebex_headless_rust 0.1.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 179 packages to latest compatible versions [INFO] [stderr] Adding local-ip-address v0.5.7 (available: v0.6.10) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded local-ip-address v0.5.7 [INFO] [stderr] Downloaded neli-proc-macros v0.1.4 [INFO] [stderr] Downloaded neli v0.6.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 502d2b619a4ab0f01c6ce027c0bb3ef7784caf4b26d004de0bb37ec40408c99d [INFO] running `Command { std: "docker" "start" "-a" "502d2b619a4ab0f01c6ce027c0bb3ef7784caf4b26d004de0bb37ec40408c99d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "502d2b619a4ab0f01c6ce027c0bb3ef7784caf4b26d004de0bb37ec40408c99d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "502d2b619a4ab0f01c6ce027c0bb3ef7784caf4b26d004de0bb37ec40408c99d", kill_on_drop: false }` [INFO] [stdout] 502d2b619a4ab0f01c6ce027c0bb3ef7784caf4b26d004de0bb37ec40408c99d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cb477c794d725359a73be553658bc0ff42303b79c128e08575b2092835c1dbb5 [INFO] running `Command { std: "docker" "start" "-a" "cb477c794d725359a73be553658bc0ff42303b79c128e08575b2092835c1dbb5", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling neli-proc-macros v0.1.4 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking neli v0.6.5 [INFO] [stderr] Checking local-ip-address v0.5.7 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking tebex_headless_rust v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `unwrap` on `ip_address` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/package.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 19 | if ip_address.is_none() { String::from("") } else { format!("{0}ipAddress={1}", [INFO] [stdout] | ----------------------- help: try: `if let Some() = ip_address` [INFO] [stdout] 20 | if basket_identifier.is_none() { String::from("?") } else { String::from("&") }, [INFO] [stdout] 21 | ip_address.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:33:29 [INFO] [stdout] | [INFO] [stdout] 33 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(json_data.data); [INFO] [stdout] 33 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:37:29 [INFO] [stdout] | [INFO] [stdout] 37 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 37 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 43 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 43 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 49 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/package.rs:37:40 [INFO] [stdout] | [INFO] [stdout] 37 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ip_address` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/package.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 65 | if ip_address.is_none() { String::from("") } else { format!("{0}ipAddress={1}", [INFO] [stdout] | ----------------------- help: try: `if let Some() = ip_address` [INFO] [stdout] 66 | if basket_identifier.is_none() { String::from("?") } else { String::from("&") }, [INFO] [stdout] 67 | ip_address.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(json_data.data); [INFO] [stdout] 79 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 83 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 89 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 95 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/package.rs:83:40 [INFO] [stdout] | [INFO] [stdout] 83 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `basket_identifier` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/category.rs:21:104 [INFO] [stdout] | [INFO] [stdout] 21 | if basket_identifier.is_none() { String::from("") } else { format!("&basketIdent={0}", basket_identifier.unwrap()) }, [INFO] [stdout] | ------------------------------ help: try: `if let Some() = basket_identifier` ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ip_address` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/category.rs:22:95 [INFO] [stdout] | [INFO] [stdout] 22 | if ip_address.is_none() { String::from("") } else { format!("&ipAddress={0}", ip_address.unwrap()) } [INFO] [stdout] | ----------------------- help: try: `if let Some() = ip_address` ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:33:29 [INFO] [stdout] | [INFO] [stdout] 33 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(json_data.data); [INFO] [stdout] 33 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:37:29 [INFO] [stdout] | [INFO] [stdout] 37 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 37 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 43 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 43 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 49 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/category.rs:37:40 [INFO] [stdout] | [INFO] [stdout] 37 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `basket_identifier` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/category.rs:67:104 [INFO] [stdout] | [INFO] [stdout] 67 | if basket_identifier.is_none() { String::from("") } else { format!("&basketIdent={0}", basket_identifier.unwrap()) }, [INFO] [stdout] | ------------------------------ help: try: `if let Some() = basket_identifier` ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ip_address` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/category.rs:68:95 [INFO] [stdout] | [INFO] [stdout] 68 | if ip_address.is_none() { String::from("") } else { format!("&ipAddress={0}", ip_address.unwrap()) } [INFO] [stdout] | ----------------------- help: try: `if let Some() = ip_address` ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(json_data.data); [INFO] [stdout] 79 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 83 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 89 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 95 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/category.rs:83:40 [INFO] [stdout] | [INFO] [stdout] 83 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 25 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Ok(json_data.data); [INFO] [stdout] 25 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 29 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 29 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 35 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 41 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:29:40 [INFO] [stdout] | [INFO] [stdout] 29 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:62:29 [INFO] [stdout] | [INFO] [stdout] 62 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return Ok(json_data); [INFO] [stdout] 62 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 66 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 72 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 72 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 78 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:66:40 [INFO] [stdout] | [INFO] [stdout] 66 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 111 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Ok(json_data.data); [INFO] [stdout] 111 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:115:29 [INFO] [stdout] | [INFO] [stdout] 115 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 115 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 121 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 127 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:115:40 [INFO] [stdout] | [INFO] [stdout] 115 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:158:29 [INFO] [stdout] | [INFO] [stdout] 158 | ... return Ok(json_data_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Ok(json_data_data); [INFO] [stdout] 158 + Ok(json_data_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:162:29 [INFO] [stdout] | [INFO] [stdout] 162 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] 162 + Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 168 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 174 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:162:40 [INFO] [stdout] | [INFO] [stdout] 162 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Could not find basket in returned data")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/handlers/basket.rs:162:53 [INFO] [stdout] | [INFO] [stdout] 162 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not find basket in returned data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:168:32 [INFO] [stdout] | [INFO] [stdout] 168 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:198:29 [INFO] [stdout] | [INFO] [stdout] 198 | ... return Ok(json_data_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return Ok(json_data_data); [INFO] [stdout] 198 + Ok(json_data_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 202 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] 202 + Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 208 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 208 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 214 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:202:40 [INFO] [stdout] | [INFO] [stdout] 202 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Could not find basket in returned data")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/handlers/basket.rs:202:53 [INFO] [stdout] | [INFO] [stdout] 202 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not find basket in returned data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:208:32 [INFO] [stdout] | [INFO] [stdout] 208 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:238:29 [INFO] [stdout] | [INFO] [stdout] 238 | ... return Ok(json_data_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return Ok(json_data_data); [INFO] [stdout] 238 + Ok(json_data_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:242:29 [INFO] [stdout] | [INFO] [stdout] 242 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] 242 + Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:248:21 [INFO] [stdout] | [INFO] [stdout] 248 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 248 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 254 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:242:40 [INFO] [stdout] | [INFO] [stdout] 242 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Could not find basket in returned data")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/handlers/basket.rs:242:53 [INFO] [stdout] | [INFO] [stdout] 242 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not find basket in returned data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:248:32 [INFO] [stdout] | [INFO] [stdout] 248 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:279:21 [INFO] [stdout] | [INFO] [stdout] 279 | return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 279 - return Ok(json_data.data); [INFO] [stdout] 279 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 283 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 283 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 283 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 289 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:283:32 [INFO] [stdout] | [INFO] [stdout] 283 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/webstores.rs:23:29 [INFO] [stdout] | [INFO] [stdout] 23 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return Ok(json_data.data); [INFO] [stdout] 23 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/webstores.rs:27:29 [INFO] [stdout] | [INFO] [stdout] 27 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 27 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/webstores.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 33 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/webstores.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 39 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/webstores.rs:27:40 [INFO] [stdout] | [INFO] [stdout] 27 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(json_data); [INFO] [stdout] 30 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 34 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 40 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 46 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/coupons.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Ok(json_data); [INFO] [stdout] 72 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:76:29 [INFO] [stdout] | [INFO] [stdout] 76 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 76 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 82 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 88 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/coupons.rs:76:40 [INFO] [stdout] | [INFO] [stdout] 76 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(json_data); [INFO] [stdout] 30 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 34 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 40 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 46 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/gift_cards.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Ok(json_data); [INFO] [stdout] 72 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:76:29 [INFO] [stdout] | [INFO] [stdout] 76 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 76 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 82 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 88 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/gift_cards.rs:76:40 [INFO] [stdout] | [INFO] [stdout] 76 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(json_data); [INFO] [stdout] 30 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 34 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 40 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 46 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/creator_codes.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(json_data); [INFO] [stdout] 69 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 73 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 79 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 85 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/creator_codes.rs:73:40 [INFO] [stdout] | [INFO] [stdout] 73 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/misc.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | return Ok(res_data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Ok(res_data) [INFO] [stdout] 17 + Ok(res_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/misc.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | return Err(String::from("Public API key is not set")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Err(String::from("Public API key is not set")); [INFO] [stdout] 21 + Err(String::from("Public API key is not set")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handlers/misc.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | if cfg!(test) && !dotenv().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `dotenv().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/misc.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return queried; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return queried; [INFO] [stdout] 34 + queried [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | return Err(String::from(format!("Error trying to get basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to get basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/tests/basket.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 37 | if basket_url.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `basket_url.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:45:28 [INFO] [stdout] | [INFO] [stdout] 45 | return Err(String::from(format!("Error trying to get basket auth url, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to get basket auth url, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/tests/basket.rs:60:28 [INFO] [stdout] | [INFO] [stdout] 60 | if packages.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `packages.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:73:48 [INFO] [stdout] | [INFO] [stdout] 73 | ... return Err(String::from(format!("Error trying to add package to basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to add package to basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:82:36 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(String::from(format!("Error trying to get basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to get basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:88:28 [INFO] [stdout] | [INFO] [stdout] 88 | return Err(String::from(format!("Error trying to get basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to get basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tests/basket.rs:98:17 [INFO] [stdout] | [INFO] [stdout] 98 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 98 - return Ok(()); [INFO] [stdout] 98 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tests/basket.rs:103:21 [INFO] [stdout] | [INFO] [stdout] 103 | return Err(String::from(format!("Error trying to remove package from basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return Err(String::from(format!("Error trying to remove package from basket, {0}", err))); [INFO] [stdout] 103 + Err(String::from(format!("Error trying to remove package from basket, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/tests/basket.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Ok(()); [INFO] [stdout] 105 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:103:32 [INFO] [stdout] | [INFO] [stdout] 103 | return Err(String::from(format!("Error trying to remove package from basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to remove package from basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/tests/basket.rs:121:28 [INFO] [stdout] | [INFO] [stdout] 121 | if packages.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `packages.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:134:48 [INFO] [stdout] | [INFO] [stdout] 134 | ... return Err(String::from(format!("Error trying to add package to basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to add package to basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:143:36 [INFO] [stdout] | [INFO] [stdout] 143 | return Err(String::from(format!("Error trying to get basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to get basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:149:28 [INFO] [stdout] | [INFO] [stdout] 149 | return Err(String::from(format!("Error trying to get basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to get basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/tests/basket.rs:164:28 [INFO] [stdout] | [INFO] [stdout] 164 | if packages.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `packages.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:181:56 [INFO] [stdout] | [INFO] [stdout] 181 | ... return Err(String::from(format!("Error trying to update package in basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to update package in basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:191:48 [INFO] [stdout] | [INFO] [stdout] 191 | ... return Err(String::from(format!("Error trying to add package to basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to add package to basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:200:36 [INFO] [stdout] | [INFO] [stdout] 200 | return Err(String::from(format!("Error trying to get basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to get basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/basket.rs:206:28 [INFO] [stdout] | [INFO] [stdout] 206 | return Err(String::from(format!("Error trying to get basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to get basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/tests/category.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if categories.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `categories.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/coupons.rs:19:36 [INFO] [stdout] | [INFO] [stdout] 19 | return Err(String::from(format!("Error trying to apply coupon, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to apply coupon, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/coupons.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | return Err(String::from(format!("Error trying to create basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to create basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/coupons.rs:49:44 [INFO] [stdout] | [INFO] [stdout] 49 | ... return Err(String::from(format!("Error trying to remove coupon, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to remove coupon, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/coupons.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(String::from(format!("Error trying to apply coupon, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to apply coupon, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/coupons.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | return Err(String::from(format!("Error trying to create basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to create basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/gift_cards.rs:19:36 [INFO] [stdout] | [INFO] [stdout] 19 | return Err(String::from(format!("Error trying to apply giftcard, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to apply giftcard, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/gift_cards.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | return Err(String::from(format!("Error trying to create basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to create basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/gift_cards.rs:49:44 [INFO] [stdout] | [INFO] [stdout] 49 | ... return Err(String::from(format!("Error trying to remove giftcard, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to remove giftcard, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/gift_cards.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(String::from(format!("Error trying to apply giftcard, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to apply giftcard, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/gift_cards.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | return Err(String::from(format!("Error trying to create basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to create basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/tests/package.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | if packages.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `packages.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/creator_codes.rs:19:36 [INFO] [stdout] | [INFO] [stdout] 19 | return Err(String::from(format!("Error trying to apply creator code, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to apply creator code, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/creator_codes.rs:26:28 [INFO] [stdout] | [INFO] [stdout] 26 | return Err(String::from(format!("Error trying to create basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to create basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/creator_codes.rs:49:44 [INFO] [stdout] | [INFO] [stdout] 49 | ... return Err(String::from(format!("Error trying to remove creator code, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to remove creator code, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/creator_codes.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(String::from(format!("Error trying to apply creator code, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to apply creator code, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/tests/creator_codes.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | return Err(String::from(format!("Error trying to create basket, {0}", err))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error trying to create basket, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ip_address` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/package.rs:21:21 [INFO] [stdout] | [INFO] [stdout] 19 | if ip_address.is_none() { String::from("") } else { format!("{0}ipAddress={1}", [INFO] [stdout] | ----------------------- help: try: `if let Some() = ip_address` [INFO] [stdout] 20 | if basket_identifier.is_none() { String::from("?") } else { String::from("&") }, [INFO] [stdout] 21 | ip_address.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:33:29 [INFO] [stdout] | [INFO] [stdout] 33 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(json_data.data); [INFO] [stdout] 33 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:37:29 [INFO] [stdout] | [INFO] [stdout] 37 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 37 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 43 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 43 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 49 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/package.rs:37:40 [INFO] [stdout] | [INFO] [stdout] 37 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ip_address` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/package.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 65 | if ip_address.is_none() { String::from("") } else { format!("{0}ipAddress={1}", [INFO] [stdout] | ----------------------- help: try: `if let Some() = ip_address` [INFO] [stdout] 66 | if basket_identifier.is_none() { String::from("?") } else { String::from("&") }, [INFO] [stdout] 67 | ip_address.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(json_data.data); [INFO] [stdout] 79 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 83 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 89 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/package.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 95 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/package.rs:83:40 [INFO] [stdout] | [INFO] [stdout] 83 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `basket_identifier` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/category.rs:21:104 [INFO] [stdout] | [INFO] [stdout] 21 | if basket_identifier.is_none() { String::from("") } else { format!("&basketIdent={0}", basket_identifier.unwrap()) }, [INFO] [stdout] | ------------------------------ help: try: `if let Some() = basket_identifier` ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ip_address` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/category.rs:22:95 [INFO] [stdout] | [INFO] [stdout] 22 | if ip_address.is_none() { String::from("") } else { format!("&ipAddress={0}", ip_address.unwrap()) } [INFO] [stdout] | ----------------------- help: try: `if let Some() = ip_address` ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:33:29 [INFO] [stdout] | [INFO] [stdout] 33 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Ok(json_data.data); [INFO] [stdout] 33 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:37:29 [INFO] [stdout] | [INFO] [stdout] 37 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 37 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 43 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 43 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 49 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/category.rs:37:40 [INFO] [stdout] | [INFO] [stdout] 37 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `basket_identifier` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/category.rs:67:104 [INFO] [stdout] | [INFO] [stdout] 67 | if basket_identifier.is_none() { String::from("") } else { format!("&basketIdent={0}", basket_identifier.unwrap()) }, [INFO] [stdout] | ------------------------------ help: try: `if let Some() = basket_identifier` ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ip_address` after checking its variant with `is_none` [INFO] [stdout] --> src/handlers/category.rs:68:95 [INFO] [stdout] | [INFO] [stdout] 68 | if ip_address.is_none() { String::from("") } else { format!("&ipAddress={0}", ip_address.unwrap()) } [INFO] [stdout] | ----------------------- help: try: `if let Some() = ip_address` ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 79 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Ok(json_data.data); [INFO] [stdout] 79 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 83 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 89 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 89 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/category.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 95 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 95 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/category.rs:83:40 [INFO] [stdout] | [INFO] [stdout] 83 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 25 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Ok(json_data.data); [INFO] [stdout] 25 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:29:29 [INFO] [stdout] | [INFO] [stdout] 29 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 29 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:35:21 [INFO] [stdout] | [INFO] [stdout] 35 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 35 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 41 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:29:40 [INFO] [stdout] | [INFO] [stdout] 29 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:62:29 [INFO] [stdout] | [INFO] [stdout] 62 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return Ok(json_data); [INFO] [stdout] 62 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 66 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 72 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 72 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 78 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:66:40 [INFO] [stdout] | [INFO] [stdout] 66 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:111:29 [INFO] [stdout] | [INFO] [stdout] 111 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return Ok(json_data.data); [INFO] [stdout] 111 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:115:29 [INFO] [stdout] | [INFO] [stdout] 115 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 115 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:121:21 [INFO] [stdout] | [INFO] [stdout] 121 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 121 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 127 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 127 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:115:40 [INFO] [stdout] | [INFO] [stdout] 115 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:158:29 [INFO] [stdout] | [INFO] [stdout] 158 | ... return Ok(json_data_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Ok(json_data_data); [INFO] [stdout] 158 + Ok(json_data_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:162:29 [INFO] [stdout] | [INFO] [stdout] 162 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] 162 + Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:168:21 [INFO] [stdout] | [INFO] [stdout] 168 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 168 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 168 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 174 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:162:40 [INFO] [stdout] | [INFO] [stdout] 162 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Could not find basket in returned data")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/handlers/basket.rs:162:53 [INFO] [stdout] | [INFO] [stdout] 162 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not find basket in returned data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:168:32 [INFO] [stdout] | [INFO] [stdout] 168 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:198:29 [INFO] [stdout] | [INFO] [stdout] 198 | ... return Ok(json_data_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 - return Ok(json_data_data); [INFO] [stdout] 198 + Ok(json_data_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:202:29 [INFO] [stdout] | [INFO] [stdout] 202 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] 202 + Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 208 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 208 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 214 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 214 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:202:40 [INFO] [stdout] | [INFO] [stdout] 202 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Could not find basket in returned data")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/handlers/basket.rs:202:53 [INFO] [stdout] | [INFO] [stdout] 202 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not find basket in returned data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:208:32 [INFO] [stdout] | [INFO] [stdout] 208 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:238:29 [INFO] [stdout] | [INFO] [stdout] 238 | ... return Ok(json_data_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 238 - return Ok(json_data_data); [INFO] [stdout] 238 + Ok(json_data_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:242:29 [INFO] [stdout] | [INFO] [stdout] 242 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] 242 + Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:248:21 [INFO] [stdout] | [INFO] [stdout] 248 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 248 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 248 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:254:13 [INFO] [stdout] | [INFO] [stdout] 254 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 254 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:242:40 [INFO] [stdout] | [INFO] [stdout] 242 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Could not find basket in returned data")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/handlers/basket.rs:242:53 [INFO] [stdout] | [INFO] [stdout] 242 | ... return Err(String::from(format!("Could not find basket in returned data"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Could not find basket in returned data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:248:32 [INFO] [stdout] | [INFO] [stdout] 248 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:279:21 [INFO] [stdout] | [INFO] [stdout] 279 | return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 279 - return Ok(json_data.data); [INFO] [stdout] 279 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 283 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 283 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 283 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/basket.rs:289:13 [INFO] [stdout] | [INFO] [stdout] 289 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 289 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 289 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/basket.rs:283:32 [INFO] [stdout] | [INFO] [stdout] 283 | return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/webstores.rs:23:29 [INFO] [stdout] | [INFO] [stdout] 23 | ... return Ok(json_data.data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return Ok(json_data.data); [INFO] [stdout] 23 + Ok(json_data.data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/webstores.rs:27:29 [INFO] [stdout] | [INFO] [stdout] 27 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 27 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/webstores.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 33 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/webstores.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 39 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/webstores.rs:27:40 [INFO] [stdout] | [INFO] [stdout] 27 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(json_data); [INFO] [stdout] 30 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 34 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 40 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 46 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/coupons.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Ok(json_data); [INFO] [stdout] 72 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:76:29 [INFO] [stdout] | [INFO] [stdout] 76 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 76 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 82 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/coupons.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 88 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/coupons.rs:76:40 [INFO] [stdout] | [INFO] [stdout] 76 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(json_data); [INFO] [stdout] 30 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 34 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 40 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 46 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/gift_cards.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:72:29 [INFO] [stdout] | [INFO] [stdout] 72 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Ok(json_data); [INFO] [stdout] 72 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:76:29 [INFO] [stdout] | [INFO] [stdout] 76 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 76 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:82:21 [INFO] [stdout] | [INFO] [stdout] 82 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 82 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/gift_cards.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 88 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/gift_cards.rs:76:40 [INFO] [stdout] | [INFO] [stdout] 76 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 30 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(json_data); [INFO] [stdout] 30 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 34 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 40 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 46 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/creator_codes.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | ... return Ok(json_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Ok(json_data); [INFO] [stdout] 69 + Ok(json_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] 73 + Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:79:21 [INFO] [stdout] | [INFO] [stdout] 79 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 79 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/creator_codes.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | return Err(String::from("Unknown error occured")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return Err(String::from("Unknown error occured")); [INFO] [stdout] 85 + Err(String::from("Unknown error occured")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/handlers/creator_codes.rs:73:40 [INFO] [stdout] | [INFO] [stdout] 73 | ... return Err(String::from(format!("Error occured whilst parsing JSON, {0}", err))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Error occured whilst parsing JSON, {0}", err)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/misc.rs:17:13 [INFO] [stdout] | [INFO] [stdout] 17 | return Ok(res_data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Ok(res_data) [INFO] [stdout] 17 + Ok(res_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/misc.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | return Err(String::from("Public API key is not set")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Err(String::from("Public API key is not set")); [INFO] [stdout] 21 + Err(String::from("Public API key is not set")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/handlers/misc.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | if cfg!(test) && !dotenv().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `dotenv().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/handlers/misc.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return queried; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return queried; [INFO] [stdout] 34 + queried [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.07s [INFO] running `Command { std: "docker" "inspect" "cb477c794d725359a73be553658bc0ff42303b79c128e08575b2092835c1dbb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb477c794d725359a73be553658bc0ff42303b79c128e08575b2092835c1dbb5", kill_on_drop: false }` [INFO] [stdout] cb477c794d725359a73be553658bc0ff42303b79c128e08575b2092835c1dbb5