[INFO] fetching crate tcplscan 0.1.5...
[INFO] linting tcplscan-0.1.5 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate tcplscan 0.1.5 into /workspace/builds/worker-7-tc1/source
[INFO] started tweaking crates.io crate tcplscan 0.1.5
[INFO] finished tweaking crates.io crate tcplscan 0.1.5
[INFO] tweaked toml for crates.io crate tcplscan 0.1.5 written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate tcplscan 0.1.5 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate crates.io crate tcplscan 0.1.5 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded windows-targets v0.48.2
[INFO] [stderr]   Downloaded colored v2.0.4
[INFO] [stderr]   Downloaded windows_aarch64_gnullvm v0.48.2
[INFO] [stderr]   Downloaded windows_x86_64_gnullvm v0.48.2
[INFO] [stderr]   Downloaded windows_aarch64_msvc v0.48.2
[INFO] [stderr]   Downloaded windows_i686_gnu v0.48.2
[INFO] [stderr]   Downloaded windows_x86_64_gnu v0.48.2
[INFO] [stderr]   Downloaded rustix v0.38.8
[INFO] [stderr]   Downloaded windows_x86_64_msvc v0.48.2
[INFO] [stderr]   Downloaded windows_i686_msvc v0.48.2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] a907a6e53ba348cd8fbd0b26944ec021007a7ed5a92aa9e05eaa2e790537db82
[INFO] running `Command { std: "docker" "start" "-a" "a907a6e53ba348cd8fbd0b26944ec021007a7ed5a92aa9e05eaa2e790537db82", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "a907a6e53ba348cd8fbd0b26944ec021007a7ed5a92aa9e05eaa2e790537db82", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a907a6e53ba348cd8fbd0b26944ec021007a7ed5a92aa9e05eaa2e790537db82", kill_on_drop: false }`
[INFO] [stdout] a907a6e53ba348cd8fbd0b26944ec021007a7ed5a92aa9e05eaa2e790537db82
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 525dee2ea29be8c20242299e61b5da5cffde1da0981c9d346ffc86e0e35a584c
[INFO] running `Command { std: "docker" "start" "-a" "525dee2ea29be8c20242299e61b5da5cffde1da0981c9d346ffc86e0e35a584c", kill_on_drop: false }`
[INFO] [stderr]    Compiling rustix v0.38.8
[INFO] [stderr]     Checking linux-raw-sys v0.4.5
[INFO] [stderr]     Checking bitflags v2.4.0
[INFO] [stderr]     Checking is-terminal v0.4.9
[INFO] [stderr]     Checking colored v2.0.4
[INFO] [stderr]     Checking tcplscan v0.1.5 (/opt/rustwide/workdir)
[INFO] [stdout] warning: field `classes` is never read
[INFO] [stdout]    --> src/indexing/parser.rs:195:9
[INFO] [stdout]     |
[INFO] [stdout] 192 | pub struct Parser {
[INFO] [stdout]     |            ------ field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 195 |     pub classes: Vec<Class>,
[INFO] [stdout]     |         ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
[INFO] [stdout]    --> src/indexing/parser.rs:556:26
[INFO] [stdout]     |
[INFO] [stdout] 556 |             let ending = use_stmt.split('\\').last().expect("Empty use statement");
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
[INFO] [stdout]     = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 556 -             let ending = use_stmt.split('\\').last().expect("Empty use statement");
[INFO] [stdout] 556 +             let ending = use_stmt.split('\\').next_back().expect("Empty use statement");
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]    --> src/indexing/parser.rs:581:23
[INFO] [stdout]     |
[INFO] [stdout] 581 |           let keyword = match match_keyword(&token) {
[INFO] [stdout]     |  _______________________^
[INFO] [stdout] 582 | |             Some(keyword) => keyword,
[INFO] [stdout] 583 | |             None => return None,
[INFO] [stdout] 584 | |         };
[INFO] [stdout]     | |_________^ help: try instead: `match_keyword(&token)?`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout]     = note: `#[warn(clippy::question_mark)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]   --> src/indexing/tokenizer.rs:46:20
[INFO] [stdout]    |
[INFO] [stdout] 46 |           let char = match self.code.first() {
[INFO] [stdout]    |  ____________________^
[INFO] [stdout] 47 | |             Some(char) => char,
[INFO] [stdout] 48 | |             None => return None,
[INFO] [stdout] 49 | |         };
[INFO] [stdout]    | |_________^ help: try instead: `self.code.first()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/indexing/tokenizer.rs:84:16
[INFO] [stdout]    |
[INFO] [stdout] 84 |         while (!self.peek().is_some_and(|c| c == &quote_type) || escaped) && !self.code.is_empty() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek().is_none_or(|c| c != &quote_type)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]    --> src/indexing/tokenizer.rs:173:20
[INFO] [stdout]     |
[INFO] [stdout] 173 |           let char = match self.next_char_opt() {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 174 | |             Some(char) => char,
[INFO] [stdout] 175 | |             None => return None,
[INFO] [stdout] 176 | |         };
[INFO] [stdout]     | |_________^ help: try instead: `self.next_char_opt()?`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `classes` is never read
[INFO] [stdout]    --> src/indexing/parser.rs:195:9
[INFO] [stdout]     |
[INFO] [stdout] 192 | pub struct Parser {
[INFO] [stdout]     |            ------ field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 195 |     pub classes: Vec<Class>,
[INFO] [stdout]     |         ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> src/interface/mod.rs:332:13
[INFO] [stdout]     |
[INFO] [stdout] 332 |             files.sort_by(|a, b| b.class.dependencies.len().cmp(&a.class.dependencies.len()));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 332 -             files.sort_by(|a, b| b.class.dependencies.len().cmp(&a.class.dependencies.len()));
[INFO] [stdout] 332 +             files.sort_by_key(|b| std::cmp::Reverse(b.class.dependencies.len()));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator
[INFO] [stdout]    --> src/indexing/parser.rs:556:26
[INFO] [stdout]     |
[INFO] [stdout] 556 |             let ending = use_stmt.split('\\').last().expect("Empty use statement");
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last
[INFO] [stdout]     = note: `#[warn(clippy::double_ended_iterator_last)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 556 -             let ending = use_stmt.split('\\').last().expect("Empty use statement");
[INFO] [stdout] 556 +             let ending = use_stmt.split('\\').next_back().expect("Empty use statement");
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]    --> src/indexing/parser.rs:581:23
[INFO] [stdout]     |
[INFO] [stdout] 581 |           let keyword = match match_keyword(&token) {
[INFO] [stdout]     |  _______________________^
[INFO] [stdout] 582 | |             Some(keyword) => keyword,
[INFO] [stdout] 583 | |             None => return None,
[INFO] [stdout] 584 | |         };
[INFO] [stdout]     | |_________^ help: try instead: `match_keyword(&token)?`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout]     = note: `#[warn(clippy::question_mark)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]   --> src/indexing/tokenizer.rs:46:20
[INFO] [stdout]    |
[INFO] [stdout] 46 |           let char = match self.code.first() {
[INFO] [stdout]    |  ____________________^
[INFO] [stdout] 47 | |             Some(char) => char,
[INFO] [stdout] 48 | |             None => return None,
[INFO] [stdout] 49 | |         };
[INFO] [stdout]    | |_________^ help: try instead: `self.code.first()?`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/indexing/tokenizer.rs:84:16
[INFO] [stdout]    |
[INFO] [stdout] 84 |         while (!self.peek().is_some_and(|c| c == &quote_type) || escaped) && !self.code.is_empty() {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.peek().is_none_or(|c| c != &quote_type)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `match` expression can be replaced with `?`
[INFO] [stdout]    --> src/indexing/tokenizer.rs:173:20
[INFO] [stdout]     |
[INFO] [stdout] 173 |           let char = match self.next_char_opt() {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 174 | |             Some(char) => char,
[INFO] [stdout] 175 | |             None => return None,
[INFO] [stdout] 176 | |         };
[INFO] [stdout]     | |_________^ help: try instead: `self.next_char_opt()?`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: consider using `sort_by_key`
[INFO] [stdout]    --> src/interface/mod.rs:332:13
[INFO] [stdout]     |
[INFO] [stdout] 332 |             files.sort_by(|a, b| b.class.dependencies.len().cmp(&a.class.dependencies.len()));
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_sort_by)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 332 -             files.sort_by(|a, b| b.class.dependencies.len().cmp(&a.class.dependencies.len()));
[INFO] [stdout] 332 +             files.sort_by_key(|b| std::cmp::Reverse(b.class.dependencies.len()));
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.34s
[INFO] running `Command { std: "docker" "inspect" "525dee2ea29be8c20242299e61b5da5cffde1da0981c9d346ffc86e0e35a584c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "525dee2ea29be8c20242299e61b5da5cffde1da0981c9d346ffc86e0e35a584c", kill_on_drop: false }`
[INFO] [stdout] 525dee2ea29be8c20242299e61b5da5cffde1da0981c9d346ffc86e0e35a584c