[INFO] fetching crate tandem-core 0.4.6... [INFO] linting tandem-core-0.4.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate tandem-core 0.4.6 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate tandem-core 0.4.6 [INFO] finished tweaking crates.io crate tandem-core 0.4.6 [INFO] tweaked toml for crates.io crate tandem-core 0.4.6 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate tandem-core 0.4.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate tandem-core 0.4.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tandem-types v0.4.6 [INFO] [stderr] Downloaded tandem-observability v0.4.6 [INFO] [stderr] Downloaded tandem-memory v0.4.6 [INFO] [stderr] Downloaded tandem-providers v0.4.6 [INFO] [stderr] Downloaded tandem-agent-teams v0.4.6 [INFO] [stderr] Downloaded pdf-extract v0.10.0 [INFO] [stderr] Downloaded keyring v2.3.3 [INFO] [stderr] Downloaded tandem-wire v0.4.6 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.61 [INFO] [stderr] Downloaded web-sys v0.3.88 [INFO] [stderr] Downloaded secret-service v3.1.0 [INFO] [stderr] Downloaded tandem-skills v0.4.6 [INFO] [stderr] Downloaded tandem-document v0.4.6 [INFO] [stderr] Downloaded tandem-tools v0.4.6 [INFO] [stderr] Downloaded rangemap v1.7.1 [INFO] [stderr] Downloaded lopdf v0.38.0 [INFO] [stderr] Downloaded tiktoken-rs v0.6.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9841a61fd368d8e9b8cfc63f2d5491f320681e71347dbaec0beeffb50660beb [INFO] running `Command { std: "docker" "start" "-a" "b9841a61fd368d8e9b8cfc63f2d5491f320681e71347dbaec0beeffb50660beb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9841a61fd368d8e9b8cfc63f2d5491f320681e71347dbaec0beeffb50660beb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9841a61fd368d8e9b8cfc63f2d5491f320681e71347dbaec0beeffb50660beb", kill_on_drop: false }` [INFO] [stdout] b9841a61fd368d8e9b8cfc63f2d5491f320681e71347dbaec0beeffb50660beb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 669538c687c209e5d16a02fd47e7d42084cbd0cc9191279501e59f1e0d552369 [INFO] running `Command { std: "docker" "start" "-a" "669538c687c209e5d16a02fd47e7d42084cbd0cc9191279501e59f1e0d552369", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Compiling markup5ever v0.12.1 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Compiling zip v2.4.2 [INFO] [stderr] Checking pom v1.1.0 [INFO] [stderr] Checking bumpalo v3.20.2 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking ecb v0.1.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking rangemap v1.7.1 [INFO] [stderr] Checking zopfli v0.8.3 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking type1-encoding-parser v0.1.0 [INFO] [stderr] Checking adobe-cmap-parser v0.4.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking getrandom v0.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking rustix v0.37.28 [INFO] [stderr] Checking uuid v1.21.0 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking async-executor v1.14.0 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Checking codepage v0.1.2 [INFO] [stderr] Checking quick-xml v0.31.0 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking euclid v0.20.14 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking postscript v0.14.1 [INFO] [stderr] Checking cff-parser v0.1.0 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Checking linux-keyutils v0.2.4 [INFO] [stderr] Checking tempfile v3.25.0 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling sqlite-vec v0.1.6 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking nom_locate v5.0.0 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking globset v0.4.18 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Compiling html5ever v0.27.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling async-stream-impl v0.3.6 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking async-stream v0.3.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking tiktoken-rs v0.6.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Checking lopdf v0.38.0 [INFO] [stderr] Checking ignore v0.4.25 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking string_cache v0.8.9 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking calamine v0.26.1 [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking tandem-types v0.4.6 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking xml5ever v0.18.1 [INFO] [stderr] Checking tandem-skills v0.4.6 [INFO] [stderr] Checking pdf-extract v0.10.0 [INFO] [stderr] Checking tandem-agent-teams v0.4.6 [INFO] [stderr] Checking tandem-wire v0.4.6 [INFO] [stderr] Checking tracing-appender v0.2.4 [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stderr] Checking tandem-observability v0.4.6 [INFO] [stderr] Checking markup5ever_rcdom v0.3.0 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tandem-document v0.4.6 [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stderr] Checking html2md v0.2.15 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking secret-service v3.1.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking keyring v2.3.3 [INFO] [stderr] Checking tandem-providers v0.4.6 [INFO] [stderr] Checking tandem-memory v0.4.6 [INFO] [stderr] Checking tandem-tools v0.4.6 [INFO] [stderr] Checking tandem-core v0.4.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine_loop.rs:1292:29 [INFO] [stdout] | [INFO] [stdout] 1292 | / ... if requested_write_required [INFO] [stdout] 1293 | | ... && write_tool_attempted_in_cycle [INFO] [stdout] 1294 | | ... && productive_write_tool_calls_total == 0 [INFO] [stdout] 1295 | | ... && is_write_invalid_args_failure_kind( [INFO] [stdout] ... | [INFO] [stdout] 1322 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1297 ~ ) [INFO] [stdout] 1298 ~ && required_write_retry_count + 1 < strict_write_retry_max_attempts [INFO] [stdout] 1299 | { [INFO] [stdout] ... [INFO] [stdout] 1319 | continue; [INFO] [stdout] 1320 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/engine_loop.rs:4494:17 [INFO] [stdout] | [INFO] [stdout] 4494 | !(trimmed.is_empty() && !trimmed.starts_with('{')) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!trimmed.is_empty() || trimmed.starts_with('{')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/storage.rs:120:10 [INFO] [stdout] | [INFO] [stdout] 120 | .or_insert_with(SessionMeta::default); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/storage.rs:149:21 [INFO] [stdout] | [INFO] [stdout] 149 | / if let MessagePart::ToolInvocation { [INFO] [stdout] 150 | | args: existing_args, [INFO] [stdout] 151 | | .. [INFO] [stdout] 152 | | } = existing [INFO] [stdout] ... | [INFO] [stdout] 161 | | return; [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/storage.rs:138:29 [INFO] [stdout] | [INFO] [stdout] 138 | if let Some(existing) = message.parts.iter_mut().rev().find(|existing| { [INFO] [stdout] | ^^^^^^^^ replace this binding [INFO] [stdout] ... [INFO] [stdout] 149 | if let MessagePart::ToolInvocation { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 150 | | args: existing_args, [INFO] [stdout] 151 | | .. [INFO] [stdout] 152 | | } = existing [INFO] [stdout] | |_____________________^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/storage.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | / if let MessagePart::ToolInvocation { [INFO] [stdout] 178 | | args: existing_args, [INFO] [stdout] 179 | | result: existing_result, [INFO] [stdout] 180 | | error: existing_error, [INFO] [stdout] ... | [INFO] [stdout] 199 | | return; [INFO] [stdout] 200 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/storage.rs:166:29 [INFO] [stdout] | [INFO] [stdout] 166 | if let Some(existing) = message.parts.iter_mut().rev().find(|existing| { [INFO] [stdout] | ^^^^^^^^ replace this binding [INFO] [stdout] ... [INFO] [stdout] 177 | if let MessagePart::ToolInvocation { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 178 | | args: existing_args, [INFO] [stdout] 179 | | result: existing_result, [INFO] [stdout] 180 | | error: existing_error, [INFO] [stdout] 181 | | .. [INFO] [stdout] 182 | | } = existing [INFO] [stdout] | |_____________________^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)` [INFO] [stdout] --> src/tool_router.rs:312:10 [INFO] [stdout] | [INFO] [stdout] 312 | .filter_map(|ch| { [INFO] [stdout] | __________^ [INFO] [stdout] 313 | | if ch.is_alphanumeric() || ch.is_whitespace() { [INFO] [stdout] 314 | | Some(ch) [INFO] [stdout] 315 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 318 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/engine_loop.rs:1292:29 [INFO] [stdout] | [INFO] [stdout] 1292 | / ... if requested_write_required [INFO] [stdout] 1293 | | ... && write_tool_attempted_in_cycle [INFO] [stdout] 1294 | | ... && productive_write_tool_calls_total == 0 [INFO] [stdout] 1295 | | ... && is_write_invalid_args_failure_kind( [INFO] [stdout] ... | [INFO] [stdout] 1322 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1297 ~ ) [INFO] [stdout] 1298 ~ && required_write_retry_count + 1 < strict_write_retry_max_attempts [INFO] [stdout] 1299 | { [INFO] [stdout] ... [INFO] [stdout] 1319 | continue; [INFO] [stdout] 1320 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/engine_loop.rs:4494:17 [INFO] [stdout] | [INFO] [stdout] 4494 | !(trimmed.is_empty() && !trimmed.starts_with('{')) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!trimmed.is_empty() || trimmed.starts_with('{')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/storage.rs:120:10 [INFO] [stdout] | [INFO] [stdout] 120 | .or_insert_with(SessionMeta::default); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/storage.rs:149:21 [INFO] [stdout] | [INFO] [stdout] 149 | / if let MessagePart::ToolInvocation { [INFO] [stdout] 150 | | args: existing_args, [INFO] [stdout] 151 | | .. [INFO] [stdout] 152 | | } = existing [INFO] [stdout] ... | [INFO] [stdout] 161 | | return; [INFO] [stdout] 162 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/storage.rs:138:29 [INFO] [stdout] | [INFO] [stdout] 138 | if let Some(existing) = message.parts.iter_mut().rev().find(|existing| { [INFO] [stdout] | ^^^^^^^^ replace this binding [INFO] [stdout] ... [INFO] [stdout] 149 | if let MessagePart::ToolInvocation { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 150 | | args: existing_args, [INFO] [stdout] 151 | | .. [INFO] [stdout] 152 | | } = existing [INFO] [stdout] | |_____________________^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/storage.rs:177:21 [INFO] [stdout] | [INFO] [stdout] 177 | / if let MessagePart::ToolInvocation { [INFO] [stdout] 178 | | args: existing_args, [INFO] [stdout] 179 | | result: existing_result, [INFO] [stdout] 180 | | error: existing_error, [INFO] [stdout] ... | [INFO] [stdout] 199 | | return; [INFO] [stdout] 200 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/storage.rs:166:29 [INFO] [stdout] | [INFO] [stdout] 166 | if let Some(existing) = message.parts.iter_mut().rev().find(|existing| { [INFO] [stdout] | ^^^^^^^^ replace this binding [INFO] [stdout] ... [INFO] [stdout] 177 | if let MessagePart::ToolInvocation { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 178 | | args: existing_args, [INFO] [stdout] 179 | | result: existing_result, [INFO] [stdout] 180 | | error: existing_error, [INFO] [stdout] 181 | | .. [INFO] [stdout] 182 | | } = existing [INFO] [stdout] | |_____________________^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.filter_map(..)` can be written more simply using `.filter(..)` [INFO] [stdout] --> src/tool_router.rs:312:10 [INFO] [stdout] | [INFO] [stdout] 312 | .filter_map(|ch| { [INFO] [stdout] | __________^ [INFO] [stdout] 313 | | if ch.is_alphanumeric() || ch.is_whitespace() { [INFO] [stdout] 314 | | Some(ch) [INFO] [stdout] 315 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 318 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stdout] = note: `#[warn(clippy::unnecessary_filter_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `Command { std: "docker" "inspect" "669538c687c209e5d16a02fd47e7d42084cbd0cc9191279501e59f1e0d552369", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "669538c687c209e5d16a02fd47e7d42084cbd0cc9191279501e59f1e0d552369", kill_on_drop: false }` [INFO] [stdout] 669538c687c209e5d16a02fd47e7d42084cbd0cc9191279501e59f1e0d552369