[INFO] fetching crate syslog_rfc3164 0.1.0... [INFO] linting syslog_rfc3164-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate syslog_rfc3164 0.1.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate syslog_rfc3164 0.1.0 [INFO] finished tweaking crates.io crate syslog_rfc3164 0.1.0 [INFO] tweaked toml for crates.io crate syslog_rfc3164 0.1.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate syslog_rfc3164 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding time v0.1.45 (available: v0.3.47) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded timeit v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9bac617c114db50be3c3f1d51733cd33ef5649898a7e8e87dc9b2de8b471c64a [INFO] running `Command { std: "docker" "start" "-a" "9bac617c114db50be3c3f1d51733cd33ef5649898a7e8e87dc9b2de8b471c64a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9bac617c114db50be3c3f1d51733cd33ef5649898a7e8e87dc9b2de8b471c64a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9bac617c114db50be3c3f1d51733cd33ef5649898a7e8e87dc9b2de8b471c64a", kill_on_drop: false }` [INFO] [stdout] 9bac617c114db50be3c3f1d51733cd33ef5649898a7e8e87dc9b2de8b471c64a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8b509f32df4c6995f17a795b9b0aee87f83228ba14028945e3ad2e82b66e187d [INFO] running `Command { std: "docker" "start" "-a" "8b509f32df4c6995f17a795b9b0aee87f83228ba14028945e3ad2e82b66e187d", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking timeit v0.1.2 [INFO] [stderr] Checking syslog_rfc3164 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 269 | timestamp: timestamp, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:270:9 [INFO] [stdout] | [INFO] [stdout] 270 | hostname: hostname, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | proc_id: proc_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `proc_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | tag: tag, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | msg: msg, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `match_default_bindings` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | #![feature(match_default_bindings)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:269:9 [INFO] [stdout] | [INFO] [stdout] 269 | timestamp: timestamp, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:270:9 [INFO] [stdout] | [INFO] [stdout] 270 | hostname: hostname, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:271:9 [INFO] [stdout] | [INFO] [stdout] 271 | proc_id: proc_id, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `proc_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | tag: tag, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/parser.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | msg: msg, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `match_default_bindings` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | #![feature(match_default_bindings)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/parser.rs:111:42 [INFO] [stdout] | [INFO] [stdout] 111 | let (res, rest1) = take_while(s, |c| c >= 'A' && c <= 'z', 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('A'..='z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/parser.rs:132:42 [INFO] [stdout] | [INFO] [stdout] 132 | let (res, rest1) = take_while(s, |c| c >= '0' && c <= '9', max_digits); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/parser.rs:150:26 [INFO] [stdout] | [INFO] [stdout] 150 | return Ok((None, &rest[1..])); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/parser.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | if rest.starts_with('-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 149 ~ if let Some() = rest.strip_prefix('-') { [INFO] [stdout] 150 ~ return Ok((None, )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/parser.rs:187:26 [INFO] [stdout] | [INFO] [stdout] 187 | return Ok((None, &m[1..])); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/parser.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | if m.starts_with('-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 186 ~ if let Some() = m.strip_prefix('-') { [INFO] [stdout] 187 ~ return Ok((None, )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/parser.rs:211:26 [INFO] [stdout] | [INFO] [stdout] 211 | return Ok((None, &m[1..])); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/parser.rs:210:5 [INFO] [stdout] | [INFO] [stdout] 210 | if m.starts_with('-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 210 ~ if let Some() = m.strip_prefix('-') { [INFO] [stdout] 211 ~ return Ok((None, )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/parser.rs:111:42 [INFO] [stdout] | [INFO] [stdout] 111 | let (res, rest1) = take_while(s, |c| c >= 'A' && c <= 'z', 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('A'..='z').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/parser.rs:132:42 [INFO] [stdout] | [INFO] [stdout] 132 | let (res, rest1) = take_while(s, |c| c >= '0' && c <= '9', max_digits); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `('0'..='9').contains(&c)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/parser.rs:150:26 [INFO] [stdout] | [INFO] [stdout] 150 | return Ok((None, &rest[1..])); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/parser.rs:149:5 [INFO] [stdout] | [INFO] [stdout] 149 | if rest.starts_with('-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 149 ~ if let Some() = rest.strip_prefix('-') { [INFO] [stdout] 150 ~ return Ok((None, )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/parser.rs:187:26 [INFO] [stdout] | [INFO] [stdout] 187 | return Ok((None, &m[1..])); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/parser.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 186 | if m.starts_with('-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 186 ~ if let Some() = m.strip_prefix('-') { [INFO] [stdout] 187 ~ return Ok((None, )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/parser.rs:211:26 [INFO] [stdout] | [INFO] [stdout] 211 | return Ok((None, &m[1..])); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/parser.rs:210:5 [INFO] [stdout] | [INFO] [stdout] 210 | if m.starts_with('-') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 210 ~ if let Some() = m.strip_prefix('-') { [INFO] [stdout] 211 ~ return Ok((None, )); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:347:34 [INFO] [stdout] | [INFO] [stdout] 347 | let res = parse_hostname(&data); [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:381:17 [INFO] [stdout] | [INFO] [stdout] 381 | assert!(!msg.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `msg.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `Command { std: "docker" "inspect" "8b509f32df4c6995f17a795b9b0aee87f83228ba14028945e3ad2e82b66e187d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b509f32df4c6995f17a795b9b0aee87f83228ba14028945e3ad2e82b66e187d", kill_on_drop: false }` [INFO] [stdout] 8b509f32df4c6995f17a795b9b0aee87f83228ba14028945e3ad2e82b66e187d